Commit Graph

735 Commits

Author SHA1 Message Date
abhishek d96a1a841d adding logic to prevent commands from being sent to the pool when it is NOT up; also adding better thread safety and db locking, along with a general refactor 2010-11-04 13:35:57 -07:00
abhishek 89f0c455e3 fixing the vm creation issue 2010-11-04 10:47:59 -07:00
nit 7dc7a4838a bug 4286: Fixing the extract functionality for Upload after new API framework. Also added a check to avoid system created templates and ISO's from getting extracted as per Mike.
status 4286: resolved fixed
2010-11-04 19:09:38 +05:30
abhishek 84ee08430a making changes to the list zones flow, to add the domain name to the table, and return it 2010-11-03 22:08:32 -07:00
Alex Huang e27bb550fe Harmony among gurus 2010-11-03 21:18:31 -07:00
alena 52a8370102 bug 6955: return embedded object for PreparePrimaryStorageForMaintenance
status 6955: resolved fixed
2010-11-03 14:30:35 -07:00
edison f3cc113525 bug 6933: send the snapshot related command to host on which vm created for kvm
status 6933: resolved fixed
2010-11-03 13:03:21 -07:00
abhishek 426e445811 bug 6904: during volume creation, we were NOT converting the size of the parent disk offering (which is in MB), to bytes. This is the size used to create the volume. I am adding the appropriate multipliers. Other flows like creating volume from snapshot etc should remain unaffected, as the parent volume created from the disk offering will be set right.
status 6904: resolved fixed
2010-11-03 11:13:06 -07:00
Kelven Yang 3c6b3b3e3d Add more volume info to BackupSnapshotCommand, to generalize multi-hypervisor usage 2010-11-02 17:04:07 -07:00
Alex Huang 5fe5450abc even more refactoring 2010-11-02 15:25:07 -07:00
Alex Huang 560d7a275e Removed InternalErrorException. Renamed the lock methods on the DAO objects to be more understandable. 2010-11-02 12:25:08 -07:00
Alex Huang 3279c26796 Removed a bunch of InternalErrorException 2010-11-02 12:25:08 -07:00
Kris McQueen 519633cd38 bug 6763: restore the volume lock when creating a snapshot for the volume to ensure only one thread is creating the snapshot at a time. 2010-10-29 13:53:00 -07:00
nit c9069303ce Code clean up for Extract functionality and making it more robust. 2010-10-28 18:45:12 +05:30
Alex Huang 4f9f249218 make console proxy work again with the new network configuration 2010-10-26 17:37:29 -07:00
Kris McQueen 28bcbc3bdd bug 6732: there is no longer a manual policy, so add in special handling for deleting manual snapshots. Also, in the process of deleting the snapshot, the snapshot might need to be retrieved from the database, so be sure to find including removed.
status 6732: resolved fixed
2010-10-26 16:47:21 -07:00
Kris McQueen 8fafc892d3 bug 6730: if a volume was never attached to a VM, then the poolId will be null and this will be flagged as not on shared storage. Since the code was deleting detached volumes only on shared storage, the never-attached volume was in an undeletable state. Instead, allow deletion of any detached volume, regardless of storage pool until some technical reason limits this from happening.
Also, the UI was not allowing volumes to be deleted due to a bug in looking at the vmname property of the volume.  The 'if' conditional always returned true that the volume was attached to a VM to due a boolean logic error.

status 6730: resolved fixed
2010-10-26 14:56:44 -07:00
Alex Huang 2bc938c3f8 checkins for problems. 2010-10-26 09:35:24 -07:00
nit 497c60d63d Extending extract functionlity for volumes to allow download. The
extraction can have two modes FTP_UPLOAD and HTTP_DOWNLOAD. In the former one
the user would provide the ftp url where the entity needs to be uploaded and in
the later the user would be provided a HTTP URL where from he/she can download
the entity. This url would be exposed for a specific time limit and would not
function after the time limit
2010-10-26 18:49:43 +05:30
Jessica Wang 958aaaaf87 new UI - instance page - refactor submenu. 2010-10-22 20:23:05 -07:00
Kris McQueen 365ac7501f bug 6672: Fix up volume commands. For createVolume, the command is supposed to create a database object, but not assign it to a storage pool until the user first attaches it to a vm instance. That allows the volume to start off hypervisor agnostic. For attachVolume, detachVolume, and listVolumes, the responses had minor issues (sourceType could be null, for example) in either the response generation, or the response handling by the UI.
status 6672: resolved fixed
2010-10-21 15:15:01 -07:00
Alex Huang d5d8f27cad Added more changes to the api 2010-10-21 15:11:49 -07:00
nit 6723549fc7 bug 6399: extending extract functionlity for templates and ISO's to allow download. The extraction can have two modes FTP_UPLOAD and HTTP_DOWNLOAD. In the former one the user would provide the ftp url where the entity needs to be uploaded and in the later the user would be provided a HTTP URL where from he/she can download the entity. This url would be exposed for a specific time limit and would not function after the time limit. 2010-10-20 11:40:03 +05:30
Alex Huang 794ca16a65 Added code to start domR 2010-10-19 11:52:01 -07:00
Chiradeep Vittal 4d37269961 fix local disk for system vms 2010-10-19 09:53:51 -07:00
Kelven Yang 2c919c5c01 Make unique name conforming with the name generated in template installation for routing template, some other minor fixes 2010-10-15 16:36:02 -07:00
anthony d41f7d78d9 DeleteStoragePool command fix
1. not delete SR in xenserver side, only delete it in database.
    2. remove a storagepool,  adding it back fails
2010-10-15 14:15:55 -07:00
Kris McQueen 8e086d7a21 resolving merge conflicts between 2.1.refactor and master 2010-10-12 16:28:16 -07:00
Kris McQueen 2740ba6c40 final merge of master->2.1.refactor preparing for merge back into master 2010-10-12 14:46:24 -07:00
Alex Huang ce091de3d2 more changes for refactor 2010-10-12 07:17:47 -07:00
anthony a93d36d81a should use _hostDao.listByCluster instead of _hostDao.listByPodId in some places 2010-10-08 18:10:15 -07:00
edison 2f39664f94 maybe it was an incorrect merge that snapshot was disabled for KVM
Re-enable it.
2010-10-07 18:56:42 -07:00
edison 3028dab141 fix systemvm template in direct attached mode, guest vm can't get gateway and dns server 2010-10-07 16:32:46 -07:00
Kris McQueen ec62ef3cd7 Injection doesn't work on private methods, restore the visibility of the methods so injection works. 2010-10-06 18:25:58 -07:00
Alex Huang 9d1270b35f console proxy started completely and running 2010-10-06 17:22:35 -07:00
anthony 0cb11027e9 back port from 2.1.x 2010-10-06 15:18:23 -07:00
Kris McQueen 9c593352d0 Fixing events for async jobs so that there's a scheduled event recorded with appropriate type/description whenever the API framework schedules the async command to run. A few miscellaneous fixes as well uncovered during regression testing (router response was not parsed correctly by UI, etc.) 2010-10-05 20:26:18 -07:00
Alex Huang 00f8de2687 console proxy vm is now started 2010-10-04 17:59:06 -07:00
Alex Huang 5f88268ef2 console proxy vm is now started but it is not reading the disk correctly 2010-10-04 17:59:06 -07:00
Alex Huang 652d86956c more files checked in 2010-10-04 12:04:59 -07:00
nit 09768ca751 bug 5363: Adding Scheduled and Started event for SNAPSHOT.CREATE.
status 5363: resolved fixed
2010-10-04 19:51:19 +05:30
edison b441deec94 Need to set all the system vms as read state 2010-09-30 20:39:34 -07:00
edison 26807bc701 bug 6362: Need to call guestos.getDisplayName to the guest os name now.
status 6362: resolved fixed
2010-09-30 12:26:37 -07:00
edison 7615f569ff after rebase, fix bugs 2010-09-29 18:41:55 -07:00
edison ad1ef80459 Now we have multiple routing template and buitin templates now, refactor template download code, that can handle it.
Basically, change the meaning of type field in template table: SYSTEM means sytem vm template, BUILIIN means buildin templates.
2010-09-29 18:41:55 -07:00
edison fb9f43d807 clean up hypervisor.type, actually hypevisor.type may only make sense on the UI in multi-hypervisor.
In our java code, we should not write code based on hypervisor.type.
2010-09-29 18:41:54 -07:00
edison 6fc7528809 create data volume is splitted into two stage:
1. create a volume entry in the database,
2. when user attaching the volume to a VM, then actually create the volume on storage pool.
2010-09-29 18:41:54 -07:00
edison 9e0f57bc0e change code for new UI 2010-09-29 18:40:52 -07:00
edison 8943cc6745 create volume
Conflicts:

	api/src/com/cloud/vm/VmCharacteristics.java
	core/src/com/cloud/dc/ClusterVO.java
	core/src/com/cloud/server/ManagementServer.java
	server/src/com/cloud/network/NetworkManager.java
	server/src/com/cloud/storage/allocator/AbstractStoragePoolAllocator.java
2010-09-29 18:40:51 -07:00
Kelven Yang 2337a9d99f Fix a NPE in AbstractStoragePoolAllocator.java when creating standalone volume 2010-09-29 18:40:51 -07:00
Kelven Yang 72e8b767fe Mount secondary storage as a datastore to implement ISO attachment 2010-09-29 18:40:50 -07:00
Kelven Yang 9db2925b77 Make database config recognize service offering change 2010-09-29 18:40:49 -07:00
edison b3427fc634 don't remove template 2010-09-29 18:40:48 -07:00
edison edb16aa117 change storage allocator policy based on hypervisor 2010-09-29 18:40:47 -07:00
edison 3aef9f408e step1 2010-09-29 18:40:47 -07:00
anthony b8c8aacca3 bug 6326: correctly update poolsToAvoid
status 6326: resolved fixed
2010-09-29 18:38:01 -07:00
anthony bca96b1079 pass guest OS name instead of guest ID when start system VM 2010-09-29 17:18:27 -07:00
anthony be5fa82229 remove snapshotpolicyRef 2010-09-29 16:24:57 -07:00
anthony 5b75f8e03b bug 6365: find policy from volumeId instead of snapshotID
status 6365: resolved fixed
2010-09-29 15:25:46 -07:00
kishan 153dca3ddf bug 6195: removed service offering Id for ROOT volumes in usage data 2010-09-29 18:29:07 +05:30
anthony 319d4f1aa0 snapshot redesign
1. use full snapshot and delta snapshot, there are maxsnashot/2 of delta snapshot between two full snapshot
2. only support one policy for one volume
3. remove all coleases in secondary storage.
2010-09-28 18:37:46 -07:00
Kris McQueen 848ce60097 Merging master into 2.1.refactor, resolve the merge conflicts as best I can. New commands related to extracting template/iso/volume and related to instance groups were refactored to the new API framework. 2010-09-28 15:47:14 -07:00
Chiradeep Vittal f1b0e4b811 tweaks for debian system vm 2010-09-27 18:04:49 -07:00
Alex Huang c443867f28 more changes 2010-09-27 15:14:38 -07:00
abhishek 7abda2ee2d bug 6291: generating some events whilst starting vms, wrt volume creation
status 6291: resolved fixed
2010-09-24 15:50:33 -07:00
Alex Huang 42986f43ba removed service offering from storageallocator 2010-09-24 10:27:02 -07:00
Kris McQueen 2a4ddac41a Change getResponse() to return a ResponseObject so that the caller can choose how to serialize. This in in preparation for serializing the async commands to the database with class information and deserializing them into the ResponseObject itself when queryAsyncJobResult is called. Once the ResponseObject is deserialized, the proper string can be returned to the caller.
The previous behavior had the JSON response from the command embedded into the queryAsyncJobResult response as a string rather than a JSON object which prevented the client from being able to read the response.  With this new behavior an actual JSON object should be returned which can then be parsed on the client side.
2010-09-23 17:34:28 -07:00
anthony c9ae6fd09d record used byte not available byte 2010-09-23 16:25:17 -07:00
alena 0f2f356874 bug 6277: listVirtualMachines with group=-1 would return all vms that don't belong to any group. As a part of the fix, changed Dao layer to be able to make different types of Joins - Inner, Right, Left, etc.
status 6277: resolved fixed
2010-09-23 10:43:17 -07:00
anthony abaa66f6e3 bug 6181: ingore provisioning factor for iscsi primary storage
status 6181: resolved fixed
2010-09-22 20:39:57 -07:00
Alex Huang 286e78c849 moved account id, service offering id, and domain id into isntance 2010-09-22 10:43:59 -07:00
nit 4ae9e1c593 bug 4144: : send an Alert when template sync deletes a template from the secondary storage due to no record of the template in the db.
status 4144: resolved fixed
2010-09-22 14:37:40 +05:30
Kris McQueen c32d6e7524 Template id is not a required parameter when listing templates. The proper serialized name for the async job id is jobid, not id. Sadly, ctxAccoutId != ctxAccountId, ugh, no wonder the UserContext wasn't getting set up correctly. Clean up some miscellaneous unnecessary casts. 2010-09-21 17:00:50 -07:00
anthony fb628a1929 add rate limit for system VM, after you change rate limit, you need to restart managementserver to make it effect 2010-09-21 12:25:53 -07:00
kishan 85964511b2 bug 6195,6255,5891: Only ROOT volumes will have templateId. offeringId will be diskOfferingId for DATA volumes and serviceOfferingId for ROOT volume
status 6195,6255,5891: resolved fixed
2010-09-21 15:46:55 +05:30
nit 0669c2c1d4 Merge branch 'master' of ssh://git.cloud.com/var/lib/git/cloudstack-oss 2010-09-21 13:37:47 +05:30
nit 7ff551bd5c bug 4286: Extract functionality - code cleanup 2010-09-21 13:36:57 +05:30
Kris McQueen ebd06ae6f3 List clusters was using the name of the command rather than the name of the cluster to search for clusters, which was resulting in no clusters returned. Fixed. CreateStoragePool was returning an array of one pool every time, simplified it to just return the pool and changed the UI to expect one pool rather than an array. Fixed the backend code for creating a storage pool to (a) generate a UUID based on host name, path, and a timestamp and (b) to list only active storage pools when checking for duplicates. This allows a storage pool to be create with the same path as a pool that had previously been deleted. 2010-09-20 19:08:52 -07:00
anthony ccc166f4ac if no private ip or public ip, send correct message to UI 2010-09-20 17:17:20 -07:00
nit 33e683e2c7 bug 4286: Making ExtractVolumeCommand async and some code cleanup 2010-09-19 18:34:12 +05:30
Kris McQueen 1f4b2cfb06 Async commands need to have a start event id for event tracking. 2010-09-17 12:07:16 -07:00
nit 48cd102ab9 Merge branch 'master' of ssh://git.cloud.com/var/lib/git/cloudstack-oss 2010-09-17 17:04:35 +05:30
nit 636dc041c7 bug 4286: Making extractIsoCmd and extractTemplateCmd async 2010-09-17 17:04:07 +05:30
Alex Huang 131e487c32 allocation complete. Moving on to actual create and deploy 2010-09-16 12:01:56 -07:00
Alex Huang 327924a9ad More changes for refactoring 2010-09-15 18:00:54 -07:00
nit f5ac46255c bug 4286: Schema changes to include the upload table, Introducing extractIso command and extractVolume command 2010-09-15 17:51:42 +05:30
Kris McQueen df10af0688 cleaning up imports, fixing up some compilation problems related to API refactoring 2010-09-13 15:25:46 -07:00
Kris McQueen 449d1f3acf working through some compilation errors that have arisen due to all the API refactoring... 2010-09-13 14:46:23 -07:00
abhishek a03cf45e5d further improvements to the sp code, especially for the local storage case 2010-09-13 12:00:54 -07:00
abhishek 542230fc26 null check for the npe 2010-09-13 09:35:28 -07:00
Kris McQueen 1e46e2e588 refactoring createVolume to new API framework 2010-09-10 23:25:22 -07:00
abhishek 93261c4eb8 bug 5147: Improvements after testing the storage maintenance across multiple sp's, with sys vms scattered across multiple sps 2010-09-10 13:44:39 -07:00
Kris McQueen 037f1ff327 Refactoring createSnapshot to new API framework. 2010-09-09 18:58:37 -07:00
abhishek 8d38e230a5 bug 5147: we ensure that if the sp under maintenance is the only one in the cluster, we just stop the vms with no migration (base case) 2010-09-09 18:34:44 -07:00
abhishek 20973d48af bug 5147: implementing the recommendations i got for the ps maintenance. For now, we are not implementing the cancel maintenance part. Instead, we are going to ask the admin if he is "sure" of enabling maintenance on a sp, before proceeding 2010-09-09 18:05:43 -07:00
root 76e5cf3321 renamed dao methods to correctly reflect what they do 2010-09-09 18:01:50 -07:00
alena 3659b7b207 Code cleanup - deleted code that was commented out and unused imports. 2010-09-09 16:07:29 -07:00
anthony bce314b131 fixed a bug about snapshot 2010-09-09 15:11:34 -07:00
Alex Huang 7249f168d5 more file changes 2010-09-09 13:27:20 -07:00
Alex Huang 6134f7dfd2 more file changes 2010-09-09 11:52:12 -07:00
alena b0aa28032c Refactored DeleteIPForwardingRule/UpdateIPForwardingRule commands to new api framework. 2010-09-08 19:03:42 -07:00
alena c0185e713a Refactored AttachVolume/PrepareForMaintenance/CancelMaintenance/PreparePrimaryStorageForMaintenance/CancelPrimaryStorageMaintenance commands. 2010-09-08 12:18:46 -07:00
Kris McQueen 614c3fa502 Refactor listSnapshots to new API framework. Also some minor code cleanup. 2010-09-07 18:41:52 -07:00
Kris McQueen 3b703c76cf Refactor listSnapshotPolicies to new API framework. 2010-09-07 17:46:55 -07:00
Kris McQueen f653e54ce6 Refactoring listRecurringSnapshotSchedule to new API framework. 2010-09-07 14:56:50 -07:00
anthony c65175aa40 bug 6048: Check createvolume's return
status 6048: resolved fixed
2010-08-31 13:05:42 -07:00
Kelven Yang 7eb61b705a Allow NetworkManagerImpl and SecondaryStorageImpl to tolerate missing of system vm template at startup 2010-08-27 16:32:03 -07:00
abhishek 742869b750 Refactoring the delete snapshot command. This has a lot of spaghetti calls, trying my best to make it works. Hopefully it all does, on the 1st pass 2010-08-27 11:26:14 -07:00
abhishek 3d8a3ef358 Refactoring the snapshot policies cmd 2010-08-26 17:17:30 -07:00
abhishek 7f7a342cbe Refactoring the delete volume command 2010-08-26 14:31:25 -07:00
abhishek 604e7016a3 Incremental checkin 2010-08-26 14:18:36 -07:00
edison 3ab4651cf0 Issue #: 5978 5977 5971 5972
Status 5978: resolved fixed
Status 5977: resolved fixed
Status 5971: resolved fixed
Status 5972: resolved fixed
2010-08-25 15:27:34 -07:00
Kelven Yang 0682d70ce6 add correct check sum to default vmware template records
Let StoragePoolMonitor be aware of vmware hypervisor
2010-08-25 11:07:27 -07:00
Alex Huang fb389e8cd6 Merge branch 'master' of ssh://git.cloud.com/var/lib/git/cloudstack-oss 2010-08-24 00:01:09 -07:00
abhishek 7454f0f24a Incremental checkin for volume lineage 2010-08-23 16:02:45 -07:00
Alex Huang e0165dd2ef my changes 2010-08-23 13:59:23 -07:00
abhishek fcdeb5a97d Incremental checkin 2010-08-19 14:40:08 -07:00
Kris McQueen 4c86af9901 cleaning up imports 2010-08-18 19:12:27 -07:00
Kris McQueen 78445d8348 Refactoring createStoragePool to new API framework. The logic was always in StoragePoolManager, mostly removed the management server proxy method which called into StoragePoolManager. There is still an outstanding TODO for this API in terms of the response. Once the storage pool has been added, there is a query for the allocated bytes on the pool in order to return proper storage stats. Hooking into this query to get the right data needs to be done. 2010-08-18 19:11:01 -07:00
Kris McQueen b0668df1b9 refactoring createSnapshotPolicy to new API framework...since this is a basic database create just move parameter validation to SnapshotManager and save the snapshot policy in the database 2010-08-18 19:08:23 -07:00
Kris McQueen da03aee028 Add snapshot manager to the list of managers that can be invoked through the API. This prepares the way for refactoring createSnapshot, but since the method is an async create that also needs to create a policy first and generally does not follow any other patters, I'll do this one last. 2010-08-18 19:08:23 -07:00
alena 46c331b54b Merge branch '2.1.refactor' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 2.1.refactor
Conflicts:
	server/src/com/cloud/storage/StorageManagerImpl.java
2010-08-18 15:52:23 -07:00
alena f1b95641cb Refactor api deletePool, addHost, addSecondaryStorage 2010-08-18 15:41:16 -07:00
abhishek 716271fca1 Merge branch '2.1.refactor' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 2.1.refactor 2010-08-18 14:05:45 -07:00
abhishek aa6e9ab2bb Refactoring the startvm command 2010-08-18 14:01:15 -07:00
Alex Huang b250b985ec changes 2010-08-18 12:19:22 -07:00
alena e2950eb5a1 Merge branch '2.1.refactor' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 2.1.refactor
Conflicts:
	server/src/com/cloud/api/BaseCmd.java
	server/src/com/cloud/network/security/NetworkGroupManagerImpl.java
2010-08-18 11:36:05 -07:00
alena 3d85fdf687 API refactor 2010-08-18 11:24:29 -07:00
abhishek 1174486e27 Refactoring into server project 2010-08-17 16:43:57 -07:00
abhishek 7e502768ed Incremental checkin 2010-08-17 16:07:48 -07:00
Alex Huang a89aad4d15 removed override 2010-08-17 10:16:16 -07:00
Alex Huang 867b43dcf9 more changes for the rewrite. 2010-08-16 11:28:11 -07:00
Manuel Amador (Rudd-O) 14ae76781e Committing Kris' big merge 2010-08-11 16:02:57 -07:00
Manuel Amador (Rudd-O) ac730ec496 Branch 2.1.refactor committed 2010-08-11 09:13:42 -07:00
Manuel Amador (Rudd-O) 05c020e1f6 Source code committed 2010-08-11 09:13:29 -07:00