etan39
/
cloudstack
mirror of https://github.com/apache/cloudstack.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
23,804 Commits 330 Branches 325 Tags 854 MiB
Commit Graph

8340 Commits

Author SHA1 Message Date
Nitin Mehta 1fbee507ea CLOUDSTACK-6987: Add support for storing metadata for snapshot policy and controlling policy using display flag 
(cherry picked from commit 5cf8edd7ec)

Conflicts:
	setup/db/db/schema-430to440.sql
 2014-07-30 13:24:31 +02:00
Nitin Mehta adfb44ec33 CLOUDSTACK-6597: Updatevm - root admin should be allowed to change instance name 
(cherry picked from commit 18c6ae0796)

Conflicts:
	api/src/com/cloud/event/EventTypes.java
 2014-07-30 12:52:15 +02:00
Nitin Mehta fec9ccf446 CLOUDSTACK-4364: Restore VM - log a usage event for newly created volume 
(cherry picked from commit 1e78354882)
 2014-07-28 16:02:49 +02:00
Prachi Damle 20a457dd6e CLOUDSTACK-6941: Can't choose storage for the volume, when attaching uploaded data volume to VM 
Changes:
- Only way to choose a certain storage pool is by using disk_offering_tags
- Added a parameter to take in a disk offering Id.
- Admin will have to create a custom sized disk offering and tag it as necessary for the user
- This custom offering Id should be passed during uploadVolume to associate the volume with this disk offering

(cherry picked from commit 13bd8beb91)
 2014-07-28 16:02:41 +02:00
Min Chen 30b22ae275 CLOUDSTACK-6940:Templates cannot be downloaded from URLs without 
matching file extensions.

(cherry picked from commit 008162a757)
 2014-07-28 16:02:41 +02:00
Alena Prokharchyk 388af6c349 CLOUDSTACK-6919: don't attempt to restart user vms having no Root volume attached 
(cherry picked from commit 146867eb07)
 2014-07-28 16:02:36 +02:00
Alena Prokharchyk 31ed30af56 CLOUDSTACK-6907: lisVolumes - make a decision whether to set service or disk offering in the response, based on the DiskOfferingVO type entry, not the volume Type 
(cherry picked from commit 43e479d238)
 2014-07-28 16:02:33 +02:00
Rajani Karuturi 713572887c Fixed few coverity issues unused assignments, boxing and unboxing of values etc. 
Signed-off-by: Koushik Das <koushik@apache.org>
(cherry picked from commit 32a7d5d387)
 2014-07-28 16:02:33 +02:00
Anthony Xu 9fbb35d13d fixed a typo 
(cherry picked from commit 40207929f7)
 2014-07-28 16:02:17 +02:00
Anthony Xu 742e1b1954 if networkID is not specified, get one network with free ips. 
(cherry picked from commit 8c5a9ec4de)
 2014-07-28 16:02:16 +02:00
Nitin Mehta 5c9ca6c22d CLOUDSTACK-6699: listResouceDetails - enhance it to list by (key,value) pair - allowed to Admin only. 
(cherry picked from commit d5425e1a4a)
 2014-07-28 16:02:13 +02:00
wrodrigues 3926f7e8b8 CLOUDSTACK-6139 router vm on local storage 
(cherry picked from commit 31b3f0a5ce)
 2014-07-28 16:02:05 +02:00
Daan Hoogland c9383c441e Updating pom.xml version numbers for release 4.4.1-SNAPSHOT 
Signed-off-by: Daan Hoogland <daan@onecht.net>
 2014-07-23 16:55:31 +02:00
amoghvk a72991a313 CLOUDSTACK-6358: KVM mappings for CentOS 6.x and RHEL 6.x 
(cherry picked from commit c8ca15b95a)

Conflicts:
	setup/db/db/schema-430to440.sql
 2014-07-17 23:40:49 +02:00
Alena Prokharchyk 92d1428c48 CLOUDSTACK-6595: allow to expunge the vm when its in Error state, in addition to Expunging/Destroyed states 
(cherry picked from commit 822b38761f)
 2014-07-17 09:49:29 +02:00
Prachi Damle 29b09b1e21 CLOUDSTACK-7047: DeploymentPlanner should include disabled resources only when the VM owner is Admin account 
Changes:
- removing unused imports

Conflicts:
	server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java

(cherry picked from commit f37b152489)
 2014-07-03 16:13:15 +02:00
Prachi Damle b70bd23be3 CLOUDSTACK-7047: DeploymentPlanner should include disabled resources only when the VM owner is Admin account 
Changes:
-DeploymentPlanner should include disabled resources only when the VM owner is Admin account. The disabled resources should be ignored when VM is owned by any other user.

(cherry picked from commit 40e28de727)
 2014-07-03 16:13:05 +02:00
Jayapal 09022344ee CLOUDSTACK-7027: Removing left over static nat rule 
(cherry picked from commit a69c1ee31d)
 2014-07-01 14:36:33 +02:00
Sanjay Tripathi 8f9458e517 CLOUDSTACK-6884: List Capacity API always returns GPU capacity also even if type is different. 
(cherry picked from commit 48646ae186)
 2014-06-27 09:41:52 +02:00
Ian Duffy 0296c46f09 remove unused import 
(cherry picked from commit 2bb12f2a85)
 2014-06-25 21:33:08 +02:00
Ian Duffy c70cadff0e Allow for length of password on VMs to be set via global settings 
(cherry picked from commit 96412e3e58)

Conflicts:
	setup/db/db/schema-430to440.sql
 2014-06-25 21:22:06 +02:00
Daan Hoogland 86aff86b78 CLOUDSTACK-6747: call a more forgiving test on the supplied peer 
cidr-list
(cherry picked from commit 17850c7aff)
 2014-06-25 17:18:45 +02:00
Min Chen 0d23ad903d CLOUDSTACK-6971: createAutoScaleVmProfile failed with NPE due to lack of bean 
injection.

(cherry picked from commit 31e250a9d2)
 2014-06-23 20:19:36 +02:00
Anshul Gangwar af37ade9e3 CLOUDSTACK-6830: Fixed [hyper-v] during VM migration, volumes on zone wide primary 
store requires storage migration resulting in failure of VM migration. This also
improves the hostsformigration api. Firstly we were trying to list all hosts and
then finding suitable storage pools for all volumes and then we were checking
whether vm migration requires storage migration to that host. Now the process is
updated. We are checking for only those volumes which are not in zone wide primary
store. We are verifying by comparing volumes->poolid->clusterid to host clusterid.
If it uses local or clusterids are different then verifying whether host has
suitable storage pools for the volume of the vm to be migrated too.

(cherry picked from commit 64153a4371)

Conflicts:
	engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
 2014-06-23 09:56:17 +02:00
Anshul Gangwar 1b1a417bb4 CLOUDSTACK-6968: Allowing cluster scope volumes to attach to any VM. If migration is 
needed then first they will be migrated to appropriate cluster before attaching.

(cherry picked from commit e7ba46b5f7)
 2014-06-23 09:50:31 +02:00
Kelven Yang c422933719 CLOUDSTACK-6970: Protect event interpretion from causing NPE exception 
(cherry picked from commit 06d8d3a03f)
 2014-06-20 22:31:56 +02:00
Murali Reddy 6bd9d1241b CLOUDSTACK-6750: [OVS] With stretched network deploying vm in a ovs 
disabled zone does not fail

Fix ensures that connectivity service provider is enabled in the zone on
to which nework is being streched.

(cherry picked from commit d8cbba1bc6)
 2014-06-19 15:24:05 +02:00
Jayapal 335f165b5b CLOUDSTACK-6923: updated listLBStickinessPolicies API to list using stickinesspolicy id 
(cherry picked from commit b0d726a872)

Conflicts:
	api/src/com/cloud/network/lb/LoadBalancingRulesService.java
 2014-06-18 14:12:46 +02:00
Rajesh Battala 6b9ac8be8b CLOUDSTACK-6920 Support listing of LBHealthcheck policy with LBHealthcheck policy ID 
(cherry picked from commit 21e452ff4f)

Conflicts:
	api/src/com/cloud/network/lb/LoadBalancingRulesService.java
 2014-06-18 13:21:32 +02:00
Santhosh Edukulla 61cf175f1c Coverity issues: Fixed conflicts 
Signed-off-by: Daan Hoogland <daan@onecht.net>
 2014-06-17 13:49:55 +02:00
Jayapal c82b61a92f CLOUDSTACK-6922: Updated events for firewall ingress and egress 
(cherry picked from commit 2214bd2502)

Conflicts:
	api/src/com/cloud/event/EventTypes.java
 2014-06-17 13:21:50 +02:00
amoghvk f8fe4c8795 CLOUDSTACK-6915: Include searching deleted OS entries 
(cherry picked from commit de04881da1)
 2014-06-17 08:22:27 +02:00
Santhosh Edukulla 87c3d77518 Fixed coverity issues 
(cherry picked from commit 4ba3aae2ea)
 2014-06-12 14:44:26 +02:00
Jayapal 80d8cef240 CLOUDSTACK-6899: Added vmId in listnics response 
(cherry picked from commit e9f60ee292)
 2014-06-12 14:18:42 +02:00
Santhosh Edukulla ce334b4ee5 CLOUDSTACK-6791 Fixed the issue 
(cherry picked from commit 62cc238e12)
 2014-06-12 13:43:44 +02:00
Saksham Srivastava 40d3503760 CLOUDSTACK-6812: Do not allow edit of storage.overprovision.factor for non supported types 
(cherry picked from commit f14f36170e)
 2014-06-12 12:25:55 +02:00
Saksham Srivastava 9771e79b1b CLOUDSTACK-6654: Configkey parameters are not validated 
(cherry picked from commit 5bcd017de6)
 2014-06-12 12:25:14 +02:00
Saksham Srivastava 23b7993d58 CLOUDSTACK-6864: UploadSSlCert API requires double encoding of URL params 
(cherry picked from commit c5ee5ad5c8)
 2014-06-12 12:23:52 +02:00
Nitin Mehta a1ab3364f4 CLOUDSTACK-6895: 1. Populate firstclass entities as uuids in the context instead of dbids for performance. 
2. Add ctxDetails in the ParamGenericValidationWorker to avoid warning for api validation
3. Add some missing events.
4. Correcting mapping for ResourceObjectType.NetworkACL and ResourceObjectType.NetworkACLItem

(cherry picked from commit 8a9092c3cd)

Conflicts:
	api/src/com/cloud/event/EventTypes.java
	api/src/org/apache/cloudstack/api/BaseCmd.java
 2014-06-12 12:18:12 +02:00
Harikrishna Patnala 0667f678b8 CLOUDSTACK-6869: SSH Public key content is overridden by template's meta data when you create a instance 
(cherry picked from commit aa75b43885)
 2014-06-11 16:10:49 +02:00
Olivier Lemasle c934e7b052 CLOUDSTACK-6850: Return cpu cores, cpu speed and memory in listUsageRecords 
Signed-off-by: Sebastien Goasguen <runseb@gmail.com>
(cherry picked from commit a1f278e9d4)
 2014-06-10 13:39:43 +02:00
sedukull 6c0b43431f CLOUDSTACK-6793: Fixed an invalid Domain Id Issue 
Signed-off-by: sedukull <santhosh.edukulla@gmail.com>
(cherry picked from commit 91d054cb00)
 2014-06-06 15:54:45 +02:00
Alena Prokharchyk 0b08d5319c Fixed unittest 
(cherry picked from commit 96bfa8a73f)
 2014-06-06 13:43:56 +02:00
Koushik Das 5fe7eb3357 CLOUDSTACK-6843: [Automation] List listServiceOfferings api fails with NPE 
Incorrect parameter name used in query building resulted in a bad sql query.

(cherry picked from commit 025c143ac7)
 2014-06-05 15:51:39 +02:00
Rajesh Battala 1f7d2ee091 CLOUDSTACK-6833 [Hyper-V] Volume snapshot creation returns success even though snapshots are not supported for Hyper-V 
(cherry picked from commit 945e879bf2)
 2014-06-05 12:21:14 +02:00
Edison Su 3f0dcc76ae CLOUDSTACK-5505: if vpc public network with snat enabled, then will triger this issue 
(cherry picked from commit 5e80e5d33d)
 2014-06-04 09:26:25 +02:00
Nitin Mehta 9286417f05 CLOUDSTACK-6599: 
1. Adding the missing Template/Volume URLs expiration functionality
2. Improvement - While deleting the volume during expiration use rm -rf as vmware now contains directoy
3. Improvement - Use standard Answer so that the error gets logged in case deletion of expiration link didnt work fine.
4. Improvement - In case of domain change, expire the old urls

(cherry picked from commit 48ea9e0b5e)
 2014-06-03 10:02:06 +02:00
Hiroki Ohashi 58d4a2400a Allow usaage reporting on removed service offering 2014-05-29 19:13:39 +02:00
Rajani Karuturi df42ce903d Fixed CLOUDSTACK-6756: usage id is not being returned for an ip in deleted ip range 2014-05-27 10:37:55 +02:00
Daan Hoogland 6f2ee6daac CLOUDSTACK-6485 prevent ipaddress asignment of gateway to gateway-interface on vpc router 2014-05-24 19:45:18 +02:00
Min Chen f002e4d161 CLOUDSTACK-6752: IAM command class separation caused ApiDoc warning of 
duplicated cmd class for the same api name.
 2014-05-23 10:10:12 +02:00
Amogh Vasekar b0b71e59e9 CLOUDSTACK-6671: Fixing NPE when a mapping is missing 
Adding missing KVM mappings

Testing Done:
Local testing with removing CentOS mapping and launch a VM.

Signed-off-by: Nitin Mehta <nitin.mehta@citrix.com>
 2014-05-22 20:38:57 +02:00
Min Chen c169ed1f3e CLOUDSTACK-6742: listVolumes - As regularuser , able to list Vms and 
volumes of other users.
 2014-05-22 10:17:15 +02:00
Min Chen 6ba541afb7 Disable IAM feature from 4.4 release. 
Conflicts:
	test/integration/smoke/test_vm_iam.py
 2014-05-21 13:49:11 +02:00
Murali Reddy 019ac691f0 CLOUDSTACK-6721: VolumeApiServiceImpl is sending wrong type for 
updateAsyncJobAttachment

fix sends 'Volume' instead of 'volume'
 2014-05-20 14:26:13 +02:00
Murali Reddy 5b525aadf3 CLOUDSTACK-6712: NPE in findJobInstanceUuid() in ApiDBUtils 2014-05-20 10:20:20 +02:00
Murali Reddy 840938504b CLOUDSTACK-6672: [Automation] NPE observed while listing system vms 
fixing NPE
 2014-05-19 11:04:57 +02:00
Jayapal adcc21ef3b Fixed vpc private gateway backend issues 2014-05-15 20:09:26 +02:00
Sanjay Tripathi da97f3f6e5 CLOUDSTACK-6678: API:MS: listCapacity returns; errorcode":530,"cserrorcode":9999,"errortext":"Index: 0, Size: 0"}. 2014-05-15 11:13:08 +02:00
Nitin Mehta e796d885f3 CLOUDSTACK-6660: Dont assume every vm will have a root volume now. 2014-05-15 08:46:30 +02:00
Sanjay Tripathi 13ba59c5f0 CLOUDSTACK-6649: CS is not giving the system-wide capacity for GPU reosurce. 2014-05-14 13:52:46 +02:00
Amogh Vasekar a7bf66b9f0 This patch disallows deleting / modifying system defined guest OS mappings 
Local env
1. Create user defined mapping
2. Delete / modify user defined mapping. Should pass
3. Delete / modify system defined mapping. Should fail

Signed off by :- Nitin Mehta<nitin.mehta@citrix.com>
 2014-05-13 22:55:14 +02:00
Min Chen aa2bbd455f CLOUDSTACK-6628:[Automation] Create PF rulw API failing with error 
"database id can only provided by VO objects".
 2014-05-13 11:34:55 +02:00
Min Chen e865cf8d2b CLOUDSTACK-6613:IAM: authorizeSecurityGroupIngress fails when SG Name is 
passed.
 2014-05-13 11:20:27 +02:00
Min Chen 7ea168e917 CLOUDSTACK-6598:IAM - listAccount() retrurns "Caller cannot be passed as 
NULL to IAM!" when domain deletion is in progress.
 2014-05-13 11:19:54 +02:00
Devdeep Singh f0dcf474f2 CLOUDSTACK-6510: Fix gson serialization exception in storage migration. Gson couldn't serialize 
a map with volume and storagepool objects for logging. Fixed by using volume and storage pool
ids instead of objects in the map.
 2014-05-13 10:51:42 +02:00
Sheng Yang ed7bd0022e CLOUDSTACK-5501: Allow one vpn customer gateway with multiple connections 
This restriction was purposely avoid confusion of VPN setup, but later found too
strictly and cause troubles for deployment. Removed after testing one customer
gateway with multiple connections.
 2014-05-13 10:36:50 +02:00
Amogh Vasekar 02bd3d0671 CLOUDSTACK-6358: As a part of supporting dynamic guest OS defined by user, removing the hard-coded dependencies. 
This patch is for KVM

1. Local testing on KVM
2. Successfully got up system VMs
3. Successfully created a CentOS VM
4. Snapshots are not supported for KVM

 Signed off by :- Nitin Mehta<nitin.mehta@citrix.com>
 2014-05-13 10:33:15 +02:00
Nitin Mehta 5ead629ce7 CLOUDSTACK-6633: listVolumes should return template/iso info for root volumes 2014-05-12 09:44:12 +02:00
Murali Reddy 0ba00ec24d CLOUDSTACK-6608:OVS distributed firewall: default ACL rule is not 
getting applied when a tier in VPC is created.

fix ensures, VpcRoutingPolicyUpdate is send when network rules are
programmed when network tier in VPC is created
 2014-05-12 09:40:36 +02:00
santhosh 32124df53c Added fix for CLOUDSTACK-6548 
Signed-off-by: santhosh <santhosh.edukulla@gmail.com>
Signed-off-by: Daan Hoogland <daan@onecht.net>
 2014-05-09 17:07:36 +02:00
Daan Hoogland 703e9f6f46 Revert "CLOUDSTACK-3272 Fixing NullPointerException for alerts" 
This reverts commit 882bf079fa.
 2014-05-09 13:24:32 +02:00
Murali Reddy 645f165429 CLOUDSTACK-6593: Connectivity service capabilites should be matched with 
the provider only if at least one capability is specified

Fix avoids the check, and only if the createNetworkOffering
'StrechedL2'Subnet' capability is specified then it should match against
'Connectivity' service provider
 2014-05-09 12:10:12 +02:00
Alena Prokharchyk d9b4b87c5c CLOUDSTACK-6601: added "forDisplay" parameter to listLoadBalancerRules API 2014-05-09 10:17:57 +02:00
Daan Hoogland 9450205f77 Revert "CLOUDSTACK-6485: private gateway network should not be associated with vpc" 
This reverts commit 90600f1bdf.
 2014-05-08 11:32:20 +02:00
sonal.ojha 882bf079fa CLOUDSTACK-3272 Fixing NullPointerException for alerts 
Signed-off-by: Daan Hoogland <daan@onecht.net>
 2014-05-08 11:13:05 +02:00
Alena Prokharchyk a3825f126f CLOUDSTACK-6596: UUID and display flag update support for LBStickinessPolicy and LBHealthCheckPolicy 2014-05-08 09:48:27 +02:00
Alena Prokharchyk 4c9bf8a70f CLOUDSTACK-6595: call expunge method marked with @ActionEvent from expunge thread context. So the action even EXPUNGE.VM is generated when vm is expunged by the thread. 2014-05-07 23:14:04 +02:00
Prachi Damle 95efad359e CLOUDSTACK-6581: IAM - Shared Network -Root Admin user is allowed to deploy VM in a shared network that is scoped for a specific domain/account. 
Changes:
- Strict access check in NetworkModel is needed as CS 4.3
- We cannot go through accountMgr since accountMgr is relaxed for rootAdmin
 2014-05-07 09:21:30 +02:00
Alena Prokharchyk 8985b8badc CLOUDSTACK-6585: added missing metadata support for LBStickiness/LBHealthcheck policies 2014-05-07 09:20:16 +02:00
Kelven Yang 60ad928ce7 CLOUDSTACK-6586: Move EventBus hookup on job framework to ApiServer to decouple job framework away from business logic related hookups. The decoupling is done through internal messaging facility provided inside management server. 2014-05-07 09:17:32 +02:00
Rajani Karuturi c081cf7b1a CLOUDSTACK-6531: stopping the router in case of command failures. Also added alerts for failures. 
Signed-off-by: Jayapal <jayapal@apache.org>
 2014-05-06 17:48:53 +02:00
Jayapal 3c33577998 CLOUDSTACK-6578: Fixed issue in delete remote access vpn command 2014-05-06 17:48:11 +02:00
Jayapal ca270cbdf7 CLOUDSTACK-6577: Disable service monitoring in RVR 2014-05-06 17:47:39 +02:00
Sam Schmit 3a3457e713 CLOUDSTACK-6472 listUsageRecords: Pull information from removed items as well, fixing NPEs/Null UUIDs with usage API calls. 2014-05-06 17:46:20 +02:00
Sebastien Goasguen 352a9f8587 Review from pyr https://reviews.apache.org/r/20557/ 2014-05-06 17:45:56 +02:00
Tanner Danzey f8419b9303 CLOUDSTACK-5907, CLOUDSTACK-6396: KVM/RBD & KVM/CLVM volumes mistakenly shown as OVM, disables snapshotting 
modified:   server/src/com/cloud/api/ApiDBUtils.java

Signed-off-by: Daan Hoogland <daan@onecht.net>
 2014-05-05 15:29:14 +02:00
Mike Tutkowski dd3076987f CLOUDSTACK-6170 Corrected an issue related to the "Reinstall VM" command and managed storage with VMware 2014-05-03 14:04:49 +02:00
Min Chen 71e0cff46e CLOUDSTACK-6568:API:createVolume: Volume gets created with wrong domain 
ID.
 2014-05-03 14:02:16 +02:00
Min Chen 1085695b5c CLOUDSTACK-6569: IAM - Regular user is able to listNetworks of another 
user in the same domain , by passing account and domainId.
 2014-05-03 00:44:25 +02:00
Alena Prokharchyk d17c299fb4 LOUDSTACK-6475: cleanupVPC task - removed the transaction wrapping up multiple VPC destroy as the destroy operation has external calls, to prevent long-locked transaction. 
Reviewed-by: Prachi Damle
 2014-05-02 23:27:42 +02:00
Min Chen 96cd858d97 CLOUDSTACK-6556: Deploy VM failing with error "does 
not have permission to access resource Ntwk".
 2014-05-02 18:53:47 +02:00
Min Chen 9f798823ef CLOUDSTACK-6556: [Automation] Deploy VM failing with error "does not 
have permission to access resource Ntwk".
 2014-05-02 18:53:22 +02:00
Min Chen 4ebde83519 CLOUDSTACK-6535: IAM:MS:API createVMSnapshot doesn't preserve access 
rights.
 2014-05-02 18:52:51 +02:00
Prachi Damle c4ab1d5772 CLOUDSTACK-6560: IAM - Admin user is denied permission to create Egress rule for a user's network 
Changes:
- CS 4.3 handled Network entity in two ways:
a) Specified "UseNetwork" access and did a strict check w.r.t who can use this network. Regular users and Domain Admin went through the strict check. Root admin got access always.
b) Specified "null" access and that meant admins can access this network for the calling API that passes null access.

- Fixing CS 4.4 IAM to handle this behavior:
a) "UseNetwork" is mapped to "UseEntry" and IAM check will be done only for domain admin and regular users when this access is specified. Root Admin is grated access.
b) If "null" access is specified, root and domain admin both are granted access. Regular users still go through IAM.
 2014-05-02 18:51:19 +02:00
Prachi Damle 33c3752d0e CLOUDSTACK-6558 IAM - Admin user is able to deploy VM in a regular user's Security Group. 
Changes:
- Even for SecurityGroup, go through IAM to do permission checks for all type of accounts
 2014-05-02 18:50:52 +02:00
Min Chen a3a0f13bb8 CLOUDSTACK-6513: remove commented code. 2014-05-01 10:38:05 +02:00
Min Chen 554cab8ea1 CLOUDSTACK-6513: templateFilter=shared should not show self-owned 
template.
 2014-05-01 10:37:46 +02:00
Prachi Damle c32b7ab7c8 CLOUDSTACK-6517: IAM - Admin is allowed to create PortFowarding rule for a regular user, when admin does not have " UseEntry" permission for IpAddress. 
Changes:
- IAM was applying ordering on accessTypes. Thus if an account had Operate, he got USe access as well. So even if IAM schema did not have 'UseEntry" permission for IpAddress, some other 'OperateEntry' permission on IpAddress was letting this operation go through.
- Fixed IAM to NOT do ordering of access types anymore. IAm will perform strict accessType check only.
- This fix is needed so that admin does not get permission to USE resources from other account just becase he has OPERATE access on those resources due to some other APIs.

- However due to this fix, we break backwards compatibilty with CS 4.3.
- CS 4.3 allowed root admin to do the createPF operation for a user by passing in networkId of the user.
- Same was the case for domain admins within their domains
- Why this worked was due to CS 4.3 simply returning true for root admin/domain admin

- So to maintain backwards compatibilty, we are adding the logic to return "true" for root admin and domain admin just like CS 4.3.
- Exception is: For Network, AffinityGroup and Templates, we still call IAM even for root admin/domain admin, since thats what CS 4.3 did. Just for these 3 resource_types, it used to perform access checks even for root admin/domain admin.
 2014-05-01 08:36:39 +02:00
Min Chen 683c242ed3 CLOUDSTACK-6513: Optimize code by removing deprecated utility to 
QueryManagerImpl as private method just used for listTemplates and
listAffinityGroups to avoid misuse by new list APIs.
 2014-04-30 10:40:39 +02:00