Commit Graph

7951 Commits

Author SHA1 Message Date
Daan Hoogland 791b7f8f7f findbugs: nullpointer guards and wrappertype comparisons 2014-01-27 00:23:57 +01:00
Daan Hoogland 20127e09dc findbugs: assign result of string manipulations 2014-01-26 23:49:56 +01:00
Daan Hoogland 0b13f8e59d Findbugs: different issues solved 2014-01-26 23:14:17 +01:00
Daan Hoogland 866a539b06 findbugs: removed fields injected in parent 2014-01-26 16:49:18 +01:00
Daan Hoogland 23a3d99fc0 findbugs: byte[].toString -> Arrays.toString(byte[]) 2014-01-26 16:38:53 +01:00
Daan Hoogland c58e509924 findbugs: null-checks 2014-01-26 16:35:48 +01:00
Daan Hoogland f3b9a7f123 findbugs: retrieve the objects to remove from the collection(s) 2014-01-26 16:07:59 +01:00
Daan Hoogland b40156313a findbugs: serialized class serializable 2014-01-26 16:03:56 +01:00
Daan Hoogland df6f40fe73 Revert "findbugs: remove compatible objects from collection"
This reverts commit 390325c50b.
2014-01-26 15:25:19 +01:00
Daan Hoogland 390325c50b findbugs: remove compatible objects from collection 2014-01-26 15:20:24 +01:00
Daan Hoogland d30ddf6d59 findbugs: null check for gateway and netmask instead of gateway twice 2014-01-26 15:11:56 +01:00
Daan Hoogland 9aced41d70 findbugs fixes for ApiServer, ApiSerializerHelper and ApiXmlDocWriter 2014-01-26 13:27:37 +01:00
Daan Hoogland 9a1b882d0e Findbugs issues in ApiResponseHelper fixes 2014-01-26 12:25:18 +01:00
Daan Hoogland 437ff438af restored imports 2014-01-26 00:34:41 +01:00
Daan Hoogland f3529a19a9 moved call on static object to synchronized block 2014-01-25 23:46:18 +01:00
Daan Hoogland 43ba36f979 nullpointer dereference guarded 2014-01-25 23:26:53 +01:00
Kelven Yang 29e44b1b67 CLOUDSTACK-5928: Use legacy vmsync logic by default 2014-01-22 14:09:22 -08:00
Alena Prokharchyk aa6f4dc8a7 CLOUDSTACK-5930: Changed "authenticate" method to return both - result of authentication, and action to perform when authentication failed - to the accountManagerImpl. Only if authenicators request INCREMENT_INCORRECT_LOGIN_ATTEMPT_COUNT, the incorrect_login_attempts parameter will be increased
Signed-off-by: Alena Prokharchyk <alena.prokharchyk@citrix.com>

Conflicts:
	plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java
	plugins/user-authenticators/md5/src/com/cloud/server/auth/MD5UserAuthenticator.java
	plugins/user-authenticators/plain-text/src/com/cloud/server/auth/PlainTextUserAuthenticator.java
	plugins/user-authenticators/sha256salted/src/com/cloud/server/auth/SHA256SaltedUserAuthenticator.java
	server/src/com/cloud/server/auth/UserAuthenticator.java
	server/src/com/cloud/user/AccountManagerImpl.java
(cherry picked from commit f160b31f51)

Signed-off-by: Animesh Chaturvedi <animesh@apache.org>
2014-01-22 13:07:43 -08:00
Alena Prokharchyk f160b31f51 CLOUDSTACK-5930: Changed "authenticate" method to return both - result of authentication, and action to perform when authentication failed - to the accountManagerImpl. Only if authenicators request INCREMENT_INCORRECT_LOGIN_ATTEMPT_COUNT, the incorrect_login_attempts parameter will be increased
Signed-off-by: Alena Prokharchyk <alena.prokharchyk@citrix.com>

Conflicts:
	plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java
	plugins/user-authenticators/md5/src/com/cloud/server/auth/MD5UserAuthenticator.java
	plugins/user-authenticators/plain-text/src/com/cloud/server/auth/PlainTextUserAuthenticator.java
	plugins/user-authenticators/sha256salted/src/com/cloud/server/auth/SHA256SaltedUserAuthenticator.java
	server/src/com/cloud/server/auth/UserAuthenticator.java
	server/src/com/cloud/user/AccountManagerImpl.java
2014-01-22 12:53:27 -08:00
Kelven Yang 50f311ed94 CLOUDSTACK-5928: disable host delta sync when new VM sync is enabled 2014-01-22 11:17:25 -08:00
Alena Prokharchyk d5e0dcd2a7 Revert "Changed "authenticate" method to return both - result of authentication, and action to perform when authentication failed - to the accountManagerImpl. Only if authenicators request INCREMENT_INCORRECT_LOGIN_ATTEMPT_COUNT, the incorrect_login_attempts parameter will be increased"
This reverts commit 7884bb8aaf.
2014-01-21 19:50:46 -08:00
Alena Prokharchyk 7884bb8aaf Changed "authenticate" method to return both - result of authentication, and action to perform when authentication failed - to the accountManagerImpl. Only if authenicators request INCREMENT_INCORRECT_LOGIN_ATTEMPT_COUNT, the incorrect_login_attempts parameter will be increased
Signed-off-by: Alena Prokharchyk <alena.prokharchyk@citrix.com>

Conflicts:
	plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java
	plugins/user-authenticators/md5/src/com/cloud/server/auth/MD5UserAuthenticator.java
	plugins/user-authenticators/plain-text/src/com/cloud/server/auth/PlainTextUserAuthenticator.java
	plugins/user-authenticators/sha256salted/src/com/cloud/server/auth/SHA256SaltedUserAuthenticator.java
	server/src/com/cloud/server/auth/UserAuthenticator.java
	server/src/com/cloud/user/AccountManagerImpl.java
2014-01-21 18:09:15 -08:00
Animesh Chaturvedi 70ba92fc14 Updating pom.xml version numbers for release 4.3.0
Signed-off-by: Animesh Chaturvedi <animesh@apache.org>
2014-01-21 17:29:51 -08:00
Min Chen afb8a79321 CLOUDSTACK-5921: S3 security key is stored in DB unencrypted 2014-01-21 14:17:30 -08:00
Mike Tutkowski 413c61b519 CLOUDSTACK-5873: [Automation] Failed to attach volume to VM, if the vm is created with option startvm=false 2014-01-20 23:08:27 -07:00
Min Chen aa2d25bf92 CLOUDSTACK-5913:API rate limiting throws a different error than expected
when Throttle limit hit in the API.
2014-01-20 14:57:48 -08:00
edison 7c2449dabd CLOUDSTACK-5432:sync vm and storage commands on mgt server for kvm 2014-01-17 15:23:43 -08:00
Kelven Yang be0d688511 CLOUDSTACK-5731: Use general instance type to categorize VM work jobs to correctly serialize VM operations 2014-01-17 10:42:04 -08:00
Saksham Srivastava 330571cea6 CLOUDSTACK-5692: obscure passwords when using cifs as storage 2014-01-17 13:49:46 +05:30
Alena Prokharchyk 9c32605f2b CLOUDSTACK-4987: when addNic to vm, don't make account check if the call is made by ROOT admin 2014-01-16 13:35:04 -08:00
Alena Prokharchyk c375ec62e2 CLOUDSTACK-4987: when addNic to vm, don't make account check if the vm belongs to ROOT admin 2014-01-16 11:12:35 -08:00
Sateesh Chodapuneedi 90e01b1e10 CLOUDSTACK-5408 [Automation] Failed to deploy vm in vmware environment with error "due to java.io.IOException: Cannot run program "mount": java.io.IOException: error=12, Cannot allocate memory"
Bump up RAM size of system offering for SSVM to 512MB. Fix if default service offering is already not present.

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2014-01-16 01:35:25 +05:30
Min Chen 64350b6f2e CLOUDSTACK-5877: ListTemplates does not sort based on sort_key. 2014-01-15 16:58:30 -08:00
Mike Tutkowski fef4c79cb2 CLOUDSTACK-5873: [Automation] Failed to attach volume to VM, if the vm is created with option startvm=false 2014-01-15 00:18:34 -07:00
Murali Reddy b6698f354c CLOUDSTACK-5861: networks that failed to implement can not be destroyed
introduces a force option in delete network to forcifully delete a
network. This comes handy in rare cases where network fails to implenet
and network is in shutdown state, but network shutdown to rollback
implement process fails as well.
2014-01-13 23:24:12 +05:30
Kelven Yang b2d5e374d9 CLOUDSTACK-5734: Fix the regression caused by adding hyper-V support 2014-01-10 17:58:48 -08:00
Marcus Sorensen 1f9ad23ba0 CLOUDSTACK-5502 createVlanIpRange, allow untagged to be accepted per previous use,
equate empty string to untagged in api parameter input
2014-01-10 16:30:43 -07:00
Harikrishna Patnala 7a39b0a2e1 CLOUDSTACK-4904: Unable to see a derieved template if the
parent template is deleted. Modified template_view so that removed(or InActive) templates also be there in the view.
Previous behavior of listing templates and state column in vm_templates will be the same.
2014-01-10 10:24:35 -08:00
Bharat Kumar 35e09c81e6 CLOUDSTACK-5651 deployVm: customparameters param name has to be changed
Signed-off-by: Alena Prokharchyk <alena.prokharchyk@citrix.com>
2014-01-10 09:42:33 -08:00
Kishan Kavala 202a935fcd CLOUDSTACK-5852: router search in DomainDouterDao using AllFieldsSearch filters few routers due to router_network_ref join. Created a seperate search to list running routers with filters. 2014-01-10 19:57:02 +05:30
Kishan Kavala ac68ebd631 CLOUDSTACK-5656: Removed Filtering of revoked rules while listing. API returns state as Deleting for revoked rules. 2014-01-09 22:00:32 +05:30
Prachi Damle ce9760f4ce CLOUDSTACK-5732 [UI] Search is not working in Affinity Groups panel
- Added keyword support
2014-01-08 17:59:23 -08:00
Min Chen 02f6e02a73 CLOUDSTACK-5840:Remove old API method. 2014-01-08 17:57:15 -08:00
edison 1f70154c34 CLOUDSTACK-5831: Fix NPE, in case the volume isn't attached to any pool 2014-01-08 17:07:45 -08:00
Min Chen 62aa14771c CLOUDSTACK-5840:Migration from NFS to S3 should be done in one API
(updateCloudToUseObjectStore) instead of two APIs.
2014-01-08 16:33:37 -08:00
Min Chen 5b07590786 CLOUDSTACK-5813: With S3 as secondary storage, snapshot taken in one
zone cannot be used to create volume in another zone. zoneId parameter
in createVolumeCmd is not observed.
2014-01-08 16:33:37 -08:00
edison f7e0a540d8 Merge remote-tracking branch 'origin/4.3' into 4.3 2014-01-08 16:27:16 -08:00
edison 086475647c CLOUDSTACK-5831: return quiescevm field in volumeresponse 2014-01-08 16:04:21 -08:00
Sheng Yang 4aad42e823 Revert "CLOUDSTACK-4540: Set execute.in.sequence.network.element.commands=true by default"
This reverts commit 62be5fad12.

Refer to the latest comment in the bug.
2014-01-08 16:02:23 -08:00
edison d1c0aa157a CLOUDSTACK-5763: if vm is stopped, then don't check hypervisor support live storage migration capabilities. 2014-01-08 15:25:26 -08:00
edison b3d4b72508 CLOUDSTACK-5607: Don't delete the template if its stored in other zones. 2014-01-08 15:05:27 -08:00
edison b180717473 CLOUDSTACK-5828: if snapshot deletion failed, such as can't find it on secondary storage, should return succeed. 2014-01-08 14:35:15 -08:00
Wei Zhou 4bb85cd7f9 CLOUDSTACK-5303: fix incorrect resource count (snapshot, secondary_storage)
(cherry picked from commit fa43987e43)
2014-01-08 15:34:51 +01:00
Bharat Kumar 55a9b5d2a2 CLOUDSTACK-5742 Add usage event detials for vm state transitions when using custom compute offering. 2014-01-08 19:11:01 +05:30
Jayapal cb48c97801 CLOUDSTACK-5552 Setup private gateway state to ready on delete failure
On delete private gateway failure set the state to ready, So that it can be
deleted later.
2014-01-08 11:42:25 +05:30
Kelven Yang c75b0044ef CLOUDSTACK-5765: cleanup internal serialization and exception propagation issues 2014-01-07 17:12:06 -08:00
Marcus Sorensen 5a8ea8ae71 CLOUDSTACK-5697 This patchset fixes a bug with the recently merged
vxlan code. Users can set a physical network to isolation type 'vxlan',
put public traffic on that physical network, and it will still attempt
to use 'vlan' isolation on the KVM hosts. This is going to be an issue
for other isolation types as well, but I'm not familiar with them, so
I'm just fixing vxlan for now.
2014-01-07 17:03:36 -07:00
Alena Prokharchyk 6fd030cbf2 CLOUDSTACK-5826: do netmask/gateway validation before calculating the POD cidr 2014-01-07 15:01:27 -08:00
Jayapal 279e9cbe49 CLOUDSTACK-5552 fixed private gateway DB clean up on router upgrade required 2014-01-07 17:57:20 +05:30
Sanjay Tripathi 0706757e00 CLOUDSTACK-5314: Negative (-ve) values for primary storage and volumes are shown in the resource count table. 2014-01-07 14:27:35 +05:30
Sanjay Tripathi 96823d3a62 CLOUDSTACK-5406: Not able to take snapshot becasue of secondary_storage limit of 400 gb exceeded even though we have not really consumed this limit in secondary store. 2014-01-06 15:48:23 +05:30
edison db25228b23 CLOUDSTACK-5329: fix NPE in storage migration for zone-wide primary storage, and also the serization error. 2014-01-03 16:44:21 -08:00
Kelven Yang ce7bc8fd90 CLOUDSTACK-5725: put origin flow context id into log4j context prefix to link jobs with the orchestration work flow in logging 2014-01-03 15:47:03 -08:00
Min Chen 3179fb2a5c CLOUDSTACK-5771:listImageStores returns error in keyword search. 2014-01-03 15:09:10 -08:00
Kelven Yang 9cad092054 CLOUDSTACK-5767: Remove the logic of using underlying job related fields for volume specific logic. 2014-01-03 13:10:32 -08:00
Devdeep Singh 741634b87e CLOUDSTACK-5691: Fix for attaching an uploaded volume to instance running
on hyperv. There were multiple issues here. Upload volume was actually
failing because the post download check for vhd on the cifs share was
unsuccessful. Also the agent code wasn't parsing the volume path correctly.
Fixed it too.
2014-01-03 16:43:21 +05:30
Jayapal 3fe9426824 CLOUDSTACK-5552 fixed private gateway clean up in DB when create failed 2014-01-03 12:56:28 +05:30
Sheng Yang 62be5fad12 CLOUDSTACK-4540: Set execute.in.sequence.network.element.commands=true by default
The things is, VR would take time to execute the commands, say it would need
time t1(which is greater than 0).

And the interval between parallel deployment is t2(which can be almost 0).  In
any case, VR need to handle commands in sequence internally, so if t1 > t2, then
the new task in the VR would wait longer and longer to execute, then some
commands result in timeout ultimately. No matter how long the timeout is, if
there are enough big number of queued task for VR, the last ones can timeout.

Currently VR has a robust mechanism to sequence the jobs internal and I
confirmed in this case, it works well. But there is no way to fix this issue if
VR is already 100% load at all time.

Probably we can improve the speed of VR internal executing, but seems the
ultimate answer is: set execute.in.sequence.network.element.commands to true. VR
doesn’t know how long it would take for mgmt. server to timeout, only mgmt.
server knows that.

By setting sequence execution in VR to "true", mgmt server would handle the
commands in a queue, make sure that VR won't be overload and report unexpected
failure just because it's overload.
2014-01-02 15:34:16 -08:00
Harikrishna Patnala bae5be7f4e CLOUDSTACK-5551: Search not working for Configuration parameters in (Account/zone/cluster/storage) settings page
Added filters while listing scoped configuration parameters.
Fixed: Some parameters are missing from UI settings tab because of missing scope entry in configuration table.
2014-01-02 15:43:47 +05:30
Kishan Kavala b763e49873 CLOUDSTACK-5656: Rules will remain in Revoked state when router upgrade is required. Filtered revoked rules while listing. Show genreric error since router is not visible to enduser. 2014-01-02 15:09:18 +05:30
Kishan Kavala 88ce5b804e Added config to enable/disable router version check
Conflicts:
	server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
2014-01-01 17:34:35 +05:30
Kishan Kavala 78b9d5cda2 CLOUDSTACK-5698: support network ACL list search by keyword 2014-01-01 16:52:05 +05:30
Anshul Gangwar 0b643ddf09 CLOUDSTACK-5705: fixed the thumbnail not wrking for hyperv 2014-01-01 15:05:34 +05:30
Anshul Gangwar e74889ac91 CLOUDSTACK-5703: putting rdp server port value in host details 2014-01-01 15:05:09 +05:30
Sanjay Tripathi ce48b0bd55 Revert "CLOUDSTACK-5329: fix NPE, in case of zone wide primary storage"
This reverts commit 23841e3369.
2014-01-01 11:23:57 +05:30
Kelven Yang a03c8fe668 Fix a typo caused problem in attach-volume process 2013-12-31 15:13:10 -08:00
edison 23841e3369 CLOUDSTACK-5329: fix NPE, in case of zone wide primary storage 2013-12-31 14:03:44 -08:00
Kelven Yang 3094160718 CLOUDSTACK-669: Finalize VM work dispatching mechanism to avoid big switch statement 2013-12-31 13:32:28 -08:00
Edison Su 9d52a4362d CLOUDSTACK-4506: fix NPE in case hostid is null 2013-12-31 11:37:30 -08:00
Anshul Gangwar b55d9ecf53 CLOUDSTACK-5344 commit for console proxy rdp for hyperv 2013-12-31 18:14:53 +05:30
Daan Hoogland 9ec137e75b isSameIsolationId 2013-12-31 12:18:33 +01:00
Kishan Kavala e4462f3626 CLOUDSTACK-5669: Return true when deleteVmSnapshot job result status is null 2013-12-31 12:48:55 +05:30
Murali Reddy 577ec61b6f CLOUDSTACK-5667: Shared Network - fails to launch router due to "
Multiple generic soure NAT IPs provided for network"

'getExistingSourceNatInNetwork' method was retruning source nat ip for
a particular account, resulting in multiple source nat ip's to be
assigned to a shared network on network implemen. Fix ensures that
account id is not considered for shared network implement.
2013-12-31 11:07:53 +05:30
Sanjay Tripathi 4c9521726b CLOUDSTACK-5422: Changing XenServer Tools Version 6.1 + doesnt work. 2013-12-30 20:11:12 +05:30
Sanjay Tripathi 68a0b27929 CLOUDSTACK-3806: OS Preference can not be set. 2013-12-30 17:10:52 +05:30
Mike Tutkowski 8eb430f602 CLOUDSTACK-5662: XenServer can't discover iSCSI targets with different credentials 2013-12-28 00:12:11 -07:00
Kelven Yang dc303fda6e CLOUDSTACK-669: Convert volume snapshot orchestration flow to make it be serialized with other VM operations 2013-12-27 16:40:50 -08:00
Mike Tutkowski 574fc3a4f8 CLOUDSTACK-5662: XenServer can't discover iSCSI targets with different credentials 2013-12-27 13:12:12 -07:00
Sanjay Tripathi 526043b715 CLOUDSTACK-4973: Specified keyboard language is not showing as default in consoleView passed during deployVM. 2013-12-27 16:15:00 +05:30
Murali Reddy ed113474ec removing unintended change 2013-12-27 14:29:49 +05:30
Murali Reddy 2715fd4dd9 CLOUDSTACK-5403: Shared network - None of PF, LB rules work after router
restart, firewall rules dropped from iptables post restart

on VR restart, not all public IP's associated with the network are sent
with IpAssocCmd to VR. This fix will ensure all the ip's associated with
the network irrespective of the account are sent as part of
IpAssocCommand
2013-12-27 13:35:42 +05:30
Devdeep Singh 9f5bea6204 CLOUDSTACK-5655: hyper-v configuration parameters are missing in upgraded setup. Updated
the db upgrade schema script to insert the configuration parameters.
2013-12-27 13:07:52 +05:30
Min Chen 69524fb11f CLOUDSTACK-5653:S3 object store as Secondary Storage, the template
created from different zone is not available for the other zones.
2013-12-26 14:26:55 -08:00
Bharat Kumar 69fb1d4ed0 CLOUDSTACK-5530 attempt to add secondary storage with the same name is ignored 2013-12-26 11:48:45 -08:00
Min Chen 35ba14d88d CLOUDSTACK-5648:CopyTemplate and CopyISO across zones fails after NFS
migration to S3.
2013-12-26 11:12:00 -08:00
Jayapal 749c77ae16 Fixed issue in setting vm ip,mac in vm_instance table
This issue is not seen in 4.2, It is observed only in 4.3.
2013-12-26 16:40:00 +05:30
Devdeep Singh 079323f591 CLOUDSTACK-5420: The agent manager wasn't transitioning the host to maintenance
mode if their are no vms running on the host. Made the change to do so.
2013-12-26 11:14:01 +05:30
Kishan Kavala ea442fa81f CLOUDSTACK-5254: If VR is not upgraded, leave firewall rule in Active state. Rule will be applied when VR is upgraded 2013-12-24 18:07:58 +05:30
Alena Prokharchyk 632346d6a5 CLOUDSTACK-5390: when calculate index (page #) in NetworkManager, rely on fact that getStartIndex() returned by API, returns pageSize*(page-1). So to get index(page), you need to do the reverse calculation 2013-12-23 16:53:46 -08:00
Kishan Kavala 0c6e8baa85 CLOUDSTACK-5300: Catch vpn add error failure, removed failed user and return failure status 2013-12-23 17:28:07 +05:30
Kishan Kavala 9471797590 CLOUDSTACK-5587, CLOUDSTACK-5589: Router version in 2.2.x routers is null. Added null check when comparing min version 2013-12-23 17:28:07 +05:30
Devdeep Singh 5b58128714 CLOUDSTACK-5564: The deployment on other hosts in the cluster used to fail because
cloudstack though the storage pool wasn't accessible from the host. Make sure host
to pool mapping is added in the storage_pool_host_ref table when a host is added
to the cluster.
2013-12-23 16:56:26 +05:30
Rajesh Battala 7c5563adb7 CLOUDSTACK-5340 [Hyper-V] Control IPs are not getting released when VRs are in stopped state 2013-12-22 20:24:16 +05:30
Rajesh Battala a63fd39cd8 CLOUDSTACK-5592
ssh should run on eth1 interface in ssvm/cpvm running in HyperV.
2013-12-22 20:24:15 +05:30
Mike Tutkowski 0ddbae580e CLOUDSTACK-4810: Enable hypervisor snapshots for CloudStack-managed storage (for XenServer and VMware) 2013-12-20 23:28:33 -07:00
Kelven Yang 497feab841 CLOUDSTACK-669: covert VMsnapshot orchestration flows to make them be serialized with other VM operations 2013-12-20 16:45:27 -08:00
Edison Su e51892abd5 CLOUDSTACK-5582: reload vm state after vm been force stopped 2013-12-20 11:19:53 -08:00
Daan Hoogland aaf3979cf9 CLOUDSTACK-5502: interpret vlan='untagged' as vlan == null 2013-12-20 13:31:25 +01:00
Harikrishna Patnala c39431ff6a CLOUDSTACK-5554: Custom disk offering allows to create a datadisk with size greater than custom.diskoffering.size.max value 2013-12-19 23:03:11 +05:30
Harikrishna Patnala 1c6b146d04 CLOUDSTACK-5554: Custom disk offering allows to create a datadisk with size greater than custom.diskoffering.size.max value 2013-12-19 15:45:43 +05:30
Nitin Mehta d2f194064d CLOUDSTACK-4941:
Adding the missing file
During HA and maintenance call different planners (if the original planners are not able to find capacity) which skip some heurestics
2013-12-18 20:26:51 -08:00
edison 15403a1f29 add xenserver 6.2.0 hotfix support, to optimize vdi copy
add xenserver hot fix
2013-12-18 18:22:52 -08:00
Nitin Mehta 00b5e1a195 undo the comments on version check 2013-12-18 13:39:36 -08:00
Kishan Kavala 8a623d884c CLOUDSTACK-5528 : When VR version is not known set requiresUpgrade flag to true 2013-12-18 18:22:07 +05:30
Jayapal 58f079d8c2 CLOUDSTACK-5466:Fixed freeing ip address in removeIpFromNic 2013-12-18 15:02:24 +05:30
Jayapal dd039da7e4 CLOUDSTACK-5505: Fixed issue in getting interface number in IpAssocVpcCommand
Regression from the below commit

commit 494ccd821d
Author: ynojima <mail@ynojima.net>
Date:   Wed Nov 6 11:02:56 2013 -0700
    Bugfix: VR has double NICs connected to Public network
2013-12-18 12:27:20 +05:30
Nitin Mehta dc0f8ebdf1 CLOUDSTACK-4941:
During HA call different planners which skip some heurestics
2013-12-17 18:32:46 -08:00
Kelven Yang ed2125ec34 CLOUDSTACK-669: convert volume attach/detach flows to make them be serialized with other VM operations 2013-12-17 17:11:05 -08:00
Min Chen d0abf3fcc2 CLOUDSTACK-5534: MySQL exception raised when searching for users with
keyword.
2013-12-17 16:55:49 -08:00
Sheng Yang 8cb51dcc88 CLOUDSTACK-5533: Disable VR's DNS functionality if user choose to use external dns
Also fix the regression that external dns won't be used if "dns" service in the
network offering is unset.
2013-12-17 16:06:31 -08:00
Prachi Damle 35afd012f5 CLOUDSTACK-4852: Since upgrade to 4.2 only users at the zone-attached domain level can manipulate VMs
Changes:
- The vmprofile owner passed in to the planner should be the VM's account and not the caller
- Do not do the access check for Root Admin
2013-12-17 11:23:21 -08:00
Bharat Kumar 9118bbf934 CLOUDSTACK-5495 Unable to stop VM. adding the changes to make the global config execute.in.sequence.hypervisor.commands configurable for stopvm command.
Signed-off-by: Koushik Das <koushik@apache.org>
2013-12-17 17:43:19 +05:30
Rajesh Battala 03f1bae21c CLOUDSTACK-5365 added route for mgmt cidr in the VR running on HyperV 2013-12-17 16:40:01 +05:30
Murali Reddy 307e058690 CLOUDSTACK-5517: NPE observed during "release portable IPs" as part of
account cleanup

ensure proper portable ip address are released  as part of account
cleanup
2013-12-16 19:34:32 +05:30
Kishan Kavala e2805b802c CLOUDSTACK-5145 : Added permission checks while deleting network ACLs 2013-12-16 17:50:08 +05:30
Likitha Shetty 6b7ea7f90d CLOUDSTACK-5514. Response of listAccounts API call includes removed users 2013-12-16 15:45:38 +05:30
Min Chen 7cd125ca39 CLOUDSTACK-5446:KVM-Secondary Store down-Even after secondary store is
brought back up after being down for few hours,snapshot jobs do not get
triggered with reason "there is other active snapshot tasks on the
instance to which the volume is attached".
2013-12-13 18:09:16 -08:00
Kelven Yang 96678bbbfb CLOUDSTACK-669: refactor VM work job dispatcher to allow volume/snapshot manager to participate serialized job handling 2013-12-13 17:26:13 -08:00
Jayapal 11c7fad535 CLOUDSTACK-5417 Updating egress firewall rules CiDR on external network restart 2013-12-13 13:59:42 +05:30
Alena Prokharchyk 326313e02e Resource metadata support for S2SVpnConnection 2013-12-12 14:57:44 -08:00
Alena Prokharchyk 888a599a41 Resource metadata support for customer gateway 2013-12-12 13:56:38 -08:00
Nitin Mehta 67785c2ad6 CLOUDSTACK-5283:
Not able to list snapshots when few snapshots are in "CreatedOnPrimary" state. Dont throw an exception when snapshot doesnt have an entry in the snapshot store ref for the snapshot in Image store because that fails to list all snapshots and also it can a perfect use case when the backup flag is not turned on.
2013-12-12 13:13:16 -08:00
Kishan Kavala 6a63fb4461 Upgrade router template by accountName and domainId instead of accountId 2013-12-12 18:18:21 +05:30
Syed Ahmed fb89a2d8f6 CLOUDSTACK-5296: Add certificate chain support for netscaler.
adds support for trust chains in the netscaler
2013-12-12 12:13:43 +05:30
Nitin Mehta 326a46d0ac Revert "CLOUDSTACK-4904: Unable to see a derieved template if the"
This reverts commit 4907a8f6fa.
2013-12-11 21:53:33 -08:00
Min Chen eb64159632 CLOUDSTACK-5414: With NFS Image Store migrated to S3 an error is thrown
in creation of Virtual Router.
2013-12-11 14:02:24 -08:00
Harikrishna Patnala 4907a8f6fa CLOUDSTACK-4904: Unable to see a derieved template if the
parent template is deleted
Signed off by : nitin mehta<nitin.mehta@citrix.com>
2013-12-11 10:32:27 -08:00
Murali Reddy 4fb54ca32d CLOUDSTACK-5428: support NetScaler to be configured exclusively for GSLB
service and not used for LB

Fix adds a boolean flag to addNetscalerLoadBalancer api, which
will mark added NetScaler for exclusive GSLB service. A netscaler marked
as exclusive gslb service provider is not picked for any guest network's
lb provider.

Conflicts:
	engine/schema/src/com/cloud/network/dao/ExternalLoadBalancerDeviceVO.java
	plugins/network-elements/f5/src/com/cloud/network/element/F5ExternalLoadBalancerElement.java
	plugins/network-elements/netscaler/src/com/cloud/api/commands/AddNetscalerLoadBalancerCmd.java
	plugins/network-elements/netscaler/src/com/cloud/api/response/NetscalerLoadBalancerResponse.java
	plugins/network-elements/netscaler/src/com/cloud/network/element/NetscalerElement.java
	server/src/com/cloud/network/ExternalLoadBalancerDeviceManager.java
	server/src/com/cloud/network/ExternalLoadBalancerDeviceManagerImpl.java
	setup/db/db/schema-421to430.sql
2013-12-11 15:36:22 +05:30
Jayapal d221efcf81 Fixed the tests related to network acl 2013-12-11 13:07:22 +05:30
Jayapal 9a5cf614ab CLOUDSTACK-5244 Fixed issue with applying acl items of acl to private gateway 2013-12-11 10:43:00 +05:30
Harikrishna Patnala b478eed655 CLOUDSTACK-5419: missing parameters in configuration table and to remove unused parameters
Signed-off-by: Koushik Das <koushik@apache.org>
2013-12-10 16:36:55 +05:30
Jayapal 785b71e399 Fixed issue in loading cidr on VR reboot 2013-12-10 15:18:10 +05:30
Jayapal 3caef2b1d5 CLOUDSTACK-5278 Fixed cleaning up egress default rules on VR and SRX
1. Egress default policy rules is send to the firewall provider. It is up to the
    provider to configure the rules.
   2. The default policy rules are send for both allow and deny default policy.
   3. On network shutdown rules for delete are send.
   4. For VR and SRX, by default deny the traffic. So no default rule to deny traffic is required.
2013-12-10 14:43:13 +05:30
Will Stevens 794c17921b CLOUDSTACK-5425: Fixed egress rules in Palo Alto plugin and removed un-need api commands.
Signed-off-by: Sheng Yang <sheng.yang@citrix.com>
2013-12-09 18:28:48 -08:00
Alena Prokharchyk 93fd323357 Resource metadata support for Site2SiteVpnGateway 2013-12-09 17:37:37 -08:00
Nitin Mehta ebbc9292f3 CLOUDSTACK-3664:
scaling up vms was not considering parameter cluster.(memory/cpu).allocated.capacity.disablethreshold. Fixed it
Also added overprovisioning factor retrieval at the cluster level for host capacity check
2013-12-09 15:03:20 -08:00
Nitin Mehta 5d9335fcc3 CLOUDSTACK-3664:
scaling up vms was not considering parameter cluster.(memory/cpu).allocated.capacity.disablethreshold. Fixed it
Also added overprovisioning factor retrieval at the cluster level for host capacity check
2013-12-09 14:51:59 -08:00
Frank.Zhang fca7dd29ab Merge branch '4.3' of https://git-wip-us.apache.org/repos/asf/cloudstack into 4.3 2013-12-09 14:47:37 -08:00
Frank.Zhang c0724349a6 CloudStackCLOUDSTACK-5350
[Automation] Failed to attach volume to VM, if the vm is created with
option startvm=false

duplicate of https://issues.apache.org/jira/browse/CLOUDSTACK-4244
merge the fix to 4.3
2013-12-09 14:47:02 -08:00
Prachi Damle 6df86db230 CLOUDSTACK-5426: Cannot deploy instance having multiple volumes that use different storage tags for storage pools in same cluster
Changes:
- We need to reset the avoid set to its original state while calling the storage pool allocators for each volume.
- This will prevent affecting allocation of the disks due to the avoid set output of the prior disk allocations.
2013-12-09 14:10:55 -08:00
Kishan Kavala 33ff20e1c3 CLOUDSTACK-5145 : Added permission checks while listing network ACLs and acl Items. Users will be able to list items that they have access to. 2013-12-09 19:49:29 +05:30
Alena Prokharchyk c305e4ec5a CLOUDSTACK-5390: obey page/pageSize parameters in listNetworks call
Conflicts:
	server/src/com/cloud/network/NetworkServiceImpl.java
2013-12-06 16:47:41 -08:00
Kelven Yang d931718ab2 CLOUDSTACK-669: put system vm work under new vmsync model 2013-12-06 15:48:10 -08:00
Fang Wang 3f526fb052 cloudstack-4308 Add API listCapabilities for KVMSnapshotEnabled so that UI can use it for recurring snapshot.
Conflicts:
	api/src/org/apache/cloudstack/api/command/user/config/ListCapabilitiesCmd.java
	api/src/org/apache/cloudstack/api/response/CapabilitiesResponse.java
	server/src/com/cloud/server/ManagementServerImpl.java
2013-12-06 15:40:48 -08:00
Prachi Damle 3a6adb3c58 CLOUDSTACK-5399: Add option to createVolume API to specify a VM, to place the volume appropriately and attach immediately
Changes:

    - Added 'virtualmachineid' parameter to the createVolume API to specify a VM for the volume. The Vm should be in 'Running' or 'Stopped' state.
    - This parameter is used only when createVolume API is called using snapshotid parameter
    - When this parameter is set, the volume is created from the snapshot in the pod/cluster of the VM. Also the volume is then attached to the VM in the same request
    - If attach Volume fails but create has succeeded, the API errors out but the Volume created remains available. User may attach the same volume later
    - When Vm is provided, but if no storage pool is available in the VM's pod/cluster then the volume is not created and API fails.
2013-12-06 13:18:37 -08:00
Prachi Damle 5c984eaef8 CLOUDSTACK-5140: A stopped vm cant start after disable threshold has been reached on the storage pool
Changes:
- Do not do the stoarge capacity check for a VM having READY Volumes that are already present on the storagepool.

Conflicts:

	server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java

Conflicts:

	server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java
2013-12-06 13:18:34 -08:00
Devdeep Singh 1a4604576a CLOUDSTACK-5339: Porting the fix for enabling vhdx virtual disk type for hyperv. 2013-12-06 18:05:50 +05:30
Anthony Xu 65642e98b7 XS VMmetadata platform contains virtual platform related info, CS should save platform info in DB to migrate the VM to other Cluster
fixed typo
2013-12-06 01:16:11 -08:00
Frank.Zhang 80e88dd482 fix merge error breaking compile 2013-12-05 18:04:58 -08:00
Frank.Zhang d3bff27ef9 CLOUDSTACK-5112
[Baremetal]Make IPMI retry times configurable

Conflicts:

	server/src/com/cloud/configuration/Config.java
	setup/db/db/schema-420to421.sql
2013-12-05 17:30:54 -08:00
Frank.Zhang fd5b9a2780 CLOUDSTACK-4674
[baremetal] /usr/share/cloudstack-common/scripts/util/ipmi.py script
need to recognize various ipmi version and BMC type of server
2013-12-05 17:28:20 -08:00
Nitin Mehta c06e69db19 CLOUDSTACK-5391:
check for host cpu capability while stop starting a vm on the same host. Also changed the FirstFitAllocator to use the same method.
2013-12-05 15:18:30 -08:00
Nitin Mehta 25e51a5716 CLOUDSTACK-4880:
check for host cpu capability while dynamic scaling a vm on the same host
2013-12-05 14:18:51 -08:00
Nitin Mehta 1cdc064c43 CLOUDSTACK-4880:
check for host cpu capability while dynamic scaling a vm on the same host
2013-12-05 14:14:31 -08:00
Anthony Xu 0847ccfe97 XS VMmetadata platform contains virtual platform related info, CS should save platform info in DB to migrate the VM to other Cluster
Conflicts:
	engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
	plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
	server/src/com/cloud/template/TemplateManagerImpl.java
2013-12-05 01:17:56 -08:00
Alena Prokharchyk 06d2e768b6 CLOUDSTACK-5152: when deployVm with SG, verify that vm and sg belong to the same account. Do this verification even when the call is done by the ROOT admin 2013-12-04 11:37:24 -08:00
Likitha Shetty 2794a9398f CLOUDSTACK-5172. Detaching VM volume is not allowed if there are VM snapshots because any changes to the disk layout will break the semantics of VM-based snapshot 2013-12-04 20:17:58 +05:30
Alena Prokharchyk b315ca1895 CLOUDSTACK-5261: support for alert publishing via Root admin web api
listAlerts: introduced new parameter "name" to the alertResponse

Added new Admin API - generateAlert. Available to ROOT admin only

listAlerts: implemented search by alert name
2013-12-03 17:08:23 -08:00
Darren Shepherd 97dc85caee Make com.cloud.network.vpn.RemoteAccessVpnService an extensible type 2013-12-03 16:03:49 -08:00
Nitin Mehta c1be404924 CLOUDSTACK-3364:
change updateIsoPermissions API to accept isextractable paramter from normal user
2013-12-03 14:54:59 -08:00
edison su 78c77ec905 0001-Fixed-issue-with-DataStoreDrivers-not-being-able-to- 2013-12-03 13:16:50 -08:00
Devdeep Singh 80a5dd75cd Changes for allowing migration of a vm on hyperv. Migration was blocked in cloudstack for hyperv.
Enabled it. Also updated the agent code to allow hyperv migration.
2013-12-03 17:27:24 +05:30
Bharat Kumar 089c7bc9f8 CLOUDSTACK-5161 use a map to specify the custom parameters instead of having one parameter each 2013-12-03 16:53:58 +05:30
Nitin Mehta ecfd486938 CLOUDSTACK-4881:
changeServiceForVirtualMachine API should be used to scale up a stopped vm only
2013-12-02 17:49:07 -08:00
Jayapal 8581e58165 CLOUDSTACK-1762 Fixed assigning network or broadcast ip to nic 2013-12-02 10:53:51 +05:30
Bharat Kumar 72e0354661 CLOUDSTACK-5161 enable scaling and upgrading of a vm using custom offering
Signed-off-by: Koushik Das <koushik@apache.org>
2013-11-29 18:32:16 +05:30
Wei Zhou db5739b83f CLOUDSTACK-5299: set hypervisor_type of volumes from image format if not set.
(cherry picked from commit 221aea5730)

Conflicts:

	server/src/com/cloud/api/query/dao/VolumeJoinDaoImpl.java
2013-11-29 10:54:28 +01:00
Likitha Shetty aef392de99 CLOUDSTACK-5302. listHosts API response - value of cpuallocated is always 0% 2013-11-28 15:47:40 +05:30
Alena Prokharchyk 4edc3989bb Resource metadata support for NetworkACLItem 2013-11-27 14:37:28 -08:00
Wei Zhou 3d601ba41a CLOUDSTACK-5293: fix issue when collect vm disk statistics from iso
(cherry picked from commit f17f35eeb8)
2013-11-27 14:43:47 +01:00
Alena Prokharchyk c9b0a8b1f4 Resource metadata support for NetworkACLList 2013-11-26 17:22:32 -08:00
Alena Prokharchyk 1fe8efc85f Resource metadata support for VPC Private Gateway 2013-11-26 12:48:41 -08:00
Wei Zhou 895e581e73 CLOUDSTACK-2940: Allowing Replacement of realhostip.com with a customized domain for SSVM
(cherry picked from commit e23b10319f)
2013-11-26 14:26:09 +01:00
Wei Zhou 3deb7dd6f5 CLOUDSTACK-5272: return unlimit if max.account.* or max.project.* is set to negative
(cherry picked from commit 888ddd724a)
2013-11-26 14:26:01 +01:00
Bharat Kumar 6af8021ef7 CLOUDSTACK-5162 Usage details are not getting populated when using dynamic offerings.
Signed-off-by: Koushik Das <koushik@apache.org>
2013-11-26 17:45:13 +05:30
Anshul Gangwar 30238f0c72 CLOUDSTACK-4959: added the connection and socket timeout parameters for SMTP and sending message in new thread so that HA doesn't get blocked beacause of hang in sending email alert 2013-11-26 16:40:39 +05:30
Alena Prokharchyk f5c29c0f1a ListPortFowardingRules: added networkId to the list of optional parameters to list by 2013-11-25 15:30:55 -08:00
Nitin Mehta 97e47f8847 CLOUDSTACK-5221:
In order to keep backward compatibility, listisos should return an empty response than an error when id of a removed iso is passed.
2013-11-25 13:48:30 -08:00
Hugo Trippaers c714a9f3db StoragePoolResponse.getId() returns a String with an UUID 2013-11-22 16:21:18 -08:00
Edison Su 70fed9f387 Add a new method on datastoredriver: getCapabilities, which will be called by liststoragepoolcmd. UI can make decision based on the capabilities of the storage.
And also add a new table: snapshotdetails

Conflicts:
	plugins/storage/volume/default/src/org/apache/cloudstack/storage/datastore/driver/CloudStackPrimaryDataStoreDriverImpl.java
2013-11-22 16:20:41 -08:00
Min Chen 44a81519ce CLOUDSTACK-5246:Xenserver - Hourly Snapshots - Creating snapshot from
ROOT volume fails with NullPointer Exception due to new jobs framework
merge.
2013-11-22 10:45:24 -08:00
Alena Prokharchyk cb14dad75b Resource metadata - support for VPC
Conflicts:
	api/src/com/cloud/server/ResourceTag.java
	server/src/com/cloud/metadata/ResourceMetaDataManagerImpl.java
2013-11-21 12:59:49 -08:00
Alena Prokharchyk 98ed8b7e59 Added missing @Inject to the ipAddressManager 2013-11-21 12:50:04 -08:00
Likitha Shetty b1e0f50145 CLOUDSTACK-5227. Cannot pass Japanese characters as parameter values to an API.
During API check for control characters use pattern matching to avoid identifying all non-printable characters as control characters.
2013-11-21 13:38:09 +05:30
Kelven Yang 367db2e45f Newly added VR monitoring service has broken VMware basic network mode. 2013-11-20 18:18:48 -08:00
Kelven Yang 7be9b121cf CLOUDSTACK-669: Add host level side-by-side VM state report for graceful sync model migration 2013-11-20 18:17:29 -08:00
Likitha Shetty f15c997769 CLOUDSTACK-5069. Added global config 'vmware.vcenter.session.timeout' to make the vCenter session timeout value configurable. 2013-11-20 16:02:50 +05:30
Syed Ahmed 041089afe2 Adding protocol parameter to loadbalancer response 2013-11-20 11:22:37 +05:30
fjkdf 7ed2a21c29 add mgt.server.vendor global configuration, in case different vendor wants to identify its identity 2013-11-19 18:01:45 -08:00
Kishan Kavala 8457538161 Fix listRouter by clusterId and upgradeRouterTemplate by clusterId 2013-11-18 13:15:42 +05:30