34d097f349
Fix 4 findbugs warnings in JuniperSrxResource Data should be read and written in UTF-8 to the SRX Buffers were being used for reading but not for writing, PrintWriter was auto-flushing and code was explicitly flushing again, causing unnecessary operation to be performed.
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #399
2015-06-15 21:49:43 +03:00
4b4c52ea77
CLOUDSTACK-8560: Stat the resulting image after copying from template and return the size
...
This way we update the DB with the actual size of the disk after deployment from template
2015-06-15 17:55:56 +02:00
9511831f0a
Fix 2 findbugs warnings in ElastistorUtil.java Unnecessary boxing/unboxing of long value
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #429
2015-06-15 12:09:47 +03:00
ea31a674a4
Fix findbugs warning in ElastistorPrimaryDataStoreLifeCycle.java Unnecessary boxing/unboxing of primitive value
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #428
2015-06-15 12:09:45 +03:00
6f330f7ab6
Fix findbugs warning in PaloAltoResource.java Unnecessary boxing/unboxing of primitive value
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #427
2015-06-15 12:09:43 +03:00
1494487f72
Fix findbugs warning in NetscalerResource.java Unnecessary boxing/unboxing of primitive value
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #426
2015-06-15 12:09:41 +03:00
be474f95a1
Fixed 4 findbugs warnings in CitrixResourceBase.java Unnecessary boxing/unboxing of primitive values
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #425
2015-06-15 12:09:39 +03:00
16ddd498d5
Fix findbugs warning in UcsManagerImpl.java Integer was being created to assign value to int
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #424
2015-06-15 12:09:37 +03:00
9ba4e9cb86
Fix findbugs warning in OvmResourceBase.java CreatePrivateTemplateAnswer constructor takes long as physicalSize parameter, Long was being created instead
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #423
2015-06-15 12:09:36 +03:00
9d2fef0de8
Fix findbugs warning in HypervDirectConnectResource.java Two boxed Longs were being created instead of simple long
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #422
2015-06-15 12:09:34 +03:00
30457556f9
Fix findbugs warning in BareMetalResourceBase.java Boxed Integer was being instantiated to assign to an int variable
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #421
2015-06-15 12:09:32 +03:00
85ad1b7e0f
Fix 3 findbugs encoding warnings in VmwareStorageProcessor.java Ova templates and metadata should be written to file in UTF-8 Fix warning in UUID generation
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #411
2015-06-15 12:09:13 +03:00
ccd7d41ee3
Resolve findbugs encoding warning
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #392
2015-06-15 12:07:55 +03:00
980d858c34
Add import statements, remove unused FileReader import
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #393
2015-06-15 12:07:49 +03:00
9ad8c70baa
Fix findbugs encoding warning, all .xml files contain only utf-8/us-ascii compatible characters
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-06-15 12:07:49 +03:00
967da97f51
Fix 2 findbugs warnings in VmwareStorageManagerImpl.java Template files and metadata should be written to file in UTF-8
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #410
2015-06-15 12:06:19 +03:00
11fec86ba3
Fix 1 findbugs warning in VmwareResource.java
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #409
2015-06-15 12:06:11 +03:00
474065e98b
Fix findbugs encoding warning in VmwareServerDiscoverer.java Input string should only contain safe characters, since it's derived from a Long object. This just gets rid of the findbugs warning
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #408
2015-06-15 12:06:01 +03:00
f8b364b7c7
Was safe either way as this piece of code should only run in linux, this just gets rid of the findbugs warning
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #402
2015-06-15 12:04:47 +03:00
3299f23ea2
Fix findbugs encoding warning in LibvirtCreatePrivateTemplateFromVolumeCommandWrapper Libvirt templates should be written in UTF-8, default was already doing that so this just gets rid of the findbugs warning
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #401
2015-06-15 12:04:24 +03:00
b869a16332
Remove unused import to fix checkstyle warning
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #400
2015-06-15 12:04:19 +03:00
949e97dec6
Fix findbugs warning in LibvirtConsoleProxyLoadCommandWrapper Encoding is now specified in both server and clients for the console proxy getstatus command For some reason, findbugs did not detect unsafe encoding issue in ConsoleProxyResource.java, is properly specified now though... CitrixConsoleProxyLoadCommandWrapper was specifying system default encoding for operation, should be ok because default for xenserver is UTF-8 since it's linux based, but it's best to specify exact encoding set on the server end to be consistent
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-06-15 12:04:18 +03:00
509c83bc74
Fix findbugs encoding warning in JuniperSrxResource All .xml files contain only utf-8/us-ascii compatible characters. If special characters are added to these files in the future, UTF-8 should be used for cross platform compatibility
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #398
2015-06-15 12:03:56 +03:00
cc6d28fc98
Fix another findbugs encoding warning in CitrixResourceBase In this case, using default encoding is desired, since the purpose is to read shell command output, which uses the platform's default encoding. This gets rid of the findbugs warning.
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #396
2015-06-15 11:59:48 +03:00
faa38ad416
Fix findbugs encoding warning in CitrixResourceBase Output of text files should be UTF-8, this is the default for linux, will now always use the same format for every platform
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #395
2015-06-15 11:59:38 +03:00
aeccd8afdf
Fix findbugs encoding issue This is done by calling HttpMethodBase's getResponseBodyAsString() which properly lookup the specified encoding in the request's Content-Type header This also avoids instantiation of two extra strings on the println() and return statements
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #394
2015-06-15 11:59:09 +03:00
d504305a98
Fixed CLOUDSTACK-8551 findbugs issue in LdapImportUsersCmd.java
...
DM_DEFAULT_ENCODING issue. Used UTF-8
2015-06-11 17:07:03 +05:30
d46b658ec0
Fixed CLOUDSTACK-8551 Findbugs warning in LdapCreateAccountCmd.java
...
byte[].toString() would give reference to the array (ex: [B@6c521576 )
but not the original string. used new String() to get the text.
2015-06-11 14:05:03 +05:30
5e41a830a5
This closes #373
...
CLOUDSTACK-3317 - DVS does not support management\storage network
Added support for Management and Storage Network traffic over VMware DVS in CloudStack deployments. Also added support for storage VLAN over dvPortGroup.
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
CLOUDSTACK-3317 - DVS does not support management\storage network
Use non-zero dvport count while updating dvportgroups of system traffic.
Updated configuration compare logic to avoid update dvportgroup operation unless required.
This would help improve speed in vm/network deployment as the update calls would reduce. Also improved logging.
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
Adding unit tests in class HypervisorHostHelperTest
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
Added license header to new file being added to repo/branch.
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2015-06-10 02:07:40 +05:30
b272d7717e
Revert "Fix 2 findbugs high priority warnings"
...
This reverts commit 1ca74dac26
2015-06-08 10:01:19 +02:00
c5437d216f
Fix malformed closing tag on comments in cisco .xml files
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #369
2015-06-08 09:41:13 +02:00
b9b13d764d
Fix another case of unnecessary boxing JuniperSrxResource.java:1280, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High Boxing/unboxing to parse a primitive com.cloud.network.resource.JuniperSrxResource.removeDestinationNatRules(Long, Map, List)
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #367
2015-06-08 09:41:07 +02:00
039d632ad3
Fix 3 more findbugs performance alerts, creating Long and Integer unnecessarily F5BigIpResource.java:297, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High F5BigIpResource.java:703, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High F5BigIpResource.java:889, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High Boxing/unboxing to parse a primitive com.cloud.network.resource.F5BigIpResource
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #366
2015-06-08 09:40:59 +02:00
e8c7069f73
Fix findbugs high priority warning VmwareStorageManagerImpl.java:1023, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE, Priority: High Redundant nullcheck of datastoreVolumePath, which is known to be non-null in com.cloud.hypervisor.vmware.manager.VmwareStorageManagerImpl.getVolumePathInDatastore(DatastoreMO, String)
...
Assertion is not used in runtime, correct way is throw and handle exception without killing app
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #362
2015-06-08 09:40:50 +02:00
9bac84a3f7
Fix last ocurrence of unnecessary boxing detected by findbugs CiscoVnmcResource.java:266, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High Boxing/unboxing to parse a primitive com.cloud.network.resource.CiscoVnmcResource.getIpRangeFromCidr(String)
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #368
2015-06-08 09:39:02 +02:00
38c269d71e
Fix performance issue reported by findbugs (unnescessary boxing/unboxing) VmwareResource.java:693, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High VmwareResource.java:4769, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High Boxing/unboxing to parse a primitive com.cloud.hypervisor.vmware.resource.VmwareResource.getNetworkStats(String)
...
Now op is faster and takes up less memory
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #365
2015-06-08 09:32:52 +02:00
65383fb8fa
Fix another findbugs high priority warning JuniperSrxResource.java:2617, ES_COMPARING_STRINGS_WITH_EQ, Priority: High Comparison of String objects using == or != in com.cloud.network.resource.JuniperSrxResource.manageApplication(JuniperSrxResource$SecurityPolicyType, JuniperSrxResource$SrxCommand, JuniperSrxResource$Protocol, int, int)
...
This now correctly compares strings
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #364
2015-06-08 09:30:38 +02:00
1ca74dac26
Fix 2 findbugs high priority warnings
...
VmwareResource.java:315, MS_SHOULD_BE_FINAL, Priority: High
com.cloud.hypervisor.vmware.resource.VmwareResource.s_serviceContext isn't final but should be
VmwareResource.java:331, MS_SHOULD_BE_FINAL, Priority: High
com.cloud.hypervisor.vmware.resource.VmwareResource.s_powerStatesTable isn't final but should be
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #363
2015-06-08 09:24:07 +02:00
93845afd53
Using a try-wioth resrouce block as suggested in @DaanHoogland review.
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #355
2015-06-04 12:34:05 +02:00
7f4e2c7cf0
Renaming the variable from "s" to "script"
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
2015-06-04 12:34:05 +02:00
6138d9a690
Coverity issue 1116812 - Replacing concatenation with optionsBuffer.append(option.getKey()).append('=').append(option.getValue()).append(',');
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
2015-06-04 12:34:05 +02:00
9ff38486a1
Coverity issue 1116677 - Avoiding catching only Exception. Makes the code too britle. - Catching the QemuImgException and throwing it to be caught further in the code - Surrounding the output stream with try/catch and throwing it to be further handled in the code. Closing the output stream quietly.
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
2015-06-04 12:34:05 +02:00
6271663682
Formatting the code - Adding final modifier and indenting the code
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
2015-06-04 12:34:04 +02:00
fe78c76691
Coverity issue: 1012179 - Commenting out unused variable.
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
2015-06-04 12:34:03 +02:00
159d8c2c97
Formatting the code - Adding final modifier to attributes and indenting the code.
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
2015-06-04 12:34:03 +02:00
3d4d152753
CID 1302976 Scanner in try-with-resource
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #352
2015-06-04 00:09:40 +02:00
109b6e94d3
CID 1302974: Scanner in try-with-resource
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #353
2015-06-04 00:09:16 +02:00
f341246888
CLOUDSTACK-8530: KVM hosts without active agents should be in Disconnected state
...
KVM hosts which are actuall up, but if their agents are shutdown should be put
in disconnected state. This would avoid getting the VMs HA'd and other commands
such as deploying a VM will exclude that host and save us from errors.
The improvement is that, we first try to contact the KVM host itself. If it fails
we assume that it's disconnected, and then ask its KVM neighbours if they can
check its status. If all of the KVM neighbours tell us that it's Down and we're
unable to reach the KVM host, then the host is possibly down. In case any of the
KVM neighbours tell us that it's Up but we're unable to reach the KVM host then
we can be sure that the agent is offline but the host is running.
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>
This closes #340
2015-06-02 13:27:16 +02:00
607a63b12d
Mocking the Connect object used in the LibvirtMigrateCommandWrapper
...
When executing the tests in an environment where Libvirt is also installed, it
caused errors.
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #342
2015-06-01 21:11:25 +02:00
b267c5fc5a
Replacing real IPs by 127.0.0.1. - It was causing problems in some environments - The Ips should have been removed in a previous commit, but some of them were missed
...
Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>
This closes #325
2015-05-29 11:25:40 +02:00
Rafael da Fonseca
Wido den Hollander
Rajani Karuturi
Sateesh Chodapuneedi
Daan Hoogland
wilderrodrigues
Rohit Yadav