Commit Graph

2257 Commits

Author SHA1 Message Date
prachi ee598d44c5 Bug 9548 [Cloud Stack Upgrade - 2.1.8 to 2.2.4] System VM's Volumes Recreation is not happening on an event of New Volume creation Failures
Changes:
- Reason was that the old volume's templateId was being updated before volume creation was attempted. So on the retry, we dint find a difference in volume's templateId and VM's templateId and did not enter the recreation logic.

- Fix is to update the new volume's templateId with the VM's templateId while creating the new volume. The old volume's templateId stays the same and the volume is marked as 'Destroy' when a new volume is created.
2011-04-26 11:55:05 -07:00
alena 25017382b6 bug 9563: fixed DB upgrade from 2.2.2/2.2.3 to 2.2.4
status 9563: resolved fixed

Also added unittest for 2.2.2 to 2.2.4 upgrade
2011-04-23 23:03:45 -07:00
alena 6f76104a0e DB upgrade: use is_static_nat field to distinguish between 2.2.1 and 2.2.2 versions 2011-04-23 21:23:07 -07:00
alena eb7a158e72 bug 9555: db upgrade for Basic zone - set default nic for the domR
status 9555: resolved fixed
2011-04-23 20:03:33 -07:00
alena 8b0b503861 bug 9556: set ip_type=ip4 for guestVm nics in Basic zone setup
status 9556: resolved fixed
2011-04-23 19:56:08 -07:00
alena c8f4dacb0a bug 9550: get storagePool to Host mappings before doing processDisconnect because these references are being deleted as a part of processDisconnect call.
status 9550: resolved fixed
2011-04-23 18:34:39 -07:00
prachi 074e143986 Manually Merged from master the remaining changes for Bug 9539 - cpu.overprovisioning.factor does not work 2011-04-22 18:58:00 -07:00
prachi 5706041ef7 Manual merge of Bug 9539 - cpu.overprovisioning.factor does not work
Partial Changes:
- Changed host allocators/planner  to use cpu.overprovisioning.factor
- Removed following: while adding a new host, we were setting the total_cpu in op_host_capacity to be actual_cpu * cpu.overprovisioning.factor. Now we set it to actual_cpu.
- ListCapacities response now calculates the total CPU as actual * cpu.overprovisioning.factor (This change does not add anything new - listCapacities was pulling total CPU from op_host_capacity DB earlier which had the cpu.overprovisioning.factor applied already. Now we need to apply it over the DB entry.)
- HostResponse has a new field: 'cpuWithOverprovisioning' that returns the cpu after applying the cpu.overprovisioning.factor

- Db Upgrade 222 to 224 now updates the total_cpu in op_host_capacity to be the actual_cpu for each Routing host.

Conflicts:

	server/src/com/cloud/agent/manager/AgentManagerImpl.java
	server/src/com/cloud/api/ApiDBUtils.java
	server/src/com/cloud/api/ApiResponseHelper.java
	server/src/com/cloud/deploy/BareMetalPlanner.java
	server/src/com/cloud/server/ManagementServerImpl.java
2011-04-22 18:54:16 -07:00
anthony eccec4ff11 bug 9541: fix one snapshot DB migrate, one java check and one script typo
status 9541: resolved fixed
2011-04-22 12:50:40 -07:00
anthony b219d3e83e cluster guid is set up when old host reconnect happens after upgrade, prohibit adding host to the cluster before guid is etup 2011-04-21 16:01:04 -07:00
anthony 71f968a3e1 bug 9282: set cluster guid if it is null
status 9282: resolved fixed
2011-04-21 15:41:54 -07:00
Murali Reddy d1650c6e60 Bug 9273: resource count going -ve
adding addtional check that ensure we decrease the count in advanceStart only on new vm creation
2011-04-22 01:37:45 +05:30
root c8d5ef8c29 Merge branch '2.2.4' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 2.2.4 2011-04-21 09:59:48 +05:30
Abhinandan Prateek b979b782c1 bug 9487: race condition in taking ownership 2011-04-21 09:20:50 +05:30
alena e5286339f1 bug 9521: fixed NPE in finalizeCommandsOnStart() method by adding vm's nic to vm profile during the vm to vmProfile conversion.
status 9521: resolved fixed
2011-04-20 16:16:27 -07:00
Abhinandan Prateek 48eebe8e7a bug 9503: race condition in taking ownership of a Host when a Management server is restarted
status 9503: resolved fixed
2011-04-20 16:37:12 +05:30
alena a99f925de1 bug 9383: createStaticNat rule - allow opening the same port for tcp/udp traffic
status 9383: resolved fixed
2011-04-18 18:18:44 -07:00
alena b7a89f2229 bug 9493: fixed the bug in Basic zone when nic_count was updated incorrectly due to multiple domRs per network
status 9493: resolved fixed
2011-04-18 16:49:12 -07:00
alena 4c53dc8d46 Throw server api exception with correct error code 2011-04-18 15:16:06 -07:00
alena c6e1a26934 Update volumes having destroyed=127 with Destroyed state only after ensuring that corresponding account is removed, or instance is expunged 2011-04-18 13:34:59 -07:00
alena 9c8ff68ca7 Added more logging to DB upgrade code 2011-04-18 11:39:44 -07:00
alena a43a7993cb bug 9483: delete records from template_spool_ref if corresponding storage pool doesn't exist any more
status 9483: resolved fixed
2011-04-15 17:07:39 -07:00
will b897508c03 bug 9468: DiskOfferings are now sorted by created date to keep consistent with other objects returned in CloudStack.
Merge from master
2011-04-15 14:27:46 -07:00
alena fcdf791645 bug 9475: don't update vlan in "networks" tab for non-implemented guest networks
status 9475: resolved fixed
2011-04-15 12:00:41 -07:00
alena 5778204e54 Fixed Db upgrade from 2.1.9 to 2.2.2 which wasn't supported before. 2011-04-15 10:17:08 -07:00
alena c2455017e0 Fixed logging for remote access vpn code 2011-04-15 09:58:48 -07:00
alena 234917780e 218-222 upgrade - no need to update user statistics with deviceId if account doesn't own any domRs 2011-04-15 09:45:19 -07:00
alena ce984ce89c bug 9453: Fixed PF rules upgrade.
status 9453: resolved fixed

1) Problem #1 was that in 2.1.x there was a bug when we didn't delete pf rules for expunged vms. These kind of rules will be ignored during the db upgrade
2) Problem #2. We didn't trim the spaces for PF/LB ports in 2.1.x, and DB upgrade code was failing because of that.
2011-04-14 20:35:34 -07:00
alena fba10b1cb8 bug 9461: don't update user_statistics with the network id if the domR is already expunged
status 9461: resolved fixed
2011-04-14 17:53:38 -07:00
alena c3c80006ca bug 9453: domain path is not unique value, removed the constraint added during 2.1.8-2.2.2 upgrade 2011-04-14 16:55:55 -07:00
Edison Su 8b9fc424d5 bug 8532,8755: don't create multiple HA work if there already has one of HAwork of this VM is created, but not finished
status 8532: resolved fixed
status 8755: resolved fixed
2011-04-14 16:55:06 -04:00
alena a76803f5e5 bug 9458: do searchIncludingRemoved when decrement resource count as corresponding domain might be removed already
status 9458: resolved fixed
2011-04-14 15:25:37 -07:00
anthony c6018bdc60 bug 9455: when host is disconnected, also remove entry in storage_pool_host_ref
status 9455: resolved fixed
2011-04-14 14:34:32 -07:00
alena 78aad72ffb bug 9407: lock network when do deployDomR/deployDhcp to avoid 2 network elements start for the same network
status 9407: resolved fixed
2011-04-14 13:19:04 -07:00
anthony 21c936ab15 bug 9411:
1. adding storage pool fails, remove the entry in DB
2. in introduce SR, create pbd for master host

status 9411: resolved fixed
2011-04-14 11:16:45 -07:00
root 2ab9238ae7 Bug 9440: we specify the wrong disk size when attaching storage device with custom size offering
wrong usage of volume size which is in bytes for setting the size of disk offering  which in MB
2011-04-14 21:25:23 +05:30
Alex Huang 7b0f95a466 bug 9422: added rows in op_networks table to correspond to the rows in networks table 2011-04-14 03:53:51 -07:00
Alex Huang 256517f1c3 bug 9422: added rows in op_networks table to correspond to the rows in networks table 2011-04-14 03:17:55 -07:00
anthony 3f4c5225dd fixed transaction usage 2011-04-13 19:35:13 -07:00
prachi fede78bea8 More changes for Bug 9438 - [Cloud Stack Upgrade - 2.1.8 to 2.2.4] Secondary Storage VM could not start after stopping it.
Added log statement to indicate that a pool is not chosen because the vm template has no entry in template_host_ref table.
2011-04-13 18:09:28 -07:00
alena 9afee0bb46 bug 9433: update network_id (if 0 or NULL) in user_statistics table
status 9433: resolved fixed
2011-04-13 17:48:49 -07:00
alena 7acba22063 bug 9436: include page/pageSize/keyword to api xml doc for each list* command
status 9436: resolved fixed
2011-04-13 16:19:44 -07:00
anthony 8d36af0033 fixed NPE 2011-04-13 16:03:41 -07:00
alena 98be7ea0f7 bug 9425: fixed detached volume removal.
status 9425: resolved fixed
2011-04-13 15:52:55 -07:00
alena 6468b66317 bug 9420: update existing user_statistics records with device_id and device_type
status 9420: resolved fixed
2011-04-13 14:31:33 -07:00
prachi 5a73309e75 Bug 9387: Recreate system vms if template id changed....
Changes:
While starting a System VM:
- We check, incase the ROOT volume is READY, if the templateID of the volume matches the SystemVM's template.
- If it does not match, we update the volumes' templateId and ask deployment planner to reassign a pool to this volume even if it is READY.

In general:
- If a root volume is READY, we remove its entry from the deploydestination before calling storagemanager :: prepare()
- StorageManager creates a volume if a pool is assigned to it in deploydestination passed to it.
- If a volume has no pool assigned to it in deploydestination, it means the volume is ready and has a pool already allocated to it.
2011-04-13 13:54:08 -07:00
anthony e001436d94 fixed NPE when delete storagepool 2011-04-13 11:02:12 -07:00
Murali Reddy 3a1fe780cf Bug 9273 : resource counts going -ve
Fixing resource count getting -ve assert. resource count should not be decremented for system VM's.
2011-04-13 17:35:09 +05:30
prachi edda8e8032 More changes for Bug 9387:
- Update system vm_instance's template_id if it does not match the system vm template.
- Use _templateDao.findSystemVMTemplate to find the latest system vm template.
2011-04-12 18:31:46 -07:00
prachi e2451f6b15 More changes for 9387:
Checks in StorageManagerImpl :: prepare() method to avoid NPE's if DeployDestination passed in is null.
2011-04-12 18:31:37 -07:00
prachi fc35aed2c9 Bug 9387 - Recreate system vms if template id changed...
Changes:
- Planner must reassign the storage pool if the template id for system vms has changed.  StorageManager must then recreate the volume if the volume has been
reassigned.  This is needed to do automatic update of the system template.
2011-04-12 18:31:27 -07:00
Chiradeep Vittal fe4d5845c2 bug 9330: ensure that console proxies are always created from the same hypervisor type 2011-04-12 15:15:01 -07:00
Chiradeep Vittal a9f88c5b0c bug 9330: discover system vm template for a given hypervisor type 2011-04-12 14:49:41 -07:00
alena 5de4f05a1c bug 9391: removed source_id, source_type from "volumes" table as we don't use them any more
status 9391: resolved fixed
2011-04-11 17:33:38 -07:00
anthony bd6661c3d2 bug 9392: don't lock domr entry, otherwise updating domr state fails
status 9392: resolved fixed
2011-04-11 16:08:05 -07:00
alena 90f79a8211 bug 9398: removed resource_type from volumes table as we no longer use it. Corresponding db upgrade scripts are updated
status 9398: resolved fixed
2011-04-11 15:25:34 -07:00
Chiradeep Vittal a8487454e8 bug 9330: add kvm / vmware system vm template definitions 2011-04-11 14:35:27 -07:00
prachi 04b9f7c7a5 Some more changes for Bug 8932 - add md5 sum to list templates call:
Also changed 'RegisterTemplate' to take in a new optional parameter 'checksum'.
The value set to it is stored as-is in the DB in vm_template table, 'checksum' column.
2011-04-11 13:30:35 -07:00
alena 93429a16d8 bug 9381: set accountId=domainId=1 for system vms in vm_instance table
status 9381: resolved fixed
2011-04-11 10:10:05 -07:00
alena 6f0da71c1a bug 9380: db upgrade - use the same case for 'hypervisor_type' in 'vm_instance' table
status 9380: resolved fixed
2011-04-11 09:59:23 -07:00
kishan b5bf6e9bee Usage upgrade changes 2011-04-11 18:54:10 +05:30
prachi 65d589da73 Bug 8932 - add md5 sum to list templates call
Modified TemplateResponse to contain a new field 'checksum' of the template. The value is pulled from the vm_template table, 'checksum' column.

Conflicts:

	server/src/com/cloud/api/ApiResponseHelper.java
2011-04-08 15:20:47 -07:00
Murali Reddy 95cd5b6f3b bug 9273: [Stress Test] 'Count' in resource_count table has negative values
changing destroy volume logic to decrement volume resource count only for user vm's
2011-04-09 02:01:54 +05:30
Murali Reddy 55caa1d60a bug 9312: deleteAccount API does not decrement User VM resource count when VM is destroyed
status 9312: closed fixed

Decrementing the resource count when we expunge VM.
2011-04-08 17:22:13 +05:30
Murali Reddy ba7abb4da8 bug 9129:can't create vm if an instance limit is set at root domain 2011-04-08 07:07:50 +05:30
Murali Reddy 4822fcae13 Bug 9273 - Count' in resource_count table has negative values
Resolved Fixed
2011-04-06 18:18:38 +05:30
Kelven Yang 623792dfaf bug 9328: always add explict route to domR 2011-04-05 17:29:52 -07:00
prachi 5fbf83c24f Bug 9045: No 'Starting job for VM.MIGRATE' & 'Successfully completed VM.MIGRATE' events shown for VM manual migration
Changes:
- Added the required 'ActionEvent' annotation to the API, so that the events get added.
2011-04-05 16:36:00 -07:00
anthony 5353e4abac hostid and poolid may overlap, fixed deletePoolStats 2011-04-05 16:01:30 -07:00
prachi 9f10d9957e Bug 9309 - In Manual migration, do not consider 'reserved_capacity' when computing available memory in destination
Changes:
- Now while listing hosts for migration, capacity is calculated as total_capacity -used_capacity
 instead of total_capacity -(used_capacity + reserved_capacity)
- Also, the capacity columns in op_host_capacity are now 'signed' type so that the subtractions in queries does not overflow.
- Added this to DB upgrade 222 to 224 change as well.
2011-04-05 14:16:21 -07:00
alena 61f968592b bug 9306: set isolationUri/broadcastUri for SSVM/domR/CPVM public nics
status 9306: resolved fixed
2011-04-05 09:18:43 -07:00
Alex Huang 04099a4950 bug 9311: changed instance_id to nic_id 2011-04-05 09:12:55 -07:00
alena 49cbcac29f bug 8959: fixed mac address generation for public ip addresses 2011-04-04 18:31:19 -07:00
alena 534623706d bug 9305: set Mode field for domR/CPVM/SSVM nics
status 9305: resolved fixed
2011-04-04 18:31:07 -07:00
prachi 204aa86686 Bug 9043 - VM manual migration - when destination host is out of memory for migration, VMs being migrated remained in 'migrating' state
Changes:
- When migration fails we try to do cleanup on the destination host agent. The AgentUnavailableException in this cleanup was not caught.
-Due to that other cleanup like reverting capacity allocated and vm state were skipped.
-Fix is to catch the AgentUnavailableException so that rest of the cleanup can happen.
- Also corrected the exceptions in various cases of migration failure.
- In case the VM is still starting, HA should schedule a retry. Introduced a special migration exception for handling this.
2011-04-04 17:39:27 -07:00
Alex Huang b2cab48e0c bug 9308: changed instance_id to nic_id 2011-04-04 16:59:16 -07:00
alena f8fce16cac bug 9274: listPublicIpAddresses - don't list Direct ip addresses by default; list them only when "forVirtualNetwork=false" is specified in the request.
status 9274: resolved fixed
2011-04-04 15:43:04 -07:00
alena f2921b7f15 bug 9272: fixed the race condition bug when we tried to remove vm from SG after it was expunged (expunge interval was really small, 60 sec).
status 9272: resolved fixed

When do search for vm, do includingRemoved search.
2011-04-04 15:43:04 -07:00
Alex Huang e8720cc1f7 bug 9300: changed the network id to management from storage for ssvm 2011-04-04 13:53:51 -07:00
Alex Huang fc7f526090 bug 9282: changed the broadcast domain type for control and public network 2011-04-04 09:56:56 -07:00
Alex Huang 5a6d3dc55c bug 9280: added gateway and cidr for control network 2011-04-04 09:50:16 -07:00
kishan 4f97d4652d Skip event migration when usage db doesn't exist 2011-04-04 18:31:48 +05:30
alena 29bfde9da4 Revert "bug 8898: allow service offering upgrade for Running vm"
This reverts commit 7668e1878a.
2011-04-01 18:16:14 -07:00
Alex Huang 8b34065623 bug 9259: added upgrade test suite 2011-04-01 10:32:23 -07:00
kishan 7b55b41556 bug 9239: Ignore optional zone Id for Snapshot delete events
status 9239: resolved fixed
2011-04-01 15:15:00 +05:30
kishan 7f08061e72 Added missing semi-colon and corrected usage unit test error messages 2011-04-01 12:06:52 +05:30
prachi 492dd78f1c Bug 9180 - Default local SR on XenServer won't be used
- Update the diskoffering for system VMs to change the value of use_local_storage, when the global config 'system.vm.use.local.storage' is changed.
2011-03-31 23:11:11 -07:00
anthony 2c85092316 bug 9161: better fix 2011-03-31 18:24:57 -07:00
anthony afd7adc775 bug 9161: findByOutstandingWork means find all works with step not equal Done 2011-03-31 18:03:59 -07:00
alena 703537d222 bug 9248: generate events on service/diskOffering create/update/delete
status 9248: resolved fixed
2011-03-31 16:30:11 -07:00
alena 7e7c647dea bug 9245: save ownerAccountId (instead of callerAccountId) to account_id field in async_job table. We already save caller info to user_id field
status 9245: resolved fixed
2011-03-31 15:31:27 -07:00
anthony db351f8cba bug 9249: use interval type , not snapshot type
status 9249: resolved fixed
2011-03-31 13:55:34 -07:00
alena 6d7f3da46a For VirtualRouter apply networkThrottling rate of the GuestNetworkOffering to both Guest and Public networks. 2011-03-30 14:53:04 -07:00
alena a1a2717811 bug 9192: don't query for securityGroups when Vm's zone is security group disabled.
status 9192: resolved fixed
2011-03-30 09:40:45 -07:00
kishan e276d3b7fb bug 7631: Convert unprocessed events to usage_events
status 7631: resolved fixed
2011-03-30 11:19:04 +05:30
alena c1db5aea31 Fixed NPE in listVirtualMachines command - when search for ROOT volume's storagePool type, assume that corresponding storagePool might be removed. 2011-03-29 20:21:26 -07:00
alena aab78874c7 bug 9201: listNetworkOfferings - return -1 when network_rate is Unlimited; if value is NULL - return global configuration value
status 9201: resolved fixed
2011-03-29 19:21:25 -07:00
alena f04f2ab10c bug 9192: More improvements to listVm performance - cache dataCenter/serviceOffering/Network/Template/Iso information on Api level
status 9192: resolved fixed
2011-03-29 19:18:30 -07:00
alena 2af46789cb bug 9192: multiple improvementes to listVms command.
1) No longer do multiple searches involving "domain" table; only one join with domain is being done.
2) Do join with domain table only when command is executed by domainAdmin
3) Added index for "path" field in "domain" table
4) No longer do joins with account table as account_id is already present in vm_instance table.
2011-03-29 19:18:30 -07:00
Edison Su a7953c1e7a bug 9205: resolved fixed
status 9205: fix NPE in usageEvent
2011-03-29 14:57:16 -04:00