Commit Graph

8263 Commits

Author SHA1 Message Date
Yashika 38181b2afa
Optional chaining used to enhance readability (#5961)
* Optional chaining used to enhance readability

* Added Suggested change

Co-authored-by: YashikaSarkar <65132044+YashikaSarkar@users.noreply.github.com>
2022-02-10 01:27:54 -03:00
Rohit Yadav 41d25d54a7 Merge remote-tracking branch 'origin/4.16' 2022-02-08 23:20:12 +05:30
Wei Zhou 6495bc1a47
packaging: display First Install and Onboarding Message (#5851)
* packaging: display First Install and Onboarding Message

* Update #5851: Update as per Rohit's comments

* Update #5851: display package name in help message

* Update #5851: display links of installed cloudstack version on UI

* Update #5851: fix vue warnings
2022-02-08 16:11:03 +01:00
Suresh Kumar Anaparti 208ae84dd7
Merge branch '4.16' into main 2022-02-08 19:01:34 +05:30
Abhishek Kumar 81b49b835a
ui: fix select networks for template nic (#5933)
* ui: fix select networks for template nic

Fixes #5927

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-02-07 16:30:40 +05:30
Daman Arora 649be0d8c7
simplify code using optional chaining in multiple views (#5630)
* simplify code using optional chaining in multiple views

* Undo simplify chaining in CreateL2NetworkForm
2022-02-06 10:09:41 -03:00
dahn 0f1cd6009d
add logging to deployment planners (#5859)
Co-authored-by: sureshanaparti <12028987+sureshanaparti@users.noreply.github.com>

Co-authored-by: Daan Hoogland <dahn@onecht.net>
Co-authored-by: Daniel Augusto Veronezi Salvador <38945620+GutoVeronezi@users.noreply.github.com>
Co-authored-by: sureshanaparti <12028987+sureshanaparti@users.noreply.github.com>
2022-02-04 17:02:32 +01:00
Suresh Kumar Anaparti e3f0e3b544
Merge branch '4.16' into main 2022-02-04 19:04:08 +05:30
Abhishek Kumar 966b32c234
ui: fix ssh keypair navigation (#5931)
Fixes #5930

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-02-04 18:29:47 +05:30
Abhishek Kumar f458964e52
ui: fix related key for section (#5929)
Fixes #5928

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-02-04 10:27:01 +05:30
Suresh Kumar Anaparti bf70566c2c
Merge branch '4.16' into main 2022-02-02 17:30:21 +05:30
Abhishek Kumar 8adb8df2fe
server: find suitable disk offering for volume upload (#5852)
* server: find suitable disk offering for volume upload

Fixes #5696

* fix npe check

* fixes, refactor, rename method and handle custom iops

* ui: allow offering selection

* list only disk offerings

* show name

* revert error check

* use checkaccess

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-02-02 16:35:47 +05:30
dahn c1bba2a308
Do not restart VPC tiers with cleanup (#5873)
* do not restart VPC tiers with cleanup

* no option for cleanup for VPC tiers

* Update server/src/main/java/com/cloud/network/NetworkServiceImpl.java

* paramNames

* remove superfluent parameter

Co-authored-by: Daan Hoogland <dahn@onecht.net>
Co-authored-by: Daniel Augusto Veronezi Salvador <38945620+GutoVeronezi@users.noreply.github.com>
2022-01-31 17:59:26 +05:30
Abhishek Kumar 5f07e4daaf
ui: fix filtering readonly details while VM update (#5887)
* ui: fix filtering readonly details while VM update

* refactor

* error on add

Fixes #5724

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-01-31 17:19:31 +05:30
Suresh Kumar Anaparti f610e89ea9
Merge branch '4.16' into main 2022-01-28 13:43:00 +05:30
davidjumani 6fa8538666
Adding placeholders for custom NSP vues (#5620)
* Adding placeholders for custom NSP vues

* Fix decorator

* Fixing gslbproviderprivateip description
2022-01-27 20:11:35 +05:30
Harikrishna f15cab16da
server: Decouple service (compute) offering and disk offering (#5008)
Currently, our compute offerings and disk offerings are tightly coupled with respect to many aspects. For example, if a compute offering is created, a corresponding disk offering entry is also created with the same ID as the reference. Also creating compute offering takes few disk-related parameters which anyway goes to the corresponding disk offering only. I think this design was initially made to address compute offering for the root volume created from a template. Also changing the offering of a volume is tightly coupled with storage tags and has to be done in different APIs either migrateVolume or resizeVolume. Changing of disk offering should be seamless and should consider new storage tags, new size and place the volume in appropriate state as defined in disk offering.

more details are mentioned here https://cwiki.apache.org/confluence/display/CLOUDSTACK/Compute+offering+and+disk+offering+refactoring

* Schema changes and disk offering column change from "type" to "compute_only"

* Few more changes

* Decoupled service offering and disk offering

* Remove diskofferingid from vminstance VO

* Decouple service offering and disk offering states

* diskoffering getsize() is only for strict disk offerings

* Fix deployVM flow

* Added new API params to compute offering creation

* Add diskofferingstrictness to serviceoffering vo under quota

* Added overrideDiskOfferingId parameter in deploy VM API which will override disk offering for the root disk both in template and ISO case

Added diskSizeStrictness parameter in create Disk offering API which will decide whether to restrict resize or disk offering change of a volume

* Fix User vm response to show proper service offering and disk offerings

* Added disk size strictness in disk offering response

* Added disk offering strictness to the service offering response

* Remove comments

* Added UI changes for Disk offering strictness in add compute offering form and Disk size strictness in add disk offering form

* Added diskoffering details to the service offering response

* Added UI changes in deployvm wizard to accept override disk offering id

* Fix delete compute offering

* Fix VM deployment from custom service offering

* Move uselocalstorage column access from service offering to disk offering

* UI: Separated compute and disk releated parameters in add compute offering wizard, also added association to disk offering

* Fixed diskoffering automatic selection on add compute offering wizard

* UI: move compute only toggle button outside the box in add compute offering wizard

* Added volumeId parameter to listDiskOfferings API and the disksizestrictness flag of the current disk offering is honored while list disk offerings

* Added configuration parameter to decide whether to check volume tags on the destination storagepool during migration

* Added disk offering change checks during resize volume operation

* Added new API changeofferingforVolume API and corresponding changes

* Add UI form for changeOfferingForVolume API

* Fix UI conflicts

* Fix service offering usage as disk offering

* Fix unit test failures

* fix user_vm_view

* Addressed review comments

* Fixed service_offering_view

* Fix service offering edit flow

* Fix service offering constructor to address custom offering

* Fix domain_router_view to get proper service offering id

* Removed unused import

* Addressed review comments and fixed update service offering flow with storage tags

* Added marvin test cases for checking disk offering strictness

* review comments addressed

* Remove system_use column from disk offering join

* update volume_view to update system_use column from service offering and not disk offering

* Fix changeOfferingForVolume API for custom disk offering

* Fix global setting implementation

* Fix list volumes, after changing system_use column from disk offering to service offering in volume_view

* Changes for override root disk offering in deployvm wizard in case of custom offering

* Fix a unit test case

* Fixed recent unit test cases with new serviceofferingvo constructor

* Fix unit test in VolumeApiServiceImpl

* Added storage id for the list disk offering API and corresponding UI changes in migrateVolume and changeOfferingForVolume flow

* Rename global configuration parameter from storage.pool.tags.disk.offering.strictness to match.storage.pool.tags.with.disk.offering

* Fix smoke test failures

* Added tool tip for migrate volume UI form

* Address review comments and fix UI form of deploy VM in case of ISO.

* Fixed resize volume UI form for data disk

* UI changes to disable override root disk size when override root disk offering is enabled

* UI fix in deploy vm wizard

* Fix listdiskoffering after rebasing with main

* Fixed UI in migrate and changeofferingfor volume to handle empty disk offering list
Removed the volume's current disk offering from listDiskOffering response list

* Added custom Iops to resize volume form and removed the current disk offering during change offering for volume UI form

* Fix false response on updateDiskOffering API

* Added search field for changeofferingforvolume UI form

* Fix resize volume and migrate volume to update volume path if DRS is applied on volume in datastore cluster

* Removed DB changes from 4.16 upgrade file

* Resolving merge conflicts with main 4.17

* Added support for auto migration and auto resize of the root volume upon changing the service offering for VM.

* UI: Added automigrate checkbox in scale VM form

* Addes since attributes to new API params

* Added shrinkOK parameter to changeofferingforvolume API

* Added shrinkOk param to UI in changeOfferingforVolume form

* Added shrinkOk flag to scaleVM and changeServiceForVirtualMachines and UI form

* Removed old foreign key constraint on IDs of service offering and disk offering

* Allow resize and automigrate of root volume if required in all cases of service offering change

* Allow only resize to higher disk size from UI

* Fixing vue syntax error

* Make UI changes to provide root disk size box when the linked disk offering is of custom

* Converted from check box to toggle in scale VM, changeoffering, resize and migrate volume forms

* Fix resize volume operation to update the VM settings

* Fix migratevolume form to pick selected storage pool id in list diskofferings API
2022-01-27 15:08:42 +05:30
Daman Arora b9905c7e37
simplify code using object shorthand in multiple views (#5899) 2022-01-27 12:27:18 +05:30
Hoang Nguyen ee9c05b5fa
UI - Added option to allow users to select volumes when doing destroy the list of VMs (#5893)
* added option to allow users to select volumes when doing destroy list of VMs

* fixes
2022-01-27 11:09:48 +05:30
Hoang Nguyen 065847e6af
UI: Fixes asynchronous when destroying wrong item VM (#5884)
* fix asynchronous error when deleting VMs one by one

* fixes error open modal
2022-01-27 11:05:35 +05:30
Suresh Kumar Anaparti 982eef202f
Merge branch '4.16' into main 2022-01-26 12:21:24 +05:30
Abhishek Kumar d18ef1c0fd
ui: add custom form for update template (#5434)
* ui: add custom form for update template

* label fix

* changes and fix

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-01-25 10:47:41 +05:30
Abhishek Kumar 68a5e5aa77
ui: show password with success notification (#5889)
Fixes #5888

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-01-24 17:05:07 +05:30
Suresh Kumar Anaparti 97d6cd50a0
Merge branch '4.16' into main 2022-01-21 19:59:35 +05:30
sureshanaparti 4996b800b5
Now correct values are shown when configuring limits for a domain. (#5874) (#5880)
Now correct values are shown when configuring limits for a domain. (#5874) (#5880)

Co-authored-by: JoaoJandre <48719461+JoaoJandre@users.noreply.github.com>
Co-authored-by: Joao <JoaoJandre@gitlab.com>
2022-01-20 14:37:51 +05:30
JoaoJandre 7f000f5016
Now correct values are shown when configuring limits for a domain. (#5874)
Co-authored-by: Joao <JoaoJandre@gitlab.com>
2022-01-20 10:28:56 +05:30
dahn fb35f46a96
Delete ldap config from UI (#5871)
* add params to delete command

* pass known params

Co-authored-by: Daan Hoogland <dahn@onecht.net>
2022-01-18 10:21:51 +01:00
Hoang Nguyen 0e2c09baca
UI - Fixes Pod, Cluster selected is incorrect on addHost dialog (#5869)
* fix pod selected is incorrect

* fixes fetch cluster with podid empty

* clear clusterid field
2022-01-18 14:35:28 +05:30
Suresh Kumar Anaparti 0efdc535a5
Merge branch '4.16' into main 2022-01-18 12:44:55 +05:30
Abhishek Kumar f5b0d2f056
ui: fix create user domain, account selection (#5487)
* ui: fix create user domain, account selection

* fetch accounts only after domains

* refresh on saml configure

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-01-17 16:30:29 +05:30
Hoang Nguyen a42ed1fb89
add a setting to config.json that allows users to set theme (#5584) 2022-01-17 11:30:56 +05:30
Abhishek Kumar 59a615cf21
ui: fix deploy vm in basic zone (#5856)
* ui: fix deploy vm in basic zone

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-01-14 16:29:35 +05:30
Hoang Nguyen 619c754903
Clear cache APIs when the switch domain with SAML user (#5855) 2022-01-14 16:20:56 +05:30
Suresh Kumar Anaparti a6271b8306
Merge branch '4.16' into main 2022-01-13 22:49:11 +05:30
Abhishek Kumar c86b98e682
ui: show account configure limits tab for domain-admin (#5858)
Fixes #5676

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-01-13 14:08:02 +01:00
Hoang Nguyen 4746509c82
[UI] Cancel all requests api, async jobs in UI when user logs out (#5663)
* cancel requests in UI when user logs out

* clear notification, message from UI after logout
2022-01-13 17:44:49 +05:30
Hoang Nguyen 001f4213c8
UI - Deploy VM with params from the template, iso, network pages (#5653)
* deploy VM with params from the template, iso, network pages

* remove default-checked not necessary
2022-01-13 16:59:41 +05:30
Suresh Kumar Anaparti 42a941cc70
Merge branch '4.16' into main 2022-01-13 12:47:08 +05:30
Abhishek Kumar c17ae740f4
ui: fix getDiagnosticsData files field (#5853)
Fixes #5707

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-01-12 13:52:01 +05:30
Abhishek Kumar 223bc11d2a
ui: fix paging in enable static NAT form (#5849)
Fixes #5715

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-01-11 22:31:02 +05:30
Gabriel Beims Bräscher 2e2d328cde
Add toggle button on the UI for list including elements in projects. (#5790)
* Allow to use projectid=-1 and list all resources (e.g. VMs) regardless of their project.
2022-01-11 21:30:30 +05:30
Abhishek Kumar c08592cad8
ui: update vm haenable only for supported vms (#5847)
For VMs which have service offering that does not allow HA, haenable option will be not shown in the UpdateVM UI form.

Fixes #5743

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-01-11 14:55:11 +05:30
Suresh Kumar Anaparti e1b56be67c
Merge branch '4.16' into main 2022-01-11 12:46:33 +05:30
Hoang Nguyen 4916f3c90d
UI - Fix Locked "Override Root Disk Size" switch (#5843)
* Fix Locked "Override Root Disk Size" switch

* fixes ut
2022-01-10 19:04:46 +05:30
Hoang Nguyen 0f926b5d68
UI: Add s3 provider option to create secondary storage (#5726)
* add s3 provider option to create secondary storage

* fixes label name

* add storagepolicy for swift provider
2022-01-10 19:01:53 +05:30
Abhishek Kumar feb4343abe
ui: fix create network/vpc offering form (#5840)
* ui: fix create network/vpc offering form

Fixes #5838

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* fix inlinemode

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-01-08 08:41:58 +05:30
Suresh Kumar Anaparti 5c02f6d507
Merge branch '4.16' into main 2022-01-06 17:47:37 +05:30
Hoang Nguyen 3cbde8cd6c
UI - Hide shrink disk option on XCP-NG/Xenserver (#5829)
* hide shrink disk option on XCP-NG/Xenserver
2022-01-06 17:41:54 +05:30
Suresh Kumar Anaparti 30ae9eedad
Merge branch '4.16' into main 2022-01-05 10:14:47 +05:30
Hoang Nguyen f071873d84
UI: Fix new UI missing 4 parameters when adding a BareMetal host (#5812)
* fix new UI missing 4 parameters when adding a BareMetal host

* remove test options

* add rule for hosttag with baremetal

* fixes password not provided
2022-01-04 15:13:31 +05:30