wilderrodrigues
3f89cd6494
Adding license headers that made RAT fail
...
- Test classes affected
This closes #143
2015-04-03 10:43:30 +02:00
wilderrodrigues
3d22a16c4f
Bump priority stragety is no longer used for redundant virtual routers
...
- With the changes added by the rVPC work, the bump priority became deprecated.
This commit includes a refactor to get it removed from the following resources:
* Java classes
* domain_router table - removing the is_priority_bumpup column
* Fixing unit tests
All changes were tested with:
XenServer 6.2 running under our VMWare zone
CloudStack Management Server running on MacBook Pro
MySql running on MackBook Pro
Storage Type: Local
2015-04-02 21:50:49 +02:00
wilderrodrigues
57d0931b49
Adding more tests to cover other possibilities concerning different versions of the XenServer
...
Adding a better algorithm in order to corver deeper inheritance form the command classes
Removing some unsued variables.
2015-03-31 16:49:48 +02:00
wilderrodrigues
d93935caac
We don't need the Start, Stop, Reboot command in the CitrixRebaseClaas anymore.
2015-03-31 10:38:33 +02:00
wilderrodrigues
3ad30a01a8
Refactoring XenServer56NetworkUsageCommandWrapper in order to cope with the new design
...
- Unit tests added
CitrixResourceBase, XenServer56Resource and XenServer56FP1Resource are now done.
i
2015-03-31 10:38:33 +02:00
wilderrodrigues
f3842c81f8
Refactoring XenServer56 and 56FP1 Resources in order to cope with new FenceCommandWrapper
...
- Unit tests added
Also removed an unit test that was doing nothing.
2015-03-31 10:38:33 +02:00
wilderrodrigues
4600eef87c
Removing all private/protected/public execute() methods from CitrixResourceBase class
...
Started the refactor of the XenServer56Resource class
- Unit test added
Changing the CitrixRequestWrapper in order to cope with multiple resources classes and commands
Still have to remove few methods form CitrixResourceBase
2015-03-31 10:38:32 +02:00
wilderrodrigues
02571728c6
Refactored the remaining commands
...
- Unit tests added
In the executeRequest I needed to keep the following:
// We need this one because the StorageSubSystemCommand is from another hierarchy.
if (cmd instanceof StorageSubSystemCommand) {
return storageHandler.handleStorageCommands((StorageSubSystemCommand) cmd);
}
2015-03-31 10:38:32 +02:00
wilderrodrigues
24bbfbc1e6
Refactoring other 8 command wrapper in order to cope with the new design
...
- Advanced unit tests added for half of the commands
- Basic unit tests added for the other half
2015-03-31 10:38:32 +02:00
wilderrodrigues
fbcae54a5b
Refactoring NetworkRulesSystemVmCommand, OvsCreateTunnelCommand, OvsDestroyBridgeCommand, OvsDestroyTunnelCommand, OvsSetupBridgeCommand in order to
...
cope with new design.
- Meny unit ests added.
2015-03-31 10:38:31 +02:00
wilderrodrigues
751c14b929
Refactoring CleanupNetworkRulesCmd, OvsCreateGreTunnelCommand, OvsDeleteFlowCommand, OvsVpcPhysicalTopologyConfigCommand and OvsVpcRoutingPolicyConfigCommand
...
in order to cope with the new design.
- Meny new unit tests added that cover more than the basics!
2015-03-31 10:38:31 +02:00
wilderrodrigues
30b770aeab
Refactoring CheckSshCommand, OvsFetchInterfaceCommand and SecurityGroupRulesCommand to cope with new design.
...
- Unit Tests added
2015-03-31 10:38:30 +02:00
wilderrodrigues
74faf73408
Refactoring CheckOnHostCommand, ModifySshKeysCommand, OvsSetTagAndFlowCommand and StartCommand to cope with new design
...
- Unit tests added
2015-03-31 10:38:30 +02:00
wilderrodrigues
18470a48d0
Refactoring PingTestCommand to cope with new design
...
- Basic tests added
2015-03-31 10:38:30 +02:00
wilderrodrigues
3a70912b7c
Make methods in subclasses public.
...
Remove the if-commands that I have already refactored.
2015-03-31 10:38:29 +02:00
wilderrodrigues
637a56c3c1
Refactoring GetVncPortCommand, MaintainCommand and SetupCommand to cope with new design.
...
- Basic test added, but could not mock all the static stuff so the test is not complete yet.
Will look further into it.
2015-03-31 10:38:29 +02:00
wilderrodrigues
11d0336803
Refactoring GetStorageStatsCommand and PrimaryStorageDownloadCommand to cope with the new design
...
Fix the NPE in the constructor that was never used
- Basic tests added for all changes
2015-03-31 10:38:29 +02:00
wilderrodrigues
ea374b6a2f
Refactoring AttachIsoCommand, AttachVolumeCommand and UpgradeSnapshotCommand to cope with new design
...
- Basic tests added
2015-03-31 10:38:28 +02:00
wilderrodrigues
6c775951c7
Refactoring DeleteStoragePoolCommand, ModifyStoragePoolCommand and ResizeVolumeCommand to cope with new design
...
- Basic tests added.
2015-03-31 10:38:28 +02:00
wilderrodrigues
a06958f469
Refactoring DestroyCommand and CreateStoragePoolCommand wrappers to cope with the new design
...
- Basic tests added
s Please enter the commit message for your changes. Lines starting
2015-03-31 10:38:27 +02:00
wilderrodrigues
a70d80dfd6
Refactoring PrepareForMigrationCommand and MigrateCommand in order to cope with the new design
...
- Basic tests added
2015-03-31 10:38:27 +02:00
wilderrodrigues
cb07b0ba08
Refactoring the CitrixCheckVirtualMachineCommand toc ope with new design
...
- Added basic tests
- Added tests for RebootRouterCommand
- Removed the code from CitrixResourceBase that has already been refactored
2015-03-31 10:38:27 +02:00
wilderrodrigues
f2fab5c8c3
Refactoring the CitrixRebootCommand in order to have the new design applied
...
- Added basic tests
- Changed the way RebootCommand gets called from RebootRouterCommand
- Made a couple of methods public in the CitrixResourceBase and its subclasses
2015-03-31 10:38:27 +02:00
wilderrodrigues
9e41b8051e
Renaming files
...
- Forgot to add "Citrix" before the new command wrappers
2015-03-31 10:38:26 +02:00
wilderrodrigues
6b80c79986
Refactoring the StopCommand on CitrixResourceBase to cope with new design
...
- Added basic tests
2015-03-31 10:38:26 +02:00
wilderrodrigues
c7830efef5
Refactor the CheckHealthCommand and GetVmDiskStatsCommand classes in CitrixResourceBase
...
- Added basic tests for both wrappers
2015-03-31 10:38:26 +02:00
wilderrodrigues
8f04108e23
Refactoring the GetVmStatsCommand
...
- Added basic tests
2015-03-31 10:38:25 +02:00
wilderrodrigues
0e51379da7
Refactoring the GetHostStatsCommand
...
- Added basic tests
- Added test for when the key (Command) does not exist in the Map
2015-03-31 10:38:25 +02:00
wilderrodrigues
30e72e4a15
Refactoring the whole XsHost thing
...
Refactor the ReadyCommand
Fixing the old test
Adding basic tests for ReadyCommandWrapper
2015-03-31 10:38:25 +02:00
wilderrodrigues
c3ae8c793b
Adding the refactor of CitrixCheckConsoleProxyLoadCommandWrapper.java and CitrixWatchConsoleProxyLoadCommandWrapper.java
...
- plus basic tests
2015-03-31 10:38:24 +02:00
wilderrodrigues
4256418af9
Adding CitrixCreateCommandWrapper.java and basic unit tests
2015-03-31 10:38:24 +02:00
wilderrodrigues
a1e8778211
First piece of the refactor of the CitrisResourceBase
...
- The same pattern will be used by the other subclasses of the ServerResource interface.
2015-03-31 10:38:24 +02:00
Daan Hoogland
b6d2b62aa7
imports in test
2015-03-27 15:59:32 +01:00
Daan Hoogland
4e1997ff5a
imports :8
2015-03-27 15:38:25 +01:00
Funs
e7d7643dd7
Only one thing can come from the agent
2015-03-27 11:19:16 +01:00
Funs
d0e25d96fb
Fix paths so they also work with tests on windows.
...
Sonarcube is great, but has no context and can be wrong, in this
case File.separator is nice if you're running platform independent,
the agent on OVM3 is however NOT platform independent and will break
if we feed it windows separators.
2015-03-27 11:14:35 +01:00
Daan Hoogland
6a821730ce
Boolean -> boolean
2015-03-25 22:20:40 +01:00
Daan Hoogland
048212b117
findbugs: Boolen function should not return null
2015-03-25 21:46:47 +01:00
Daan Hoogland
724699424e
findbugs: boxing/unboxing
2015-03-25 21:20:39 +01:00
Daan Hoogland
1552c912a7
findbugs: parseLong instead of boxing/deboxing
2015-03-25 18:36:12 +01:00
Daan Hoogland
340aa9ff0f
findbugs: make default encoding explicit
2015-03-25 18:31:08 +01:00
Daan Hoogland
a4c23b170e
findbugs: just in case we run on windows, use save expression
2015-03-25 18:27:56 +01:00
Daan Hoogland
bff8a8e9cd
findbugs: set explicit default charset
2015-03-25 18:22:07 +01:00
Rohit Yadav
694b723899
CLOUDSTACK-8312: Fix NPE regression, copy template can have NULL volume size
...
The copy command reply can have null size returned, so check and set values
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit 53ca0b1861 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-03-20 17:27:14 +05:30
Rohit Yadav
3c429ee6b5
Merge remote-tracking branch 'sbp/feature/persisten-systemvm-redundant-vpc-REBASE'
...
This closes #118
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-03-17 15:44:57 +05:30
wilderrodrigues
84ba06b87d
Fix: the update_config.py was not parsing the incoming guest net configuration properly
...
Added comments to the CitrixResourceBase class: do not destroy the cd-rom
2015-03-16 11:39:49 +01:00
wilderrodrigues
2bb79b8115
Adding some info to the update_config.py
2015-03-16 11:39:49 +01:00
wilderrodrigues
edd839ab10
Fix: allow multiple VIFs per Mac Address
...
Fix: RTNETLINK errors
- Management Server health check trying to create already existing interface
- Changes on update_config.py, cs_guestnetwork.py, merger.py
Fix: replace RRouTER_LOG in the CsRedundant.py per log file location
Fix: Guest Net address association during Router restart
- Changes on NicProfileHelper, NicProfileHelperImpl
Fix: aggregationExecution() method on VirtualNetworkApplianceManagerImpl
- Do not send an AggregationControlCommand to a non-configured router
Some classes have been formatted.
2015-03-16 11:39:48 +01:00
wilderrodrigues
33b0ce816b
Make sure we can plug the nic in 2 routers with the same mac address
...
The still some work to do on the prepareNetworkElementCommand() method.
2015-03-16 11:39:16 +01:00
Antonio Fornie
09bd847040
Vpc redundancy enabled. Including Vpc & Vpc Offering creation. Marvin tests and UI.
2015-03-16 11:38:05 +01:00