Commit Graph

325 Commits

Author SHA1 Message Date
Kelven Yang 899f92b725 CLOUDSTACK-4288: Fix the way that VmwareClient is using vSphere 5.1 SDK which caused huge memory footprint 2013-09-04 14:49:45 -07:00
Kelven Yang 0becde90bb CLOUDSTACK-3568: Refactore CloudStack/vCenter API session management facility to avoid the situation that multiple API requests are sharing with the same vCenter API session 2013-09-04 14:49:45 -07:00
Kelven Yang c6dfb33d9f CLOUDSTACK-3237: pass disk file name instead of full datastore path when setting up storage relocation specin order to safely locate the disk device 2013-09-04 14:49:45 -07:00
Kelven Yang dbe4e13e8e CLOUDSTACK-3778: serialize configuration of port group at per-host level to prevent run-time race condition 2013-09-04 14:49:45 -07:00
Kelven Yang 75bb38394b CLOUDSTACK-3869: fix merge conflicts 2013-09-04 14:49:45 -07:00
Kelven Yang 362ef67013 CLOUDSTACK-3869: make new folder structure to work with Create/Delete/Attach/Detach commands 2013-09-04 14:49:45 -07:00
Kelven Yang 9a2148ffc3 CLOUDSTACK-3886: check in for review request https://reviews.apache.org/r/13008/ 2013-09-04 14:49:45 -07:00
Kelven Yang 40869a5a2b CLOUDSTACK-3869: Move VMware datastore folder structure policy management to central place 2013-09-04 14:49:45 -07:00
Kelven Yang 249e2e8f59 Correct DAO usage in VmwareDatacenterVO, relax assertion conditions to work with stack calling frame that is not wrapped with @DB injection 2013-09-04 14:49:44 -07:00
Wei Zhou f555e26c87 CLOUDSTACK-1192: fix silly mistake 2013-09-03 08:52:35 +02:00
Wei Zhou 87d73e227f CLOUDSTACK-1192: GetVmDiskStatsCommand return null as disk I/O statistics does not support xen/vmware
(cherry picked from commit 3121133c03)
2013-09-02 16:04:59 +02:00
Daan Hoogland d9c06e538b CLOUDSTACK-4346 replace URI getHost() and create(String) calls with BroadcastDomainType methods 2013-09-01 22:53:23 +02:00
frank 2a0e371881 [Upgrade from 3.0.6 to 4.2][vmware] After upgrade the system vms fail to come up because "Secondary storage mount point" is pointing to a wrong location
when secondary storage is mounted as read-only, changing permission of files on it will fail. But we should still stick to current mount point instread of
returning a wrong mount point /mnt/sec
2013-08-29 10:32:13 -07:00
frank e217c0f1c3 CloudStack CLOUDSTACK-4426
[VMware] [upgrade] system VM not coming up after upgrade from 3.0.4 to 4.2
2013-08-28 15:40:33 -07:00
frank 993a1f937f CloudStack CLOUDSTACK-4426
[VMware] [upgrade] system VM not coming up after upgrade from 3.0.4 to 4.2
2013-08-28 15:40:28 -07:00
Mike Tutkowski de531c0c0a Trim IQN so that the format /iqn/lun becomes iqn. 2013-08-28 15:08:45 -06:00
Mike Tutkowski bd2d875073 Make Mutual CHAP optional for VMware. 2013-08-26 16:08:37 -06:00
Min Chen 49dd7289c0 CLOUDSTACK-4468:template created from snapshot is destroyed once we
restart management server.
2013-08-26 11:58:53 -07:00
Min Chen 2807d083db CLOUDSTACK-4480: Handle DestroyCommand in VmwareResource to evict
unused template from primary storage pool.
2013-08-23 15:26:43 -07:00
Min Chen 75be7a9ac4 CLOUDSTACK-4433:[VMware]Registration of template using the downloaded
template URL is failing.
2013-08-22 15:59:09 -07:00
Sateesh Chodapuneedi 69adeecc39 CLOUDSTACK-4414
Fixing detection of failure in cluster discovery before cleanup vsm device.
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-08-21 08:03:52 +05:30
Nitin Mehta e6b53e5529 CLOUDSTACK-4386
KVM - Create template from volume
Vmware - Create template from volume / Create template from snapshot
send the physical size in the copycommand which accordingly will populate template store ref and the usage_event tables with the right physical size
Signed off by : nitin mehta<nitin.mehta@citrix.com>
2013-08-20 19:21:32 +05:30
Sateesh Chodapuneedi 41f2c75aee CLOUDSTACK-4385 : [ZWPS]Across the cluster live migration of VM on zone wide primary storage pool fails
If all the VM's volumes are on zone wide primary storage pool then live migration of the VM would not involve storage migration. Hence MigrateVM API would be called against MigrateVMWithVolume. So far PrepareForMigrationCommand handled scenarios of VM moving across hosts within a cluster, but with zone wide primary storage in picture this command need to handle scenarios of VM moving across clusters. Try to find the VM in datacenter if not found within cluster.

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-08-19 05:55:17 +05:30
Edison Su dd6b245221 CLOUDSTACK-4318: clean up snapshot stored in staging area, after backup snapshot to object store 2013-08-14 14:59:25 -07:00
Sateesh Chodapuneedi b0e06981c1 CLOUDSTACK-4326 Adding VMware DC to legacy zone should not be allowed by API
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-08-14 12:47:58 +05:30
Alex Huang de2bd96d98 Moved volume related code into cloud-engine-orchestration 2013-08-12 19:06:51 -07:00
Edison Su 8af05e5202 CLOUDSTACK-4253: add more logs for vmware storage related operations 2013-08-12 17:19:17 -07:00
Edison Su 3ad9681fd1 CLOUDSTACK-4253: change the log message if copy template from secondary storage to primary storage failed 2013-08-12 17:19:04 -07:00
Sateesh Chodapuneedi 9e3aa37a8d CLOUDSTACK-3905 [VMWARE]Can not add Standard/DVSwitch when Nexus global config is set to true
Make VSM specific input paramters optional while adding VMware cluster where no traffic chosen to use Nexus 1000v dvSwitch when cloud level vSwitch is Nexus 1000v.

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-08-12 22:45:01 +05:30
Sateesh Chodapuneedi f0ae682d48 CLOUDSTACK-4246 VM deployment fails with global configuration parameter "vmware.nested.virtualization" enabled.
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-08-12 09:44:33 +05:30
Sateesh Chodapuneedi 14abe4cb2d CLOUDSTACK-4155 [VMWARE] Failed to deploy VM with NPE when vmware.nested.virtualization is enabled to true
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-08-12 07:43:10 +05:30
Min Chen bf6961255a CLOUDSTACK-4190:[Object_store_refactor] volume should be deleted from
staging storage after successfule volume migration .
2013-08-08 16:16:36 -07:00
Alex Huang 5495f10bce Revert "Reverting the range of commits that broke the build"
This reverts commit b59e3aaefc.
2013-08-08 15:02:40 -07:00
Sateesh Chodapuneedi f43f3bb95e CLOUDSTACK-2558 Nexus configuration cleanup is not done when there is a failure while adding the Nexus enabled VMWARE cluster which is causing for NPE while readding the cluster with same configuration details
If cluster addition fails then cleaning up the Nexus VSM related to the cluster.

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-08-08 13:49:11 +05:30
Prasanna Santhanam b59e3aaefc Reverting the range of commits that broke the build
This reverts commits 30c33415..f6a2c817bc

Signed-off-by: Prasanna Santhanam <tsp@apache.org>
2013-08-08 14:46:56 +05:30
Edison Su 9bce985f62 CLOUDSTACK-4108: fix create template from snapshot for vmware& s3 2013-08-07 19:14:22 -07:00
Edison Su e851f4a930 CLOUDSTACK-4109: fix upload volume to s3 for vmware 2013-08-07 19:14:18 -07:00
Min Chen 82c35e52ea CLOUDSTACK-4135: [Object_store_refactor] ISO attached to the guest vm
has wrong mount path.
2013-08-07 18:01:58 -07:00
Alex Huang 5287f4c9ec Got everything running through testing 2013-08-07 16:41:06 -07:00
Alex Huang 942f282a6e Moved config into it's own package 2013-08-07 16:41:02 -07:00
Sateesh Chodapuneedi a470b33f97 CLOUDSTACK-3616 [VMware] Failed to create template from volume (volume is created from snapshot of data volume)
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-08-07 14:56:08 +05:30
Sateesh Chodapuneedi 1d9465d758 CLOUDSTACK-3782 Data disk size is modified to KB from GB after it is attached to the instance
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-08-07 08:08:46 +05:30
Sateesh Chodapuneedi 3946070359 CLOUDSTACK-4041 [ZWPSFailed to migrate a ROOT volume created on zone wide primary storage
While finding endpoint to send the migrate volume command, in case of zone wide storage pool, storage engine is picking a host among all connected hosts randomly. Hence a host may be from different cluster t

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-08-07 06:07:54 +05:30
Edison Su a8ee45de7c CLOUDSTACK-4074: if hypervisor doesn't return size of volume/template, don't update it into db 2013-08-06 15:53:57 -07:00
Edison Su 36c7a56d12 CLOUDSTACK-4073: fix s3 on vmware
Conflicts:

	plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
2013-08-05 20:23:01 -07:00
Mice Xia 51e4f597e0 fix CLOUDSTACK-3591 add usage recording for VM snapshots
Conflicts:

	plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
	server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java
	setup/db/db/schema-410to420.sql
2013-08-01 10:47:36 +08:00
Edison Su 211524f3bc add note on vmwarweguru->getCommandHostDelegation 2013-07-30 16:17:06 -07:00
Edison Su c42f51d75b CLOUDSTACK-3944: fix regression for vmware 2013-07-30 16:17:02 -07:00
Koushik Das 62a71e055b CLOUDSTACK-3937: Attaching uploaded volume is failing
The method getCommandHostDelegation(long hostId, Command cmid) got overidden in VmwareGuru.java as part of
commit bfe30cd2e3. Earlier there was no HV specific implementation and copy
volume from secondary to primary worked fine. With the Vmware specific change the code was getting hit even
in case of XS and other hypervisors and failed with NPE.
Now there is a check in the Vmware implementation to check if the HV is of type Vmware.
2013-07-30 16:56:15 +05:30
Edison Su f0f55226de CLOUDSTACK-3107: fix attach upload volume 2013-07-29 19:00:16 -07:00
Edison Su f486d36f88 CLOUDSTACK-3908: fix extract path 2013-07-29 16:58:51 -07:00
Edison Su ae534388c0 CLOUDSTACK-3852: fix upload volume
Conflicts:

	plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java
	server/src/com/cloud/template/TemplateManagerImpl.java
2013-07-29 11:50:16 -07:00
Kishan Kavala 9fe5d398a2 CLOUDSTACK-3849: Set volume size in CopyAnswer for Vmware when cloning volume from bas template 2013-07-29 16:34:46 +05:30
Sateesh Chodapuneedi 57d96308c1 CLOUDSTACK-3468 Failed to Deploy Instances with multiple VMWARE clusters when DVS is enabled at the Zone level
Fixing cluster level override of zone level specified vSwitch settings.

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-07-29 03:04:23 +05:30
Sateesh Chodapuneedi 3adeb12d2f CLOUDSTACK-3879 [VMware] NPE while attempting to create template from volume
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-07-27 18:03:17 +05:30
Sateesh Chodapuneedi 081ba92497 COUDSTACK-3053 Template creation from snapshot is failing on VMware setup
Fixed snapshot vmdk file path while copying snapshot files to template path.

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-07-27 18:02:31 +05:30
Min Chen c8cafb91a7 CLOUDSTACK-3818: NFS Cache Improperly Named. 2013-07-26 15:07:45 -07:00
Alex Huang 111febc567 Fixed up the rest of the management server code that calls clustermanager 2013-07-25 19:57:45 -07:00
Min Chen e7cdaa1b31 CLOUDSTACK-3667:[Object_Store_Refactor][VMWare] System VMs StartCommand
failed due to Exception: java.lang.Exception Message: secondary storage
for dc 3 is not ready yet?
2013-07-25 10:57:05 -07:00
Jayapal 0984594323 CLOUDSTACK-2933 Added vpc load balancing changes for vmware 2013-07-25 17:40:48 +05:30
Edison Su 80ac885e22 CLOUDSTACK-2304: fix migrate volume for vmware 2013-07-24 19:06:42 -07:00
Edison Su 7f200d966e CLOUDSTACK-3681: fix bunch of bugs related to vmware, regarding to snapshot 2013-07-24 19:06:30 -07:00
Bharat Kumar e14f5d0aeb Cloudstack-3694 Dnsmasq rewrite in bash
(Sheng: Fix typo, fix log and error message, remove 'set -x' in script)

Signed-off-by: Sheng Yang <sheng.yang@citrix.com>
2013-07-24 14:00:31 -07:00
Alex Huang 319d91e1c2 Removed the getByTypeAndId() method and replace it with getById method 2013-07-22 20:06:04 -07:00
Alex Huang 1325014a03 Changed VirtualMachineProfile to be non-generic. From here on VirtualMachineManager will only manage vm instance. It doesn't understand the difference between different types of VMs. This makes the vmsync code to be generic across all vms. 2013-07-22 11:48:11 -07:00
Mike Tutkowski 98dd501a81 Changes related to Review Board comments 2013-07-20 17:44:23 -06:00
Mike Tutkowski b43a2a5fae Changes related to Review Board comments 2013-07-18 20:10:58 -06:00
Sateesh Chodapuneedi 7e087645c6 CLOUDSTACK-3595 Backup snapshot successful but CopyCmdAnswer received is failure.
Send success answer of type CopyCmdAnswer with full snapshot backup path in secondary store (image store role)

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-07-18 23:29:54 +05:30
Vijayendra Bhamidipati d6cb95208b CLOUDSTACK-3554: NPE while attaching VMWARE Tools ISO to the instance
Description:

    Account for null imagestore for vmware-tools iso.
2013-07-17 16:58:51 -07:00
Sateesh Chodapuneedi 59788c1473 CLOUDSTACK-3530 Runtime exception while creating Snapshot from volume (ROOT/DATA)
Worker name is not being configured for CopyCommand.

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-07-18 00:39:28 +05:30
Jayapal 2d6644d961 CLOUDSTACK-2433 Enable rps and rfs in virtual router 2013-07-17 16:59:59 +05:30
Hugo Trippaers af696e6ff6 CLOUDSTACK-728 Remove the nvp portgroup when the virtual machine is
expunged.
2013-07-16 15:42:29 +02:00
Vijayendra Bhamidipati 1f004f60e8 CLOUDSTACK-3425 Ignore network interfaces without a uuid when passing
them on as extra configs to ESX for nicira NVP controller.
2013-07-15 10:17:36 +02:00
Mike Tutkowski 505ab2eebe Changes related to Review Board comments
Changes related to Review Board comments

Changes related to Review Board comments
2013-07-12 14:28:00 -06:00
Hugo Trippaers 2691970f28 CLOUDSTACK-728 Get the framework in place the support the removal of the portgroup that is created for a nic connected to an lswitch.
Add a command to tell a hypervisor guru to take some action when
expunging a nic
2013-07-12 12:18:34 +02:00
Hugo Trippaers 7dc3d3bae5 Formatting changes using the settings from Alex 2013-07-12 12:18:20 +02:00
Hugo Trippaers 392bbcc737 CLOUDSTACK-728 Rewrite support for lswitch connected nics on both standard and distributed switches.
Fix the name of the interface id in extra config, so the nic is found up using the nic uuid instead of the vm id.

getVlanInfo should return null when the nic is plugged on a Lswitch network.

On a distributed portgroup all vms should be connected to a single
portgroup and set a specific vlan on the port. On a standard switch each nic should have its own portgroup with a dedicated vlan (not related to CS vlans)
2013-07-12 12:18:07 +02:00
Sateesh Chodapuneedi a3660d8109 CLOUDSTACK-3469 [VMware] Support to make username/password optional while adding VMware cluster
For legacy zones insist on the old model of asking for credentials for each cluster being added.
For non-legacy zones check if username & password are provided. If either or both not provided, try to retrieve & use the credentials from database, which are provided earlier while adding VMware DC to zone.
This lets user to not specify credentials while adding VMware cluster to zone, if the credentials are same as that of provided while adding VMware DC to zone.

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-07-11 20:39:33 +05:30
Sateesh Chodapuneedi 1e2f99be68 Updated logger initalization in classes ListVmwareDcsCmd, RemoveVmwareDcCmd & minor cleanup of comments. 2013-07-11 15:59:25 +05:30
Sateesh Chodapuneedi 29a31708d5 CLOUDSTACK-3450 To implement toggle action of add/remove VMware DC, listVmwareDcs API call is required.
listVmwareDcs API is added. Takes 1 parameter (mandatory) which is zoneId.
Returns list of VMware DCs associated with specified zone.

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-07-10 23:04:32 +05:30
Sateesh Chodapuneedi 664dc17b0b CLOUDSTACK-3303 Vmware - Put a mechanism to disable hot add vcpu if the number of cores per socket is not 1 and virtual machine hardware version=7
Following Hotadd memory checks are included now.
1) Check if guest operating system supports memory hotadd
2) Check if virtual machine is using hardware version 7 or later before enabling memory hotadd

Following Hotadd CPU checks are included now.
1) Check if guest operating system supports cpu hotadd
2) Check if virtual machine is using hardware version 8 or later.
3) Check if virtual machine has only 1 core per socket. If hardware version is 7, then only 1 core per socket is supported. Hot adding multi-core vcpus is not allowed if hardware version is 7.

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-07-10 17:58:42 +05:30
Mike Tutkowski 06f73092fb Changes related to Review Board comments 2013-07-09 22:50:14 -06:00
Sateesh Chodapuneedi 91d31b29b8 CLOUDSTACK-3304 [Vmware][Dynamic Scaling] - Enforce checks for maximum hotadd memory limit & memory increment size in CS
Retrieve maximum hotadd memory limit & hotadd memory increment size from running VM's configuration to validate dynamic scale memory limit while scaling up a VM.

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-07-08 21:17:49 +05:30
Sateesh Chodapuneedi 5f395e41ab CLOUDSTACK-2592 [Automation]: Scale up VM on VMWARE without license doesn't throw appropriate error
Now ESXi server license would be fetched to see if HOTPLUG feature is license or not.
Throw Exception if the feature is not licensed.

Also added FeatureKeyConstants enum type to maintain list of various features to be checked whether licensed or not.
2013-07-08 12:49:39 +05:30
Harikrishna Patnala d2739cde2e Fix file name in DnsMasqConfigCommand
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2013-07-03 20:43:42 +05:30
Harikrishna Patnala 98c5fe3a8d CLOUDSTACK-3302: [Multiple_IP_Ranges][VmWare] VM deployement failed due to dnsmasq configuration issue in case of multiple subnets in a vlan
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2013-07-03 16:59:21 +05:30
Sateesh Chodapuneedi 6aa9b2f356 CLOUDSTACK-3152 addVmwareDc API call fails if called more than once to add same VMware DC to same cloudstack zone.
Check if the associated VMware DC matches the one specified in API params. This check would yield success as the association exists between same entities (zone and VMware DC)
This scenario would result in if the API addVmwareDc is called more than once with same parameters. For such scenario, return success response with VmwareDatacenter object read from database. Also returns success if addVmwareDC is called agsin with same zone and VMwareDC where the zone already has resources added to it (clusters etc.)

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-07-02 17:31:09 +05:30
Bharat Kumar 61bc6c8477 Cloudstack-3302 VM deployement failed in VMWare due to dnsmasq configuration issue in case of multiple subnets in a vlan
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2013-07-02 12:00:50 +05:30
Bharat Kumar 160c8f361b Cloudstack-3299 incorrect arguments sent to the script createIpalias in case of vmware, Cloudstack-3240 corrected a mistake in the script name.
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2013-07-02 12:00:30 +05:30
Sateesh Chodapuneedi f980341808 CLOUDSTACK-3279 Need mechanism to detect if hotadd for cpu/memory is supported per a specific guest OS supported by VMware.
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-07-01 17:27:32 +05:30
Sateesh Chodapuneedi e8ea6b1abd CLOUDSTACK-3260
Fixing NPE.
2013-06-30 08:59:41 +05:30
Prasanna Santhanam 085e8838e4 Fix typo in backupSnapshotCommand
Signed-off-by: Prasanna Santhanam <tsp@apache.org>
2013-06-29 13:50:25 +05:30
Mike Tutkowski 99227f7b3e SolidFire plug-in and related changes
SolidFire plug-in

SolidFire plug-in related
2013-06-28 16:59:21 -06:00
Fang Wang 24499deb43 CLOUDSTACK-2384: Template created from snapshot error.
In DB, the backedUpSnapshotUuid format got changed.
This messed up the vmdk file path in template creation from snapshot
2013-06-27 17:34:32 -07:00
Hugo Trippaers 53d1ce75a1 CLOUDSTACK-728 Set vmspec extra config for the Nicira NVP vApp 2013-06-26 15:41:52 -07:00
Hugo Trippaers 98dc68d8c9 CLOUDSTACK-728 For Nicira NVP a specified port-group must be used,
instead of a dynamically configured one.

Refactor bits of the HypervisorHostHelper to better
support multiple BroadcastDomainTypes

Cleanup some parts of the code that was using tab indents and removed some dead code.
2013-06-26 15:41:52 -07:00
Sateesh Chodapuneedi c36a952f15 CLOUDSTACK-1767 VMWare DVS - cannot use untagged portgroups
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-06-25 19:43:20 +05:30
Sateesh Chodapuneedi b3927ffe96 CLOUDSTACK-1766 VmWare DVS vmware.ports.per.dvportgroup setting not used
Read the global configuration setting while configuring VmwareManager.
Also enabling autoExpand feature for supported distributed virtual switch versions.

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-06-25 19:15:24 +05:30
Jayapal 1ab87ef4be CLOUDSTACK-3003 Fixed static route issue in vpc vmware 2013-06-25 18:43:00 +05:30
Jayapal 9121191f70 CLOUDSTACK-1578 vmware:Egress default policy configurable using network offering on vmware 2013-06-24 13:37:01 +05:30