Min Chen
bdcfa1919b
Clean up ApiServer, ApiServlet and ApiDispatcher in handling various
...
exceptions, and Introduced ApiErrorCode to handle CloudStack API error
code to standard Http code mapping.
2013-01-16 21:52:48 -08:00
Min Chen
4355d06a86
Reuse APIChecker adapter interface for APi Rate limit checking and optimize ApiRateLimitService interface.
...
Signed-off-by: Min Chen <min.chen@citrix.com>
2013-01-15 15:53:19 -08:00
Kelven Yang
af67d87662
Fix issues with @DB support in Spring environment
2013-01-15 12:35:03 -08:00
Kelven Yang
6dfbcee63d
Fix singleton initialization in ApiServer/ApiDispatcher to make it work under Spring bootstraped environment
2013-01-14 13:57:30 -08:00
Alex Huang
56e5fbdee2
removed import of componentlocator and inject from all files
2013-01-10 11:44:47 -08:00
Rohit Yadav
296b49c2f8
Merge branch 'master' into test-merge-api
...
Conflicts:
api/src/com/cloud/agent/api/BackupSnapshotCommand.java
api/src/com/cloud/agent/api/storage/PrimaryStorageDownloadCommand.java
api/src/com/cloud/agent/api/to/PortForwardingRuleTO.java
api/src/com/cloud/network/NetworkService.java
api/src/com/cloud/resource/ResourceService.java
api/src/org/apache/cloudstack/api/ApiConstants.java
api/src/org/apache/cloudstack/api/ResponseGenerator.java
api/src/org/apache/cloudstack/api/response/SSHKeyPairResponse.java
client/tomcatconf/commands.properties.in
core/src/com/cloud/storage/SnapshotVO.java
pom.xml
server/src/com/cloud/api/ApiDispatcher.java
server/src/com/cloud/api/ApiResponseHelper.java
server/src/com/cloud/api/ApiServer.java
server/src/com/cloud/configuration/ConfigurationManagerImpl.java
server/src/com/cloud/network/NetworkManagerImpl.java
server/src/com/cloud/network/rules/RulesManagerImpl.java
server/src/com/cloud/offerings/NetworkOfferingVO.java
server/src/com/cloud/resource/ResourceManagerImpl.java
server/src/com/cloud/upgrade/dao/Upgrade40to41.java
server/src/com/cloud/vm/UserVmManagerImpl.java
server/test/com/cloud/vpc/MockNetworkManagerImpl.java
setup/db/create-schema.sql
setup/db/db/schema-40to410.sql
Signed-off-by: Rohit Yadav <bhaisaab@apache.org>
2012-12-23 13:54:46 -08:00
Chip Childers
ba30500402
CLOUDSTACK-505: Added string cleaning to the start and end debug
...
log statements within the API servlet.
2012-12-17 15:13:59 -05:00
Rohit Yadav
f8a483fc5a
api: Include cloudstack-version in both xml and json api response
...
Signed-off-by: Rohit Yadav <bhaisaab@apache.org>
2012-12-16 21:37:03 -08:00
Rohit Yadav
8fbbc76466
api: minor fixes in ApiServlet
...
- Reusing local variable for string splitting/processing
- Fix comments
- Fix indentations
Signed-off-by: Rohit Yadav <bhaisaab@apache.org>
2012-12-10 16:19:40 -08:00
Rohit Yadav
6fc3bc3760
api_refactor: refactor vpn and vm apis
...
- Refactor VPN and VM APIs to admin and user pkgs
- Names space, org.apache.cloudstack
- Fix refactored apis in commands*.in
- Fix comments etc.
- Expand tabs, remove trailing whitespace
Signed-off-by: Rohit Yadav <bhaisaab@apache.org>
2012-12-03 21:27:02 -08:00
Min Chen
7b7f4cd1fd
CLOUDSTACK-409: ThreadLocal Transaction and its db connection got reset for user managed db connnection, causing ClusterHeartBeat thread frequently trying to get db connection. Add unit test to test user managed transaction.
2012-10-25 13:06:50 -07:00
David Nalley
e87558256c
Patch from Chip Childers
...
https://reviews.apache.org/r/5704/
License header updates for the server folder
2012-07-02 09:51:21 -04:00
Deepti Dohare
e0860d5a48
CS-14345 Fixing for Login API also.
...
Signed-off-by: Deepti Dohare <deepti.dohare@citrix.com>
2012-06-19 23:07:31 +05:30
unknown
fc9a656b97
CS-14345 Logout API is not returning XML header
...
Signed-off-by: Deepti Dohare <deepti.dohare@citrix.com>
2012-06-19 14:26:18 +05:30
saksham
f6d16d0ab5
CS-15018: Event USER.LOGIN should contain the client IP address. Changes made in accordance with the coding convention.
...
Reviewed-by: Alena Prokharchyk
2012-06-18 10:18:30 -07:00
frank
2f634c0913
Switch to Apache license
2012-04-03 04:50:05 -07:00
prachi
e43914ab58
Bug 14336 - Login API does not return UUID's
...
Changes done:
- Provide UUID for userid and domainid only while constructing the login response. Session will hold the DB id's as before, to ensure other parts keep working.
- This reverts commit de28aa3ddde5b601f2f234f2eccef871fbaf1a06.
2012-03-20 16:59:04 -07:00
prachi
280d533a6f
Bug 14047 - login API fails when UUID is used for domain_id
...
Changes:
- API should accept UUID for domain and convert to id when needed
2012-03-20 16:59:00 -07:00
Vijayendra Bhamidipati
e5b4cf5cf1
Bug 13127: API error text refer to database ids instead of uuids
...
Description:
1) Put in an IdentityProxy object in the ExceptionResponse class.
This allows us to copy over the IdentityProxy object contained
in the exception caught by handlerequest() when thrown by the
command's execute() method, into the Response object that is
prepared to return an exception response to the calling API
invocation.
2) Modified the GSON serialization method to conver the entire
exception object into JSON format and not just the error text.
3) Modify the updateDomain API to populate the exception it throws
upon detecting a duplicate domain to include the tablename and
domain db id in the exception's IdentityProxy object.
NOTE:
1) We can modify the base exception classes and the ExceptionResponse
class to contain a list of IdentityProxy objects rather than a
single one.
2) We will need to modify all commands such that wherever applicable
(wherever a db id is involved), they populate the IdentityProxy
object(s) before throwing an exception.
2012-02-27 17:54:58 -08:00
alena
b883b25a12
bug 11348: make content type for "json" files configurable
...
status 11348: resolved fixed
2011-09-07 14:22:01 -07:00
alena
41e5e38fef
bug 9336: securityGroups can be used by other securityGroups in the same domain only; no cross domain SG authentication
...
status 9336: resolved fixed
Following changes were made:
* deleteSecurityGroup/authorizeSecurityGroupIngress - removed account/domainId parameters as SG is uniquely identified by id now
* removed account_name field from securityGroup DB table; removed allowed_security_group/allowed_sec_grp_acct from security_ingress_rule.
These values were used for api response generation only for performance purposes; added caching on API level to improve performance
* Added missing security checks for securityGroups/ingressRules
2011-04-22 11:35:29 -07:00
Frank
92155522f2
Add license header to files
2011-04-14 11:23:14 -07:00
Alex Huang
075fba5899
stackmaid is now taskmanager
2011-04-05 10:17:22 -07:00
Kelven Yang
d78cea1cea
fix merge conflicts
2011-02-15 17:08:01 -08:00
Kelven Yang
43c82d03d8
UTF-8 fix - make encoding work across GET/POST
2011-02-15 17:06:29 -08:00
alena
a05400604b
bug 8565: throw unsupported error code when non existing api command is sent
...
status 8565: resolved fixed
2011-02-15 16:01:09 -08:00
Kelven Yang
a0c48d7fa1
1) Rename console-common to console so that Eclipse project name is the same as folder name
...
2) Fix UTF encoding issue at servlet response
2011-02-15 10:04:06 -08:00
will
c89ad5ae7b
bug 8485: Merge from 2.2.x. Fixed ClassCastException with returning the login response in xml format
2011-02-08 15:22:40 -08:00
Ragnar B. Johannsson
ee923e5797
Added HTTP Header 'X-Description' to API error responses.
...
For easy access to API error descriptions in the CloudBridge.
2011-01-11 18:27:03 +00:00
Ragnar B. Johannsson
a013640180
Bugfix: Do not URL-decode API parameters twice.
...
There's no need to call ApiServer's handleRequest with decode=true
since Tomcat has already url-decoded the parameters. URL-decoding
twice breaks all Base64 encoded data such as userData in deployVM,
since %2b decodes to ' ', not '+' as it should.
2011-01-06 14:25:59 +00:00
alena
5743db87e1
bug 5482: build Error api response based on responseType(xml, json) specified in the request instead of using default HttpServlet error response format
...
status 5482: resolved fixed
2011-01-04 15:08:12 -08:00
Alex Huang
544fa7ff1b
remote access vpn, user ip address changes
2010-12-29 09:32:54 -08:00
abhishek
8ea2959f71
sending back a account_error errorcode for trying to log into a locked account. also, changing the domainId to domainname for this error
2010-12-08 16:11:16 -08:00
Kelven Yang
54f177cacc
1) Make generic dao be able to persist UTF-8 string for internationalization support
...
2) Undo gson Unicode escape in API response object to avoid double escaping which can break Javascript from getting correct text content
3) Correct API layer in dealing with character encoding
4) Remove double escape in cloud.core.js
2010-11-30 09:40:54 -08:00
alena
aa8aa6027a
Modified UserContext - got rid of accountName, domainId fields as we can get this information from Account field.
2010-11-24 14:29:08 -08:00
alena
138e0914b6
bug 7245: don't try to set vm name for detached volume during expunge process.
...
status 7245: resolved fixed
Fixed couple of other problems:
* cleanup corresponding records in load_balancer_vm_map table when loadBalancerRule is removed.
* don't log "java.lang.IllegalStateException: getAttribute: Session already invalidated" exception when UI session expires
2010-11-19 20:08:18 -08:00
alena
91a87f9d8f
bug 7155: fixed NPE in AuditTrial which used to happen when logout command was executed when session was already invalidated.
...
status 7155: resolved fixed
2010-11-17 21:42:51 -08:00
abhishek
10cfe07970
bug 6793: returning the right msg to the ui when we try to log in to a locked account
2010-11-16 14:15:08 -08:00
abhishek
92e3dc91c4
found a bug in the code where we were not decoding the params sent in eg. "a b" was being stored in the db as 'a%20b'. Fixing the same to have the right val persisted to the db
2010-11-16 11:46:55 -08:00
abhishek
fc461abed1
bug 6755: adding checks for commands before they hit the ms; to ensure they are valid. Also returning the right error msg if the command is not valid
...
status 6755: resolved fixed
2010-11-12 13:55:06 -08:00
alena
6e0b500a83
bug 4964: made listDomainChildren work with "isRecursive" flag
...
status 4964: resolved fixed
2010-11-11 14:32:36 -08:00
Alex Huang
d5d8f27cad
Added more changes to the api
2010-10-21 15:11:49 -07:00
Kris McQueen
f4f00cbe2d
bug 6655: when verifying request signature for API requests that use keys, pass the userId of the requester as a Long to avoid NPEs when converting it to a string. Also set up the UserContext for both normal users and admins.
...
status 6655: resolved fixed
2010-10-19 11:41:09 -07:00
Kris McQueen
5960911511
Fix processing of session parameters in logout case
2010-10-12 19:42:53 -07:00
Kris McQueen
2740ba6c40
final merge of master->2.1.refactor preparing for merge back into master
2010-10-12 14:46:24 -07:00
nit
f7f2b5666a
bug 5871: removing the NDC since there is no nested context involved in the audit trail and since its leaking into the management server logs.
2010-10-05 19:51:12 +05:30
nit
38fd80e522
bug 5871: Introducing audit trail for all the interactions with the cloud stack - User 'X' initiated an action 'Y' on resource 'Z'. The audit will contain http api request along with the contextual parameters (userId, accountId, sessionId). For the response part only log success/failure for all sync api's with the exception of queryAsyncJob where reason code and reason will also be logged. For async api's I will also log the async job id.
2010-10-04 14:27:40 +05:30
Kris McQueen
bc2449a69a
If the session in invalidated due to a bad session key, just return to avoid the situation where the session is invalidated twice (which causes IllegalStateException)
2010-09-30 11:39:36 -07:00
Kris McQueen
0105aec338
Always set the response type on the command object so that the correct output is generated. Add both Strings and Longs to the login response (domainId and userId will be the Longs). Use the correct method name for ListSystemVMsCmd.
2010-09-29 17:32:19 -07:00
Kris McQueen
da660f2575
Change session parameters to be their actual type (domainId and userId are saved to the session as Longs and not Strings)
2010-09-29 15:18:43 -07:00
Kris McQueen
a8112f65de
When using session based authentication, we now store the parameters in the session as part of the login processing, instead of returning those parameters so that the caller has to update the session. Authentication now throws an exception on failure and the caught exception is where the session is invalidated.
2010-09-13 17:04:11 -07:00
Kris McQueen
df10af0688
cleaning up imports, fixing up some compilation problems related to API refactoring
2010-09-13 15:25:46 -07:00
Kris McQueen
449d1f3acf
working through some compilation errors that have arisen due to all the API refactoring...
2010-09-13 14:46:23 -07:00
Manuel Amador (Rudd-O)
ac730ec496
Branch 2.1.refactor committed
2010-08-11 09:13:42 -07:00
Manuel Amador (Rudd-O)
05c020e1f6
Source code committed
2010-08-11 09:13:29 -07:00