Will Stevens
20f779298d
merging 4.8 -> master
2016-05-27 15:19:33 -04:00
jeff
7aec943ef8
Emit template UUID and class type over event bus when deleting templates.
...
The behavior is now consistent with template creation. This commit
also adds a unit test for this functionality to make sure that it will
always happen.
2016-05-26 11:20:39 +00:00
Will Stevens
978184bccb
Merge pull request #1424 from syed/create-template-api-bug
...
[CLOUDSTACK-8973] Fix create template from snapshot returning null in case of region storeThis PR fixes a case where when we create a template from a snpashot in a region wide store, we don't set the cross zone flag which causes a null response to be returned
Tests:
Before fix
```
(local) > create template snapshotid=33aa3f3b-5a47-4d2a-8d27-12952c01ebed displaytext=t2 ostypeid=20c8ead6-d750-11e5-9f8c-06524200007c name=t9
accountid = 1b13d7c2-d750-11e5-9f8c-06524200007c
cmd = org.apache.cloudstack.api.command.admin.template.CreateTemplateCmdByAdmin
created = 2016-02-23T16:09:24+0000
jobid = 4f9f5ff9-e7f0-4af6-999c-799431fd47de
jobinstanceid = a08a9711-bd31-43bb-80a2-49cf9d722a19
jobinstancetype = Template
jobprocstatus = 0
jobresult:
null:
crossZones = False
isfeatured = False
ispublic = False
isready = False
tags:
jobresultcode = 0
jobresulttype = object
jobstatus = 1
userid = 1b140f08-d750-11e5-9f8c-06524200007c
```
See the *null* in response
After fix:
```
(local) > create template snapshotid=33aa3f3b-5a47-4d2a-8d27-12952c01ebed displaytext=t2 ostypeid=20c8ead6-d750-11e5-9f8c-06524200007c name=t11
accountid = 1b13d7c2-d750-11e5-9f8c-06524200007c
cmd = org.apache.cloudstack.api.command.admin.template.CreateTemplateCmdByAdmin
created = 2016-02-25T21:47:03+0000
jobid = 1b74209b-b3c1-4168-a243-f559aa0c081b
jobinstanceid = 06ecee5a-b1f2-4e67-80fb-f0f44b0aa198
jobinstancetype = Template
jobprocstatus = 0
jobresult:
template:
id = 06ecee5a-b1f2-4e67-80fb-f0f44b0aa198
name = t11
account = admin
created = 2016-02-25T21:47:03+0000
crossZones = True
displaytext = t2
domain = ROOT
domainid = 1b13ab80-d750-11e5-9f8c-06524200007c
format = VHD
hypervisor = XenServer
isdynamicallyscalable = False
isextractable = True
isfeatured = False
ispublic = False
isready = True
ostypeid = 20c8ead6-d750-11e5-9f8c-06524200007c
ostypename = CentOS 5 (64-bit)
passwordenabled = False
size = 21474836480
sourcetemplateid = 1af0f0cc-d750-11e5-9f8c-06524200007c
sshkeyenabled = False
status = Download Complete
tags:
templatetype = USER
jobresultcode = 0
jobresulttype = object
jobstatus = 1
userid = 1b140f08-d750-11e5-9f8c-06524200007c
```
Works correctly
* pr/1424:
Fix create template from snapshot returning null in case of region store
Signed-off-by: Will Stevens <williamstevens@gmail.com>
2016-05-25 23:04:31 -04:00
Mike Tutkowski
2bd035d199
Support for backend snapshots with XenServer
2016-05-13 01:02:04 -06:00
Syed
7b5d5648d8
Fix create template from snapshot returning null in case of region store
2016-05-09 15:59:23 -04:00
SudharmaJain
93ce108e0c
CLOUDSTACK-8901: PrepareTemplate job thread hard-coded to max 8 threads
2016-04-21 09:13:06 +05:30
Syed
52fc2bab69
Add ability to download templates in Swift
2016-04-05 16:40:00 -04:00
cirstofolini
1a64c247ad
Removed unnecessary @Local annotations and their respective imports from the ComponentLifecycleBase class and its subclasses.
2015-11-21 18:31:11 -02:00
Anshul Gangwar
8511d62b5a
CLOUDSTACK-8834: Fixed unable to download Template , when in multi zones
...
We were listing image stores by zone id which was resulting in listing of only one image store
If in that image store its download state is not DOWNLOADED then download template is failing
2015-09-11 15:30:39 +05:30
Rajani Karuturi
8bc0294014
Revert "Merge pull request #714 from rafaelweingartner/master-lrg-cs-hackday-003"
...
This reverts commit cd7218e241 , reversing
changes made to f5a7395cc2 .
Reason for Revert:
noredist build failed with the below error:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.2:compile (default-compile) on project cloud-plugin-hypervisor-vmware: Compilation failure
[ERROR] /home/jenkins/acs/workspace/build-master-noredist/plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java:[484,12] error: non-static variable logger cannot be referenced from a static context
[ERROR] -> [Help 1]
even the normal build is broken as reported by @koushik-das on dev list
http://markmail.org/message/nngimssuzkj5gpbz
2015-08-31 11:27:57 +05:30
Rafael Weingartner
3818257a68
Solved jira ticket: CLOUDSTACK-8750
2015-08-28 22:35:08 -03:00
Devdeep Singh
fedef2e6ca
CLOUDSTACK-8687: Unit tests for validating the prepare template functionality.
...
These tests validate that the templates get scheduled for seeding. Additionally,
if a template is already seeded, we do not try and seed it again. Tests also
validate that templates are seeded to storage pools which are available.
2015-08-19 10:06:54 +05:30
Devdeep Singh
adf6b588dd
CLOUDSTACK-8687: Update prepare template api to seed/prepare a template
...
only on a given primary storage. Currently, the prepare template api
will seed/prepare a given template on all the primary storage pools in
a zone. If however, a user wishes to prepare a template only a
particular storage pool, it isn't possible. Updated the api to take
storage pool id as an optional parameter. If the pool id is provided
then the template is prepared only on the given primary storage pool
2015-08-19 10:04:05 +05:30
Maneesha.P
f7e8d44552
Implemented condition that only admin or owner of the template can change its permissions using updateTemplatePermissions API
2015-08-11 11:08:35 +05:30
Daan Hoogland
edfe6f4d4f
findbugs Boolean return null in getter not in is-query
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
This closes #534
2015-06-28 12:41:44 +02:00
Rajani Karuturi
e0721fe976
volume upload: when create template fails, rolling back transaction
2015-05-04 15:15:33 +05:30
Rajani Karuturi
0b8355920e
Merge branch 'volume-upload' into master
...
This closes #206
2015-04-29 11:12:53 +05:30
Rajani Karuturi
faaa1365a3
Throwing an exception incase the template service couldnt register template.
2015-04-27 15:12:09 +05:30
Rajani Karuturi
75ae90b073
volume-upload: added account level secondary storage resource limit checks
2015-04-24 15:48:44 +05:30
Rohit Yadav
79a46fe0b4
CLOUDSTACK-8399: Allow changing hvm flag in updateTemplate API
...
This allows changing the hvm flag for a template after the template has been
registered.
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit 3e8b12bbb1 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-04-23 15:28:22 +02:00
Rajani Karuturi
4f35d3611a
volume upload: fixed the error message incase of wrong image format
2015-04-16 17:43:46 +05:30
Sanjay Tripathi
30604e973a
CLOUDSTACK-8386: CS is returning sec. storage even if it is full and there are other sec. storage with free space.
2015-04-14 16:10:40 +05:30
Rajani Karuturi
c32a6695dc
wrapped create template in db transaction
...
Template entry created in DB even though GetUpload* API fails with "No
ssvm present" error
2015-03-23 11:19:21 +05:30
Rajani Karuturi
018023c1ef
volume upload: added validation for file formats
...
merged TemplateUtils and ImageStoreUtil to a singe ImageStoreUtil
also added a unittest for ImageStoreUtil
2015-03-20 16:25:13 +05:30
Rajani Karuturi
3de5d9db5f
volume upload: Restart of MS leads to loss of browser uploaded templates
...
on restart of management server, template sync runs. It checks for
templates in ssvm using the uniquename. If it doesnt find any, cleans
the directory. In case of uploaded templates, these are getting saved
using name instead on uniquename and hence template sync cant find them
and does cleanup. Using uniquename in template.properties now.
2015-03-16 12:45:24 +05:30
Rajani Karuturi
b16520bcec
volume upload: added max size check for temaplte/volume post upload
...
used the existing configuration variables max.template.iso.size and
storage.max.volume.upload.size for templates and volumes respectively.
2015-03-03 17:27:40 +05:30
Rajani Karuturi
b616894c21
volume upload: fixed issues during request validation
...
adding the encoded metadata to the signature
2015-02-17 11:50:58 +05:30
Rajani Karuturi
5c4fd12a9b
volume upload: using the timeout from configuration
...
removed the hardcoded 60 min
2015-02-17 11:33:29 +05:30
Rajani Karuturi
812a140d17
volume upload: returning only the first payload incase of templates
...
Cross zone copy will be intiated by the management server.
2015-02-17 11:32:40 +05:30
Rajani Karuturi
3814677977
volume upload: getUploadParamsForVolume url has IP address instead of hostname, SSL fails
2015-02-17 11:31:44 +05:30
Koushik Das
6ff8752fd0
volume-upload: gc thread to clean partially uploaded files
...
Fixed multiple issues in the template code path
2015-01-31 17:25:19 +05:30
Mike Tutkowski
0f84e042b9
Adding support for creating a volume from a snapshot when the snapshot is on managed storage
2015-01-20 15:24:33 -07:00
Rajani Karuturi
15ae33a5b6
volume upload: refactored post upload command and used it during template registration
2015-01-20 09:24:14 +05:30
Rajani Karuturi
1ae34d98d4
volume upload: fixed circular reference error while generating json
2015-01-13 10:41:39 +05:30
Rajani Karuturi
9bb6cf8452
volume upload: persisting the volume metadata
...
on calling GetUploadParamsForVolume, persisting the metadata to db
validating the account limits and incrementing the appropriate limits
encoded the metadata on management server using preshared key
2014-12-18 17:50:51 +05:30
Rajani Karuturi
36c0c38ab8
volume upload: added the url validation check when url is not null
2014-12-16 15:41:27 +05:30
Rajani Karuturi
f70a2a1486
volume upload: renamed command classes to follow the naming convention
2014-12-16 12:48:37 +05:30
Rajani Karuturi
7e030ee72d
volume upload: persisting the template metadata
...
on calling GetUploadParamsForTemplate, persisting the metadata to db
validating the account limits and incrementing the appropriate limits
encoded the metadata on management server using preshared key
2014-12-16 11:52:09 +05:30
Wei Zhou
13205e6be1
CLOUDSTACK-8050: VM Guest OS type does not update if template guestostype changes
2014-12-09 08:21:35 +01:00
Laszlo Hornyak
3577423da9
removed executable flags from java classes
...
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-11-23 19:49:01 +01:00
Rohit Yadav
97fa4a023e
CLOUDSTACK-7871: allow VM and template details update using update APIs
...
Allows updating details (key/value) pair which updatse entries
invm_template_details and user_vm_details tables using updateVM and updateTemplate
APIs. This allows sys admins to update nics, controllers etc without DB hacking.
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-11-10 17:51:57 +05:30
Mike Tutkowski
9338abb6f3
Check to see if the Map<String, String> of capabilities passed back from the storage driver is null.
2014-11-06 19:49:44 -07:00
Mike Tutkowski
ebb96f5e2f
Handle the case where the volume a snapshot was created from is removed from the database
2014-11-06 19:44:46 -07:00
Kishan Kavala
e427d0004c
CLOUDSTACK-7267: For LXC volumes, show unsupported operation error for template creation from ROOT volume
2014-11-03 17:20:21 +05:30
Santhosh Edukulla
1aef5cba66
Fixed Coverity Issues
2014-11-03 16:45:30 +05:30
Mike Tutkowski
06f6b00cd1
Snapshot support
2014-10-21 16:01:13 -06:00
Nitin Mehta
e1a993d37b
CLOUDSTACK-7754: Templates source_template_id is null when it is created from Snapshot with its corresponding volume removed. Fix it by searching for volumes including removed. Also bring the logic of setting source template id to create() method than execute which was wrongly put in.
2014-10-21 09:57:02 -07:00
Nitin Mehta
a72580def0
CLOUDSTACK-7754: Templates source_template_id is null when it is created from Snapshot with its corresponding volume removed. Fix it by searching for volumes including removed.
...
(cherry picked from commit 287ff83552 )
2014-10-20 16:50:22 -07:00
Hugo Trippaers
9ead2046d4
CID-1240106 Remove unused variable
2014-09-23 11:02:40 +02:00
Nitin Mehta
082aed3d33
CLOUDSTACK-7588: [Vmware] Creating templates (with same names) from volumes get deleted from CS. Fix it by changing the unique name generation to the standard one used by registertemplate. Also cleaned up vmtemplatevo which had too many constructors.
2014-09-19 13:40:17 -07:00