Santhosh Edukulla
dc2346147b
Fixed few coverity issues reported
2014-07-30 17:06:35 +05:30
Min Chen
a216046191
CLOUDSTACK-7165:[Automation] NPE observed during restart and expunge VM.
2014-07-25 15:51:47 -07:00
Santhosh Edukulla
deeb754bfa
Fixed Coverity Issues Reported
2014-07-25 16:42:14 +05:30
Santhosh Edukulla
16b1746111
Fixed Coverity Issues Reported
2014-07-25 16:40:43 +05:30
Nitin Mehta
2ed22b3ba7
CLOUDSTACK-5641: Local disk usage on host don't show up in the admin's webui. Correcting the view to include capacity type 9 which is local storage. Also changing the response to just pick the used bytes coming in through the view which now stands corrected.
...
Verified that the dashboard and storage pool view works fine.
2014-07-24 17:16:30 -07:00
amoghvk
c804660c74
CLOUDSTACK-7168: Revert "Fixed Coverity Issues reported" that broke CI
...
This reverts commit 4523490d44 .
2014-07-23 11:37:36 -07:00
Santhosh Edukulla
4523490d44
Fixed Coverity Issues reported
...
Signed-off-by: Santhosh Edukulla <santhosh.edukulla@gmail.com>
2014-07-22 18:03:36 +05:30
Suresh Ramamurthy
03de9cc335
CLOUDSTACK-6845 : NuageVsp Network plugin
...
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-07-21 10:49:49 +02:00
Saksham Srivastava
d382be9578
CLOUDSTACK-6508: impossible to list projects from API with domainid set
2014-07-17 14:26:25 +05:30
Santhosh Edukulla
97d296bfbd
Fixed Coverity reported performance issues like inefficient string concatenations, wrong boxing or unboxing types, inefficent map element retrievals
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-07-01 22:06:25 +02:00
Sanjay Tripathi
28505c2729
CLOUDSTACK-6884: List Capacity API always returns GPU capacity also even if type is different.
2014-06-27 15:58:42 +05:30
Nitin Mehta
80ef915fd5
CLOUDSTACK-7000: ListSnapshotPolicy should list by policyid. Introduce updateSnapshotPolicy command
...
(cherry picked from commit fce21439fa )
2014-06-26 11:38:41 -07:00
Nitin Mehta
cb5e8c591f
CLOUDSTACK-6987: Add support for storing metadata for snapshot policy and controlling policy using display flag
...
(cherry picked from commit 5cf8edd7ec )
2014-06-24 14:07:39 -07:00
Kelven Yang
60f4203cbc
Protect event interpretion from causing NPE exception
2014-06-20 10:16:04 -07:00
Alena Prokharchyk
887f027a9a
CLOUDSTACK-6907: lisVolumes - make a decision whether to set service or disk offering in the response, based on the DiskOfferingVO type entry, not the volume Type
2014-06-12 16:25:04 -07:00
Jayapal
923c0cd89f
CLOUDSTACK-6899: Added vmId in listnics response
2014-06-12 17:18:08 +05:30
Nitin Mehta
c2a0fb4e52
CLOUDSTACK-6895: 1. Populate firstclass entities as uuids in the context instead of dbids for performance.
...
2. Add ctxDetails in the ParamGenericValidationWorker to avoid warning for api validation
3. Add some missing events.
4. Correcting mapping for ResourceObjectType.NetworkACL and ResourceObjectType.NetworkACLItem
(cherry picked from commit 8a9092c3cd )
2014-06-11 15:24:56 -07:00
Olivier Lemasle
a5902f1db4
CLOUDSTACK-6850: Return cpu cores, cpu speed and memory in listUsageRecords
...
Signed-off-by: Sebastien Goasguen <runseb@gmail.com>
2014-06-10 03:11:35 -04:00
Koushik Das
d34419579e
CLOUDSTACK-6843: [Automation] List listServiceOfferings api fails with NPE
...
Incorrect parameter name used in query building resulted in a bad sql query.
2014-06-05 13:57:38 +05:30
Hiroki Ohashi
3256e88623
Allow usaage reporting on removed service offering
2014-05-29 19:12:11 +02:00
Marcus Sorensen
20a31b43d6
CLOUDSTACK-6784: Expose data types via API so consumers of API can validate data
2014-05-27 15:23:23 -06:00
Marcus Sorensen
96055058b0
CLOUDSTACK-6785: changed async job param injectedjobid to customjobid and check for unique/uuid
2014-05-27 15:23:12 -06:00
Marcus Sorensen
2a5bf65c78
CLOUDSTACK-6785: Allow async jobs to supply an injectedjobid
2014-05-27 15:23:02 -06:00
Min Chen
faa379b6c2
CLOUDSTACK-6752: IAM command class separation caused ApiDoc warning of
...
duplicated cmd class for the same api name.
2014-05-22 18:28:25 -07:00
Min Chen
b259bccee7
CLOUDSTACK-6742: listVolumes - As regularuser , able to list Vms and
...
volumes of other users.
2014-05-22 18:28:00 -07:00
Min Chen
ba848087f8
Disable IAM feature from 4.4 release.
2014-05-22 18:27:08 -07:00
Murali Reddy
965346cad1
CLOUDSTACK-6712: NPE in findJobInstanceUuid() in ApiDBUtils
2014-05-20 10:26:12 +05:30
Nitin Mehta
667c8e7905
CLOUDSTACK-6699: listResouceDetails - enhance it to list by (key,value) pair - allowed to Admin only.
2014-05-18 23:21:37 -07:00
Sanjay Tripathi
f789a03769
CLOUDSTACK-6678: API:MS: listCapacity returns; errorcode":530,"cserrorcode":9999,"errortext":"Index: 0, Size: 0"}.
2014-05-15 14:22:40 +05:30
Sanjay Tripathi
35cd61c463
CLOUDSTACK-6649: CS is not giving the system-wide capacity for GPU reosurce.
2014-05-14 15:05:28 +05:30
Amogh Vasekar
9b6d430171
This patch disallows deleting / modifying system defined guest OS mappings
...
Local env
1. Create user defined mapping
2. Delete / modify user defined mapping. Should pass
3. Delete / modify system defined mapping. Should fail
Signed off by :- Nitin Mehta<nitin.mehta@citrix.com>
2014-05-12 22:45:24 -07:00
Nitin Mehta
7ae784ba3c
CLOUDSTACK-6633: listVolumes should return template/iso info for root volumes
2014-05-11 20:36:53 -07:00
Min Chen
0f79223f28
CLOUDSTACK-6613:IAM: authorizeSecurityGroupIngress fails when SG Name is
...
passed.
2014-05-08 23:19:28 -07:00
Kelven Yang
521ac796dd
Move EventBus hookup on job framework to ApiServer to decouple job framework away from business logic related hookups. The decoupling is done through internal messaging facility provided inside management server.
2014-05-06 15:48:22 -07:00
Tanner Danzey
601827e6b3
CLOUDSTACK-5907, CLOUDSTACK-6396: KVM/RBD & KVM/CLVM volumes mistakenly shown as OVM, disables snapshotting
...
modified: server/src/com/cloud/api/ApiDBUtils.java
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-05-05 15:15:25 +02:00
Min Chen
3314e11b70
CLOUDSTACK-6569: IAM - Regular user is able to listNetworks of another
...
user in the same domain , by passing account and domainId.
2014-05-02 14:58:11 -07:00
Sam Schmit
81b4731e3b
CLOUDSTACK-6472 listUsageRecords: Pull information from removed items as well, fixing NPEs/Null UUIDs with usage API calls.
...
Signed-off-by: Sebastien Goasguen <runseb@gmail.com>
2014-05-02 16:27:21 -04:00
Min Chen
d7c5382c58
CLOUDSTACK-6535: IAM:MS:API createVMSnapshot doesn't preserve access
...
rights.
2014-05-01 15:57:28 -07:00
Min Chen
2521fd482b
CLOUDSTACK-6513: remove commented code.
2014-05-01 15:57:28 -07:00
Min Chen
db9aee4517
CLOUDSTACK-6513: templateFilter=shared should not show self-owned
...
template.
2014-05-01 15:57:28 -07:00
Min Chen
a9072a6612
CLOUDSTACK-6513: Optimize code by removing deprecated utility to
...
QueryManagerImpl as private method just used for listTemplates and
listAffinityGroups to avoid misuse by new list APIs.
2014-05-01 15:57:28 -07:00
Min Chen
5521581b6e
CLOUDSTACK-6532:Affinity Groups - As admin user, not able to list all
...
affinity groups available for regular users by passing account and
domainId paramater. This is to revert IAM way of implementing
listAffinityGroupsCmd, will bring it back when we have implemented real
impersonation.
2014-05-01 15:57:27 -07:00
Nitin Mehta
dd55095fd5
CLOUDSTACK-6530: Populate the first class entities in the context to be available for publishing more information for the event bus, checking the displayable property etc.
...
(cherry picked from commit 3e7ea4e8d9 )
2014-04-28 18:21:48 -07:00
Min Chen
44ff7fea5f
CLOUDSTACK-6513: IAM - Templates - When templates are listed with
...
templatefilter="shared" is used , we see public templates also being
included in the list. This commit reverts listTemplates behavior to 4.3
old logic without using consistent interpretation of list parameters
adopted in new IAM model.
2014-04-28 11:11:53 -07:00
Prachi Damle
9514c9e045
CLOUDSTACK-6349: IAM - No error message presented to the user , when
...
invalid password is provided.
- AccountManager now works using accountId instead of accountType in
following methods too:
- isResourceDomainAdmin()
- isAdmin()
2014-04-28 11:10:50 -07:00
Sebastien Goasguen
744e2a54e8
Review from pyr https://reviews.apache.org/r/20557/
2014-04-25 16:59:47 -04:00
Alena Prokharchyk
1e0d6716ca
CLOUDSTACK-6436: listResourceDetails - don't return entries set with display=false, by default
...
Conflicts:
api/src/org/apache/cloudstack/api/command/user/volume/ListResourceDetailsCmd.java
2014-04-24 14:35:46 -07:00
Alena Prokharchyk
9c4d20cb68
Revert "Return isolation methods as a part of listPhysicalNetworks call"
...
This reverts commit 316f23ed5f .
2014-04-22 18:06:46 -07:00
Alena Prokharchyk
316f23ed5f
Return isolation methods as a part of listPhysicalNetworks call
2014-04-22 14:57:04 -07:00
Min Chen
82821daffc
Fix listAccountsCmd logic to be consistent with new interpretation of
...
listAll, isRecursive and domainId parameters.
2014-04-18 17:24:00 -07:00
Alena Prokharchyk
6cfe248e2b
Fixed NPE in listResourceDetalis logic
2014-04-18 16:32:05 -07:00
Min Chen
29f39149b1
Fix IAM list api implementation based on agreed interpretation for
...
listAll, isRecursive, domainId and account.
2014-04-17 18:33:22 -07:00
Prachi Damle
a0cd0c4d9d
Changes while processing the @ACL annotation, to include only 1 object per parameter even if the parameter is tied to multiple interfaces in the @EntityReference
2014-04-17 17:54:19 -07:00
Min Chen
da13165743
Change AccountManagerImpl.checkAccess to invoke SecurityChecker
...
interface that takes multiple controlled entities.
2014-04-17 17:53:01 -07:00
Antonio Fornie
f5ba020633
Fix: ParamGenericValidationWorker shouldn't be case sensitive
...
Signed-off-by: Alena Prokharchyk <alena.prokharchyk@citrix.com>
2014-04-14 10:05:19 -07:00
Marcus Sorensen
11f5bdd78d
CLOUDSTACK-6191 Add support for specifying volume provisioning
...
type (thin, sparse, fat) in disk/compute offerings.
Submitted-by: Yoshikazu Nojima <mail@ynojima.net>
Reviewed-by: Marcus Sorensen, Mike Tutowski
2014-04-10 09:23:04 -06:00
Sanjay Tripathi
6a725c6795
CLOUDSTACK-6373: listHost API response is not listing all the details of vgpuType.
2014-04-10 14:08:32 +05:30
Daan Hoogland
e97e65bff0
findbugs: toArray of the right type, not Object[]
2014-04-05 10:14:54 +02:00
Min Chen
94ebc90877
Remove usage of sameOwner checkAccess invocation, and convert to
...
OperateEntry IAM check.
2014-04-04 16:38:29 -07:00
Prachi Damle
a509f94544
Adding SecurityChecker list for the ParamProcessWorker
2014-04-04 16:38:29 -07:00
Prachi Damle
897e0d3abe
SecurityChecker can accept multiple ControlledEntity
2014-04-04 16:38:29 -07:00
Edison Su
25a6234a5b
fix build
2014-03-28 16:24:45 -07:00
edison
d4c7574f12
CLOUDSTACK-5831: Fix NPE, in case the volume isn't attached to any pool
2014-03-28 16:23:27 -07:00
Edison Su
7c04aa6115
CLOUDSTACK-5831: return quiescevm field in volumeresponse
...
Conflicts:
api/src/org/apache/cloudstack/api/response/VolumeResponse.java
server/src/com/cloud/api/query/QueryManagerImpl.java
2014-03-28 16:23:19 -07:00
Laszlo Hornyak
c6d2549939
StringBuffer replaced with StringBuilder in ApiServerService
...
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-03-24 21:04:06 +01:00
Laszlo Hornyak
aef76f71ec
StringBuffer replaced with StringBuilder in ApiServlet
...
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-03-24 21:03:48 +01:00
Laszlo Hornyak
843464efc8
removed commented-out code
...
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-03-24 19:05:47 +01:00
Laszlo Hornyak
96d56b7525
Tests for ApiServlet
...
- tests for login
- loginSuccessResponse test for xml and json
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-03-24 19:05:47 +01:00
Laszlo Hornyak
265208a261
Basic tests for ApiServlet
...
new tests for ApiServlet covering
- utf8Fixup
- some of processRequestInContext
minor cleanup done in StringBuffer handling and utf8Fixup got a bit shorter
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-03-22 18:34:46 +01:00
Laszlo Hornyak
3dc4d2ec21
Removed commented-out code
...
A big block of code commented out for about a year.
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-03-22 18:34:46 +01:00
Laszlo Hornyak
dd225684f4
new unit test for ApiResponseHelper
...
- unit test for getDateStringInternal
- StringBuffer replaced with StringBuilder, string concatenation replaced with append
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-03-22 18:34:46 +01:00
Laszlo Hornyak
2c4ac5e4d3
removed some redundant Boolean isntantiations
...
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-03-22 18:34:45 +01:00
Murali Reddy
2b51207510
persist fact that network can span multiple zones, if network offering
...
has strechedL2Subnet capability and return the zones in which
network spans in the networkreponse object
2014-03-20 17:01:33 +05:30
Murali Reddy
d2d54a9463
region level VPC support
...
introduce 'RegionLevelVpc' as capability of 'Connectivity' service. Add
support for CreateVPCOffering to take the 'regionlevelvpc' as capability
of service 'connectivity'.
introduces new capability 'StretchedL2Subnet' for 'Connectivity'
service. Also add support to createNetworkOffering api to allow
StretchedL2Subnet capablity for the connectivity service.
adds check to ensure 'Connectivity' service provider supports
'StretchedL2Subnet' and 'RegionLevelVpc' capabilities when specified in
createNetworkOffering and createVpcOffering respectivley
enable ovs plug-in to support both StretchedL2Subnet and RegionLevelVpc
capabilities
make zone id optional parameter in createVpc, zone id can be null only
if vpc offfering supports region level VPC
in region level vpc, let the network/tier to be created in any zone of
the region
keep zoneid as required param for createVpc
skip external guest network guru if 'Connectivy' service is present in
network offering
fix build break in contrail manager
permit VM's to be created in different zone that in which network is
created if the network support streched L2 subnet
add integration tests for region level VPC
rebase to master
Conflicts:
setup/db/db/schema-430to440.sql
Conflicts:
api/src/org/apache/cloudstack/api/ApiConstants.java
engine/schema/src/com/cloud/network/vpc/VpcVO.java
setup/db/db/schema-430to440.sql
2014-03-20 16:32:22 +05:30
Min Chen
ae1d6a771b
Remove IAMEntityType to use existing VO interface class to annotate
...
entityType.
2014-03-17 17:19:55 -07:00
Alena Prokharchyk
78a04c5315
CLOUDSTACK-6235: listSystemVms - retrieve vlan info of EIP address only when ip address can be found in the DB
2014-03-16 16:29:56 -07:00
Saksham Srivastava
48f8a95b06
CLOUDSTACK-6092: Storage OverProvisioning as a Per Primary Basis Allow storage.overprovisioning.factor to be specified at storape pool level.
...
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2014-03-14 12:16:46 +05:30
Murali Reddy
3139b35518
mark VPC to be using distributed router if VPC offerign supports
...
distributedrouter capability.
2014-03-14 16:56:35 +05:30
Murali Reddy
7c4443e233
-introduces 'DistributedRouter' as capability to 'Connectivity' service.
...
-create VPC offering to permit 'DistributedRouter' as capability to
connectivity service
2014-03-14 16:56:35 +05:30
Min Chen
84a528fad6
Merge branch 'master' into rbac
2014-03-13 14:52:37 -07:00
Prachi Damle
d9696b26e1
After merge, fix isRootAdmin() calls to use accountId instead of type
2014-03-13 13:28:40 -07:00
Min Chen
99bdc8d875
Merge branch 'master' into rbac.
2014-03-13 11:05:03 -07:00
Antonio Fornie
39e5b768e8
More generic parameters that are not unknown
...
Adding some more parameter names that should not be considered unknown since they belong to general use paramters
Signed-off-by: Alena Prokharchyk <alena.prokharchyk@citrix.com>
2014-03-13 10:40:14 -07:00
Koushik Das
5779292e93
CLOUDSTACK-6052: List VM enhancement to support querying with multiple VM IDs
...
New parameter 'ids' added to listVirtualMachine API. The syntax looks like
http://localhost:8096/api?command=listVirtualMachines&listAll=true&ids=eddac053-9b12-4d2e-acb7-233de2e98112,009966fc-4d7b-4f84-8609-254979ba0134
The new parameter will be mutually exclusive with the existing 'id' parameter.
2014-03-13 17:05:35 +05:30
amogh.vasekar
3ee1fc28de
CLOUDSTACK-6217:
...
Add APIs for ability to add new guest OS types, and their hypervisor specific mappings.
The table guest_os_hypervisor is currently maintained but not used, and the APIs reuse the same
Signed off by: Nitin Mehta <nitin.mehta@citrix.com>
2014-03-12 17:03:38 -07:00
Alena Prokharchyk
40192cd8a1
CLOUDSTACK-6235 - return gateway/netmask of publicVlan, along with the EIP information, for system vms in EIP/ELB setup
2014-03-12 15:11:01 -07:00
Min Chen
b554d4ac1f
Fix issues found through FindBugs.
2014-03-11 11:49:48 -07:00
Sanjay Tripathi
c7d31fe288
CLOUDSTACK-4760 : Enabling GPU support for XenServer.
...
CLOUDSTACK-4762 : Enabling VGPU support for XenServer.
This feature is to enable the GPU-passthrough and vGPU functionality,
with the help of this feature, admins/users will be able to leverage
the GPU graphics unit power by deploying a virtul machine with GPU or
vGPU support or by changing the service offering of an existing VM
at any later point of time. There GPU/vGPU enabled VMs are able to run
graphical applications.
For now, this feature is only supported with XenServer hypervisor but
can be extended to add the support of other hypervisors.
2014-03-11 15:44:51 +05:30
Nitin Mehta
33a0dec965
CLOUDSTACK-6221:
...
Publish first class objects involved in an operation (for now vm uuid) on the event bus . Example - during attach/detachIso along with iso id, vm id should be available as well.
2014-03-10 16:22:34 -07:00
Daan Hoogland
07102b400f
findbugs: scope and final to mitgate possible abuse of fields
2014-03-10 09:39:35 +01:00
Nitin Mehta
ded7e682dc
CLOUDSTACK-5478: Enable publishing uuid for all the async apis in the CallContext.
...
The advantage would be that event publishing can pick up the uuid and publish them.
2014-03-07 16:50:21 -08:00
Alena Prokharchyk
7b0c5cfcbe
Removed unused methods from BaseCmd class. Moved some helper methods to AccountManagerImpl class
2014-03-07 11:33:10 -08:00
Daan Hoogland
c257fb0e3e
rats
2014-03-07 19:27:58 +01:00
Antonio Fornie
c211f0bbbe
Dispatcher corrections, refactoring and tests
...
Corrects problems from previous attempt. Fixes based on help comments from
the community and conflict resolution
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-03-07 19:12:07 +01:00
Min Chen
48e08fe676
Merge branch 'master' into rbac.
2014-03-06 14:02:20 -08:00
Mike Tutkowski
9b66866dc2
CLOUDSTACK-6170
2014-03-06 13:01:11 -07:00
Nitin Mehta
830328b63d
CLOUDSTACK-6199: Hide action events for Vm/Volume commands when the resources have display flag=0.
...
Introduce generic BaseAsync(Vm/Volume)Cmd to make get the flag value for logging action events.
Rename the db field as display rather than display_event in keeping with the convention
2014-03-05 16:40:44 -08:00
Min Chen
793becf524
CLOUDSTACK-5920: Add some interface methods and constants required by
...
IAM.
2014-03-05 09:40:55 -08:00
Min Chen
d0ae4d9a9f
CLOUDSTACK-5920:Add interface to ControlledEntity to return IAM
...
entity type.
2014-03-05 09:40:55 -08:00
Nitin Mehta
339c4f4c3f
CLOUDSTACK-6199: Action Events - hide them when display flag is off in the context of "Ability to have better control over first class objects in CS" feature.
...
For root admin - s/he should be able to see all the events despite the value of the flag.
2014-03-04 14:59:30 -08:00
Alena Prokharchyk
bbf5a912c6
list* APIs - added parameter helping to filter by "display" flag (available to ROOT admin only)
2014-03-03 14:37:46 -08:00
Kelven Yang
537bf7ced1
add job path to help associate an API job to related internal job. Reviewed-By: Self
2014-02-28 15:35:59 -08:00
Jayapal
100a911229
CLOUDSTACK-6187: Fixed MigrateSystemVMCmd response for router
2014-02-28 16:46:57 +05:30
Alena Prokharchyk
bb6fddf434
listVirtualMachines API: ability to search by service offering the vm is created from
...
listVolumes API: ability to search by disk offering the volume is created from
2014-02-26 16:56:33 -08:00
Daan Hoogland
e431538b0a
findbugs possible nullpointer mitigated
2014-02-26 11:56:49 +01:00
Prachi Damle
f41604fc6c
Renaming AclEntityType --> IAMEntityType
2014-02-25 16:43:17 -08:00
Mandar Barve
b0c6d47347
- Updated APICommand annotation to add new flags that indicate if API request or response carry sensitive info - Updated all API classes with the new annotation flag values as per the API's sensitivity - Updated server code to check response annotation before audit logging
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
(cherry picked from commit df270d6387c362b960064ee5123c14782e767a19)
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-02-25 22:59:10 +01:00
Alena Prokharchyk
e2ec094722
Display flag support for VpnConnection/VpnGateway/RemoteAccessVpn
2014-02-21 14:51:22 -08:00
Alena Prokharchyk
0f489732c8
Display flag support for LB/InternalLB/NetworkACL rules
2014-02-21 14:03:10 -08:00
Alena Prokharchyk
92064e347a
Display flag support for autoscale vmGroup and vmProfile
2014-02-21 11:52:50 -08:00
Alena Prokharchyk
27a790bdc1
DisplayFlag update support for PF/Firewall/EgressFirewall rules
2014-02-21 11:06:52 -08:00
Alena Prokharchyk
21d016b3dd
API response: added new field to @Param - RoleType[] authorized() default {}. The field defines who is authorized to see this partciluar reponse field. If not specified, the parameter is returned to everybody
2014-02-20 17:15:43 -08:00
Alena Prokharchyk
2f7bfc0c73
Display flag support for publicIpAddress and VPC. Once set to false, the object is not listed to the regular user. Available to be set by Root admin only
2014-02-20 17:15:42 -08:00
Nitin Mehta
c171e2c3e4
CLOUDSTACK-4744: Enhance root admin API updateVolume with chaininfo parameter as a part of "Better control over first party objects" feature.
2014-02-19 18:01:18 -08:00
Min Chen
8072e50845
Fixed a bug for listTemplates with TemplateFilter=shared.
2014-02-13 16:47:41 -08:00
Alena Prokharchyk
e0de79b170
Resource metadata: by default, all metadata is set with display=true (meaning that the detail is avaialble for display to the regular user). If admin wants to set a specific detail to be false, he has to specify it explicitly in addResourceDetail command
2014-02-10 12:05:59 -08:00
Devdeep Singh
306ffa0218
CLOUDSTACK-6053: While adding a primary or secondary of type smb the password wasn't
...
encoded. This cause createStoragePool or addImageStore command to fail if special
characters were present. Updated the code to pass user, password and domain as part
of details while adding primary or secondary. Also made changes on server side to
handle it.
2014-02-10 10:29:09 +05:30
Min Chen
7bab0bc304
Optimize fix for CLOUDSTACK-5987.
2014-02-07 16:08:12 -08:00
Min Chen
3b58a45e04
Merge branch 'master' into rbac.
2014-02-07 13:43:36 -08:00
Alena Prokharchyk
782c530685
Revert "CLOUDSTACK-6003 fixing plus refactoring dispatcher" as it breaks API dispatching for commands having Map<String,String> as a parameter type
...
This reverts commit 447430c3df .
Conflicts:
api/src/org/apache/cloudstack/api/BaseCmd.java
server/src/com/cloud/api/ApiDispatcher.java
server/src/com/cloud/network/as/AutoScaleManagerImpl.java
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
2014-02-06 14:46:58 -08:00
Min Chen
c440d90466
Merge fix for CLOUDSTACK-5987 in master to RBAC.
2014-02-05 16:34:01 -08:00
Alena Prokharchyk
7cb4b571c8
ExternalUUID control: enforce checking uuid validity by defining checkUUID method in the corresponding absract class, and performing the check during API command dispatching
2014-02-04 15:47:13 -08:00
Prachi Damle
f84375442e
Merge branch 'master' into rbac
...
Conflicts:
api/src/org/apache/cloudstack/api/command/user/autoscale/ListAutoScaleVmProfilesCmd.java
api/src/org/apache/cloudstack/api/command/user/volume/ResizeVolumeCmd.java
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java
server/src/com/cloud/api/ApiServer.java
server/src/com/cloud/api/query/QueryManagerImpl.java
server/src/com/cloud/template/TemplateAdapterBase.java
setup/db/db/schema-430to440.sql
tools/apidoc/gen_toc.py
2014-02-04 12:07:32 -08:00
Antonio Fornie
447430c3df
CLOUDSTACK-6003 fixing plus refactoring dispatcher
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
(cherry picked from commit a9bcc1ea3b7dfd3fcc5c795b0095c77851ebe618)
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-02-04 13:37:08 +01:00
Alena Prokharchyk
fc56f0cf42
Revert "Findbugs: different issues solved(cherry picked from commit" as it breaks UserVm API Response
...
This reverts commit fae0556021 .
Conflicts:
server/src/com/cloud/dc/DedicatedResourceVO.java
2014-02-03 17:20:28 -08:00
Alena Prokharchyk
48361d8a8b
Fixed listAutoScaleVmGroups: used to return incorrect value in lbruleid field (wrong parameter was used when search in firewall_rules table - profileId instead of lbRuleId)
2014-01-31 09:21:55 -08:00
Alena Prokharchyk
b38c033d5c
LOUDSTACK-5987: when listTemplates with filter=community/featured, get public templates from all domains in the system, not just parent/child subdomains of the caller
2014-01-29 17:12:46 -08:00
Daan Hoogland
fae0556021
Findbugs: different issues solved(cherry picked from commit
...
0b13f8e59d )
2014-01-28 16:30:04 +01:00
Daan Hoogland
a71871d11c
findbugs: fixes for ApiServer, ApiSerializerHelper and
...
ApiXmlDocWriter(cherry picked from commit
9aced41d70 )
2014-01-28 14:47:06 +01:00
Daan Hoogland
1c7361756c
Findbugs: scariest issues in ApiResponseHelper fixed (cherry picked from
...
commit 9a1b882d0e )
2014-01-28 14:24:21 +01:00
Daan Hoogland
60e8d131cf
findbugs: moved call on static object to synchronized block(cherry
...
picked from commit f3529a19a9 )
2014-01-28 14:14:47 +01:00
Likitha Shetty
95bd04e449
CLOUDSTACK-5965. VM displayname is not returned by API.
...
If user doesn't supply a display name during VM launch, default it to VM name(uuid) in listVM response.
2014-01-28 16:43:12 +05:30
Koushik Das
a0f21ff6bf
CLOUDSTACK-5949: Remove unused field vnc_password from user_vm_view
...
Removed unused field. This will ensure that list VM queries are not blocked.
2014-01-27 15:43:20 +05:30
Min Chen
d47d4bbd20
Guard NPE due to empty policies.
2014-01-23 18:32:48 -08:00
Prachi Damle
96a64b933e
- Adding OperateEntry during loading of commands
...
- Replace ListEntry By OperateEntry
- ApiDispatcher should pass on the API name
2014-01-23 17:50:59 -08:00
Min Chen
33cd1ab921
Merge branch 'master' into rbac
2014-01-22 11:23:51 -08:00
Min Chen
c0da0a884a
CLOUDSTACK-5921:S3 security key is stored in DB unencrypted
2014-01-21 14:34:32 -08:00
Min Chen
3689f72f27
CLOUDSTACK-5913:API rate limiting throws a different error than expected
...
when Throttle limit hit in the API.
2014-01-20 15:49:19 -08:00
Min Chen
929fbabaa2
Merge branch 'master' into rbac.
2014-01-17 14:37:08 -08:00
Saksham Srivastava
06f8c1de75
CLOUDSTACK-5692: obscure passwords when using cifs as storage
2014-01-17 14:00:24 +05:30
Min Chen
dd50210e74
CLOUDSTACK-5877: ListTemplates does not sort based on sort_key.
2014-01-15 17:39:00 -08:00
Min Chen
6583cb3800
Add listAclGroupsByAccount to QuerySelector adapters and remove
...
AclProxyService interface.
2014-01-14 16:19:25 -08:00
Alex Huang
68b8891c62
Removed all reminants of the IdentityService. Created the KeysManager to move the management
...
of keys out of management server
2014-01-14 13:11:35 -08:00
Likitha Shetty
16d36dd75f
Fix checkstyle
2014-01-14 14:04:57 +05:30
Likitha Shetty
e5512960af
CLOUDSTACK-5865. Unable to use login API if domainId parameter is id and not uuid
2014-01-14 13:47:27 +05:30
Min Chen
bae498c89e
Handle search of those entities without db view created using new ACL
...
model.
2014-01-13 21:55:56 -08:00
Min Chen
43f0f901dd
Remove VO and DAO from cloud-engine-schema.
2014-01-10 15:57:39 -08:00
Min Chen
e42a262f6c
Remove old APIs and old security checker plugins. Also use QuerySelector
...
adapater in ACL search routine.
2014-01-10 14:54:31 -08:00
Prachi Damle
42e53702a2
CLOUDSTACK-5732 [UI] Search is not working in Affinity Groups panel
...
- Added keyword support
Conflicts:
api/src/org/apache/cloudstack/api/command/user/affinitygroup/ListAffinityGroupsCmd.java
api/src/org/apache/cloudstack/query/QueryService.java
server/src/com/cloud/api/query/QueryManagerImpl.java
2014-01-10 14:45:08 -08:00
Harikrishna Patnala
5bf78b82c0
CLOUDSTACK-4904: Unable to see a derieved template if the
...
parent template is deleted. Modified template_view so that removed(or InActive) templates also be there in the view.
Previous behavior of listing templates and state column in vm_templates will be the same.
2014-01-10 10:26:10 -08:00
Alex Huang
ae8560b195
Moved security out into its own jar. Will be adding more to it. Fixed a few white space issues brought up by checkstyle in eclipse.
2014-01-09 16:12:25 -08:00
Nitin Mehta
5c1d639bc4
CLOUDSTACK-5829:
...
listvms should return the diskoffering id when deployed with an iso
2014-01-08 18:32:51 -08:00
Alena Prokharchyk
c3680cc111
CLOUDSTACK-5839: fixed xml serializer to process collection field when its elements are of String type
2014-01-08 15:38:50 -08:00
Alena Prokharchyk
07557eb570
CLOUDSTACK-5839 : return canEnableIndividualService in listNetworkServiceProvidersResponse
2014-01-08 14:40:10 -08:00
Min Chen
89a20d3eed
CLOUDSTACK-5771:listImageStores returns error in keyword search.
2014-01-06 14:50:10 -08:00
Min Chen
e02e19a6f1
Make AclApiServiceTest pass without changing ApiServerService signature.
2014-01-06 10:43:01 -08:00
Min Chen
d374cd5a2c
Add Unit Testcases for AclApiService.
2014-01-03 17:18:44 -08:00
Devdeep Singh
e59420c514
CLOUDSTACK-5691: Fix for attaching an uploaded volume to instance running
...
on hyperv. There were multiple issues here. Upload volume was actually
failing because the post download check for vhd on the cifs share was
unsuccessful. Also the agent code wasn't parsing the volume path correctly.
Fixed it too.
2014-01-03 16:55:28 +05:30
Prachi Damle
e5b4a1d869
Moved the loading of commands.properties to the IAM plugin
2014-01-02 18:39:18 -08:00
Sanjay Tripathi
db8d5f602a
CLOUDSTACK-5422: Changing XenServer Tools Version 6.1 + doesnt work.
2013-12-30 20:01:06 +05:30
Prachi Damle
b7c3411be9
Fixing the issues in loading the beans
2013-12-26 15:17:10 -08:00
Alena Prokharchyk
526af5e326
Included guestOsId to userVmResponse - as we let to change this param through updateVm call, we should return it in the response
2013-12-26 13:28:29 -08:00
Alena Prokharchyk
03226ba539
Added deviceId parameter to the NicResponse. This information can be useful for the user if he wants to see the order of the networks in his vm
2013-12-24 15:34:43 -08:00
Min Chen
630b7fb4a1
Fix listTemplates issues with new ACL model.
2013-12-20 17:57:44 -08:00
Prachi Damle
ce774e184e
Fixing the management server startup
2013-12-18 14:14:55 -08:00
Kishan Kavala
cc27a740dc
CLOUDSTACK-5528 : When VR version is not known set requiresUpgrade flag to true
...
Conflicts:
server/src/com/cloud/api/query/dao/DomainRouterJoinDaoImpl.java
server/test/com/cloud/vpc/NetworkACLServiceTest.java
2013-12-18 18:29:08 +05:30
Min Chen
e53081fe26
CLOUDSTACK-5534: MySQL exception raised when searching for users with
...
keyword.
2013-12-17 16:58:22 -08:00
Min Chen
729a79e85c
Refactor db view based list apis to use new IAM acl search criteria.
2013-12-16 14:31:32 -08:00
Likitha Shetty
7cac5aa9fc
CLOUDSTACK-5514. Response of listAccounts API call includes removed users
2013-12-16 15:53:08 +05:30
Prachi Damle
3f092d14cc
Adding the AclEntityType attribute to APICommand annotation
2013-12-13 16:04:25 -08:00
Min Chen
d2922b9254
Separate ListAccounts cmd to use two different views.
2013-12-12 17:52:45 -08:00
Min Chen
312ff76f69
Separate listZones cmd to use two different views, also renamed previous
...
listZonesByCmd to listZonesCmd.
2013-12-12 17:40:30 -08:00
Min Chen
a6d03cd826
Separate IpAddress related cmds to use two different views.
2013-12-12 17:20:34 -08:00
Min Chen
add277a4aa
Separate network and VPC related cmd to use two different views.
2013-12-12 16:53:59 -08:00
Alena Prokharchyk
9df10718e4
Resource metadata support for S2SVpnConnection
...
Conflicts:
server/src/com/cloud/metadata/ResourceMetaDataManagerImpl.java
server/src/com/cloud/tags/TaggedResourceManagerImpl.java
setup/db/db/schema-421to430.sql
2013-12-12 16:39:02 -08:00
Prachi Damle
7c6f1c14c2
ControlledEntity Interface change to return EntityType and added values to the AclEntityType enum and
2013-12-12 16:31:00 -08:00
Nitin Mehta
b084cc469a
CLOUDSTACK-5283:
...
Not able to list snapshots when few snapshots are in "CreatedOnPrimary" state. Dont throw an exception when snapshot doesnt have an entry in the snapshot store ref for the snapshot in Image store because that fails to list all snapshots and also it can a perfect use case when the backup flag is not turned on.
2013-12-12 13:18:56 -08:00
Alex Huang
be5e5cc641
All Checkstyle problems corrected
2013-12-12 12:26:07 -08:00
Min Chen
67b97539ac
Separate ListTemplatePermissions and ListIsoPermissions commands to use
...
two different views.
2013-12-11 17:41:10 -08:00
Min Chen
8f21eca922
Separate Template/ISO related APIs to use two different views.
2013-12-10 12:23:39 -08:00
Min Chen
d252d95c26
Separate all vm related user APIs to have two different views.
2013-12-09 17:30:57 -08:00
tuna
015ab6af8a
fix rebase master
2013-12-09 23:33:14 +07:00
tuna
d935d3865a
tuna
2013-12-09 23:33:14 +07:00
Min Chen
a416f6c3c3
Fix API build error based on new DB schema, now only
...
RoleBasedEntityAccessChecker needs to be fixed.
2013-12-06 15:09:00 -08:00
Min Chen
c3f480e9b9
Updated db schema based on latest FS. Still need to fix old code in
...
AclServiceImpl, RoleBasedEntityAccessChecker and QueryManagerImpl to
make all build.
2013-12-04 18:44:30 -08:00
Bharat Kumar
68406ba29d
CLOUDSTACK-5161 enable scaling of a vm using custom offering
...
Signed-off-by: Koushik Das <koushik@apache.org>
2013-11-29 17:53:33 +05:30
Wei Zhou
abd4a826e9
Revert "CLOUDSTACK-5033: set origin ip address in logs if management servers is behind a reverse proxy or load balancer"
...
This reverts commit 5cc47f77c5 .
2013-11-29 10:52:51 +01:00
Wei Zhou
5cc47f77c5
CLOUDSTACK-5033: set origin ip address in logs if management servers is behind a reverse proxy or load balancer
2013-11-29 10:39:04 +01:00
Likitha Shetty
6bda2739c8
CLOUDSTACK-5302. listHosts API response - value of cpuallocated is always 0%
2013-11-28 15:52:42 +05:30
Wei Zhou
221aea5730
CLOUDSTACK-5299: set hypervisor_type of volumes from image format if not set.
2013-11-28 10:47:21 +01:00
wilderrodrigues
226b193488
Fix for Coverity issues CID_1116744, CID_1116718 and CID_1116682, all related to resource leak
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
2013-11-27 14:20:29 +01:00
Prachi Damle
cf69731a52
Suring startup load the API permissions from commands.properties and @APICommand annotations
2013-11-25 17:01:56 -08:00
Nitin Mehta
a1ca4f1d56
CLOUDSTACK-5221:
...
In order to keep backward compatibility, listisos should return an empty response than an error when id of a removed iso is passed.
2013-11-25 13:47:42 -08:00
Prachi Damle
f231cec5b7
Loading api permissions from commands.properties during startup
2013-11-25 10:59:12 -08:00
Min Chen
015d06e7fc
Separate all volume related APIs to two Cmd classes based on two
...
response views.
2013-11-22 18:48:20 -08:00
Min Chen
11c0c263f2
QueryChecker interface and ACL search criteria to be used for query api
...
for entities with db views created.
2013-11-22 16:36:38 -08:00
Min Chen
81a794a5d3
Change two static response views to Full and Restricted.
2013-11-21 10:32:08 -08:00
Alex Huang
433a631916
Reformat of source code to set a stable base for the future. I couldn't get checkstyle enabled. There's still about a thousand errors from checkstyle. Most of it from length errors from comments and strings. Will attempt to remove those tonight. This change is so large I just want to get it in before any merge nightmares. The changes are fairly minor though and I did a full compile and start a server with the reformat code.
2013-11-21 07:56:47 -08:00
Alex Huang
d620df2bdd
Reformatted all of the code.
2013-11-21 06:15:26 -08:00
Alex Huang
224f479974
Removed trailing spaces
2013-11-21 04:08:01 -08:00