62bb5d8848
fix checkstyle
2013-12-19 15:05:58 -08:00
8caf52c6bc
add xenserver 6.2.0 hotfix support, to optimize vdi copy
...
add xenserver hot fix
Conflicts:
api/src/com/cloud/vm/VirtualMachineName.java
core/src/com/cloud/host/HostInfo.java
core/src/org/apache/cloudstack/storage/to/SnapshotObjectTO.java
deps/XenServerJava/src/com/xensource/xenapi/VDI.java
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
engine/storage/src/org/apache/cloudstack/storage/endpoint/DefaultEndPointSelector.java
engine/storage/src/org/apache/cloudstack/storage/image/db/SnapshotDataStoreDaoImpl.java
plugins/hypervisors/xen/src/com/cloud/hypervisor/XenServerGuru.java
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServerPoolVms.java
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServerStorageProcessor.java
server/src/com/cloud/configuration/Config.java
2013-12-19 14:15:41 -08:00
95364a4022
CLOUDSTACK-5531
...
Initial support for vhd, raw, vmdk image formats on KVM. Tested all formats with local and CLVM.
2013-12-16 14:32:51 -07:00
fa2f18d2a2
CLOUDSTACK-4875. Vmware vCenter 5.5 - System VM deployment fails During VM deployment.
...
When base template is being cloned to create VM ROOT disk, get the disk path i.e. base file name
of the VM's ROOT disk from vCenter
2013-12-17 18:31:15 +05:30
3604f87c8d
CLOUDSTACK-5217: Attach volume fails with NPE. Made changes to make sure
...
the hypervisor product version is reported on startup. Also made changes
to fix attach and detach volume on scsi controller.
2013-12-17 16:28:08 +05:30
759d484d9a
CLOUDSTACK-5489: Query the user name and add it to the command while mounting a cifs share.
2013-12-17 14:19:32 +05:30
2f53295151
CLOUDSTACK-5521: Create multi-core topology when deploying KVM virtual machines with many cores
2013-12-16 16:12:43 -07:00
46d1e1afb2
CLOUDSTACK-5446:KVM-Secondary Store down-Even after secondary store is
...
brought back up after being down for few hours,snapshot jobs do not get
triggered with reason "there is other active snapshot tasks on the
instance to which the volume is attached".
2013-12-13 22:04:29 -08:00
86dadaaec4
CLOUDSTACK-5489: Cloud user doesn't have permissions to copy systemvm.iso to secondary.
...
Make sure when a cifs (secondary) is mounted, uid is set for the user who owns the files
and directories on the filesystem.
2013-12-13 17:32:34 +05:30
db2b8d9b0d
CLOUDSTACK-5311: Fix the host version reported by the hyper-v agent. Also updated the hypervisor
...
capabilities for hyper-v.
2013-12-13 10:28:17 +05:30
be5e5cc641
All Checkstyle problems corrected
2013-12-12 12:26:07 -08:00
ffd1a078d4
CLOUDSTACK-5462: Hyperv agent confused by existing volume of different
...
image type. Works by avoiding volume image format inference errors and
removing existing files with same name, but different format.
2013-12-12 14:56:37 +05:30
bdbc5f2ae3
CLOUDSTACK-5473: Fixed the name with which the hyper-v agent gets
...
installed as a service.
2013-12-12 14:56:29 +05:30
78b39bbe12
CLOUDSTACK-5455: Fix detach iso on hyperv. Made sure normalized path is
...
used while attaching and detaching iso. Also made normalization of path
across the agent code.
2013-12-11 19:42:36 +05:30
2b1d997728
CLOUDSTACK-5248: Fixed creation of mount point when running as non root (cloud) user.
...
The systemvm iso file is copied only when a systemvm or router vm is to be started on
a host. The file gets copied to the secondary storage. The mount point used is the one
that has permissions for regular user to mount a share.
CLOUDSTACK-5275: The failure was because a secondary storage wasn't available when the
host was added. When a setup is done through wizard the hosts get added before the
secondary storage. CS was tying to copy yhe systemvm iso to secondary and it used to
fail if it wasn't available. Made a change to copy the iso only when a systemvm is
being started on a host.
CLOUDSTACK-5202: Made changes to clean up mount points on stop and start.
All the three are related fixes; so putting a fix in one commit.
2013-12-11 17:50:13 +05:30
36cbc2dfbf
CLOUDSTACK-4498 we should not reserve memory and cpu for vmware VMs if the
...
vmware.reserve.cpu and vmware.reserve.mem are set to false while not overcommiting
Signed-off-by: Jayapal <jayapal@apache.org>
2013-12-11 13:07:56 +05:30
1ddc0b99fe
put CS/XS plugin log into seperate directory
2013-12-10 01:23:46 -08:00
dc151115be
AutoScaling without NetScaler
2013-12-10 10:35:55 +07:00
61e80f030a
remove unused code
2013-12-09 23:33:15 +07:00
c7dab82dc4
move cloudstack_pluginlib
2013-12-09 23:33:15 +07:00
3df8b912fc
add kvm support & LB service
2013-12-09 23:33:14 +07:00
d935d3865a
tuna
2013-12-09 23:33:14 +07:00
4e914b7087
re-factor gre controller
...
Signed-off-by: tuna <ng.tuna@gmail.com>
2013-12-09 23:33:14 +07:00
3a9c9bd717
fix white-space
2013-12-09 23:33:14 +07:00
79a7ce871e
make SDN GRE work with XCP 1.6
2013-12-09 23:33:14 +07:00
088247b61b
kvm: Force the default disk cache mode to none.
...
Not doing this caused the cache mode to be null for SystemVMs for their CDROM/ISO.
2013-12-09 16:49:17 +01:00
1f67ebc297
Fix nuget package path error.
2013-12-09 13:23:20 +05:30
462e6d91c1
Fix the directory path of where the nuget packages get downloaded.
2013-12-09 11:10:51 +05:30
e6127a7c00
CLOUDSTACK-5216. delete volume failed due to Exception: java.lang.Exception" while destroying Vms
2013-12-06 12:04:02 +05:30
04b48ae04e
XS VMmetadata platform contains virtual platform related info, CS should save platform info in DB to migrate the VM to other Cluster
2013-12-05 01:41:14 -08:00
0b16a45ceb
Modified savepassword.sh path in Hyperv Resource according to the new template
2013-12-05 11:45:54 +05:30
fd195433ae
fixing the test
2013-12-04 16:14:27 -08:00
71323f15c6
CLOUDSTACK-5352:
...
CPU cap calculated incorrectly for VMs on XenServer hosts. It should not be limited by the overprovisioning and should set the cap as service offering
2013-12-04 14:59:24 -08:00
71d547ba87
CLOUDSTACK-5352:
...
CPU cap calculated incorrectly for VMs on XenServer hosts. It should not be limited by the overprovisioning and should set the cap as service offering
2013-12-04 14:53:28 -08:00
bd6f706b72
CLOUDSTACK-5261: added support for Alert publishing via ROOT Admin API
...
Conflicts:
engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
engine/storage/image/src/org/apache/cloudstack/storage/image/TemplateServiceImpl.java
engine/storage/volume/src/org/apache/cloudstack/storage/datastore/provider/DefaultHostListener.java
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/discoverer/HypervServerDiscoverer.java
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java
server/src/com/cloud/alert/AlertManagerImpl.java
server/src/com/cloud/alert/ConsoleProxyAlertAdapter.java
server/src/com/cloud/alert/SecondaryStorageVmAlertAdapter.java
server/src/com/cloud/configuration/ConfigurationManagerImpl.java
server/src/com/cloud/ha/HighAvailabilityManagerExtImpl.java
server/src/com/cloud/ha/HighAvailabilityManagerImpl.java
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
server/src/com/cloud/resourcelimit/ResourceLimitManagerImpl.java
server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java
server/src/com/cloud/vm/UserVmManagerImpl.java
usage/src/com/cloud/usage/UsageAlertManagerImpl.java
usage/src/com/cloud/usage/UsageManagerImpl.java
listAlerts: introduced new parameter "name" to the alertResponse
Conflicts:
api/src/org/apache/cloudstack/api/command/admin/resource/ListAlertsCmd.java
server/src/com/cloud/alert/AlertManagerImpl.java
usage/src/com/cloud/usage/UsageAlertManagerImpl.java
Added new Admin API - generateAlert. Available to ROOT admin only
Conflicts:
api/src/org/apache/cloudstack/alert/AlertService.java
api/src/org/apache/cloudstack/api/BaseCmd.java
usage/src/com/cloud/usage/UsageAlertManagerImpl.java
listAlerts: implemented search by alert name
Conflicts:
api/src/org/apache/cloudstack/alert/AlertService.java
api/src/org/apache/cloudstack/api/command/admin/resource/ListAlertsCmd.java
engine/schema/src/com/cloud/alert/AlertVO.java
2013-12-04 10:05:46 -08:00
13740ac135
CLOUDSTACK-5178: DeployVm from ISO fails. Fixed the creation of root
...
volume and made sure the iso is attached when a vm is deployed.
2013-12-04 20:36:49 +05:30
3f8741a4ec
Changes for fixing the hyperv agent build on windows using mono.
2013-12-04 12:21:36 +05:30
d26b9ac00e
Fix for live migration of vm. Use the host name as the migration
...
destination. Also mapped the vm state corrected in check vm on host
answer.
2013-12-04 10:31:02 +05:30
5a96307fbf
Changes for allowing migration of a vm on hyperv. Migration was blocked in cloudstack for hyperv.
...
Enabled it. Also updated the agent code to allow hyperv migration.
2013-12-04 10:29:36 +05:30
cc86599c4d
adding missing license headers for cs files
2013-12-03 15:53:39 +05:30
5a062e155c
put shell scripts to a seperate directory in XS
...
use same scripts for both XS and XCP
2013-12-03 02:05:34 -08:00
30db5d648b
code to install and uninstall agent as windows service
2013-12-03 12:17:56 +05:30
1d3a4f4645
Fixed issues on HyperV Agent code for shared network VR issues
2013-12-03 12:17:32 +05:30
4d187192b3
Fix VM stats collections in HyperV
2013-12-03 12:16:53 +05:30
875e1ea281
Added contextMap data to all the command responses in HyperV
2013-12-03 12:14:56 +05:30
d473d5a36a
CLOUDSTACK-5293: get vm disk statistics only from DISK (not for ISO/FLOPPY)
2013-11-28 10:47:51 +01:00
c781e3b668
Fixing creation of VM with virtual disks on a shared storage for hyperv. The shared storage
...
path wasn't getting interpreted correctly by the agent.
2013-11-27 13:04:16 +05:30
2145505d30
CLOUDSTACK-5280: fix issue in getBroadcastUriFromBridge
...
(cherry picked from commit 96842475d9
2013-11-26 23:37:39 +01:00
84be2ab3be
CLOUDSTACK-4913: Don't enable ebtables/iptables for non-security group zone
2013-11-25 16:06:48 -08:00
433a631916
Reformat of source code to set a stable base for the future. I couldn't get checkstyle enabled. There's still about a thousand errors from checkstyle. Most of it from length errors from comments and strings. Will attempt to remove those tonight. This change is so large I just want to get it in before any merge nightmares. The changes are fairly minor though and I did a full compile and start a server with the reformat code.
2013-11-21 07:56:47 -08:00
cf715ff491
Bump 4.3.0 to 4.4.0 in master
2013-11-21 16:01:15 +01:00
d620df2bdd
Reformatted all of the code.
2013-11-21 06:15:26 -08:00
eaa250fd3c
Formatted again after all the tab expansions and eol removals
2013-11-21 04:47:01 -08:00
224f479974
Removed trailing spaces
2013-11-21 04:08:01 -08:00
e4b22d0fca
Replace all tabs, particularly the ones in the comments
2013-11-21 03:39:58 -08:00
8c6840e489
Modified GetExternalVirtSwitch to take the switchname param and return the same or default one
2013-11-21 14:36:47 +05:30
4f1821bf3a
Add support of attaching nic's to the specified network labels in HyperV
2013-11-21 11:55:17 +05:30
273c912bb6
CLOUDSTACK-1868. GetVmStatsCommand throws NullPointerException with VMWare.
2013-11-21 09:39:44 +05:30
2d42b2d1ab
Add logs in case ipassoccmd failed
2013-11-20 15:07:02 -08:00
1edaa36cc6
CLOUDSTACK-1302: Allow a cache mode per disk offering
...
Per disk offering the setting none, writeback or writethrough can be set
This allows for both safety and performance for writes.
2013-11-20 17:11:10 +01:00
8d62744681
Reformat all source code. Added checkstyle to check the source code
2013-11-20 07:26:53 -08:00
90fb76a72c
CLOUDSTACK-5069. Added global config 'vmware.vcenter.session.timeout' to make the vCenter session timeout value configurable.
2013-11-20 16:12:22 +05:30
9c739ef93d
Revert "Revert "XS host free memory might change, if user manually changes dom0 memory,""
...
This reverts commit 74153e4a79
2013-11-14 11:58:55 -08:00
74153e4a79
Revert "XS host free memory might change, if user manually changes dom0 memory,"
...
This reverts commit a1d09ae16f
2013-11-13 15:38:42 -08:00
a1d09ae16f
XS host free memory might change, if user manually changes dom0 memory,
...
this patch makes CS update latest XS host free memory on host connect process.
2013-11-13 10:59:36 -08:00
fc9adec72e
CLOUDSTACK-669: Add host level side-by-side VM state report for graceful sync model migration
2013-11-12 18:32:51 -08:00
951336c3e4
CLOUDSTACK-5124: Adopt GetDomRVersionAnswer to VR upgradability
...
While VRs upgrade, cloudstack should still be able to work with older
/newer version of the scripts within VRs. To allow this, the simulator
needs to send the version strings for the domr version response or the
VR start is interrupted.
Signed-off-by: Prasanna Santhanam <tsp@apache.org>
2013-11-11 13:49:55 +05:30
a35425eec6
CLOUDSTACK-5122. System VMs are getting recreated with old template after upgrading to 4.2.
...
In VMware during VM start the existing disk information is used to configure the VMs. So even if a new disk is created using the new template VM continues to use the old disk.
Once the old root disk is marked for destroy force expunge it and sync the new disk into the VM folder before VM start
2013-11-10 23:31:56 +05:30
b2f06aae68
fix long cast to double
...
- the result of dividing long with long resulted in loss of precision both for network and IO
- unit tests included
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2013-11-09 09:04:05 +01:00
4815b024bf
Add quiesce vm for vmware during vm snapshot
2013-11-08 15:47:11 -08:00
4674ae4dd3
CLOUDSTACK-5076: fix wrong bridge name in vm domain xml desc after upgrade from 4.0 or before to 4.2
...
(cherry picked from commit 86976fb298
2013-11-08 15:40:14 +01:00
39c201a593
Changes in hyperv agent to handle an add shared (SMB) storage pool
...
command. ModifyStoragePoolCommand was updated to map (net use) the share
and give an answer with the capacity details of the pool.
2013-11-08 16:34:38 +05:30
c2fc6e69b5
check Linux bridge status before remove it (Cherry-picked from commit a33f0e7bdd)
2013-11-08 09:00:12 +01:00
63b23bb341
Fixed VmSync issues in HyperV.
2013-11-08 13:14:52 +05:30
f826dfb918
Fixed bug with deleting VMWare VM Snapshots
...
Signed-off-by: Edison Su <sudison@gmail.com>
2013-11-07 14:29:35 -08:00
d0123f9594
Added option to reload VM during in RevertToVMSnapshotCommand (only in VMWare as I don't believe that XenServer supports anything similar)
...
Signed-off-by: Edison Su <sudison@gmail.com>
2013-11-07 14:23:36 -08:00
b864e677e5
CLOUDSTACK-5039 bugfix: live migration failure in KVM env.
...
Signed-off-by: ynojima <mail@ynojima.net>
2013-11-07 20:56:23 +05:30
ad0d7f882f
Fix CID 1127045 Dead local store
...
Fix CID 1127041,1127040, 1127039, 1127038, 1127037 String concatenation in loop
2013-11-07 14:40:14 +01:00
494ccd821d
Bugfix: VR has double NICs connected to Public network
...
replace vlanid wih broadcast uri to support vxlan to identify whether id is VLAN ID or VNI
Signed-off-by: ynojima <mail@ynojima.net>
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2013-11-07 11:17:59 +01:00
e77ab38543
Fixing the implementation for AttachCommand and DetachCommand in hyperv agent.
...
Also implemented RebootCommand for rebooting an instance on hyperv host.
2013-11-07 13:13:39 +05:30
7095ea2b5e
CLOUDSTACK-4738 Dynamic compute offering.
...
Signed-off-by: Koushik Das <koushik@apache.org>
2013-11-07 12:41:20 +05:30
f03dcdab19
[CLOUDSTACK-5051] Revert "CLOUDSTACK-3715. Socket timeout error is observed in VMware setup if a VMware task (RelocateVM_Task, CloneVM_Task etc.) takes more than 10 minutes. Making this value configurable to allow admins to modify the timeout if required. It defaults to the current value i.e. 10 minutes."
...
This reverts commit 3a91500173
2013-11-06 19:07:33 +05:30
88170f9a79
CLOUDSTACK-4736 Monitoring service kvm vmware resource changes
2013-11-06 18:37:43 +05:30
2613c0a821
git config files were missing the ASF license
2013-11-05 15:40:45 -08:00
b464a20a52
CLOUDSTACK-4736: Monitoring services in VR
2013-11-05 23:39:33 +05:30
0ef6135198
CLOUDSTACK-3715. Fix import error.
2013-11-05 17:42:17 +05:30
a286dec098
CLOUDSTACK-4908: CPU socket count of host Adding cpu socket count of the host in hostresponse
...
Signed-off-by: Koushik Das <koushik@apache.org>
2013-11-05 16:12:36 +05:30
3a91500173
CLOUDSTACK-3715. Socket timeout error is observed in VMware setup if a VMware task (RelocateVM_Task, CloneVM_Task etc.) takes more than 10 minutes. Making this value configurable to allow admins to modify the timeout if required. It defaults to the current value i.e. 10 minutes.
2013-11-05 15:59:03 +05:30
e60037cb80
Remove primarydatastoreTo in vmwareresource
2013-11-04 14:37:24 -08:00
a196fbc836
Application context files so that hyperv guru and discoverer can be loaded. Also made changes
...
to hyperv pom.xml to make sure the resources are picked up at build time.
2013-11-04 18:48:54 +05:30
d14592fe93
Make sure only unit tests are run during build time and not functional tests.
...
Fixing rebase issues after integrating with wmi v2 implementation.
Removing the executable attribute from some files.
Remove the unused wmi v1 interface file.
Unit test for DestroyCommand implementation in hyperv agent.
Fixed VM state changes w.r.t wmi version 2 changes
If a VM is already running, deploy virtual machine shouldn't fail and throw an exception.
Don't run vhd-util on templates which are present on CIFS. Hyperv uses cifs as secondary storage
Add a SCSI controller by default. This is needed so that data volumes can be added/removed
on a running vm.
Remove the hard coded path in the agent code.
Rat fixes for hyper agent. Added the missing headers in files where it was missing.
2013-11-04 18:48:54 +05:30
1601498bd7
Changes for switching all wmi calls to V2 namespace. V1 namespace is deprecated so it is better
...
to be on v2 namespace.
2013-11-04 18:48:54 +05:30
36b8b357e6
Changes to attach the system vm iso when booting the virtual router - part 1.
...
Copy the iso to the secondary storage and let the hypervisor agent know of its
location during setup. The agent will copy it over once it handles the setup
command.
Changes for attaching the systemvm iso to virtual router will booting it -
part 2. The agent copies over the systemvm iso during setup. When a
virtual router is being booted it attaches the iso to it.
Hyperv unit tests for the agent. Unit tests are written using NSubstitute and XUnit and
they test the create, stop and start commands in the agent.
Fix to make sure the hyperv agent and the funcitonal tests are working after the unit tests update.
Fixing the warnings while running unit tests for hyper agent.
Added a new switch for functional tests.
Update the unit test to create a fake vhd file on the fly and run the test. The file is removed when the test completes.
Fix for functional tests. The test was failing to build on java 1.6.
Fix to bring up SSVM and Console Proxy systemvms
Fix to discover the seeded template to bring up the systemvm's for the first startup and fixed UNC path isues
Fixed the UNC path for copying the files from CIFS, and from seeded template
Fixed the issues for ssvm and cpvm to wait until it gets configured and then return the status. Made checksum method to return true.
Fixed HypervDirectConnect resource to figure out the status of systemvms, Need to fix this issue by connecting to public/control ip instead of local ip
checksum is failing for the copied system vm images, currently bypassing.
2013-11-04 18:48:54 +05:30
989c6e6914
Modified cloud-early-config to configure, when the VR boots up in HyperV Environment
...
Implemented commands that are required for VR to bootup and Vm deployment to work
Modified hyperv agent code, to deploy VR with Boot Args, boot args passed to VR using KVP Exchange Component.
Fix for VR to boot up and get configured with boot args, Fixed issue in VolumeOrchestrator
Implemented SetFirewallRulesCommand in HyperV Resource
Implemented VR network commands to provide the necessary services from VR
Fixed hyperv localstorage path encode url issue. encode is converting space to '+'
2013-11-04 18:48:53 +05:30
f9f196a46a
A plugin for Hyper-V control is available for CloudStack. The plugin implements basic VM control; however, its
...
architecture allows additional functionality to be easily added. Incorporating the plugin in CloudStack will allow
the community to participate in improving the features available with Hyper-V. The plugin uses a Director Connect
Agent architecture described here: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Progress
Add ability to pass kvp data via the key cloudstack-vm-userdata
Rearrange code to make it clearer what .NET objects are being used.
Test failures are easier to deal with if test key is not deleted.
Acquire management/pod ip for control ip when VR deploys in HyperV
Fixed deletion on VM's on hyperv host when mgmt server gets restarted due to HA
Implementation for attach iso command. Attaches an iso to a given vm.
2013-11-04 18:48:53 +05:30
6eecb0b3b5
CLOUDSTACK-5017: If SSVM is unavailable DownloadCommands will be routed
...
to mgmt server.
2013-11-01 18:07:00 -07:00
c2e2f6ce63
relax KVM agent setup to allow non-bridge traffic labels
...
(guest bridges are created on physical device, no need for bridge traffic label)
2013-11-01 18:16:54 -06:00
7c99b88926
Don't use cast to PrimarydataStoreTO on the resource code
2013-11-01 15:13:16 -07:00
6b5fab2f5c
OpenContrail network plugin
...
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2013-11-01 17:46:52 +01:00
47641637f6
Summary: LibvirtStorageAdaptor.getPhysicalDisk() to recogize .raw extension
...
Detail: getPhysicalDisk() was not matching on volumes with .raw, so
instead setting disk format to QCOW2.
BUG-ID: CLOUDSTACK-5018
Bugfix-for:
Reviewed-by:
Reported-by:
Signed-off-by: John Kinsella <jlk@stratosec.co> 1383287538 -0700
2013-10-31 23:32:18 -07:00
Edison Su
Marcus Sorensen
Likitha Shetty
Devdeep Singh
Min Chen
Alex Huang
Donal Lafferty
Bharat Kumar
Anthony Xu
tuna
Wido den Hollander
Anshul Gangwar
Rajesh Battala
Nitin Mehta
Alena Prokharchyk
Wei Zhou
Hugo Trippaers
Kelven Yang
Prasanna Santhanam
Laszlo Hornyak
Chris Suich
ynojima
Jayapal
Harikrishna Patnala
Pedro Marques
John Kinsella