9bb920af65
Fix findbugs warning in VmwareStorageManagerImpl.java Any encoding would do fine as it's just used to generate a UUID. Sticking with UTF-8 for consistency
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #461
2015-06-16 08:53:56 +02:00
3d48af41a8
Fix findbugs encoding issue in VmwareResource.java Key file should be UTF-8 encoded in VR
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #462
2015-06-16 08:51:54 +02:00
85ad1b7e0f
Fix 3 findbugs encoding warnings in VmwareStorageProcessor.java Ova templates and metadata should be written to file in UTF-8 Fix warning in UUID generation
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #411
2015-06-15 12:09:13 +03:00
967da97f51
Fix 2 findbugs warnings in VmwareStorageManagerImpl.java Template files and metadata should be written to file in UTF-8
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #410
2015-06-15 12:06:19 +03:00
11fec86ba3
Fix 1 findbugs warning in VmwareResource.java
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #409
2015-06-15 12:06:11 +03:00
474065e98b
Fix findbugs encoding warning in VmwareServerDiscoverer.java Input string should only contain safe characters, since it's derived from a Long object. This just gets rid of the findbugs warning
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #408
2015-06-15 12:06:01 +03:00
5e41a830a5
This closes #373
...
CLOUDSTACK-3317 - DVS does not support management\storage network
Added support for Management and Storage Network traffic over VMware DVS in CloudStack deployments. Also added support for storage VLAN over dvPortGroup.
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
CLOUDSTACK-3317 - DVS does not support management\storage network
Use non-zero dvport count while updating dvportgroups of system traffic.
Updated configuration compare logic to avoid update dvportgroup operation unless required.
This would help improve speed in vm/network deployment as the update calls would reduce. Also improved logging.
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
Adding unit tests in class HypervisorHostHelperTest
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
Added license header to new file being added to repo/branch.
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2015-06-10 02:07:40 +05:30
b272d7717e
Revert "Fix 2 findbugs high priority warnings"
...
This reverts commit 1ca74dac26
2015-06-08 10:01:19 +02:00
e8c7069f73
Fix findbugs high priority warning VmwareStorageManagerImpl.java:1023, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE, Priority: High Redundant nullcheck of datastoreVolumePath, which is known to be non-null in com.cloud.hypervisor.vmware.manager.VmwareStorageManagerImpl.getVolumePathInDatastore(DatastoreMO, String)
...
Assertion is not used in runtime, correct way is throw and handle exception without killing app
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #362
2015-06-08 09:40:50 +02:00
38c269d71e
Fix performance issue reported by findbugs (unnescessary boxing/unboxing) VmwareResource.java:693, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High VmwareResource.java:4769, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High Boxing/unboxing to parse a primitive com.cloud.hypervisor.vmware.resource.VmwareResource.getNetworkStats(String)
...
Now op is faster and takes up less memory
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #365
2015-06-08 09:32:52 +02:00
1ca74dac26
Fix 2 findbugs high priority warnings
...
VmwareResource.java:315, MS_SHOULD_BE_FINAL, Priority: High
com.cloud.hypervisor.vmware.resource.VmwareResource.s_serviceContext isn't final but should be
VmwareResource.java:331, MS_SHOULD_BE_FINAL, Priority: High
com.cloud.hypervisor.vmware.resource.VmwareResource.s_powerStatesTable isn't final but should be
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #363
2015-06-08 09:24:07 +02:00
04365601da
CLOUDSTACK-8412. VM migration with storage fails.
...
Update MigrateWithStorageCommand to avoid JSON deserialization error.
2015-04-28 10:22:00 +05:30
f45e6b94ed
CLOUDSTACK-8405: Restore VM results in deletion of data disk.
...
Dont evict template when a delete command has been sent to VMware resource for deletion of volume.
2015-04-27 16:37:46 +05:30
06e353e5c7
vmware: support vmfs as local storage pool type
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit 752d784d92
2015-04-16 17:36:52 +05:30
7949d2922d
vmware: plugin improvements
...
- use sticky chmod 1777 on the mountpoint
- remove dead code
(cherry picked from commit eea716b791
2015-04-13 15:49:01 +05:30
37820e15f2
CLOUDSTACK-7593: allow nic type to be fetched from vm's details
...
(cherry picked from commit 43db75c319
2015-04-13 15:47:03 +05:30
6a821730ce
Boolean -> boolean
2015-03-25 22:20:40 +01:00
048212b117
findbugs: Boolen function should not return null
2015-03-25 21:46:47 +01:00
3d411dc616
Fixed simulator and vmware NPE issue.
2015-03-13 14:59:34 +05:30
bdd28a45ed
CLOUDSTACK-8319. For both 'MigrateVolume' and 'MigrateVMWithVolumes, ensure VM's vconfiguration files are migrated along with VM's root volume.
2015-03-12 11:57:02 +05:30
adc836cc5e
CLOUDSTACK-8318. Storage vMotion support for VMFS.
...
MigrateVMWithVolumes-
1. If ESXi host version is below 5.1, ensure destination datastore(s) is mounted on the source host, then migrate the storage and then finally migrate the VM.
If destination storage(s) is not mounted on the source host,
- In case of NFS storage mount the storage(s).
- In case of VMFS storage fail the request for migration.
2. If EXi host version is 5.1 or above, simultaneously migrate the VM and its storage to the destination host and storage(s) respectively for both NFS and VMFS storage.
2015-03-12 11:57:01 +05:30
ff7ef985f1
NFS support for VMware-managed storage
...
Signed-off-by: Mike Tutkowski <mike.tutkowski@solidfire.com>
2015-03-05 17:39:10 -07:00
25a4f0dc53
CLOUDSTACK-8136. [VMware] Create VM snapshot fails if a previous attempt to take the snapshot failed.
...
While looking for an ongoing VM snapshot task, check the task status to identify if the task is still running.
2014-12-30 14:19:48 +05:30
13bdc1cef4
CLOUDSTACK-8134. Worker VMs don't have MS id set in vCenter annotation 'cloud.vm.workertag'.
...
Correctly register node info for a newly created VMware context.
2014-12-30 11:52:56 +05:30
15b348632d
CLOUDSTACK-8129. Cold migration of VM across VMware DCs leaves the VM behind in the source host.
...
If VM has been cold migrated across different VMware DCs, then unregister the VM from source host.
2014-12-26 11:07:30 +05:30
5227ae2275
CLOUDSTACK-8128. VM with Datadisk fails to start when storage is put into maintenance.
...
While migrating a volume from primary to seocndary use a worker VM to perform the operations if the VM associated with the volume is stopped.
2014-12-24 16:57:37 +05:30
974b0180dd
CLOUDSTACK-8126. Cold Migration of VM is not working as expected. In case a VM is cold migrated across clusters then VM fails to start.
...
1. If a VM by the same name exists on a different cluster in the VMware DC, unregister the existing VM and continue with the VM start.
2. If VM start succeeds, delete VM files associated with the unregistered VM.
3. If VM start fails, re-register the unregistered VM.
2014-12-24 15:07:08 +05:30
1c0bf32170
CLOUDSTACK-8123. VM re-install fails.
...
While moving root disk into VM folder during restore, look for folder based on vCenter name.
2014-12-24 14:01:20 +05:30
ac491c9607
CLOUDSTACK-8121. Data disk properties are not updated upon Creation/Deletion of VM snapshots.
...
Update the path and size of data volumes after snapshot creation/deletion by correctly trimming only the snapshot postfix of a disk.
2014-12-24 13:04:12 +05:30
4d7ede535d
CLOUDSTACK-8119. Propagate error message to UI for attach/detach volume failure operations.
...
For AttachVolume/DetachVolume API command, improve user error message in case of RuntimeException by throwing the exception instead of 'Unexpected Exception'.
2014-12-24 11:29:03 +05:30
ddcae8a930
CLOUDSTACK-8118. Root volume migration fails with 'No such disk device' in case of vCenter 5.5 setup.
...
If an exact match is being done while locating disk chain by name, don't trim snapshot postfix appended to the disk name.
2014-12-24 10:19:22 +05:30
cb211f18d1
CLOUDSTACK-8113. VM migration fails with "Message: No such disk device: " error.
...
Consolidate VM disks once VM/volumes are migrated.
2014-12-23 14:28:17 +05:30
33179cce56
CLOUDSTACK-8112. CS allows creation of VM's with the same Display name when vm.instancename.flag is set to true.
...
Before registering a VM check if a different CS VM with same name exists in vCenter.
2014-12-23 13:48:01 +05:30
647532376f
CLOUDSTACK-8111. NFS secondary storage repetitively mounted on CS server with ESXi hypervisors.
...
Fix cleanup of NFS mounts on management server during server starup by correcting how mount points are listed for a management server.
2014-12-23 13:23:43 +05:30
51ee90074d
CLOUDSTACK-8110. VM name in vCenter should be VM's DisplayName if global config 'vm.instancename.flag' is set.
2014-12-23 11:42:26 +05:30
507d9d337d
CLOUDSTACK-8109. Extract Template is failing.
...
Fix the OVA path that is returned once an OVA is packaged using a META file.
2014-12-23 10:44:10 +05:30
1df0453d27
CLOUDSTACK-8088: VM scale up is failing in vmware with Unable to execute ScaleVmCommand due to java.lang.NullPointerException
2014-12-18 14:27:55 +05:30
aa84b05491
CLOUDSTACK-5933 Problem with VMware snapshot when datastore has a space in its name
...
Handling spaces in datastore name while extracting vmdk base name
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2014-12-09 05:34:41 +05:30
bca015306e
CLOUDSTACK-7803 Storage live migration of instance may not happen if instance has ISO attached.
...
BUG-ID:CLOUDSTACK-7803
Summary:Ensure secondary storage is mounted on target host.
Reviewed-By:Rajesh
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2014-12-09 03:27:31 +05:30
3ac8f8d601
Fixing an issue related to figuring out the name of a datastore that is backed by managed storage
2014-12-08 14:26:31 -07:00
9585aa0b51
CLOUDSTACK-6465: vmware.reserve.mem is missing from cluster level settings
...
Signed-off-by: Rajani Karuturi <rajanikaruturi@gmail.com>
(cherry picked from commit eae733817b
2014-11-25 15:55:54 +05:30
3577423da9
removed executable flags from java classes
...
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-11-23 19:49:01 +01:00
4ff3130bec
CLOUDSTACK-7950: AttachIsoCmd shoud give correct messge when trying to attach vmwaretools installer iso on non supported guestvm deployed by ISO
2014-11-20 13:04:14 +05:30
ef6ec7b276
Fixed few coverity issues like invalid boxing unboxing issues, resource leaks, null dereferences
2014-11-13 17:26:24 +05:30
b8fdda0a34
BUG-ID: CLOUDSTACK-7102. Volume migration fails with 'VM i-2-3-VM does not exist in VMware datacenter' expection.
...
Look for a VM in vCenter based on both the vCenter name and CS internal name (required in case 'vm.instancename.flag' is enabled).
During Attach Volume and Volume Migration, for lookup and other operations use VM's name as obtained from vCenter instead of using the name set in the agent command.
2014-11-13 12:58:56 +05:30
ea99ff1c86
CLOUDSTACK-7763 Reservations for VMware VMs remain after dynamic scaling
2014-11-10 14:30:42 +05:30
1aef5cba66
Fixed Coverity Issues
2014-11-03 16:45:30 +05:30
efc9632c1b
CLOUDSTACK:6915 search including removed
2014-10-31 15:47:18 -07:00
0cea0346ae
Support for back-end snapshots on primary storage
2014-10-21 16:01:14 -06:00
0a9742f914
Fixed few coverity issues
...
Signed-off-by: Santhosh Edukulla <santhosh.edukulla@gmail.com>
2014-10-14 17:16:50 +05:30
49c01e2ae4
Don't do chmod -R when mounting secondary storage for vmware
...
It causes extreme long vm start time when managment server has slow connection to secondary storage
2014-10-13 12:06:37 -07:00
d233f39c82
disable parallel for xenserver. Also for vmware, if full.clone is enabled and migratecommand will have the behavor of start/stop command
2014-10-09 17:14:57 -07:00
6a5e4306f2
fix build
2014-10-09 16:38:23 -07:00
15a2ea7c7e
vmware resource code needs to honor the timeout value send
2014-10-09 16:28:20 -07:00
9e7fbae52f
Revert "CLOUDSTACK-7533: Wrong download URL is generated when using multiple SSVMs in a zone. The public ip of the url would sometime point to the wrong ssvm when the url was created on another one."
...
This reverts commit f3b5a6ebc7
2014-10-06 15:00:32 -07:00
65ed25b7a6
BUG-ID: CLOUDSTACK-7662. Resize of detached volume fails.
...
Support offline volume resize on ESX by creating a worker VM to attach the unattached volume to and then resize it.
2014-10-01 15:41:50 +05:30
f1e3e83bbf
BUG-ID: CLOUDSTACK-7653. VM's are not getting deleted from hypervisor after deleting from UI when using zone wide primary storage.
...
While expunging a volume, CS chooses the endpoint to perform delete operation by selecting any host that has the storage containing the volume mounted on it.
Instead, if the volume to be deleted is attached to a VM, the endpoint chosen by CCP should be the host that contains the VM.
2014-09-30 15:20:15 +05:30
6b06970366
BUG-ID: CLOUDSTACK-7652. [VMware] 'SOAPFaultException: The object has already been deleted or has not been completely created' exceptions.
...
If CCP thread local context which is used to handle connections to a vCenter is being re-used, validate that the context corresponds to the right vCenter API session.
2014-09-30 15:20:14 +05:30
18e5aa116e
Fixing an issue around VMware system templates
2014-09-18 19:38:59 -06:00
f3b5a6ebc7
CLOUDSTACK-7533: Wrong download URL is generated when using multiple SSVMs in a zone. The public ip of the url would sometime point to the wrong ssvm when the url was created on another one.
...
Fix the bug by removing the command CreateEntityDownloadURLCommand from the host delegation. This results in same ssvm for creating the symlink on ssvm and same public ip being used for generating the url on MS.
2014-09-10 17:46:33 -07:00
7dbff9b42c
CLOUDSTACK-7371. [VMware] Enabling primary storage maintenance fails when storages are across cluster.
...
1. While destroying a ROOT volume do the lookup of the associated VM under the DC and not just cluster.
2. In case of VMware, during VM start if a volume is being recreated no need to detach the old volume because
we now expunge it immediately and don't wait for the storage cleanup task to run.
2014-08-20 10:51:18 +05:30
8bb4022f37
CLOUDSTACK-4587. System VMs fail to start when the primary storage that has the System VMs is put into maintenance.
...
During VM start while configuring its disk devices, obtain the matching disk for a volume in storage
using both the volume's path and volume's datastore information.
2014-08-20 10:51:18 +05:30
a1d0925f90
CLOUDSTACK-7360 [vmware] Add host to existing cluster fails if the cluster is using Nexus 1000v as backend for atleast one traffic type.
...
While adding host to existing cluster which is using Nexus 1000v as a network backend, skip validation of Nexus VSM as it was already done while adding that cluster.
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2014-08-18 07:18:13 +05:30
6a4a11ed71
CLOUDSTACK-7334. [VMware] AddHost command fails if there is a space in the VMware DC/Cluster name.
...
URL decode vCenter path during cluster discovery.
2014-08-13 16:24:14 +05:30
d1d722f9bd
CLOUDSTACK-7295: VMs is Stopped state have no host ID, resulting in NPE
2014-08-11 14:56:58 -07:00
9866c648eb
CLOUDSTACK-7260: Management server not responding after some time for
...
Vmware due to Oom (cannot create native thread).
2014-08-05 17:36:53 -07:00
f803100813
CLOUDSTACK-6969. Data Volume Shrink operation failing with "Unexpected Exception".
...
For ResizeVolume API command -
1. If hypervisor resource throws an exception, handle the NPE thrown by the job framework.
2. Improve user error message in case of RuntimeException by throwing the exception instead of 'Unexpected Exception'.
2014-08-01 16:23:47 +05:30
96a6e673a3
CLOUDSTACK-7078 CLONE - [VMWARE]System VM's are failed to start with Nexus enabled Zone Since introducing pool of session contexts we no more have a dedicated context for each VMware hypervisor host. Hence vsm credentials stored in session context cannot be retrieved always correctly. Fix is to register the vsm credentials after fetching context and the context gets recycled after use.
...
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2014-07-31 16:31:41 +05:30
ecf100e4ed
fixed build for vmware
2014-07-28 17:37:31 -07:00
330c4ba578
completed the new vmsync TODOs in the code.
...
removed old vmsync logic
2014-07-28 12:51:37 -07:00
786285ab54
CLOUDSTACK-7174. [VMware] Recreating System VMs fails if global config 'vm.instancename' is set to true.
...
Append VM's name in vCenter with the hostname only for User VMs.
2014-07-24 13:05:45 +05:30
1d2124dcbf
Fix NPE reported on IRC, provide the user an informative error message
2014-07-22 17:45:24 +02:00
b3e4c6d6dc
CLOUDSTACK-7150. [VMware] Global config 'vm.instancename' is not honored.
...
If global config 'vm.instancename' is set to true, VM name in vCenter should be '<instance_name>-<vm_hostname>'.
2014-07-22 11:59:53 +05:30
03de9cc335
CLOUDSTACK-6845 : NuageVsp Network plugin
...
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-07-21 10:49:49 +02:00
3d8dd1c921
Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/cloudstack
2014-07-14 17:30:12 -07:00
62e63a1bf7
CLOUDSTACK-6358: Missing patches in master for VMware
2014-07-14 16:54:10 -07:00
5143fe404b
When instance.name.flag is set to true, append user-supplied name with legacy prefix to VM name appears in vCenter.
2014-07-14 14:53:51 -07:00
362f875a3f
Detach disks before cleaning up of VMware worker VM.
2014-07-08 14:47:22 -07:00
8cf94c9ec1
CLOUDSTACK-7069. [VMware] While setting 'numCoresPerSocket' property for a Virtual Machine in VMware
...
add a check to ensure the vSphere version is 5.0 or above.
2014-07-07 14:36:58 +05:30
4f969057b2
CLOUDSTACK-7030. After the restart of MS in a clustered MS pool, not all hung worker VMs are recycled.
...
Recycle worker VMs that originally belonged to other management servers too because in case of MS restart, the owner MS might change.
2014-07-07 13:38:47 +05:30
71f76edf71
CLOUDSTACK-6996 Adding cluster to legacy zone failed
...
Lookup zone_id field in legacy_zones table to search the table for legacy zone.
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2014-06-27 14:01:39 +05:30
f756d4aa33
Make job info universally available across management server and resource agents
2014-06-24 16:28:22 -07:00
42d00cae58
SolidFire (shared-access) Provider
2014-06-16 12:15:29 -06:00
99b4cf788e
Cloudstack-5077: reserve cpu and memory only when vmware.reserve.cpu/mem are set to true. Insted of setting the ovecommit values to one on upgrade, we popultate them from the global values.
...
Conflicts:
engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java
engine/schema/src/com/cloud/upgrade/dao/Upgrade420to421.java
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
2014-05-05 11:39:10 +05:30
8ac7784db2
CLOUDSTACK-6170 Corrected an issue related to the "Reinstall VM" command and managed storage with VMware
2014-05-02 18:41:59 -06:00
5bc72ea250
CLOUDSTACK-6317 [VMware] Tagged VLAN support broken for Management/Control/Storage traffic
...
Check if switch name detected from traffic label for management, storage, control traffic is null before falling back to default value.
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2014-05-02 18:25:29 +05:30
06bbcde458
Organized an algorithm a bit more
2014-04-25 11:57:54 -06:00
a7e267b416
CLOUDSTACK-6170 (VMware root-disk support for managed storage)
2014-04-24 15:03:05 -06:00
db9de2e39b
CLOUDSTACK-6488 Fixed an issue where the "path" field was not being set properly in the DB when the volume had a snapshot taken of it
2014-04-23 18:30:19 -06:00
523913a315
CLOUDSTACK-6469
2014-04-22 22:52:33 -06:00
1bb31412fc
CLOUDSTACK-6170 (VMware root-disk support for managed storage)
2014-04-21 22:22:50 -06:00
c0910cbdb9
CLOUDSTACK-6170 (VMware root-disk support for managed storage)
2014-04-19 10:41:42 -06:00
4620c27ebf
CLOUDSTACK-6047: Make aggregation command timeout configurable
...
In case some environments has different performance or we found some commands
would took too long to execute, one global configuration item is introduced to
specify "time out in seconds per one command in aggregation commands".
By default it's 3 seconds. If admin feel it's too long, it can be adjust to as
low as 1 seconds, which runs still well in my machine.
Conflicts:
setup/db/db/schema-430to440.sql
2014-04-18 23:36:19 -07:00
5e90b75c98
CLOUDSTACK-6402: Fix StopCommand so that VMs are not removed accidentally as part of vmsync
...
Added a new flag 'checkBeforeCleanup' to StopCommand based on which check is done to see if VM is running in HV host.
If VM is running then in this case it is not stopped and the operation bails out.
Also modified the MS code to call the StopCommand with appropriate value for the flag based on the context.
Currently it is only set to 'true' when called from the new vmsync logic based on powerstate of VM. For rest it
is set to 'false' meaning no change in behaviour.
2014-04-14 16:52:37 +05:30
06c0486d0b
CLOUDSTACK-6170 (VMware root-disk support for managed storage)
2014-04-01 00:09:53 -06:00
21455222e4
CLOUDSTACK-6170 (VMware root-disk support for managed storage)
2014-03-31 21:20:43 -06:00
1577e75a3d
CLOUDSTACK-6170 (VMware root-disk support for managed storage)
2014-03-31 00:13:30 -06:00
0879ab812e
CLOUDSTACK-6170 (VMware root-disk support for managed storage)
2014-03-28 13:15:04 -06:00
6de28bb1a4
in XenServer, host eject may fail due to diffent reasons, it's hard for CS to handle all failure.
...
in CS, removing a host means CS will not manage the host, admin needs to eject the host from XS pool outside of CS
2014-03-26 14:22:49 -07:00
1d3a6eaa50
CLOUDSTACK-6047: Fix timeout issue when try to execute aggregated commands
...
Add executeInVR() with timeout interface to VirtualRouterDeployer
AggregationControlCommand with Action.Finish may take longer than normal command
since it would execute all the commands in one execution, and it may result in
SSH timeout for SshHelper or other mechanism communicate with VR.
Introduce an new executeInVR() interface with added timeout period for waiting
FinishAggregationCommand to complete execution.
2014-03-18 17:43:59 -07:00
5a75a3e1f9
Give graceful state transition period to live with race-condition on VM startup time
2014-03-13 16:59:56 -07:00
6c23e201ad
1) More fixes for the problems found by findBugs
...
2) Corrected some logging in MidoNetPublicNetworkGuru - removed .toString method call on the objects in the log body as toString is called on the object by default when use log4j
2014-03-13 16:05:45 -07:00
466825a167
Fixed nonoss build
2014-03-10 15:29:18 -07:00
ab1d3af460
Use seperate path to sync VM metadata for XS
...
VM status sync only does VM status sync
2014-03-05 15:44:50 -08:00
b06e66c50a
CLOUDSTACK-6170
2014-03-05 13:55:12 -07:00
57a00a8172
Let ESX host timeout to reflect disconnect status in vCenter into CloudStack.
2014-02-28 15:35:59 -08:00
24e64ac62a
let PingTestCommand support host-ping in addition to ping user VM via VR. Reviewed-By: self
2014-02-28 15:35:59 -08:00
88b5761647
CLOUDSTACK-6146. [VMware] [ESXi 5.5] Live VM migration of an already migrated VM (with storage) across clusters fails
...
In vCenter 5.5, once a volume is migrated the VMDKs are renamed to match the name of the VM.
Update volume path for every volume belonging to the VM to the corresponding new disk filename.
Conflicts:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
plugins/hypervisors/vmware/src/org/apache/cloudstack/storage/motion/VmwareStorageMotionStrategy.java
2014-02-26 13:45:44 +05:30
0926bf57f4
CLOUDSTACK-6146. [VMware] [ESXi 5.5] Live storage migration of an already migrated volume fails
...
In vCenter 5.5, once a volume is migrated the VMDKs are renamed to match the name of the VM.
If a volume has been renamed upon migration update its volumePath to that of the new disk filename.
Conflicts:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java
2014-02-26 13:45:43 +05:30
b0c6d47347
- Updated APICommand annotation to add new flags that indicate if API request or response carry sensitive info - Updated all API classes with the new annotation flag values as per the API's sensitivity - Updated server code to check response annotation before audit logging
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
(cherry picked from commit df270d6387c362b960064ee5123c14782e767a19)
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-02-25 22:59:10 +01:00
5332f67ae8
CLOUDSTACK-6047: Make sure every commands to VR resource is NetworkElementCommand
2014-02-19 19:46:49 -08:00
c969aa2595
CLOUDSTACK-6134:
...
If volume already exists for the vm - register the vm in the inventory and start it.
2014-02-18 18:24:33 -08:00
d4d49578dc
Findbugs : Fix a number of potential NPEs and minor findings
2014-02-14 18:37:45 +01:00
db91e54bf3
CLOUDSTACK-6112. Adding VPC router to a guest network fails with StringIndexOutOfBoundsException.
2014-02-14 17:01:27 +05:30
7064972997
Fix someone's broken push due to bad checkstyle (VMwareGuru.java unused imports)
2014-02-12 16:26:33 -07:00
9f597ef130
CLOUDSTACK-6056. Enabling static NAT rule for a portable public IP fails with error "Failed to enable static nat".
...
router.extra.public.nics isn't being honoured and so when an ip that is acquired from the additional VLAN range
is being configured it failed.
2014-02-12 15:53:45 +05:30
7f34282dfa
Removed references to secondarystoragevmmanager from code that doesn't use it.
2014-02-05 01:39:15 +00:00
929099518d
Fix trailing whitespace.
2014-02-04 15:42:39 -08:00
39efee285f
CLOUDSTACK-6027:CreateVolume from snapshot is failing with S3 on Vmware.
2014-02-04 15:08:28 -08:00
9b21da65d1
CLOUDSTACK-6025:CreateTemplate from snapshot in NFS is failing , after
...
migarting to S3 datastore.
2014-02-04 11:01:51 -08:00
30695d7f93
CLOUDSTACK-6019:CreateVolume from snapshot in NFS is throwing Warning
...
"sync snapshot from cache to region wide store failed for image store
test".
2014-02-03 16:41:04 -08:00
06f79a881c
CLOUDSTACK-5994. Hitting IndexOutOfBoundsException in GetVmStatsCommand after upgrade.
...
To obtain network read/write statistics, multiply sample duration with the
average of the particular performance metric obtained over the sample period.
2014-01-30 18:31:38 +05:30
3bd38eb17e
Findbugs finding : Incorrect use of equality
2014-01-28 08:58:28 +00:00
4583bac05b
CLOUDSTACK-5796. [VMware] Size column is not getting updated in snapshot_store_ref table when a snapshot is backed up in secondary storage.
...
Calculate and update the size of a backed up snapshot. This snapshot size is in turn used to update the secondary_storage count for an account.
2014-01-28 09:21:05 +05:30
3c955c3659
CLOUDSTACK-5779: Make VmwareResource use VirtualRoutingResource
2014-01-24 19:57:52 -08:00
2d3022594c
CLOUDSTACK-5779: Generalize calling to execute or create file for Vmware
2014-01-24 18:28:00 -08:00
2d100f1269
CLOUDSTACK-5779: Generalize calling to execute or create file for Xen
2014-01-24 18:27:55 -08:00
5e0d61bf98
Findbugs finding: Fix object comparison with == instead of equals
2014-01-23 15:53:26 +00:00
532bf4b190
Get rid of compiler warnings and dead code in plugin-hypervisor-vmware
2014-01-22 09:55:38 +01:00
1767ddac77
CLOUDSTACK-5779: Update vmdata command in Vmware
...
To use Gson rather than copy a file to it, follow the same as Xen and KVM.
2014-01-21 18:59:30 -08:00
d4e069ecc8
Fix noredist build issue
...
Introduced by:
commit ac65f8fddf
2014-01-21 11:31:40 -08:00
e88cc488e5
CLOUDSTACK-5779: Move loadbalancer to use routerProxy
2014-01-20 18:48:46 -08:00
ac65f8fddf
CLOUDSTACK-5884 make getTargetSwitch(NicTO nicTo) do all the work to select switch name, type and vlan token. Change preference to use the tags set on the physical network.
...
Conflicts:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
2014-01-20 18:09:01 +01:00
37332ad9d4
CLOUDSTACK-5873: [Automation] Failed to attach volume to VM, if the vm is created with option startvm=false
2014-01-18 18:07:10 -07:00
0ea1c7dfc4
CLOUDSTACK-5779: Move firewall to use routerProxy
2014-01-17 12:36:42 -08:00
ce67e24d0a
CLOUDSTACK-5779: Move ipAlias to use routerProxy
2014-01-17 12:36:42 -08:00
008b029a29
CLOUDSTACK-5891.[VMware] If a template has been registered and "cpu.corespersocket=X" template details have been added for it,
...
then any instance deployed from that template should have X cores per socket
2014-01-17 11:00:48 +05:30
0cdf0f6f67
CLOUDSTACK-5779: Moving bumpUpPriority, edithosts.sh, dnsmasq.sh to use routeProxy
2014-01-16 16:03:09 -08:00
a957d52a3c
CLOUDSTACK-5707. Hitting multiple 'User unauthenticated' exceptions when vCenter is upgraded to 5.5 from 5.1.
...
We hit these excptions whenever a management server held session that was with the old 5.1 vCenter server
is used to make resource calls to the new 5.5 vCenter.
Validate a vCenter session context before it is being used to make a resource call.
And if the context is invalid then discard the context and retrieve a new one.
During the invalidation of an old context handle the context disconnect better
by catching the appropriate exception and returning a newly created context.
Conflicts:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareContextFactory.java
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareSecondaryStorageResourceHandler.java
vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareContext.java
2014-01-14 09:38:50 +05:30
a354d969ce
Merge from 4.3: CLOUDSTACK-5823: Taking a VMware snapshot doesn't work
2014-01-09 23:10:40 -07:00
ae35782ccd
Merge from 4.3: CLOUDSTACK-5662: XenServer can't discover iSCSI targets with different credentials
2014-01-09 21:36:34 -07:00
64b8d1044d
CLOUDSTACK-5819:extractTemplate fails with Vmware host on migration of
...
NFS to S3.
2014-01-09 15:08:23 -08:00
8b6e89c012
Merge from 4.3: CLOUDSTACK-4810: Enable hypervisor snapshots for CloudStack-managed storage (for XenServer and VMware)
2014-01-09 15:44:02 -07:00
bc677e2a99
CLOUDSTACK-5782. [VMware] Snapshot creation on a detached volume failes with NPE.
...
For a detached volume, don't try to find the associated VM on the hypervisor/peer hypervisor host.
By default create a worker VM to perform snapshot operations.
Conflicts:
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
2014-01-06 14:34:15 +05:30
50c2119a84
CLOUDSTACK-5704. OVA files exist for templates created from volumes.
...
Don't package the OVF and VMDK files into OVA after a template is created from volume.
Since packaging process contains reading and writing from the NFS mount, it doubles the amount of data that needs to be moved around
Conflicts:
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
2014-01-02 16:39:07 +05:30
68e0bf39d0
Fix check style error.
2013-12-31 07:04:17 +05:30
6ba9754201
CLOUDSTACK-5447 [Automation] Volume migration failing with NullPointerException in vmware and KVM.
...
Instead of injecting object of VolumeOrchestrationService into VmwareResource, we now populate the command object (MigrateVolumeCommand here) with required information. Thus we dont need volume orchestration service to query that information from resource.
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-12-31 06:31:43 +05:30
9ca34f14a2
CLOUDSTACK-5666 Cant remove a nic when a vm is in the Stopped state
...
When VM is not running, existing code is unable to retrieve associated cluster's Id. Now we will try to get this information using previous host where the VM was running.
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
Conflicts:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java
2013-12-28 09:13:58 +05:30
db99146187
CLOUDSTACK-5661 [VMware] DetachIsoCmd succeeds even though cdrom is locked by VM as cdrom is mounted
...
DetachISO is succeeding even though detach opeartion is failing as cdrom is locked by VM as it was mounted inside VM.
Detect if cdrom is locked or not. If locked fail detach operation and warn user to unmount before detaching the iso/cdrom device.
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
Conflicts:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java
2013-12-28 02:36:53 +05:30
95364a4022
CLOUDSTACK-5531
...
Initial support for vhd, raw, vmdk image formats on KVM. Tested all formats with local and CLVM.
2013-12-16 14:32:51 -07:00
fa2f18d2a2
CLOUDSTACK-4875. Vmware vCenter 5.5 - System VM deployment fails During VM deployment.
...
When base template is being cloned to create VM ROOT disk, get the disk path i.e. base file name
of the VM's ROOT disk from vCenter
2013-12-17 18:31:15 +05:30
be5e5cc641
All Checkstyle problems corrected
2013-12-12 12:26:07 -08:00
36cbc2dfbf
CLOUDSTACK-4498 we should not reserve memory and cpu for vmware VMs if the
...
vmware.reserve.cpu and vmware.reserve.mem are set to false while not overcommiting
Signed-off-by: Jayapal <jayapal@apache.org>
2013-12-11 13:07:56 +05:30
e6127a7c00
CLOUDSTACK-5216. delete volume failed due to Exception: java.lang.Exception" while destroying Vms
2013-12-06 12:04:02 +05:30
bd6f706b72
CLOUDSTACK-5261: added support for Alert publishing via ROOT Admin API
...
Conflicts:
engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
engine/storage/image/src/org/apache/cloudstack/storage/image/TemplateServiceImpl.java
engine/storage/volume/src/org/apache/cloudstack/storage/datastore/provider/DefaultHostListener.java
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/discoverer/HypervServerDiscoverer.java
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java
server/src/com/cloud/alert/AlertManagerImpl.java
server/src/com/cloud/alert/ConsoleProxyAlertAdapter.java
server/src/com/cloud/alert/SecondaryStorageVmAlertAdapter.java
server/src/com/cloud/configuration/ConfigurationManagerImpl.java
server/src/com/cloud/ha/HighAvailabilityManagerExtImpl.java
server/src/com/cloud/ha/HighAvailabilityManagerImpl.java
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
server/src/com/cloud/resourcelimit/ResourceLimitManagerImpl.java
server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java
server/src/com/cloud/vm/UserVmManagerImpl.java
usage/src/com/cloud/usage/UsageAlertManagerImpl.java
usage/src/com/cloud/usage/UsageManagerImpl.java
listAlerts: introduced new parameter "name" to the alertResponse
Conflicts:
api/src/org/apache/cloudstack/api/command/admin/resource/ListAlertsCmd.java
server/src/com/cloud/alert/AlertManagerImpl.java
usage/src/com/cloud/usage/UsageAlertManagerImpl.java
Added new Admin API - generateAlert. Available to ROOT admin only
Conflicts:
api/src/org/apache/cloudstack/alert/AlertService.java
api/src/org/apache/cloudstack/api/BaseCmd.java
usage/src/com/cloud/usage/UsageAlertManagerImpl.java
listAlerts: implemented search by alert name
Conflicts:
api/src/org/apache/cloudstack/alert/AlertService.java
api/src/org/apache/cloudstack/api/command/admin/resource/ListAlertsCmd.java
engine/schema/src/com/cloud/alert/AlertVO.java
2013-12-04 10:05:46 -08:00
433a631916
Reformat of source code to set a stable base for the future. I couldn't get checkstyle enabled. There's still about a thousand errors from checkstyle. Most of it from length errors from comments and strings. Will attempt to remove those tonight. This change is so large I just want to get it in before any merge nightmares. The changes are fairly minor though and I did a full compile and start a server with the reformat code.
2013-11-21 07:56:47 -08:00
d620df2bdd
Reformatted all of the code.
2013-11-21 06:15:26 -08:00
eaa250fd3c
Formatted again after all the tab expansions and eol removals
2013-11-21 04:47:01 -08:00
224f479974
Removed trailing spaces
2013-11-21 04:08:01 -08:00
e4b22d0fca
Replace all tabs, particularly the ones in the comments
2013-11-21 03:39:58 -08:00
273c912bb6
CLOUDSTACK-1868. GetVmStatsCommand throws NullPointerException with VMWare.
2013-11-21 09:39:44 +05:30
8d62744681
Reformat all source code. Added checkstyle to check the source code
2013-11-20 07:26:53 -08:00
90fb76a72c
CLOUDSTACK-5069. Added global config 'vmware.vcenter.session.timeout' to make the vCenter session timeout value configurable.
2013-11-20 16:12:22 +05:30
fc9adec72e
CLOUDSTACK-669: Add host level side-by-side VM state report for graceful sync model migration
2013-11-12 18:32:51 -08:00
a35425eec6
CLOUDSTACK-5122. System VMs are getting recreated with old template after upgrading to 4.2.
...
In VMware during VM start the existing disk information is used to configure the VMs. So even if a new disk is created using the new template VM continues to use the old disk.
Once the old root disk is marked for destroy force expunge it and sync the new disk into the VM folder before VM start
2013-11-10 23:31:56 +05:30
4815b024bf
Add quiesce vm for vmware during vm snapshot
2013-11-08 15:47:11 -08:00
f826dfb918
Fixed bug with deleting VMWare VM Snapshots
...
Signed-off-by: Edison Su <sudison@gmail.com>
2013-11-07 14:29:35 -08:00
d0123f9594
Added option to reload VM during in RevertToVMSnapshotCommand (only in VMWare as I don't believe that XenServer supports anything similar)
...
Signed-off-by: Edison Su <sudison@gmail.com>
2013-11-07 14:23:36 -08:00
f03dcdab19
[CLOUDSTACK-5051] Revert "CLOUDSTACK-3715. Socket timeout error is observed in VMware setup if a VMware task (RelocateVM_Task, CloneVM_Task etc.) takes more than 10 minutes. Making this value configurable to allow admins to modify the timeout if required. It defaults to the current value i.e. 10 minutes."
...
This reverts commit 3a91500173
2013-11-06 19:07:33 +05:30
88170f9a79
CLOUDSTACK-4736 Monitoring service kvm vmware resource changes
2013-11-06 18:37:43 +05:30
0ef6135198
CLOUDSTACK-3715. Fix import error.
2013-11-05 17:42:17 +05:30
a286dec098
CLOUDSTACK-4908: CPU socket count of host Adding cpu socket count of the host in hostresponse
...
Signed-off-by: Koushik Das <koushik@apache.org>
2013-11-05 16:12:36 +05:30
3a91500173
CLOUDSTACK-3715. Socket timeout error is observed in VMware setup if a VMware task (RelocateVM_Task, CloneVM_Task etc.) takes more than 10 minutes. Making this value configurable to allow admins to modify the timeout if required. It defaults to the current value i.e. 10 minutes.
2013-11-05 15:59:03 +05:30
e60037cb80
Remove primarydatastoreTo in vmwareresource
2013-11-04 14:37:24 -08:00
7c99b88926
Don't use cast to PrimarydataStoreTO on the resource code
2013-11-01 15:13:16 -07:00
449b5daa70
VMware changes related to managed storage
2013-10-31 08:30:50 -06:00
3205cd42b5
CLOUDSTACK-730: Site-to-site VPN between VPC VR to VR
...
Now VPN connection can be created as "passive", which would enable the ability
of remote peer initiate the connection. So it's possible for VPC VR to
establish the connection to another VPC VR of CloudStack.
Test case also included.
The test case would create 2 vpcs and using VPN to connect them.
2013-10-30 19:30:22 -07:00
7116268f33
CLOUDSTACK-4946. VM Restore with template id/Volatile VM feature doesnt work on VMware
...
When a ROOT volume is created from base template, if a folder already exists for the ROOT volume's VM then replace the old ROOT disk files with the new one.
2013-10-28 13:17:54 +05:30
858ce76665
Extend support of CloudStack-managed storage to KVM
2013-10-27 22:30:03 -06:00
51a8086cf6
Merge branch 'pluggable_vm_snapshot'
...
Conflicts:
client/tomcatconf/applicationContext.xml.in
engine/storage/integration-test/test/org/apache/cloudstack/storage/test/SnapshotTest.java
engine/storage/integration-test/test/resources/storageContext.xml
server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java
server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java
2013-10-25 16:47:17 -07:00
a6ce66e55a
move a lot of code into vmsnapshot strategy
...
fix compile
fix compile
add vm_snapshot_details table in db
add vmsnapshot test cases
2013-10-25 15:09:04 -07:00
df1924d910
CLOUDSTACK-754: Fix KVM and Vmware resource for VPN
2013-10-24 17:43:03 -07:00
c9101966e0
Added StorageStrategyFactory to centralize and deduplicate some logic
2013-10-23 12:40:41 -07:00
e3280bdba2
Merge remote-tracking branch 'origin/spring-modularization'
...
Conflicts:
client/tomcatconf/applicationContext.xml.in
client/tomcatconf/nonossComponentContext.xml.in
client/tomcatconf/simulatorComponentContext.xml.in
framework/db/src/com/cloud/utils/db/Transaction.java
plugins/hypervisors/simulator/src/com/cloud/agent/manager/MockAgentManagerImpl.java
server/src/com/cloud/api/ApiServer.java
server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java
2013-10-23 11:14:42 -07:00
205a77a5bb
Merge remote-tracking branch 'origin/txn-refactor'
...
Conflicts:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
server/src/com/cloud/configuration/ConfigurationManagerImpl.java
server/src/com/cloud/metadata/ResourceMetaDataManagerImpl.java
server/src/com/cloud/vm/UserVmManagerImpl.java
2013-10-23 10:40:44 -07:00
e33ae74067
CLOUDSTACK-4649:
...
xs 6.1/6.2 introduce the new virtual platform, so there are two virtual platforms, windows PV driver version must match virtual platforms,
this patch tracks PV driver versions in vm details and template details.
Anthony
2013-10-22 17:54:51 -07:00
484d6c4eb7
CLOUDSTACK-2792: Call savepassword.sh inside VR
...
Also only set password when password service is running, thus avoid setting for
redundant router BACKUP router.
2013-10-17 20:04:44 -07:00
9cbb309d6b
Refactor missed classes
2013-10-17 16:00:11 -07:00
aad1cda7e0
Added categorized sorting to SnapshotStrategy and DataMotionStrategy
2013-10-14 15:20:42 -07:00
16b022b1b1
CLOUDSTACK-4802: Change VM start flow to better support VM snapshot on certian version of vSphere, (vSphere 5.0 Update 2). If we detect that VM has pending VM snapshot, we will fully honor VM disk info from vCenter, since in some version of vSphere (vSphere 5.0 U2) does not allow disk-editting when VM has pending snapshot.
2013-10-04 16:13:56 -07:00
bced4c7e8b
Add support for hypervisor snapshots to CloudStack-managed storage (for XenServer and VMware)
2013-10-04 15:41:20 -06:00
180cfa19e8
Refactor Storage Related Resource Code
...
These changes are a joint effort between Edison and I to refactor some
of the code around snapshotting VM volumes and creating
templates/volumes from VM volume snapshots. In general, we were working
towards allowing PrimaryDataStoreDrivers to create snapshots on primary
storage and not requiring the snapshots to be transferred to secondary
storage.
High level changes:
-Added uuid to NfsTO, SwiftTO & S3TO to cut down on the requirement of
PrimaryDataStoreTO and ImageStoreTO which don't really serve much of a
purpose
-Initial work towards enable reverting VM volume from snapshots
-Added hypervisor commands for introducing and forgetting new hypervisor
objects (snapshots, templates & volumes)
Signed-off-by: Edison Su <sudison@gmail.com>
2013-10-04 13:06:42 -07:00
bd8536739c
remove txn attribute from DB
...
txn attribute was never actually used
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2013-10-04 10:15:39 -07:00
a3babdd61c
CLOUDSTACK-4790: Skip reserved VMware scsi device number for SCSI disks
2013-10-02 17:53:56 -07:00
67186429e1
Spring Modularization
...
ACS is now comprised of a hierarchy of spring application contexts.
Each plugin can contribute configuration files to add to an existing
module or create it's own module.
Additionally, for the mgmt server, ACS custom AOP is no longer used
and instead we use Spring AOP to manage interceptors.
2013-10-02 15:41:04 -07:00
f3c917db05
CLOUDSTACK-4734: Validate and Fail-over to another VmwareContext object when it is from the pool
2013-09-27 15:57:56 -07:00
08c3b6596d
CLOUDSTACK-4659: Vmware allows destroying VM that has pending tasks, worker VM GC actually relies on the assumption that Vmware is protected from that which is a false assumption. Recycle Worker VM only it is from previous session
2013-09-27 15:57:02 -07:00
159d798a19
Disable VMwareTools detection to avoid unreliable result caused by race-condition when VMwareTools is not ready in guest OS yet and the API is called. This is the corrected commit
2013-09-27 15:56:43 -07:00
2614b00c51
sdn hosted vpc gateways (using lswitch)
2013-09-18 16:56:56 +02:00
1598571dfc
CLOUDSTACK-4659: Fix the regression caused by worker VM consolidation for GC purpose
2013-09-17 14:07:14 -07:00
5820b071b8
CLOUDSTACK-4659: Add the missing feature back for GC VMware worker VMs
2013-09-17 14:06:52 -07:00
b11a8e12e8
CLOUDSTACK-4625:Snapshots and templates should be deleted from staging
...
storage after create template from snapshot on S3.
2013-09-06 17:48:40 -07:00
ae231444bc
CLOUDSTACK-4585: make run-time datastore folder migration, VM snapshot, bug in root disk controller type carried from previous version work under upgrade situation
2013-09-04 14:49:46 -07:00
e81e75c6b0
CLOUDSTACK-4362: always honor vCenter on-disk meta data to work with live migration better
2013-09-04 14:49:46 -07:00
281b94d587
CLOUDSTACK-4458: Volume attach/detach command needs to sent to hypervisor resource even when target VM is in Stopped state
2013-09-04 14:49:46 -07:00
ea13e089b8
CLOUDSTACK-4519: reimplementdestroy-volume to take consideration of on-disk snapshot
2013-09-04 14:49:46 -07:00
a4762b0904
CLOUDSTACK-4464,CLOUDSTACK-4529: use property collector to collect all information in one round, we have a few other places that need to do it the same way
2013-09-04 14:49:46 -07:00
d6bac1465a
CLOUDSTACK-4518: make folder sync resilience with possible runtime situation
2013-09-04 14:49:46 -07:00
e929b4ceb2
CLOUDSTACK-4522: check before we do dynamic casting
2013-09-04 14:49:46 -07:00
bae2666549
CLOUDSTACK-3237: add disk chain sync logic to handle out-of-band chain changes that could happen in storage live migration and VM snapshot operations
2013-09-04 14:49:46 -07:00
e3a5b3fad9
CLOUDSTACK-3237: acknowledge the behind-back VMDK disk consolidation happend in vCenter after storage live migration
2013-09-04 14:49:46 -07:00
c528e71fec
CLOUDSTACK-4390, CLOUDSTACK-4358: Enable full-clone deployment by default for VMware. Apply keep-alive kick for all outstanding vCenter sessions
2013-09-04 14:49:45 -07:00
899f92b725
CLOUDSTACK-4288: Fix the way that VmwareClient is using vSphere 5.1 SDK which caused huge memory footprint
2013-09-04 14:49:45 -07:00
0becde90bb
CLOUDSTACK-3568: Refactore CloudStack/vCenter API session management facility to avoid the situation that multiple API requests are sharing with the same vCenter API session
2013-09-04 14:49:45 -07:00
c6dfb33d9f
CLOUDSTACK-3237: pass disk file name instead of full datastore path when setting up storage relocation specin order to safely locate the disk device
2013-09-04 14:49:45 -07:00
dbe4e13e8e
CLOUDSTACK-3778: serialize configuration of port group at per-host level to prevent run-time race condition
2013-09-04 14:49:45 -07:00
75bb38394b
CLOUDSTACK-3869: fix merge conflicts
2013-09-04 14:49:45 -07:00
362ef67013
CLOUDSTACK-3869: make new folder structure to work with Create/Delete/Attach/Detach commands
2013-09-04 14:49:45 -07:00
9a2148ffc3
CLOUDSTACK-3886: check in for review request https://reviews.apache.org/r/13008/
2013-09-04 14:49:45 -07:00
40869a5a2b
CLOUDSTACK-3869: Move VMware datastore folder structure policy management to central place
2013-09-04 14:49:45 -07:00
249e2e8f59
Correct DAO usage in VmwareDatacenterVO, relax assertion conditions to work with stack calling frame that is not wrapped with @DB injection
2013-09-04 14:49:44 -07:00
f555e26c87
CLOUDSTACK-1192: fix silly mistake
2013-09-03 08:52:35 +02:00
87d73e227f
CLOUDSTACK-1192: GetVmDiskStatsCommand return null as disk I/O statistics does not support xen/vmware
...
(cherry picked from commit 3121133c03
2013-09-02 16:04:59 +02:00
d9c06e538b
CLOUDSTACK-4346 replace URI getHost() and create(String) calls with BroadcastDomainType methods
2013-09-01 22:53:23 +02:00
2a0e371881
[Upgrade from 3.0.6 to 4.2][vmware] After upgrade the system vms fail to come up because "Secondary storage mount point" is pointing to a wrong location
...
when secondary storage is mounted as read-only, changing permission of files on it will fail. But we should still stick to current mount point instread of
returning a wrong mount point /mnt/sec
2013-08-29 10:32:13 -07:00
e217c0f1c3
CloudStack CLOUDSTACK-4426
...
[VMware] [upgrade] system VM not coming up after upgrade from 3.0.4 to 4.2
2013-08-28 15:40:33 -07:00
993a1f937f
CloudStack CLOUDSTACK-4426
...
[VMware] [upgrade] system VM not coming up after upgrade from 3.0.4 to 4.2
2013-08-28 15:40:28 -07:00
de531c0c0a
Trim IQN so that the format /iqn/lun becomes iqn.
2013-08-28 15:08:45 -06:00
bd2d875073
Make Mutual CHAP optional for VMware.
2013-08-26 16:08:37 -06:00
49dd7289c0
CLOUDSTACK-4468:template created from snapshot is destroyed once we
...
restart management server.
2013-08-26 11:58:53 -07:00
2807d083db
CLOUDSTACK-4480: Handle DestroyCommand in VmwareResource to evict
...
unused template from primary storage pool.
2013-08-23 15:26:43 -07:00
75be7a9ac4
CLOUDSTACK-4433:[VMware]Registration of template using the downloaded
...
template URL is failing.
2013-08-22 15:59:09 -07:00
69adeecc39
CLOUDSTACK-4414
...
Fixing detection of failure in cluster discovery before cleanup vsm device.
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-08-21 08:03:52 +05:30
e6b53e5529
CLOUDSTACK-4386
...
KVM - Create template from volume
Vmware - Create template from volume / Create template from snapshot
send the physical size in the copycommand which accordingly will populate template store ref and the usage_event tables with the right physical size
Signed off by : nitin mehta<nitin.mehta@citrix.com>
2013-08-20 19:21:32 +05:30
41f2c75aee
CLOUDSTACK-4385 : [ZWPS]Across the cluster live migration of VM on zone wide primary storage pool fails
...
If all the VM's volumes are on zone wide primary storage pool then live migration of the VM would not involve storage migration. Hence MigrateVM API would be called against MigrateVMWithVolume. So far PrepareForMigrationCommand handled scenarios of VM moving across hosts within a cluster, but with zone wide primary storage in picture this command need to handle scenarios of VM moving across clusters. Try to find the VM in datacenter if not found within cluster.
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-08-19 05:55:17 +05:30
dd6b245221
CLOUDSTACK-4318: clean up snapshot stored in staging area, after backup snapshot to object store
2013-08-14 14:59:25 -07:00
b0e06981c1
CLOUDSTACK-4326 Adding VMware DC to legacy zone should not be allowed by API
...
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-08-14 12:47:58 +05:30
de2bd96d98
Moved volume related code into cloud-engine-orchestration
2013-08-12 19:06:51 -07:00
8af05e5202
CLOUDSTACK-4253: add more logs for vmware storage related operations
2013-08-12 17:19:17 -07:00
3ad9681fd1
CLOUDSTACK-4253: change the log message if copy template from secondary storage to primary storage failed
2013-08-12 17:19:04 -07:00
9e3aa37a8d
CLOUDSTACK-3905 [VMWARE]Can not add Standard/DVSwitch when Nexus global config is set to true
...
Make VSM specific input paramters optional while adding VMware cluster where no traffic chosen to use Nexus 1000v dvSwitch when cloud level vSwitch is Nexus 1000v.
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-08-12 22:45:01 +05:30
f0ae682d48
CLOUDSTACK-4246 VM deployment fails with global configuration parameter "vmware.nested.virtualization" enabled.
...
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-08-12 09:44:33 +05:30
14abe4cb2d
CLOUDSTACK-4155 [VMWARE] Failed to deploy VM with NPE when vmware.nested.virtualization is enabled to true
...
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-08-12 07:43:10 +05:30
bf6961255a
CLOUDSTACK-4190:[Object_store_refactor] volume should be deleted from
...
staging storage after successfule volume migration .
2013-08-08 16:16:36 -07:00
5495f10bce
Revert "Reverting the range of commits that broke the build"
...
This reverts commit b59e3aaefc
2013-08-08 15:02:40 -07:00
f43f3bb95e
CLOUDSTACK-2558 Nexus configuration cleanup is not done when there is a failure while adding the Nexus enabled VMWARE cluster which is causing for NPE while readding the cluster with same configuration details
...
If cluster addition fails then cleaning up the Nexus VSM related to the cluster.
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-08-08 13:49:11 +05:30
b59e3aaefc
Reverting the range of commits that broke the build
...
This reverts commits 30c33415..f6a2c817bc
Signed-off-by: Prasanna Santhanam <tsp@apache.org>
2013-08-08 14:46:56 +05:30
9bce985f62
CLOUDSTACK-4108: fix create template from snapshot for vmware& s3
2013-08-07 19:14:22 -07:00
e851f4a930
CLOUDSTACK-4109: fix upload volume to s3 for vmware
2013-08-07 19:14:18 -07:00
82c35e52ea
CLOUDSTACK-4135: [Object_store_refactor] ISO attached to the guest vm
...
has wrong mount path.
2013-08-07 18:01:58 -07:00
5287f4c9ec
Got everything running through testing
2013-08-07 16:41:06 -07:00
942f282a6e
Moved config into it's own package
2013-08-07 16:41:02 -07:00
a470b33f97
CLOUDSTACK-3616 [VMware] Failed to create template from volume (volume is created from snapshot of data volume)
...
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-08-07 14:56:08 +05:30
1d9465d758
CLOUDSTACK-3782 Data disk size is modified to KB from GB after it is attached to the instance
...
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-08-07 08:08:46 +05:30
3946070359
CLOUDSTACK-4041 [ZWPSFailed to migrate a ROOT volume created on zone wide primary storage
...
While finding endpoint to send the migrate volume command, in case of zone wide storage pool, storage engine is picking a host among all connected hosts randomly. Hence a host may be from different cluster t
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-08-07 06:07:54 +05:30
a8ee45de7c
CLOUDSTACK-4074: if hypervisor doesn't return size of volume/template, don't update it into db
2013-08-06 15:53:57 -07:00
36c7a56d12
CLOUDSTACK-4073: fix s3 on vmware
...
Conflicts:
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
2013-08-05 20:23:01 -07:00
51e4f597e0
fix CLOUDSTACK-3591 add usage recording for VM snapshots
...
Conflicts:
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java
setup/db/db/schema-410to420.sql
2013-08-01 10:47:36 +08:00
211524f3bc
add note on vmwarweguru->getCommandHostDelegation
2013-07-30 16:17:06 -07:00
c42f51d75b
CLOUDSTACK-3944: fix regression for vmware
2013-07-30 16:17:02 -07:00
62a71e055b
CLOUDSTACK-3937: Attaching uploaded volume is failing
...
The method getCommandHostDelegation(long hostId, Command cmid) got overidden in VmwareGuru.java as part of
commit bfe30cd2e3
2013-07-30 16:56:15 +05:30
f0f55226de
CLOUDSTACK-3107: fix attach upload volume
2013-07-29 19:00:16 -07:00
f486d36f88
CLOUDSTACK-3908: fix extract path
2013-07-29 16:58:51 -07:00
ae534388c0
CLOUDSTACK-3852: fix upload volume
...
Conflicts:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java
server/src/com/cloud/template/TemplateManagerImpl.java
2013-07-29 11:50:16 -07:00
9fe5d398a2
CLOUDSTACK-3849: Set volume size in CopyAnswer for Vmware when cloning volume from bas template
2013-07-29 16:34:46 +05:30
57d96308c1
CLOUDSTACK-3468 Failed to Deploy Instances with multiple VMWARE clusters when DVS is enabled at the Zone level
...
Fixing cluster level override of zone level specified vSwitch settings.
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-07-29 03:04:23 +05:30
3adeb12d2f
CLOUDSTACK-3879 [VMware] NPE while attempting to create template from volume
...
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-07-27 18:03:17 +05:30
081ba92497
COUDSTACK-3053 Template creation from snapshot is failing on VMware setup
...
Fixed snapshot vmdk file path while copying snapshot files to template path.
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-07-27 18:02:31 +05:30
c8cafb91a7
CLOUDSTACK-3818: NFS Cache Improperly Named.
2013-07-26 15:07:45 -07:00
111febc567
Fixed up the rest of the management server code that calls clustermanager
2013-07-25 19:57:45 -07:00
e7cdaa1b31
CLOUDSTACK-3667:[Object_Store_Refactor][VMWare] System VMs StartCommand
...
failed due to Exception: java.lang.Exception Message: secondary storage
for dc 3 is not ready yet?
2013-07-25 10:57:05 -07:00
0984594323
CLOUDSTACK-2933 Added vpc load balancing changes for vmware
2013-07-25 17:40:48 +05:30
80ac885e22
CLOUDSTACK-2304: fix migrate volume for vmware
2013-07-24 19:06:42 -07:00
7f200d966e
CLOUDSTACK-3681: fix bunch of bugs related to vmware, regarding to snapshot
2013-07-24 19:06:30 -07:00
e14f5d0aeb
Cloudstack-3694 Dnsmasq rewrite in bash
...
(Sheng: Fix typo, fix log and error message, remove 'set -x' in script)
Signed-off-by: Sheng Yang <sheng.yang@citrix.com>
2013-07-24 14:00:31 -07:00
319d91e1c2
Removed the getByTypeAndId() method and replace it with getById method
2013-07-22 20:06:04 -07:00
1325014a03
Changed VirtualMachineProfile to be non-generic. From here on VirtualMachineManager will only manage vm instance. It doesn't understand the difference between different types of VMs. This makes the vmsync code to be generic across all vms.
2013-07-22 11:48:11 -07:00
98dd501a81
Changes related to Review Board comments
2013-07-20 17:44:23 -06:00
b43a2a5fae
Changes related to Review Board comments
2013-07-18 20:10:58 -06:00
7e087645c6
CLOUDSTACK-3595 Backup snapshot successful but CopyCmdAnswer received is failure.
...
Send success answer of type CopyCmdAnswer with full snapshot backup path in secondary store (image store role)
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-07-18 23:29:54 +05:30
d6cb95208b
CLOUDSTACK-3554: NPE while attaching VMWARE Tools ISO to the instance
...
Description:
Account for null imagestore for vmware-tools iso.
2013-07-17 16:58:51 -07:00
59788c1473
CLOUDSTACK-3530 Runtime exception while creating Snapshot from volume (ROOT/DATA)
...
Worker name is not being configured for CopyCommand.
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-07-18 00:39:28 +05:30
2d6644d961
CLOUDSTACK-2433 Enable rps and rfs in virtual router
2013-07-17 16:59:59 +05:30
af696e6ff6
CLOUDSTACK-728 Remove the nvp portgroup when the virtual machine is
...
expunged.
2013-07-16 15:42:29 +02:00
1f004f60e8
CLOUDSTACK-3425 Ignore network interfaces without a uuid when passing
...
them on as extra configs to ESX for nicira NVP controller.
2013-07-15 10:17:36 +02:00
505ab2eebe
Changes related to Review Board comments
...
Changes related to Review Board comments
Changes related to Review Board comments
2013-07-12 14:28:00 -06:00
2691970f28
CLOUDSTACK-728 Get the framework in place the support the removal of the portgroup that is created for a nic connected to an lswitch.
...
Add a command to tell a hypervisor guru to take some action when
expunging a nic
2013-07-12 12:18:34 +02:00
7dc3d3bae5
Formatting changes using the settings from Alex
2013-07-12 12:18:20 +02:00
392bbcc737
CLOUDSTACK-728 Rewrite support for lswitch connected nics on both standard and distributed switches.
...
Fix the name of the interface id in extra config, so the nic is found up using the nic uuid instead of the vm id.
getVlanInfo should return null when the nic is plugged on a Lswitch network.
On a distributed portgroup all vms should be connected to a single
portgroup and set a specific vlan on the port. On a standard switch each nic should have its own portgroup with a dedicated vlan (not related to CS vlans)
2013-07-12 12:18:07 +02:00
a3660d8109
CLOUDSTACK-3469 [VMware] Support to make username/password optional while adding VMware cluster
...
For legacy zones insist on the old model of asking for credentials for each cluster being added.
For non-legacy zones check if username & password are provided. If either or both not provided, try to retrieve & use the credentials from database, which are provided earlier while adding VMware DC to zone.
This lets user to not specify credentials while adding VMware cluster to zone, if the credentials are same as that of provided while adding VMware DC to zone.
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-07-11 20:39:33 +05:30
1e2f99be68
Updated logger initalization in classes ListVmwareDcsCmd, RemoveVmwareDcCmd & minor cleanup of comments.
2013-07-11 15:59:25 +05:30
29a31708d5
CLOUDSTACK-3450 To implement toggle action of add/remove VMware DC, listVmwareDcs API call is required.
...
listVmwareDcs API is added. Takes 1 parameter (mandatory) which is zoneId.
Returns list of VMware DCs associated with specified zone.
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-07-10 23:04:32 +05:30
664dc17b0b
CLOUDSTACK-3303 Vmware - Put a mechanism to disable hot add vcpu if the number of cores per socket is not 1 and virtual machine hardware version=7
...
Following Hotadd memory checks are included now.
1) Check if guest operating system supports memory hotadd
2) Check if virtual machine is using hardware version 7 or later before enabling memory hotadd
Following Hotadd CPU checks are included now.
1) Check if guest operating system supports cpu hotadd
2) Check if virtual machine is using hardware version 8 or later.
3) Check if virtual machine has only 1 core per socket. If hardware version is 7, then only 1 core per socket is supported. Hot adding multi-core vcpus is not allowed if hardware version is 7.
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-07-10 17:58:42 +05:30
06f73092fb
Changes related to Review Board comments
2013-07-09 22:50:14 -06:00
91d31b29b8
CLOUDSTACK-3304 [Vmware][Dynamic Scaling] - Enforce checks for maximum hotadd memory limit & memory increment size in CS
...
Retrieve maximum hotadd memory limit & hotadd memory increment size from running VM's configuration to validate dynamic scale memory limit while scaling up a VM.
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-07-08 21:17:49 +05:30
5f395e41ab
CLOUDSTACK-2592 [Automation]: Scale up VM on VMWARE without license doesn't throw appropriate error
...
Now ESXi server license would be fetched to see if HOTPLUG feature is license or not.
Throw Exception if the feature is not licensed.
Also added FeatureKeyConstants enum type to maintain list of various features to be checked whether licensed or not.
2013-07-08 12:49:39 +05:30
d2739cde2e
Fix file name in DnsMasqConfigCommand
...
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2013-07-03 20:43:42 +05:30
98c5fe3a8d
CLOUDSTACK-3302: [Multiple_IP_Ranges][VmWare] VM deployement failed due to dnsmasq configuration issue in case of multiple subnets in a vlan
...
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2013-07-03 16:59:21 +05:30
6aa9b2f356
CLOUDSTACK-3152 addVmwareDc API call fails if called more than once to add same VMware DC to same cloudstack zone.
...
Check if the associated VMware DC matches the one specified in API params. This check would yield success as the association exists between same entities (zone and VMware DC)
This scenario would result in if the API addVmwareDc is called more than once with same parameters. For such scenario, return success response with VmwareDatacenter object read from database. Also returns success if addVmwareDC is called agsin with same zone and VMwareDC where the zone already has resources added to it (clusters etc.)
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-07-02 17:31:09 +05:30
61bc6c8477
Cloudstack-3302 VM deployement failed in VMWare due to dnsmasq configuration issue in case of multiple subnets in a vlan
...
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2013-07-02 12:00:50 +05:30
Rafael da Fonseca
Sateesh Chodapuneedi
Daan Hoogland
Likitha Shetty
Rohit Yadav
Daan Hoogland
Sanjay Tripathi
punith-cloudbyte
Saksham Srivastava
Mike Tutkowski
Harikrishna Patnala
Laszlo Hornyak
Santhosh Edukulla
Bharat Kumar
amoghvk
Frank Zhang
Edison Su
Nitin Mehta
Min Chen
Anthony Xu
Hugo Trippaers
Suresh Ramamurthy
Kelven Yang
Sheng Yang
Koushik Das
Alena Prokharchyk
Mandar Barve
Marcus Sorensen
Alex Huang
Chris Suich
Jayapal
Darren Shepherd
Darren Shepherd
Wei Zhou
Prasanna Santhanam
Mice Xia
Kishan Kavala
Vijayendra Bhamidipati