a400eecf6c
CLOUDSTACK-7503: Fixed few coverity issues
2014-09-10 11:33:01 +05:30
dc3f0cbc63
Improve the handling of the findbug exclude files
2014-09-03 10:41:22 +02:00
1c688f40e1
CLOUDSTACK-7277: [Hyper-V] For vmsync first VMs are listed and their power state is
...
determined. To exclude hosted system we filter the result on Caption='Virtual Machine'
but this string is locale dependent so it may not not work properly for locales other
than english. To overcome this now we started using ProcessId >= 0 filter
2014-08-18 11:38:29 +05:30
d1796c5f58
CLOUDSTACK-7235: [Hyper-V] In case of any exception in ModifyStoragePoolCommand, now we are returning appropriate error
2014-08-18 11:38:29 +05:30
0ecc9f79af
CLOUDSTACK-7234: stop sending smb credentials to Hyper-v agent
2014-08-18 11:38:29 +05:30
90fe6d8087
removed trailing space
2014-08-13 11:09:38 -07:00
fd96ad02d7
Fixed few coverity reported issues around concurrency, null checks
2014-08-11 16:55:23 +05:30
330c4ba578
completed the new vmsync TODOs in the code.
...
removed old vmsync logic
2014-07-28 12:51:37 -07:00
c1aed55583
More rat fixes
2014-07-18 11:52:27 +02:00
b43036d10e
CLOUDSTACK-6872: [hyperv] removed the redundant connectToRemote, DisconnectRemote methods which in turn fixes this bug. connectToRemote was used to connect to share, but once the share is domain joined we don't need this method as we already have required permissions
2014-06-13 13:26:30 +05:30
26fa623ffd
CLOUDSTACK-6663: Fixed Hyper-V agent fails to start on some setups. During startup agent tries
...
to get nic info of 0.0.0.0. To get it, it iterates through all nics and return the last NIC in
the list if it doesn't match with any IP address. In case last NIC doesn't have unicastAddress,
Hyper-V agent will fail to start. We don't need IP address during initialization. It get
initialized with startupcommand later.
2014-05-27 12:03:11 +05:30
5ba5da3696
CLOUDSTACK-6622: After a volume was live migrated, the destination smb storage path was added to
...
the folder column. For an smb share the smb credentials are in the query string of the path.
Before adding the path, smb shares query string should be cleaned up.
2014-05-09 16:31:34 +05:30
b82e26253c
CLOUDSTACK-6620: Fixed null pointer exception in hyperv agent in getting vmstats, when all vms are deleted from outside
2014-05-09 16:31:25 +05:30
7916542d99
CLOUDSTACK-6399: When there are no vms running on hyperv host, then agent was returning null. In
...
that case cloudstack was not doing anything and not updating the state of the vms to stopped.
Now the agent returns empty list of hostvmstatereport. Management server will then update the
vm state to stopped (instead of not acting upon the return state).
2014-05-09 16:31:06 +05:30
dacb541950
Fixed windows line ending issues
2014-05-07 15:13:46 +05:30
f9cf2c241b
CLOUDSTACK-6518 [Hyper-V] Efficient way of finding the empty nic in VR/VpcVR to configure VPC entities
2014-05-05 12:56:42 +05:30
6511b96088
CLOUDSTACK-6504: removed warnings coming in building hyper-v agent code
2014-04-25 14:46:06 +05:30
1dc76a2743
CLOUDSTACK-6470: while stopping vm in hyper-v, now we are first trying to shutdown it gracefully before turning it off forcefully
2014-04-25 14:45:37 +05:30
455d2b3284
CLOUDSTACK-6411: removing license header from nuget.config and agent settings file, with
...
the header they are not getting loaded properly. Added an exception to not to do rat
checks on these files.
2014-04-21 14:10:17 +05:30
4620c27ebf
CLOUDSTACK-6047: Make aggregation command timeout configurable
...
In case some environments has different performance or we found some commands
would took too long to execute, one global configuration item is introduced to
specify "time out in seconds per one command in aggregation commands".
By default it's 3 seconds. If admin feel it's too long, it can be adjust to as
low as 1 seconds, which runs still well in my machine.
Conflicts:
setup/db/db/schema-430to440.sql
2014-04-18 23:36:19 -07:00
55f53e13e8
CLOUDSTACK-6401: [hyper-v] fixed correct host state, if host is up and hyper-v agent is down then the host state will be shown as up(actual host state) in cloudstack
2014-04-15 14:37:05 +05:30
3ec7497e1e
CLOUDSTACK-6400: [hyper-v] [vmsync] fixed occasionally VM is not deleted from back-end when it is stopped from Hyper-V manager and then destroyed-expunged from CS and returning only power VMs for vmsync
2014-04-15 14:36:55 +05:30
0aa6cc60c7
CLOUDSTACK-6398:[hyper-v] changed auto shutdown and startup actions of VMs to shutdown and nothingauto shutdown and startup actions of VMs to shutdown and nothing so that they are consistent with cloudstack auto shudown and startup behavior
2014-04-15 14:36:37 +05:30
5e90b75c98
CLOUDSTACK-6402: Fix StopCommand so that VMs are not removed accidentally as part of vmsync
...
Added a new flag 'checkBeforeCleanup' to StopCommand based on which check is done to see if VM is running in HV host.
If VM is running then in this case it is not stopped and the operation bails out.
Also modified the MS code to call the StopCommand with appropriate value for the flag based on the context.
Currently it is only set to 'true' when called from the new vmsync logic based on powerstate of VM. For rest it
is set to 'false' meaning no change in behaviour.
2014-04-14 16:52:37 +05:30
ade4d44de4
CLOUDSTACK-6262: Fixed network throttling in hyper-v, Now network rate parameter is honored in hyper-v. Network rate parameter now set the max bandwidth of nic on hyper-v
2014-04-09 13:10:30 +05:30
1dfe4c19b5
CLOUDSTACK-6289: fixed storage migration failing in case of hyper-v if there are multiple disks attached to VM
2014-04-08 14:39:13 +05:30
e644ac1653
CLOUDSTACK-6325: [hyper-v] fixed cleaning of bin and obj directories when building with mono, they were not cleaning up and resulting in use of stale dlls in some cases
2014-04-08 14:37:21 +05:30
f40e8a835c
CLOUDSTACK-6326: fixed password visible in plain text in some of commands in Hyper-v Agent logs
2014-04-08 14:37:13 +05:30
24820d20d3
CLOUDSTACK-6288: Changing default ImageFormat to vhdx for hyper-v and allowing registration of vhdx format templates.
...
Signed-off-by: Devdeep Singh <devdeep@gmail.com>
2014-04-01 14:00:24 +05:30
8b62b2cb92
findbugs: exclude known spiffy hacks a.k.a. false positives
2014-03-28 14:28:10 +01:00
1d3a6eaa50
CLOUDSTACK-6047: Fix timeout issue when try to execute aggregated commands
...
Add executeInVR() with timeout interface to VirtualRouterDeployer
AggregationControlCommand with Action.Finish may take longer than normal command
since it would execute all the commands in one execution, and it may result in
SSH timeout for SshHelper or other mechanism communicate with VR.
Introduce an new executeInVR() interface with added timeout period for waiting
FinishAggregationCommand to complete execution.
2014-03-18 17:43:59 -07:00
4402685e11
Update master to 4.5.0-SNAPSHOT
2014-03-14 14:55:26 +01:00
6a4927f660
Fixed all findbugs in hyperv plugin code
2014-03-14 17:36:43 +05:30
4523f5d8de
CLOUDSTACK-6106 Agent side changes for VPC on Hyper-V
2014-03-14 17:36:43 +05:30
1b4325d2c8
CLOUDSTACK-6106 supporting VPC VR on Hyper-V
2014-03-14 17:36:43 +05:30
2aff39f8c7
CLOUDSTACK-6143: Storage motion support for hyper-v. With these changes a volume on a shared
...
storage pool (SMB) and attached to a running vm can be live migrated to another shared storage
pool. Also a vm and its volumes can be live migrated to another host and storage pool respectively.
2014-03-14 16:27:58 +05:30
6c23e201ad
1) More fixes for the problems found by findBugs
...
2) Corrected some logging in MidoNetPublicNetworkGuru - removed .toString method call on the objects in the log body as toString is called on the object by default when use log4j
2014-03-13 16:05:45 -07:00
540d020aa5
CLOUDSTACK-6179 Execute VR commands on Virtual Resource when commands received to Hyper-V
2014-03-11 13:10:13 +05:30
ab1d3af460
Use seperate path to sync VM metadata for XS
...
VM status sync only does VM status sync
2014-03-05 15:44:50 -08:00
f960ada36e
CLOUDSTACK-6159 Fixed creating volumes(Root, DataDisk) with uuid in primary store
2014-02-23 09:21:30 +05:30
b86d45b003
CLOUDSTACK-6054: Changes for making vmsync work for hyper-v. Made changes to PingCommand and
...
StartupCommand to return the state of all vms on the host.
2014-02-11 12:19:41 +05:30
7f780f26f9
Fixed agent code to handle untagged public vlan while parsing the vlan id
2014-02-05 23:44:14 +05:30
a24263fe81
CLOUDSTACK-6030: Encrypt the primary and secondary smb storage password when it is stored in the db.
2014-02-05 15:44:09 +05:30
39447cce6e
CLOUDSTACK-5941 User Vm deployment on HyperV is failing due to change in the userdata script location and moved to json model
2014-01-28 07:03:08 +05:30
807dc09138
CLOUDSTACK-5561 Support of multiple public vlans on VR running in HyperV
2014-01-28 07:03:08 +05:30
aab881be21
CLOUDSTACK-5942: The agent at places logs the password of the user. It should mask the
...
password from the message string before writing to the log. Made a change to do so.
2014-01-24 15:04:00 +05:30
538092b73e
Hyper-V agent should log to the event viewer. Changed the default
...
log appender for the agent.
2014-01-23 13:45:55 +05:30
b2de225f54
CLOUDSTACK-5703: putting rdp server port value in host details
2014-01-23 10:54:08 +05:30
5941ac46d2
CLOUDSTACK-5344 commit for console proxy rdp for hyperv
2014-01-23 10:54:08 +05:30
e9e5b84747
CLOUDSTACK-5894: A template created from a volume on hyper-v became unusable after
...
the management server was restarted. The template.properties file created for the
template has the format field in upper-case. This caused the template service to
not to recognise the format and it removed the entry from the template_store_ref
table in db. Fixed the format field in the templatee.properties.
2014-01-17 19:17:17 +05:30
06f8c1de75
CLOUDSTACK-5692: obscure passwords when using cifs as storage
2014-01-17 14:00:24 +05:30
823abe6a23
CLOUDSTACK-5880: Communication between management server and hyper-v agent should be secure.
2014-01-16 14:48:28 +05:30
68b8891c62
Removed all reminants of the IdentityService. Created the KeysManager to move the management
...
of keys out of management server
2014-01-14 13:11:35 -08:00
f58d77c8d1
CLOUDSTACK-5689: System vm creation on local storage fails for hyper-v. A
...
null pointer exception was getting generated when a VolumeTO object was
serialized to create an answer object. If a local storage is used the uri
field will be null. Added null checks for the same.
2014-01-14 19:55:00 +05:30
641f85cf6f
CLOUDSTACK-5657: Run the service as an account (hyper-v admin on host) so
...
that migration can work across hosts.
2014-01-10 17:08:01 +05:30
db2b025608
CLOUDSTACK-5639: If path field in the TO already has the complete path, do
...
not try to generate the path.
2014-01-10 16:37:43 +05:30
7dc4c5cb5d
CLOUDSTACK-5795: Template.properties file wasn't created when a template
...
was created from a volume. Added a post creation change to create the file
with the necessary information.
2014-01-09 10:52:34 +05:30
3116f51a26
CLOUDSTACK-5788, CLOUDSTACK-5789: Attaching upload volume and download
...
volume was failing for hyper-v. Copy command answer was failing while
creating the answer object. Fixing the issue.
2014-01-06 16:36:03 +05:30
cd43921fda
CLOUDSTACK-5658 CLOUDSTACK-5563 deploying VM from template created from volumes fails
2014-01-03 17:25:54 +05:30
e59420c514
CLOUDSTACK-5691: Fix for attaching an uploaded volume to instance running
...
on hyperv. There were multiple issues here. Upload volume was actually
failing because the post download check for vhd on the cifs share was
unsuccessful. Also the agent code wasn't parsing the volume path correctly.
Fixed it too.
2014-01-03 16:55:28 +05:30
faa503d6fc
CLOUDSTACK-5605: Fixing GetStorage stats command for hyper-v. The agent
...
wasn't looking up the share path correctly for reading the stats of a smb
share.
2014-01-01 14:33:33 +05:30
d50517e931
Fixing check style errors in HypervDirectConnectResource.java.
2013-12-31 07:16:35 +05:30
fe11fa89ee
CLOUDSTACK-5687 [Hyper-V] Remote Access VPN fails with Unsupported command while trying to configure VPN users
2013-12-31 12:36:16 +05:30
785931b6f0
CLOUDSTACK-5560: Reattach of data disk fails for hyperv. When a data disk
...
is attached a hard disk drive is created on the scsi controller. On detach
the data disk is removed from the drive but the disk drive is left behind.
On reattach the agent was again trying to create a disk drive while it was
already present. Fixed the agent code to look up for disk drive while
attaching and if one is not found then only to create the drive for
attaching a data disk.
2013-12-30 16:53:43 +05:30
069f8aeed5
CLOUDSTACK-5659: Creation of vm from iso failing with wrong file format.
...
The agent was always creating a disk with image format vhdx, but the
cloudstack management server defaults to image format vhd for hyperv.
Updated the agent code to be consistent with what cs expects. All disks
are now created with image format vhd.
2013-12-30 12:00:26 +05:30
865330d440
CLOUDSTACK-5610: Host doesn't go to Down/Alert state even though it is powered off. VM
...
deployment fails because of that as cloudstack tries to deploy it on a host which is
ctually down. An investigator wasn't present for hyper-v; so cloudstack wasn't able to
determine the status of the host. Wrote an investigator for hyper-v which checks with
other hosts in the cluster for the status of the host being investigated.
2013-12-27 16:35:23 +05:30
cdf2a1161b
CLOUDSTACK-5649: Vms are stopped and not migrated from a host when the
...
host is put in maintenance mode. The migrate flag wasn't set to true in
the maintain answer. This caused cloudstack to not to schedule a migration
work item for vms on the host. Made a change to set the migrate flag to
true in migrate answer.
2013-12-27 15:21:14 +05:30
ea09c0435f
CLOUDSTACK-5193 [Hyper-V] VHDs not deleted post VM destroy and expunge
2013-12-27 14:59:57 +05:30
31969e993e
CLOUDSTACK-5595 add vlan to storage nic to vnic for ssvm
2013-12-27 14:59:31 +05:30
3f59780e91
CLOUDSTACK-5584 fix the issue to configure the systemvm's in hyperv consistently
2013-12-27 14:58:56 +05:30
67d1a88880
CLOUDSTACK-5603 support Monitoring VR services when VR running on Hyper-V
2013-12-27 14:55:16 +05:30
84bf5b3e55
added support to run hyperv agent on 0.0.0.0 and startuprouting command will discover the ip details and send in response
2013-12-27 14:43:25 +05:30
1a033eddae
CLOUDSTACK-5308, CLOUDSTACK-5542: Copy command didn't handle the scenario
...
when a volume is copied to secondary storage for template creation.
Updated the command to handle it.
2013-12-26 15:32:41 +05:30
38d6c2ea60
CLOUDSTACK-5639: Cold storage migration doesn't work for hyper-v. Made
...
changes to make sure CopyCommand honours requests for volume copy from
primary to secondary storage and vice versa.
2013-12-25 15:23:48 +05:30
216554d574
CLOUDSTACK-5210: Fix the sockets reported by the hyperv agent.
2013-12-23 13:25:22 +05:30
74cb4b1c5a
CLOUDSTACK-5555: Fixing booting a vm on hyperv with data disk. Made
...
changes to attach a data disk on scsi controller when a vm is being
created.
2013-12-20 17:12:59 +05:30
3604f87c8d
CLOUDSTACK-5217: Attach volume fails with NPE. Made changes to make sure
...
the hypervisor product version is reported on startup. Also made changes
to fix attach and detach volume on scsi controller.
2013-12-17 16:28:08 +05:30
759d484d9a
CLOUDSTACK-5489: Query the user name and add it to the command while mounting a cifs share.
2013-12-17 14:19:32 +05:30
86dadaaec4
CLOUDSTACK-5489: Cloud user doesn't have permissions to copy systemvm.iso to secondary.
...
Make sure when a cifs (secondary) is mounted, uid is set for the user who owns the files
and directories on the filesystem.
2013-12-13 17:32:34 +05:30
db2b8d9b0d
CLOUDSTACK-5311: Fix the host version reported by the hyper-v agent. Also updated the hypervisor
...
capabilities for hyper-v.
2013-12-13 10:28:17 +05:30
be5e5cc641
All Checkstyle problems corrected
2013-12-12 12:26:07 -08:00
ffd1a078d4
CLOUDSTACK-5462: Hyperv agent confused by existing volume of different
...
image type. Works by avoiding volume image format inference errors and
removing existing files with same name, but different format.
2013-12-12 14:56:37 +05:30
bdbc5f2ae3
CLOUDSTACK-5473: Fixed the name with which the hyper-v agent gets
...
installed as a service.
2013-12-12 14:56:29 +05:30
78b39bbe12
CLOUDSTACK-5455: Fix detach iso on hyperv. Made sure normalized path is
...
used while attaching and detaching iso. Also made normalization of path
across the agent code.
2013-12-11 19:42:36 +05:30
2b1d997728
CLOUDSTACK-5248: Fixed creation of mount point when running as non root (cloud) user.
...
The systemvm iso file is copied only when a systemvm or router vm is to be started on
a host. The file gets copied to the secondary storage. The mount point used is the one
that has permissions for regular user to mount a share.
CLOUDSTACK-5275: The failure was because a secondary storage wasn't available when the
host was added. When a setup is done through wizard the hosts get added before the
secondary storage. CS was tying to copy yhe systemvm iso to secondary and it used to
fail if it wasn't available. Made a change to copy the iso only when a systemvm is
being started on a host.
CLOUDSTACK-5202: Made changes to clean up mount points on stop and start.
All the three are related fixes; so putting a fix in one commit.
2013-12-11 17:50:13 +05:30
1f67ebc297
Fix nuget package path error.
2013-12-09 13:23:20 +05:30
462e6d91c1
Fix the directory path of where the nuget packages get downloaded.
2013-12-09 11:10:51 +05:30
0b16a45ceb
Modified savepassword.sh path in Hyperv Resource according to the new template
2013-12-05 11:45:54 +05:30
bd6f706b72
CLOUDSTACK-5261: added support for Alert publishing via ROOT Admin API
...
Conflicts:
engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
engine/storage/image/src/org/apache/cloudstack/storage/image/TemplateServiceImpl.java
engine/storage/volume/src/org/apache/cloudstack/storage/datastore/provider/DefaultHostListener.java
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/discoverer/HypervServerDiscoverer.java
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java
server/src/com/cloud/alert/AlertManagerImpl.java
server/src/com/cloud/alert/ConsoleProxyAlertAdapter.java
server/src/com/cloud/alert/SecondaryStorageVmAlertAdapter.java
server/src/com/cloud/configuration/ConfigurationManagerImpl.java
server/src/com/cloud/ha/HighAvailabilityManagerExtImpl.java
server/src/com/cloud/ha/HighAvailabilityManagerImpl.java
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
server/src/com/cloud/resourcelimit/ResourceLimitManagerImpl.java
server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java
server/src/com/cloud/vm/UserVmManagerImpl.java
usage/src/com/cloud/usage/UsageAlertManagerImpl.java
usage/src/com/cloud/usage/UsageManagerImpl.java
listAlerts: introduced new parameter "name" to the alertResponse
Conflicts:
api/src/org/apache/cloudstack/api/command/admin/resource/ListAlertsCmd.java
server/src/com/cloud/alert/AlertManagerImpl.java
usage/src/com/cloud/usage/UsageAlertManagerImpl.java
Added new Admin API - generateAlert. Available to ROOT admin only
Conflicts:
api/src/org/apache/cloudstack/alert/AlertService.java
api/src/org/apache/cloudstack/api/BaseCmd.java
usage/src/com/cloud/usage/UsageAlertManagerImpl.java
listAlerts: implemented search by alert name
Conflicts:
api/src/org/apache/cloudstack/alert/AlertService.java
api/src/org/apache/cloudstack/api/command/admin/resource/ListAlertsCmd.java
engine/schema/src/com/cloud/alert/AlertVO.java
2013-12-04 10:05:46 -08:00
13740ac135
CLOUDSTACK-5178: DeployVm from ISO fails. Fixed the creation of root
...
volume and made sure the iso is attached when a vm is deployed.
2013-12-04 20:36:49 +05:30
3f8741a4ec
Changes for fixing the hyperv agent build on windows using mono.
2013-12-04 12:21:36 +05:30
d26b9ac00e
Fix for live migration of vm. Use the host name as the migration
...
destination. Also mapped the vm state corrected in check vm on host
answer.
2013-12-04 10:31:02 +05:30
5a96307fbf
Changes for allowing migration of a vm on hyperv. Migration was blocked in cloudstack for hyperv.
...
Enabled it. Also updated the agent code to allow hyperv migration.
2013-12-04 10:29:36 +05:30
cc86599c4d
adding missing license headers for cs files
2013-12-03 15:53:39 +05:30
30db5d648b
code to install and uninstall agent as windows service
2013-12-03 12:17:56 +05:30
1d3a4f4645
Fixed issues on HyperV Agent code for shared network VR issues
2013-12-03 12:17:32 +05:30
4d187192b3
Fix VM stats collections in HyperV
2013-12-03 12:16:53 +05:30
875e1ea281
Added contextMap data to all the command responses in HyperV
2013-12-03 12:14:56 +05:30
c781e3b668
Fixing creation of VM with virtual disks on a shared storage for hyperv. The shared storage
...
path wasn't getting interpreted correctly by the agent.
2013-11-27 13:04:16 +05:30
433a631916
Reformat of source code to set a stable base for the future. I couldn't get checkstyle enabled. There's still about a thousand errors from checkstyle. Most of it from length errors from comments and strings. Will attempt to remove those tonight. This change is so large I just want to get it in before any merge nightmares. The changes are fairly minor though and I did a full compile and start a server with the reformat code.
2013-11-21 07:56:47 -08:00
Anshul Gangwar
Hugo Trippaers
Anthony Xu
Santhosh Edukulla
Devdeep Singh
Rajesh Battala
Sheng Yang
Koushik Das
Daan Hoogland
Alena Prokharchyk
Saksham Srivastava
Alex Huang
Sateesh Chodapuneedi
Donal Lafferty