Daan Hoogland
871ba9c521
findbugs: ignored return value should have been returned down stack
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
This closes #494
2015-06-20 00:57:01 +02:00
Daan Hoogland
0952580096
findbugs: try-with-resource to circumvent not handling an exception on
...
close
2015-06-17 12:41:04 +02:00
Daan Hoogland
6da6c5f762
findbugs: log unhandled exception as warning
2015-06-17 12:35:39 +02:00
Daan Hoogland
41c1fddaee
findbugs: better message and fallback to defaultCharset
2015-06-16 11:57:15 +02:00
Rafael da Fonseca
0851e4e54b
Catch encoding exception
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #464
2015-06-16 11:24:51 +02:00
Rafael da Fonseca
9f2ebdf443
Fix findbugs encoding issue in VmwareStorageProcessor.java Any encoding would do fine as it's just used to generate a UUID. Sticking with UTF-8 for consistency
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #460
2015-06-16 08:56:33 +02:00
Rafael da Fonseca
9bb920af65
Fix findbugs warning in VmwareStorageManagerImpl.java Any encoding would do fine as it's just used to generate a UUID. Sticking with UTF-8 for consistency
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #461
2015-06-16 08:53:56 +02:00
Rafael da Fonseca
3d48af41a8
Fix findbugs encoding issue in VmwareResource.java Key file should be UTF-8 encoded in VR
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #462
2015-06-16 08:51:54 +02:00
Rafael da Fonseca
85ad1b7e0f
Fix 3 findbugs encoding warnings in VmwareStorageProcessor.java Ova templates and metadata should be written to file in UTF-8 Fix warning in UUID generation
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #411
2015-06-15 12:09:13 +03:00
Rafael da Fonseca
967da97f51
Fix 2 findbugs warnings in VmwareStorageManagerImpl.java Template files and metadata should be written to file in UTF-8
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #410
2015-06-15 12:06:19 +03:00
Rafael da Fonseca
11fec86ba3
Fix 1 findbugs warning in VmwareResource.java
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #409
2015-06-15 12:06:11 +03:00
Rafael da Fonseca
474065e98b
Fix findbugs encoding warning in VmwareServerDiscoverer.java Input string should only contain safe characters, since it's derived from a Long object. This just gets rid of the findbugs warning
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #408
2015-06-15 12:06:01 +03:00
Sateesh Chodapuneedi
5e41a830a5
This closes #373
...
CLOUDSTACK-3317 - DVS does not support management\storage network
Added support for Management and Storage Network traffic over VMware DVS in CloudStack deployments. Also added support for storage VLAN over dvPortGroup.
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
CLOUDSTACK-3317 - DVS does not support management\storage network
Use non-zero dvport count while updating dvportgroups of system traffic.
Updated configuration compare logic to avoid update dvportgroup operation unless required.
This would help improve speed in vm/network deployment as the update calls would reduce. Also improved logging.
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
Adding unit tests in class HypervisorHostHelperTest
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
Added license header to new file being added to repo/branch.
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2015-06-10 02:07:40 +05:30
Daan Hoogland
b272d7717e
Revert "Fix 2 findbugs high priority warnings"
...
This reverts commit 1ca74dac26 .
2015-06-08 10:01:19 +02:00
Rafael da Fonseca
e8c7069f73
Fix findbugs high priority warning VmwareStorageManagerImpl.java:1023, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE, Priority: High Redundant nullcheck of datastoreVolumePath, which is known to be non-null in com.cloud.hypervisor.vmware.manager.VmwareStorageManagerImpl.getVolumePathInDatastore(DatastoreMO, String)
...
Assertion is not used in runtime, correct way is throw and handle exception without killing app
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #362
2015-06-08 09:40:50 +02:00
Rafael da Fonseca
38c269d71e
Fix performance issue reported by findbugs (unnescessary boxing/unboxing) VmwareResource.java:693, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High VmwareResource.java:4769, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High Boxing/unboxing to parse a primitive com.cloud.hypervisor.vmware.resource.VmwareResource.getNetworkStats(String)
...
Now op is faster and takes up less memory
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #365
2015-06-08 09:32:52 +02:00
Rafael da Fonseca
1ca74dac26
Fix 2 findbugs high priority warnings
...
VmwareResource.java:315, MS_SHOULD_BE_FINAL, Priority: High
com.cloud.hypervisor.vmware.resource.VmwareResource.s_serviceContext isn't final but should be
VmwareResource.java:331, MS_SHOULD_BE_FINAL, Priority: High
com.cloud.hypervisor.vmware.resource.VmwareResource.s_powerStatesTable isn't final but should be
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #363
2015-06-08 09:24:07 +02:00
Likitha Shetty
04365601da
CLOUDSTACK-8412. VM migration with storage fails.
...
Update MigrateWithStorageCommand to avoid JSON deserialization error.
2015-04-28 10:22:00 +05:30
Likitha Shetty
f45e6b94ed
CLOUDSTACK-8405: Restore VM results in deletion of data disk.
...
Dont evict template when a delete command has been sent to VMware resource for deletion of volume.
2015-04-27 16:37:46 +05:30
Rohit Yadav
06e353e5c7
vmware: support vmfs as local storage pool type
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit 752d784d92 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-04-16 17:36:52 +05:30
Rohit Yadav
7949d2922d
vmware: plugin improvements
...
- use sticky chmod 1777 on the mountpoint
- remove dead code
(cherry picked from commit eea716b791 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-04-13 15:49:01 +05:30
Rohit Yadav
37820e15f2
CLOUDSTACK-7593: allow nic type to be fetched from vm's details
...
(cherry picked from commit 43db75c319 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Conflicts:
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
2015-04-13 15:47:03 +05:30
Daan Hoogland
6a821730ce
Boolean -> boolean
2015-03-25 22:20:40 +01:00
Daan Hoogland
048212b117
findbugs: Boolen function should not return null
2015-03-25 21:46:47 +01:00
Rajani Karuturi
843f6b1691
CLOUDSTACK-5236 : ability to identify where the user is from (ex. LDAP)
...
Added a source column to the user table.
Source now has only two values UNKNOWN,LDAP with UNKNOWN being the
default and is an enum is com.cloud.User.
When the source is UNKNOWN, the old method of authenticating against all
the available authenticators is used. If a source is available, only
that particular authenticator will be used.
added overloaded methods in AccountService to createUserAccount and
createUser with source specified.
(cherry picked from commit 5da733072e )
2015-03-16 14:53:53 +05:30
Sanjay Tripathi
3d411dc616
Fixed simulator and vmware NPE issue.
2015-03-13 14:59:34 +05:30
Likitha Shetty
bdd28a45ed
CLOUDSTACK-8319. For both 'MigrateVolume' and 'MigrateVMWithVolumes, ensure VM's vconfiguration files are migrated along with VM's root volume.
2015-03-12 11:57:02 +05:30
Likitha Shetty
adc836cc5e
CLOUDSTACK-8318. Storage vMotion support for VMFS.
...
MigrateVMWithVolumes-
1. If ESXi host version is below 5.1, ensure destination datastore(s) is mounted on the source host, then migrate the storage and then finally migrate the VM.
If destination storage(s) is not mounted on the source host,
- In case of NFS storage mount the storage(s).
- In case of VMFS storage fail the request for migration.
2. If EXi host version is 5.1 or above, simultaneously migrate the VM and its storage to the destination host and storage(s) respectively for both NFS and VMFS storage.
2015-03-12 11:57:01 +05:30
punith-cloudbyte
ff7ef985f1
NFS support for VMware-managed storage
...
Signed-off-by: Mike Tutkowski <mike.tutkowski@solidfire.com>
2015-03-05 17:39:10 -07:00
Likitha Shetty
25a4f0dc53
CLOUDSTACK-8136. [VMware] Create VM snapshot fails if a previous attempt to take the snapshot failed.
...
While looking for an ongoing VM snapshot task, check the task status to identify if the task is still running.
2014-12-30 14:19:48 +05:30
Likitha Shetty
13bdc1cef4
CLOUDSTACK-8134. Worker VMs don't have MS id set in vCenter annotation 'cloud.vm.workertag'.
...
Correctly register node info for a newly created VMware context.
2014-12-30 11:52:56 +05:30
Likitha Shetty
15b348632d
CLOUDSTACK-8129. Cold migration of VM across VMware DCs leaves the VM behind in the source host.
...
If VM has been cold migrated across different VMware DCs, then unregister the VM from source host.
2014-12-26 11:07:30 +05:30
Likitha Shetty
5227ae2275
CLOUDSTACK-8128. VM with Datadisk fails to start when storage is put into maintenance.
...
While migrating a volume from primary to seocndary use a worker VM to perform the operations if the VM associated with the volume is stopped.
2014-12-24 16:57:37 +05:30
Likitha Shetty
974b0180dd
CLOUDSTACK-8126. Cold Migration of VM is not working as expected. In case a VM is cold migrated across clusters then VM fails to start.
...
1. If a VM by the same name exists on a different cluster in the VMware DC, unregister the existing VM and continue with the VM start.
2. If VM start succeeds, delete VM files associated with the unregistered VM.
3. If VM start fails, re-register the unregistered VM.
2014-12-24 15:07:08 +05:30
Likitha Shetty
1c0bf32170
CLOUDSTACK-8123. VM re-install fails.
...
While moving root disk into VM folder during restore, look for folder based on vCenter name.
2014-12-24 14:01:20 +05:30
Likitha Shetty
ac491c9607
CLOUDSTACK-8121. Data disk properties are not updated upon Creation/Deletion of VM snapshots.
...
Update the path and size of data volumes after snapshot creation/deletion by correctly trimming only the snapshot postfix of a disk.
2014-12-24 13:04:12 +05:30
Likitha Shetty
4d7ede535d
CLOUDSTACK-8119. Propagate error message to UI for attach/detach volume failure operations.
...
For AttachVolume/DetachVolume API command, improve user error message in case of RuntimeException by throwing the exception instead of 'Unexpected Exception'.
2014-12-24 11:29:03 +05:30
Likitha Shetty
ddcae8a930
CLOUDSTACK-8118. Root volume migration fails with 'No such disk device' in case of vCenter 5.5 setup.
...
If an exact match is being done while locating disk chain by name, don't trim snapshot postfix appended to the disk name.
2014-12-24 10:19:22 +05:30
Likitha Shetty
cb211f18d1
CLOUDSTACK-8113. VM migration fails with "Message: No such disk device: " error.
...
Consolidate VM disks once VM/volumes are migrated.
2014-12-23 14:28:17 +05:30
Likitha Shetty
33179cce56
CLOUDSTACK-8112. CS allows creation of VM's with the same Display name when vm.instancename.flag is set to true.
...
Before registering a VM check if a different CS VM with same name exists in vCenter.
2014-12-23 13:48:01 +05:30
Likitha Shetty
647532376f
CLOUDSTACK-8111. NFS secondary storage repetitively mounted on CS server with ESXi hypervisors.
...
Fix cleanup of NFS mounts on management server during server starup by correcting how mount points are listed for a management server.
2014-12-23 13:23:43 +05:30
Likitha Shetty
51ee90074d
CLOUDSTACK-8110. VM name in vCenter should be VM's DisplayName if global config 'vm.instancename.flag' is set.
2014-12-23 11:42:26 +05:30
Likitha Shetty
507d9d337d
CLOUDSTACK-8109. Extract Template is failing.
...
Fix the OVA path that is returned once an OVA is packaged using a META file.
2014-12-23 10:44:10 +05:30
Saksham Srivastava
1df0453d27
CLOUDSTACK-8088: VM scale up is failing in vmware with Unable to execute ScaleVmCommand due to java.lang.NullPointerException
2014-12-18 14:27:55 +05:30
Sateesh Chodapuneedi
aa84b05491
CLOUDSTACK-5933 Problem with VMware snapshot when datastore has a space in its name
...
Handling spaces in datastore name while extracting vmdk base name
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2014-12-09 05:34:41 +05:30
Sateesh Chodapuneedi
bca015306e
CLOUDSTACK-7803 Storage live migration of instance may not happen if instance has ISO attached.
...
BUG-ID:CLOUDSTACK-7803
Summary:Ensure secondary storage is mounted on target host.
Reviewed-By:Rajesh
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2014-12-09 03:27:31 +05:30
Mike Tutkowski
3ac8f8d601
Fixing an issue related to figuring out the name of a datastore that is backed by managed storage
2014-12-08 14:26:31 -07:00
Harikrishna Patnala
9585aa0b51
CLOUDSTACK-6465: vmware.reserve.mem is missing from cluster level settings
...
Signed-off-by: Rajani Karuturi <rajanikaruturi@gmail.com>
(cherry picked from commit eae733817b )
2014-11-25 15:55:54 +05:30
Laszlo Hornyak
3577423da9
removed executable flags from java classes
...
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-11-23 19:49:01 +01:00
Saksham Srivastava
4ff3130bec
CLOUDSTACK-7950: AttachIsoCmd shoud give correct messge when trying to attach vmwaretools installer iso on non supported guestvm deployed by ISO
2014-11-20 13:04:14 +05:30
Santhosh Edukulla
ef6ec7b276
Fixed few coverity issues like invalid boxing unboxing issues, resource leaks, null dereferences
2014-11-13 17:26:24 +05:30
Likitha Shetty
b8fdda0a34
BUG-ID: CLOUDSTACK-7102. Volume migration fails with 'VM i-2-3-VM does not exist in VMware datacenter' expection.
...
Look for a VM in vCenter based on both the vCenter name and CS internal name (required in case 'vm.instancename.flag' is enabled).
During Attach Volume and Volume Migration, for lookup and other operations use VM's name as obtained from vCenter instead of using the name set in the agent command.
2014-11-13 12:58:56 +05:30
Bharat Kumar
ea99ff1c86
CLOUDSTACK-7763 Reservations for VMware VMs remain after dynamic scaling
2014-11-10 14:30:42 +05:30
Santhosh Edukulla
1aef5cba66
Fixed Coverity Issues
2014-11-03 16:45:30 +05:30
amoghvk
efc9632c1b
CLOUDSTACK:6915 search including removed
2014-10-31 15:47:18 -07:00
Hugo Trippaers
4ebaf0a583
Bump master version to 4.6.0-SNAPSHOT after branching 4.5.0-SNAPSHOT
2014-10-29 14:54:23 +01:00
Mike Tutkowski
0cea0346ae
Support for back-end snapshots on primary storage
2014-10-21 16:01:14 -06:00
Santhosh Edukulla
0a9742f914
Fixed few coverity issues
...
Signed-off-by: Santhosh Edukulla <santhosh.edukulla@gmail.com>
2014-10-14 17:16:50 +05:30
Frank Zhang
49c01e2ae4
Don't do chmod -R when mounting secondary storage for vmware
...
It causes extreme long vm start time when managment server has slow connection to secondary storage
2014-10-13 12:06:37 -07:00
Edison Su
d233f39c82
disable parallel for xenserver. Also for vmware, if full.clone is enabled and migratecommand will have the behavor of start/stop command
2014-10-09 17:14:57 -07:00
Edison Su
6a5e4306f2
fix build
2014-10-09 16:38:23 -07:00
Edison Su
15a2ea7c7e
vmware resource code needs to honor the timeout value send
2014-10-09 16:28:20 -07:00
Nitin Mehta
9e7fbae52f
Revert "CLOUDSTACK-7533: Wrong download URL is generated when using multiple SSVMs in a zone. The public ip of the url would sometime point to the wrong ssvm when the url was created on another one."
...
This reverts commit f3b5a6ebc7 .
Reverting since a better fix is available with CLOUDSTACK-6478
2014-10-06 15:00:32 -07:00
Likitha Shetty
65ed25b7a6
BUG-ID: CLOUDSTACK-7662. Resize of detached volume fails.
...
Support offline volume resize on ESX by creating a worker VM to attach the unattached volume to and then resize it.
2014-10-01 15:41:50 +05:30
Likitha Shetty
f1e3e83bbf
BUG-ID: CLOUDSTACK-7653. VM's are not getting deleted from hypervisor after deleting from UI when using zone wide primary storage.
...
While expunging a volume, CS chooses the endpoint to perform delete operation by selecting any host that has the storage containing the volume mounted on it.
Instead, if the volume to be deleted is attached to a VM, the endpoint chosen by CCP should be the host that contains the VM.
2014-09-30 15:20:15 +05:30
Likitha Shetty
6b06970366
BUG-ID: CLOUDSTACK-7652. [VMware] 'SOAPFaultException: The object has already been deleted or has not been completely created' exceptions.
...
If CCP thread local context which is used to handle connections to a vCenter is being re-used, validate that the context corresponds to the right vCenter API session.
2014-09-30 15:20:14 +05:30
Mike Tutkowski
18e5aa116e
Fixing an issue around VMware system templates
2014-09-18 19:38:59 -06:00
Nitin Mehta
f3b5a6ebc7
CLOUDSTACK-7533: Wrong download URL is generated when using multiple SSVMs in a zone. The public ip of the url would sometime point to the wrong ssvm when the url was created on another one.
...
Fix the bug by removing the command CreateEntityDownloadURLCommand from the host delegation. This results in same ssvm for creating the symlink on ssvm and same public ip being used for generating the url on MS.
2014-09-10 17:46:33 -07:00
Hugo Trippaers
dc3f0cbc63
Improve the handling of the findbug exclude files
2014-09-03 10:41:22 +02:00
Likitha Shetty
7dbff9b42c
CLOUDSTACK-7371. [VMware] Enabling primary storage maintenance fails when storages are across cluster.
...
1. While destroying a ROOT volume do the lookup of the associated VM under the DC and not just cluster.
2. In case of VMware, during VM start if a volume is being recreated no need to detach the old volume because
we now expunge it immediately and don't wait for the storage cleanup task to run.
2014-08-20 10:51:18 +05:30
Likitha Shetty
8bb4022f37
CLOUDSTACK-4587. System VMs fail to start when the primary storage that has the System VMs is put into maintenance.
...
During VM start while configuring its disk devices, obtain the matching disk for a volume in storage
using both the volume's path and volume's datastore information.
2014-08-20 10:51:18 +05:30
Sateesh Chodapuneedi
a1d0925f90
CLOUDSTACK-7360 [vmware] Add host to existing cluster fails if the cluster is using Nexus 1000v as backend for atleast one traffic type.
...
While adding host to existing cluster which is using Nexus 1000v as a network backend, skip validation of Nexus VSM as it was already done while adding that cluster.
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2014-08-18 07:18:13 +05:30
Sateesh Chodapuneedi
6a4a11ed71
CLOUDSTACK-7334. [VMware] AddHost command fails if there is a space in the VMware DC/Cluster name.
...
URL decode vCenter path during cluster discovery.
2014-08-13 16:24:14 +05:30
amoghvk
d1d722f9bd
CLOUDSTACK-7295: VMs is Stopped state have no host ID, resulting in NPE
2014-08-11 14:56:58 -07:00
Min Chen
9866c648eb
CLOUDSTACK-7260: Management server not responding after some time for
...
Vmware due to Oom (cannot create native thread).
2014-08-05 17:36:53 -07:00
Likitha Shetty
f803100813
CLOUDSTACK-6969. Data Volume Shrink operation failing with "Unexpected Exception".
...
For ResizeVolume API command -
1. If hypervisor resource throws an exception, handle the NPE thrown by the job framework.
2. Improve user error message in case of RuntimeException by throwing the exception instead of 'Unexpected Exception'.
2014-08-01 16:23:47 +05:30
Sateesh Chodapuneedi
96a6e673a3
CLOUDSTACK-7078 CLONE - [VMWARE]System VM's are failed to start with Nexus enabled Zone Since introducing pool of session contexts we no more have a dedicated context for each VMware hypervisor host. Hence vsm credentials stored in session context cannot be retrieved always correctly. Fix is to register the vsm credentials after fetching context and the context gets recycled after use.
...
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2014-07-31 16:31:41 +05:30
Anthony Xu
ecf100e4ed
fixed build for vmware
2014-07-28 17:37:31 -07:00
Anthony Xu
330c4ba578
completed the new vmsync TODOs in the code.
...
removed old vmsync logic
2014-07-28 12:51:37 -07:00
Likitha Shetty
786285ab54
CLOUDSTACK-7174. [VMware] Recreating System VMs fails if global config 'vm.instancename' is set to true.
...
Append VM's name in vCenter with the hostname only for User VMs.
2014-07-24 13:05:45 +05:30
Hugo Trippaers
1d2124dcbf
Fix NPE reported on IRC, provide the user an informative error message
2014-07-22 17:45:24 +02:00
Likitha Shetty
b3e4c6d6dc
CLOUDSTACK-7150. [VMware] Global config 'vm.instancename' is not honored.
...
If global config 'vm.instancename' is set to true, VM name in vCenter should be '<instance_name>-<vm_hostname>'.
2014-07-22 11:59:53 +05:30
Suresh Ramamurthy
03de9cc335
CLOUDSTACK-6845 : NuageVsp Network plugin
...
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-07-21 10:49:49 +02:00
amoghvk
3d8dd1c921
Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/cloudstack
2014-07-14 17:30:12 -07:00
amoghvk
62e63a1bf7
CLOUDSTACK-6358: Missing patches in master for VMware
2014-07-14 16:54:10 -07:00
Kelven Yang
5143fe404b
When instance.name.flag is set to true, append user-supplied name with legacy prefix to VM name appears in vCenter.
2014-07-14 14:53:51 -07:00
Kelven Yang
362f875a3f
Detach disks before cleaning up of VMware worker VM.
2014-07-08 14:47:22 -07:00
Likitha Shetty
8cf94c9ec1
CLOUDSTACK-7069. [VMware] While setting 'numCoresPerSocket' property for a Virtual Machine in VMware
...
add a check to ensure the vSphere version is 5.0 or above.
2014-07-07 14:36:58 +05:30
Likitha Shetty
4f969057b2
CLOUDSTACK-7030. After the restart of MS in a clustered MS pool, not all hung worker VMs are recycled.
...
Recycle worker VMs that originally belonged to other management servers too because in case of MS restart, the owner MS might change.
2014-07-07 13:38:47 +05:30
Sateesh Chodapuneedi
71f76edf71
CLOUDSTACK-6996 Adding cluster to legacy zone failed
...
Lookup zone_id field in legacy_zones table to search the table for legacy zone.
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2014-06-27 14:01:39 +05:30
Kelven Yang
f756d4aa33
Make job info universally available across management server and resource agents
2014-06-24 16:28:22 -07:00
Mike Tutkowski
42d00cae58
SolidFire (shared-access) Provider
2014-06-16 12:15:29 -06:00
Bharat Kumar
99b4cf788e
Cloudstack-5077: reserve cpu and memory only when vmware.reserve.cpu/mem are set to true. Insted of setting the ovecommit values to one on upgrade, we popultate them from the global values.
...
Conflicts:
engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java
engine/schema/src/com/cloud/upgrade/dao/Upgrade420to421.java
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
2014-05-05 11:39:10 +05:30
Mike Tutkowski
8ac7784db2
CLOUDSTACK-6170 Corrected an issue related to the "Reinstall VM" command and managed storage with VMware
2014-05-02 18:41:59 -06:00
Sateesh Chodapuneedi
5bc72ea250
CLOUDSTACK-6317 [VMware] Tagged VLAN support broken for Management/Control/Storage traffic
...
Check if switch name detected from traffic label for management, storage, control traffic is null before falling back to default value.
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2014-05-02 18:25:29 +05:30
Mike Tutkowski
06bbcde458
Organized an algorithm a bit more
2014-04-25 11:57:54 -06:00
Mike Tutkowski
a7e267b416
CLOUDSTACK-6170 (VMware root-disk support for managed storage)
2014-04-24 15:03:05 -06:00
Mike Tutkowski
db9de2e39b
CLOUDSTACK-6488 Fixed an issue where the "path" field was not being set properly in the DB when the volume had a snapshot taken of it
2014-04-23 18:30:19 -06:00
Mike Tutkowski
523913a315
CLOUDSTACK-6469
2014-04-22 22:52:33 -06:00
Mike Tutkowski
1bb31412fc
CLOUDSTACK-6170 (VMware root-disk support for managed storage)
2014-04-21 22:22:50 -06:00
Mike Tutkowski
c0910cbdb9
CLOUDSTACK-6170 (VMware root-disk support for managed storage)
2014-04-19 10:41:42 -06:00
Sheng Yang
4620c27ebf
CLOUDSTACK-6047: Make aggregation command timeout configurable
...
In case some environments has different performance or we found some commands
would took too long to execute, one global configuration item is introduced to
specify "time out in seconds per one command in aggregation commands".
By default it's 3 seconds. If admin feel it's too long, it can be adjust to as
low as 1 seconds, which runs still well in my machine.
Conflicts:
setup/db/db/schema-430to440.sql
2014-04-18 23:36:19 -07:00
Koushik Das
5e90b75c98
CLOUDSTACK-6402: Fix StopCommand so that VMs are not removed accidentally as part of vmsync
...
Added a new flag 'checkBeforeCleanup' to StopCommand based on which check is done to see if VM is running in HV host.
If VM is running then in this case it is not stopped and the operation bails out.
Also modified the MS code to call the StopCommand with appropriate value for the flag based on the context.
Currently it is only set to 'true' when called from the new vmsync logic based on powerstate of VM. For rest it
is set to 'false' meaning no change in behaviour.
2014-04-14 16:52:37 +05:30
Mike Tutkowski
06c0486d0b
CLOUDSTACK-6170 (VMware root-disk support for managed storage)
2014-04-01 00:09:53 -06:00
Mike Tutkowski
21455222e4
CLOUDSTACK-6170 (VMware root-disk support for managed storage)
2014-03-31 21:20:43 -06:00
Mike Tutkowski
1577e75a3d
CLOUDSTACK-6170 (VMware root-disk support for managed storage)
2014-03-31 00:13:30 -06:00
Mike Tutkowski
0879ab812e
CLOUDSTACK-6170 (VMware root-disk support for managed storage)
2014-03-28 13:15:04 -06:00
Daan Hoogland
8b62b2cb92
findbugs: exclude known spiffy hacks a.k.a. false positives
2014-03-28 14:28:10 +01:00
Anthony Xu
6de28bb1a4
in XenServer, host eject may fail due to diffent reasons, it's hard for CS to handle all failure.
...
in CS, removing a host means CS will not manage the host, admin needs to eject the host from XS pool outside of CS
2014-03-26 14:22:49 -07:00
Sheng Yang
1d3a6eaa50
CLOUDSTACK-6047: Fix timeout issue when try to execute aggregated commands
...
Add executeInVR() with timeout interface to VirtualRouterDeployer
AggregationControlCommand with Action.Finish may take longer than normal command
since it would execute all the commands in one execution, and it may result in
SSH timeout for SshHelper or other mechanism communicate with VR.
Introduce an new executeInVR() interface with added timeout period for waiting
FinishAggregationCommand to complete execution.
2014-03-18 17:43:59 -07:00
Hugo Trippaers
4402685e11
Update master to 4.5.0-SNAPSHOT
2014-03-14 14:55:26 +01:00
Kelven Yang
5a75a3e1f9
Give graceful state transition period to live with race-condition on VM startup time
2014-03-13 16:59:56 -07:00
Alena Prokharchyk
6c23e201ad
1) More fixes for the problems found by findBugs
...
2) Corrected some logging in MidoNetPublicNetworkGuru - removed .toString method call on the objects in the log body as toString is called on the object by default when use log4j
2014-03-13 16:05:45 -07:00
Alena Prokharchyk
466825a167
Fixed nonoss build
2014-03-10 15:29:18 -07:00
Anthony Xu
ab1d3af460
Use seperate path to sync VM metadata for XS
...
VM status sync only does VM status sync
2014-03-05 15:44:50 -08:00
Mike Tutkowski
b06e66c50a
CLOUDSTACK-6170
2014-03-05 13:55:12 -07:00
Kelven Yang
57a00a8172
Let ESX host timeout to reflect disconnect status in vCenter into CloudStack.
2014-02-28 15:35:59 -08:00
Kelven Yang
24e64ac62a
let PingTestCommand support host-ping in addition to ping user VM via VR. Reviewed-By: self
2014-02-28 15:35:59 -08:00
Likitha Shetty
88b5761647
CLOUDSTACK-6146. [VMware] [ESXi 5.5] Live VM migration of an already migrated VM (with storage) across clusters fails
...
In vCenter 5.5, once a volume is migrated the VMDKs are renamed to match the name of the VM.
Update volume path for every volume belonging to the VM to the corresponding new disk filename.
Conflicts:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
plugins/hypervisors/vmware/src/org/apache/cloudstack/storage/motion/VmwareStorageMotionStrategy.java
2014-02-26 13:45:44 +05:30
Likitha Shetty
0926bf57f4
CLOUDSTACK-6146. [VMware] [ESXi 5.5] Live storage migration of an already migrated volume fails
...
In vCenter 5.5, once a volume is migrated the VMDKs are renamed to match the name of the VM.
If a volume has been renamed upon migration update its volumePath to that of the new disk filename.
Conflicts:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java
2014-02-26 13:45:43 +05:30
Mandar Barve
b0c6d47347
- Updated APICommand annotation to add new flags that indicate if API request or response carry sensitive info - Updated all API classes with the new annotation flag values as per the API's sensitivity - Updated server code to check response annotation before audit logging
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
(cherry picked from commit df270d6387c362b960064ee5123c14782e767a19)
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-02-25 22:59:10 +01:00
Sheng Yang
5332f67ae8
CLOUDSTACK-6047: Make sure every commands to VR resource is NetworkElementCommand
2014-02-19 19:46:49 -08:00
Nitin Mehta
c969aa2595
CLOUDSTACK-6134:
...
If volume already exists for the vm - register the vm in the inventory and start it.
2014-02-18 18:24:33 -08:00
Hugo Trippaers
d4d49578dc
Findbugs : Fix a number of potential NPEs and minor findings
2014-02-14 18:37:45 +01:00
Likitha Shetty
db91e54bf3
CLOUDSTACK-6112. Adding VPC router to a guest network fails with StringIndexOutOfBoundsException.
2014-02-14 17:01:27 +05:30
Marcus Sorensen
7064972997
Fix someone's broken push due to bad checkstyle (VMwareGuru.java unused imports)
2014-02-12 16:26:33 -07:00
Likitha Shetty
9f597ef130
CLOUDSTACK-6056. Enabling static NAT rule for a portable public IP fails with error "Failed to enable static nat".
...
router.extra.public.nics isn't being honoured and so when an ip that is acquired from the additional VLAN range
is being configured it failed.
2014-02-12 15:53:45 +05:30
Alex Huang
7f34282dfa
Removed references to secondarystoragevmmanager from code that doesn't use it.
2014-02-05 01:39:15 +00:00
Min Chen
929099518d
Fix trailing whitespace.
2014-02-04 15:42:39 -08:00
Min Chen
39efee285f
CLOUDSTACK-6027:CreateVolume from snapshot is failing with S3 on Vmware.
2014-02-04 15:08:28 -08:00
Min Chen
9b21da65d1
CLOUDSTACK-6025:CreateTemplate from snapshot in NFS is failing , after
...
migarting to S3 datastore.
2014-02-04 11:01:51 -08:00
Min Chen
30695d7f93
CLOUDSTACK-6019:CreateVolume from snapshot in NFS is throwing Warning
...
"sync snapshot from cache to region wide store failed for image store
test".
2014-02-03 16:41:04 -08:00
Likitha Shetty
06f79a881c
CLOUDSTACK-5994. Hitting IndexOutOfBoundsException in GetVmStatsCommand after upgrade.
...
To obtain network read/write statistics, multiply sample duration with the
average of the particular performance metric obtained over the sample period.
2014-01-30 18:31:38 +05:30
Hugo Trippaers
3bd38eb17e
Findbugs finding : Incorrect use of equality
2014-01-28 08:58:28 +00:00
Likitha Shetty
4583bac05b
CLOUDSTACK-5796. [VMware] Size column is not getting updated in snapshot_store_ref table when a snapshot is backed up in secondary storage.
...
Calculate and update the size of a backed up snapshot. This snapshot size is in turn used to update the secondary_storage count for an account.
2014-01-28 09:21:05 +05:30
Sheng Yang
3c955c3659
CLOUDSTACK-5779: Make VmwareResource use VirtualRoutingResource
2014-01-24 19:57:52 -08:00
Sheng Yang
2d3022594c
CLOUDSTACK-5779: Generalize calling to execute or create file for Vmware
2014-01-24 18:28:00 -08:00
Sheng Yang
2d100f1269
CLOUDSTACK-5779: Generalize calling to execute or create file for Xen
2014-01-24 18:27:55 -08:00
Hugo Trippaers
5e0d61bf98
Findbugs finding: Fix object comparison with == instead of equals
2014-01-23 15:53:26 +00:00
Hugo Trippaers
532bf4b190
Get rid of compiler warnings and dead code in plugin-hypervisor-vmware
2014-01-22 09:55:38 +01:00
Sheng Yang
1767ddac77
CLOUDSTACK-5779: Update vmdata command in Vmware
...
To use Gson rather than copy a file to it, follow the same as Xen and KVM.
2014-01-21 18:59:30 -08:00
Sheng Yang
d4e069ecc8
Fix noredist build issue
...
Introduced by:
commit ac65f8fddf
Author: Hugo Trippaers <htrippaers@schubergphilis.com>
Date: Mon Jan 20 18:03:02 2014 +0100
CLOUDSTACK-5884 make getTargetSwitch(NicTO nicTo) do all the work to select
switch name, type and vlan token. Change preference to use the tags set on the
physical network.
2014-01-21 11:31:40 -08:00
Sheng Yang
e88cc488e5
CLOUDSTACK-5779: Move loadbalancer to use routerProxy
2014-01-20 18:48:46 -08:00
Hugo Trippaers
ac65f8fddf
CLOUDSTACK-5884 make getTargetSwitch(NicTO nicTo) do all the work to select switch name, type and vlan token. Change preference to use the tags set on the physical network.
...
Conflicts:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
2014-01-20 18:09:01 +01:00
Mike Tutkowski
37332ad9d4
CLOUDSTACK-5873: [Automation] Failed to attach volume to VM, if the vm is created with option startvm=false
2014-01-18 18:07:10 -07:00
Sheng Yang
0ea1c7dfc4
CLOUDSTACK-5779: Move firewall to use routerProxy
2014-01-17 12:36:42 -08:00
Sheng Yang
ce67e24d0a
CLOUDSTACK-5779: Move ipAlias to use routerProxy
2014-01-17 12:36:42 -08:00
Likitha Shetty
008b029a29
CLOUDSTACK-5891.[VMware] If a template has been registered and "cpu.corespersocket=X" template details have been added for it,
...
then any instance deployed from that template should have X cores per socket
2014-01-17 11:00:48 +05:30
Sheng Yang
0cdf0f6f67
CLOUDSTACK-5779: Moving bumpUpPriority, edithosts.sh, dnsmasq.sh to use routeProxy
2014-01-16 16:03:09 -08:00
Likitha Shetty
a957d52a3c
CLOUDSTACK-5707. Hitting multiple 'User unauthenticated' exceptions when vCenter is upgraded to 5.5 from 5.1.
...
We hit these excptions whenever a management server held session that was with the old 5.1 vCenter server
is used to make resource calls to the new 5.5 vCenter.
Validate a vCenter session context before it is being used to make a resource call.
And if the context is invalid then discard the context and retrieve a new one.
During the invalidation of an old context handle the context disconnect better
by catching the appropriate exception and returning a newly created context.
Conflicts:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareContextFactory.java
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareSecondaryStorageResourceHandler.java
vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareContext.java
2014-01-14 09:38:50 +05:30