Rajani Karuturi
dd1a8da977
volume upload: Volume entry created in DB even though GetUpload* API fails with "No ssvm present" error
...
Signed-off-by: Rajani Karuturi <rajanikaruturi@gmail.com>
2015-02-27 17:42:32 +05:30
Rohit Yadav
a75ff23131
CLOUDSTACK-8273: fix baremetal account creation
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit e000646790 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Conflicts:
plugins/hypervisors/baremetal/src/com/cloud/baremetal/manager/BaremetalVlanManagerImpl.java
2015-02-27 15:55:09 +05:30
Rohit Yadav
e000646790
CLOUDSTACK-8273: fix baremetal account creation
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-27 15:52:25 +05:30
Rohit Yadav
d8e1bf1506
CLOUDSTACK-7089: don't log VNC password
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit e287de9fd9 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-26 18:11:12 +05:30
Rohit Yadav
e287de9fd9
CLOUDSTACK-7089: don't log VNC password
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-26 18:10:23 +05:30
Rohit Yadav
4dde4106c0
server: Add missing import, fixes build
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-26 17:49:55 +05:30
Rohit Yadav
6df2fe7a8a
CLOUDSTACK-8273: refactor baremetal user name to utils, restrict baremetal user
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit cb08707add )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Conflicts:
server/src/com/cloud/user/AccountManagerImpl.java
2015-02-26 17:47:01 +05:30
Rohit Yadav
cb08707add
CLOUDSTACK-8273: refactor baremetal user name to utils, restrict baremetal user
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-26 17:42:21 +05:30
Rohit Yadav
e1827fc696
CLOUDSTACK-8285: check and update IP capacity states based on allocation state
...
- Backend should update if state was diabled and now has changed
- UI's fetch latest does not actually fetch latest
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit 985a61652e )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-25 16:47:40 +05:30
Rohit Yadav
985a61652e
CLOUDSTACK-8285: check and update IP capacity states based on allocation state
...
- Backend should update if state was diabled and now has changed
- UI's fetch latest does not actually fetch latest
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-25 16:46:12 +05:30
Rohit Yadav
4f9bc70b1f
CLOUDSTACK-8282: startSystemVM should override consoleproxy.start setting
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit b462a56f27 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-25 14:30:13 +05:30
Rohit Yadav
b462a56f27
CLOUDSTACK-8282: startSystemVM should override consoleproxy.start setting
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-25 14:21:11 +05:30
Koushik Das
dc870b5114
volume upload: Size is listed as zero for uploaded volumes
...
Updating the virtual size for template/volume when upload is completed.
2015-02-19 17:13:47 +05:30
Koushik Das
075c841052
volume upload: cannot delete a volume in NotUploaded state Added exception handler in the upload status monitor thread.
2015-02-17 12:31:41 +05:30
Koushik Das
d19ea5226a
volume upload: Use volume/template UUID instead of ID in UploadStatusCommand
2015-02-17 12:31:40 +05:30
Rajani Karuturi
b616894c21
volume upload: fixed issues during request validation
...
adding the encoded metadata to the signature
2015-02-17 11:50:58 +05:30
Rajani Karuturi
5c4fd12a9b
volume upload: using the timeout from configuration
...
removed the hardcoded 60 min
2015-02-17 11:33:29 +05:30
Rajani Karuturi
812a140d17
volume upload: returning only the first payload incase of templates
...
Cross zone copy will be intiated by the management server.
2015-02-17 11:32:40 +05:30
Rajani Karuturi
3814677977
volume upload: getUploadParamsForVolume url has IP address instead of hostname, SSL fails
2015-02-17 11:31:44 +05:30
Rohit Yadav
2580edbcfb
CLOUDSTACK-7908: UserVmResponse returns userid/username information of the creator
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-16 16:12:22 +05:30
Rohit Yadav
1a6df6f978
CLOUDSTACK-7908: Add user_id column to vm_instance table
...
Design Document:
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Allow+VM+listing+by+User+ID
- Adds column to VMInstance DAO
- Adds column in vm_instance table
- Adds column in the UserVMJoinVO
- Adds default admin user which has UID = 2
- Adds migration path that sets user_id to first user of the accountId that
owns the vm in vm_instance table
- Add arg on list VMs API to query by userId, add support in query layer
- Refactor VMInstanceVO and child classes to accept userId
- Add code to let service layer pass userId if loggedIn user belongs to same
account as the owner executing an API call or use first user from owner account
- In case of CPVM and SSVM use system user ID
- Fix unit tests and spring injections
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-16 15:02:38 +05:30
Santhosh Edukulla
78bfaa79cf
Fixed few coverity issues like invalid boxing unboxing issues, resource leaks, null dereferences
...
(cherry picked from commit ef6ec7b276 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-06 16:50:20 +05:30
Sheng Yang
405ed3ca50
CLOUDSTACK-7605: Fix basic zone multiple pod network restart with cleanup=true
...
1. getRouters() doesn't handle RestartNetwork with cleanup=true for basic zone,
because pod wouldn't be specific at the time.
2. The regression caused by the following fix. The variable "routers" was
overrided with some local values, result in only one of the routers in multiple
pods would return, thus only one router would be started.
commit 6dd5c3fd42
Author: Rohit Yadav <bhaisaab@apache.org>
Date: Thu Oct 11 18:30:00 2012 +0530
CLOUDSTACK-70: Improve restart network behaviour for basic network
(cherry picked from commit aaeadc5c44 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-06 16:44:19 +05:30
Kishan Kavala
40e296dea4
CLOUDSTACK-7267: For LXC volumes, show unsupported operation error for template creation from ROOT volume
...
(cherry picked from commit e427d0004c )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-06 16:32:35 +05:30
Nitin Mehta
4ea0dcda9b
CLOUDSTACK-7870: When Vm deployments fail and end in error state volume count should be decremented
...
(cherry picked from commit a8b89bea4f )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-06 16:24:06 +05:30
Saksham Srivastava
54d08a8e29
CLOUDSTACK-8091: Stale entry exists for a VM NIC even after an exception while adding a new nic to vm
...
(cherry picked from commit 4821bfffe2 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-06 16:19:46 +05:30
Rohit Yadav
1cf165f86d
ApiResponseHelper: fix NPE when parent of snapshot is null
2015-02-05 17:10:56 +05:30
Rohit Yadav
fae4fdae53
ApiResponseHelper: fix NPE when parent of snapshot is null
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-05 17:02:30 +05:30
Kishan Kavala
7a397cd4ef
For volumes created from template, do not log offering ID in VOLUME.CREATE in usage_event. Moved offering type to DiskOffering interface
...
(cherry picked from commit 9eb8d538dd )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-05 16:37:59 +05:30
Santhosh Edukulla
c25263ba81
Fixed Coverity Issues
2015-02-05 15:59:29 +05:30
Damodar
01cc1b816d
CLOUDSTACK-7792: Usage Events to be captured based on Volume State Machine
...
(cherry picked from commit 781648fb10 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Conflicts:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java
2015-02-05 15:22:21 +05:30
Damodar
8ec6d0471c
CLOUDSTACK-7648: There are new VM State Machine changes introduced which were missed to capture the usage events
...
(cherry picked from commit 50185b7c3a )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Conflicts:
plugins/hypervisors/baremetal/src/com/cloud/baremetal/manager/BaremetalManagerImpl.java
server/src/com/cloud/capacity/CapacityManagerImpl.java
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
2015-02-05 14:56:52 +05:30
Kishan Kavala
6541354a59
Trigger user stats aggregation job at midnight in usage aggregation timezone
...
(cherry picked from commit 4ac96d637c )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Conflicts:
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
2015-02-05 14:33:27 +05:30
Rajesh Battala
782adc106e
CLOUDSTACK-7313 Fixed issues in provisioning vpx in SDX from CS
...
(cherry picked from commit 0f528df228 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-05 13:50:29 +05:30
Santhosh Edukulla
bd190192b9
Fixed Resource Leaks
...
Signed-off-by: Santhosh Edukulla <santhosh.edukulla@gmail.com>
(cherry picked from commit 350ac4c4b0 )
Conflicts:
engine/schema/src/com/cloud/upgrade/dao/Upgrade441to450.java
2015-02-05 13:47:22 +05:30
Anthony Xu
98b416b7f0
fixed NPE
...
(cherry picked from commit c78f14cbc2 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-05 12:10:09 +05:30
Daan Hoogland
b586439c9f
CLOUDSTACK-8197 create MinVRVersion config item
2015-02-03 13:18:15 +01:00
Rohit Yadav
552f2ae60c
CLOUDSTACK-8191: SAML users should have their own accounts
...
(cherry picked from commit 876c78fe1b )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-02 19:58:10 +05:30
Rohit Yadav
876c78fe1b
CLOUDSTACK-8191: SAML users should have their own accounts
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-02 19:56:25 +05:30
Devdeep Singh
0e4d91aa91
CLOUDSTACK-6924. To attach a volume if a volume needs to be moved to another storage
...
pool, the source and destination pools cannot be local and cluster/zone and vice versa.
Cloudstack detects it and throws a exception. However, the end user only sees an
unexpected exception and not the reason for failure. Fixed it by making sure the
reason for the failure is correctly captured and shown to the end user.
(cherry picked from commit cffae8eef0 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Conflicts:
server/src/com/cloud/storage/VolumeApiServiceImpl.java
2015-02-02 14:36:07 +05:30
Likitha Shetty
f00140243c
CLOUDSTACK-8112. CS allows creation of VM's with the same Display name when vm.instancename.flag is set to true.
...
During VM creation, if vm.instancename.flag is set to true and hypervisor type is VMware, check if VM with the same hostname already exists in the zone.
(cherry picked from commit 5f9e4fddf3 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-02 14:30:18 +05:30
Likitha Shetty
272f282a05
CLOUDSTACK-8119. Propagate error message to UI for attach/detach volume failure operations.
...
For AttachVolume/DetachVolume API command, improve user error message in case of RuntimeException by throwing the exception instead of 'Unexpected Exception'.
(cherry picked from commit 4d7ede535d )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Conflicts:
server/src/com/cloud/storage/VolumeApiServiceImpl.java
2015-02-02 13:57:38 +05:30
Likitha Shetty
b9932a0129
CLOUDSTACK-8122. Handle NPE thrown during migration failures.
...
When migration fails instead of returning NULL, throw the exception.
(cherry picked from commit a5a65c7b55 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-02 13:56:43 +05:30
Likitha Shetty
bcbfe3bdee
CLOUDSTACK-8129. Cold migration of VM across VMware DCs leaves the VM behind in the source host.
...
If VM has been cold migrated across different VMware DCs, then unregister the VM from source host.
(cherry picked from commit 15b348632d )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-02 13:51:47 +05:30
Likitha Shetty
8f4aa23ae0
CLOUDSTACK-8127. VM name not displayed after attaching data disk to a VM.
...
If user hasn't supplied a display name for a VM, default it to VM name in listVolume response.
This behaviour is identical to listVirtualMachine response.
(cherry picked from commit ff7997a2b1 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-02 13:01:33 +05:30
Koushik Das
121ff19cba
volume-upload: Attaching uploaded volume to an instance failing while copying from secondary to primary storage
...
The volume/template size and install path was not getting updated properly.
The upload status response should return these properties on completion of upload.
2015-01-31 17:27:46 +05:30
Koushik Das
6ff8752fd0
volume-upload: gc thread to clean partially uploaded files
...
Fixed multiple issues in the template code path
2015-01-31 17:25:19 +05:30
Koushik Das
c9908d2678
volume-upload: management server polling and upload status from agent
...
Some more fixes to the polling logic
2015-01-31 17:10:46 +05:30
Koushik Das
3e857bde08
volume-upload: management server polling and upload status from agent
...
Fixed some issues with the polling logic to handle scenarios when SSVM is destroyed/down.
Also changed the status of the volume_store_ref entries so that subsequent operations work fine.
2015-01-31 17:02:18 +05:30
Mike Tutkowski
5f16bf746b
When canceling maintenance mode, the logic was looking at the id field of the work object instead of the id field of the VM object.
2015-01-29 23:11:29 -07:00
Mike Tutkowski
31f67c2b3c
If the HypervisorType of a storage pool is Any, we need to retrieve hosts in the given zone for each HypervisorType.
2015-01-29 19:18:04 -07:00
Mike Tutkowski
bd6a89939d
Adding/updating comments around the volume's hypervisor snapshot reserve field
2015-01-29 15:50:42 -07:00
Mike Tutkowski
1b51bbbf74
Update hypervisor snapshot reserve for the root volume earlier than when it is currently being set
2015-01-29 13:01:51 -07:00
Rajani Karuturi
89ef9e709b
volume upload: updating the PSK if its null
2015-01-29 16:55:26 +05:30
Mike Tutkowski
8aa34d048a
Putting in an extra check to see if this volume is already attached to a VM
2015-01-26 17:25:17 -07:00
Nitin Mehta
abf4e5c646
CLOUDSTACK-8181: Introducing a new allocator called firstfitleastconsumed. The purpose of this allocator is to find hosts/pools with least capacity usage (in terms of percentage) within the cluster and use those resources first before others. This allocator can be used changing vm.allocation.algorithm. For hosts it would decide the least consumed host through the setting host.capacityType.to.order.clusters to base the usage on cpu or ram.
...
Reviewed-by: Prachi
2015-01-26 10:48:06 -08:00
Daan Hoogland
e474454c91
CLOUDSTACK-6485 prevent ipaddress asignment of gateway to gateway-interface on vpc router by setting vpcid to null in network
2015-01-26 16:57:46 +01:00
Daan Hoogland
29aeed71fc
CLOUDSTACK-6485 prevent ipaddress asignment of gateway to gateway-interface on vpc router by setting vpcid to null in network
2015-01-26 16:54:53 +01:00
Mike Tutkowski
e5ffcab09d
Moving the call to getDeviceId(long, long) avoids a race condition when two volumes are being attached to a VM at the same time
2015-01-24 00:36:07 -07:00
Rohit Yadav
f9a8111e17
CLOUDSTACK-8151: Add removeRawUsageRecords API to cleanup old cloud_usage data
...
Call removeRawUsageRecords with interval (> 0) and it will clean up cloud_usage
table by removing records older than interval no. of days from today (current date)
and in case it runs when the job exec time is near, it will fail alerting
user to try again after a 15 min window.
There is an issue with async job scheduler, if this API were async it tries
to search and remove job from cloud_usage.async_job table and fails which is
why this API is sync and extends BaseCmd.
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-23 19:38:32 +05:30
Mike Tutkowski
0f84e042b9
Adding support for creating a volume from a snapshot when the snapshot is on managed storage
2015-01-20 15:24:33 -07:00
Harikrishna Patnala
9cf05dc842
CLOUDSTACK-7534: ResetVM for VM with attached datadisk fails when enable.ha.storage.migration is false
...
Separate global config to enable/disable Storage Migration during normal deployment
Introduced a configuration parameter named enable.storage.migration
(cherry picked from commit c55bc0b2d1 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-20 14:43:10 +05:30
Saksham Srivastava
45108fdbad
CLOUDSTACK-7582: Update Storage Pool API does not update tags correctly
...
(cherry picked from commit fc4dceaa99 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-20 14:38:03 +05:30
Nitin Mehta
31a6517402
CLOUDSTACK-7754: Templates source_template_id is null when it is created from Snapshot with its corresponding volume removed. Fix it by searching for volumes including removed. Also bring the logic of setting source template id to create() method than execute which was wrongly put in.
...
(cherry picked from commit e1a993d37b )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-20 12:07:42 +05:30
Nitin Mehta
a6f9411b1e
CLOUDSTACK-7771: Throw exception while restoring vm if the template is already deleted. Also fix the usage event being generated from the right template id and fix the log message which sometime showed incorrect template id.
...
CLOUDSTACK-4201: listServiceOfferings API needs to be able to take virtualmachineid of SystemVM and return service offerings available for the vm to change service offering
(cherry picked from commit ee0f0a1cff )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-20 12:05:25 +05:30
Nitin Mehta
be0882b19e
CLOUDSTACK-7909: Change the capacity_state in op_host_Capacity table only on explicit enabling/disabling of the host and remove the logic for changing it when cluster/pod/zone is enabled/disabled. Also add the logic in capacity checker thread so that previous changes finally get consistent with this new model and also its good to have it for sanity reasons.
...
(cherry picked from commit ade305be20 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Conflicts:
server/src/com/cloud/capacity/CapacityManagerImpl.java
2015-01-20 11:58:04 +05:30
Nitin Mehta
665aa6b522
CLOUDSTACK-7916: Generate Alerts if System VMs cannot be started.
...
(cherry picked from commit e87bb20d0c )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-20 11:55:47 +05:30
Nitin Mehta
a12ab8a2b3
CLOUDSTACK-7916: Generate Alerts if System VMs cannot be started.
...
(cherry picked from commit 3907bc6f9d )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-20 11:55:36 +05:30
Nitin Mehta
1aeaf4dcc9
CLOUDSTACK-7920: NPE in the payload was causing the ssvm agent to not connect, fix it and also make sure that template/volume sync are robust that exceptions do not cause ssvm agent disconnect issues.
...
(cherry picked from commit 5213401ace )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Conflicts:
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java
2015-01-20 11:39:34 +05:30
Saksham Srivastava
6715c6ccfa
CLOUDSTACK-7941: CloudStack should log IP address of actual client even if a ReverseProxy is there
...
(cherry picked from commit f0a4a639de )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-20 11:32:09 +05:30
Saksham Srivastava
6e5b9da7d4
CLOUDSTACK-7962: Change state to Volume State
...
(cherry picked from commit c615aafd77 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-20 11:30:05 +05:30
Saksham Srivastava
f88a34dabe
CLOUDSTACK-7962: VM Snaptshot should add check for root volume status also
...
(cherry picked from commit 690a5ded35 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-20 11:29:59 +05:30
Sanjay Tripathi
b77cbea0f3
CLOUDSTACK-7964: listAccounts API is not listing correct value of resource limits.
...
(cherry picked from commit d475b62838 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-20 11:29:34 +05:30
amoghvk
57f5d51a11
CLOUDSTACK-7976 : Param validation for global params involving domain name
...
(cherry picked from commit 95ea203907 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Conflicts:
server/src/com/cloud/configuration/ConfigurationManagerImpl.java
2015-01-20 10:36:11 +05:30
amoghvk
3cb4358270
CLOUDSTACK-7977
...
Fix password generator, add guards for minimum length
(cherry picked from commit 960b7bbf74 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-20 10:31:05 +05:30
Koushik Das
37cdb4ecca
CLOUDSTACK-8054: No event generated on host maintenance mode is completed
...
Added events for host maintenance start and completion
(cherry picked from commit f6854bc984 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-20 10:23:37 +05:30
Rajani Karuturi
15ae33a5b6
volume upload: refactored post upload command and used it during template registration
2015-01-20 09:24:14 +05:30
Rajani Karuturi
ad6b7b30cb
Volume upload: sending the nfsstore url in the metadata
...
decoding the metadata and deserialising it on receiving it
2015-01-19 18:04:14 +05:30
Abhinandan Prateek
d8def3dc0b
CLOUDSTACK-8164: Look for all host to avoid NPE
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit a1a601be5a )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-19 11:30:49 +05:30
Abhinandan Prateek
a1a601be5a
CLOUDSTACK-8164: Look for all host to avoid NPE
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-19 11:29:51 +05:30
Koushik Das
7900ae5d9f
volume-upload: initializing state for volume and also setting the post url in volume_store_ref
2015-01-19 11:03:42 +05:30
Kishan Kavala
1e87f3b80b
Bug-Id: CLOUDSTACK-3439: Include dynamically created nics in Prepare for migration command in KVM
...
(cherry picked from commit f767adfe71 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-18 18:19:24 +05:30
Rajesh Battala
5f117e6be9
CLOUDSTACK-6920 Support listing of LBHealthcheck policy with LBHealthcheck policy ID
...
(cherry picked from commit c7b23d0a10 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-18 17:31:15 +05:30
Saksham Srivastava
a1791cb4a8
CLOUDSTACK-8088: VM scale up is failing in vmware with Unable to execute ScaleVmCommand due to java.lang.NullPointerException
...
(cherry picked from commit 1df0453d27 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-18 17:28:17 +05:30
Sanjay Tripathi
8676ff26e0
CLOUDSTACK-8066: There is not way to know the size of the snapshot created.
...
(cherry picked from commit 9153b8bede )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-18 17:25:41 +05:30
Koushik Das
053c160b0f
volume upload: management server polling and upload status from agent
...
MS polling logic to query status for templates that are uploaded
2015-01-16 18:03:36 +05:30
Rajani Karuturi
ebaa4dd38e
volume upload: added httpcomponents server and removed nio server
...
removing nio server as it is currently handling only https connections
and the parsing logic is also specific to agent communication.
current limitation of httpcomponents server is that the entire file is
read in memory. need figure out how to read it in chunks and send it
through a inputstreamreader to save on secondary storage.
2015-01-16 17:15:14 +05:30
Koushik Das
1f1c96d2ee
volume upload: management server polling and upload status from agent
...
- Added config parameters for upload monitoring interval and operation timeout
- Some updates to the volume state machine
2015-01-16 15:28:17 +05:30
Rajani Karuturi
0eee9e8138
volume upload: removed the transition from IN-PROGRESS to ABONDONED
...
incase of timeout it moved to error state. ABONDONED state is only when
the user hasnt initiated the post request in the specified time
2015-01-16 12:50:42 +05:30
cloudtrends
5028874e1c
under windows the publicKeyPath and privateKeyPath should replace from \ to / when send them into injectkeys.py , and use isOnWindows function . thanks karuturi kindly tips.
...
Signed-off-by: Rajani Karuturi <rajanikaruturi@gmail.com>
This closes #66
2015-01-16 11:33:00 +05:30
cloudtrends
4c30636c22
under windows the publicKeyPath and privateKeyPath should replace from \ to / when send them into injectkeys.py
...
Signed-off-by: Rajani Karuturi <rajanikaruturi@gmail.com>
This closes #66
2015-01-16 11:33:00 +05:30
Rohit Yadav
71a0148565
CLOUDSTACK-7219: Fix NPE, log warning when config item is missing from scope
...
- Cherry picked from Daan's fix 63fbd16dd1
- Added another check if configDepot returned null
- Removed developer prefill values
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit 188924751e )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-15 19:19:46 +05:30
Rohit Yadav
188924751e
CLOUDSTACK-7219: Fix NPE, log warning when config item is missing from scope
...
- Cherry picked from Daan's fix 63fbd16dd1
- Added another check if configDepot returned null
- Removed developer prefill values
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-15 19:13:40 +05:30
Pierre-Yves Ritschard
5ea7414746
move ConstantTimeComparator to utils
...
(cherry picked from commit b2393c31ed )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-14 20:25:32 +05:30
Pierre-Yves Ritschard
162c5af6f8
Use constant-time comparison functions when checking signatures
...
This limits the likeliness of timing attacks against the API.
See http://codahale.com/a-lesson-in-timing-attacks/ for the
full rationale.
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Conflicts:
server/src/com/cloud/api/ApiServer.java
server/src/com/cloud/user/AccountManagerImpl.java
(cherry picked from commit 9b4e39e837 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-14 20:25:21 +05:30
Pierre-Yves Ritschard
b2393c31ed
move ConstantTimeComparator to utils
2015-01-14 12:14:00 +01:00
Pierre-Yves Ritschard
9b4e39e837
Use constant-time comparison functions when checking signatures
...
This limits the likeliness of timing attacks against the API.
See http://codahale.com/a-lesson-in-timing-attacks/ for the
full rationale.
Conflicts:
server/src/com/cloud/api/ApiServer.java
server/src/com/cloud/user/AccountManagerImpl.java
2015-01-14 11:32:29 +01:00
Koushik Das
627f5a62dc
volume upload: management server polling and upload status from agent
...
MS polling logic to query status for volumes that are uploaded
2015-01-14 10:19:12 +05:30
Rohit Yadav
185f7e0152
CLOUDSTACK-8155: Remove unwanted whitespaces from json response
...
This removes extra whitespaces from the JSON serialized response.
After the fix, tested to work with:
- Present UI
- CloudMonkey
- Old buggy json parsers
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit 921ad057de )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-14 02:43:54 +05:30
Rohit Yadav
921ad057de
CLOUDSTACK-8155: Remove unwanted whitespaces from json response
...
This removes extra whitespaces from the JSON serialized response.
After the fix, tested to work with:
- Present UI
- CloudMonkey
- Old buggy json parsers
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-14 02:40:00 +05:30
Rajani Karuturi
c2cf2503c1
volume upload: persisting the PSK only when its not present
2015-01-13 11:37:22 +05:30
Rajani Karuturi
1ae34d98d4
volume upload: fixed circular reference error while generating json
2015-01-13 10:41:39 +05:30
Kishan Kavala
f767adfe71
Bug-Id: CLOUDSTACK-3439: Include dynamically created nics in Prepare for migration command in KVM
2015-01-07 14:52:42 +05:30
Kishan Kavala
a520309190
Bug-Id: CLOUDSTACK-7395: reverted 0560254c04 partially. Allow multiple networks with LB service
2015-01-07 14:33:31 +05:30
Kishan Kavala
01a325b2bf
Network Id for direct-network should not be included in usage record response. Direct network stats have network_id = 0. Ignore network with id = 0 in usage record
2015-01-07 14:17:30 +05:30
Kishan Kavala
9eb8d538dd
For volumes created from template, do not log offering ID in VOLUME.CREATE in usage_event. Moved offering type to DiskOffering interface
2015-01-07 12:31:41 +05:30
Kishan Kavala
4ac96d637c
Trigger user stats aggregation job at midnight in usage aggregation timezone
2015-01-07 11:17:24 +05:30
Daan Hoogland
3cba1c41fb
CID-1114614 dead code removed
2015-01-06 16:47:32 +01:00
Daan Hoogland
e8a54f471c
CID-1114606 use of MAX_VALUE and longValue() on Integer
2015-01-06 16:24:29 +01:00
Wei Zhou
1e8476d38a
CLOUDSTACK-8140: CS fails to start after secstorage/consoleproxy.service.offering is set to uuid
...
(cherry picked from commit 84c44b6314 )
2015-01-06 10:26:04 +01:00
Wei Zhou
84c44b6314
CLOUDSTACK-8140: CS fails to start after secstorage/consoleproxy.service.offering is set to uuid
2015-01-06 10:23:44 +01:00
Wei Zhou
93429443d5
CLOUDSTACK-8063: list secondary Ips information on non-default nics in VM response
2015-01-05 11:22:14 +01:00
Rajesh Battala
c7b23d0a10
CLOUDSTACK-6920 Support listing of LBHealthcheck policy with LBHealthcheck policy ID
2014-12-26 21:01:03 +05:30
Likitha Shetty
15b348632d
CLOUDSTACK-8129. Cold migration of VM across VMware DCs leaves the VM behind in the source host.
...
If VM has been cold migrated across different VMware DCs, then unregister the VM from source host.
2014-12-26 11:07:30 +05:30
Likitha Shetty
ff7997a2b1
CLOUDSTACK-8127. VM name not displayed after attaching data disk to a VM.
...
If user hasn't supplied a display name for a VM, default it to VM name in listVolume response.
This behaviour is identical to listVirtualMachine response.
2014-12-24 15:21:34 +05:30
Likitha Shetty
a5a65c7b55
CLOUDSTACK-8122. Handle NPE thrown during migration failures.
...
When migration fails instead of returning NULL, throw the exception.
2014-12-24 13:33:11 +05:30
Likitha Shetty
4d7ede535d
CLOUDSTACK-8119. Propagate error message to UI for attach/detach volume failure operations.
...
For AttachVolume/DetachVolume API command, improve user error message in case of RuntimeException by throwing the exception instead of 'Unexpected Exception'.
2014-12-24 11:29:03 +05:30
Likitha Shetty
5f9e4fddf3
CLOUDSTACK-8112. CS allows creation of VM's with the same Display name when vm.instancename.flag is set to true.
...
During VM creation, if vm.instancename.flag is set to true and hypervisor type is VMware, check if VM with the same hostname already exists in the zone.
2014-12-23 14:00:32 +05:30
Koushik Das
106ec718fc
Revert "CLOUDSTACK-7872: network getting shutdown inspite of running VM's in the network"
...
This reverts commit 709bf074de .
Network GC is broken with out-of-band VM movements due to the original commit, so reverting.
2014-12-23 12:13:51 +05:30
Koushik Das
e0c495d357
Revert "CLOUDSTACK-7872: network getting shutdown inspite of running VM's in the network"
...
This reverts commit 0bd34d389f .
Network GC is broken with out-of-band VM movements due to the original commit, so reverting.
2014-12-23 11:56:40 +05:30
Koushik Das
788fe5a273
CLOUDSTACK-8103: Vmsync marks VM as stopped even after failing to stop it in HV
...
During vmsync if StopCommand (issued as part of PowerOff/PowerMissing report) fails to stop VM (since VM is running on HV),
don't transition VM state to "Stopped" in CS db. Also added a check to throw ConcurrentOperationException if vm state is not
"Running" after start operation.
2014-12-22 12:31:34 +05:30
Koushik Das
331e257ca0
CLOUDSTACK-8103: Vmsync marks VM as stopped even after failing to stop it in HV
...
During vmsync if StopCommand (issued as part of PowerOff/PowerMissing report) fails to stop VM (since VM is running on HV),
don't transition VM state to "Stopped" in CS db. Also added a check to throw ConcurrentOperationException if vm state is not
"Running" after start operation.
2014-12-22 10:52:13 +05:30
Min Chen
c5d3a73c67
CLOUDSTACK-8101: volume sync not working as expected - MS restart during
...
upload volume leaves volume in hung state.
2014-12-19 16:43:02 -08:00
Min Chen
ea634550fc
CLOUDSTACK-8101: volume sync not working as expected - MS restart during upload volume leaves volume in hung state.
2014-12-19 15:51:52 -08:00
Rajani Karuturi
3e594c4e4f
volume upload: removed unused variables
2014-12-19 12:44:56 +05:30
Min Chen
3506789b0b
CLOUDSTACK-8093:Not able to list shared templates by passing id.
2014-12-18 10:27:20 -08:00
Min Chen
d304409c98
CLOUDSTACK-8093:Not able to list shared templates by passing id.
2014-12-18 10:00:18 -08:00
Rajani Karuturi
9bb6cf8452
volume upload: persisting the volume metadata
...
on calling GetUploadParamsForVolume, persisting the metadata to db
validating the account limits and incrementing the appropriate limits
encoded the metadata on management server using preshared key
2014-12-18 17:50:51 +05:30
Saksham Srivastava
4821bfffe2
CLOUDSTACK-8091: Stale entry exists for a VM NIC even after an exception while adding a new nic to vm
2014-12-18 17:45:34 +05:30
Saksham Srivastava
1df0453d27
CLOUDSTACK-8088: VM scale up is failing in vmware with Unable to execute ScaleVmCommand due to java.lang.NullPointerException
2014-12-18 14:27:55 +05:30
Edison Su
1eb20ee095
if concurrent snapshot happening on the same vm, throw invalid parameter
...
exception to user.
Reviewed-by: Frank
2014-12-17 14:35:42 -08:00
Edison Su
b036c32bfc
if concurrent snapshot happening on the same vm, throw invalid parameter
...
exception to user.
Reviewed-by: Frank
2014-12-17 14:35:15 -08:00
Edison Su
8f2bd45660
if local storage is in maitenance mode or removed, won't change its
...
status in case of mgt server restart
Reviewed-by:Frank
2014-12-17 14:34:48 -08:00
Edison Su
b40d9c23fc
if local storage is in maitenance mode or removed, won't change its
...
status in case of mgt server restart
Reviewed-by:Frank
2014-12-17 14:34:23 -08:00
Edison Su
50d5d488d4
add event for volume migration
...
Reviewed-by: Frank
2014-12-17 14:33:54 -08:00
Edison Su
5a10a4725d
add event for volume migration
...
Reviewed-by: Frank
2014-12-17 14:33:06 -08:00
Prachi Damle
01ae7120ac
CLOUDSTACK-8078: [Automation] Deletion of Affinity Groups - CloudRuntimeException: No Event Pubish can be wrapped within DB Transaction!
...
Changes:
- The event of deleteing an affinity group is published on the MessageBus so that IAM Service can listen and process the event, However the publish operation should not be handled within a DB transaction, since it may take longer and hold the DB transaction for long unnecessarily
- Publish any events to MessageBus outside of the transaction
Conflicts:
server/src/org/apache/cloudstack/affinity/AffinityGroupServiceImpl.java
2014-12-17 13:53:11 -08:00
Prachi Damle
a7861aa5fa
CLOUDSTACK-8079: If the cluster capacity threshold is reached, HA-enabled VM is not migrated on another host during HA
...
Changes:
- When there is HA we try to redeploy the affected vm using regular planners and if that fails we retry using the special planner for HA (which skips checking disable threshold)
Now because of job framework the InsufficientCapacittyException gets masked and the special planners are not called. Job framework needs to be fixed to rethrow the correct exception.
- Also the VM Work Job framework is not setting the DeploymentPlanner to the VmWorkJob. So the HA Planner being passed by HAMgr was not getting used.
- Now the job framework sets the planner passed in by any caller of the VM Start operation, to the job
2014-12-17 13:48:24 -08:00
Prachi Damle
f5d4736c87
CLOUDSTACK-8079: If the cluster capacity threshold is reached, HA-enabled VM is not migrated on another host during HA
...
Changes:
- When there is HA we try to redeploy the affected vm using regular planners and if that fails we retry using the special planner for HA (which skips checking disable threshold)
Now because of job framework the InsufficientCapacittyException gets masked and the special planners are not called. Job framework needs to be fixed to rethrow the correct exception.
- Also the VM Work Job framework is not setting the DeploymentPlanner to the VmWorkJob. So the HA Planner being passed by HAMgr was not getting used.
- Now the job framework sets the planner passed in by any caller of the VM Start operation, to the job
2014-12-17 11:43:07 -08:00
Prachi Damle
74720830cd
CLOUDSTACK-8078: [Automation] Deletion of Affinity Groups - CloudRuntimeException: No Event Pubish can be wrapped within DB Transaction!
...
Changes:
- The event of deleteing an affinity group is published on the MessageBus so that IAM Service can listen and process the event, However the publish operation should not be handled within a DB transaction, since it may take longer and hold the DB transaction for long unnecessarily
- Publish any events to MessageBus outside of the transaction
2014-12-17 11:43:05 -08:00
Sanjay Tripathi
9153b8bede
CLOUDSTACK-8066: There is not way to know the size of the snapshot created.
2014-12-17 16:00:19 +05:30
Min Chen
9fb654cbad
CLOUDSTACK-8077: Not able to deploy VM using a shared template.
2014-12-16 16:40:37 -08:00
Min Chen
cf1eed4811
CLOUDSTACK-8077: Not able to deploy VM using a shared template.
2014-12-16 16:39:56 -08:00
Rajani Karuturi
36c0c38ab8
volume upload: added the url validation check when url is not null
2014-12-16 15:41:27 +05:30
Wei Zhou
ff2ed33645
Fixed few coverity issues
2014-12-16 09:21:28 +01:00
Rajani Karuturi
f70a2a1486
volume upload: renamed command classes to follow the naming convention
2014-12-16 12:48:37 +05:30
Rajani Karuturi
7e030ee72d
volume upload: persisting the template metadata
...
on calling GetUploadParamsForTemplate, persisting the metadata to db
validating the account limits and incrementing the appropriate limits
encoded the metadata on management server using preshared key
2014-12-16 11:52:09 +05:30
Jayapal
aca0f79592
CLOUDSTACK-8072: Fixed NPE in deleting default ACL items in default ACL
2014-12-15 16:44:08 +05:30
Jayapal
85bb685662
CLOUDSTACK-8072: Fixed NPE in deleting default ACL items in default ACL
2014-12-15 16:37:35 +05:30
Sebastien Goasguen
cdc66c9e70
Small typo correction, exisits -> exists
...
Signed-off-by: Rajani Karuturi <rajanikaruturi@gmail.com>
This closes #57
2014-12-15 11:26:19 +05:30
Anshul Gangwar
b07c9b7a9c
CLOUDSTACK-8067: Fixed NPEs in MS log related to console proxy VM
...
(cherry picked from commit 1115bc9cc6 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-12-12 21:41:38 +05:30
Rohit Yadav
aa92f5d483
Merge remote-tracking branch 'anshulg/CLOUDSTACK-8067'
...
This closes #56
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-12-12 21:40:21 +05:30
Wei Zhou
19e99848c8
CLOUDSTACK-7882: SSH Keypair Creation/Selection in UI
...
Thanks Ilia Shakitko for the porting and testing.
2014-12-12 14:30:34 +01:00
Wei Zhou
76dc20a0ee
CLOUDSTACK-255: fix NPE in createPortForwardingRule due to no PortForwarding provider
...
(cherry picked from commit c9d492d714 )
2014-12-12 11:15:08 +01:00
Wei Zhou
c9d492d714
CLOUDSTACK-255: fix NPE in createPortForwardingRule due to no PortForwarding provider
2014-12-12 11:13:18 +01:00
Wei Zhou
fec31d53c3
CLOUDSTACK-8064: UpdatePortForwardingRuleCmd implementation
2014-12-12 10:19:06 +01:00
Wei Zhou
dcb7fcc6df
CLOUDSTACK-8063: list secondary Ips information in VM response
2014-12-12 09:47:27 +01:00
Anshul Gangwar
1115bc9cc6
CLOUDSTACK-8067: Fixed NPEs in MS log related to console proxy VM
2014-12-12 11:24:28 +05:30
Min Chen
fbe54974c5
CLOUDSTACK-8061: Extracting volume when it is in migrating state causes
...
both the operations to fail.
2014-12-11 11:36:34 -08:00
Min Chen
528bc80b4c
CLOUDSTACK-8061: Extracting volume when it is in migrating state causes
...
both the operations to fail.
2014-12-11 09:53:33 -08:00
Wei Zhou
f5619f428b
CLOUDSTACK-8051: fix NPE in updateNetwork due to static nat rules exist but no StaticNat provider
2014-12-11 15:13:36 +01:00
Rohit Yadav
fdb782ffcb
CLOUDSTACK-8014: Fix NPE searching including removed templates
...
Steps to reproduce if you have this issue:
- Create a VM's volume snapshot
- Remove VM's template and mark the template as removed with timestamp in DB
- Restart mgmt server and create a volume out of snapshot you should get NPE
Fix: In `storagePoolHasEnoughSpace`, we're only searching for a VM's volume's
snapshot's template by Id and not including removed templates. This is a corner
case and NPE hits when template has been marked removed for a VM's volume's
template so we should search including removed templates.
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit f189c105d8 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-12-10 19:31:27 +05:30
Rohit Yadav
e59dac201d
CLOUDSTACK-8014: Fix NPE searching including removed templates
...
Steps to reproduce if you have this issue:
- Create a VM's volume snapshot
- Remove VM's template and mark the template as removed with timestamp in DB
- Restart mgmt server and create a volume out of snapshot you should get NPE
Fix: In `storagePoolHasEnoughSpace`, we're only searching for a VM's volume's
snapshot's template by Id and not including removed templates. This is a corner
case and NPE hits when template has been marked removed for a VM's volume's
template so we should search including removed templates.
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit f189c105d8 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-12-10 19:30:56 +05:30
Koushik Das
f6854bc984
CLOUDSTACK-8054: No event generated on host maintenance mode is completed
...
Added events for host maintenance start and completion
2014-12-10 10:18:34 +05:30
Jayapal
8278d88f76
CLOUDSTACK-8030: Updated router to come up egress default ALLOW
...
On default iptables rules are updated to add ACCEPT egress traffic.
If the network egress default policy is false, CS remove ACCEPT and adds the DROP rule which
is egress default rule when there are no other egress rules.
If the CS network egress default policy is true, CS won't configure any default rule for egress because
router already came up to accept egress traffic. If there are already egress rules for network then the
egress rules get applied on VR.
For isolated network with out firewall service, VR default allows egress traffic (guestnetwork --> public network)
2014-12-10 10:13:41 +05:30
Koushik Das
016d009adf
CLOUDSTACK-7994: Network rules are not configured in VR after out-of-band movement due to host crash
...
The last commit 513adab51b didn't fully fix it. Scenario #1 was not handled, only #2 was handled.
Fixed #1 as part of this commit.
1. If VM is in stopped state in CS due to 'PowerMissing' report from old host (hostId is null) and then there is a 'PowerOn' report from new host
2. If VM is in running state in CS and there is a 'PowerOn' report from new host
2014-12-09 11:46:45 +05:30
Koushik Das
ef9830d6a4
Merge branch '4.5'
...
Conflicts:
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
tools/appliance/build.sh
2014-12-09 14:59:36 +05:30
Wei Zhou
13205e6be1
CLOUDSTACK-8050: VM Guest OS type does not update if template guestostype changes
2014-12-09 08:21:35 +01:00
Daan Hoogland
05b2ec4f55
Merge branch 'hotfix/CID-1256277'
2014-12-08 12:40:08 +01:00
Jayapal
8f8e311110
CLOUDSTACK-8030: Updated router to come up egress default ALLOW
...
On default iptables rules are updated to add ACCEPT egress traffic.
If the network egress default policy is false, CS remove ACCEPT and adds the DROP rule which
is egress default rule when there are no other egress rules.
If the CS network egress default policy is true, CS won't configure any default rule for egress because
router already came up to accept egress traffic. If there are already egress rules for network then the
egress rules get applied on VR.
For isolated network with out firewall service, VR default allows egress traffic (guestnetwork --> public network)
2014-12-08 11:32:01 +05:30
Nitin Mehta
b1e4c6db07
Revert "Revert "CLOUDSTACK-7919: If there is an out of band movement for the VR, irrespective of the fact that came as out of band live migrate or HA, reboot the router to make sure the router has all the rules configured.""
...
This reverts commit 24aaf19239 .
2014-12-08 11:20:49 +05:30
Nitin Mehta
24aaf19239
Revert "CLOUDSTACK-7919: If there is an out of band movement for the VR, irrespective of the fact that came as out of band live migrate or HA, reboot the router to make sure the router has all the rules configured."
...
This reverts commit 39a671dfd8 .
2014-12-05 15:24:09 +05:30
Wei Zhou
2554cfb140
CLOUDSTACK-7847: Can't deploy in project using customer created compute offerings
2014-12-05 08:42:22 +01:00
Jayapal
2d7f0c693b
CLOUDSTACK-8027: Update error msg for enable static nat
2014-12-05 12:55:41 +05:30
Jayapal
936a17be22
CLOUDSTACK-8027: Update error msg for enable static nat
2014-12-05 12:45:22 +05:30
Damodar
7ef0f5507d
Attach volume events are not correctly shown in events.
...
Signed-off-by: Koushik Das <koushik@apache.org>
2014-12-04 20:01:41 +05:30
Wei Zhou
fc1a09ff49
Add snapshotName parameter in CreateSnapshotCmd
2014-12-04 15:29:39 +01:00
Wei Zhou
d4605556c6
fix NPE when delete a domain
2014-12-04 15:28:41 +01:00
Damodar
7b8fe0c8cd
Attach volume events are not correctly shown in events.
...
Signed-off-by: Koushik Das <koushik@apache.org>
2014-12-04 19:31:03 +05:30
Sheng Yang
3c9e14e85a
CLOUDSTACK-5241: Remove Rot13 usage
2014-12-03 19:38:47 -08:00
Sheng Yang
feeafa76a4
CLOUDSTACK-5241: Remove Rot13 cipher
2014-12-03 19:30:31 -08:00
Min Chen
344d98e0bd
CLOUDSTACK-7981: added back resource tag related columns to user_vm_view to support resource tag related search.
2014-12-03 09:48:07 -08:00
Min Chen
8cb11f407f
CLOUDSTACK-7981: added back resource tag related columns to user_vm_view to support resource tag related search.
2014-12-03 09:33:22 -08:00
Laszlo Hornyak
a81b59e2a4
Revert "some unused fields deleted"
...
This reverts commit 31db58f720 .
2014-12-03 18:09:49 +01:00
Daan Hoogland
590667076d
CID-1256277 use StringBuffer in loop
2014-12-03 13:32:22 +01:00
Wei Zhou
c25d4fdea2
CLOUDSTACK-7847: Separate ListDomains cmd to use two different views
2014-12-03 12:33:57 +01:00
Wei Zhou
0407fb334f
CLOUDSTACK-7847: add max.domain.* in global setting and display domain resources in listDomainsCmd response
2014-12-02 11:52:10 +01:00
Rajani Karuturi
b963bb1e6d
volume upload: added getUploadParamsForVolume and getUploadParamsForTemplate api
2014-12-02 12:15:42 +05:30
Sheng Yang
77c88fa917
CLOUDSTACK-7999: Always override local keystore file with the entry in DB
2014-12-01 19:03:23 -08:00
Sheng Yang
c987080c26
CLOUDSTACK-7999: Always override local keystore file with the entry in DB
2014-12-01 18:59:25 -08:00
Koushik Das
c3515c9ff9
CLOUDSTACK-7994: Network rules are not configured in VR after out-of-band movement due to host crash
...
Ensure that VR is re-booted when it is moved to another host out-of-band. This is necessary to re-program all network rules
Conflicts:
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
2014-12-01 18:49:09 +05:30
Koushik Das
513adab51b
CLOUDSTACK-7994: Network rules are not configured in VR after out-of-band movement due to host crash
...
Ensure that VR is re-booted when it is moved to another host out-of-band. This is necessary to re-program all network rules
2014-12-01 18:09:58 +05:30
Wei Zhou
af2f21894c
CLOUDSTACK-7983: Create Disk/Service Offering for Domain Admin
2014-12-01 13:03:37 +01:00
Rohit Yadav
5241d0faf8
CLOUDSTACK-7903: Fix build regression from previous fix
...
The previous fix tried to access StatsCollector from UsageManagerImpl
which is not possible due to dependency cycle.
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit 1e0880cbab )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Conflicts:
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
2014-12-01 16:39:01 +05:30
Rohit Yadav
1e0880cbab
CLOUDSTACK-7903: Fix build regression from previous fix
...
The previous fix tried to access StatsCollector from UsageManagerImpl
which is not possible due to dependency cycle.
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-12-01 16:35:23 +05:30
Ilia Shakitko
e124781445
CLOUDSTACK-7903: Decreased minimal usage aggregation range value
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit 9b907902d2 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Conflicts:
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
2014-12-01 15:55:30 +05:30
Ilia Shakitko
9b907902d2
CLOUDSTACK-7903: Decreased minimal usage aggregation range value
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-12-01 15:52:00 +05:30
Rajani Karuturi
b6c86bdb75
changed commons-io version to the latest stable 2.4
...
also updated version numbers in all the poms its used.
2014-11-28 17:01:16 +05:30
Rohit Yadav
d28b716d8a
CLOUDSTACK-7989: Ignore Auth API calls in unauthenticated HTTP handlers
...
If an auth API call (such as login, logout) is called on unauthenticated port
such as the 8096 integration server port, we need to ignore such API calls
as calling auth APIs on 8096 is un-necessary and is undefined.
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit 21a6bef53b )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-11-28 15:46:17 +05:30
Rohit Yadav
21a6bef53b
CLOUDSTACK-7989: Ignore Auth API calls in unauthenticated HTTP handlers
...
If an auth API call (such as login, logout) is called on unauthenticated port
such as the 8096 integration server port, we need to ignore such API calls
as calling auth APIs on 8096 is un-necessary and is undefined.
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-11-28 15:43:29 +05:30
Harikrishna Patnala
cdfdda2051
CLOUDSTACK-6075: Increase the ram size for router service offering
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit 488c17858f )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-11-27 16:05:34 +05:30
Harikrishna Patnala
488c17858f
CLOUDSTACK-6075: Increase the ram size for router service offering
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-11-27 16:04:59 +05:30
Min Chen
bf8dd828f5
CLOUDSTACK-7981: listVirtualMachine is too slow in case of duplicate
...
resource tags due to joining user_vm_details to user_vm_view.
2014-11-26 17:40:06 -08:00
Min Chen
4e7af26c9f
CLOUDSTACK-7981: listVirtualMachine is too slow in case of duplicate
...
resource tags due to joining user_vm_details to user_vm_view.
2014-11-26 17:23:07 -08:00
amoghvk
960b7bbf74
CLOUDSTACK-7977
...
Fix password generator, add guards for minimum length
2014-11-26 15:08:48 -08:00
amoghvk
95ea203907
CLOUDSTACK-7976 : Param validation for global params involving domain name
2014-11-26 14:54:42 -08:00
amoghvk
86895ec13c
Add validation for domain names passed via global pamaremets
2014-11-26 14:45:50 -08:00
Harikrishna Patnala
9585aa0b51
CLOUDSTACK-6465: vmware.reserve.mem is missing from cluster level settings
...
Signed-off-by: Rajani Karuturi <rajanikaruturi@gmail.com>
(cherry picked from commit eae733817b )
2014-11-25 15:55:54 +05:30
Daniel Vega
02ca6f2e5b
CLOUDSTACK-7917: Validating Load Balancer Rule when updating LB + unit test
...
Signed-off-by: Rajani Karuturi <rajanikaruturi@gmail.com>
(cherry picked from commit c919ff83d8 )
2014-11-25 15:55:30 +05:30
Rohit Yadav
7ff31f1b22
Merge remote-tracking branch 'origin/inetaddress'
...
- Tested locally against unit tests
- TravisCI build passed: https://travis-ci.org/apache/cloudstack/builds/41990351
- Manual QA passed for basic auth and saml auth using default IDP settings
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Conflicts:
server/src/com/cloud/api/ApiServlet.java
2014-11-25 14:32:09 +05:30
Harikrishna Patnala
eae733817b
CLOUDSTACK-6465: vmware.reserve.mem is missing from cluster level settings
...
Signed-off-by: Rajani Karuturi <rajanikaruturi@gmail.com>
2014-11-25 12:22:31 +05:30
Daniel Vega
c919ff83d8
CLOUDSTACK-7917: Validating Load Balancer Rule when updating LB + unit test
...
Signed-off-by: Rajani Karuturi <rajanikaruturi@gmail.com>
2014-11-25 11:55:43 +05:30
Edison Su
7175247c5e
CLOUDSTACK-7966:
...
remove snapshot_store_ref entry, in which role is Primary, during
storage GC
2014-11-24 14:30:32 -08:00
Edison Su
4e5b3d028d
CLOUDSTACK-7966:
...
remove snapshot_store_ref entry, in which role is Primary, during
storage GC
2014-11-24 14:27:56 -08:00
Wido den Hollander
72ba98b1b8
Validate IPv4 address using Apache Commons Validator
2014-11-24 14:43:48 +01:00
Wido den Hollander
87a7810ade
Fix UnitTest ApiServlet
2014-11-24 11:48:13 +01:00
Sanjay Tripathi
d475b62838
CLOUDSTACK-7964: listAccounts API is not listing correct value of resource limits.
2014-11-24 13:44:42 +05:30
Saksham Srivastava
c615aafd77
CLOUDSTACK-7962: Change state to Volume State
2014-11-24 12:08:58 +05:30
Saksham Srivastava
690a5ded35
CLOUDSTACK-7962: VM Snaptshot should add check for root volume status also
2014-11-24 11:20:19 +05:30
Laszlo Hornyak
31db58f720
some unused fields deleted
...
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-11-23 19:49:04 +01:00
Laszlo Hornyak
712a729bd7
unused logger removed
...
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-11-23 19:49:03 +01:00
Laszlo Hornyak
3577423da9
removed executable flags from java classes
...
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-11-23 19:49:01 +01:00
Laszlo Hornyak
2a6d6891eb
Some simplification on getClientAddress in ApiServlet
...
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-11-23 19:48:58 +01:00
Laszlo Hornyak
fa52ffad65
unit test for getClientAddress
...
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-11-23 19:48:57 +01:00
Min Chen
b85183ede7
CLOUDSTACK-7678:volumes are getting uploaded successfully with wrong
...
url.
2014-11-21 15:18:47 -08:00
Min Chen
9ac93d3e43
CLOUDSTACK-7678:volumes are getting uploaded successfully with wrong url.
2014-11-21 14:36:36 -08:00
Wido den Hollander
4bd49df3f5
Use InetAddress for passing Remote Address instead of String
2014-11-21 12:10:35 +01:00
Syed
9f8d0051ed
CLOUDSTACK-7952: Remove private key from SslCertResponse (listSslCerts)
...
Signed-off-by: Will Stevens <wstevens@cloudops.com>
2014-11-21 03:39:57 -05:00
Will Stevens
1be6fb143e
CLOUDSTACK-7822: Fixed SSL Cert Tests and relaxed chain validation
...
Signed-off-by: Will Stevens <wstevens@cloudops.com>
2014-11-21 03:38:52 -05:00
Min Chen
66e0f049db
CLOUDSTACK-7954:ListTags API is ignoring the resourceID and displaying
...
all the tags of all resources.
2014-11-20 09:48:07 -08:00
Min Chen
5fa7801b20
CLOUDSTACK-7954:ListTags API is ignoring the resourceID and displaying
...
all the tags of all resources.
2014-11-20 09:46:00 -08:00
Min Chen
7de9d2f002
Revert "BUG-ID: CS-27662: ListTags API is ignoring the resourceID and displaying"
...
This reverts commit 3014fd0089 .
2014-11-20 09:44:55 -08:00
Min Chen
3014fd0089
BUG-ID: CS-27662: ListTags API is ignoring the resourceID and displaying
...
all the tags of all resources.
Reviewed-by: Frank
2014-11-20 09:31:29 -08:00
Syed
8ea7902075
CLOUDSTACK-7952: Remove private key from SslCertResponse (listSslCerts)
...
Signed-off-by: Will Stevens <wstevens@cloudops.com>
2014-11-20 03:46:03 -05:00
Edison Su
4140811549
CLOUDSTACK-7947:
...
double check if parent snapshot is removed or not, when creating new
snapshot
Reviewed-by: Min
2014-11-19 16:13:05 -08:00
Edison Su
bd79965329
CLOUDSTACK-7947:
...
double check if parent snapshot is removed or not, when creating new
snapshot
Reviewed-by: Min
2014-11-19 16:12:28 -08:00
Edison Su
2ccecce515
CLOUDSTACK-7946:
...
fix compile
2014-11-19 16:09:30 -08:00
Edison Su
15c0efb774
CLOUDSTACK-7946:
...
fix compile
2014-11-19 16:08:54 -08:00
Edison Su
d856a2acad
CLOUDSTACK-7946:
...
remove leftover state in volume and snapshot table in case of mgt server
shutdown during storage operation.
Reviewed-by: Min
2014-11-19 16:08:27 -08:00
Edison Su
67113ff0b2
CLOUDSTACK-7946:
...
remove leftover state in volume and snapshot table in case of mgt server
shutdown during storage operation.
Reviewed-by: Min
2014-11-19 16:06:37 -08:00
Rajani Karuturi
3da3d7418e
volume upload: PSK exchange between managemnet server and SSVM
...
generated a key during management server start and saved it in
configurationt table
2014-11-19 17:53:14 +05:30
Saksham Srivastava
f0a4a639de
CLOUDSTACK-7941: CloudStack should log IP address of actual client even if a ReverseProxy is there
2014-11-19 16:07:10 +05:30
Kishan Kavala
4e896938ee
BUG-ID: CLOUDSTACK-5324 when router requires upgrade throw ResourceUnavailableException with scope VirtualRouter. API willl return generic Network Unavailable error.
...
Reviewed-By: Damoder
2014-11-19 09:46:56 +05:30
Prachi Damle
968ca060ee
CLOUDSTACK-5853 cannot deploy vm with differing service storage tag and data disk storage tag
...
Changes:
- Reverting Marcus's fix since this issue has already fixed by https://issues.apache.org/jira/browse/CLOUDSTACK-5426
2014-11-18 14:07:51 -08:00
Prachi Damle
7f54894045
CLOUDSTACK-7559 After migrating root volume to other cluster wide storage, start VM is not running the VM with root disk from new storage.
...
Changes:
- During VM start, do not use the last host Id, if the host's cluster does not match the cluster provided in the deployment plan.
2014-11-18 14:07:49 -08:00
Prachi Damle
48553d7434
CLOUDSTACK-7559 After migrating root volume to other cluster wide storage, start VM is not running the VM with root disk from new storage.
...
Changes:
- During VM start, do not use the last host Id, if the host's cluster does not match the cluster provided in the deployment plan.
2014-11-18 09:47:20 -08:00
Daan Hoogland
f2ccee7a03
name convention adherence
2014-11-18 16:52:46 +01:00
Hugo Trippaers
302d5195d4
Merge branch 'bugfix/CID-1254835'
2014-11-18 14:31:33 +01:00
Hugo Trippaers
e1d4a329c4
Package name should reflect the location on the filesystem or viseversa
2014-11-18 14:12:44 +01:00
Anshul Gangwar
9c328cb9dd
CLOUDSTACK-7929: While creating network offering if one specifies negative value for network rate then we will convert that value to 0 i.e. unlimited
...
This closes #40
2014-11-18 14:25:30 +05:30
Anshul Gangwar
8307dd9105
CLOUDSTACK-7930, CLOUDSTACK-7931: Do not allow to set invalid values for global settings which are of type integer and float
...
This closes #41
2014-11-18 14:25:12 +05:30
Anshul Gangwar
4721e66d0e
CLOUDSTACK-7541: Added restriction to not allow custom disk offering with disksize UI doesn't allow but with API we were able to create custom disk offering with disk size which was causing this issue
...
This closes #28
2014-11-18 14:24:58 +05:30
Anshul Gangwar
44d12330b9
CLOUDSTACK-7758: Fixed although api calls are failing, event tab shows them as successful
...
This closes #29
2014-11-18 14:24:47 +05:30
Anshul Gangwar
ae199b6ce7
CLOUDSTACK-7703, CLOUDSTACK-7752: Fixed deployment planner stuck in infinite loop.
...
If we create VM with shared service offering and attach disk with local disk offering,
and one of storage pool is full(cannot be allocated) and other is not full then
we are not putting the cluster in avoid list which is causing this infinite loop.
Fixed by putting the cluster in avoid list even if one of the storage pool is full(cannot be allocated)
2014-11-18 14:12:45 +05:30
Anshul Gangwar
c04cdae60b
CLOUDSTACK-7767: fixed events are not generated for snapshot creation
2014-11-18 14:12:33 +05:30
Anshul Gangwar
f43ffb9a0f
CLOUDSTACK-7688, CLOUDSTACK-7747: restricted various operations for VM with VM snapshots which breaks VM snapshots.
...
Now they are informed that they cannot perform the operation.
To perform operation they have to remove VM snapshots of VM.
2014-11-18 14:12:02 +05:30
Hugo Trippaers
ef30300281
CID-1254834 secStorageVm can only be null in a special case
2014-11-18 09:37:35 +01:00
Hugo Trippaers
8560cc3b01
CID-1254835 proxy can only be null in a special case
2014-11-18 09:30:37 +01:00
Anshul Gangwar
31876fb588
CLOUDSTACK-7929: While creating network offering if one specifies negative value for network rate then we will convert that value to 0 i.e. unlimited
...
This closes #40
2014-11-18 13:39:08 +05:30
Anshul Gangwar
b008d78b57
CLOUDSTACK-7930, CLOUDSTACK-7931: Do not allow to set invalid values for global settings which are of type integer and float
...
This closes #41
2014-11-18 13:36:21 +05:30
Daan Hoogland
7b9e4a820b
CID-1254842 use boxed constant instead of true
2014-11-17 14:59:47 +01:00
Daan Hoogland
bb1ab33bb4
CID-1254841 removed unused var
2014-11-17 14:55:13 +01:00
Daan Hoogland
3dc12f7b48
CID-1254843: var name changed to saolve c&p issue
2014-11-17 14:45:48 +01:00
Anshul Gangwar
efe47b0704
CLOUDSTACK-7541: Added restriction to not allow custom disk offering with disksize UI doesn't allow but with API we were able to create custom disk offering with disk size which was causing this issue
...
This closes #28
2014-11-17 16:34:26 +05:30
Anshul Gangwar
e8a47594da
CLOUDSTACK-7758: Fixed although api calls are failing, event tab shows them as successful
...
This closes #29
2014-11-17 16:31:35 +05:30
Anshul Gangwar
2898f7d8d6
CLOUDSTACK-7703, CLOUDSTACK-7752: Fixed deployment planner stuck in infinite loop. If we create VM with shared service offering and attach disk with local disk offering, and one of storage pool is full(cannot be allocated) and other is not full then we are not putting the cluster in avoid list which is causing this infinite loop.
...
Fixed by putting the cluster in avoid list even if one of the storage pool is full(cannot be allocated)
This closes #30
2014-11-17 16:17:15 +05:30
Rajesh Battala
3a4d70e696
Revert "Merge branch 'CLOUDSTACK-7703' of https://github.com/anshul1886/cloudstack-1 "
...
This reverts commit d5b6fc4f04 , reversing
changes made to 91ffaaa5a2 .
2014-11-17 16:05:32 +05:30
Rajesh Battala
d5b6fc4f04
Merge branch 'CLOUDSTACK-7703' of https://github.com/anshul1886/cloudstack-1
...
This closes #30
2014-11-17 15:55:17 +05:30
Nitin Mehta
5213401ace
CLOUDSTACK-7920: NPE in the payload was causing the ssvm agent to not connect, fix it and also make sure that template/volume sync are robust that exceptions do not cause ssvm agent disconnect issues.
2014-11-14 16:19:10 -08:00
Nitin Mehta
39a671dfd8
CLOUDSTACK-7919: If there is an out of band movement for the VR, irrespective of the fact that came as out of band live migrate or HA, reboot the router to make sure the router has all the rules configured.
2014-11-14 14:30:46 -08:00
Nitin Mehta
e87bb20d0c
CLOUDSTACK-7916: Generate Alerts if System VMs cannot be started.
2014-11-14 13:35:40 -08:00
Nitin Mehta
3907bc6f9d
CLOUDSTACK-7916: Generate Alerts if System VMs cannot be started.
2014-11-14 13:18:27 -08:00
Jayapal
7fd1e8e239
Merge branch '4.5'
2014-11-14 12:12:07 +05:30
Devdeep Singh
cffae8eef0
CLOUDSTACK-6924. To attach a volume if a volume needs to be moved to another storage
...
pool, the source and destination pools cannot be local and cluster/zone and vice versa.
Cloudstack detects it and throws a exception. However, the end user only sees an
unexpected exception and not the reason for failure. Fixed it by making sure the
reason for the failure is correctly captured and shown to the end user.
2014-11-14 11:19:19 +05:30
Damodar
7e6ec2ce82
CLOUDSTACK-7877: The NET.IPRELEASE events are not added to usage_event on IP range deletion from Physical Networks.
...
Signed-off-by: Jayapal <jayapal@apache.org>
2014-11-14 10:31:46 +05:30
Nitin Mehta
ade305be20
CLOUDSTACK-7909: Change the capacity_state in op_host_Capacity table only on explicit enabling/disabling of the host and remove the logic for changing it when cluster/pod/zone is enabled/disabled. Also add the logic in capacity checker thread so that previous changes finally get consistent with this new model and also its good to have it for sanity reasons.
2014-11-13 13:54:45 -08:00
Will Stevens
92d4a41a69
CLOUDSTACK-7822: Fixed SSL Cert Tests and relaxed chain validation
2014-11-13 09:55:49 -05:00
Santhosh Edukulla
ef6ec7b276
Fixed few coverity issues like invalid boxing unboxing issues, resource leaks, null dereferences
2014-11-13 17:26:24 +05:30
Saksham Srivastava
fc4dceaa99
CLOUDSTACK-7582: Update Storage Pool API does not update tags correctly
2014-11-13 17:01:06 +05:30
Koushik Das
f585dd2661
CLOUDSTACK-7902: Account creation results in exception in logs
...
Event publish code was wrapped in transaction, moved it out
2014-11-13 16:11:53 +05:30
Koushik Das
03e63a67e0
CLOUDSTACK-7902: Account creation results in exception in logs
...
Event publish code was wrapped in transaction, moved it out
2014-11-13 14:41:33 +05:30
Mike Tutkowski
2042660a68
Added a "long getUsedIops(StoragePool)" method to the PrimaryDataStoreDriver interface
2014-11-12 13:38:58 -07:00
Wido den Hollander
95daa14e2a
CLOUDSTACK-7583: Fix NPE caused by previous commit
2014-11-12 16:54:20 +01:00
Damodar
f1361796bf
CLOUDSTACK-7886: cloudstackoperations like deployvm,deleteNW are failing if CS fail to contact rabbit mq server. This is happening in case of Async API calls.
...
Signed-off-by: Koushik Das <koushik@apache.org>
2014-11-12 10:24:56 +05:30
Damodar
50a3c0b2e3
CLOUDSTACK-7886: cloudstackoperations like deployvm,deleteNW are failing if CS fail to contact rabbit mq server. This is happening in case of Async API calls.
...
Signed-off-by: Koushik Das <koushik@apache.org>
2014-11-12 10:12:15 +05:30
Harikrishna Patnala
edf1047a20
CLOUDSTACK-7706: Coverity defects
...
Signed-off-by: Santhosh Edukulla <santhosh.edukulla@gmail.com>
2014-11-11 20:58:45 +05:30
Wido den Hollander
840c2fda85
CLOUDSTACK-7583: Send VmStats to Graphite host when configured
...
This allows external processing of VmStats information without using
the usage server of CloudStack
Statistics are being send to Graphite using UDP and not TCP.
UDP is used to prevent the management server waiting for TCP timeouts
when the Graphite server is unavailable
2014-11-11 13:04:43 +01:00
Koushik Das
2685ed36cc
CLOUDSTACK-7880: Creating shared network results in exception
...
This is due to event publish being wrapped in a transaction, moved it outside of transaction scope.
2014-11-11 16:35:20 +05:30
Koushik Das
6d268db217
CLOUDSTACK-7880: Creating shared network results in exception
...
This is due to event publish being wrapped in a transaction, moved it outside of transaction scope.
2014-11-11 16:32:20 +05:30
Daan Hoogland
d2f28ea3ae
CID-1251369: not null check changed to null check
2014-11-11 09:32:09 +01:00
Santhosh Edukulla
c916f30574
CLOUDSTACK-7828.Avoid marking IPs already in Allocated as Allocated again. Use row lock to ensure that prev state is either Allocating or Free. This will inturn avoid logging duplicate events
2014-11-10 21:22:47 +05:30
Rohit Yadav
c401dbc8f9
CLOUDSTACK-7871: allow VM and template details update using update APIs
...
Allows updating details (key/value) pair which updatse entries
invm_template_details and user_vm_details tables using updateVM and updateTemplate
APIs. This allows sys admins to update nics, controllers etc without DB hacking.
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit 97fa4a023e )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-11-10 17:53:26 +05:30
Rohit Yadav
97fa4a023e
CLOUDSTACK-7871: allow VM and template details update using update APIs
...
Allows updating details (key/value) pair which updatse entries
invm_template_details and user_vm_details tables using updateVM and updateTemplate
APIs. This allows sys admins to update nics, controllers etc without DB hacking.
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-11-10 17:51:57 +05:30
Jayapal
709bf074de
CLOUDSTACK-7872: network getting shutdown inspite of running VM's in the network
2014-11-10 16:06:58 +05:30
Jayapal
0bd34d389f
CLOUDSTACK-7872: network getting shutdown inspite of running VM's in the network
2014-11-10 15:26:48 +05:30
Damodar
781648fb10
CLOUDSTACK-7792: Usage Events to be captured based on Volume State Machine
2014-11-10 15:19:02 +05:30
Bharat Kumar
310bb255ac
CLOUDSTACK-7760 Data disk size is not considering for primary storage resource limit check
2014-11-10 15:07:13 +05:30
Bharat Kumar
991d783e03
CLOUDSTACK-7760 Data disk size is not considering for primary storage resource limit check
2014-11-10 14:30:42 +05:30
Nitin Mehta
a8b89bea4f
CLOUDSTACK-7870: When Vm deployments fail and end in error state volume count should be decremented
2014-11-09 23:01:28 -08:00
Koushik Das
54ec268b7e
CLOUDSTACK-7869: Add simulator support for findHostsForMigration API
2014-11-08 13:50:43 +05:30
Koushik Das
e25de54b4c
CLOUDSTACK-7421
...
Unnecessary exception in MS logs while removing default NIC from VM. Following changes are made:
1. Changed the exception from CloudRuntimeException to InvalidParameterValueExecption.
2. Moved out validation logic to UserVMManagerImpl from VirtualMachineManagerImpl.
3. Handling InvalidParameterValueException from async API calls so that they are not logged as ERROR in MS logs.
2014-11-08 13:50:15 +05:30
Koushik Das
8378485e56
CLOUDSTACK-7869: Add simulator support for findHostsForMigration API
2014-11-08 13:46:54 +05:30
Sanjay Tripathi
1c9775b0df
CLOUDSTACK-7859: Host tags are not getting removed in cloud.host_tags table when a Host is deleted from CS.
2014-11-07 17:34:16 +05:30
Sanjay Tripathi
330bd2748e
CLOUDSTACK-7859: Host tags are not getting removed in cloud.host_tags table when a Host is deleted from CS.
2014-11-07 17:32:25 +05:30
Mike Tutkowski
9338abb6f3
Check to see if the Map<String, String> of capabilities passed back from the storage driver is null.
2014-11-06 19:49:44 -07:00
Mike Tutkowski
ebb96f5e2f
Handle the case where the volume a snapshot was created from is removed from the database
2014-11-06 19:44:46 -07:00
Edison Su
812b0122e2
CLOUDSTACK-7683: hold a db lock during vm expunge
2014-11-06 15:37:15 -08:00
Edison Su
ffdb38c496
there is no transaction context during the mgt server start, thus causing transaction.close will delete op_lock table if aquireinlocktable is called Reviewed-by: Anthony and Min
2014-11-06 15:30:19 -08:00
Edison Su
1fb28c2959
CS-21296: hidden snapshot.backup.rightafter, as it's not needed
2014-11-06 15:29:56 -08:00
Edison Su
103a4dd54d
CLOUDSTACK-7683: hold a db lock during vm expunge
2014-11-06 15:22:34 -08:00
Mike Tutkowski
92d9ef9c17
Handle the case where a snapshot is associated with a deleted volume
2014-11-06 15:34:39 -07:00
Pierre-Luc Dion
f5c3a71ef9
commented unit tests for CertService until certs issues fixed
2014-11-06 09:39:45 -05:00
pdion891
b532e4f52c
CLOUDSTACK-7822: fix tests CA cert
2014-11-05 10:54:21 -05:00
pdion891
f86eb522e2
commented broken unit test
2014-11-05 10:46:36 -05:00
pdion891
ddb2d9c60e
CLOUDSTACK-7822: merge, test sslcert ca
2014-11-05 08:49:42 -05:00
Sanjay Tripathi
5a67fe7369
CLOUDSTACK-7842: wrong size column is getting updated with snapshot physical size in snapshot_store_ref table.
...
Also fixed the issue that snapshot size with hypervisor XS >= 6.2.5 is not getting updated in snapshot_store_ref table.
2014-11-05 16:44:54 +05:30
Sanjay Tripathi
b844155240
CLOUDSTACK-7842: Wrong size column is getting updated with snapshot physical size in snapshot_store_ref table.
...
Also fixed the issue that snapshot size with hypervisor XS >= 6.2.5 is not getting updated in snapshot_store_ref table.
2014-11-05 16:42:28 +05:30
Rajani Karuturi
4c5f792ca9
Merge branch '4.5'
2014-11-05 15:20:34 +05:30
Rajani Karuturi
c3e5964dcb
Fixed CLOUDSTACK-7242: Adding a securing config using configDepo doesnt work
...
In ConfigurationVo, changed the setter to do the encryption if required
like the getter. Called the setter in constructor as well.
Removed references of encryption check in different places.
Reviewed-by: Santhosh Edukulla
This closes #35
2014-11-05 11:49:38 +05:30
Koushik Das
0327c2b13e
CLOUDSTACK-7421
...
Unnecessary exception in MS logs while removing default NIC from VM. Following changes are made:
1. Changed the exception from CloudRuntimeException to InvalidParameterValueExecption.
2. Moved out validation logic to UserVMManagerImpl from VirtualMachineManagerImpl.
3. Handling InvalidParameterValueException from async API calls so that they are not logged as ERROR in MS logs.
2014-11-04 17:34:07 +05:30
Sanjay Tripathi
9168d826da
CLOUDSTACK-7372: [vGPU] When a host is put in maintenance mode, vGPU enabled VMs
...
failed to migrate to the other host in the cluster.
Migration for vGPU VMs is not supported in XS, so instead of migrating them to
new server, stopping them.
2014-11-04 17:28:22 +05:30
Sanjay Tripathi
7a8f511014
CLOUDSTACK-7372: [vGPU] When a host is put in maintenance mode, vGPU enabled VMs
...
failed to migrate to the other host in the cluster.
Migration for vGPU VMs is not supported in XS, so instead of migrating them to
new server, stopping them.
2014-11-04 16:46:28 +05:30
Min Chen
07ba078ee6
CLOUDSTACK-7833: VM Async work jobs log "Was unable to find lock for the key vm_instance" errors as warning
2014-11-03 11:19:06 -08:00
Min Chen
684889f0b5
CLOUDSTACK-7833: VM Async work jobs log "Was unable to find lock for the key vm_instance" errors as warning
2014-11-03 10:52:47 -08:00
Kishan Kavala
e427d0004c
CLOUDSTACK-7267: For LXC volumes, show unsupported operation error for template creation from ROOT volume
2014-11-03 17:20:21 +05:30
Kishan Kavala
99010f463b
CLOUDSTACK-7265: For LXC volumes, show unsupported operation error for volume snapshot
2014-11-03 17:20:00 +05:30
Kishan Kavala
d6fdb7c6bc
CLOUDSTACK-7253: For LXC Vms, show unsupported error for console access
2014-11-03 17:19:15 +05:30
Santhosh Edukulla
1aef5cba66
Fixed Coverity Issues
2014-11-03 16:45:30 +05:30
Santhosh Edukulla
1c01da3e08
CLOUDSTACK-7828.Avoid marking IPs already in Allocated as Allocated again. Use row lock to ensure that prev state is either Allocating or Free. This will inturn avoid logging duplicate events
2014-11-03 12:40:13 +05:30
amoghvk
efc9632c1b
CLOUDSTACK:6915 search including removed
2014-10-31 15:47:18 -07:00
amoghvk
6df396c9c0
Merge branch '4.5' of https://git-wip-us.apache.org/repos/asf/cloudstack into 4.5
2014-10-31 15:29:40 -07:00
amoghvk
0c153966e6
CLOUDSTACK:6915 search including removed
2014-10-31 15:29:07 -07:00
Nitin Mehta
138366804d
CLOUDSTACK-7825: Report both virtual size and physical size for the snaphost usage event.
2014-10-31 15:25:06 -07:00
Nitin Mehta
2652195010
CLOUDSTACK-7825: Report both virtual size and physical size for the snaphost usage event.
2014-10-31 15:24:32 -07:00
pdion891
aaa561a283
Revert "CLOUDSTACK-7822: updated ssl cert(exp:2096), reactivate tests"
...
This reverts commit 0d1fa9102d .
2014-10-31 17:14:59 -04:00
pdion891
f28ade56f2
Revert "CLOUDSTACK-7822: updated ssl cert(exp:2096), reactivate tests"
...
This reverts commit 0d1fa9102d .
2014-10-31 17:12:54 -04:00
pdion891
5b1cbc442a
CLOUDSTACK-7822: updated ssl cert(exp:2096), reactivate tests
2014-10-31 16:43:57 -04:00
pdion891
0d1fa9102d
CLOUDSTACK-7822: updated ssl cert(exp:2096), reactivate tests
2014-10-31 16:42:31 -04:00
Rohit Yadav
f543d86eff
saml: Use camelCase api names for SAML login/logout apis
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-10-31 01:24:39 +05:30
Rohit Yadav
cd52bed477
saml: Use camelCase api names for SAML login/logout apis
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit 85c0bd68ae8a76c231ab402dd0311e3672155f71)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-10-31 00:32:29 +05:30
Rohit Yadav
62f9bf0fff
PR #26 CLOUDSTACK-7688, CLOUDSTACK-7747
...
Restricted various operations for VM with VM Snapshots #26
This closes #26
2014-10-30 15:11:57 +05:30
Anshul Gangwar
4705933a64
CLOUDSTACK-7703, CLOUDSTACK-7752: Fixed deployment planner stuck in infinite loop.
...
If we create VM with shared service offering and attach disk with local disk offering,
and one of storage pool is full(cannot be allocated) and other is not full then
we are not putting the cluster in avoid list which is causing this infinite loop.
Fixed by putting the cluster in avoid list even if one of the storage pool is full(cannot be allocated)
2014-10-30 13:36:01 +05:30
Anshul Gangwar
d8b46b81b9
CLOUDSTACK-7767: fixed events are not generated for snapshot creation
2014-10-30 13:25:06 +05:30
Anshul Gangwar
a4d8215ebb
CLOUDSTACK-7688, CLOUDSTACK-7747: restricted various operations for VM with VM snapshots which breaks VM snapshots.
...
Now they are informed that they cannot perform the operation.
To perform operation they have to remove VM snapshots of VM.
2014-10-30 12:37:50 +05:30
Anthony Xu
c78f14cbc2
fixed NPE
2014-10-29 17:05:42 -07:00
Edison Su
b6d8ceda3d
there is no transaction context during the mgt server start, thus causing transaction.close will delete op_lock table if aquireinlocktable is called Reviewed-by: Anthony and Min
2014-10-30 02:21:29 -07:00
Hugo Trippaers
4ebaf0a583
Bump master version to 4.6.0-SNAPSHOT after branching 4.5.0-SNAPSHOT
2014-10-29 14:54:23 +01:00
Min Chen
055901acda
CLOUDSTACK-7797: listSupportedNetworkServices API takes more than 1 second to
...
complete, slow compared to previous 4.3 release.
2014-10-27 17:00:42 -07:00
Sheng Yang
dd7026b20e
CLOUDSTACK-1771: Fix VR IP change when restartnetwork with cleanup=true in basic zone
...
In basic network, the correct network id associate with IP is source network id
rather than network id.
2014-10-27 16:49:30 -07:00
Sheng Yang
307a35a618
CLOUDSTACK-1771: Fix VR IP change when restartnetwork with cleanup=true in basic zone
...
In basic network, the correct network id associate with IP is source network id
rather than network id.
2014-10-27 16:46:01 -07:00
Min Chen
4f43839dae
CLOUDSTACK-7797: listSupportedNetworkServices API takes more than 1 second to
...
complete, slow compared to previous 4.3 release.
2014-10-27 16:27:17 -07:00
Sanjay Tripathi
db6a0d65aa
No need to log discrepancy resource count message for Primary and secondary storage.
2014-10-27 15:26:06 +05:30
Sanjay Tripathi
4f4595cef8
No need to log discrepancy resource count message for Primary and secondary storage.
2014-10-27 15:23:36 +05:30
Sanjay Tripathi
c5fa7cc494
Correct the error message when tried created VM Snapshot with memory on a vGPU Instance.
...
"VM snapshot with MEMORY is not supported for VGU enabled VMs."
Change VGU to vGPU.
2014-10-27 13:59:59 +05:30
Sanjay Tripathi
9bcf0e1bf6
Correct the error message when tried created VM Snapshot with memory on a vGPU Instance.
...
"VM snapshot with MEMORY is not supported for VGU enabled VMs."
Change VGU to vGPU.
2014-10-27 13:52:28 +05:30
Frank Zhang
88561e154f
fix expried certificate in unit test
2014-10-24 11:10:24 -07:00
Anthony Xu
32dc09f2c3
even xenserverinvestigator returns true, that means host is up, but XAPI may not work
2014-10-23 16:10:18 -07:00
Edison Su
10cc7f86af
CS-21296: hidden snapshot.backup.rightafter, as it's not needed
2014-10-22 15:36:35 -07:00
Anthony Xu
4a13f81485
when host is pingtimeout and CCP can not determine the host status, put the host to Alert status , no VM HA.
2014-10-22 15:14:46 -07:00
Anthony Xu
c52e14730e
when host is pingtimeout and CCP can not determine the host status, put the host to Alert status , no VM HA.
2014-10-22 15:07:40 -07:00
Nitin Mehta
ee0f0a1cff
CLOUDSTACK-7771: Throw exception while restoring vm if the template is already deleted. Also fix the usage event being generated from the right template id and fix the log message which sometime showed incorrect template id.
...
CLOUDSTACK-4201: listServiceOfferings API needs to be able to take virtualmachineid of SystemVM and return service offerings available for the vm to change service offering
2014-10-22 15:03:25 -07:00
Mike Tutkowski
97aa02ceb0
Commits related to taking snapshots that live on primary storage
2014-10-22 12:44:33 -06:00
Anthony Xu
0141b37784
CLOUDSTACK-7761:
...
Revert "when system VM ping times out, stop system VM"
This reverts commit ee23be1942 .
2014-10-21 17:21:17 -07:00
Anthony Xu
70112bd145
CLOUDSTACK-7761:
...
Revert "when system VM ping times out, stop system VM"
This reverts commit ee23be1942 .
2014-10-21 17:19:57 -07:00
Frank Zhang
ccf4c66ef1
fix expried certificate in unit test
2014-10-21 16:20:54 -07:00
Mike Tutkowski
57dacf99a2
Changed "boolean connectVolumeToHost(VolumeInfo, Host, DataStore)" to "boolean grantAccess(DataObject, Host, DataStore)"
...
Changed "void disconnectVolumeFromHost(VolumeInfo, Host, DataStore)" to "void revokeAccess(DataObject, Host, DataStore)"
2014-10-21 16:01:14 -06:00
Mike Tutkowski
06f6b00cd1
Snapshot support
2014-10-21 16:01:13 -06:00
Nitin Mehta
e1a993d37b
CLOUDSTACK-7754: Templates source_template_id is null when it is created from Snapshot with its corresponding volume removed. Fix it by searching for volumes including removed. Also bring the logic of setting source template id to create() method than execute which was wrongly put in.
2014-10-21 09:57:02 -07:00
Nitin Mehta
a72580def0
CLOUDSTACK-7754: Templates source_template_id is null when it is created from Snapshot with its corresponding volume removed. Fix it by searching for volumes including removed.
...
(cherry picked from commit 287ff83552 )
2014-10-20 16:50:22 -07:00
Nitin Mehta
287ff83552
CLOUDSTACK-7754: Templates source_template_id is null when it is created from Snapshot with its corresponding volume removed. Fix it by searching for volumes including removed.
2014-10-20 16:49:48 -07:00
Daan Hoogland
622041b513
rats
2014-10-17 11:56:07 +02:00
Daan Hoogland
1de0cb7094
restore barematel work after merge
2014-10-17 10:24:01 +02:00
Daan Hoogland
148efbb73f
Merge remote-tracking branch 'origin/4.5' into merge-master
...
Conflicts:
engine/schema/src/com/cloud/upgrade/dao/Upgrade441to450.java
plugins/hypervisors/baremetal/src/com/cloud/baremetal/manager/BaremetalManagerImpl.java
plugins/hypervisors/baremetal/src/com/cloud/baremetal/manager/BaremetalVlanManager.java
plugins/hypervisors/baremetal/src/com/cloud/baremetal/manager/BaremetalVlanManagerImpl.java
plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetalKickStartServiceImpl.java
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java
setup/db/db/schema-441to450.sql
test/integration/component/test_deploy_vgpu_vm.py
tools/marvin/marvin/config/test_data.py
2014-10-16 12:29:37 +02:00
Sanjay Tripathi
1f8cf0bee4
CLOUDSTACK-7739: Add new vGPU types K160Q, K180Q, K280Q to the CloudStack UI.
2014-10-16 14:38:33 +05:30
Sanjay Tripathi
ec6a666855
Config value having different category in SQL and Config.java.
2014-10-16 14:38:23 +05:30
Sanjay Tripathi
420d4e0da0
CLOUDSTACK-7739: Add new vGPU types K160Q, K180Q, K280Q to the CloudStack UI.
2014-10-16 14:25:30 +05:30
Sanjay Tripathi
5025071954
Config value having different category in SQL and Config.java.
2014-10-16 14:01:23 +05:30
Sanjay Tripathi
80e0c99189
Removed duplicate code and unused imports which was causing build failure.
2014-10-16 13:53:32 +05:30
Santhosh Edukulla
efe1e0a544
Fixed coverity and other resource leak issues
...
Signed-off-by: Santhosh Edukulla <santhosh.edukulla@gmail.com>
2014-10-16 12:19:51 +05:30
Jayapal
53ee4cd794
CLOUDSTACK-7728: Removed duplicate import
2014-10-16 10:05:06 +05:30
Damodar
7fe3c45142
CLOUDSTACK-7729: listVMSnapshot API not returning parent id in response
2014-10-16 09:43:04 +05:30
Jayapal
e257c13f16
CLOUDSTACK-7728: Fixed adding iptables rules for egress allow on VR reboot
2014-10-16 09:38:21 +05:30
Jayapal
f488a8f72c
CLOUDSTACK-7728: Fixed adding icmp rules with different types and codes
2014-10-16 09:38:21 +05:30
Bharat Kumar
080bc2e2e9
CLOUDSTACK-7536 user vm can get a gateway ip when gateway ip is a part of the guest ip range.
...
Signed-off-by: Jayapal <jayapal@apache.org>
2014-10-16 09:38:21 +05:30
Jayapal
55e11cddca
CLOUDSTACK-7728: Fixed adding iptables rules for egress allow on VR reboot
2014-10-16 09:37:43 +05:30
Jayapal
7cd3438580
CLOUDSTACK-7728: Fixed adding icmp rules with different types and codes
2014-10-16 09:37:42 +05:30
Bharat Kumar
6967c6c229
CLOUDSTACK-7536 user vm can get a gateway ip when gateway ip is a part of the guest ip range.
...
Signed-off-by: Jayapal <jayapal@apache.org>
2014-10-16 09:37:42 +05:30
Nitin Mehta
3b442acdd7
CLOUDSTACK-7532: Template status is not shown in UI/API response for non-default account users. Show it if the owner of the template is the caller
...
(cherry picked from commit 42f628c61c )
2014-10-15 13:58:22 -07:00
Nitin Mehta
42f628c61c
CLOUDSTACK-7532: Template status is not shown in UI/API response for non-default account users. Show it if the owner of the template is the caller
2014-10-15 13:53:39 -07:00
Mike Tutkowski
e70dde09c9
Implementing snapshot-strategy support for reverting a volume to a snapshot
2014-10-14 22:04:18 -06:00
Mike Tutkowski
35a8b70799
Adding a snapshot strategy for systems that want to take snapshots that reside on their own system (as opposed to the default approach of taking a hypervisor snapshot and then copying it to secondary storage)
2014-10-14 12:26:40 -06:00
Daan Hoogland
771d052381
Merge branch 'vpc-refactor-clean-for-PR' of https://github.com/schubergphilis/cloudstack
2014-10-14 20:14:50 +02:00
wilderrodrigues
1e87d7b266
Fixing checkstyle.
...
Making local variable compatible with our checkstyle settings.
2014-10-14 15:25:50 +02:00
wilderrodrigues
2ed64b2356
Applying fix from commit id 6b8e0baa21
...
Changes by Edilson Su: if vpc public network with snat enabled, then will triger this issue.
2014-10-14 15:10:14 +02:00
Wilder Rodrigues
db86bdfb2c
Applygin fix from commit ID aaeadc5c44
...
Sheng Yang changed 2 classes, ut only one was related to the bug CLOUDSTACK-7605.
I applied the changed on the routerslist, used during the deployment of the virtual routers.
Tested Advanced Zone against the simulator. 69 happy tests in place
2014-10-14 15:08:13 +02:00
Wilder Rodrigues
c81b3380df
Applying the latest chances from the VPC Refactor branch onto the new one.
...
We will keep this branch as clean as possible to avoid problems with merge.
2014-10-14 15:08:13 +02:00
wrodrigues
3ac2e222e8
CLOUDSTACK-6278 Baremetal Advanced Networking support from commit id e06fa18ed2 by Frank Zhang
...
Conflicts:
server/src/com/cloud/network/router/NetworkHelperImpl.java
2014-10-14 15:08:13 +02:00
wrodrigues
4e21948f5c
Fixing the NetworkHelperImpl class. It was throwing a NPE due to a hypervisor type SIMULATOR not being in the hashmap.
...
When the refactor took place, we should have changed first structure, then behaviour. By refactoring the deployRouter method
we changed how the templateName was retrieved.
Fixed and tested using the simulator and the following Marvin tests
test_privategateway_acl
test_routers
test_vpc_vpn
test_service_offerings
test_volumes
test_reset_vm_on_reboot
test_multipleips_per_nic
Conflicts:
server/src/com/cloud/network/router/NetworkHelperImpl.java
2014-10-14 15:08:12 +02:00
wrodrigues
025ff72410
fixing checkstyle in the virtual network manager. problem appeared after a rebase. probably due to my saving action in the eclipse workspace
...
Conflicts:
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
2014-10-14 15:08:12 +02:00
Wilder Rodrigues
9f801d1f3a
Changing the way the DAOs were being injected in the RuleApplier;
...
Making code clearer and simple.
Conflicts:
server/src/com/cloud/network/rules/PrivateGatewayRules.java
server/src/com/cloud/network/rules/VirtualNetworkApplianceFactory.java
server/src/org/apache/cloudstack/network/topology/BasicNetworkTopology.java
server/src/org/apache/cloudstack/network/topology/NetworkTopologyVisitor.java
2014-10-14 15:08:12 +02:00
Wilder Rodrigues
60eea3bb1a
Adding fixes for the add user data and vpn rules
2014-10-14 15:08:11 +02:00
Wilder Rodrigues
f2f4732854
Removing the VirtualNetworkStatus, it was not being used properly;
...
fixing the injection of the network DAO in the PrivateGatewayRules;
all tests that were failing in Travis have been tested before the commit.
Conflicts:
server/src/com/cloud/network/router/NetworkHelperImpl.java
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
2014-10-14 15:08:11 +02:00
Wilder Rodrigues
dc5fefc018
making sure the instance variable _router in the Rules is being used instead of the parameter
...
Conflicts:
server/src/com/cloud/network/router/NetworkHelperImpl.java
2014-10-14 15:08:11 +02:00
Antonio Fornie
64eed6c6ab
Fix: VpcRouter has always PublicIp setup as it did before refactoring
2014-10-14 15:08:10 +02:00
Wilder Rodrigues
ee9068b5b2
merging cmd-visitor into cmd-visitor-rebase, with the upstream from ACS repo
...
Conflicts:
server/src/com/cloud/network/rules/DhcpRules.java
server/src/org/apache/cloudstack/network/topology/AdvancedNetworkTopology.java
2014-10-14 15:08:10 +02:00
wrodrigues
b7c193a88d
fixing nic plug unplug rule
...
Conflicts:
server/src/org/apache/cloudstack/network/topology/BasicNetworkVisitor.java
2014-10-14 15:08:10 +02:00
wrodrigues
5f51a06e3c
fix dhcp subnet rules. we can create VMs again.
2014-10-14 15:08:10 +02:00
Antonio Fornie
02c75251b3
Fixing NPE due to use of dependencies before Spring injection
2014-10-14 15:08:09 +02:00
Antonio Fornie
cd8cadaf9c
Refactor hypervisor retrieval from VpcNwHelper and NwHelper
...
Conflicts:
server/src/com/cloud/network/router/NetworkHelperImpl.java
server/src/org/cloud/network/router/deployment/RouterDeploymentDefinition.java
server/src/org/cloud/network/router/deployment/VpcRouterDeploymentDefinition.java
server/test/org/cloud/network/router/deployment/VpcRouterDeploymentDefinitionTest.java
2014-10-14 15:08:09 +02:00
Wilder Rodrigues
65fb21647a
auto wire the network helper
...
Conflicts:
server/src/org/apache/cloudstack/network/topology/BasicNetworkTopology.java
2014-10-14 15:08:09 +02:00
Wilder Rodrigues
546e563c27
refactor all private methods in the virtual router appliance and VPC appliance
...
Conflicts:
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java
server/src/com/cloud/network/rules/DhcpEntryRules.java
server/src/com/cloud/network/rules/LoadBalancingRules.java
server/src/com/cloud/network/rules/RuleApplier.java
server/src/com/cloud/network/rules/VirtualNetworkApplianceFactory.java
server/src/org/apache/cloudstack/network/topology/AdvancedNetworkTopology.java
server/src/org/apache/cloudstack/network/topology/AdvancedNetworkVisitor.java
server/src/org/apache/cloudstack/network/topology/BasicNetworkVisitor.java
server/src/org/apache/cloudstack/network/topology/NetworkTopology.java
2014-10-14 15:08:09 +02:00
Antonio Fornie
b5e96af4e2
Missing license headers
2014-10-14 15:02:14 +02:00
Antonio Fornie
2802d3b75b
Refactor and test NetworkHelper#sendCommandsToRouterWithNoAnswers
2014-10-14 15:02:14 +02:00
Wilder Rodrigues
e08cb11fc0
fixing check style issues
...
Conflicts:
server/src/com/cloud/network/element/VpcVirtualRouterElement.java
server/src/com/cloud/network/rules/AdvancedVpnRules.java
server/src/com/cloud/network/rules/RuleApplier.java
server/src/com/cloud/network/rules/VirtualNetworkApplianceFactory.java
server/src/org/apache/cloudstack/network/topology/AdvancedNetworkTopology.java
server/src/org/apache/cloudstack/network/topology/AdvancedNetworkVisitor.java
server/src/org/apache/cloudstack/network/topology/BasicNetworkTopology.java
server/src/org/apache/cloudstack/network/topology/BasicNetworkVisitor.java
server/src/org/apache/cloudstack/network/topology/NetworkTopology.java
2014-10-14 15:02:14 +02:00
wrodrigues
01edc8e394
adding setupPrivateGateway to new style;
...
removing methods from Vpc appliance;
changing the way VpcElement calls the command;
there is still work tob e done with the destroyPrivateGateway rule.
Conflicts:
server/src/com/cloud/network/rules/VirtualNetworkApplianceFactory.java
server/src/org/apache/cloudstack/network/topology/BasicNetworkTopology.java
server/src/org/apache/cloudstack/network/topology/NetworkTopology.java
2014-10-14 15:02:13 +02:00
Antonio Fornie
b9bff843c6
Whole router.deployment package got 97% coverage
...
Conflicts:
server/src/org/cloud/network/router/deployment/RouterDeploymentDefinitionBuilder.java
server/test/org/cloud/network/router/deployment/VpcRouterDeploymentDefinitionTest.java
2014-10-14 15:02:13 +02:00
Antonio Fornie
3d4ddb7251
DeployRouter includes nw creation following TellDontAsk principle
...
Also factor out NicProfile specific methods and fix some DI config.
Conflicts:
server/src/org/cloud/network/router/deployment/VpcRouterDeploymentDefinition.java
server/test/org/cloud/network/router/deployment/VpcRouterDeploymentDefinitionTest.java
2014-10-14 15:02:13 +02:00
wrodrigues
adebaf2bd0
adding applyStaticRoutes to the new visitor pattern.
2014-10-14 15:02:13 +02:00
Wilder Rodrigues
b96035f356
adding applyStaticRoutes method to the network topology/visitor. it will be used by the VPC virtual net manager appliance.
...
Conflicts:
server/src/com/cloud/network/rules/VirtualNetworkApplianceFactory.java
2014-10-14 15:02:12 +02:00
Antonio Fornie
2da3ceda31
Refactor to include network creation as actual deployment
...
Conflicts:
server/src/org/cloud/network/router/deployment/RouterDeploymentDefinition.java
server/src/org/cloud/network/router/deployment/RouterDeploymentDefinitionBuilder.java
server/src/org/cloud/network/router/deployment/VpcRouterDeploymentDefinition.java
server/test/org/cloud/network/router/deployment/VpcRouterDeploymentDefinitionTest.java
2014-10-14 15:02:12 +02:00
Wilder Rodrigues
00dc8a7b24
fixing check styles
...
Conflicts:
server/src/org/apache/cloudstack/network/topology/AdvancedNetworkTopology.java
server/src/org/apache/cloudstack/network/topology/BasicNetworkTopology.java
2014-10-14 15:02:12 +02:00
wrodrigues
16ad4122b4
moving sendCommand to the NetworkGeneralHelper;
...
adding handle single network method to the NetworkGeneralHelper;
moving getRealPriority to the NetworkGeneralHelper;
making priority constants part of the VirtualNetworkApplianceManager;
changing the network topology implementation in order to use the NetworkGeneralManager instead of the appliance
Conflicts:
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
server/src/org/apache/cloudstack/network/topology/AdvancedNetworkTopology.java
server/src/org/apache/cloudstack/network/topology/BasicNetworkTopology.java
2014-10-14 15:02:11 +02:00
Antonio Fornie
95d32b4d0d
Fix unnecessary changes Spring contexts
2014-10-14 15:01:17 +02:00
Antonio Fornie
0d81cf09f6
Increasing test coverage for Vpc Deployment
2014-10-14 15:01:16 +02:00
Antonio Fornie
240a539d43
Factor out prepareDeployment and update tests
2014-10-14 15:01:16 +02:00
Antonio Fornie
d2d9157ab0
Complete tests for normal deployment and start vpc one
...
Conflicts:
server/src/org/cloud/network/router/deployment/RouterDeploymentDefinitionBuilder.java
2014-10-14 15:01:16 +02:00
Wilder Rodrigues
12b0d188cb
Replacing the old [Vpc}VirtualNetworkApplianceManager by the new ones;
...
Implement the missing commands related to DHCP PV Lan and DHCP SubNet
Conflicts:
server/src/com/cloud/network/element/VirtualRouterElement.java
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
server/src/com/cloud/network/rules/DhcpRules.java
server/src/com/cloud/network/rules/VirtualNetworkApplianceFactory.java
server/src/org/apache/cloudstack/network/topology/AdvancedNetworkTopology.java
server/src/org/apache/cloudstack/network/topology/BasicNetworkTopology.java
server/src/org/apache/cloudstack/network/topology/BasicNetworkVisitor.java
server/src/org/apache/cloudstack/network/topology/NetworkTopologyVisitor.java
2014-10-14 15:01:16 +02:00
Antonio Fornie
a83f5790eb
License headers
2014-10-14 15:01:15 +02:00
Antonio Fornie
6fac12675d
More refactoring and testing in the same classes
...
Conflicts:
server/src/org/cloud/network/router/deployment/RouterDeploymentDefinitionBuilder.java
2014-10-14 15:01:15 +02:00
Antonio Fornie
f3c04172a4
RouterDeployment and VPC. Improving code and Unit Testing
2014-10-14 15:01:14 +02:00
Antonio Fornie
8852153d0c
Splitting Vpc and NonVpc deployment into phases & testing it
2014-10-14 15:01:14 +02:00
Wilder Rodrigues
325026de3f
fixing VPC IP Association and ACL rules. Have to rewrite in a better why the apply rules method in the Advanced Topology
2014-10-14 15:01:14 +02:00
Wilder Rodrigues
b97f2b05c7
apply network acls; acls items to pvt gw; vpc ip association
...
Conflicts:
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
server/src/com/cloud/network/rules/VirtualNetworkApplianceFactory.java
server/src/org/apache/cloudstack/network/topology/BasicNetworkTopology.java
2014-10-14 15:01:14 +02:00
Antonio Fornie
f23ba91ed1
Fixing null pointers during vpc router deployment
2014-10-14 15:01:13 +02:00
Wilder Rodrigues
bfd4316b58
adding new bean to spring context file; renaming package from "com" to "org"
2014-10-14 15:01:13 +02:00
Wilder Rodrigues
8437c2fda0
removing bean from the xml
2014-10-14 15:01:13 +02:00
Wilder Rodrigues
e35fded401
commenting broken code in tests in order to run build adn tests other changes via the UI
...
Conflicts:
server/test/com/cloud/network/router/VirtualNetworkApplianceManagerImplTest.java
2014-10-14 15:01:12 +02:00
Wilder Rodrigues
0b78731bc7
fixing import in virtual router element and checkstyle in dhcp entry related changes
...
Conflicts:
server/src/com/cloud/network/element/VirtualRouterElement.java
server/src/com/cloud/network/rules/DhcpEntryRules.java
server/src/org/apache/cloudstack/network/topology/AdvancedNetworkTopology.java
server/src/org/apache/cloudstack/network/topology/BasicNetworkTopology.java
server/src/org/apache/cloudstack/network/topology/BasicNetworkVisitor.java
2014-10-14 15:01:12 +02:00
Antonio Fornie
95395f9574
Deployment more OO - Objects with data and behavior
...
Conflicts:
server/src/com/cloud/network/element/VirtualRouterElement.java
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
2014-10-14 15:01:12 +02:00
wrodrigues
e99b5b0760
fixing the injection of the networkDao
...
Conflicts:
server/src/com/cloud/network/rules/VirtualNetworkApplianceFactory.java
2014-10-14 15:00:33 +02:00
Daan Hoogland
c76952b5ff
whitespace
...
Conflicts:
server/src/org/apache/cloudstack/network/topology/AdvancedNetworkVisitor.java
2014-10-14 15:00:33 +02:00
wrodrigues
d15329679b
fixing injection of beans with a relationship
...
Conflicts:
server/src/org/apache/cloudstack/network/topology/AdvancedNetworkTopology.java
server/src/org/apache/cloudstack/network/topology/BasicNetworkTopology.java
2014-10-14 15:00:33 +02:00
Wilder Rodrigues
8f313ca5d3
adding user data pwd rules
...
Conflicts:
server/src/org/apache/cloudstack/network/topology/AdvancedNetworkTopology.java
server/src/org/apache/cloudstack/network/topology/AdvancedNetworkVisitor.java
server/src/org/apache/cloudstack/network/topology/BasicNetworkTopology.java
2014-10-14 15:00:32 +02:00
Wilder Rodrigues
b9ffe2329e
making instance variables compliant with ACS convention
...
Conflicts:
server/src/com/cloud/network/rules/LoadBalancingRules.java
server/src/org/apache/cloudstack/network/topology/BasicNetworkTopology.java
2014-10-14 15:00:32 +02:00
Wilder Rodrigues
f0189ac3c3
adding userdata to router and ssh pub key to router rules.
...
Conflicts:
server/src/org/apache/cloudstack/network/topology/BasicNetworkTopology.java
server/src/org/apache/cloudstack/network/topology/BasicNetworkVisitor.java
2014-10-14 15:00:32 +02:00
Antonio Fornie
631b561d9c
Unify and encapsulate deployment flow methods and params
...
Conflicts:
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
2014-10-14 15:00:31 +02:00
Wilder Rodrigues
299c42c336
adding password to router rules; moving the advance code to the advance net topology.
...
Conflicts:
server/src/org/apache/cloudstack/network/topology/AdvancedNetworkTopology.java
server/src/org/apache/cloudstack/network/topology/BasicNetworkTopology.java
2014-10-14 14:55:26 +02:00
Wilder Rodrigues
87f0e68983
fixing the classes relationship; adding beans properly in the spring context; using the right basic/advance stuff; testing ip and port forwarding rules
...
Conflicts:
server/src/org/apache/cloudstack/network/topology/AdvancedNetworkVisitor.java
server/src/org/apache/cloudstack/network/topology/BasicNetworkTopology.java
server/src/org/apache/cloudstack/network/topology/BasicNetworkVisitor.java
2014-10-14 14:55:25 +02:00
Antonio Fornie
a98253296a
Temporary put state info in a state object
2014-10-14 14:55:25 +02:00
Daan Hoogland
e1866bf90d
package rename
...
Conflicts:
server/src/com/cloud/network/rules/DhcpEntryRules.java
server/src/com/cloud/network/rules/DhcpSubNetRules.java
2014-10-14 14:55:25 +02:00
Antonio Fornie
563f853d59
Fix offering setup
2014-10-14 14:55:24 +02:00
Wilder Rodrigues
6b2d35c8c2
adding Ip Association and VPN Rules
...
Conflicts:
server/src/com/cloud/network/topology/AdvancedNetworkVisitor.java
server/src/com/cloud/network/topology/BasicNetworkTopology.java
server/src/com/cloud/network/topology/NetworkTopologyVisitor.java
2014-10-14 14:55:24 +02:00
Wilder Rodrigues
f965fb9672
adding apache license headers
2014-10-14 14:55:24 +02:00
Wilder Rodrigues
7e98e3e132
we have to check if VPC is null bfore calling it. VPC is not used in gest networks, so deploying a new VM was broken.
2014-10-14 14:55:23 +02:00
Wilder Rodrigues
fb8973f1e2
adding static nat rules. Deploying new VMs is not working due to the appliance refactory, will check the changes with Antonio tomorrow.
...
Conflicts:
server/src/com/cloud/network/element/VirtualRouterElement.java
server/src/com/cloud/network/topology/AdvancedNetworkVisitor.java
2014-10-14 14:55:23 +02:00
Daan Hoogland
f17a0b835c
TODO
2014-10-14 14:55:23 +02:00
Wilder Rodrigues
4b1112af28
finished firewall rules and load balancing rules; fixed all the injection problems; added VirtualMachineManager to the appliance factory to be injected.
...
Conflicts:
server/src/com/cloud/network/element/VirtualRouterElement.java
server/src/com/cloud/network/router/NEWVirtualNetworkApplianceManagerImpl.java
server/src/com/cloud/network/topology/BasicNetworkTopology.java
2014-10-14 14:55:23 +02:00
Wilder Rodrigues
bbce7d944b
fixing checkstyles
...
Conflicts:
server/src/com/cloud/network/topology/AdvancedNetworkVisitor.java
server/src/com/cloud/network/topology/BasicNetworkTopology.java
2014-10-14 14:55:22 +02:00
Wilder Rodrigues
3457d0fbaf
changing accessor modifier in instance variables
2014-10-14 14:55:22 +02:00
Wilder Rodrigues
65d7e0756d
Adding Firewall Rules to comply with the Visitor pattern implementation; refactoring the applyRules so we can reuse it.
...
Conflicts:
server/src/com/cloud/network/rules/LoadBalancingRules.java
server/src/com/cloud/network/topology/AdvancedNetworkVisitor.java
server/src/com/cloud/network/topology/BasicNetworkTopology.java
server/src/com/cloud/network/topology/NetworkTopology.java
2014-10-14 14:55:22 +02:00
Antonio Fornie
24b230d11b
Fix dependency problem. Extract and unify router deployment stuff
...
Conflicts:
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
2014-10-14 14:55:22 +02:00
Antonio Fornie
f28426e1a2
Extract general behavior to Router and Vpc delegates
...
Conflicts:
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
2014-10-14 14:51:02 +02:00
Antonio Fornie
1a85213bbf
Rules and visitors for Load Balance Rules
...
Conflicts:
server/src/com/cloud/network/element/VirtualRouterElement.java
2014-10-14 14:46:38 +02:00
Sanjay Tripathi
176e0d47bb
CLOUDSTACK-6650: Reorder Cluster list in deployment planner to protect
...
GPU enabled hosts from non-GPU VM deployment.
Cluster reordering is based on the number of unique host tags in a cluster,
cluster with most number of unique host tags will put at the end of list.
Hosts with GPU capability will get tagged with implicit tags defined by
global config param 'implicit.host.tags' at the time os host discovery.
Also added FirstFitPlannerTest unit test file.
2014-10-14 17:55:37 +05:30
Sanjay Tripathi
e4a8bbcdf4
CLOUDSTACK-6650: Reorder Cluster list in deployment planner to protect
...
GPU enabled hosts from non-GPU VM deployment.
Cluster reordering is based on the number of unique host tags in a cluster,
cluster with most number of unique host tags will put at the end of list.
Hosts with GPU capability will get tagged with implicit tags defined by
global config param 'implicit.host.tags' at the time os host discovery.
Also added FirstFitPlannerTest unit test file.
2014-10-14 17:53:50 +05:30
Santhosh Edukulla
0a9742f914
Fixed few coverity issues
...
Signed-off-by: Santhosh Edukulla <santhosh.edukulla@gmail.com>
2014-10-14 17:16:50 +05:30
Nitin Mehta
a6d575b127
CLOUDSTACK-7699: Disable ROOT volume attach/detach ability.
2014-10-13 13:57:45 -07:00
Santhosh Edukulla
350ac4c4b0
Fixed Resource Leaks
...
Signed-off-by: Santhosh Edukulla <santhosh.edukulla@gmail.com>
2014-10-13 17:51:02 +05:30
Rajesh Battala
0f528df228
CLOUDSTACK-7313 Fixed issues in provisioning vpx in SDX from CS
2014-10-13 15:57:13 +05:30
Damodar
50185b7c3a
CLOUDSTACK-7648: There are new VM State Machine changes introduced which were missed to capture the usage events
2014-10-13 14:42:00 +05:30
Kishan Kavala
b6cacb3d67
change dos line ending to unix format
2014-10-13 12:34:32 +05:30
Edison Su
c10189f79a
if vpc public network with snat enabled, then will triger this issue;
...
(cherry picked from commit 6b8e0baa21 )
2014-10-13 00:39:10 -04:00
amoghvk
da73d735b2
Revert "CLOUDSTACK-6650: Reorder Cluster list in deployment planner to protect"
...
This reverts commit d910b4ff14 since it is causing encryption/decryption issues with RPM builds
(cherry picked from commit fbcab01ff0 )
2014-10-13 00:37:34 -04:00
Kishan Kavala
db79dd1ef5
CLOUDSTACK-2625, CLOUDSTACK-3401: Usage records are ordered by start_date which is not unique. While listing large datasets or when page size is small this will result in duplicates. Order records by id instead
...
(cherry picked from commit 63109a97b1 )
2014-10-13 00:36:30 -04:00
Sanjay Tripathi
eb447f14e2
CLOUDSTACK:7323: [vGPU] Creation of VM snapshot with "memory" is failing.
...
VM snapshot with memory is not supported for VGPU VMs, so putting checks
for same.
(cherry picked from commit 123ec8b3d3 )
2014-10-13 00:35:13 -04:00
Sanjay Tripathi
d058fa6880
CLOUDSTACK-6650: Reorder Cluster list in deployment planner to protect
...
GPU enabled hosts from non-GPU VM deployment.
Cluster reordering is based on the number of unique host tags in a cluster,
cluster with most number of unique host tags will put at the end of list.
Hosts with GPU capability will get tagged with implicit tags defined by
global config param 'implicit.host.tags' at the time os host discovery.
Also added FirstFitPlannerTest unit test file.
(cherry picked from commit d910b4ff14 )
2014-10-13 00:32:03 -04:00
Santhosh Edukulla
0df43197d9
Fixed few coverity issues
...
(cherry picked from commit 45597766a5 )
2014-10-13 00:30:01 -04:00
Anthony Xu
ba1862836e
ccp should not check public ip resource when deploy a vm on shared network
...
(cherry picked from commit 3201251256 )
2014-10-13 00:27:01 -04:00
Sanjay Tripathi
47d2a578ee
CLOUDSTACK-6650: Reorder Cluster list in deployment planner to protect
...
GPU enabled hosts from non-GPU VM deployment.
Cluster reordering is based on the number of unique host tags in a cluster,
cluster with most number of unique host tags will put at the end of list.
Hosts with GPU capability will get tagged with implicit tags defined by
global config param 'implicit.host.tags' at the time os host discovery.
Also added FirstFitPlannerTest unit test file.
(cherry picked from commit 39fe766c2b )
2014-10-13 00:15:03 -04:00
Likitha Shetty
54110edda1
CLOUDSTACK-6969. Data Volume Shrink operation failing with "Unexpected Exception".
...
(cherry picked from commit bca71ec169 )
2014-10-13 00:14:09 -04:00
Kishan Kavala
759b5fa048
For network stats aggregation job, get the most recent mgmt server id to do the aggregation. Set dao filter to descending.
...
(cherry picked from commit ce5c35b193 )
2014-10-13 00:13:45 -04:00
Anthony Xu
ee23be1942
when system VM ping times out, stop system VM
...
(cherry picked from commit 847e1e47ae )
2014-10-13 00:11:21 -04:00
Jayapal
26ac4dd395
CLOUDSTACK-7615: Update log msg to print error msg rather than exception
...
(cherry picked from commit 1d01ee3a60 )
2014-10-13 00:06:40 -04:00
Devdeep Singh
549840dd0d
CLOUDSTACK-7495. Volume resize is only supported on kvm, vmware and xenserver. If
...
the operation is tried on other hypervisors it fails but logs a stack trace. We
should just log a message that the operation isn't supported.
(cherry picked from commit ec1123aca1 )
2014-10-13 00:01:55 -04:00
Rohit Yadav
6e04f93785
CID-1192822: ids is a List<Long>, the cast to List<?> is removed
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit 92858afd55 )
2014-10-12 23:58:17 -04:00
Rohit Yadav
4d8dfc9b7c
CID-1192810: Remove useless control flow
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit f74446a195 )
2014-10-12 23:58:06 -04:00
Rohit Yadav
ff42d5ad54
CID-1211005: Fix comparison, Class<?> is always instance of Class
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit 59482b3eba )
2014-10-12 23:57:53 -04:00
Rohit Yadav
a35521315e
CID-1223274: Remove dead local storage code from VolumeApiServiceImpl
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit 60e492aeb9 )
2014-10-12 23:57:13 -04:00
Koushik Das
1b0618d39c
CLOUDSTACK-7595: Config parameters "job.expire.minutes" and "job.cancel.threshold.minutes" incorrectly getting multiplied by a factor of 60
...
Removed the unnecessary multiply factor for both the config parameters. Also removed the duplicate entries from Config.java as these are not required
(cherry picked from commit a6ee4112a5 )
2014-10-12 23:43:01 -04:00
Nitin Mehta
988b9efc97
CLOUDSTACK-7588: [Vmware] Creating templates (with same names) from volumes get deleted from CS. Fix it by changing the unique name generation to the standard one used by registertemplate. Also cleaned up vmtemplatevo which had too many constructors.
...
(cherry picked from commit 082aed3d33 )
2014-10-12 23:39:21 -04:00
David Nalley
ffe846673c
more revert cleanup
2014-10-12 23:31:17 -04:00
David Nalley
3cac7f01bb
Revert "CLOUDSTACK-6278"
...
This reverts commit bc2ec23d09 .
2014-10-12 23:19:30 -04:00
Edison Su
6b8e0baa21
if vpc public network with snat enabled, then will triger this issue;
2014-10-09 16:48:09 -07:00
amoghvk
fbcab01ff0
Revert "CLOUDSTACK-6650: Reorder Cluster list in deployment planner to protect"
...
This reverts commit d910b4ff14 since it is causing encryption/decryption issues with RPM builds
2014-10-09 15:39:19 -07:00
Kishan Kavala
63109a97b1
CLOUDSTACK-2625, CLOUDSTACK-3401: Usage records are ordered by start_date which is not unique. While listing large datasets or when page size is small this will result in duplicates. Order records by id instead
2014-10-09 10:27:49 +05:30
Sanjay Tripathi
123ec8b3d3
CLOUDSTACK:7323: [vGPU] Creation of VM snapshot with "memory" is failing.
...
VM snapshot with memory is not supported for VGPU VMs, so putting checks
for same.
2014-10-08 19:21:12 +05:30
Sanjay Tripathi
d910b4ff14
CLOUDSTACK-6650: Reorder Cluster list in deployment planner to protect
...
GPU enabled hosts from non-GPU VM deployment.
Cluster reordering is based on the number of unique host tags in a cluster,
cluster with most number of unique host tags will put at the end of list.
Hosts with GPU capability will get tagged with implicit tags defined by
global config param 'implicit.host.tags' at the time os host discovery.
Also added FirstFitPlannerTest unit test file.
2014-10-07 16:49:38 +05:30
Santhosh Edukulla
45597766a5
Fixed few coverity issues
2014-10-07 12:19:39 +05:30
Anthony Xu
3201251256
ccp should not check public ip resource when deploy a vm on shared network
2014-10-02 16:03:34 -07:00
amoghvk
0ef6cd36c4
Revert "CLOUDSTACK-6650: Reorder Cluster list in deployment planner to protect"
...
This reverts commit 39fe766c2b .
2014-10-02 13:28:52 -07:00
Sanjay Tripathi
39fe766c2b
CLOUDSTACK-6650: Reorder Cluster list in deployment planner to protect
...
GPU enabled hosts from non-GPU VM deployment.
Cluster reordering is based on the number of unique host tags in a cluster,
cluster with most number of unique host tags will put at the end of list.
Hosts with GPU capability will get tagged with implicit tags defined by
global config param 'implicit.host.tags' at the time os host discovery.
Also added FirstFitPlannerTest unit test file.
2014-10-01 17:25:41 +05:30
Likitha Shetty
bca71ec169
CLOUDSTACK-6969. Data Volume Shrink operation failing with "Unexpected Exception".
2014-10-01 15:41:50 +05:30
Kishan Kavala
ce5c35b193
For network stats aggregation job, get the most recent mgmt server id to do the aggregation. Set dao filter to descending.
2014-10-01 14:24:50 +05:30
Anthony Xu
847e1e47ae
when system VM ping times out, stop system VM
2014-09-30 12:35:44 -07:00
Jayapal
1d01ee3a60
CLOUDSTACK-7615: Update log msg to print error msg rather than exception
2014-09-29 17:15:42 +05:30
Devdeep Singh
ec1123aca1
CLOUDSTACK-7495. Volume resize is only supported on kvm, vmware and xenserver. If
...
the operation is tried on other hypervisors it fails but logs a stack trace. We
should just log a message that the operation isn't supported.
2014-09-26 13:15:31 +05:30
Rohit Yadav
f74446a195
CID-1192810: Remove useless control flow
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-09-25 17:02:13 +02:00
Rohit Yadav
92858afd55
CID-1192822: ids is a List<Long>, the cast to List<?> is removed
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-09-25 16:59:47 +02:00
Rohit Yadav
59482b3eba
CID-1211005: Fix comparison, Class<?> is always instance of Class
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-09-25 16:52:09 +02:00
Rohit Yadav
60e492aeb9
CID-1223274: Remove dead local storage code from VolumeApiServiceImpl
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-09-25 16:43:48 +02:00
Harikrishna Patnala
c55bc0b2d1
CLOUDSTACK-7534: ResetVM for VM with attached datadisk fails when enable.ha.storage.migration is false
...
Separate global config to enable/disable Storage Migration during normal deployment
Introduced a configuration parameter named enable.storage.migration
2014-09-24 16:35:23 +05:30
Hugo Trippaers
3a5401f8f9
Merge branch 'bugfix/CID-1240106'
2014-09-24 09:07:20 +02:00
Sheng Yang
aaeadc5c44
CLOUDSTACK-7605: Fix basic zone multiple pod network restart with cleanup=true
...
1. getRouters() doesn't handle RestartNetwork with cleanup=true for basic zone,
because pod wouldn't be specific at the time.
2. The regression caused by the following fix. The variable "routers" was
overrided with some local values, result in only one of the routers in multiple
pods would return, thus only one router would be started.
commit 6dd5c3fd42
Author: Rohit Yadav <bhaisaab@apache.org>
Date: Thu Oct 11 18:30:00 2012 +0530
CLOUDSTACK-70: Improve restart network behaviour for basic network
2014-09-23 14:17:42 -07:00
Hugo Trippaers
9ead2046d4
CID-1240106 Remove unused variable
2014-09-23 11:02:40 +02:00
Koushik Das
a6ee4112a5
CLOUDSTACK-7595: Config parameters "job.expire.minutes" and "job.cancel.threshold.minutes" incorrectly getting multiplied by a factor of 60
...
Removed the unnecessary multiply factor for both the config parameters. Also removed the duplicate entries from Config.java as these are not required
2014-09-22 16:45:37 +05:30
Nitin Mehta
082aed3d33
CLOUDSTACK-7588: [Vmware] Creating templates (with same names) from volumes get deleted from CS. Fix it by changing the unique name generation to the standard one used by registertemplate. Also cleaned up vmtemplatevo which had too many constructors.
2014-09-19 13:40:17 -07:00
Hugo Trippaers
2df41e857e
CID-1114592 Replaced duplicate code with a call to super
2014-09-19 14:47:13 +02:00
Hugo Trippaers
9cfab9b815
CID-1114591 Replace duplicated functionality with a call to super like the other state classes
2014-09-19 14:42:20 +02:00
Hugo Trippaers
cf4ff03c90
CID-1191682 Fix missing break statement
2014-09-19 08:28:42 +02:00
Frank Zhang
b11e3bc60a
CLOUDSTACK-6278
...
Baremetal Advanced Networking support
2014-09-18 16:54:37 -07:00
Frank Zhang
bc2ec23d09
CLOUDSTACK-6278
...
Baremetal Advanced Networking support
2014-09-18 16:54:37 -07:00
Koushik Das
4e07dd1dc4
CLOUDSTACK-7581: Empty 'ID' parameters allowed in API calls
...
Fix is to fail API calls with empty 'id' parameter value upfront rather than going ahead and failing with NPE later on
2014-09-18 17:10:25 +05:30
Daan Hoogland
dec9133dcd
CLOUDSTACK-7184: xenheartbeat gets passed timeout and interval
...
(cherry picked from commit 4d065b9a3a )
Conflicts:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/discoverer/XcpServerDiscoverer.java
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
server/src/com/cloud/configuration/Config.java
server/src/com/cloud/configuration/ConfigurationManagerImpl.java
server/src/com/cloud/resource/DiscovererBase.java
2014-09-18 12:51:10 +02:00
Rohit Yadav
bfa36c0280
CID-1233090, CID-1233089: Synchronize on session object in ApiServer
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-09-18 11:26:20 +02:00
Rohit Yadav
190bd38026
server: remove unused imports that failed build in last run
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-09-17 16:53:32 +02:00
Rohit Yadav
369b5b439b
CID-1192812: Remove dead code from DataCenterJoinDaoImpl
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-09-17 16:29:03 +02:00
Rohit Yadav
bfd8af0751
CID-1192811: Remove dead local store from VolumeJoinDaoImpl
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-09-17 16:27:41 +02:00
Rohit Yadav
c27dd6293e
CID-1233085: Fix potential NPE in AccountManagerImpl from VpcManagerImpl
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-09-17 15:56:03 +02:00
Rohit Yadav
a5004e37ad
CID-1233084: Fix NPE in persisting volume in VolumeApiServiceImpl
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-09-17 10:39:53 +02:00
Rohit Yadav
bdee5e3734
CID-1233086: Fix potential NPE blowup in UserVmManagerImpl
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-09-17 10:32:23 +02:00
Anthony Xu
cb45133799
for windows guest OS, configure gateway for each nic
2014-09-16 14:33:22 -07:00
Rohit Yadav
a1e8d5eefb
CID-1233087: In case of no virtual routers, fail early
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-09-16 17:27:32 +02:00
Rohit Yadav
fbbd2f8932
CID-1233088: In case there is no GSLB SP, throw cloud exception
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-09-16 17:17:11 +02:00
Anthony Xu
15a3bb318f
When deploying a VM with startvm=false, the root volume is in Allocated state, the root volume is not created in primary storage yet.
...
need to handle restoreVM for VM which is above status.
2014-09-15 18:49:15 -07:00
Nitin Mehta
0a4ab3251a
CLOUDSTACK-7513: listServiceOfferings API when called with VM's id also returns offerings to which it cant be upgraded. Adding the logic that when vmid is passed it looks for compatible offerngs using the storage type (local/shares), storage tags and also compute (cpu,speed, memory) in case the vm is running.
...
Also changed the scaleVm API to upgrade only when the destination offering has storage tags as a subset of current offering tags.
2014-09-15 11:02:34 -07:00
Saksham Srivastava
8c671c49b3
CLOUDSTACK-7548:removeNICFromVM should check for networkId while checking for PF rules on the nic
2014-09-15 19:15:09 +05:30
Devdeep Singh
283666b038
Password is logged in api server logs while creating a storage pool and while
...
adding an image store of type SMB. Cleaning the message before logging.
2014-09-12 14:31:17 +05:30
Frank Zhang
7a555b398f
CLOUDSTACK-7523
...
java.lang.NullPointerException when listing accounts
2014-09-10 14:43:41 -07:00
Frank Zhang
e06fa18ed2
CLOUDSTACK-6278
...
Baremetal Advanced Networking support
2014-09-10 14:43:41 -07:00
Ilia Shakitko
70142c4acb
Added "usageid" parameter to the "listUsageRecords" API call. Can be used only together with "type" parameter specified
...
Signed-off-by: Ilia Shakitko <i.shakitko@tech.leaseweb.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-09-10 12:19:34 +02:00
Rohit Yadav
91fd8d7cd5
CLOUDSTACK-7528: More verbose logging when sending alert fails
...
When sendAlert is called on an AlertManager impl, if it fails it logs that
something was wrong but does not log the body of the issue/error. This means
we tell the user/admin that there was an issue but don't share the "issue"
with them at all as the email alert fail (or that they were not initialized).
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit 885c02dbd8 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Conflicts:
server/src/com/cloud/alert/AlertManagerImpl.java
usage/src/com/cloud/usage/UsageAlertManagerImpl.java
2014-09-10 11:38:47 +02:00
Anthony Xu
63ea596ba2
removed unused class
...
engine/schema/src/com/cloud/upgrade/PremiumDatabaseUpgradeChecker.java
2014-09-09 18:31:13 -07:00
Kishan Kavala
c773754fda
CLOUDSTACK-7504,CLOUDSTACK-7507: For LXC host maintenance, migrate system Vms and schedule restart of users Vms
2014-09-08 18:13:11 +05:30
Frank.Zhang
10544e287b
CLOUDSTACK-6278
...
Baremetal Advanced Networking support
2014-09-05 16:28:34 -07:00
Frank Zhang
197332464f
CLOUDSTACK-6278
...
Baremetal Advanced Networking support
2014-09-05 16:28:33 -07:00
Nitin Mehta
f9d7a12a57
CLOUDSTACK-7481: Assertion/exception in listVolumes call from UI with assert enabled
...
searchForVolumesInternal() indicated some inconsistency in the use of entity().isDisplayVolume() property – used twice as “display” and “displayVolume” in search criteria. And then exception/assert happens while setting the property.
Correcting the issue.
2014-09-05 11:35:11 -07:00
Will Stevens
b145a7d140
null deref when no project found
2014-09-05 10:06:25 -04:00
Harikrishna Patnala
5d389b1a71
CLOUDSTACK-5992: default values of configuraiton parameters in configuration table are set NULL on fresh setup Some configuration parameters have Component names different from fresh and upgrade setup
...
Signed-off-by: Rajani Karuturi <rajanikaruturi@gmail.com>
2014-09-05 14:59:33 +05:30
Edison Su
ce82ab605d
listhost api needs to return host_details table
2014-09-04 17:57:24 -07:00
Will Stevens
0fa0320860
CLOUDSTACK-7418 and CLOUDSTACK-7488 - Fixed LB removal if cert is associated
2014-09-04 14:11:21 -04:00
Will Stevens
cacbc80ab1
Merge branch 'origin/CLOUDSTACK-7468'
2014-09-04 14:08:07 -04:00
Will Stevens
18653f6cd6
CLOUDSTACK-7418 and CLOUDSTACK-7488 - Fixed LB removal if cert is applied
2014-09-04 13:02:12 -04:00
Kishan Kavala
6f7c4863a2
CLOUDSTACK-7473: Vm migration is not supported for LXC. When host is put in maintenance mode, stop the Vms instead of migrating
2014-09-04 20:59:19 +05:30
Fred Clift
355eb72c7d
make virtual router /latest/.htaccess file be static - no longer dynamically generate it, remove code that managed the file previously
...
Signed-off-by: Sebastien Goasguen <runseb@gmail.com>
2014-09-04 04:22:27 -04:00
Mike Tutkowski
1d2f3300ad
Adding support for SolidFire snapshots
2014-09-03 20:09:00 -06:00
Will Stevens
5d11385c31
CLOUDSTACK-7468: Fixed the NetScaler SSL Termination behavior with Projects
...
Signed-off-by: Will Stevens <wstevens@cloudops.com>
2014-09-03 10:07:19 -04:00
Hugo Trippaers
dc3f0cbc63
Improve the handling of the findbug exclude files
2014-09-03 10:41:22 +02:00
Min Chen
47365ac4ba
Fix incorrectly written unit tests.
2014-09-02 17:55:44 -07:00
Min Chen
5f7b4dbbb2
CLOUDSTACK-7471:Regular user is allowed to deleteNetwork/RestartNetwork
...
that does not belong to him.He is also able to deploy Vm for other
users.
2014-09-02 17:24:08 -07:00
Mike Tutkowski
ba41f230e1
CLOUDSTACK-7467 (this part of the ticket is related to augmenting an error message)
2014-09-02 12:51:01 -06:00
Hugo Trippaers
f636611cac
Revert "server: Add event bus bean as commented xml in META-INF core"
...
Breaks CloudStack startup. You're better off putting this on the wiki
This reverts commit c730bc3491 .
2014-09-02 10:09:04 +02:00
Rohit Yadav
c730bc3491
server: Add event bus bean as commented xml in META-INF core
...
This adds a spring bean xml to have EventBus for ACS, but the bean is commented
so the event bus service won't start by default. I'm adding this for any developer
who may want to hack on events and may use it just by uncommenting it and fixing
options.
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-09-01 21:26:43 +02:00
Kishan Kavala
f44be742f8
CLOUDSTACK-7447: Send modify storage pool command on host connect to LXC hosts
2014-09-01 12:39:05 +05:30
Rohit Yadav
33a249e77a
CLOUDSTACK-7455: Fix possible case for NPE
...
NPE can happen if Spring fails to inject api authenticator, so better check
and set list of commands if the authenticator is not null or returning null cmds
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-31 14:42:18 +02:00
Mike Tutkowski
de6a3112b6
Update to volume-resize logic
2014-08-28 23:19:04 -06:00
Rohit Yadav
6eae9b8596
saml: disable plugin by default and don't initiate if not enabled
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-28 19:49:48 +02:00
Rohit Yadav
249446dc52
server: add config to enable/disable SAML SSO/SLO plugin
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-28 19:45:27 +02:00
Rohit Yadav
b0f3d66f9d
Config: add config for saml user account, domain and redirected URL to ACS UI
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-28 19:45:25 +02:00
Rohit Yadav
47ccce85a1
api: add method to pass on api authenticators to cmd classes
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-28 19:45:24 +02:00
Rohit Yadav
0444bfb653
server: Add IDP entity ID config param
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-28 19:45:24 +02:00
Rohit Yadav
5d94fd5be5
server: Add SAML related config params in Config
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-28 19:45:23 +02:00
Rohit Yadav
37d696db80
ApiServer: Fix imports order, use org.apache.cloudstack.api.ApiServerService
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-28 19:45:23 +02:00
Rohit Yadav
591a686d77
server: fix server package after auth plugin refactor
...
- Have opensaml dependency to get version from root pom
- add com.cloud.api.auth.APIAuthenticationManagerImpl to spring ctx manager
- Fix getCommands() in APIAuthenticationManagerImpl
- Fix imports in resources, test and src classes
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-28 19:45:23 +02:00
Rohit Yadav
68e094ebaf
saml: move refactor files from server to api module
...
- Move interfaces and classes from server to api module
- This can be then used for pluggable api authenticators
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-28 19:45:22 +02:00
Rohit Yadav
a364054db6
Minor fixes
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-28 19:45:21 +02:00
Rohit Yadav
2464e02bf4
SAML2LoginAPIAuthenticatorCmd: Set all necessary cookies and redirect to UI
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-28 19:45:21 +02:00
Rohit Yadav
2694ad7bd9
ApiServlet: Fix NPE while inserting to auditTrail
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-28 19:45:21 +02:00
Rohit Yadav
a1dc9e8189
SAML2LoginAPIAuthenticatorCmd: Implement SAML SSO using HTTP Redirect binding
...
- Creates SAMLRequest and uses HTTP redirect binding (uses GET/302)
- Redirects to IdP for auth
- On successful auth, check for assertion
- Tries to get attributes based on standard LDAP attribute names
- Next, gets user using EntityManager, if not found creates one with NameID as UUID
- Finally tries to log in and redirect
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-28 19:45:21 +02:00
Rohit Yadav
9c7204d386
DefaultLoginAPIAuthenticatorCmd: move createLoginResponse to ApiServer
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-28 19:45:21 +02:00
Rohit Yadav
1a3813a342
ApiServer: change loginUser method signature to return ResponseObject
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-28 19:45:20 +02:00
Rohit Yadav
b82207e081
SAML: WIP redirections work now
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-28 19:45:20 +02:00
Rohit Yadav
18ff47efc0
server: add opensaml as dependency
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-28 19:45:20 +02:00
Rohit Yadav
df95a762f4
SAML2: add saml sso and slo apicmds skeleton, add classes to AuthManager
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-28 19:45:20 +02:00
Saksham Srivastava
d9531fb0de
CLOUDSTACK-7453: Network rate field specified with negative value in service offering results in db Exception
2014-08-28 16:01:11 +05:30
Saksham Srivastava
490d499b7f
CLOUDSTACK-7453: Network rate field specified with negative value in service offering results in db Exception
2014-08-28 15:28:00 +05:30
Kishan Kavala
55983d47c0
CLOUDSTACK-7400: Allow migration of systemVms in LXC. USer Vms cannot be migrated
2014-08-27 13:05:04 +05:30
Kishan Kavala
08dc5c6f91
CLOUDSTACK-7428: Allow LXC cluster in SG enabled zones. Use lxc driver in security_group.py script for lxc host
2014-08-27 11:52:59 +05:30
Saksham Srivastava
9fb2a760c6
CLOUDSTACK-300: Creation of compute offering allow combination of local storage + HA
2014-08-26 14:48:51 +05:30
Jayapal
384025f258
CLOUDSTACK-7218: Remvoing all static nat associated with vm in case of secondary ips
...
In vm secondary ips case static nat configured to vm primary/secondary ips
IP1-->vm1Ip1, IP2-->vm1Ip2
While destroying vm deleting all static nats associated with the vm
2014-08-26 14:29:23 +05:30
Rohit Yadav
d71c19f91c
ApiXmlDocWriter: add more search name spaces to find APIs
...
Whenever a new API command is added to CloudStack, if developers are not using
the recommended namespace of org.apache.cloudstack.api.* they should add their
custom namespace/package here. ApiXmlDocWriter uses ReflectUtils to find APIs
within these packages (which must be also available in cloud-client).
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-25 18:16:28 +02:00
Likitha Shetty
433ec7c856
Fixed few issues reproted by coverity.
2014-08-25 16:11:58 +05:30
Mike Tutkowski
3773ff060e
Update to volume-resize logic
2014-08-21 20:18:20 -06:00
Min Chen
1436ce62b6
CLOUDSTACK-7394:Caller should be owner after creating template from
...
snapshot/volume.
2014-08-21 17:16:13 -07:00
Santhosh Edukulla
19ffc93e2e
Fixed few coverity reported issues:Aug22 2014
2014-08-21 17:09:27 +05:30
Rohit Yadav
e3b3a18aef
ConfigurationManagerImpl: Fix NPE when trying to access method on null object
...
Before checking obj.length, the fix is to check that the obj is not null
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-21 11:34:44 +02:00
Bharat Kumar
cab2b12d7d
CLOUDSTACK-7155 Re-copying templates to other zones doesn't work
2014-08-21 09:50:54 +05:30
Mike Tutkowski
ffa4d73290
Update to volume-resize logic
2014-08-20 13:18:33 -06:00
Harikrishna Patnala
8d0817860f
CLOUDSTACK-7337: Volume state remains in allocated after volume creation faliure from snapshot Volume should be marked to Destroy state after creation faliure.
...
Signed-off-by: Koushik Das <koushik@apache.org>
2014-08-20 17:39:53 +05:30
Wei Zhou
880bff28e0
CLOUDSTACK-7362: fix wrong uuid issue for resource tags
...
(cherry picked from commit 838a1a8476 )
2014-08-18 16:17:36 +02:00
Wei Zhou
b035a444c6
CLOUDSTACK-7308: add tags to all security group rules
...
(cherry picked from commit ae1b87ca23 )
2014-08-18 16:17:28 +02:00
seif
59ea2e2960
Added the listHostTags API command
2014-08-17 20:38:46 -06:00
Stephen Hoogendijk
6978c18c3a
CLOUDSTACK-7308 - Adds tagging support for security group rules
2014-08-15 09:39:53 +02:00
Girish Chaudhari
adf7de9a95
CLOUDSTACK-5663 : Added the NULL CIDR check to avoid NPE for createNetwork and listNetwork
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-08-14 10:34:45 +02:00
Min Chen
fee2bfce49
CLOUDSTACK-7344:VOLUME.DELETE usage event missing for VM's in ERROR
...
state.
2014-08-13 22:15:47 -07:00
Anthony Xu
90fe6d8087
removed trailing space
2014-08-13 11:09:38 -07:00
Rohit Yadav
31fbb20648
ApiXmlDocWriter: Don't hardcode around login api or skip it based on key name
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-13 14:05:18 +02:00
Luis Henrique Okama
cb9319d3d8
bugfix CLOUDSTACK-7309 using findProjectByProjectAccountIdIncludingRemoved
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-13 00:07:25 +02:00
Min Chen
e3564658be
CLOUDSTACK-6940, CLOUDSTACK-7312, CLOUDSTACK-5512: Template/ISO/Volume
...
upload rejects some valid URL formats. Also consolidate URL format check
into one util routine.
2014-08-12 11:43:08 -07:00
Min Chen
83bd4d60f1
Revert "CLOUDSTACK-7312:ISOs cannot be downloaded from URLs without matching"
...
This reverts commit 737f76df8c .
2014-08-12 11:43:08 -07:00
Min Chen
a8316de725
Revert "CLOUDSTACK-6940:Templates cannot be downloaded from URLs without"
...
This reverts commit 569e94908b .
2014-08-12 11:43:08 -07:00
Harikrishna Patnala
6568e0bb31
CLOUDSTACK-7305: hypervisor type parameter is mandatory when deploying VM using ISO
...
Signed-off-by: Koushik Das <koushik@apache.org>
2014-08-12 16:27:48 +05:30
Rohit Yadav
ae207bea98
DefaultLoginAPIAuthenticatorCmd: return userId as UUID
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-12 12:01:32 +02:00
Rohit Yadav
384acffff4
ApiServer: take UTF_8 and other static vars from HttpUtils
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-12 12:01:32 +02:00
Rohit Yadav
3cc6efce04
ApiServlet: use HttpUtils instead of class specific implementation
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-12 12:01:32 +02:00
Rohit Yadav
983252cffd
ApiResponseSerializer: Use HttpUtils instead of BaseCmd
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-12 12:01:32 +02:00
Rohit Yadav
f11dcf8ef5
ApiServletTest: Fix test, now login/logout have their own API/class
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-12 12:01:31 +02:00
Rohit Yadav
224dc9f8e5
APIAuthenticator: refactor signature of APIAuthenticator interface's authenticate
...
Pass HttpServletResponse as it can be useful for authenticators which need to
have their own writer interface/method
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-12 12:01:31 +02:00
Rohit Yadav
6ec1a1b604
ApiServlet: move setting of response type up in the layer
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-12 12:01:31 +02:00
Rohit Yadav
7434f1bd33
ApiXmlDocWriter: get rid of hardcoded login/logout docs
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-12 12:01:31 +02:00
Rohit Yadav
ee57f47e29
ApiServlet: use the new and refactored authentication mechanism
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-12 12:01:31 +02:00
Rohit Yadav
2e5bbc9a0d
ApiXmlDocWriter: remove hardcoded login and logout apis
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-12 12:01:31 +02:00
Rohit Yadav
b587291d55
ApiResponseSerializer: Skip extra boxing for Auth responses
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-12 12:01:30 +02:00
Rohit Yadav
bd2898e491
APIAuthenticationManagerImpl: add the auth manager and bean entry in spring xmls
...
- This implements ManageBase, is a pluggable service
- Has a mechanism to return commands, useful for apidocs etc.
- Has a method to return APIAuthenticator based on API command name
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-12 12:01:30 +02:00
Rohit Yadav
f7821ecf09
DefaultLoginAPIAuthenticatorCmd: Refactor and implement the default login mechanism
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-12 12:01:30 +02:00
Rohit Yadav
1330559b8d
DefaultLogoutAPIAuthenticatorCmd: Refactor and implement the logout mechanism
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-12 12:01:30 +02:00
Rohit Yadav
ac3adfeca7
APIAuthenticationManager: Add Auth manager definition
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-12 12:01:30 +02:00
Rohit Yadav
4d3fbc54ad
APIAuthenticationType: Add auth enum type, login or logout
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-12 12:01:30 +02:00
Rohit Yadav
31722c2674
APIAuthenticator: Add interface definition for the auth mechanisms
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-12 12:01:29 +02:00
Min Chen
737f76df8c
CLOUDSTACK-7312:ISOs cannot be downloaded from URLs without matching
...
file extensions.
2014-08-11 15:00:32 -07:00
amoghvk
d1d722f9bd
CLOUDSTACK-7295: VMs is Stopped state have no host ID, resulting in NPE
2014-08-11 14:56:58 -07:00
Alena Prokharchyk
97efbc56e4
CLOUDSTACK-7283: listUsers - for regular user, only return the caller info. If there are more users under the same account, their information should never be returned
2014-08-11 13:51:11 -07:00
Rajani Karuturi
736ff5f8e5
Fixed CLOUDSTACK-7303 [LDAP] while importing ldap users, update the user info if it already exists in cloudstack
2014-08-11 17:54:31 +05:30
Santhosh Edukulla
fd96ad02d7
Fixed few coverity reported issues around concurrency, null checks
2014-08-11 16:55:23 +05:30
Santhosh Edukulla
f9e11540c7
Fixed few coverity issues
2014-08-11 16:02:19 +05:30
Alena Prokharchyk
354756219c
CLOUDSTACK-6486: Guest network guru - when add network, validate isolation method in case insensitive manner
2014-08-08 17:08:13 -07:00
Min Chen
d33278250d
CLOUDSTACK-7264:NPE while creating scheduled/recurring snapshots for the
...
removed account with cleanup_needed=1.
2014-08-08 09:42:55 -07:00
seif
67ca2557f9
Changes for a new API command to list the storage tags
2014-08-07 17:46:06 -06:00
Alena Prokharchyk
6d1482b97b
CLOUDSTACK-7283: listUsers API is available for regular users now
2014-08-07 14:01:58 -07:00
Nitin Mehta
f424a04b0c
CLOUDSTACK-7272: Router stop fails with NPE. Fixing it by making the hostId as Long object than native type long. The issue was the response was checking for getHostId() != null to populate attribute hypervisor. But since the hostId is declared as long it will never be null, resulting in the NPE when populating hypervisor. Fixed that
2014-08-06 18:06:33 -07:00
Santhosh Edukulla
dda2820552
Fixed Coverity reported type issues
2014-08-06 15:27:00 +05:30
Nitin Mehta
b9d834e838
CLOUDSTACK-4200: listSystemVMs API and listRouters API should return hypervisor property since dynamic scaling is not enabled for all the hypervisors and that action can be showed only for the hypervisors that support it.
2014-08-05 17:29:34 -07:00
Anthony Xu
129437c636
added more log
2014-08-05 16:41:38 -07:00
Rohit Yadav
1176a836af
server: use scoped variable in pom.xml for build.properties file path
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-05 18:30:14 +02:00
Ilia Shakitko
07f916dfc6
CLOUDSTACK-7159 Added "state" parameter to the "listPublicIpAddresses" API call
...
Signed-off-by: Ilia Shakitko <i.shakitko@tech.leaseweb.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-05 18:13:38 +02:00
namita.chaudhari
fce2880b9f
CLOUDSTACK-2694: Able to configure duplicate firewall rule with protocol and no ports
...
Signed-off-by: Jayapal <jayapal@apache.org>
2014-08-05 17:57:54 +05:30
Damodar
221c118b4f
CLOUDSTACK-7245: listIsos call does not return isdynamicallyscalable in the response attributes as mentioned in API docs.
2014-08-05 16:06:01 +05:30
Nitin Mehta
835ca8eea8
CLOUDSTACK-7018: Restore VM - missing destroyed usage event for the destroyed root volume. Also removed the resource count logic since we destroy the old root volume and create a new one.
2014-08-04 16:40:28 -07:00
Min Chen
8a21633050
CLOUDSTACK-7239:Wrong message thrown on Primary Storage addition failure
...
in some cases.
2014-08-04 16:04:38 -07:00
Frank.Zhang
1ee7e0c77e
CLOUDSTACK-6278
...
Baremetal Advanced Networking support
2014-08-04 15:00:44 -07:00
Frank.Zhang
44dff6c426
CLOUDSTACK-6278
...
Baremetal Advanced Networking support
2014-08-04 15:00:44 -07:00
Alena Prokharchyk
05d056bb90
CLOUDSTACK-7194: deployVm Api, "hypervisor" parameter:
...
* is respected only when vm is deployed from ISO, or hypervisorType is not set on the template record
* if parameter passed when vm is deployed from template having hypervisor info set, validate that these 2 parameters are the same instead of silently defaulting the final value to the one set on the template
2014-08-04 14:21:52 -07:00
Santhosh Edukulla
b7d3f1bd30
Fixed few coverity issues for resource synchronization
2014-08-04 16:09:26 +05:30
Edison Su
29f711e0a9
remove unused servlet
2014-08-01 16:55:35 -07:00
Alena Prokharchyk
ffeca8bbd2
CLOUDSTACK-7209: handle the case when network fails to implement NoTransitionException, and null is returned to the caller stack. All caller methods should verify if the return value is null before processing it further.
2014-08-01 09:47:28 -07:00
Likitha Shetty
f803100813
CLOUDSTACK-6969. Data Volume Shrink operation failing with "Unexpected Exception".
...
For ResizeVolume API command -
1. If hypervisor resource throws an exception, handle the NPE thrown by the job framework.
2. Improve user error message in case of RuntimeException by throwing the exception instead of 'Unexpected Exception'.
2014-08-01 16:23:47 +05:30
Santhosh Edukulla
92c70f03e0
Fixed Coverity Issues
2014-08-01 16:16:12 +05:30
Jayapal
d28da9d986
CLOUDSTACK-7212: Failed creating LB rule on public port 8081 for VR as LB provider
2014-08-01 15:54:17 +05:30
Anthony Xu
5fb03aec9b
check if admin user exists
2014-07-31 13:44:58 -07:00
Rohit Yadav
89fabe82b9
CLOUDSTACK-7211: Add Guest OS mapping before returning VirtualMachineTO object
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-07-31 19:03:51 +02:00
Santhosh Edukulla
b371356abc
Fixed coverity issues reported
2014-07-31 21:19:57 +05:30
Mike Tutkowski
b919da8a5c
CLOUDSTACK-7173
2014-07-30 19:27:45 -06:00
Alena Prokharchyk
89017a7d7b
CS-19072: got rid of unneeded type casting when apply pagination to different resources
2014-07-30 10:33:45 -07:00
Santhosh Edukulla
dc2346147b
Fixed few coverity issues reported
2014-07-30 17:06:35 +05:30
Devdeep Singh
96b5c08250
CLOUDSTACK-7136. While listing hosts for migration, the offering details were
...
not correctly initialized in the vmprofile. With a custom offering the cpu,
cpu-speed and memory were getting initialized to null which caused a NPE in
the allocator. Fixed it by explicitly initializing the offering details in the
vm profile before calling into the allocator for listing suitable hosts.
2014-07-30 16:32:10 +05:30
Devdeep Singh
fc14fe1132
CLOUDSTACK-7201. Before initating out live volume migration to a pool check that if the
...
destination pool is a cluster wide pool, it should be in the same cluster as the vm to
which the volume is attached.
2014-07-30 13:01:29 +05:30
Rajani Karuturi
5fa2d1c7ca
Fixed Bug: CLOUDSTACK-7200 [LDAP] importUsersCmd for a group fails incase any member of a group is not an user
2014-07-30 12:02:24 +05:30
Anthony Xu
fefb0028fe
HA VM with local storage works
2014-07-29 16:31:33 -07:00
Alena Prokharchyk
3d34a136a6
CLOUDSTACK-6168: fixed the description for global config "vm.instancename.flag" - the flag is applicable for VMware hypervisor only
2014-07-29 11:15:37 -07:00
Alena Prokharchyk
477f91327c
CS-19072: fixed broken pagination and count in listVpcs
2014-07-28 15:26:02 -07:00
Alena Prokharchyk
fa74b3a300
CS-19072: fixed broken pagination and count in listVpcOfferings
2014-07-28 14:44:12 -07:00
Alena Prokharchyk
8b98cc2202
CS-19072: fixed broken pagination and count in listNetworkOfferings
2014-07-28 14:44:04 -07:00
Alena Prokharchyk
ca8d3672e8
listNetworks: moved pagination post processing to StringUtils class
2014-07-28 14:43:55 -07:00
Anthony Xu
330c4ba578
completed the new vmsync TODOs in the code.
...
removed old vmsync logic
2014-07-28 12:51:37 -07:00
Min Chen
a216046191
CLOUDSTACK-7165:[Automation] NPE observed during restart and expunge VM.
2014-07-25 15:51:47 -07:00
Santhosh Edukulla
343943fd4e
Fixed Coverity Issues Reported
2014-07-25 16:45:16 +05:30
Santhosh Edukulla
5ee9a3cc8a
Fixed Coverity Issues Reported
2014-07-25 16:44:18 +05:30
Santhosh Edukulla
deeb754bfa
Fixed Coverity Issues Reported
2014-07-25 16:42:14 +05:30
Santhosh Edukulla
16b1746111
Fixed Coverity Issues Reported
2014-07-25 16:40:43 +05:30
Rajesh Battala
ea740aa0e1
fixed CLOUDSTACK-7090 Console proxy key store password should be securely generated
2014-07-25 14:20:52 +05:30
Kishan Kavala
c61c636ce8
CLOUDSTACK-5946: Commit 2774b62d64 changed keystore file along with coverity fixes. Use varible name for keystore filename to keep it in sync
2014-07-25 14:07:46 +05:30
Nitin Mehta
2ed22b3ba7
CLOUDSTACK-5641: Local disk usage on host don't show up in the admin's webui. Correcting the view to include capacity type 9 which is local storage. Also changing the response to just pick the used bytes coming in through the view which now stands corrected.
...
Verified that the dashboard and storage pool view works fine.
2014-07-24 17:16:30 -07:00
Edison Su
2f832fddff
CLOUDSTACK-7164: fix NPE
2014-07-24 17:01:23 -07:00
Edison Su
165618ac9a
CLOUDSTACK-7166: fix NPE
2014-07-24 16:58:30 -07:00
Hugo Trippaers
1440a1c6a0
Fix CID 1114609 Log the correct number
2014-07-24 12:21:37 +02:00
Bharat Kumar
da55aff64f
CLOUDSTACK-7158 listCapacity API missing types for certain zones
2014-07-24 14:33:51 +05:30
Saksham Srivastava
0f85e649b6
CLOUDSTACK-5999: Virtual Router does not start if Guest VM is rebooted from CloudStack
2014-07-24 10:45:51 +05:30
Min Chen
e6ead3176c
CLOUDSTACK-7175:Domain Id is exposed in error message when cross domain
...
access is attempted when listing Vms.
2014-07-23 17:36:15 -07:00
Daan Hoogland
7f14da6406
rats
2014-07-23 21:31:50 +02:00
Daan Hoogland
b8112ac79e
highlevel 'unit'-test for refactoring of (Vpc)VirtualNetworkApplianceManagerImpl
2014-07-23 21:30:21 +02:00
Daan Hoogland
44be176486
rename networkMgr to networkMdl to prevent name clashes in mocks of
...
VirtualRouterElement and VirtualNetworkApplianceManagerImpl
2014-07-23 21:19:31 +02:00
amoghvk
c804660c74
CLOUDSTACK-7168: Revert "Fixed Coverity Issues reported" that broke CI
...
This reverts commit 4523490d44 .
2014-07-23 11:37:36 -07:00
Damodar
c43b56998a
CLOUDSTACK-7153: addNicToVirtualMachine not BaseAsyncCreate but creates an entity
2014-07-23 09:28:32 +05:30
Santhosh Edukulla
4523490d44
Fixed Coverity Issues reported
...
Signed-off-by: Santhosh Edukulla <santhosh.edukulla@gmail.com>
2014-07-22 18:03:36 +05:30
Hugo Trippaers
4bf321bd03
Fix equality check using != on objects
...
Cleanup in the code, removing dead code
2014-07-22 13:14:26 +02:00
Hugo Trippaers
2833366415
Remove dead code
2014-07-22 13:12:47 +02:00
Likitha Shetty
493fd17054
CLOUDSTACK-7152. Attaching datadisk to VMs that have VM snapshot throws 'Unexpected exception'.
...
Like with other API commands, ensure input parameter validation for AttachVolume happens outside the job queue.
2014-07-22 15:13:37 +05:30
Nitin Mehta
77dadd75c4
CLOUDSTACK-6787: Publishing uuids missing in some cases, adding/correcting events in some cases.
...
Also fixed a bug in the global config framework.
2014-07-21 14:08:18 -07:00
Murali Reddy
9dc322d46f
CLOUDSTACK-7144: No GSLB provider is available during assigning load
...
balancing rule
this fix ensures any bean implementing GslbProvider interface are injected
into GlobalLoadBalancingRulesServiceImpl.
2014-07-21 16:50:21 +05:30
Suresh Ramamurthy
03de9cc335
CLOUDSTACK-6845 : NuageVsp Network plugin
...
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-07-21 10:49:49 +02:00
Rajani Karuturi
8b2efee61c
Fixed coverity reported issues in UserVmManagerImpl
2014-07-21 08:24:23 +05:30
Ian Duffy
8716376b4a
remove unused import
2014-07-20 18:15:52 +01:00
Ian Duffy
d4428a93a8
Allow for length of password on VMs to be set via global settings
...
Conflicts:
server/src/com/cloud/vm/UserVmManagerImpl.java
setup/db/db/schema-430to440.sql
2014-07-20 18:14:55 +01:00
Mike Tutkowski
08d7b46be7
Update to volume-resize logic
2014-07-19 00:42:04 -06:00
Edison Su
1bb3ea8b7a
CLOUDSTACK-6918: iterate through pending works in cancel maitenance
2014-07-18 15:39:30 -07:00
amoghvk
cfcc4a076d
CLOUDSTACK-6358: KVM mappings for CentOS 6.x and RHEL 6.x
2014-07-18 15:10:10 -07:00
Murali Reddy
2f293f42d5
CLOUDSTACK-7129: Non-admin user can use deleteNetwork with shared
...
networks
fix ensures only admin users can delete shared network
2014-07-18 17:52:09 +05:30
Harikrishna Patnala
0069037573
CLOUDSTACK-7113: Ability to reset password when Router VM is stopped
...
With this improvement password reset also happens when router is in stopped state on resetPasswordCmd and restoreVM
2014-07-18 14:37:44 +05:30
Mike Tutkowski
b080eaf327
Updates to the way resizing a volume works
2014-07-17 21:09:19 -06:00
Daan Hoogland
3b76278b97
rvr4vpc: more interesting test
2014-07-17 15:32:03 +02:00
Saksham Srivastava
d382be9578
CLOUDSTACK-6508: impossible to list projects from API with domainid set
2014-07-17 14:26:25 +05:30
Likitha Shetty
d3e7b43ee9
CLOUDSTACK-7119. [VMware] Don't allow VM reset when VM has snapshots.
2014-07-17 13:32:16 +05:30
Daan Hoogland
27bc791746
rats
2014-07-17 09:23:03 +02:00
Edison Su
771b53b342
CLOUDSTACK-4725: if storage pool has different path, but the uuid is the same, then treat them as the same storage pool
2014-07-16 16:38:17 -07:00
Daan Hoogland
5b37c65577
oversimplified test fixed
2014-07-16 17:28:01 +02:00
Hugo Trippaers
b0d7e10aef
Prevent a NPE when shutting down a network that did not have a vlan
...
assigned yet.
2014-07-16 16:57:12 +02:00
Daan Hoogland
cc37eb50cf
checkstyle: unused imports
2014-07-16 16:52:02 +02:00
Daan Hoogland
799258662c
rvr4vpc simple test for deployRouter
2014-07-16 16:44:28 +02:00
Hugo Trippaers
dbc7d80329
Aggregate command cleanup is not required for the virtual router as we
...
already cleanup in the finish.
And consequently dies if somebody tries to test with assertions enabled.
2014-07-16 16:24:54 +02:00
Daan Hoogland
5ccd904e83
simple first test for backward compatibility testing in rvr4vpc work
2014-07-16 10:59:58 +02:00
amoghvk
3d8dd1c921
Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/cloudstack
2014-07-14 17:30:12 -07:00
Amogh Vasekar
c30821f703
CLOUDSTACK-6671: Missing patch in master
2014-07-14 17:00:08 -07:00
Amogh Vasekar
09069fcc87
CLOUDSTACK-6358: Add missing patches in master for KVM
2014-07-14 16:51:55 -07:00
Alena Prokharchyk
4f0640dac4
CLOUDSTACK-6595: allow to expunge the vm when its in Error state, in addition to Expunging/Destroyed states
2014-07-14 14:40:11 -07:00
Jayapal
778e04cb77
CLOUDSTACK-7104: perform ipassoc for ip when network is implemented after the gc
2014-07-14 19:50:36 +05:30
Alena Prokharchyk
63b81995f6
CLOUDSTACK-7100: update global config - trim leading and trailing whitespaces before global config value update
2014-07-11 16:02:51 -07:00
Alena Prokharchyk
7098367dc6
Fixed code causing warnings in ActionEventUtils
2014-07-11 14:59:39 -07:00
Likitha Shetty
00778de96e
CLOUDSTACK-7099. Volume snapshot is not getting backed up.
...
Correctly inject ConfigDao into SnapshotStateListener.
2014-07-11 17:06:15 +05:30
Jayapal
73b622c823
CLOUDSTACK-7068: addIpToNicCmd changed to BaseAsyncCreate
2014-07-09 14:57:25 +05:30
Min Chen
cc8fc746df
CLOUDSTACK-6468:IAM - Templates - Admin user is not allowed to edit
...
template and set isExtractable() paramater.
(cherry picked from commit b6617843d2 )
Signed-off-by: Nitin Mehta <nitin.mehta@citrix.com>
2014-07-08 14:20:45 -07:00
Alena Prokharchyk
b517156fe3
CLOUDSTACK-7039: don't log exception stackTrace when catch sql exception on system/admin user/account insert
2014-07-07 16:45:23 -07:00
Frank.Zhang
65497b69c7
CLOUDSTACK-6278
...
Baremetal Advanced Networking support
2014-07-07 14:52:45 -07:00
Frank.Zhang
3ddc9e7674
CLOUDSTACK-6278
...
Baremetal Advanced Networking support
2014-07-07 11:40:21 -07:00
Santhosh Edukulla
a600d8408e
Fixed Resource Leaks, null dereferences, few other issues reported by coverity
2014-07-04 16:17:58 +05:30
Daan Hoogland
b2d613f536
CLOUDSTACK-6242: catching all to allow continuation on configuration
...
error (CLOUDSTACK-7039 through CLOUDSTACK-7042)
2014-07-03 08:41:47 +02:00
Prachi Damle
48574f2d60
CLOUDSTACK-7047: DeploymentPlanner should include disabled resources only when the VM owner is Admin account
...
Changes:
- removing unused imports
2014-07-02 17:49:53 -07:00
Prachi Damle
9f68870a77
CLOUDSTACK-7047: DeploymentPlanner should include disabled resources only when the VM owner is Admin account
...
Changes:
-DeploymentPlanner should include disabled resources only when the VM owner is Admin account.
The disabled resources should be ignored when VM is owned by any other user.
2014-07-02 17:49:51 -07:00
Alena Prokharchyk
324b5d5a57
CLOUDSTACK-7045: save started/completed events for createPrivateGateway and createStaticRoute apis
2014-07-02 17:23:35 -07:00
Nitin Mehta
1f7a818440
CLOUDSTACK-7000: Fix bugs in ListSnapshotPolicy and updateSnapshotPolicy command
...
(cherry picked from commit 63c4f02897 )
2014-07-02 13:13:51 -07:00
Kishan Kavala
421d6029db
Remove cloud-server dependency for cloud-usage project
2014-07-02 15:28:42 +05:30
Santhosh Edukulla
97d296bfbd
Fixed Coverity reported performance issues like inefficient string concatenations, wrong boxing or unboxing types, inefficent map element retrievals
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-07-01 22:06:25 +02:00
Jayapal
f45c9f9d2f
CLOUDSTACK-7027: Removing left over static nat rule
2014-07-01 15:16:35 +05:30
Nitin Mehta
0c9c5a71b4
CLOUDSTACK-4364: Restore VM - log a usage event for newly created volume
2014-06-30 14:41:37 -07:00
Mike Tutkowski
afd48819a6
Fixing an issue introduced with Review Request 22717
2014-06-27 14:03:08 -06:00
Hugo Trippaers
190116c94c
Fix CID 1223793 Use equals to test equality of values contained in
...
objects.
2014-06-27 15:15:29 +02:00
Sanjay Tripathi
28505c2729
CLOUDSTACK-6884: List Capacity API always returns GPU capacity also even if type is different.
2014-06-27 15:58:42 +05:30
Nitin Mehta
80ef915fd5
CLOUDSTACK-7000: ListSnapshotPolicy should list by policyid. Introduce updateSnapshotPolicy command
...
(cherry picked from commit fce21439fa )
2014-06-26 11:38:41 -07:00
Hugo Trippaers
cd0ef09344
Fix typo and add the right exception to the error map.
2014-06-25 15:51:28 +02:00
Hugo Trippaers
49b0936a72
Fix several potential issues reported by coverity.
2014-06-25 15:51:28 +02:00
Daan Hoogland
17850c7aff
CLOUDSTACK-6747: call a more forgiving test on the supplied peer
...
cidr-list
2014-06-25 15:45:28 +02:00
Mike Tutkowski
3d9eaf0753
Fixed some spacing issues from 4d6c682f18
2014-06-24 15:27:06 -06:00
punith-cloudbyte
4d6c682f18
supporting nfs protocol and resize feature for managed storage for xenserver
...
resize feature refactored
Signed-off-by: Mike Tutkowski <mike.tutkowski@solidfire.com>
2014-06-24 15:16:45 -06:00
Nitin Mehta
cb5e8c591f
CLOUDSTACK-6987: Add support for storing metadata for snapshot policy and controlling policy using display flag
...
(cherry picked from commit 5cf8edd7ec )
2014-06-24 14:07:39 -07:00
Mike Tutkowski
c344693e48
Inform the applicable storage plug-in's life cycle that capacity (bytes and/or IOPS) can be updated
2014-06-24 14:39:57 -06:00
Daan Hoogland
c79ab570b0
Revert "CLOUDSTACK-6967: Initial OVM3 drop"
...
This reverts commit 8a485b9b59 .
2014-06-24 10:24:01 +02:00
Funs
8a485b9b59
CLOUDSTACK-6967: Initial OVM3 drop
...
Signed-off-by: Sebastien Goasguen <runseb@gmail.com>
(cherry picked from commit ed47763e25 )
Conflicts:
api/src/com/cloud/network/NetworkService.java
api/src/org/apache/cloudstack/api/ApiConstants.java
api/src/org/apache/cloudstack/api/command/admin/usage/AddTrafficTypeCmd.java
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/SnapshotObject.java
plugins/pom.xml
server/src/com/cloud/network/NetworkServiceImpl.java
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
server/test/com/cloud/vpc/MockNetworkManagerImpl.java
ui/scripts/docs.js
2014-06-23 12:39:10 +02:00
Anshul Gangwar
6416de5770
CLOUDSTACK-6968: allowing cluster scope volumes to attach to any VM. If migration is
...
needed then first they will be migrated to appropriate cluster before attaching.
2014-06-23 12:15:10 +05:30
Santhosh Edukulla
1c80185170
Fixed Resource Leaks, null dereferences, invalid value comparisons, invalid result set loop
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-06-21 12:38:46 +02:00
Min Chen
a97455b602
CLOUDSTACK-6971: createAutoScaleVmProfile failed with NPE due to lack of bean
...
injection.
2014-06-20 14:28:26 -07:00
Kelven Yang
60f4203cbc
Protect event interpretion from causing NPE exception
2014-06-20 10:16:04 -07:00
Anshul Gangwar
450d890942
CLOUDSTACK-6830: Fixed during VM migration, volumes on zone wide primary store
...
requires storage migration resulting in failure of VM migration. This also improves
the hostsformigration api. Firstly we were trying to list all hosts and then
finding suitable storage pools for all volumes and then we were checking whether
vm migration requires storage migration to that host. Now the process is updated.
We are checking for only those volumes which are not in zone wide primary store.
We are verifying by comparing volumes->poolid->clusterid to host clusterid. If it
uses local or clusterids are different then verifying whether host has suitable
storage pools for the volume of the vm to be migrated too.
2014-06-20 16:32:19 +05:30
Murali Reddy
7e355de365
CLOUDSTACK-6750: [OVS] With stretched network deploying vm in a ovs
...
disabled zone does not fail
Fix ensures that connectivity service provider is enabled in the zone on
to which nework is being streched.
2014-06-19 16:06:56 +05:30
Jayapal
cc98d44542
CLOUDSTACK-6922: Updated events for firewall ingress and egress
2014-06-19 15:06:56 +05:30
Jayapal
2be26e03af
CLOUDSTACK-6923: updated listLBStickinessPolicies API to list using stickinesspolicy id
2014-06-19 15:05:22 +05:30
Kishan Kavala
89854de18d
CLOUDSTACK-6931: Set hypervisor.type in agent.properties using cloudstack-setup -t option. Default is kvm.
2014-06-19 11:31:23 +05:30
Prachi Damle
05c01a7dc9
CLOUDSTACK-6941: Can't choose storage for the volume, when attaching uploaded data volume to VM
...
Changes:
- Only way to choose a certain storage pool is by using disk_offering_tags
- Added a parameter to take in a disk offering Id.
- Admin will have to create a custom sized disk offering and tag it as necessary for the user
- This custom offering Id should be passed during uploadVolume to associate the volume with this disk offering
2014-06-18 16:37:43 -07:00
Min Chen
569e94908b
CLOUDSTACK-6940:Templates cannot be downloaded from URLs without
...
matching file extensions.
2014-06-18 16:13:49 -07:00
Kelven Yang
f529823566
Add ReflectionUse annotation for marking up *un-used* methods
2014-06-17 17:31:29 -07:00
ynojima
5be7fa23b4
refactor unused code in storagePoolHasEnoughIops method
2014-06-17 14:48:57 -06:00
Alena Prokharchyk
09a97e1968
CLOUDSTACK-6919: don't attempt to restart user vms having no Root volume attached
2014-06-16 14:59:52 -07:00
Santhosh Edukulla
f89100ed72
CLOUDSTACK-6793 : Added fix
...
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2014-06-16 17:11:14 +05:30
Hugo Trippaers
0c28f36ff1
Fix a number of resource leaks reported by Coverity
2014-06-13 14:42:35 +02:00
Alena Prokharchyk
887f027a9a
CLOUDSTACK-6907: lisVolumes - make a decision whether to set service or disk offering in the response, based on the DiskOfferingVO type entry, not the volume Type
2014-06-12 16:25:04 -07:00
Saksham Srivastava
505a7127b8
CLOUDSTACK-6812: Do not allow edit of storage.overprovision.factor for non supported types
2014-06-12 17:26:06 +05:30
Jayapal
923c0cd89f
CLOUDSTACK-6899: Added vmId in listnics response
2014-06-12 17:18:08 +05:30
Santhosh Edukulla
93c75c73a4
CLOUDSTACK-6791 Fixed the issue
2014-06-12 16:48:44 +05:30
Rajani Karuturi
2482da8cbf
Fixed few coverity issues unused assignments, boxing and unboxing of values etc.
...
Signed-off-by: Koushik Das <koushik@apache.org>
2014-06-12 13:44:58 +05:30
Saksham Srivastava
41030e4e3e
CLOUDSTACK-6654: Configkey parameters are not validated
2014-06-12 11:20:44 +05:30
Saksham Srivastava
f2464e4182
CLOUDSTACK-6864: UploadSSlCert API requires double encoding of URL params
2014-06-12 10:35:47 +05:30
Nitin Mehta
c2a0fb4e52
CLOUDSTACK-6895: 1. Populate firstclass entities as uuids in the context instead of dbids for performance.
...
2. Add ctxDetails in the ParamGenericValidationWorker to avoid warning for api validation
3. Add some missing events.
4. Correcting mapping for ResourceObjectType.NetworkACL and ResourceObjectType.NetworkACLItem
(cherry picked from commit 8a9092c3cd )
2014-06-11 15:24:56 -07:00
Harikrishna Patnala
522208dec2
CLOUDSTACK-6869: SSH Public key content is overridden by template's meta data when you create a instance
2014-06-11 17:00:32 +05:30
Olivier Lemasle
a5902f1db4
CLOUDSTACK-6850: Return cpu cores, cpu speed and memory in listUsageRecords
...
Signed-off-by: Sebastien Goasguen <runseb@gmail.com>
2014-06-10 03:11:35 -04:00
Tim Mackey
a8212d9ef4
Cleanup of Xen and XenServer terms. Cloned xen plugin creating a xenserver plugin, then removed xen plugin
...
Signed-off-by: Tim Mackey <tmackey@gmail.com>
Signed-off-by: Sebastien Goasguen <runseb@gmail.com>
2014-06-07 04:50:23 -04:00
Alena Prokharchyk
ac1b4b0316
Fixed unittest
2014-06-05 18:37:56 -07:00
Koushik Das
d34419579e
CLOUDSTACK-6843: [Automation] List listServiceOfferings api fails with NPE
...
Incorrect parameter name used in query building resulted in a bad sql query.
2014-06-05 13:57:38 +05:30
Hugo Trippaers
a59db987f9
Fix CID-1219920 Dereference before null check
2014-06-03 16:39:32 +02:00
Rohit Yadav
eb8e630f24
AlertGenerator: Fix NPE from CLOUDSTACK-3272
...
There was a commit 4b89a45e57 on master which was
added by "root@devcloud.apache.org" with no committer signature so I cannot tell
whom to reach. In the code it looks like they forgot to initialize the static
config dao variable which is causing NPE on master. The fix simply initializes
the s_configDao with injected configDao object.
Signed-off-by: Rohit Yadav <bhaisaab@apache.org>
2014-06-02 22:43:27 +05:30
Nitin Mehta
5393387bbd
CLOUDSTACK-6599:
...
1. Adding the missing Template/Volume URLs expiration functionality
2. Improvement - While deleting the volume during expiration use rm -rf as vmware now contains directoy
3. Improvement - Use standard Answer so that the error gets logged in case deletion of expiration link didnt work fine.
4. Improvement - In case of domain change, expire the old urls
2014-05-30 10:48:42 -07:00
Hiroki Ohashi
3256e88623
Allow usaage reporting on removed service offering
2014-05-29 19:12:11 +02:00
Upendra Moturi
e9af5f44ae
CLOUDSTACK-6223. removeNicFromVirtualMachine fails if another instance in another domain has a nic with the same ip and a forwarding rule configured on it
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-05-29 10:18:41 +02:00
Marcus Sorensen
7ce3034299
CLOUDSTACK-6790: Disable PXE ROM for system vm nics
2014-05-27 16:52:26 -06:00
Nitin Mehta
a8140ff58c
CLOUDSTACK-6787: Event Bus - uuids missing in some cases due to various reasons
2014-05-27 15:07:38 -07:00
Marcus Sorensen
20a31b43d6
CLOUDSTACK-6784: Expose data types via API so consumers of API can validate data
2014-05-27 15:23:23 -06:00
Marcus Sorensen
96055058b0
CLOUDSTACK-6785: changed async job param injectedjobid to customjobid and check for unique/uuid
2014-05-27 15:23:12 -06:00
Marcus Sorensen
2a5bf65c78
CLOUDSTACK-6785: Allow async jobs to supply an injectedjobid
2014-05-27 15:23:02 -06:00
Rajani Karuturi
ce6a53e37b
Fixed CLOUDSTACK-6756: usage id is not being returned for an ip in deleted ip range
...
(cherry picked from commit a6ed48fc9c5f68b46f0d2e05adefc7263c4cd0d0)
Conflicts:
setup/db/db/schema-430to440.sql
2014-05-27 10:41:40 +05:30
Daan Hoogland
16bf065a0d
CLOUDSTACK-6485 prevent ipaddress asignment of gateway to gateway-interface on vpc router
2014-05-24 19:44:00 +02:00
Min Chen
8a1eed24b9
Fix AccountManager unit testcase.
2014-05-22 22:33:25 -07:00
Min Chen
faa379b6c2
CLOUDSTACK-6752: IAM command class separation caused ApiDoc warning of
...
duplicated cmd class for the same api name.
2014-05-22 18:28:25 -07:00
Min Chen
b259bccee7
CLOUDSTACK-6742: listVolumes - As regularuser , able to list Vms and
...
volumes of other users.
2014-05-22 18:28:00 -07:00
Min Chen
ba848087f8
Disable IAM feature from 4.4 release.
2014-05-22 18:27:08 -07:00
Anthony Xu
c0936fecbc
fixed a typo
2014-05-22 15:47:28 -07:00
Anthony Xu
df6ce24f43
if networkID is not specified, get one network with free ips.
2014-05-21 14:33:52 -07:00
Murali Reddy
17fe6cdda4
CLOUDSTACK-6721: VolumeApiServiceImpl is sending wrong type for
...
updateAsyncJobAttachment
fix sends 'Volume' instead of 'volume'
Conflicts:
server/src/com/cloud/storage/VolumeApiServiceImpl.java
2014-05-20 17:13:20 +05:30
Murali Reddy
965346cad1
CLOUDSTACK-6712: NPE in findJobInstanceUuid() in ApiDBUtils
2014-05-20 10:26:12 +05:30
Nitin Mehta
667c8e7905
CLOUDSTACK-6699: listResouceDetails - enhance it to list by (key,value) pair - allowed to Admin only.
2014-05-18 23:21:37 -07:00
Sanjay Tripathi
f789a03769
CLOUDSTACK-6678: API:MS: listCapacity returns; errorcode":530,"cserrorcode":9999,"errortext":"Index: 0, Size: 0"}.
2014-05-15 14:22:40 +05:30
Nitin Mehta
afb31fa09f
CLOUDSTACK-6660: Dont assume every vm will have a root volume now.
...
(cherry picked from commit 076bbdcfe8 )
2014-05-14 15:00:34 -07:00
Sanjay Tripathi
35cd61c463
CLOUDSTACK-6649: CS is not giving the system-wide capacity for GPU reosurce.
2014-05-14 15:05:28 +05:30
Amogh Vasekar
9b6d430171
This patch disallows deleting / modifying system defined guest OS mappings
...
Local env
1. Create user defined mapping
2. Delete / modify user defined mapping. Should pass
3. Delete / modify system defined mapping. Should fail
Signed off by :- Nitin Mehta<nitin.mehta@citrix.com>
2014-05-12 22:45:24 -07:00
Sheng Yang
0a62eb8380
CLOUDSTACK-5501: Allow one vpn customer gateway with multiple connections
...
This restriction was purposely avoid confusion of VPN setup, but later found too
strictly and cause troubles for deployment. Removed after testing one customer
gateway with multiple connections.
2014-05-12 18:50:48 -07:00
Nitin Mehta
7ae784ba3c
CLOUDSTACK-6633: listVolumes should return template/iso info for root volumes
2014-05-11 20:36:53 -07:00
Min Chen
daadc45122
CLOUDSTACK-6628:[Automation] Create PF rulw API failing with error
...
"database id can only provided by VO objects".
2014-05-09 18:48:08 -07:00
santhosh
00fcd9fb20
Added fix for CLOUDSTACK-6548
...
Signed-off-by: santhosh <santhosh.edukulla@gmail.com>
Signed-off-by: Daan Hoogland <daan@onecht.net>
Conflicts:
server/src/com/cloud/network/NetworkServiceImpl.java
2014-05-09 17:14:06 +02:00
Min Chen
0f79223f28
CLOUDSTACK-6613:IAM: authorizeSecurityGroupIngress fails when SG Name is
...
passed.
2014-05-08 23:19:28 -07:00
Min Chen
51cb0f9a4a
CLOUDSTACK-6598:IAM - listAccount() retrurns "Caller cannot be passed as
...
NULL to IAM!" when domain deletion is in progress.
2014-05-08 17:56:20 -07:00
Murali Reddy
2a175a2b02
CLOUDSTACK-6608:OVS distributed firewall: default ACL rule is not
...
getting applied when a tier in VPC is created.
fix ensures, VpcRoutingPolicyUpdate is send when network rules are
programmed when network tier in VPC is created
2014-05-08 15:58:02 +05:30
Daan Hoogland
3515c39cac
Revert "CLOUDSTACK-6485: private gateway network should not be associated with vpc"
...
This reverts commit 3bd594c584 .
Conflicts:
server/src/com/cloud/network/NetworkServiceImpl.java
2014-05-08 11:45:35 +02:00
Devdeep Singh
245b7f4c39
CLOUDSTACK-6510: Fix gson serialization exception in storage migration. Gson couldn't serialize
...
a map with volume and storagepool objects for logging. Fixed by using volume and storage pool
ids instead of objects in the map.
2014-05-08 12:23:46 +05:30
Alena Prokharchyk
b7b89b1297
CLOUDSTACK-6601: added "forDisplay" parameter to listLoadBalancerRules API
2014-05-07 17:06:55 -07:00
Alena Prokharchyk
66d5ebc657
CLOUDSTACK-6596: UUID and display flag update support for LBStickinessPolicy and LBHealthCheckPolicy
2014-05-07 15:46:18 -07:00
Alena Prokharchyk
25ab05a189
CLOUDSTACK-6595: call expunge method marked with @ActionEvent from expunge thread context. So the action even EXPUNGE.VM is generated when vm is expunged by the thread.
2014-05-07 15:46:10 -07:00
Nitin Mehta
5388d349a4
CLOUDSTACK-6597: Updatevm - root admin should be allowed to change instance name
2014-05-07 14:34:01 -07:00
Murali Reddy
e18ff2821d
CLOUDSTACK-6593: Connectivity service capabilites should be matched with
...
the provider only if at least one capability is specified
Fix avoids the check, and only if the createNetworkOffering
'StrechedL2'Subnet' capability is specified then it should match against
'Connectivity' service provider
2014-05-07 20:05:47 +05:30
Jayapal
d4f167032b
Fixed vpc private gateway backend issues
2014-05-07 16:33:46 +05:30
root
4b89a45e57
CLOUDSTACK-3272 Latest changes to add global configuration parameters to control the publishing of events on the message bus
2014-05-07 10:09:03 +05:30
Alena Prokharchyk
ee5f5591c7
CLOUDSTACK-6585: added missing metadata support for LBStickiness/LBHealthcheck policies
2014-05-06 17:13:50 -07:00
Kelven Yang
521ac796dd
Move EventBus hookup on job framework to ApiServer to decouple job framework away from business logic related hookups. The decoupling is done through internal messaging facility provided inside management server.
2014-05-06 15:48:22 -07:00
Rajani Karuturi
59bf355919
CLOUDSTACK-6531: stopping the router in case of command failures. Also added alerts for failures.
...
Signed-off-by: Jayapal <jayapal@apache.org>
2014-05-06 20:08:30 +05:30
Jayapal
40836344de
CLOUDSTACK-6578: Fixed issue in delete remote access vpn command
2014-05-06 20:08:30 +05:30
Jayapal
b9b623bccc
CLOUDSTACK-6577: Disable service monitoring in RVR
2014-05-06 20:08:30 +05:30
Jayapal
11591582d5
CLOUDSTACK-6364 Added ip address validation
...
Also updated to assign vm primary ip to lb rule when vmid is passed virtualmachineid
and vm id ip details in vmidipmap
2014-05-06 20:08:30 +05:30
Girish Chaudhari
0babb92d62
CLOUDSTACK-2697 Removed the clusterId as null from the alert message logs
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-05-05 19:10:17 +02:00
Tanner Danzey
601827e6b3
CLOUDSTACK-5907, CLOUDSTACK-6396: KVM/RBD & KVM/CLVM volumes mistakenly shown as OVM, disables snapshotting
...
modified: server/src/com/cloud/api/ApiDBUtils.java
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-05-05 15:15:25 +02:00
Min Chen
4e674ffad1
CLOUDSTACK-6568:API:createVolume: Volume gets created with wrong domain
...
ID.
2014-05-02 17:47:06 -07:00
Mike Tutkowski
8ac7784db2
CLOUDSTACK-6170 Corrected an issue related to the "Reinstall VM" command and managed storage with VMware
2014-05-02 18:41:59 -06:00
Min Chen
7f595778ad
Fix compilation error due to cherry-pick CLOUDSTACK-6569.
2014-05-02 16:01:13 -07:00
Min Chen
3314e11b70
CLOUDSTACK-6569: IAM - Regular user is able to listNetworks of another
...
user in the same domain , by passing account and domainId.
2014-05-02 14:58:11 -07:00
Alena Prokharchyk
15c4851fc9
LOUDSTACK-6475: cleanupVPC task - removed the transaction wrapping up multiple VPC destroy as the destroy operation has external calls, to prevent long-locked transaction.
...
Reviewed-by: Prachi Damle
2014-05-02 14:20:38 -07:00
Sam Schmit
81b4731e3b
CLOUDSTACK-6472 listUsageRecords: Pull information from removed items as well, fixing NPEs/Null UUIDs with usage API calls.
...
Signed-off-by: Sebastien Goasguen <runseb@gmail.com>
2014-05-02 16:27:21 -04:00
Laszlo Hornyak
178240a7da
test for HighAvailabilityManagerImpl
...
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-05-02 21:22:43 +02:00
Laszlo Hornyak
726d8fc3fc
test for escapeHTML
...
- test added
- StringBuffer replaced with StringBuilder
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-05-02 21:19:49 +02:00
Laszlo Hornyak
78507c07c8
log exceptions in ConsoleProxyServlet
...
- Added exception to the logger method parameters to make stack trace available
- removed checking of debug level, it does not save temporary object creation here
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-05-02 21:19:48 +02:00
Min Chen
134a7998ce
CLOUDSTACK-6556: Deploy VM failing with error "does
...
not have permission to access resource Ntwk".
2014-05-01 15:57:29 -07:00
Min Chen
d7c5382c58
CLOUDSTACK-6535: IAM:MS:API createVMSnapshot doesn't preserve access
...
rights.
2014-05-01 15:57:28 -07:00
Min Chen
95e9db2f91
CLOUDSTACK-6556: [Automation] Deploy VM failing with error "does not
...
have permission to access resource Ntwk".
2014-05-01 15:57:28 -07:00
Min Chen
2521fd482b
CLOUDSTACK-6513: remove commented code.
2014-05-01 15:57:28 -07:00
Min Chen
db9aee4517
CLOUDSTACK-6513: templateFilter=shared should not show self-owned
...
template.
2014-05-01 15:57:28 -07:00
Min Chen
a9072a6612
CLOUDSTACK-6513: Optimize code by removing deprecated utility to
...
QueryManagerImpl as private method just used for listTemplates and
listAffinityGroups to avoid misuse by new list APIs.
2014-05-01 15:57:28 -07:00
Min Chen
5521581b6e
CLOUDSTACK-6532:Affinity Groups - As admin user, not able to list all
...
affinity groups available for regular users by passing account and
domainId paramater. This is to revert IAM way of implementing
listAffinityGroupsCmd, will bring it back when we have implemented real
impersonation.
2014-05-01 15:57:27 -07:00
Laszlo Hornyak
94ab870d42
null pointer dereference fix
...
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-04-29 21:46:16 +02:00