Commit Graph

5370 Commits

Author SHA1 Message Date
Koushik Das bb17d09e01 Support for local data disk (part 2)
- Zone level config to enable/disable local storage usage for service and disk offerings.
- Local storage gets discovered when a host is added/reconnected if zone level config is enabled. When disabled existing local storages are not removed but any new local storage is not added.
- Deploy VM command validates service and disk offerings based on local storage config.
- Upgrade uses the global config 'use.local.storage' to set the zone level config for local storage.

Reviewed-by: Abhi, Nitin
2012-07-30 13:59:14 +05:30
Likitha Shetty ddcb3d7b30 CS-14770. ec2-run-instances and ec2-describe-instances don't return keypair information.
Changing CS deployVirtualMachine and listVirtualMachine api response to include ssh keypair information.
Component: AWSAPI.
2012-07-30 11:50:04 +05:30
Sheng Yang 65ef8b24c1 CS-15730: Prohibit create VPN connection from different gateway to same customer gateway 2012-07-27 17:41:22 -07:00
Vijayendra Bhamidipati 774e73dae3 Merge branch '3.0.x' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 3.0.x 2012-07-27 15:38:56 -07:00
Alena Prokharchyk 984f9290ae CS-15717: fail to delete the network when corresponding network elements fail to be destroyed 2012-07-27 15:33:28 -07:00
Sheng Yang e8dbac17f6 CS-15719: Fix state change when stopping 2012-07-27 15:31:52 -07:00
Sheng Yang 260422de07 CS-15704: Fix wrong domain id setting of non-root domain 2012-07-27 15:31:52 -07:00
Vijayendra Bhamidipati b6e70f2281 CS-15217: Security: Malicious user is able to get the size of the cloud by enumerating IDs
Description:

	New 3.0.x merge included a new instance of InvalidParameterValue exception
	being raised. Fixing it.
2012-07-27 15:15:32 -07:00
Vijayendra Bhamidipati b8211728e1 Merge branch '3.0.x' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 3.0.x 2012-07-27 15:11:14 -07:00
Vijayendra Bhamidipati 62c11df4e9 CS-15217: Security: Malicious user is able to get the size of the cloud by enumerating IDs
Description:

	1) With this commit in the series for this bug,
	removed all occurrances of db IDs being passed
	when raising InvalidParameterValueException.

	2) Renamed HyervisorTemplateAdapter.java to
	HypervisorTemplateAdapter.java.
2012-07-27 15:08:48 -07:00
Alena Prokharchyk c0b58130d3 VPC: CS-15725 - don't allow regular offering upgrade to the offering that can be used inside vpc only 2012-07-27 13:32:00 -07:00
Alena Prokharchyk 78a00c03e1 VPC: replaced vmTo object with vmName parameter in plug/unplugNic commands 2012-07-27 13:32:00 -07:00
Vijay 57b1783764 CS-15729. AutoScale. Default counter names are corrected to valid values without special characters 2012-07-27 21:00:03 +05:30
Sheng Yang c971d3c2a6 CS-15697: Fix wrong class for finalizeStop() 2012-07-26 16:04:10 -07:00
Vijayendra Bhamidipati 1e9c5c54df Merge branch '3.0.x' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 3.0.x 2012-07-26 18:27:55 -04:00
Alena Prokharchyk ecd8450ab6 Added missing action events for enable/disable static nat 2012-07-26 15:26:53 -07:00
Vijayendra Bhamidipati 06e974ef92 Merge branch '3.0.x' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 3.0.x 2012-07-26 18:06:06 -04:00
Vijayendra Bhamidipati 2e18ffec20 CS-15217: Security: Malicious user is able to get the size of the cloud by enumerating IDs
Description:

	Removing more DB IDs from exception messages.
2012-07-26 18:05:43 -04:00
Alena Prokharchyk 5eb87e99ff VPC: added global configuration for limiting number of networks per vpc (vpc.max.networks) 2012-07-26 14:05:56 -07:00
prachi 5f433ff7bc Merge branch '3.0.x' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 3.0.x 2012-07-26 11:37:36 -07:00
prachi 6fe394231b CS-15299: Typo in use.external.dns setting description
Changes:
- fixed the typo in the setting description
2012-07-26 11:37:04 -07:00
Alena Prokharchyk 20b6b36302 VPC:
1) CS-15692 - ipAddress is always null for NetworkACL rule
2) CS-15699 - redundant router = true when provider is VirtualRouter
3) CS-15701 - fixed error message
2012-07-26 10:15:35 -07:00
Sheng Yang cc35ea2be3 S2S VPN: CS-15650: Add connection status update to s2s vpn 2012-07-25 22:00:40 -07:00
Sheng Yang 517c9af7c9 S2S VPN: Add list function for normal users 2012-07-25 18:59:49 -07:00
Vijayendra Bhamidipati 3b13c47e38 Merge branch '3.0.x' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 3.0.x 2012-07-25 18:43:21 -04:00
Vijayendra Bhamidipati a0fa53ecd8 CS-15217: Security: Malicious user is able to get the size of the cloud by enumerating IDs
Description:

	Removing more DB IDs from exception messages.
2012-07-25 18:39:48 -04:00
Alena Prokharchyk 8cfc3c4775 Bug 14875: fixed listNetworks by domainId/aclType=Domain 2012-07-25 14:48:08 -07:00
Alena Prokharchyk f6041de179 VPC: added vif info to ipassoc command 2012-07-25 13:03:40 -07:00
Vijay d4e43846f8 AutoScale. Adding default counters 2012-07-25 18:17:32 +05:30
Koushik Das 266b8e5ee8 Support for local data disk (part 1)
Following changes are made:
- Create disk offering API now takes an extra parameter to denote storage type (local or shared). This is similar to storage type in service offering.
- Create/delete of data volume on local storage
- Attach/detach for local data volumes. Re-attach is allowed as long as vm host and data volume storage pool host is same.
- Migration of VM instance is not supported if it uses local root or data volumes.
- Migrate is not supported for local volumes.

Reviewed-by: Abhi
2012-07-25 15:16:42 +05:30
Sheng Yang c4dff1e204 CS-15670: Allow normal users to configure S2S VPN 2012-07-24 19:44:27 -07:00
Alena Prokharchyk 2c24b7446e VPC: CS-15681 - execute VPC related methods only when router is a vpc router 2012-07-24 16:06:47 -07:00
Sheng Yang d88f8abed4 S2S VPN: Fix build 2012-07-24 13:24:22 -07:00
Sheng Yang eeaee286a1 S2S VPN: Fix incorrect conn returned by resetVpnConnection cmd 2012-07-24 13:02:29 -07:00
Sheng Yang f1dbdedfa9 S2S VPN: Add name field for customer gateway
Easier for user to identify the correct gateway
2012-07-24 13:02:24 -07:00
Alena Prokharchyk f68a1a7d44 listPublicIpAddresses: when do join with nics table, count only non-removed nics 2012-07-24 12:39:26 -07:00
Sheng Yang 9da29e7f77 CS-15676: Fix NPE when stop non-VPC router 2012-07-24 11:42:36 -07:00
Vijay 04b51bb6ba AutoScale.
NetScaler changes for deleteAutoScaleVmGroup and min/max member
    policies - Tested
    Introducing apikey/sharedsecret/csurl empty checks as well
    Introducing the autoscale change sheet that got deleted during the merge
2012-07-24 19:25:22 +05:30
Vijay 62082b0de6 Resetting unwanted files similar to 3.0.x 2012-07-24 10:45:25 +05:30
Vijay 629053d2f1 AutoScale. Catching an odd case to get rid of null pointer exception 2012-07-24 10:02:45 +05:30
Deepak Garg edcd8e7394 Checking success in deleteCounter 2012-07-24 10:02:39 +05:30
Vijay 30cb0e74d2 AutoScale. ALenas Final Review Comments. 2nd Cut. Remove csurl from profile, 2012-07-24 10:02:29 +05:30
Vijay f9bcf3186c AutoScale. Enabling AutoScale to go to the Resource.
Tested the reachability for Basic Network.
Fixing compile error introduced due to a89919ce2ffd9a0a99f1810aeaa0488b0805f665
2012-07-24 10:01:22 +05:30
Deepak Garg a96df19b68 Improved logging in AutoScale APIs 2012-07-24 10:01:19 +05:30
Deepak Garg 349ab92ffc Added more logging to AutoScale Vm Group 2012-07-24 10:01:13 +05:30
Deepak Garg 05e46cfd31 Added more params to UpdateAutoScaleVmProfileCmd 2012-07-24 10:00:42 +05:30
Vijay 09adc78196 AutoScale. Removed checks for no parameters in update command. 2012-07-24 10:00:40 +05:30
Vijay deb70ad200 AutoScale. Enabled Update commands with UnitTesting. Introduced and tested capability for NetScaler 2012-07-24 10:00:37 +05:30
Deepak Garg a4a15aa737 Work around for CS-15556 2012-07-24 10:00:26 +05:30
Vijay df84f88296 CS-15593: Conditions are checked in database before used 2012-07-24 10:00:03 +05:30
Vijay c755172a3a CS-15590 : Conditions are corrected to be similar to other search wrapper usecases 2012-07-24 10:00:00 +05:30
Vijay c826fa295b AutoScale. AutoScaleVmGroup Response corrected. Responses tested for list commands of autoscale entities 2012-07-24 09:59:57 +05:30
Deepak Garg 3bee3fd4fd Added CSurl in the vm profile response 2012-07-24 09:59:44 +05:30
Vijay 19a2f4ab66 AutoScale. Introducing caller in getEntityInDatabase 2012-07-24 09:59:12 +05:30
Deepak Garg 8bbc8ee0ec Added csurl as param in CreateAutoScaleVmProfileCmd 2012-07-24 09:58:56 +05:30
Vijay fa9282add1 AutoScale. Alena's final review comments. 1st Cut. 2012-07-24 09:58:17 +05:30
Deepak Garg 1c960c0b34 Fixed event type in deleteCondition 2012-07-24 09:57:30 +05:30
Deepak Garg 10a58fdef2 CS-15592 Fixed the quiettime parameter check 2012-07-24 09:57:28 +05:30
Deepak Garg 4ee6ed6afb CS-15589 Fixed the invalid counter exception 2012-07-24 09:57:26 +05:30
Vijay 998f9aa051 AutoScale. Unit Test Add/Delete/List of all AutoScale entities. 2012-07-24 09:57:24 +05:30
Vijay a6a206d3fc AutoScale. Bringing in update commands and enable/disable. Not Tested. 2012-07-24 09:57:21 +05:30
Vijay 21e13657b4 AutoScale.
All API commands with separate service layer for AutoScale.
  Not tested.
2012-07-24 09:57:10 +05:30
Sheng Yang 4dddd76e95 CS-15534: Mark VPN connection as Disconnected when rebootRouter 2012-07-23 21:07:49 -07:00
Sheng Yang 6e571d28df S2S VPN: Add check for router status before apply vpn 2012-07-23 19:53:06 -07:00
Alena Prokharchyk 22826032b4 VPC: CS-15668 - IpAssoc: unplug the nics before pluggning new ones 2012-07-23 16:18:49 -07:00
Alena Prokharchyk a867e7e5a8 CS-15077: fixed listPublicIpAddresses in basic zone 2012-07-23 11:16:28 -07:00
Alena Prokharchyk 9899df816c Resource tags: CS-15661 - don't accept NULL or empty key value when create resource tag 2012-07-23 10:50:21 -07:00
Alena Prokharchyk cec0ea54ec Resource tags: CS-15647 - delete resource tags when SG is expunged 2012-07-23 10:32:56 -07:00
Alena Prokharchyk 49199d0022 VPC: when VPC router gets destroyed and recreated, plug public nic for each Vlan where VPC public ips belong to 2012-07-20 16:28:43 -07:00
prachi 2a97fdae64 Merge branch '3.0.x' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 3.0.x 2012-07-20 15:39:43 -07:00
prachi c581d8b820 CS-15586: Public Vlan for an account fails in case of multiple Physical networks
Changes:
- Since Now a zone can have multiple physical networks, we need to find the physical network Id from the networkOffering's tag and zoneId and trafficType when we create a guest network
2012-07-20 15:39:26 -07:00
Alena Prokharchyk 04ed3884d0 CS-15622: always get router info from the DB 2012-07-20 14:35:39 -07:00
Alena Prokharchyk aa6ee7c506 VPC: one more fix for multiple public nic case for the VPC VR 2012-07-20 14:08:00 -07:00
Alena Prokharchyk c0fb2fece9 VPC: CS-15638: Plug nic for the public ip address if the ip address from the diff vlan range than sourceNat ip 2012-07-20 13:25:09 -07:00
Prasanna Santhanam 135a999db8 CS-15560 : Improve HVM logging of hosts
When a host is not considered for deployment because it is disabled HVM,
then call that out in the logs for debugging.
2012-07-20 17:28:36 +05:30
Alena Prokharchyk f243765758 304-305 DB upgrade: upgrade for VPC and resourceTags feature 2012-07-19 16:54:00 -07:00
Alena Prokharchyk ba0c448174 Added upgrade path from 3.0.4 to 3.0.5 (Burbank) release 2012-07-19 16:54:00 -07:00
Alena Prokharchyk 6224423ecc More logging to the VirtualRouter manager 2012-07-19 14:02:04 -07:00
prachi 317e0df566 CS-15606 Dogfood Setup: Virtual Router (DHCP Server) fails to create in Pods
Reviewed-By: Alena

Changes:
- Correct the virtual router entries from table' virtual_router_providers' that wrongly refer to SecurityGroupProvider instead of VirtualRouter provider in physical_network_service_providers table
- For such entries, we update them to point to the VirtualRouter provider in physical_network_service_providers table
2012-07-18 16:54:47 -07:00
prachi 302485e8ef CS-15578 (spinned off from 15495) Upgrade from 2.2.14 -> 3.0.3-> 3.04 failed with exception"mysql.jdbc.exceptions.jdbc4.MySQLIntegrityConstraintViolationException
reviewed-by: kishan

- Add physical network to the removed data_center as well and mark it as removed, to avoid foreign constraint failures
- Since rest all stuff related to multiple physcial networks is done based on networks having non-null removed field, nothing will apply to this zone.
2012-07-18 16:54:22 -07:00
prachi f06d73a6f3 CS-15407 [2.2.14 to 3.0.4 upgrade] After upgrade VLAN allocation doesn't happen properly for multiple physical networks
Reviewed-By: Alena

Changes:
- Upgrade insturctions updated to secify 'isolated' networks
2012-07-18 16:53:42 -07:00
prachi 58dab4b62e CS-15476: Multiple physical networks are created with same label (to same NIC) after upgrade
Reviewed-By: Alena

Changes:
- Error out upgrade when we find there will be multiple physical networks with same traffic label
2012-07-18 16:53:20 -07:00
prachi 30737b8cdd CS-15407 [2.2.14 to 3.0.4 upgrade] After upgrade VLAN allocation doesn't happen properly for multiple physical networks
Reviewed-By: Alena

- Update instructions for setups with multiple physical networks and guest vnets
- if there are such setups upgraded to 3.0.3 and face problems starting VMs, then they need to roll back to 2.2.14 and carry out the instructions and then upgrade to 3.0.4
2012-07-18 16:52:39 -07:00
prachi 2e7ec3798d CS-15516 com.cloud.utils.exception.CloudRuntimeException: Exception while adding PhysicalNetworks : Caused by: java.sql.SQLException: No value specified for parameter 1
Reviewed-By: Prachi

- Same bug in 303 to 304.
2012-07-18 16:49:57 -07:00
prachi a7ae4b9988 CS 15516: com.cloud.utils.exception.CloudRuntimeException: Exception while adding PhysicalNetworks : Caused by: java.sql.SQLException: No value specified for parameter 1
Reviewed-by: Prachi

Changes:
Missed on setting the zoneId parameter.
2012-07-18 16:49:28 -07:00
prachi ff8acfa50a CS-15404 [2.2.14 to 3.0.4 upgrade] After upgrade cloud.physical_network.id starts from 200 which is not the case with fresh installation
Reviewed-By: Alena

Changes:
- We need to set the id while creating physical network entry.
2012-07-18 16:49:05 -07:00
prachi 5e03887430 CS-15406 [2.2.14 to 3.0.4 upgrade] Hosts going to Alert state after upgrade as it cann't find any name-label set to "cloud-private"
Reviewed-By: Alena

Changes:
- Looks like we cannot default to 'cloud-private' label.
- If it is not set, CS figures out the default management interface and usus its name.
- We will use the global config variable as the label. if it is null, the label on the physical network will be null.
2012-07-18 16:48:19 -07:00
prachi bef9670476 CS-15407 [2.2.14 to 3.0.4 upgrade] After upgrade VLAN allocation doesn't happen properly for multiple physical networks
Reviewed-by: Alena

Changes:
- If a 2.2.14 setup uses guest vnet and has multiple network tags, we cannot upgrade this to 3.0.x since on upgrade we dont know how to assign the vnets to physical networks
- So we error out and provide instructions
- If an already upgraded 3.0.3 setup has this some guest networks using vnet but the assignment of vnet to physical network is wrong, upgrade to 3.04 will detect it and error out with further steps
2012-07-18 16:45:30 -07:00
prachi b818e6f68f CS-15450: vmware:upgrade fails from 2.2.14GA to 3.04
CS-15414 [upgrde from 2.2.14 to 3.0.4] Need to decrypt xen.guest.network.device value before setting the traffic label after upgrade.

Reviewed-by: Alena

- This uncovered a generic case where only 1 network tag is used and other few untagged networks.
- Upgrdae 303 to 304, should create a physical network for the untagged networks.
- Earlier we were doing this only if the 303 db has multiple physical networks. But in this case the 303 db will  have just 1 physcial network (created due to the single tag used on 2.2.14).
- So  we need to create the extra physical network for the untagged networks irrespective of the number of physical networks present in 303 db.

- This commit also take care of the decryption of the xen.guest.network.device value
2012-07-18 16:43:21 -07:00
prachi 64ce2eac32 CS-15396: [2.2.14 to 3.0.4 upgrade] data_center table doesn't contain "uuid" after upgrade
Reviewed-By: Sheng Yang

Changes:
- Add uuid to data_center while upgrading from 2.2.14 to 3.0x.
- For previous setups that have already been updated, correctly add the uuid in 304 upgrade
2012-07-18 16:39:13 -07:00
prachi 709f1b9c78 CS-15381: Upgrade from 3.0.3 to 3.0.4 is failing
CS-15382: Hosts going to Alert state if there were destroyed networks with non-existent tags prior to upgrade

Reviewed-By: Alena P.

Changes:
- If 2.2.14, create the SG provider by looking at is_security_group_enabled flag
- if 3.0.3, create the SG provider by looking at the ntwk_service_map.
2012-07-18 16:34:13 -07:00
prachi a8fd70fe0a Bug 14773 - VM's are unable to start after upgrade from 2.2.14 to 3.0.3
Reviewed-By: Alena P.

Changes:
- Added upgrade path to 304. This would check the missing portions of the previous upgrades and try to correct.
- This will check if the setup has multiple physical networks with Guest traffic type. If yes then:
- Check if the previous upgrade has left behind any guest networks that were untagged in 2.2.14. For such networks, add a new physical network
- Check if the multiple physical network has tags. If no add tag and clone the network offerings for the networks on this physical network and add this tag to them
- Also clone the network offering service map.
- Thus this creates copies of offerings for each physical network.
2012-07-18 16:32:23 -07:00
Alena Prokharchyk f778f0f174 Fixed update endpointe.url global config var 2012-07-18 15:45:42 -07:00
Alena Prokharchyk 9bebe245ca More logging on nic release 2012-07-18 10:59:07 -07:00
Sheng Yang 3dca5a8689 CS-15615: Fix Site2SiteVpnService injection 2012-07-18 09:58:14 -07:00
Sheng Yang d2643c0fdf CS-15574: Delete VPN gateway and connection when deleting VPC 2012-07-17 18:06:15 -07:00
Alena Prokharchyk 14c3ef17ad VPC: added one more default network offering for VPC - the one not having LB service 2012-07-17 17:47:02 -07:00
Sheng Yang c36de737db S2S VPN: Use source NAT ip address for VPN gateway 2012-07-17 17:22:00 -07:00
Alena Prokharchyk 3994d8427c VPC: fixed listPublicIpAddresses for the addresses with NULL network_id 2012-07-17 17:10:08 -07:00
Alena Prokharchyk 0fdf1a1d8a Resource tags: CS-15591 - delete tags for template/iso when corresponding vo object is removed 2012-07-16 14:36:47 -07:00