Commit Graph

67 Commits

Author SHA1 Message Date
alena 5db28c57e4 bug 9492: allow security group removal when it has ingress rules, but not assigned to any vms yet
status 9492: resolved fixed
2011-04-25 16:43:39 -07:00
alena 41e5e38fef bug 9336: securityGroups can be used by other securityGroups in the same domain only; no cross domain SG authentication
status 9336: resolved fixed

Following changes were made:

* deleteSecurityGroup/authorizeSecurityGroupIngress - removed account/domainId parameters as SG is uniquely identified by id now
* removed account_name field from securityGroup DB table; removed allowed_security_group/allowed_sec_grp_acct from security_ingress_rule.
These values were used for api response generation only for performance purposes; added caching on API level to improve performance
* Added missing security checks for securityGroups/ingressRules
2011-04-22 11:35:29 -07:00
alena 1a6d78eae4 Code cleanup. No need to declare runtime exceptions (CloudRuntimeException, InvalidParameterException, PermissionDenied exceptions) 2011-04-21 16:26:53 -07:00
Frank 92155522f2 Add license header to files 2011-04-14 11:23:14 -07:00
anthony e0ba2a2fa6 clean up transation code 2011-04-12 18:56:49 -07:00
nit debe236a8d bug 8710: CONTD....Introducing a new user role in cloudstack called RESOURCE_DOMAIN_ADMIN. The role would have all the domain_admin rights and the rights to list zone,pods,clusters and so on. More info in the bug 2011-04-11 19:40:37 +05:30
alena a47a4c8cfe bug 9272: fixed the race condition bug when we tried to remove vm from SG after it was expunged (expunge interval was really small, 60 sec).
status 9272: resolved fixed

When do search for vm, do includingRemoved search.
2011-04-04 15:47:14 -07:00
alena 1932652125 bug 5912: Added events and logging for securityGroup create/delete
status 5912: resolved fixed
2011-03-25 15:23:18 -07:00
alena 1cf735c537 bug 8968: use search criteria when list security group by id
status 8968: resolved fixed
2011-03-14 13:45:11 -07:00
Edison Su 8eaa53f282 fix transaction rollback in security group listener, which cause state machine update failed 2011-03-04 10:58:24 -05:00
Edison Su 9ad5139fda fix delete security group rule 2011-03-03 13:44:48 -05:00
Edison Su 8240ae7e8c fix migration 2011-02-28 12:16:40 -05:00
Edison Su b20808d223 minor fix 2011-02-28 12:16:40 -05:00
Edison Su 9b51886850 fix migration issue 2011-02-28 12:16:40 -05:00
Edison Su adbd20ca5a bug 8655: add security group for direct tagged network 2011-02-23 15:53:14 -05:00
alena 15f59e6f58 bug 8637: throw ResourceAllocationException when resource limit is exceeded.
status 8637: resolved fixed
2011-02-18 12:26:58 -08:00
Edison Su 08285af33f fix capacity caclulation issue after migration 2011-02-09 13:33:42 -05:00
abhishek 73eb597ba6 bug 8335: adding the security group objects to the list virtual machines response 2011-02-08 11:48:39 -08:00
abhishek 2a38a58be0 bug 8335: changing the deployVm flow to take in a list of security group ids instead of a list of security group names 2011-02-03 11:37:49 -08:00
Edison Su a46155e895 bug 8094: send networkrulesforssvm command to agent, no matter security group is enabled or not
status 8094: resolved fixed
2011-02-02 16:26:54 -05:00
abhishek 24acc66124 bug 8331: changing the revoke logic to work by taking in the entity id. All other params are obsolete at this point
status 8331: resolved fixed
2011-02-02 13:49:56 -08:00
Edison Su fc97034000 refactor vmstatelistener 2011-01-26 11:01:43 -05:00
Edison Su d45f5cd5bf bug 8119: don't boot from iso, if iso is dettached
status 8119: resolved fixed
2011-01-22 04:04:52 -05:00
Edison Su 4b355ca301 bug 8118: add security group back
status 8118: resolved fixed
2011-01-22 04:04:52 -05:00
abhishek 31c9cce6c3 bug 7949: changing security group code to use ids instead of name
status 7949: resolved fixed
2011-01-20 14:21:32 -08:00
Alex Huang d43717eef8 merge changes 2011-01-14 15:12:13 -08:00
Chiradeep Vittal dd7f8625cc bug 7380: SNAT rules when there are multiple public interfaces
bug 6854: port from 2.1.x
2011-01-13 16:59:35 -08:00
Chiradeep Vittal 2b66b8a924 bug 7929: remove security groups when account is deleted.
status 7929: resolved fixed
2011-01-13 15:40:29 -08:00
abhishek e28882b8ee eliminating use of multiple variables; using the same var for all protocols (denoting ports for tcp/udp and type/code for icmp) 2011-01-11 14:20:02 -08:00
abhishek e4c3f556c2 bug 7942: we were not using the right values for record creation when the proto=icmp. Using the right vals
status 7942: resolved fixed
2011-01-11 13:57:53 -08:00
abhishek ffb8d54dff changing a few obsolete names to std convention 2011-01-07 16:49:51 -08:00
abhishek fec9a6d566 not iterating over cidr list if null 2011-01-07 16:22:28 -08:00
abhishek 274edf1478 fixing sec group rules creation, and also adding some description in commands. checking in so that ui work can begin. 2011-01-07 10:34:00 -08:00
Alex Huang 4eba6d10d7 Moved State into VirtualMachine like other States of objects 2011-01-04 15:01:34 -08:00
Alex Huang 544fa7ff1b remote access vpn, user ip address changes 2010-12-29 09:32:54 -08:00
abhishek d73e06a938 bug 7509: adding search by id for security groups, also refactoring a few method names to use the new scheme
status 7509: resolved fixed
2010-12-16 16:47:57 -08:00
abhishek 5154ba1539 bug 6361: this is a good point to commit; 1st round of refactor is done, code is clean compiling and ms is deploying 2010-12-16 15:37:19 -08:00
alena 44737d24c5 bug 7196: fixed response object generation for authorizeNetworkGroupIngress command (response type is Network group response - the way it was in 2.1.x - instead of IngressRule response)
status 7196: resolved fixed

Also fixed revokeNetworkGroup command - didn't work via 8096 port
2010-11-24 09:50:04 -08:00
Alex Huang d38f7fd56d Moved DAO to server 2010-11-22 07:40:41 -08:00
Alex Huang 1e44925564 api refactoring 2010-11-21 12:00:21 -08:00
alena 9fefa33a36 bug 5701: listNetworkGroups api - apply page size parameter to the NetworkGroup instead of IngressRule.
status 5701: resolved fixed
2010-11-17 15:34:45 -08:00
alena c5d78a726e Modified exception handing in API. Following exceptions are supported now (location - BaseCmd.java):
* MALFORMED_PARAMETER_ERROR - when type of the request parameter is invalid (String instead of Long for id for example)
* PARAM_ERROR - when invalid parameter value is specified in api request. For example, id of non existing vm for StartVmCmd
* ACCOUNT_RESOURCE_LIMIT_ERROR - when user tries to exceed his resource limits by executing the api command.
* INSUFFICIENT_CAPACITY_ERROR - when resource fails to create/start due to insufficient capacity.
* RESOURCE_UNAVAILABLE_ERROR - when user tries to create a vm when storage is not available.
* RESOURCE_IN_USE_ERROR - when user tries to delete/modify resource while it's in use. For example, when we try to delete a network group when it contains ingress rules.
* NETWORK_RULE_CONFLICT_ERROR - when LB/PF rule to add conflicts with existing rule
* ACCOUNT_ERROR - when user is not authorized to execute operation on the resource.
* INTERNAL_ERROR
2010-11-16 11:56:34 -08:00
alena d43a8e983c Fixed authorizeNetworkGroupIngress api command (it stopped working after API refactor) 2010-11-15 17:44:51 -08:00
alena 1c24deda34 1) Refactored current Apis not to use reflection for method invocation. In new version following has to be done:
* Implement callCreate() and execute() methods in apis extending BaseAsyncCreateCmd (example - CreateVolumeCmd)
* Implement execute() method in apis extending BaseCmd and BaseAsyncCmd (example - deleteVolumeCmd and deleteUserCmd)

We no longer need createMethod(), method(), manager() fields in @Implementation annotation, cleanup has to be done.

2) Moved Account/User related methods to AccountManagerImpl. Methods are exposed via AccountService interface.
3) Enhanced exception handing for Api calls.
4) Created ConfigurationService interface, all Api config methods are exposed via it.
2010-11-08 11:27:36 -08:00
Alex Huang 560d7a275e Removed InternalErrorException. Renamed the lock methods on the DAO objects to be more understandable. 2010-11-02 12:25:08 -07:00
Alex Huang 2bc938c3f8 checkins for problems. 2010-10-26 09:35:24 -07:00
Alex Huang d5d8f27cad Added more changes to the api 2010-10-21 15:11:49 -07:00
abhishek 7c11c04427 reverting the change for bug 6361; this was an accidental push instead of commit 2010-10-19 15:21:01 -07:00
abhishek 7cc8087fa6 bug 6361: more name changes from network group to security group 2010-10-19 15:21:01 -07:00
abhishek 523862f571 bug 6361: further name changes from network to security group 2010-10-19 14:35:17 -07:00