Commit Graph

8307 Commits

Author SHA1 Message Date
Nitin Mehta 667c8e7905 CLOUDSTACK-6699: listResouceDetails - enhance it to list by (key,value) pair - allowed to Admin only. 2014-05-18 23:21:37 -07:00
Sanjay Tripathi f789a03769 CLOUDSTACK-6678: API:MS: listCapacity returns; errorcode":530,"cserrorcode":9999,"errortext":"Index: 0, Size: 0"}. 2014-05-15 14:22:40 +05:30
Nitin Mehta afb31fa09f CLOUDSTACK-6660: Dont assume every vm will have a root volume now.
(cherry picked from commit 076bbdcfe8)
2014-05-14 15:00:34 -07:00
Sanjay Tripathi 35cd61c463 CLOUDSTACK-6649: CS is not giving the system-wide capacity for GPU reosurce. 2014-05-14 15:05:28 +05:30
Amogh Vasekar 9b6d430171 This patch disallows deleting / modifying system defined guest OS mappings
Local env
1. Create user defined mapping
2. Delete / modify user defined mapping. Should pass
3. Delete / modify system defined mapping. Should fail

Signed off by :- Nitin Mehta<nitin.mehta@citrix.com>
2014-05-12 22:45:24 -07:00
Sheng Yang 0a62eb8380 CLOUDSTACK-5501: Allow one vpn customer gateway with multiple connections
This restriction was purposely avoid confusion of VPN setup, but later found too
strictly and cause troubles for deployment. Removed after testing one customer
gateway with multiple connections.
2014-05-12 18:50:48 -07:00
Nitin Mehta 7ae784ba3c CLOUDSTACK-6633: listVolumes should return template/iso info for root volumes 2014-05-11 20:36:53 -07:00
Min Chen daadc45122 CLOUDSTACK-6628:[Automation] Create PF rulw API failing with error
"database id can only provided by VO objects".
2014-05-09 18:48:08 -07:00
santhosh 00fcd9fb20 Added fix for CLOUDSTACK-6548
Signed-off-by: santhosh <santhosh.edukulla@gmail.com>
Signed-off-by: Daan Hoogland <daan@onecht.net>

Conflicts:
	server/src/com/cloud/network/NetworkServiceImpl.java
2014-05-09 17:14:06 +02:00
Min Chen 0f79223f28 CLOUDSTACK-6613:IAM: authorizeSecurityGroupIngress fails when SG Name is
passed.
2014-05-08 23:19:28 -07:00
Min Chen 51cb0f9a4a CLOUDSTACK-6598:IAM - listAccount() retrurns "Caller cannot be passed as
NULL to IAM!" when domain deletion is in progress.
2014-05-08 17:56:20 -07:00
Murali Reddy 2a175a2b02 CLOUDSTACK-6608:OVS distributed firewall: default ACL rule is not
getting applied when a tier in VPC is created.

fix ensures, VpcRoutingPolicyUpdate is send when network rules are
programmed when network tier in VPC is created
2014-05-08 15:58:02 +05:30
Daan Hoogland 3515c39cac Revert "CLOUDSTACK-6485: private gateway network should not be associated with vpc"
This reverts commit 3bd594c584.

Conflicts:
	server/src/com/cloud/network/NetworkServiceImpl.java
2014-05-08 11:45:35 +02:00
Devdeep Singh 245b7f4c39 CLOUDSTACK-6510: Fix gson serialization exception in storage migration. Gson couldn't serialize
a map with volume and storagepool objects for logging. Fixed by using volume and storage pool
ids instead of objects in the map.
2014-05-08 12:23:46 +05:30
Alena Prokharchyk b7b89b1297 CLOUDSTACK-6601: added "forDisplay" parameter to listLoadBalancerRules API 2014-05-07 17:06:55 -07:00
Alena Prokharchyk 66d5ebc657 CLOUDSTACK-6596: UUID and display flag update support for LBStickinessPolicy and LBHealthCheckPolicy 2014-05-07 15:46:18 -07:00
Alena Prokharchyk 25ab05a189 CLOUDSTACK-6595: call expunge method marked with @ActionEvent from expunge thread context. So the action even EXPUNGE.VM is generated when vm is expunged by the thread. 2014-05-07 15:46:10 -07:00
Nitin Mehta 5388d349a4 CLOUDSTACK-6597: Updatevm - root admin should be allowed to change instance name 2014-05-07 14:34:01 -07:00
Murali Reddy e18ff2821d CLOUDSTACK-6593: Connectivity service capabilites should be matched with
the provider only if at least one capability is specified

Fix avoids the check, and only if the createNetworkOffering
'StrechedL2'Subnet' capability is specified then it should match against
'Connectivity' service provider
2014-05-07 20:05:47 +05:30
Jayapal d4f167032b Fixed vpc private gateway backend issues 2014-05-07 16:33:46 +05:30
root 4b89a45e57 CLOUDSTACK-3272 Latest changes to add global configuration parameters to control the publishing of events on the message bus 2014-05-07 10:09:03 +05:30
Alena Prokharchyk ee5f5591c7 CLOUDSTACK-6585: added missing metadata support for LBStickiness/LBHealthcheck policies 2014-05-06 17:13:50 -07:00
Kelven Yang 521ac796dd Move EventBus hookup on job framework to ApiServer to decouple job framework away from business logic related hookups. The decoupling is done through internal messaging facility provided inside management server. 2014-05-06 15:48:22 -07:00
Rajani Karuturi 59bf355919 CLOUDSTACK-6531: stopping the router in case of command failures. Also added alerts for failures.
Signed-off-by: Jayapal <jayapal@apache.org>
2014-05-06 20:08:30 +05:30
Jayapal 40836344de CLOUDSTACK-6578: Fixed issue in delete remote access vpn command 2014-05-06 20:08:30 +05:30
Jayapal b9b623bccc CLOUDSTACK-6577: Disable service monitoring in RVR 2014-05-06 20:08:30 +05:30
Jayapal 11591582d5 CLOUDSTACK-6364 Added ip address validation
Also updated to assign vm primary ip to lb rule when vmid is passed virtualmachineid
and vm id ip details in vmidipmap
2014-05-06 20:08:30 +05:30
Girish Chaudhari 0babb92d62 CLOUDSTACK-2697 Removed the clusterId as null from the alert message logs
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-05-05 19:10:17 +02:00
Tanner Danzey 601827e6b3 CLOUDSTACK-5907, CLOUDSTACK-6396: KVM/RBD & KVM/CLVM volumes mistakenly shown as OVM, disables snapshotting
modified:   server/src/com/cloud/api/ApiDBUtils.java

Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-05-05 15:15:25 +02:00
Min Chen 4e674ffad1 CLOUDSTACK-6568:API:createVolume: Volume gets created with wrong domain
ID.
2014-05-02 17:47:06 -07:00
Mike Tutkowski 8ac7784db2 CLOUDSTACK-6170 Corrected an issue related to the "Reinstall VM" command and managed storage with VMware 2014-05-02 18:41:59 -06:00
Min Chen 7f595778ad Fix compilation error due to cherry-pick CLOUDSTACK-6569. 2014-05-02 16:01:13 -07:00
Min Chen 3314e11b70 CLOUDSTACK-6569: IAM - Regular user is able to listNetworks of another
user in the same domain , by passing account and domainId.
2014-05-02 14:58:11 -07:00
Alena Prokharchyk 15c4851fc9 LOUDSTACK-6475: cleanupVPC task - removed the transaction wrapping up multiple VPC destroy as the destroy operation has external calls, to prevent long-locked transaction.
Reviewed-by: Prachi Damle
2014-05-02 14:20:38 -07:00
Sam Schmit 81b4731e3b CLOUDSTACK-6472 listUsageRecords: Pull information from removed items as well, fixing NPEs/Null UUIDs with usage API calls.
Signed-off-by: Sebastien Goasguen <runseb@gmail.com>
2014-05-02 16:27:21 -04:00
Laszlo Hornyak 178240a7da test for HighAvailabilityManagerImpl
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-05-02 21:22:43 +02:00
Laszlo Hornyak 726d8fc3fc test for escapeHTML
- test added
- StringBuffer replaced with StringBuilder

Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-05-02 21:19:49 +02:00
Laszlo Hornyak 78507c07c8 log exceptions in ConsoleProxyServlet
- Added exception to the logger method parameters to make stack trace available
- removed checking of debug level, it does not save temporary object creation here

Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-05-02 21:19:48 +02:00
Min Chen 134a7998ce CLOUDSTACK-6556: Deploy VM failing with error "does
not have permission to access resource Ntwk".
2014-05-01 15:57:29 -07:00
Min Chen d7c5382c58 CLOUDSTACK-6535: IAM:MS:API createVMSnapshot doesn't preserve access
rights.
2014-05-01 15:57:28 -07:00
Min Chen 95e9db2f91 CLOUDSTACK-6556: [Automation] Deploy VM failing with error "does not
have permission to access resource Ntwk".
2014-05-01 15:57:28 -07:00
Min Chen 2521fd482b CLOUDSTACK-6513: remove commented code. 2014-05-01 15:57:28 -07:00
Min Chen db9aee4517 CLOUDSTACK-6513: templateFilter=shared should not show self-owned
template.
2014-05-01 15:57:28 -07:00
Min Chen a9072a6612 CLOUDSTACK-6513: Optimize code by removing deprecated utility to
QueryManagerImpl as private method just used for listTemplates and
listAffinityGroups to avoid misuse by new list APIs.
2014-05-01 15:57:28 -07:00
Min Chen 5521581b6e CLOUDSTACK-6532:Affinity Groups - As admin user, not able to list all
affinity groups available for regular users by passing account and
domainId paramater. This is to revert IAM way of implementing
listAffinityGroupsCmd, will bring it back when we have implemented real
impersonation.
2014-05-01 15:57:27 -07:00
Laszlo Hornyak 94ab870d42 null pointer dereference fix
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-04-29 21:46:16 +02:00
Rajani Karuturi f4779b4d0c Fixed CLOUDSTACK-6509 Cannot import multiple LDAP/AD users into a cloudstack account
Conflicts:
	api/src/com/cloud/user/AccountService.java
	plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapCreateAccountCmd.java
	plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java

Signed-off-by: Koushik Das <koushik@apache.org>
2014-04-29 14:49:06 +05:30
Nitin Mehta dd55095fd5 CLOUDSTACK-6530: Populate the first class entities in the context to be available for publishing more information for the event bus, checking the displayable property etc.
(cherry picked from commit 3e7ea4e8d9)
2014-04-28 18:21:48 -07:00
Laszlo Hornyak fc68922286 Static resource compression
- added compile time maven plugin to compress css and js files
- Added new StaticResourceServlet to serve the requests to static files, this replaces the tomcat DefaultServlet
- Tests
- mapping of the static resource servlet to css and js files

Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-04-28 21:10:18 +02:00
Laszlo Hornyak ecec8d368d autounboxing fix in ConfigurationManager
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-04-28 20:56:45 +02:00
Min Chen 44ff7fea5f CLOUDSTACK-6513: IAM - Templates - When templates are listed with
templatefilter="shared" is used , we see public templates also being
included in the list. This commit reverts listTemplates behavior to 4.3
old logic without using consistent interpretation of list parameters
adopted in new IAM model.
2014-04-28 11:11:53 -07:00
Min Chen 3e4151e13e CLOUDSTACK-6512:IAM - Not able to list shared networks in the Vm
deployment flow. This commit is to revert
ec5ee761d9 to still use old logic for
listNetworks to keep old behavior instead of new IAM model.
2014-04-28 11:11:42 -07:00
Min Chen 6af1a2919b CLOUDSTACK-6501:IAM - DomainAdmin - When listVirtualMachines is used
with listall=true and account and domainId , Vms owned by the account
account is not listed.
2014-04-28 11:11:27 -07:00
Prachi Damle 9514c9e045 CLOUDSTACK-6349: IAM - No error message presented to the user , when
invalid password is provided.

- AccountManager now works using accountId instead of accountType in
following methods too:
- isResourceDomainAdmin()
- isAdmin()
2014-04-28 11:10:50 -07:00
Prachi Damle 797169457b CLOUDSTACK-6349: IAM - No error message presented to the user , when invalid password is provided.
- AccountManager now works using accountId instead of accountType
2014-04-28 11:09:12 -07:00
Daan Hoogland ca907d8d02 formatting 2014-04-28 15:50:05 +02:00
Daan Hoogland 3bd594c584 CLOUDSTACK-6485: private gateway network should not be associated with vpc
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-04-28 14:40:52 +02:00
Sanjay Tripathi 795a6e5fa0 CLOUDSTACK-6480: Creating Service Offering with Implict Dedication planner
fails with message:  "Please specify the pciDevice and vgpuType correctly".
2014-04-28 11:27:47 +05:30
Amogh Vasekar 05802004e2 In 4.3, SSL was turned off by default.
However, for SSVM, the value from configuration server overrides the default in Config.java. Work around is to change in global properties.

Local testing, checking a fresh install has the above property false by default.

Signed-off-by: Nitin Mehta<nitin.mehta@citrix.com>
2014-04-25 14:48:36 -07:00
Sebastien Goasguen 744e2a54e8 Review from pyr https://reviews.apache.org/r/20557/ 2014-04-25 16:59:47 -04:00
Amogh Vasekar 78c683f568 CLOUDSTACK-6437:
Add ability to distinguish between user defined and system defined guest OS and mappings
Add default mappings for XenServer

Local testing with
1. Add new guest OS by API
2. Add new guest OS mapping by API
2014-04-25 13:10:10 -07:00
Mike Tutkowski 2960ba733a CLOUDSTACK-6170 Updated logic to more accurately calculate how much space is currently allocated for a managed storage pool 2014-04-25 12:31:13 -06:00
Nitin Mehta 1d45b75298 CLOUDSTACK-6499:
Made changes so that uploading custom certificate works for ssvm.
    1. Reboot ssvm only when private key is passed meaning the server cert is passed. This is because while uploading the server cert is the last to be uploaded. And we want to propagate the entire chain once uploading is done.
    2. Change the SecStorageSetupCommand sent to ssvm so that it also carries the root cert apart from having the chain and the server cert and key.
    3. Change ssvm agent code to be able to configure root cert to the java key store.
    4. Change ssvm configure ssl script to insert the chain certs correctly.
    5. Fix order of chain certificates for apache webserver in SSVM
    6. Remove double encoding and decoding for uploadCustomCertificate API from UI and server code respectively, so that API call without UI works fine
    7. Java 1.7 - disable using SNI since copyTemplate doesnt work for SSL.
2014-04-24 17:27:02 -07:00
Alena Prokharchyk 1e0d6716ca CLOUDSTACK-6436: listResourceDetails - don't return entries set with display=false, by default
Conflicts:
	api/src/org/apache/cloudstack/api/command/user/volume/ListResourceDetailsCmd.java
2014-04-24 14:35:46 -07:00
jeff 9c4de764f7 Add pre/post-state transition status to messages published on event bus by UserVmStateListener. Allow system VM resource state post-transitions to be published. 2014-04-24 20:05:26 +05:30
Alena Prokharchyk 9c4d20cb68 Revert "Return isolation methods as a part of listPhysicalNetworks call"
This reverts commit 316f23ed5f.
2014-04-22 18:06:46 -07:00
Alena Prokharchyk 316f23ed5f Return isolation methods as a part of listPhysicalNetworks call 2014-04-22 14:57:04 -07:00
Laszlo Hornyak e24bf73a96 new testcase for AccountManagerImpl.deleteUserAccount
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-04-22 22:47:05 +02:00
Laszlo Hornyak 9411e4517e Potential NPE dereference fix
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-04-22 22:47:05 +02:00
Laszlo Hornyak be8c6fe626 test for AccountManagerImpl
- new test for disableUser
- unused code removed
- A redundant if branch removed - all branches are doing the same

Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-04-21 10:25:16 +02:00
Sheng Yang 4620c27ebf CLOUDSTACK-6047: Make aggregation command timeout configurable
In case some environments has different performance or we found some commands
would took too long to execute, one global configuration item is introduced to
specify "time out in seconds per one command in aggregation commands".

By default it's 3 seconds. If admin feel it's too long, it can be adjust to as
low as 1 seconds, which runs still well in my machine.

Conflicts:
	setup/db/db/schema-430to440.sql
2014-04-18 23:36:19 -07:00
Min Chen c4892c2692 Fix FindBugs bug. 2014-04-18 17:31:29 -07:00
Min Chen 82821daffc Fix listAccountsCmd logic to be consistent with new interpretation of
listAll, isRecursive and domainId parameters.
2014-04-18 17:24:00 -07:00
Alena Prokharchyk 6cfe248e2b Fixed NPE in listResourceDetalis logic 2014-04-18 16:32:05 -07:00
Min Chen 29f39149b1 Fix IAM list api implementation based on agreed interpretation for
listAll, isRecursive, domainId and account.
2014-04-17 18:33:22 -07:00
Min Chen c25332fc46 CLOUDSTACK-6429:distinguish the case where caller can see everything and
the case where caller cannot see anything. Also change behavior to
default isRecursive to false if not specified.
2014-04-17 18:33:08 -07:00
Min Chen cdd39a88ba CLOUDSTACK-5960: Remove another check preventing Domain admin and
normal user from registering template in S3.
2014-04-17 18:32:43 -07:00
Min Chen c4b0a1e2d9 CLOUDSTACK-6350: IAM - Listing of VM using uuid when owner account of
this Vm is deleted results is VM not being returned.But list VM with
listAll=true is able to return this VM.
2014-04-17 18:06:29 -07:00
Min Chen 5d59fc7f5a Fix RoleBasedQuerySelector to handle new listAll semantics. If
listAll=true, show all resources that caller (or impersonater) has
ListEntry access type; otherwise, show all resources that caller (or
impersonater) has UseEntry access type.
2014-04-17 18:06:07 -07:00
Min Chen 7796128372 Handle listAll flag in IAM buildAclSearchParameters. 2014-04-17 18:05:44 -07:00
Prachi Damle a0cd0c4d9d Changes while processing the @ACL annotation, to include only 1 object per parameter even if the parameter is tied to multiple interfaces in the @EntityReference 2014-04-17 17:54:19 -07:00
Min Chen da13165743 Change AccountManagerImpl.checkAccess to invoke SecurityChecker
interface that takes multiple controlled entities.
2014-04-17 17:53:01 -07:00
wrodrigues b3f18e7d74 implementation of the featured requests in the issue CLOUDSTACK-6139.
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-04-17 20:51:46 +02:00
Daan Hoogland a05718cb23 [DB-CHANGE] windows line endings 2014-04-17 20:51:04 +02:00
Sheng Yang 74fe010db3 CLOUDSTACK-6434: Make RvR advert_int configurable
In some network environment, 1*3 seconds by default make RvR setup too
sensitive. A configurable parameter would be better for fitting different
network environments.
2014-04-16 20:13:16 -07:00
Sheng Yang a554ebdf75 CLOUDSTACK-6432: Blocking DHCP server to service DNS outside network
This would cover only DHCP only network since in basic and shared network, the
private IP used by VR and network may expose to outside.
2014-04-16 19:13:23 -07:00
Sheng Yang 59a9db39b1 CLOUDSTACK-6433: Don't return success if only one of RvR successfully created
Conflicts:
	server/src/com/cloud/network/element/VirtualRouterElement.java
2014-04-16 18:10:39 -07:00
Saksham Srivastava eb195d0575 CLOUDSTACK-6151: Local data disk with tag goes to the wrong local storage pool
Signed-off-by: Koushik Das <koushik@apache.org>
2014-04-16 16:19:08 +05:30
Ding Yuan c031eb7d38 CLOUDSTACK-6242: exception handling improvements
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-04-15 08:07:15 +02:00
Antonio Fornie f5ba020633 Fix: ParamGenericValidationWorker shouldn't be case sensitive
Signed-off-by: Alena Prokharchyk <alena.prokharchyk@citrix.com>
2014-04-14 10:05:19 -07:00
Marcus Sorensen 11f5bdd78d CLOUDSTACK-6191 Add support for specifying volume provisioning
type (thin, sparse, fat) in disk/compute offerings.

Submitted-by: Yoshikazu Nojima <mail@ynojima.net>
Reviewed-by: Marcus Sorensen, Mike Tutowski
2014-04-10 09:23:04 -06:00
Kishan Kavala 26746feb39 CLOUDSTACK-6376: Return empty list when network tier has no ACL list associated. 2014-04-10 14:45:15 +05:30
Kishan Kavala 16ab5ce76c CLOUDSTACK-6374: Remove entries from lb vm map when lb rule apply fails 2014-04-10 14:45:15 +05:30
Sanjay Tripathi 6a725c6795 CLOUDSTACK-6373: listHost API response is not listing all the details of vgpuType. 2014-04-10 14:08:32 +05:30
Sanjay Tripathi a195205d11 CLOUDSTACK-6366: add vgpuTypes details in vgpu_types table. 2014-04-09 18:23:50 +05:30
Harikrishna Patnala ecc71518a9 CLOUDSTACK-6253: Optimizing VR alerts getting algorithm In addition to this a new configuration parameter is added router.alerts.check.interval defaulted to 30minutes to check for alerts in Virtual Router 2014-04-09 18:12:20 +05:30
Sanjay Tripathi 2ae9da8d47 CLOUDSTACK-6357: Not able to select GPU card in case of GPU-passthrough. 2014-04-08 22:10:09 +05:30
Jayapal e6e4fe4d26 CLOUDSTACK-6353 Fixed listing vm ip details for lb rule 2014-04-08 12:56:02 +05:30
Jayapal 78a29c0d41 CLOUDSTACK-6327 updated uuid to id mapping 2014-04-07 18:03:57 +05:30
Sanjay Tripathi 2530bf9658 CLOUDSTACK-6345: Non gpu enabled VMs are getting deployed in gpu enabled Hosts. 2014-04-07 15:43:46 +05:30