Commit Graph

54 Commits

Author SHA1 Message Date
alena 62b3d548d6 bug 8753: never release public Ip address without ensuring that all corresponding resources (PF/StaticNat/Lb rules) are cleaned up.
Fixed couple of other problems along:

* when expunge PF/Static nat rules as a part of vmExpunge/IpRelease process, first mark all rules as Revoke, and then send commands to the backend. Group commands by Ip address.
Before we used to do Revoke/Send per rule basis.
* When release source nat rule, make sure that corresponding vpn (if exists) is being expunged.
2011-02-28 09:21:05 -08:00
alena f8993d9ec4 Fixed NPE in vm expunge process - when cleanup static nat rules after corresponding vm is expunged, make search for guest Nic including removed. 2011-02-24 18:27:55 -08:00
alena b0aabc1b20 bug 8682: implemented search by id in listPortForwardingRules
status 8682: resolved fixed
2011-02-24 09:55:03 -08:00
alena 8978839d96 bug 8617: Disable firewall/lb/vpn service for Direct network offering, so when user tries to create PF/LB rule for direct IP address, it fails.
status 8617: resolved fixed
2011-02-17 14:31:05 -08:00
alena 42ddf74bc5 bug 8284: don't allow to create static nat rules for 2 different ip addresses and the same vm.
status 8284: resolved fixed
2011-02-15 13:52:00 -08:00
alena 9c2db92b63 Fixed the bug when port forwarding rules were not reset correctly on domR restart/start (multiple public ip addresses case) 2011-02-15 10:49:46 -08:00
alena d80caf24fd bug 8564: Changed implementation for static nat rules. Now we use separate interfaces instead of PortForwardingRules interfaces.
status 8564: resolved fixed
2011-02-15 10:45:28 -08:00
alena 8cd7426dd0 bug 8455: for static nat port range don't allow start port to be bigger than end port
status 8455: resolved fixed
2011-02-11 17:43:56 -08:00
alena 0938509bc0 bug 7341: introduced search by id/vmId to listIpForwardingRules command
status 7341: resolved fixed
2011-02-11 17:14:34 -08:00
kishan 2a6bef2750 seperating service API call form internal calls for revoke port forwarding rule 2011-02-08 12:34:04 +05:30
alena 0082b8435a Fixed account security checks for domain admins in following commands:
* listPortForwardingRules
* listIpForwardingRules
* listRemoteAccessVpns
* listVpnUsers
2011-02-07 16:24:34 -08:00
alena 807562da50 bug 8424: fixed NPE in vmExpunge thread - set accountId for UserContext to the vm's ownerId (this value is being read by UsageEvents generator)
status 8424: resolved fixed
2011-02-07 12:13:59 -08:00
alena 6e399aa698 Vm expunge: when delete port forwarding rules as a part of vm expunge, do searchIncludingRemoved for the vm because vm can be marked for removal already. 2011-02-07 10:02:10 -08:00
kishan 56f3343911 Added action events for VM, volume, Ip and snapshot actions 2011-02-04 19:59:41 +05:30
alena 6f55c4dd7e bug 8270: Synchronize on 1) ipAddress object when create/delete ipForwarding/portForwardingRule and vpn service 2) on networkId when assignTo/removeFrom/deleteLoadBalancer
status 8270: resolved fixed
2011-02-03 18:45:49 -08:00
kishan 5bedf10cbf Added action events for Ip and net rules 2011-02-03 18:13:23 +05:30
alena 9aa9c34029 bug 8340: return networkId for private/public/guest networks in listRouters response. Implemented search by networkId
status 8340: resolved fixed
2011-02-02 13:25:28 -08:00
alena 5d2cc07768 bug 8201: accept "any" value for protocol when open port range for staticNat rule
status 8201: resolved fixed
2011-02-02 12:57:14 -08:00
alena 6544820e74 Moved networkRestart to the NetworkManager as it's up to the manager (not network elements) to decide what to do on restart (IpAssoc/ruleApply/etc..) 2011-02-01 12:16:19 -08:00
alena f6f8a35c75 bug 8251: introduced "id" field for public IP address. In the DB id is a primary key in user_ip_address table; ip_address and source_network_id is a composite key
status 8251: resolved fixed
2011-02-01 12:16:18 -08:00
alena 402506e8a0 Disable static nat for the IP address when corresponding vm gets expunged 2011-01-26 14:17:08 -08:00
alena a4c5bef188 disableOneToOneNat: generate usage events for all rules (port ranges) that are being removed 2011-01-26 10:31:27 -08:00
alena 731e78937f Added 2 new api commands for 1-1 nat feauture: enable/disableOneToOneNat. Here is the 1-1 nat api summary:
* to enable 1-1 nat for ip/vm use enalbeOneToOneNat api
* to open port range (or multiple port ranges) use createIpForwardingRule api.
* to delete one port range use deleteIpForwardingRule api.
* to disable 1-1 nat use disableOneToOneNat api.
2011-01-26 09:35:32 -08:00
alena 4fdbb00060 Allow to add 1-1 Nat with the same public IP address and different port ranges 2011-01-25 15:31:48 -08:00
alena a96f8f9575 Refactored 1-1 NAT feature:
* added new fields to createIpForwardingRule api: startPort/protocol - required, endPort is optional
* updated "firewall_rules" table with a new field "is_one_to_one_nat" (being set when new rule is created)
2011-01-25 14:43:32 -08:00
kishan 16c8111add bug 8122: cover port forwarding rules for usage
status 8122: resolved fixed
2011-01-25 19:14:55 +05:30
alena a4cfe20db8 bug 7389: implemented listPortForwardingRules by ip/account/domainId. Also fixed broken pagination for this call
status 7389: resolved fixed
2011-01-20 11:35:40 -08:00
kishan 94ec7bf27a bug 7842: events refactoring. Still wrok in progress 2011-01-20 21:49:50 +05:30
alena 3f9e96b08a bug 8035: allow PF rules creation with the same parameters except for the protocol
status 8035: resolved fixed
2011-01-19 17:31:59 -08:00
kishan fa2ae5793a bug 7341: introduced search by id and vmId for listIpForwardingRules
status 7341: resolved fixed
2011-01-19 13:13:09 +05:30
alena d0687f663f bug 7863: fixed router cleanup thread
status 7863: resolved fixed

Router cleanp thread is fixed, here is functionality description:

* Runs every "router.cleanup.interval" period of time (1 day by default)
* Stops only domRs running in Advance zone
* Thread Flow:
- gets all Running domRs/dhcps, get their networks, select network that
has to be checked (see criteria below):
- checks that there is only one nic in the op_networks table for the
network, and this nic belongs to domR/dhcp
- Stops domR/dhcp
* Criteria to choose the network:
- Network has to be non-system.
- Network should be one of the following: Guest Virtual (TrafficType=Guest; GuestType=Virtual); Direct Tagged (TrafficType=Public; GuestType=Direct)

Couple of other fixes:

* Added isShared parameter to listNetworks command
* Moved guestType from NetworkOffering to Network
2011-01-07 16:57:47 -08:00
alena 4ec3bc5865 bug 7244: delete corresponding untagged pod vlan ranges when pod is deleted
status 7244: resolved fixed
2011-01-06 16:16:09 -08:00
Alex Huang 4eba6d10d7 Moved State into VirtualMachine like other States of objects 2011-01-04 15:01:34 -08:00
kishan 02ae55cc96 bug 7389: made ip optinal for list pf rules, all rules for the account will be listed when ip is not available
status 7389: resolved fixed
2011-01-03 13:47:18 +05:30
Alex Huang a10ce22f99 remote access vpn from management server side is done 2010-12-29 12:13:35 -08:00
Alex Huang 544fa7ff1b remote access vpn, user ip address changes 2010-12-29 09:32:54 -08:00
alena d005f9133e bug 7603: update uservm count when deploy/recover vm. Also fixed updating volumes count when volume is created as a part of vm deployment
status 7603: resolved fixed

Couple of other fixes:
* Set correct user_id for createVolume event instead of hardcoding it to System (1)
* Deploy dhcp vm when Zone's gateway provider is External Firewall and network is Virtual
2010-12-28 17:32:17 -08:00
alena 085824d524 1) Updated schema for data_center - provider fields can have NULL values.
2) Fixed deletePortForwarding/deleteIpForwardingRule commands to return false when delete rule fails.
2010-12-28 16:22:36 -08:00
alena b7317c12fa bug 7616: Don't try to apply portForwardingRule when vm's nic is not set with Ip address
status 7616: resolved fixed
2010-12-27 15:50:57 -08:00
alena dceab9f18a bug 7705: deletePortForwardingRule is Async now
status 7705: resolved fixed

Couple of other fixes:
* don't allow to send ipAssoc command when domR is in Starting/Stopping states as the command not async so it might be sent in parallel with domR stop/start and fail on the backend.
* DeleteIpForwardingRule api: set ownerId to rule owner id instead of hardcoding it to 1(System)
2010-12-27 14:17:17 -08:00
kishan bb0e6a0ae3 bug 7504: Events refactoring 2010-12-24 12:58:32 +05:30
alena ca92c28e0e Fixed setupNetwork command to use vlan tag instead of vlan dbId.
Changed LoadBalancerConfigCommand to use Array data structrue instead of List as list is not handled well by gson.
2010-12-17 12:07:06 -08:00
edison 5279ac1468 fix expunge 2010-12-16 13:22:42 -08:00
alena 0d1c529175 Fixed revokeRule method to set FirewallRule state to Revoke in the DB. 2010-12-16 12:19:53 -08:00
alena 1f7d74dbec 1) Disabled updatePortForwardingRule api command.
2) Added vm information (id, name, display_text) to all port forwarding rule responses.
2010-12-08 14:28:37 -08:00
Alex Huang fcdd20ca06 more checkin 2010-12-06 14:17:53 -08:00
Alex Huang 16caf1954b New ip address states and mode 2010-12-04 17:32:32 -08:00
Alex Huang daa9add158 removed router stuff from network manager 2010-12-04 17:32:31 -08:00
Alex Huang a8b617c596 port forwarding is now in 2010-12-03 08:48:03 -08:00
Alex Huang b859e103d8 ip nat rule forwarding done 2010-12-03 08:48:03 -08:00