64ff67da55
Merge pull request #654 from DaanHoogland/CLOUDSTACK-8656
...
Cloudstack 8656: do away with more silently ignoring exceptions.a lot of messages added.
some restructuring for test exception assertions and try-with-resource blocks
* pr/654: (29 commits)
CLOUDSTACK-8656: more logging instead of sysout
CLOUDSTACK-8656: use catch block for validation
CLOUDSTACK-8656: class in json specified not found
CLOUDSTACK-8656: removed unused classes
CLOUDSTACK-8656: restructure of tests
CLOUDSTACK-8656: reorganise sychronized block
CLOUDSTACK-8656: restructure tests to ensure exception throwing
CLOUDSTACK-8656: validate the throwing of ServerApiException
CLOUDSTACK-8656: logging ignored exceptions
CLOUDSTACK-8656: try-w-r removes need for empty catch block
CLOUDSTACK-8656: try-w-r instead of clunckey close-except
CLOUDSTACK-8656: deal with empty SQLException catch block by try-w-r
CLOUDSTACK-8656: unnecessary close construct removed
CLOUDSTACK-8656: message about timed buffer logging
CLOUDSTACK-8656: message about invalid number from store
CLOUDSTACK-8656: move cli test tool to separate file
CLOUDSTACK-8656: exception is the rule for some tests
CLOUDSTACK-8656: network related exception logging
CLOUDSTACK-8656: reporting ignored exceptions in server
CLOUDSTACK-8656: log in case we are on a platform not supporting UTF8
...
Signed-off-by: Remi Bergsma <github@remi.nl>
2015-08-14 21:38:49 +02:00
882de20e1c
CLOUDSTACK-8656: reorganise sychronized block
2015-08-14 16:03:17 +02:00
a3ae8e0645
coverity 1315774: improvement of code to negate false positive
2015-08-12 01:04:06 +02:00
e8a00ed989
CLOUDSTACK-8656: try-with-resource in vmsd reader
...
moved closeable util function up the hierarchy
2015-08-04 11:37:06 +02:00
1f460f4174
CLOUDSTACK-8656: messages on SQL exception in DbUtils!
2015-08-03 20:49:02 +02:00
e2b6237464
CLOUDSTACK-8656: debug messages on interupted exceptions
2015-07-30 16:03:10 +02:00
03b076cd1b
coverity 1116668: conditionally close ds provided connection
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
This closes #599
2015-07-17 13:22:43 +02:00
a1ff7e24f3
coverity 1311707: only sql exception on select would have been caught. passing all runtime exceptions through
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #584
2015-07-14 13:41:09 +02:00
b0136c56e7
coverity 1116564: complicated update of sequences fixed
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
This closes #564
2015-07-09 21:30:24 +02:00
5557ad5588
Offer a getDurationInMillis() method in the Profiler utility class
...
- New implementation uses nanoseconds. Due to that, the places where the Profiler is used as a Monitor and/or
a stopwatch will suffer with the difference in the return
- Also added a getDuration(), which returns the time in nanoseconds in case someone wants to use it instead
- Added an extra test to check if the getDuration() works fine with nanoseconds
- Fixed the test that checks the time in milliseconds: I added an error margin to cover the test better
Signed-off-by: Daan Hoogland <daan@onecht.net>
2015-06-24 09:36:40 +02:00
069aa4e5f3
CLOUDSTACK-8433: remove awsapi db usage and add upgrade cleanup path
...
- Removes awsapi db properties usage across codebase
- Removes references from spring xmls, test cases and TransactionLegacy
- Adds sql command to drop database cloudbridge in schema-451to460-cleanup.sql
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-05-06 15:22:04 +02:00
3577423da9
removed executable flags from java classes
...
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-11-23 19:49:01 +01:00
ffaabdc13f
CLOUDSTACK-7832: Move some job db update and item purge to
...
completeAsyncJob transaction to avoid MySQL deadlock.
2014-11-03 10:41:36 -08:00
31a42d2b7a
Fixed few coverity patches
...
Signed-off-by: Santhosh Edukulla <santhosh.edukulla@gmail.com>
2014-10-09 11:45:26 +05:30
f5eae55abb
timeInSeconds * 1000
...
timeInSeconds is int type, if timeInSeconds is very big, it makes "timeInseconds * 1000" very small even 0
2014-09-24 10:57:36 -07:00
c74dada854
add logs for lock acquire and release
2014-09-24 10:28:04 -07:00
2503aaafef
Revert "removed unused class"
...
This reverts commit 093fa6f0a5
2014-09-24 08:41:55 +02:00
d8ad3e32bc
throw timeout exception when lock acquire times out
2014-09-23 18:01:32 -07:00
093fa6f0a5
removed unused class
...
ramework/db/src/com/cloud/utils/db/TransactionContextInterceptor.java
2014-09-23 16:48:14 -07:00
61fe959bb4
Removed invalid assertions from code. Now the MS can be run with assertions enabled (using -ea flag)
2014-07-10 12:18:29 +05:30
a600d8408e
Fixed Resource Leaks, null dereferences, few other issues reported by coverity
2014-07-04 16:17:58 +05:30
b2283d7a28
Fixed few resource leaks and added secstoragefirewallcfg command support to simulator
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-06-24 23:19:47 +02:00
1c80185170
Fixed Resource Leaks, null dereferences, invalid value comparisons, invalid result set loop
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-06-21 12:38:46 +02:00
0c28f36ff1
Fix a number of resource leaks reported by Coverity
2014-06-13 14:42:35 +02:00
ba848087f8
Disable IAM feature from 4.4 release.
2014-05-22 18:27:08 -07:00
54c83c168f
removed redundant Integer instantiation in GenericDaoBase
...
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-03-28 18:40:25 +01:00
48e08fe676
Merge branch 'master' into rbac.
2014-03-06 14:02:20 -08:00
a0f932437c
Move mysql ha strategy to a plugin. Activate this plugin using the mysqlha profile or the noredist flag
2014-02-27 09:51:02 +01:00
19b15a1bdc
Fix parameter index in getCount function.
2014-02-20 15:13:29 +01:00
443acac927
Fix functional issue introduced by some findbug changes.
2014-02-14 18:37:47 +01:00
cbea6d26e8
Fix and test GroupBy SQL query creation
...
Signed-off-by: Ian Southam <isoutham@schubergphilis.com>
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-02-14 18:37:46 +01:00
5a6ad11fa2
findbugs findings
...
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-02-14 18:37:46 +01:00
e0de79b170
Resource metadata: by default, all metadata is set with display=true (meaning that the detail is avaialble for display to the regular user). If admin wants to set a specific detail to be false, he has to specify it explicitly in addResourceDetail command
2014-02-10 12:05:59 -08:00
f84375442e
Merge branch 'master' into rbac
...
Conflicts:
api/src/org/apache/cloudstack/api/command/user/autoscale/ListAutoScaleVmProfilesCmd.java
api/src/org/apache/cloudstack/api/command/user/volume/ResizeVolumeCmd.java
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java
server/src/com/cloud/api/ApiServer.java
server/src/com/cloud/api/query/QueryManagerImpl.java
server/src/com/cloud/template/TemplateAdapterBase.java
setup/db/db/schema-430to440.sql
tools/apidoc/gen_toc.py
2014-02-04 12:07:32 -08:00
e4da3775c9
removed redundant Long, Short, Double, Float and Boolean instantiations
...
- Added unit tests
- Added javadoc
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-01-25 20:09:45 +01:00
929fbabaa2
Merge branch 'master' into rbac.
2014-01-17 14:37:08 -08:00
bae498c89e
Handle search of those entities without db view created using new ACL
...
model.
2014-01-13 21:55:56 -08:00
55a6df4501
Resources leaks, refactoring and testing
...
Removing resource leaks from UsageSanityChecker and
refactoring it (encapsulation, removal of copy and paste, constants...)
Modularize static method for closing Statments in TransactionLegacy
and reusing this new method from other classes (Upgrade2214to30)
Create Unit and Integration Tests for UsageSanityChecker
Add DBUnit cases and integration profile for nitegration tests as
a base for future DB tests
2013-12-18 10:55:04 +01:00
be5e5cc641
All Checkstyle problems corrected
2013-12-12 12:26:07 -08:00
d620df2bdd
Reformatted all of the code.
2013-11-21 06:15:26 -08:00
eaa250fd3c
Formatted again after all the tab expansions and eol removals
2013-11-21 04:47:01 -08:00
224f479974
Removed trailing spaces
2013-11-21 04:08:01 -08:00
e4b22d0fca
Replace all tabs, particularly the ones in the comments
2013-11-21 03:39:58 -08:00
8d62744681
Reformat all source code. Added checkstyle to check the source code
2013-11-20 07:26:53 -08:00
065e5afa08
Tests for DBUtil
...
This patch adds test for the lock management:
- getGlobalLock
- releaseGlobalLock
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2013-11-16 15:44:31 +01:00
67fc2f53e2
CLOUDSTACK-4916: Fixing the issue with DB HA when there are more than 2 db nodes (Issue was mysql DriverManager was returning salve db nodes on random basis which was causing issue)
...
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2013-11-14 11:10:48 +05:30
dcd3c44279
CLOUDSTACK-4916: To Enable Master High Availability using mysql connector params and mysql's 2 way replication
...
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2013-11-08 16:18:14 +05:30
dc3d279272
CLOUDSTACK-4833:[Automation][BVT] Template and ISO test cases failing
...
from BVT suite, during LIST api call.
2013-11-07 15:19:19 -08:00
78b1ac4126
CLOUDSTACK-3868: fixed "count" param in listUsageRecords API to return the actual number of records matching the search criteria. Used to return the wrong value - the number of records per page
...
Conflicts:
server/src/com/cloud/usage/UsageServiceImpl.java
utils/src/com/cloud/utils/db/GenericDaoBase.java
2013-10-31 15:25:57 -07:00
afaf6370dd
Fix change that broke db.properties.override
2013-10-31 09:21:34 -07:00
Remi Bergsma
Daan Hoogland
Daan Hoogland
wilderrodrigues
Rohit Yadav
Laszlo Hornyak
Min Chen
Santhosh Edukulla
Anthony Xu
Hugo Trippaers
Koushik Das
Antonio Fornie
Ian Southam
Alena Prokharchyk
Prachi Damle
Alex Huang
Damodar Reddy
Darren Shepherd