fdefee75ff
vmware: fix inter-cluster stopped vm and volume migration ( #4895 )
...
Fixes #4838
For inter-cluster migration without shared storage, VMware needs a host to be specified. Fix is to specify an appropriate host in the target cluster during a stopped VM migration. Also, find target datastore using the host in the target cluster.
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2021-04-10 13:22:28 +05:30
76e9c2772b
Merge remote-tracking branch 'origin/4.15'
2021-04-06 16:50:31 +05:30
35b20b2367
vmware: Fix worker VM hardware version format ( #4851 )
...
This PR fixes a small bug when explicitly setting VM hardware versions lower than version 10.
Vmware expects the hardware version in format: vmx-DD where DD is a two-digit representation of the virtual hardware version. For hardware version lower than 10, CloudStack was not using to digits for the hardware version number, which ended up on an error while creating worker VMs. (vmx-8 for example instead of vmx-08)
2021-04-06 16:28:52 +05:30
0dbeb262e4
server: Support for persistence mode in L2 networks ( #4561 )
...
This PR aims at introducing persistence mode in L2 networks and enhancing the behavior in Isolated networks
Doc PR apache/cloudstack-documentation#183
Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com>
2021-04-05 14:37:11 +05:30
c1a02e1697
Merge remote-tracking branch 'origin/4.15'
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2021-03-29 16:34:22 +05:30
d763169b1c
Restore VMware VM naming convention option ( #4581 )
...
* initial chanes
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
* changes
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
* fix
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
* make check explicit for instance name flag
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
* allow hiding vm details (in ui)
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
* condition based on name instead of displayname
Signed-off-by: Abhishek Kumar <abhishek.kumar@shapeblue.com>
2021-03-29 16:13:14 +05:30
97176690b8
server: Fix issue with volume resize on VMWare (deploy as-is templates) ( #4829 )
...
This PR fixes the issue pertaining to volume resize on VMWare for deploy as-is templates. VMware deploy as-is templates are those that are deployed as per the specification in the imported OVF. Hence override root disk size will not be adhered to for such templates. Moreover, when we deploy VMs in stopped state and resize the volume, the root disk doesn't get resized but the volume size is merely updated in the DB.
This PR also includes the following (for deploy as-is templates):
- Disables overriding root disk size during VM deployment on the UI
- Disables selection of compute offerings with root disk size specified, at the time of deployment
- Provided users with the option to deploy VM is stopped state via UI (so as to give an option to users to resize the volumes before starting the VM)
Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com>
2021-03-29 12:54:47 +05:30
d6e8b53736
vmware: vm migration improvements ( #4385 )
...
- Fixes inter-cluster migration of VMs
- Allows migration of stopped VM with disks attached to different and suitable pools
- Improves inter-cluster detached volume migration
- Allows inter-cluster migration (clusters of same Pod) for system VMs, VRs on VMware
- Allows storage migration for stopped system VMs, VRs on VMware within same Pod if StoragePool cluster scopetype
Linked Primate PR: https://github.com/apache/cloudstack-primate/pull/789 [Changes merged in this PR after new UI merge]
Documentation PR: https://github.com/apache/cloudstack-documentation/pull/170
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2021-02-12 12:41:41 +05:30
b482da8c91
Updating pom.xml version numbers for release 4.15.1.0-SNAPSHOT
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2021-01-11 13:58:30 +05:30
280c13a4bb
Updating pom.xml version numbers for release 4.15.0.0
...
Signed-off-by: Daan Hoogland <dahn@onecht.net>
2021-01-05 15:51:02 +00:00
81e9e6809b
Updating pom.xml version numbers for release 4.15.1.0-SNAPSHOT
...
Signed-off-by: Daan Hoogland <dahn@onecht.net>
2021-01-04 11:34:46 +00:00
e26202f23e
Updating pom.xml version numbers for release 4.16.0.0-SNAPSHOT
...
Signed-off-by: Daan Hoogland <dahn@onecht.net>
2021-01-04 11:32:10 +00:00
01b3e361c7
Updating pom.xml version numbers for release 4.15.0.0
...
Signed-off-by: Daan Hoogland <dahn@onecht.net>
2020-12-23 16:32:25 +00:00
51034be270
Fix migrateVMwithVolumes API in case of multiple volumes on VMware ( #4480 )
...
Problem:
When migrateVMwithVolumes API is tried on a VM with two volumes to migrate to a different host and tried to migrate only one volume, Cloudstack migrates both the Volumes but then marks only one of them migrated. This makes volume inaccessible due to inconsitency in path of volume in cloudstack and vsphere
Solution:
Set the target datastore in relocate spec properly for each volume
2020-11-20 12:38:06 +00:00
87e1fa9e02
Removed sensitive info from UI/API when volume attach/detach fails ( #4476 )
...
* Removed sensitive info from UI when attach/detach fails
* minor formatting change
2020-11-19 04:39:37 +05:30
7d7e7f7941
Check there is at least a host to verify pool compatibility for a storage policy
2020-10-26 09:07:23 -03:00
85f5512ec3
Fix unit test failure
2020-10-25 02:53:43 -03:00
c405e5dc31
Add new API to check storage policy compatible pools and fix marvin test for storage policies
2020-10-25 02:19:22 -03:00
8c68843142
Fix boot into hardware
2020-10-21 11:47:15 -03:00
f1f490b151
Fix restore VM workflow - clone and replace existing VM instead of cloning and moving disks
2020-10-20 19:47:27 -03:00
67794aba23
Fix reinstall VM bug
2020-10-20 03:00:21 -03:00
88c02efd27
Fix deploy-as-is templates GC
2020-10-19 15:05:58 +05:30
048e8c8744
Fixed the issue of VM deletion not cleaning the VM folder on vVols datastore. Fixed it by deleting the VM as complete entity including the extra root disks.
2020-10-19 15:05:58 +05:30
5fdabc1cb0
Added storage policy details to disk while creating disk and restricted migration of volumes to storage pools which are not storage policy compliance
2020-10-19 15:05:58 +05:30
46b5322d9b
Adding vSphere storage policy to disk on start command and attach volume command
2020-10-19 15:05:58 +05:30
d69283a013
Fix reset/restore VM
2020-10-19 15:05:57 +05:30
9dd1d60db9
Fix multidisk VM deployment on vVol datastore
2020-10-19 15:05:57 +05:30
388a9c2c6d
Reconcile chaininfo after attaching volume
2020-10-19 15:05:57 +05:30
9b923ba9dc
Handle detach volume of datastore cluster if the volume name has changed at vCenter level and reconsile the chaininfo
2020-10-19 15:05:57 +05:30
588b7a1c90
Cleanup volume wrapper VM(ROOT-xxx) while deploying VM in case of any failure. since the same name will be used on retries and that will eventually fails saying volume wrapper VM already exists.
2020-10-19 15:05:57 +05:30
897cc4bdba
Fix nested virt marvin test
2020-10-19 15:05:57 +05:30
94bebe8792
Revert back deploy as is column on templates but keep it as default for new templates
2020-10-19 15:05:57 +05:30
46d412d998
Fix for system VMs
2020-10-19 15:05:57 +05:30
9b51a706db
Set deploy-as-is to default on VMware
2020-10-19 15:05:57 +05:30
2f03877723
Search in possible folders for volume while dettaching the volume
2020-10-19 15:05:57 +05:30
9543fd6e6a
Fix startcommand on Datastore cluster when the volume datastore in CloudStack mismatches with vCenter datastore. Volume could have migrated with in datastore cluster which caused the mismatch
...
Fix dettach volume when volume is not on CloudStack intended datastore
2020-10-19 15:05:57 +05:30
78aa3df440
Fix reboot deploy-as-is VMs
2020-10-19 15:05:57 +05:30
667cb53772
Fix mismatch from OVF nic adapter type and expected adapter type string
2020-10-19 15:05:57 +05:30
bb90ce5bd7
Fix for dettached disk migrations from vVols to other datastores
2020-10-19 15:05:57 +05:30
7a8dd46b32
Fix deploy as-is disks cleanup
2020-10-19 15:05:57 +05:30
89aa25d023
VM deployment from ISO not working on VSAN65, fixed by adding a backup to create disk using old way
2020-10-19 15:05:57 +05:30
c6c4bfe30c
Fix deploy as is with datadisks
2020-10-19 15:05:57 +05:30
acf872cdab
Relocate deploy-as-is cloned VM if does not end on the host receiving the start command and restore deployment logs
2020-10-19 15:05:57 +05:30
edfbed34ad
Use network adapter from OVF on deploy-as-is
2020-10-19 15:05:57 +05:30
61e7625d49
Do not set user-configurable details for deploy-as-is VMs
2020-10-19 15:05:57 +05:30
44dc0c6072
Fixed rat failure on new class DeployAsIsHelper.java
...
Also removed some unused imports during rebase
2020-10-19 15:05:57 +05:30
19c83fef64
Fix zone to zone scope volume migrations NPE
2020-10-19 15:05:57 +05:30
6ebfdc6854
Dettached datadisk migration failed between NFS storages.
...
Fixed the issue of worker VM name being null
2020-10-19 15:05:57 +05:30
bb4ce2118d
Add new template and vm deploy as is details table and refactor
2020-10-19 15:05:57 +05:30
fab6b41c90
Delete VM fix which does not move detached disks to fcd folder
...
vVols attach disk fix
2020-10-19 15:05:56 +05:30
f74262b12a
Snapshot on dettached volume considering wrong path, corrected it
2020-10-19 15:05:56 +05:30
f53f11b010
Fix seeding template issue after PR merging
2020-10-19 15:05:56 +05:30
f825a94dc4
Fixed volume migrations to and fro vVols datastorewq
2020-10-19 15:05:56 +05:30
700ab1a5ef
vVols datastore support added
2020-10-19 15:05:56 +05:30
5652097ef0
Added backup on fail over scenrio in case of new create disk method
2020-10-19 15:05:56 +05:30
d864e9dc39
[VMware] Full OVF properties support
2020-10-19 15:05:56 +05:30
04d400f055
Handle import unmanaged VM into CloudStack to support any type of datastore
2020-10-19 14:57:16 +05:30
40934ba9ff
Fix travis failures by removing dependency of vmware from storage.
...
Added a new command class to verify the vCenter details provided while adding primary storage
2020-10-19 14:57:16 +05:30
570f3214b8
Handle VMFS6 sesparse format disk files
2020-10-19 14:57:16 +05:30
0a412ac6da
Handle volume copy from secondary to primary in case of vSAN
2020-10-19 14:57:16 +05:30
af84743fd9
Fix addition of datastore clusters not to configure it as non NFS storage
2020-10-19 14:57:16 +05:30
b88df5ee5b
Fixed a smoke test while taking snapshot
2020-10-19 14:57:16 +05:30
a5531a9e86
Changed artifact id from pbm for vmware-pbm for policy based management
2020-10-19 14:57:16 +05:30
e211b92324
Changed workflow for storing volumes in sec storage
2020-10-19 14:57:16 +05:30
36d65905b1
Base folder creation on datstores restrict only to primary storages, for secondary storage datastore it is not required
2020-10-19 14:57:16 +05:30
c8a28f34ee
Use clonevm task while creating template from volume
...
Old way is by taking snapshot of entire VM and then clone from that snapshot with the required disk
2020-10-19 14:57:16 +05:30
4178a7cd90
inter-cluster migration support
2020-10-19 14:57:16 +05:30
5aac6c3f0f
Fix immutable list to add another entry to list
2020-10-19 14:57:16 +05:30
ed7efdf4d2
Generalise linked clone formats which are different for each datastore type
2020-10-19 14:57:16 +05:30
c9c38c0f37
Handle datastore clusters in list storage pools to list only parent not the children in the Datastore cluster
2020-10-19 14:57:15 +05:30
53fa3beecf
Register Disk to first class disk whereever possible
2020-10-19 14:57:15 +05:30
41b3fc19d6
Add Datastore cluster and the child entities which are datastores in the cluster into CloudStack
...
Setting scope is still pending.
2020-10-19 14:57:15 +05:30
f858387b3c
Import storagepolicies when vmware datacenter is added or updated
2020-10-19 14:57:15 +05:30
48786b2d31
DataStore Clusters addition as a storage pool
2020-10-19 14:57:15 +05:30
c45b83a158
Logging variable name change
2020-10-19 14:57:15 +05:30
586fa7eeaf
Added listVsphereStoragePoliciesCmd
2020-10-19 14:57:15 +05:30
233e665b34
Fix response list on importVsphereStoragePoliciescmd
2020-10-19 14:57:15 +05:30
778148ba16
Fix importstorage policies to update deleted policies on vcenter
2020-10-19 14:57:15 +05:30
18340e96b1
importVsphereStoragePolices improvements
2020-10-19 14:57:15 +05:30
6df819028e
UI changes and accept any type of datastore as presetup in vmware
2020-10-19 14:57:15 +05:30
4bbb747b23
VMFS to presetup change
2020-10-19 14:57:15 +05:30
3d9edeeb9d
Bug fixing on default base folder
2020-10-19 14:57:15 +05:30
aa07959f2a
Use VStorageObjectManager for disk operations.
...
Created disks using VStorageObjectManager
Removed redundant code around attach volume and create volumes
2020-10-19 14:57:15 +05:30
487bb03c4d
Added Storagepolicy while creating diskoffering. CreateDiskOffering API now takes storagepolicy as a parameter with UUID value
2020-10-19 14:57:15 +05:30
fb0a96e7fb
Check if datastore is complaince with the storagepolicy provided in the disk offering.
...
Added corresponding manager objects from PBM sdk to do the job.
Made dao layer changes to read the storage policy in diskoffering
2020-10-19 14:57:15 +05:30
27e5dfa633
Updated code to handle sync of storage policies when importVsphereStoragePolicies API is called multiple times
2020-10-19 14:57:15 +05:30
a951e5f57f
Fixed unit test failure
2020-10-19 14:57:15 +05:30
8b23ea90b8
Moved Dao and VO files to different packages
2020-10-19 14:57:15 +05:30
a4ec86a652
Added Storage policy id to VO
2020-10-19 14:57:15 +05:30
037fcfd032
Fixed bean creation errors on VsphereStoragePolicyDaoImpl
2020-10-19 14:57:15 +05:30
b8b4f0f9ad
Added importVsphereStoragePolicies API and scheme changes
2020-10-19 14:57:15 +05:30
a72782f2e5
Fix root folder issue on datastore
2020-10-19 14:57:15 +05:30
0701dc9d9c
Initial commit adding few required managed object classes and added pbm sdk
2020-10-19 14:57:15 +05:30
5b419b90d0
vmware: use hotPlugMemoryIncrementSize only for valid value ( #4348 )
...
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2020-10-14 16:05:57 +05:30
1bbb29d034
Fixed vm-templates not being removed from primary storage with storag… ( #4389 )
...
* Fixed vm-templates not being removed from primary storage with storage garbage collection
* Update vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java
Co-authored-by: sureshanaparti <12028987+sureshanaparti@users.noreply.github.com>
* Var name
Co-authored-by: sureshanaparti <12028987+sureshanaparti@users.noreply.github.com>
2020-10-12 15:54:12 +05:30
479ef8aafa
VMware: match hardware version for worker VM when taking a snapshot ( #4321 )
...
* Add hardware version to worker VM
* Added worker VM hardware version when creating a template from a volume and migrating a detached volume
* Add null parameter back that was removed by merge
2020-10-09 17:06:07 +02:00
86fcb14238
Merge remote-tracking branch 'origin/4.14'
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2020-09-24 12:20:29 +05:30
ca1e02fab9
vmware: search unmanaged instances using hypervisor name ( #4328 )
...
VMware code keeps a cache of existing VMs on a hypervisor host using cloud.vm.internal.name property of the VM. Searching for unmanaged instances/VMs on a host might not return an expected result when this property differs from the actual name of the VM.
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2020-09-24 11:01:33 +05:30
4f8b88baea
vmware: while plugging in nics get existing sorted nic devices ( #4336 )
...
In large environments, with VR having multiple nics when plugging in
nic, it must get existing nics by sorted device ID otherwise it may
cause incorrect nic plugging/order.
Fixes #4246
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2020-09-24 10:59:39 +05:30
90e72b1e40
vmware: Create template from detached data-disks on VMWare ( #4294 )
...
Creation of templates from detached data disks results in a Null Pointer Exception on VMWare, as it expects the volume to be attached to a VM.
To fix this behavior and make it consistent with other hypervisors, creation of the template from the volume in case not attached to a VM is facilitated by creating a worker VM, attaching the disk to the worker VM, creating the template from it, and then destroying the VM.
Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com>
2020-09-18 08:25:17 +05:30
Abhishek Kumar
Rohit Yadav
Nicolas Vazquez
Pearl Dsilva
Abhishek Kumar
Daan Hoogland
Harikrishna
Spaceman1984
Pearl Dsilva