The method getCommandHostDelegation(long hostId, Command cmid) got overidden in VmwareGuru.java as part of
commit bfe30cd2e3. Earlier there was no HV specific implementation and copy
volume from secondary to primary worked fine. With the Vmware specific change the code was getting hit even
in case of XS and other hypervisors and failed with NPE.
Now there is a check in the Vmware implementation to check if the HV is of type Vmware.
sourceNAT service on it
if a portable ip is first IP associated with a non-VPC network, then its
being considered as source nat IP. This fix adds exemption for portable
IP not to be considred for source nat.
When you have a method with named parameters, all calls to it should
explicitly pass name=value pairs. Not doing so can result in the wrong
params being passed in the method call. This is a result of the
"services" dictionary being passed into the isportable flag failing the
API signature generation and hence the API call.
Signed-off-by: Prasanna Santhanam <tsp@apache.org>
(cherry picked from commit 28835054e6)
ISO size can differ from the mounted packages within the ISO. Remove the
size check and only perform attach and detach in the guest.
Signed-off-by: Prasanna Santhanam <tsp@apache.org>
(cherry picked from commit d875a36e5c)
Add simultor to the seemingly strict filter which should happen within
the hypervisor resource and not the virtualmachine :/
Signed-off-by: Prasanna Santhanam <tsp@apache.org>
Added isportable param to associateIP API. Fixed base class
for PortableIP tio call portableip APIs.
Removed test_createPortablePublicIPAcquire from basic zone run
requires additional network creation handling which can be done
in component tests.
Signed-off-by: Prasanna Santhanam <tsp@apache.org>
(cherry picked from commit 4054a8e2ac)
Implement the download url expiration functionality for templates. Also persist the template download urls after their creation
Signed off by : nitin mehta<nitin.mehta@citrix.com>
storage pool entry was removed from the db but the pool wasn't unmounted from
the host. There was a check that if the pool is not in UP state then the entry
can just be removed. That is wrong. A pool can only be removed if it is in
maintenance state. So after putting the pool in maintenance state if admin
tries to delete the pool we just remove the db entry without un-mounting the
storage pool from the host. Removed the incorrect check.
- Fix the test that ensures vpc offerings cannot be created with
firewall service
- CLOUDSTACK-3902 blocks the fix for vpc offerings created without
source nat service. Without source NAT VPC creation should fail.
Signed-off-by: Prasanna Santhanam <tsp@apache.org>
(cherry picked from commit e4de46e4b1)
One of the VPC offerings (4) is deleted in the test before moving into
teardown. This offering should be removed from cleanup.
Signed-off-by: Prasanna Santhanam <tsp@apache.org>
PublicIpAddresses.list takes an associatednetworkid which lists all the
public ip addresses in the deployment's physical network associated with
the vnet.
Various tests failed because of `networkid` used in place of
`associatednetworkid`
Signed-off-by: Prasanna Santhanam <tsp@apache.org>