Commit Graph

10877 Commits

Author SHA1 Message Date
Wei Zhou dfd59321b1
server: fix format error with memorywithoverprovisioning in list hosts response (#4435) 2020-10-30 09:38:59 +01:00
Gabriel Beims Bräscher 6f559d285a
Prevent deploying IPv6 network if Zone has no IPv6 DNS configured (#4177) 2020-10-30 09:07:20 +01:00
Rakesh 4cd9886a89
FIX s2svpn connection stuck on Pending state (#4429)
When we try to reset the site 2 site vpn connection while
the VR's are being restarted, the connection enters the
PENDING state and we cant reset the connection.

So change the state from PENDING to disconnected.

Steps to reproduce the issue

1.create a VPC with a tier (vpc-001-001 in vpc-001), create a vm
2.create a VPC with a tier (vpc-002-001 in vpc-002) with different cidr, create a vm
3.create custom gateway for both vpn
4.enable site-to-site vpn on both vpn, and add vpn connection to each other. both should be "Connected"
5.restart vpc-001 with cleanup and monitor it
6.when the first router is destroyed, go to site-to-site vpn page and reset vpn connection.
7.we will get an error "Resource [DataCenter:1] is unreachable: Unable to apply site 2 site VPN configuration, virtual router is not in the right state"
and vpn connection is stuck at Pending
8.When vpc is restarted, go to site-to-site vpn page and reset vpn connection.

Co-authored-by: Rakesh Venkatesh <r.venkatesh@global.leaseweb.com>
2020-10-29 16:20:28 +05:30
Daan Hoogland 2d1989fd76 Merge branch '4.14' 2020-10-29 09:56:32 +01:00
Rakesh 8b994113ff
Failed to update host password if username/password is not saved in db (#4359) 2020-10-29 09:43:05 +01:00
Rakesh b266c757d2
Unable to create snapshot from vm snapshot (#4432)
Co-authored-by: Rakesh Venkatesh <r.venkatesh@global.leaseweb.com>
2020-10-29 08:53:33 +01:00
Rohit Yadav 6de8e012e8 Merge remote-tracking branch 'origin/4.14'
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2020-10-28 15:56:14 +05:30
Wei Zhou dbb66850b2
server: update template to another template type (#3945)
this contains other changes
(1) add isrouting field for vm templates on UI
(2) show register URL of template/iso on UI
(3) set 'Bootable' field to changable for existing ISO
2020-10-28 15:41:36 +05:30
Daan Hoogland c1fb6b4cb9 Merge branch '4.14' 2020-10-28 10:28:10 +01:00
Rakesh e1dd07a30c
Ability to put a server in Down state to maintenance (#4363) 2020-10-28 09:59:43 +01:00
Rakesh b9f15fd159
Remove cpu core from op_host_capacity when host is deleted (#4367)
When a host is put into maintenance mode or its deleted from
cloudstack then delete its entries from op_host_capacity table
2020-10-28 09:41:14 +01:00
nvazquez a831ad1252 Fix detach volume on stopped Vms 2020-10-25 00:33:46 -03:00
nvazquez d119a5d19f Merge branch 'master' into ovfprops-and-vsphere-adv-together 2020-10-24 13:02:31 -03:00
davidjumani 81c524e9f3
Fixing count for findHostsForMigration (#4375) 2020-10-24 13:08:45 +02:00
Gabriel Beims Bräscher f4f35a8995
Enhance UpdateDiskOfferingCmd (#4409) 2020-10-24 13:00:11 +02:00
nvazquez 0c6900e3bd Do not fail if osTypeId parameter or rootdiskcontroller/nicadapter details are set on template registration 2020-10-23 10:39:21 -03:00
Rakesh 71c5dbcf49
server: Update use_bytes of storage pools (#4360)
Update the used_bytes for all default primary storage pools
Also get used_bytes of storage pool from database instead of
memory
2020-10-21 19:18:03 +02:00
Pearl Dsilva 963d603ede
Fix usage record count (#4193)
Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com>
2020-10-21 19:15:34 +02:00
nvazquez 68d51cb333 Remove unused code 2020-10-20 19:57:42 -03:00
nvazquez f1f490b151 Fix restore VM workflow - clone and replace existing VM instead of cloning and moving disks 2020-10-20 19:47:27 -03:00
Wei Zhou 2661ce81d4
server: add global configuration for default router service offering (#3946) 2020-10-20 15:17:00 +02:00
nvazquez 6e6d6d60b7 Fix template registration 2020-10-19 15:05:58 +05:30
davidjumani 6b715ecb53 Throwing error if boot type or boot mode specified while deploying VMs on VMware 2020-10-19 15:05:58 +05:30
nvazquez 950292dcb0 Ensure deploy as is disks get allocated to the same storage pool 2020-10-19 15:05:58 +05:30
Harikrishna Patnala d81f050918 Check storage policy of disk offering if it suitable for storage pool while using migratevirtualmachinewithvolume API 2020-10-19 15:05:58 +05:30
Harikrishna Patnala 5fdabc1cb0 Added storage policy details to disk while creating disk and restricted migration of volumes to storage pools which are not storage policy compliance 2020-10-19 15:05:58 +05:30
Harikrishna Patnala 1e4e5cf4c0 Disk offering response: added vsphere storage policy to response if exists 2020-10-19 15:05:58 +05:30
Harikrishna Patnala a54436b790 service offering response: added vsphere storage policy to response if exists 2020-10-19 15:05:58 +05:30
nvazquez dc4f913afa Fix restrictions on attach and restore VMs 2020-10-19 15:05:57 +05:30
Harikrishna Patnala 3063b6cae5 Fixed import VM for NFS storage which added as presetup.
Previous code assumes the NFS storage is always added by CloudStack, but NFS can also be added as presetup storagepool.
2020-10-19 15:05:57 +05:30
nvazquez d69283a013 Fix reset/restore VM 2020-10-19 15:05:57 +05:30
Harikrishna Patnala 388a9c2c6d Reconcile chaininfo after attaching volume 2020-10-19 15:05:57 +05:30
Harikrishna Patnala 9b923ba9dc Handle detach volume of datastore cluster if the volume name has changed at vCenter level and reconsile the chaininfo 2020-10-19 15:05:57 +05:30
nvazquez 94bebe8792 Revert back deploy as is column on templates but keep it as default for new templates 2020-10-19 15:05:57 +05:30
nvazquez 08c0b07b59 Remove deployasis parameter from register template API 2020-10-19 15:05:57 +05:30
nvazquez 9b51a706db Set deploy-as-is to default on VMware 2020-10-19 15:05:57 +05:30
Harikrishna Patnala 9543fd6e6a Fix startcommand on Datastore cluster when the volume datastore in CloudStack mismatches with vCenter datastore. Volume could have migrated with in datastore cluster which caused the mismatch
Fix dettach volume when volume is not on CloudStack intended datastore
2020-10-19 15:05:57 +05:30
Harikrishna Patnala 1638d7243c Get allocated size for datastoreCluster from its child datastores to show the accumalated value for Datastore cluster 2020-10-19 15:05:57 +05:30
nvazquez 32d85b0fa2 Display storage on logging when not deploy-as-is and guest OS small refactor 2020-10-19 15:05:57 +05:30
nvazquez 41354227e2 Handle guest OS read from deploy-as-is OVF descriptor 2020-10-19 15:05:57 +05:30
nvazquez 0f5a6ee589 Remove deploy as-is details when removing templates or vms 2020-10-19 15:05:57 +05:30
Harikrishna Patnala 33ae2afc89 Removed few duplicate imports during rebase with master 2020-10-19 15:05:57 +05:30
nvazquez f73830acbb Refactor deploy as is constants 2020-10-19 15:05:57 +05:30
nvazquez bb4ce2118d Add new template and vm deploy as is details table and refactor 2020-10-19 15:05:57 +05:30
Harikrishna Patnala bc8ad68434 prepare for maintenance of storage pool of type datastore cluster should not try to cancel the maintenance upon failure, rather keep it in error in maintenance state 2020-10-19 15:05:56 +05:30
nvazquez d864e9dc39 [VMware] Full OVF properties support 2020-10-19 15:05:56 +05:30
Harikrishna Patnala 04d400f055 Handle import unmanaged VM into CloudStack to support any type of datastore 2020-10-19 14:57:16 +05:30
Harikrishna Patnala c11dc337be Set back the datastore cluster state to UP upon on failure in prepare maintenance 2020-10-19 14:57:16 +05:30
Harikrishna Patnala 19745ea049 Fix enable primary datastore maintenance command seriliaztion on it 2020-10-19 14:57:16 +05:30
Harikrishna Patnala 38b9618e4b Fix destination hostname for stopped VMs in case of reset ssh keys 2020-10-19 14:57:16 +05:30
Harikrishna Patnala c16b40e337 Fix list volumes cmd and update volume cmd to accept datastore cluster as storgeid 2020-10-19 14:57:16 +05:30
Harikrishna Patnala d2d9b3c72f Fix proper error message on revert volume snapshot operation in case of any hypervisor other than KVM 2020-10-19 14:57:16 +05:30
Harikrishna Patnala 97ae846c1e Removed unused imports caused due to some merge conflicts 2020-10-19 14:57:16 +05:30
Harikrishna Patnala 85d440d973 Fix list volume response to list datastore cluster name and id instead of child datastore 2020-10-19 14:57:16 +05:30
Harikrishna Patnala d48cab75ab Fix findstoragepoolsformigration cmd not to list the parent datastore cluster as suitable storagepool 2020-10-19 14:57:16 +05:30
Harikrishna Patnala ab171adfdd Handle failure case of putting datastore cluster on maintenance mode 2020-10-19 14:57:16 +05:30
Harikrishna Patnala 70e19b28e6 fix some more test cases 2020-10-19 14:57:16 +05:30
Harikrishna Patnala 48dd0dae07 Adding Storagepolicies to the service offering for root disks 2020-10-19 14:57:16 +05:30
Harikrishna Patnala 1244fca367 Handle listsystemvms cmd in case of datastore clusters 2020-10-19 14:57:16 +05:30
Harikrishna Patnala 61dd85876b Fix migrate vm and volume APIs in case if datastore cluster 2020-10-19 14:57:16 +05:30
Harikrishna Patnala fc05d3168f Fix ListVMsCmd with storageid as datastore cluster 2020-10-19 14:57:16 +05:30
Harikrishna Patnala e700ad72e7 Fix prepare template API incase of Datastore cluster 2020-10-19 14:57:16 +05:30
Harikrishna Patnala 812d42ebaa Fix updateconfiguration API to add settings to child datastores in case of datastore clusters 2020-10-19 14:57:16 +05:30
Harikrishna Patnala 7932f63390 Add checks before actual deletion of datastore cluster 2020-10-19 14:57:16 +05:30
Harikrishna Patnala 4b10c61167 Datastore cluster maintenance failure case handling. 2020-10-19 14:57:16 +05:30
Harikrishna Patnala 873f9dd9ac Datastore Clusters operations on putting into maintenance mode, update storage pool with tags, cancelling mantenance mode and deleting storage pool 2020-10-19 14:57:16 +05:30
Harikrishna Patnala c9c38c0f37 Handle datastore clusters in list storage pools to list only parent not the children in the Datastore cluster 2020-10-19 14:57:15 +05:30
Harikrishna Patnala b4a23ea5f6 Allocation logic to skip datastore cluster and consider only storagepools inside the datastore cluster 2020-10-19 14:57:15 +05:30
Harikrishna Patnala 6df819028e UI changes and accept any type of datastore as presetup in vmware 2020-10-19 14:57:15 +05:30
Harikrishna Patnala 851b562e04 Unit test fix 2020-10-19 14:57:15 +05:30
Harikrishna Patnala 487bb03c4d Added Storagepolicy while creating diskoffering. CreateDiskOffering API now takes storagepolicy as a parameter with UUID value 2020-10-19 14:57:15 +05:30
Harikrishna Patnala fb0a96e7fb Check if datastore is complaince with the storagepolicy provided in the disk offering.
Added corresponding manager objects from PBM sdk to do the job.
Made dao layer changes to read the storage policy in diskoffering
2020-10-19 14:57:15 +05:30
Rodrigo D. Lopez c222d0bf60
enable update tags on disk offerings (#4194) 2020-10-16 09:22:42 +02:00
Gabriel Beims Bräscher 4c936b4690
Re-add affinity group (#4405) 2020-10-16 09:16:19 +02:00
Daan Hoogland 644731edad Merge branch '4.14' 2020-10-15 18:02:00 +00:00
Wei Zhou f7a3701c7a
server: fix issue that vm guest os type is reset after updatetemplate (#4377) 2020-10-15 17:54:59 +00:00
Rakesh 6c88e9afb3
Dont add host back after agent service restart (#4228) 2020-10-14 16:49:39 +00:00
Wei Zhou 2acd87c41e
server: Add global configuration vm.serviceoffering.cpu.cores.max and vm.serviceoffering.ram.size.max (#4379)
vm.serviceoffering.cpu.cores.max and vm.serviceoffering.ram.size.max
2020-10-14 15:48:35 +05:30
Rakesh 2333d97098
plugins: Consider maintenance mode as offline for promethues stats (#4366)
If the resource state of hypervisor in "Maintenance" then it
should be considered as offline even though the agent state
is "Up". Since its in maintenance mode, it cant be used to
allocate VM's and hence can't be considered towards resource
allocation
2020-10-14 15:42:02 +05:30
Daan Hoogland b65282eaa9 Merge branch '4.14' 2020-10-14 10:54:35 +02:00
Gabriel Beims Bräscher 2e32a3a94a
List VMs by Security Group & HA (#4397) 2020-10-14 09:26:47 +02:00
Wei Zhou 94f9f89736
server: Fix some cpuspeed issues while create service offering (#4376) 2020-10-13 11:32:16 +02:00
davidjumani aab8df09aa
Fixing searchAndCount searchAndDistinctCount when sc is null (#4374) 2020-10-13 11:30:04 +02:00
Rohit Yadav b3bafffff3 Merge remote-tracking branch 'origin/4.14' 2020-09-29 14:33:58 +05:30
Wei Zhou 98c51a6d3d
server: check guest os preference of last host when start a vm (#4338)
If vm has last host_id specified, cloudstack will try to start vm on it at first.
However, host tag is checked, but guest os preference is not checked.

for new vm, it will be deployed to the preferred host as we expect.

Fixes: #3554 (comment)
2020-09-29 12:45:29 +05:30
Rohit Yadav 86fcb14238 Merge remote-tracking branch 'origin/4.14'
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2020-09-24 12:20:29 +05:30
Wei Zhou 534dd475d8
agent: Compare indirect agent lb algorithm when cloudstack agent connects (#4335)
Compare not only the list of management servers but also the lb algorithm when agent connects.

Fixes: #3895
2020-09-23 12:48:16 +05:30
davidjumani c06e7ded3c
systemvm: update novnc v1.2.0 (#4323)
Update noVNC v1.2.0, add support for clipboard, explicit button toolbar and resize screensize
2020-09-22 17:42:30 +05:30
Pearl Dsilva 82b6971258
server: Handle listProjects API to list projects with user as members when listAll=true (#4316)
* added defensive checks for avoiding NPE and list projects API fix

* list projects with account name provided to not include users in the account in response

Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com>
2020-09-17 10:20:34 +05:30
davidjumani 44bc134162
Adding acl name to several responses (#4315) 2020-09-17 10:13:14 +05:30
Pearl Dsilva b464fe41c6
server: Secondary Storage Usage Improvements (#4053)
This feature enables the following:
Balanced migration of data objects from source Image store to destination Image store(s)
Complete migration of data
setting an image store to read-only
viewing download progress of templates across all data stores
Related Primate PR: apache/cloudstack-primate#326
2020-09-17 10:12:10 +05:30
Pearl Dsilva f06daa5f8a
Change Global setting type for allow.user.create.projects (#4320)
Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com>
2020-09-15 13:23:54 +05:30
Rakesh 43a25c78f6
Display acl name in listNetworks response (#4317)
* Display acl name in listNetworks response

Display acl name along with its id so that we
dont need to make extra api call to get acl name

* Add since tag
2020-09-11 14:36:20 +02:00
Rohit Yadav c7328652fd Merge remote-tracking branch 'origin/4.14' 2020-09-01 16:02:33 +05:30
Rohit Yadav 578d29e166 Merge remote-tracking branch 'origin/4.13' into 4.14
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2020-09-01 16:01:52 +05:30
Gabriel Beims Bräscher 5c29d5ba45
influxdb: Avoid out of memory by influxDB (#4291)
After a few hours running with InfluxDB configured, CloudStack hangs due to OutOfMemoryException raised. The exception happens at com.cloud.server.StatsCollector.writeBatches(StatsCollector.java:1510):

2020-08-12 21:19:00,972 ERROR [c.c.s.StatsCollector] (StatsCollector-6:ctx-0a4cfe6a) (logid:03a7ba48) Error trying to retrieve host stats
java.lang.OutOfMemoryError: unable to create new native thread
        ...
        at org.influxdb.impl.BatchProcessor.<init>(BatchProcessor.java:294)
        at org.influxdb.impl.BatchProcessor$Builder.build(BatchProcessor.java:201)
        at org.influxdb.impl.InfluxDBImpl.enableBatch(InfluxDBImpl.java:311)
        at com.cloud.server.StatsCollector.writeBatches(StatsCollector.java:1510)
        at com.cloud.server.StatsCollector$AbstractStatsCollector.sendMetricsToInfluxdb(StatsCollector.java:1351)
        at com.cloud.server.StatsCollector$HostCollector.runInContext(StatsCollector.java:522)
Context on InfluxDB Batch: Enabling batch on InfluxDB is great and speeds writing but it requires caution to avoid Zombie threads.

Solution: This happens because the batching feature creates an internal thread pool that needs to be shut down explicitly; therefore, it is important to add: influxDB.close().
2020-09-01 15:59:43 +05:30
Gabriel Beims Bräscher d5acabdbf7
server: Avoid Null pointer at DomainChecker and enhance AssignVMCmd (#4279)
When executing request assignVirtualMachine with null domainID and a valid projectID then a NullPointerException happens at DomainChecker.java.

Command example:

assign virtualmachine virtualmachineid=vmID projectid=projectID account=admin
The NullPointerException that is thrown at DomainChecker is handled at AssignVMCmd.java#L142, resulting in the following log message: Failed to move vm null.
2020-09-01 13:58:42 +05:30
Wei Zhou 4746c8c726
server: move UpdateDefaultNic to vm work job queue (#4020)
While remove secondary nic from a Running vm, if update the default nic to the secondary nic before the nic is removed, the vm will not have default nic (and cannot be started) when both operations are completed.

It is because UpdateDefaultNic api is not handled as a vm work job (AddNicToVMCmd and RemoveNicFromVMCmd are), it is processed before nic is removed. The result is that secondary nic becomes default nic and got removed.
2020-09-01 13:54:48 +05:30
Rohit Yadav 749e302e0e Merge remote-tracking branch 'origin/4.14' 2020-08-28 15:00:18 +05:30
Rakesh 3b4a8fcbfd
api: List networks using networkofferingid (#4258)
Add extra parameter for listNetworks command to list
all networks using networkofferingid
2020-08-28 14:55:54 +05:30