Commit Graph

5557 Commits

Author SHA1 Message Date
Alena Prokharchyk d0dac13787 CS-15304: VR deployment - release the lock for the network once the router entry is allocated (2.2.x behavior) as opposed to releasing it when the router start is completed
Reviewed-by: Frank Zhang
2012-08-20 16:05:22 -07:00
Edison Su ef02d1ae87 add recreate.systemvm.enabled parameter to control recreating systemvm 2012-08-20 11:10:28 -07:00
Murali Reddy b9a6e60ea9 bug CS-16068: Restart Guestnetwork which has netscaler failed
On restart network with out clean-up option, no need to re-implement the network on then backend NetScaler device.
2012-08-20 19:40:56 +05:30
Abhinandan Prateek 953d0b7c0b bug CS-16031: marking older snapshots removed in db 2012-08-20 13:25:27 +05:30
Alena Prokharchyk d158b38007 More logging to lock operations on the network 2012-08-17 16:27:32 -07:00
Vijayendra Bhamidipati 0cf0523afe CS-16042: 3.0.x to 3.0.5 Upgrade: VMWare : Upgrade Procedure for using the new Burbank System Template in place of Acton System Template Required
Description:

    Modifying reference to system VM template for vmware for the
    2.2.14 to 3.0 upgrade path so that it picks up the burbank
    template if upgrading from 2.2.14 to 3.0.5 or beyond, and
    the acton template if upgrading from 2.2.14 to 3.0.[0-4].
2012-08-17 15:59:35 -07:00
Edison Su d6092380cd HA worker thread needs to have its own worker thread configuration 2012-08-17 12:54:02 -07:00
Vijayendra Bhamidipati 4d7c6f43ac CS-16042: 3.0.x to 3.0.5 Upgrade: VMWare : Upgrade Procedure for using the new Burbank System Template in place of Acton System Template Required
Description:

    Updating system VM template for vmware for 3.0.5.
2012-08-17 12:24:27 -07:00
Sheng Yang f1c77e84dd CS-16060: Firewall service should be excluded from conserve mode checking 2012-08-17 10:56:01 -07:00
Vijay 623f3b26ca CS-15830. If autoscale vm group creation is attempted on a unimplemented
network an error is thrown.
Enhancing the check to make sure AutoScaleVmGroup should have atleast 1
min member.
2012-08-17 20:42:09 +05:30
Deepak Garg ad6ac9b449 CS-15617. Changed CounterResponse to a List as queryAsyncJob expects it.
reviewed by: Nitin
2012-08-17 17:43:50 +05:30
Vijay f2aeb9351f CS-15927 : Able to add autoscale VMs to static LB rule
First Part: AutoScale Vms are named as "AutoScale-LB-<lbname>"
    This could be used by UI and have filter mechanism to not display
    autoscale vms during the "Add Vms" dialog for a non autoscaled
    lb rule.
2012-08-17 17:20:21 +05:30
Likitha Shetty 5b9224f290 CS-16041. Not able to deploy Vms using base64 encoded userdata.
Relaxed the validation applied on userdata.
Reviewed by: Prachi
2012-08-17 11:48:50 +05:30
Alena Prokharchyk 01f33deca0 Fixed regression in GuestNetworkGuru - get networkId from the network object passed to the method call instead of retrieving it from tne NicProfile when it wasn't set yet 2012-08-16 15:46:48 -07:00
Sheng Yang e3e5f1bb74 CS-16043: Using network based router rather than account for RVR detection 2012-08-16 15:33:39 -07:00
Alena Prokharchyk 44fd5108f3 CS-15999: added nics to domain router api response 2012-08-16 10:45:23 -07:00
Alena Prokharchyk 9b5819bef2 CS-16030: set UUID when persist public ip address 2012-08-16 10:12:24 -07:00
Abhinandan Prateek 3a0905b280 bug cs-15946: added vpc.max.networks for a integer validation 2012-08-16 18:04:39 +05:30
kishan 02a8ee911d bug CS-15878: created network usage rules after ipassoc during reboot
status CS-15878: resolved fixed
2012-08-16 17:38:20 +05:30
Nitin Mehta d1fd10fc43 bug CS-15278: Download Volume fails in case of Multiple Secondary Storages. Correcting it to use the same secondary storage to copy the volume and creating the soft link
Reviewed-by: Kishan
2012-08-16 15:40:56 +05:30
Jayapal d55021e82f Merge branch '3.0.x' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 3.0.x 2012-08-16 14:27:22 +05:30
Jayapal 1376a9e762 Bug CS-15862: assigning diff ip to VR
reviewed-by: alena
2012-08-16 14:22:27 +05:30
Prachi Damle 68c1fe0899 CS-16022: If host connection fails due to some DB error, host disconnect does not happen and mgmt_server_id is not removed.
Making sure host disconnect is called.
2012-08-15 18:13:13 -07:00
Sheng Yang eaddb44c8a CS-14253: Apply IP when firewall rule is in place 2012-08-15 15:08:17 -07:00
Sheng Yang 17941d9d64 Revert "bug 14484: Apply existed firewall rules when associating IP"
This reverts commit d80b58fe1d.
2012-08-15 15:08:17 -07:00
Alena Prokharchyk 5acc99c774 Fixed unittest for VPC - added missing implementation for some methods in Mock classes used by the test 2012-08-14 13:49:40 -07:00
Vijay d9b843ed9d CS-15938. Support for multiple guest networks with autoscale
The loadbalancers network and the VM's network are the same.
Hence not getting the input from user and passing the loadbalancers network
for the AutoScale VMs (for advanced network).
2012-08-14 16:34:29 +05:30
Vijayendra Bhamidipati 31118d91a3 Merge branch '3.0.x' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 3.0.x 2012-08-13 17:59:09 -07:00
Vijayendra Bhamidipati 93a0989167 CS-15569: InterVlan - ApiDispatcher reports wrong Information as the reason for Failure. Public IP Addresses unrelated to the Guest VM are mentioned to be associated with the VM.
Description:

    Fixing misleading error message in exception.
2012-08-13 17:58:17 -07:00
Anthony Xu 6315b5ad41 CS-15922 : to avoid race condition when expunge vm, expunge interval and expunge deplay should be larger than 600 second 2012-08-13 17:41:21 -07:00
Alena Prokharchyk 4116ac876f VPC: CS-15805 - guest cidr should be RFC1918 complient 2012-08-13 17:08:39 -07:00
Alena Prokharchyk 3ef9f27c66 VPC: CS-15925 - when vpc provider is speficied for a new network offering, no other providers can be used 2012-08-13 13:58:16 -07:00
Alena Prokharchyk a82ff7b0d1 VPC: CS-15968 - don't send ips in Releasing state to the router when the nic is already unplugged for this Vlan 2012-08-13 11:42:29 -07:00
Koushik Das 7e681a701c CS-15908 : LDV: Prevent attach local data volume to a VM created in a zone with local storage disabled
Following scenarios are not allowed in case local storage is disabled on zone:
-Creation of volume (new or from snapshot) with local disk offering.
-Attach/reattach of volume with local disk offering.

Reviewed-by: Nitin
2012-08-13 17:11:26 +05:30
Murali Reddy 9862378ed5 bug CS-15232: After upgrade 2.2.14 -> Bonita CloudStack-tag-3.0.3-prerelease3-3.0.3-0.2592-rhel5 with external devices F5-SRX, Unable to acquire IP in original network of F5SRX devices
ensuring that networks using external load balancer/firewall in 2.2.14 or prior releases deployments has entry
  in network_external_lb_device_map and network_external_firewall_device_map
2012-08-12 18:48:38 +05:30
Fang Wang 90d0871131 bugCS-15741
InterVlan - User VM's ID should not be revealed in the Error message displayed to the Regular User Account - Error during Static NAT Rule creation.
Description:
	Use the UUID to replace the vmId in the exception message.
2012-08-10 19:53:13 -07:00
Alena Prokharchyk e866122ff8 Fixed line endings in RulesManagerimpl file 2012-08-10 16:33:34 -07:00
Sheng Yang 8f8d92ad08 S2S VPN: CS-15947: Add global config for S2S VPN VPN connection counts limitation
And subnets limitation for each customer gateway
2012-08-10 16:15:39 -07:00
Alena Prokharchyk 029a07fad4 VPC: CS-15950 - throw networkConflictException when try to create network rule for the ip address that is already in use for another service 2012-08-10 16:04:18 -07:00
Sheng Yang 0bbefcecff S2S VPN: CS-15932: Allow user to update customer gateway when connection state is ERROR 2012-08-10 11:56:45 -07:00
Sheng Yang 727d0d60f4 S2S VPN: CS-15936: Prevent user from connecting to different customer gateway with overlapped subnets 2012-08-10 11:30:06 -07:00
Abhinandan Prateek eb1c94feba bug CS-15868: enable tampa pre-release 2012-08-10 19:18:17 +05:30
Koushik Das cae5db1722 CS-15603 : CloudStack failing to stop vm's when destroyVM is called
When a VM is force deleted and the host is not available then CS simply marks the state in db as "Destroyed/Expunging". The VM is still running on the host and once it becomes available again there is a discrepancy in state of the VM. In this scenario the VM is removed from the host when the next full cluster sync happens.

Reviewed-by: Abhi
2012-08-10 17:54:57 +05:30
Nitin Mehta 3aa0e9a352 bug CS-15278: For removing clusters crossing threshold find out the list of cluster through db instead of iteratting cluster one by one in the java code.
Reviewed-by: Koushik
2012-08-10 16:15:25 +05:30
Vijay 0bd667418e CS-15931 Delete Vm group not removing configs from NS.
CS-15935 NetScaler sessions increase in case of errors in the NetScaler
CS-15930 Save config not triggered to NS after create, update delete VM group
CS-15934 Handling Resource Unavailable exception for AutoScale
2012-08-10 13:45:23 +05:30
Abhinandan Prateek b82fddd629 bug CS-15919: added details parameter value can be a comma separated list of [all, vm, account, storage_type, disk_offering, min] 2012-08-10 10:28:25 +05:30
Koushik Das 20ba086d99 Fix CS-15910
In case of volume creation from snapshot there is no associated VM so put a check for that.
Reviewed-by: Nitin
2012-08-09 19:32:39 +05:30
Alena Prokharchyk 601ca8c5eb Fixed unittest 2012-08-08 18:58:50 -07:00
Alena Prokharchyk 4739ac0ae3 Reverted "Initialize user context from AccountManager" committed by mistake
This reverts commit cc212aaecf.
2012-08-08 15:25:31 -07:00
Alena Prokharchyk d31449f1c0 Name change for vpc/Dao package (dao is lowercased now)
Conflicts:

	api/src/com/cloud/vm/PluggableNics.java
	server/src/com/cloud/configuration/DefaultComponentLibrary.java
	server/src/com/cloud/network/dao/RouterNetworkDaoImpl.java
	server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java
	server/src/com/cloud/network/vpc/dao/PrivateIpDao.java
	server/src/com/cloud/network/vpc/dao/PrivateIpDaoImpl.java
	server/src/com/cloud/network/vpc/dao/StaticRouteDao.java
	server/src/com/cloud/network/vpc/dao/StaticRouteDaoImpl.java
	server/src/com/cloud/network/vpc/dao/VpcDao.java
	server/src/com/cloud/network/vpc/dao/VpcDaoImpl.java
	server/src/com/cloud/network/vpc/dao/VpcGatewayDao.java
	server/src/com/cloud/network/vpc/dao/VpcGatewayDaoImpl.java
	server/src/com/cloud/network/vpc/dao/VpcOfferingDao.java
	server/src/com/cloud/network/vpc/dao/VpcOfferingDaoImpl.java
	server/src/com/cloud/network/vpc/dao/VpcOfferingServiceMapDao.java
	server/src/com/cloud/network/vpc/dao/VpcOfferingServiceMapDaoImpl.java
2012-08-08 15:02:46 -07:00
Alena Prokharchyk cc212aaecf Initialize user context from AccountManager 2012-08-08 14:52:40 -07:00
Sheng Yang 685af150bc S2S VPN: Use coma instead of semicolon for separating cidr list 2012-08-08 10:37:26 -07:00
Deepak Garg 211b60ef64 CS-15644 Implemented UUIDs for templateId, serviceOfferingId, zoneId, domainId replacing the ids being passed to
Netscaler in the API url

Reviewed By: Vijay V.
2012-08-08 18:17:38 +05:30
Vijay b10274efd9 CS-15866. Packaging AutoScale Vm Group as part of delete
load balancer rule.
ReviewedBy: Devdeep Singh
2012-08-08 17:44:28 +05:30
Koushik Das a9c7ae2934 Fix CS-15621
Using migrateVolumes method which does not perform input validation. Some input validation in the migrateVolume method prevented migration of volume in READY state. Also using volume disk offering to check if it is a local or shared one.

Reviewed-by: Nitin
2012-08-08 16:53:38 +05:30
kishan f57b242e1f bug CS-15648: For volumes created from snapshot, create usage event after successful volume
status CS-15648: resolved fixed
reviewed-by: Nitin
2012-08-08 16:21:15 +05:30
kishan 23aa4bff69 bug CS-15221: Support multiple public interfaces 2012-08-08 13:42:14 +05:30
Sheng Yang 9898495974 S2S VPN: Fix multiply remote side guest networks 2012-08-07 18:34:41 -07:00
Prachi Damle e59a2f2ef6 CS-14817 Intergrating External network service provider using pluggable interface - issue with CreateNetwork and UpdateNetwork
Changes:
- While checking if network has any external provider, we should consider all providers in the network. Not just F5, Juniper, Netscalar
2012-08-07 18:01:39 -07:00
Sheng Yang a7342974b3 S2S VPN: Fix typo 2012-08-07 16:26:06 -07:00
Sheng Yang 20f4b6a386 CS-15243: Add service combination check at create network offering 2012-08-07 12:52:59 -07:00
Sheng Yang acd9f4887f S2S VPN: CS-15882: Only allow VPN connection between same account's gateways 2012-08-07 11:51:14 -07:00
Alena Prokharchyk 1cf91a8397 VPC: more unittests for VpcService 2012-08-07 11:01:43 -07:00
Jayapal 3455305f69 Fix: CS-15398 fix for basic zone dns issue in multiple pods 2012-08-07 16:16:24 +05:30
Likitha Shetty 0dd17697bb CS-14796. deployVirtualMachine api, added a check to see if the userdata provided is base64 encoded.
Reviewed by: Prachi
2012-08-07 14:18:21 +05:30
Alena Prokharchyk 44ae760257 VPC: CS-15850 - don't unplug the nic for public network when there are existing ips in the same vlan having network rules 2012-08-06 17:37:16 -07:00
Alena Prokharchyk 08a1e93462 VPC: CS-15850 - don't unplug the nic for public network when there are existing ips in the same vlan having network rules 2012-08-06 16:31:32 -07:00
Alena Prokharchyk ddb9e498f7 VPC: unittest preparation 2012-08-06 16:31:32 -07:00
Rajesh Battala 9317c888d6 CS-15778: Fetching thumbnail 2012-08-06 20:47:22 +05:30
Rajesh Battala 96826e5218 CS-15778: Fetching thumbnail 2012-08-06 20:31:00 +05:30
Koushik Das f772c9aa99 Fix CS-15835
Using the disk offering associated with volume to determine the storage type
Reviewed-by: Nitin
2012-08-06 18:51:35 +05:30
Abhinandan Prateek 4146b4273d bug CS-15859: put a check on volume limit 2012-08-06 17:50:29 +05:30
Koushik Das 32c577ef7d Fix CS-15834
Added storage type in list disk offerings response
Reviewed-by: Abhi, Nitin
2012-08-06 15:24:01 +05:30
kishan b87800c159 bug CS-15852: Added VPN network usage. Uses vpn mark 0x525 to match VPN packets 2012-08-06 03:19:58 +05:30
kishan f3536fecc1 bug CS-15577: corrected regular router usage changes due to VPC usage addition 2012-08-05 23:51:09 +05:30
Rajesh Battala ed6cd4f77e CS-15779 - fixed composeThumbnailurl to send thumbnail request to ConsoleProxyAjaxImage Handler 2012-08-04 17:57:34 +05:30
Sheng Yang 7779097653 S2S VPN: CS-15642: Re-initiate the VPN connections after router reboot 2012-08-03 15:37:34 -07:00
Alena Prokharchyk da9bd84e09 VPC: more validation for static route rules: 1) Can't belong to guest cidr defined on Vpc 2) Can't belong to link local cidr 2012-08-03 15:32:27 -07:00
Alena Prokharchyk 0b2b021f18 VPC: CS-15812 - fixed listVPCs by projectId 2012-08-03 14:08:26 -07:00
Vijayendra Bhamidipati 6dc833c771 CS-15217: Security: Malicious user is able to get the size of the cloud by enumerating IDs
Description:

	Missed throwing exceptions at few places when making
	changes previously. Commit includes whitespace corrections.
2012-08-03 13:24:18 -07:00
Alena Prokharchyk a25cf5e08f VPC: CS-15827 - register only VpcVirtualNetworkApplianceMgr 2012-08-03 11:47:50 -07:00
Nitin Mehta a82ad3b3bc bug CS-15200: Introducing state transition when volume is getting copied from secondary storage and it is put into Creating state
Reviewed-by: Kishan
2012-08-03 16:15:22 +05:30
Murali Reddy f837a0431d bug CS-15817 system VM's fail to create in basic zone with EIP/ELB network offering
removing the ActionEvent annotation on associate IP, acuquire IP methods
on internal methods, so that static NAT for system VM succeeds
2012-08-03 08:54:35 +05:30
Alena Prokharchyk 2cca73daef VPC: applyStaticRoutes - don't exclude static routes in Revoke state 2012-08-02 18:42:35 -07:00
Sheng Yang 263ae86311 S2S VPN: CS-15820: Remove account information of vpn gateway and vpn connection
The owner would be always same as VPC owner.
2012-08-02 18:01:58 -07:00
Sheng Yang d4ce07779f S2S VPN: Allow name to be modified in updateCustomerGateway 2012-08-02 18:01:58 -07:00
Sheng Yang 0f603daff6 S2S VPN: CS-15472: Separate IKE lifetime and ESP lifetime 2012-08-02 18:01:58 -07:00
Alena Prokharchyk 863bce0171 VPC: createPrivateGateway - added cleanup part happening in case when the gateway fails to be applied on the backend 2012-08-02 17:57:43 -07:00
Alena Prokharchyk 967ff1141b VPC: CS-15818 - don't allow having ICMP networkACLs with the same cidr and icmpType=-1 for rule1 and icmpType!=-1 for rule 2 as the rule1 covers rule2 in this case 2012-08-02 17:06:31 -07:00
prachi 102a563cdd CS-12510: Deleting the host_details and inserting them back causes deadlocks.
Changes:
- 3.0.4 release has a patch where a unique key is added on host_details.
- But this key is not present in 3.0.4 GA
- So 3.0.5 upgrade has to consider both cases and add the key only if it does not exist in the 3.0.4 version.
2012-08-02 16:16:26 -07:00
Alena Prokharchyk b526affe01 Revert "CS-15398: Fix for dns issue in multiple pods"
This reverts commit dd4e19c16f.
2012-08-02 15:53:31 -07:00
Alena Prokharchyk b05e6ba959 listVirtualMachines: implemented search by templateId/isoId 2012-08-02 15:40:20 -07:00
Alena Prokharchyk a3b00a7535 VPC: CS-15821 - corrected mac address format for vpc private network 2012-08-02 14:52:04 -07:00
Murali Reddy f64a52a3f9 bug CS-15654 Restarting guest network fails with exception
in basic zone when NetScaler is providing EIP and ELB services, NetscalerElement should
 have no action to take on implement and shutdown of the network
2012-08-02 18:51:42 +05:30
kishan 8c53b79cfe bug CS-15577: Added per gateway network usage for VPC 2012-08-02 17:14:57 +05:30
Vijay d027a0f705 CS-15781. AutoScale.
During update of Autoscale VM Group, the interval is
checked for validity against existing policies in the group as well.
2012-08-02 14:22:15 +05:30
Jayapal dd4e19c16f CS-15398: Fix for dns issue in multiple pods 2012-08-02 12:40:39 +05:30
Alena Prokharchyk 3e9eea42f0 VPC: CS-15813 - ICMP type and code validation 2012-08-01 19:49:45 -07:00
Alena Prokharchyk f47d3f7b59 VPC: CS-15805 - verify vpc guest network cidr only against networks in the same vpc 2012-08-01 17:59:36 -07:00
Alena Prokharchyk 41655c0395 VPC: CS-15811 - removed Netscaler from the list of supported providers in VPC 2012-08-01 16:47:05 -07:00