Commit Graph

7303 Commits

Author SHA1 Message Date
Min Chen 2bbf63bc7a CLOUDSTACK-3513: ListIsos/ListTemplates does not return correct results
when id and zoneid are passed.
2013-07-20 15:16:49 -07:00
Harikrishna Patnala f604e3d9cc CLOUDSTACK-3365: cluster level parameters cluster.(cpu/memory).allocated.capacity.notificationthreshold is not considering overcommit value 2013-07-20 17:03:05 +05:30
Edison Su e659328ff5 fix create template from snapshot if it's swift 2013-07-19 18:18:02 -07:00
frank a5ee39a54a CLOUDSTACK-3453
UCS:API: List Blades after decommissioning a blade, listUcsBlades API returns wrong number of total blades

fixed resolved
2013-07-19 16:15:46 -07:00
Fang Wang 2b254186b2 CLOUDSTACK-732 Add disk snapshot for KVM 6.3, add the flag in CS.
Signed-off-by: Edison Su <sudison@gmail.com>
2013-07-19 13:22:26 -07:00
Alena Prokharchyk 242f46118b InternalLb: fixed creation for default network offering with internal lb support - public lb support should be disbaled on it
Conflicts:
	engine/schema/src/com/cloud/offerings/NetworkOfferingVO.java
2013-07-19 13:20:46 -07:00
Murali Reddy 2b82c3e1db CLOUDSTACK-3642: [Usage][PortableIP] CS is not generating usage events
for portable IPs

generating usage events for acquire/release of portable IP
2013-07-19 18:42:52 +05:30
Murali Reddy 75af53be6f CLOUDSTACK-3640: [Usage][GSLB] usage events are not generated for GSLB
geneating usage events for create/delete of GSLB rule
2013-07-19 18:29:05 +05:30
Sanjay Tripathi a98c0f5b89 CLOUDSTACK-3496: [Regression]Primary Storage resource usage is not getting updated if detached volume is deleted 2013-07-19 16:19:41 +05:30
Sanjay Tripathi 5de96db81d CLOUDSTACK-3492: [Regression]Update Resource Count for an account is updating the primary storage incorretly.
The issue is that while calculating the used primary storage size, the updateResourceCount
API is also calculating the disk size of virtual router VM, created for that account and
because of this, the API is returning the incorrect result.
2013-07-19 16:19:23 +05:30
Harikrishna Patnala 12c711cef7 CLOUDSTACK-3358: create template from a volume/snapshot should also take input from User/Admin whether xstools / vmware tools installed in the VM
Signed off by : Nitin Mehta<nitin.mehta@citrix.com>
2013-07-19 11:54:36 +05:30
Mike Tutkowski 8f1799b71f Changes related to Review Board comments 2013-07-18 19:46:42 -06:00
Min Chen c236645d9a CLOUDSTACK-3498:[Object_Store_Refactor] Deleting and adding back the
zone does not create NFS Cache store and Failure in Sytem VMs Start Up
2013-07-18 16:28:56 -07:00
Min Chen 251efff69c CLOUDSTACK-3513: add debug message to diagnose copyIso issue on
automation setup where DownloadCommand is never sent.
2013-07-18 16:01:55 -07:00
Prachi Damle 3fc43cf281 CLOUDSTACK-3451 Parallel deployment - Xenserver - When deploying 30 Vms in parallel, some of the Vm deployment fails when “applying dhcp entry/applying userdata and password entry on router” and retry eventually happens when they succeed.
Changes:
- Passing the avoid set generated by the first pass of deployment to the second try.
- The second try is done, when the first pass that uses a reserved plan fails to deploy on the reserved host, to search over the entire zone again
2013-07-18 15:57:13 -07:00
Min Chen 9a1cd1ac53 ListIsos only shows cross-zone ISO in one zone. 2013-07-18 10:55:02 -07:00
Prasanna Santhanam fbf38a35d2 CLOUDSTACK-3633: AffinityGroupResponse does not include uuid
The uuid->id of the affinity group created is not included as part of
the response. Included the uuid.

Signed-off-by: Prasanna Santhanam <tsp@apache.org>
2013-07-18 18:13:58 +05:30
Sanjay Tripathi c9548e3788 CLOUDSTACK-3376: NPE: resource count calculation from the account manager on account cleanup
This issue is happing because of the steps the code follow to cleanup the account.
The cleanupAccount was deleting the entries from the resource_limit and
resource_count table and performing further cleaning afterwards. Ideally, deletion
of entries from resourceLimit and resourceCount should be the last step in
cleanupAccount process.

Signed-off-by: Prasanna Santhanam <tsp@apache.org>
(cherry picked from commit 21b1c9449a)
2013-07-18 15:08:44 +05:30
Harikrishna Patnala f1a6de5eed CLOUDSTACK-3551: scaling up VM to service offering with 2gbram
Fixed the type overflow of Ram value.
Signed off by : Nitin Mehta<nitin.mehta@citrix.com>
2013-07-18 11:42:03 +05:30
Min Chen c443115a48 CLOUDSTACK-3513: [Automation] Failed to copy iso and template between
zones.
2013-07-17 17:24:23 -07:00
Saksham Srivastava 1933960dda CLOUDSTACK-3476:deleteDomain api should fail when release dedicated resource to that domain fails 2013-07-17 11:18:24 -07:00
Bharat Kumar 779bfd460b Fixed the conditon which checks for the provider's capabilty and reapply ipaliases on virtual router restart.
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2013-07-17 17:31:34 +05:30
Bharat Kumar 956a2a68ce Incorportaed the review changes Now dhcpservice IPs are removed when last vm from the subnet is removed.
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2013-07-17 16:53:11 +05:30
Bharat Kumar 4fdb177bb6 Cloudstack-2150 DB table entries of phisical network is not proper.Shows Duplicate entries Cloudstack-2980 Adding a VLAN range that overlaps with two existing ranges results in inconsistent DB entries
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2013-07-17 15:10:52 +05:30
Bharat Kumar 664d479f8f Cloudstack-3313 Cannot deploy vm in ipv6 network
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2013-07-17 10:07:57 +05:30
Edison Su ba4c4400b5 be able to upload template into swift 2013-07-16 18:05:01 -07:00
Sheng Yang 882982605a CLOUDSTACK-494: Loose the limition of same ip used by site-to-site vpn
Different account can have same remote side IP now. Of course the remote side need
to identify them and configured properly to handle it.
2013-07-16 17:16:58 -07:00
Vijayendra Bhamidipati e18ca0117d CLOUDSTACK-3514: [Automation] Vmware - Failed to download default template for first zone
Description:

    Fixing reference to null object.
2013-07-16 16:14:10 -07:00
Sheng Yang 13c1c6291c CLOUDSTACK-1670: Fix the order of user vm's multiple nics
They should follow the order of networkIds parameter of deployVMCmd(). And eth0
would be always on default network.
2013-07-16 16:07:05 -07:00
Prachi Damle 9a9d277884 CLOUDSTACK-2159 Anti-Affinity - When "HostAntiAffinityProcessor" plugin is not included in the deployment , deployVirtualMachine() command does not error out when passing the affiitygroupnames parameter.
Changes:
- Added a check during vm deployment to see if a processor for the affinity group type is available
2013-07-16 15:23:08 -07:00
Prachi Damle d70076e6a5 CLOUDSTACK-2155: Anti-Affinity -When Vm deployment is done in parallel , anti-affinity rule is not honored.
Changes:
- Locking the group and save reservation mechanism done by DPM
- Added admin operation to cleanup VM reservations
- DPM will also cleanup VM reservations on startup
2013-07-16 13:41:16 -07:00
Prachi Damle 9cb91ba58c CLOUDSTACK-2155 Anti-Affinity -When Vm deployment is done in parallel , anti-affinity rule is not honored.
Changes to check if the destination found does not conflict with any vm reservation
2013-07-16 13:41:12 -07:00
Likitha Shetty e15876944b CLOUDSTACK-3293. DeleteAccount fails with ConstraintViolation on snapshot_store_ref. 2013-07-16 14:36:57 +05:30
Likitha Shetty 4c924bb83d Revert "CLOUDSTACK-3293. DeleteAccount fails with ConstraintViolation on snapshot_store_ref."
This reverts commit d0955663cf.
2013-07-16 14:09:43 +05:30
Likitha Shetty d0955663cf CLOUDSTACK-3293. DeleteAccount fails with ConstraintViolation on snapshot_store_ref. 2013-07-16 13:42:27 +05:30
Devdeep Singh c59c736f98 CLOUDSTACK-3545: NPE in listStoragePoolsForMigration api. The volume table no longer holds
the pod id, the column is null now. Made a change to get the pod id from the storage pool
on which the volume resides.
2013-07-16 12:04:36 +05:30
Sheng Yang 2f85c80655 CLOUDSTACK-3539: Fix wrong management ip when server start up
The value "localhost" for mgmt server should be over-written anyway.
2013-07-15 18:26:41 -07:00
Min Chen dabedd0848 CLOUDSTACK-2595: [Automation] Failed download default template for
second zone. Actually it is a listTemplate issue.
2013-07-15 17:36:42 -07:00
Alena Prokharchyk 48e030589e CLOUDSTACK-3346: Fixed setting up resourceTags for network ACL - added missing @Inject when load NetworkACLItemDao 2013-07-15 10:19:55 -07:00
Murali Reddy 5e0a61d57c CLOUDSTACK-2960: [portableIPrange] CS should check the portable ip range, vlan with
existing public ip ranges and vlans

adds a validation check to ensure there is no VLAN in the zones with
same id
2013-07-15 16:17:47 +05:30
Murali Reddy feeffeaf10 CLOUDSTACK-3463: [Portable IP] [EIP/ELB Zone] EIP semantics are not
intact with portable IP

fix ensures that, on release of portable IP associated with 'EIP
enabled' basic zone vm, a new system public IP is allocated and
associated with the VM
2013-07-15 09:50:41 +05:30
Murali Reddy 8de3b4f461 CLOUDSTACK-3444: Unable to transfer portalbe IP between ISOLATED network and VPC
Tiered Network

When portable IP is transferred across the zones, we emulate portable IP
as provisioned in new zone's physical network carrying public traffic
and logical public network. network Id, and physical network id both
were bieng set to same physical network id resulting in IP association
to fail. This fix ensures both network and physcial network are set
appropriatley.
2013-07-15 09:04:24 +05:30
Edison Su 7e6c1a0bf7 CLOUDSTACK-3400: add swift support 2013-07-13 01:52:03 -07:00
Edison Su c888fc6b75 add inital swift support 2013-07-13 01:52:03 -07:00
Vijayendra Bhamidipati 8439209ba6 CLOUDSTACK-3509: Put in missing code to kick off non root volume resize operations in vmware deployments
Description:

    Include vmware in list of hypervisors supporting volume resize.
2013-07-12 15:21:52 -07:00
Vijayendra Bhamidipati cb96d70967 CLOUDSTACK-3264: [ZWPS]NPE while finding storage pools for migration
Description:

    Filter primary storage pools based on zonewide/clusterwide configuration
    when considering pools to list for storage migration of volumes.
2013-07-12 15:21:40 -07:00
Mike Tutkowski 13ec10caa6 Changes related to Review Board comments
Changes related to Review Board comments
2013-07-12 14:26:11 -06:00
Hugo Trippaers 55c0616d90 CLOUDSTACK-728 Get the framework in place the support the removal of the portgroup that is created for a nic connected to an lswitch.
Add a command to tell a hypervisor guru to take some action when
expunging a nic
2013-07-12 14:23:13 +02:00
Harikrishna Patnala 8816d41d3b CLOUDSTACK-2987: Fixing dynamicallyScalable flag in register and update template API Previuos commit: 7b6b8d7a07 This fix is due to some changes made by the merges after this commit.
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2013-07-12 15:27:25 +05:30
Wei Zhou b3ac91ef63 CLOUDSTACK-3368: clear download URLs when create SSVM and validate download URLs 2013-07-12 10:43:49 +02:00
Wei Zhou 838cfa2bb6 CLOUDSTACK-3362: use POST instead of GET and encode/decode cert/key in uploadCustomCertificate 2013-07-12 10:43:38 +02:00
Murali Reddy f3a2fc22bf CLOUDSTACK-3485: NPE while getting instance ID from Asyn Job when
publishing async job events on eventbus

handing case where instance id is null in the asyn job, while publishing
asyn job events on to event bus
2013-07-12 13:57:53 +05:30
Saksham Srivastava 87a2a95445 CLOUDSTACK-3094: Adding a shared network to already deployed VM is failing.
Signed-off-by: Mice Xia <mice_xia@tcloudcomputing.com>
2013-07-12 14:30:40 +08:00
Alena Prokharchyk 52d3e1190f CLOUDSTACK-2843: added CopyCommand to the list of the commands controlled by execute.in.sequence.hypervisor.commands global config. This command was introduced by the Storage refactoring, and used for volume creation on the primary storage 2013-07-11 17:43:33 -07:00
ahuang a4f729759a Added the git commit and branch to war file 2013-07-11 17:37:36 -07:00
Min Chen 45cf96afb7 CLOUDSTACK-3335:[Object_Store_Refactor][Automation]CopyTemplate failed
with Unexpected exception.
2013-07-11 16:01:42 -07:00
Alena Prokharchyk cce2dad2e4 CLOUDSTACK-3458: network GC thread - acquire global lock to prevent multiple MS from running the GC thread on the network at the same time 2013-07-11 09:37:39 -07:00
Daan Hoogland f99d599930 CLOUDSTACK-3357: dnsmasq on vpc-routervm 2013-07-11 14:34:51 +01:00
Murali Reddy 0c97cd271a CLOUDSTACK-1673: AWS Regions - Events - User disable / Domain Delete event does not
include the UUID of the user/domain that was disabled.

- added enity type and enity UUID details to UserContext
- publish the entity type and UUID details for the action events
  generated  for accout/user/domain
2013-07-11 17:53:13 +05:30
Koushik Das c076ae875a CLOUDSTACK-3248: XenServer Host got removed successfully inspite of running VMs on the host
In UI there is a restriction to first put a host in maintenance and only then deletion is allowed. But there is no such restriction in the deleteHost API.
Added a validation in deleteHost API to prevent deletion if the host is not in maintenance. In case of a forced deletion the restriction doesn't apply.
2013-07-11 17:33:41 +05:30
Sanjay Tripathi 5dda98c3a0 CLOUDSTACK-1768: Ability to delete Events and Alerts: Delete by a time period is required.
User should be able to delete/archive alerts and events by selecting a time period or by
choosing the alerts and events older than a date. Added the ability to choose a time period
too.
2013-07-11 14:28:51 +05:30
Likitha Shetty a5e1e40fff CLOUDSTACK-3447. CLOUDSTACK-3448.
Correct the access check on networks in APIs addNicToVM and removeNicFromVM
2013-07-11 13:48:55 +05:30
Wei Zhou ca8b47778f CLOUDSTACK-3244: Inject KeystoreManager in ManagementServerImpl 2013-07-11 09:57:06 +02:00
Koushik Das c4e3213132 CLOUDSTACK-3441: [Load Test] High delays between VM being allocated to Pod and network implementation causing delays in VM deployment
This is a regresion caused due to fix for CLOUDSTACK-70. In order to fix network restart scenario, delays got introduced in the user VM deployment scenario.
Fixed it by separating out the network restart and new VM deployment scenario such that the latter is not affected due to the fix for CLOUDSTACK-70.
2013-07-11 12:08:08 +05:30
Sanjay Tripathi 2ac8f2b452 CLOUDSTACK-1047: tracking in logs using job id. 2013-07-11 10:57:13 +05:30
Likitha Shetty 8eac039d86 CLOUDSTACK-3423. Publish 'VM.UPGRADE' usage event every time the service offering of a VM is upgraded. 2013-07-11 10:05:08 +05:30
Jessica Wang 3e265d22a4 CLOUDSTACK-2988: API - Template Response - add isdynamicallyscalable property. 2013-07-10 15:46:38 -07:00
Alena Prokharchyk 2e0a62749e CLOUDSTACK-3455: delete Shared networks of the domain when do domain deletion 2013-07-10 15:28:56 -07:00
Vijayendra Bhamidipati 2a8e113aa1 CLOUDSTACK-1510: NPE when primary storage is added with wrong path
Description:

	a) Fixing NPE when wrong path is provided for primary datastore.
	b) No error dialog shows up in GUI when wrong path is provided,
	   after NPE fix - propagating exception upward.
	c) If the KVM agent is down, an invalid datastore gets logged in
	   storage_pool table and doesn't get removed, so it shows up
	   in the GUI in the list of datastores - fixing this as well.
2013-07-10 14:58:41 -07:00
Rajesh Battala 1bde0f3fcc CLOUDSTACK-3301 NPE wile deployVM in kvm Only solidfire type PS is setting/using the capacityIops, This check will fix to return the storage has enough Iops when capacityIops is set to NULL for any PS Storage provider 2013-07-10 14:58:37 -07:00
Murali Reddy ea04729fdb CLOUDSTACK-3442: [PortableIP] [VPC] Unable to associate Portable IP to VPC
removing invalid check
2013-07-10 19:31:54 +05:30
Devdeep Singh 5a67a6f1a2 CLOUDSTACK-3443: Timeoffset on windows guest not persisted between VM stop and start on XenServer.
The problem was because in cloudstack when a vm is stopped it gets destroyed on the host. For a
windows vm the timeoffset (which can be set by changing the timezone from within the vm) is stored
in the platform:timeoffset attribute of vm record. The information is lost when the vm is destroted.
Made change to read and persist the platform:timeoffset vm attribute when an instance is stopped.
The value is persisted in the user_vm_details table. When the vm is started again the attribute is
set for the vm instance that gets created.
2013-07-10 17:56:19 +05:30
Murali Reddy 82e447aa31 CLOUDSTACK-3440: action events are not published due to conflict of
Eventutils and ActionEventUtils files

removing the 'EventUtils' file which got merged back during the Spring
changes to master at 4.1. 'EventUtils' file was replaced by
'ActionEventUtils', and the original file was removed for events
frameworks. This file conflict was resulting in action events not to be
published on to event bus
2013-07-10 16:45:54 +05:30
Wei Zhou 023aac8bd1 CLOUDSTACK-3438: update CPVM SSL certificate for both Premium and non-Premium cases 2013-07-10 12:23:57 +02:00
Koushik Das a81cc8a12d CLOUDSTACK-2918: In a scaled up environment, hosts fail to come up after Management server restart in clustered set up
Summary of changes in the fix
- Optimized host scan logic, now instead of iterating over each cluster host scan is done for a batch of clusters
- Made host scan task interval configurable
2013-07-10 12:22:39 +05:30
Mike Tutkowski be6bc2b681 Changes related to Review Board comments 2013-07-09 23:19:44 -06:00
Marcus Sorensen bbff5e84ce CLOUDSTACK-3422 - fix null pointer in usage and action events when
deleting resources whose account has been removed
2013-07-09 09:44:54 -06:00
Kishan Kavala d4ed20b0d3 CLOUDSTACK-2429: Multiple private gateways are allowed within a VPC. Check for conflicting routes in all gateways when adding a new static route 2013-07-09 17:18:23 +05:30
Murali Reddy fe568fefd3 CLOUDSTACK-234: create/delete firewa/lb/pf rule: send ip assoc command
only on first rule is created on the IP and last rule is revoked on the
IP

Current suboptima logic of IP Assoc

 - On associate IP to GuestNetwork there is an IPAssoc command sent to
   corresponding network service providers of the network
 - On every rule apply on IP associated with the network send IP assoc
   to the network service providers
 - On every rule deletion on IP associated with a network sernd IP assoc
   command to the network service providers

With this fix logic of IP assoc is changed as below which eliminates
executio of unnessary and expensive IpAssocCommand resource command

 - On associate IP to GuestNetwork, associate IP only to the network,
   Untill any service is associated with the IP dont send IP Assoc
 - On creation of first rule on the IP send IPAssoc to corresponding
   network service provider. Since IP is used for a service, IPAssoc
   need to be sent to correpondign service provider
 - On deletion of last rule on the IP send IPAssoc to corresponding
   network service provider. When last rule is deleted, IP has no
   service associated with it, so send IP assoc to service provider to
   remove the IP association
2013-07-09 13:31:39 +05:30
Jayapal c0a2821ac8 CLOUDSTACK-3352 fixed removing previous acl rules when emply acl is applied 2013-07-09 12:50:08 +05:30
Marcus Sorensen a505b5b489 Summary: update user data on all networks a VM is connected to
Detail: Get list of all nics and update user data on them, rather than just
the default nic for the VM. This makes the results consistent with the password
and SSH key metadata.

BUG-ID: CLOUDSTACK-3408
Bugfix-for: 4.1.1, 4.2.0
Signed-off-by: Marcus Sorensen <marcus@betterservers.com> 1373345338 -0600
2013-07-08 22:54:37 -06:00
Alena Prokharchyk 5f7b257fde CLOUDSTACK-3387: deleteTemplate - log the exception message when delete command fails 2013-07-08 15:44:48 -07:00
Jessica Wang 00ae00ae35 CLOUDSTACK-2084: API - when account type is ACCOUNT_TYPE_PROJECT, make listVlanIpRanges API to return accountName. 2013-07-08 11:57:05 -07:00
Alena Prokharchyk 8c34f35a3f CLOUDSTACK-3356: list shared networks available for projects when call is executed by the admin who is not a part of the project 2013-07-08 11:21:13 -07:00
Koushik Das 916a009d5d CLOUDSTACK-3393: Local disk recreated for stopped VM when started
Recreating local disk will result in cleanup of the old disk and this will lead to data loss. So preventing this and bailing out with error. Once migration of local disk is supported then another option is to migrate the existing disk to the new local storage pool.
2013-07-08 17:09:16 +05:30
toshiaki.hatano a930426741 CLOUDSTACK-3384: CloudStack allow VLAN range between 0-4096. Should be 0-'4095'. 2013-07-08 15:39:57 +05:30
Ryan Dietrich e7c8a35c3a CLOUDSTACK-3190: Async jobs actions now trigger event bus messages to be
published

-AsyncJobManagerImpl to publish async job events when async jobs are
created, updated and completed
2013-07-05 17:50:03 +05:30
Likitha Shetty 640948d818 CLOUDSTACK-3361. [Projects] Allow a normal user to edit public templates created by him. 2013-07-05 16:27:16 +05:30
Wei Zhou bccf5d8ea0 CLOUDSTACK-3345: createLBStickinessPolicy replaces old stickiness policy if exists 2013-07-05 10:48:03 +02:00
Wei Zhou 893eb37724 CLOUDSTACK-3372: CapacityManager does not count destroyed volumes when deploy VMs 2013-07-05 10:47:58 +02:00
Murali Reddy 3cf07118a8 CLOUDSTACK-2045:[Multiple IPs Per Nic] This feature is not working well
in case of networks with external devices after GC

adding missing 'retrun false' for isNetworkReadyForGc for the networks
that use external network devices and has secondary IP's associated with
nics.
2013-07-04 21:32:01 +05:30
Kishan Kavala 0de3a11788 CLOUDSTACK-3172: Allow creation of private gateway with same Vlan in different VPCs 2013-07-04 16:14:26 +05:30
Alena Prokharchyk fdb85998ef CLOUDSTACK-3347: fixed project deletion for project's owned template
Conflicts:
	server/src/com/cloud/template/TemplateAdapterBase.java
2013-07-03 13:41:53 -07:00
Sanjay Tripathi b993556988 CLOUDSTACK-3184: updateVirtualMachine api gives java NPE.
Signed-off-by: Prasanna Santhanam <tsp@apache.org>
(cherry picked from commit 31df729008)
2013-07-03 21:44:56 +05:30
Nitin Mehta 40ae16140e CLOUDSTACK-2107
If the scaling up fails on the host the vm is running on try to migrate it to other hosts in the cluster and try scaling.
CLOUDSTACK-3349
For deciding the host in the cluster try the new deployment manager now
Signed off by : nitin mehta<nitin.mehta@citrix.com>
2013-07-03 18:47:28 +05:30
Min Chen 0314a99718 CLOUDSTACK-3314: templates downloaded to S3 should show up in
listTemplates when zoneId is provided.
2013-07-02 15:49:14 -07:00
Alena Prokharchyk 90824fc36d CLOUDSTACK-3207: added resourceLimit/resourceCount to the Project API response
Conflicts:
	setup/db/db/schema-410to420.sql
2013-07-02 15:34:17 -07:00
Min Chen 6417629748 CLOUDSTACK-3314: ListTemplates only show one entry for cross-zone
templates.
2013-07-02 14:59:53 -07:00
Rajesh Battala deaf10cad2 CLOUDSTACK-3089 [ZWPS] NPE while cancelling the Storage Maintenance
Signed-off-by: Edison Su <sudison@gmail.com>
2013-07-02 11:22:18 -07:00
Alena Prokharchyk 724be3f5f7 CLOUDSTACK-2984: createNetwork call - when vlan is specified, check that its not coming from the physical network vnet range as this range is used for dynamic vlan allocation during the network implementation stage 2013-07-02 10:20:07 -07:00
Alena Prokharchyk cd7e21b6b1 CLOUDSTACK-236: log uuid instead of actual db id, in the updateNetworkOffering method 2013-07-02 10:19:49 -07:00
Murali Reddy 93090aa7c5 CLOUDSTACK-1959: GSLB: add capability to provide weights to the sites
involved in the GSLB

add weights to each site participating in the GSLB. Traffic will be load
balanced across the sites based on the weigths associated with each
site. If not specified weight of site is defaulted to 1.
2013-07-02 17:57:00 +05:30
Sanjay Tripathi af4eb22a65 CLOUDSTACK-3189: Primary storage usage is not getting decremented after deleting the DATA volumes.
When a volume is created the resource usage for it gets incremented. If it is deleted without being
attached to a volume, the decrement doesn't take place. Fixed the delete volume code to decrement
resource usage for a volume in allocated state too.
2013-07-02 00:39:27 +05:30
Murali Reddy 6a7369b20b CLOUDSTACK-3287: [GSLB] API "updateGlobalLoadBalancerRule" is not
recognised by CloudStack

added api to managementServerImpl and ensure glsb config is applied to
gslb service providers
2013-07-01 23:47:33 +05:30
Rajesh Battala 160b493285 CLOUDSTACK-2571 Zone Wide Primary Storage blocker issues while Enabling in Maintenance State
Signed-off-by: Edison Su <sudison@gmail.com>
2013-07-01 10:18:01 -07:00
Daan Hoogland 216e374993 readibilty of log- and exception messages
Signed-off-by: Prasanna Santhanam <tsp@apache.org>
(cherry picked from commit 639592f3b7)
2013-07-01 20:18:14 +05:30
Sanjay Tripathi 58e69704ea CLOUDSTACK-2288: NPE while creating volume from snapshot when the primary storage is in maintenance state.
Signed-off-by: Prasanna Santhanam <tsp@apache.org>
(cherry picked from commit ffd5f1a777)
2013-07-01 20:18:14 +05:30
Murali Reddy 1032d5c26a CLOUDSTACK-3282:[GSLB] Unable to add multiple LB rules to same GSLB rule
-fixing regression due to adding GSLB monitor for GSLB service

-code to add/delete GSLB monitor and GSLB service-monitor binding is
made idempotenet so as to succeed if the resource exists.
2013-07-01 19:01:48 +05:30
Edison Su 49ded7e4a3 the plugin better not touch database 2013-06-29 15:09:43 +05:30
Prasanna Santhanam de38cd815f Fix typo in class name
AsyncRpcConext -> AsyncRpcContext

Signed-off-by: Prasanna Santhanam <tsp@apache.org>
2013-06-29 13:50:25 +05:30
Min Chen 87c401aaaf CLOUDSTACK-3144: [Automation] Deletion of templates failing. Fails to
find image store housing template.
2013-06-28 17:57:42 -07:00
Min Chen 2c31f38c05 CLOUDSTACK-3145:StorageManager-Scavenger NPEs when cleaning up
templates.
2013-06-28 17:54:48 -07:00
Mike Tutkowski 99227f7b3e SolidFire plug-in and related changes
SolidFire plug-in

SolidFire plug-in related
2013-06-28 16:59:21 -06:00
Prachi Damle 02ab2eb384 Revert "Cloudstack-2150 DB table entries of phisical network is not proper.Shows Duplicate entries Cloudstack-2980 Adding a VLAN range that overlaps with two existing ranges results in inconsistent DB entries"
This reverts commit 7f2f25d640.
2013-06-28 14:58:32 -07:00
Vijayendra Bhamidipati 78922589bb CLOUDSTACK-2385: template download fails with Unexpected failure in Vmware.
Description:

    Putting in fix to allow download of guest VM templates that are available
    across zones.
2013-06-28 23:08:36 +05:30
Bharat Kumar 1c924e5ab5 Assertion failure in updatephysicalnetwork Test.
Signed-off-by: Jayapal <jayapal@apache.org>
2013-06-28 19:05:55 +05:30
Bharat Kumar 974245991c Cloudstack-2732 [Multiple_IP_Ranges] Deleting guest IP range is not throwing any error message to user while the ip addresses are being used
Signed-off-by: Jayapal <jayapal@apache.org>
2013-06-28 19:05:55 +05:30
Bharat Kumar 6b0df2566d Cloudstack-3106 Delete all ips except ipAlias. Cloudstack-3119 Shared network removal doesn't cleanup corresponding IP ranges
Signed-off-by: Jayapal <jayapal@apache.org>
2013-06-28 19:05:55 +05:30
Bharat Kumar 7f2f25d640 Cloudstack-2150 DB table entries of phisical network is not proper.Shows Duplicate entries Cloudstack-2980 Adding a VLAN range that overlaps with two existing ranges results in inconsistent DB entries
Signed-off-by: Jayapal <jayapal@apache.org>
2013-06-28 19:05:54 +05:30
Jayapal 3096261c05 Updated to show same value in log msg SetFirewallRulesCommand and accessdetails for egress default policy 2013-06-28 19:05:54 +05:30
Murali Reddy 0f40cfbea8 CLOUDSTACK-2045: [Multiple IPs Per Nic] This feature is not working well
in case of networks with external devices after GC

add an exception for networks that use external networking devices and has
secondary guest IP's allocated. On network GC, when network goes through
implement phase a new vlan is allocated, based on the acquired VLAN id cidr
of the network is decided in case of external networking case. While NIC
uses reservation strategy 'Start' which ensures that new primary ip is
allocated for the NiC from the new CIDR. Secondary IP's have hardcoded
IP's in  network rules. So prevent network GC.
2013-06-28 12:26:20 +05:30
Kishan Kavala 6da29c4cde CLOUDSTACK-650: Rename ExternalLBUsageMgr to more generic ExternalDeviceUsageManager since it contains firewall usage also. Most of the functionality is already fixed in CLOUDSTACK-1289 2013-06-28 12:08:33 +05:30
Kishan Kavala 7713c5cdbc CLOUDSTACK-3239: Delete Traffic Monitor directly without going through maintenance state 2013-06-28 11:12:55 +05:30
Devdeep Singh 4bbc65b34c CLOUDSTACK-3246: Unable to use portable ips if the portable ip range is deleted and readded atleast once. Fixed the query used to look for available portable ips. 2013-06-28 03:32:31 +05:30
Min Chen 3160a0c2da Add template zone related information into TemplateZoneResponse. 2013-06-27 14:34:00 -07:00
Harikrishna Patnala c8692f2e4a CLOUDSTACK-3245: non admin user not able to register template
Reviewed-by: Alena Prokharchyk
2013-06-27 14:09:52 -07:00
Saksham Srivastava 0d78868180 CLOUDSTACK-3064: Able to create an instance from different account of the same domain without
using affinity group even if the zone is dedicated to an account. The check to make sure that
explicit resources are not picked up for non-explicit deployment was present only at the domain
level for zones. Added a check at account level too.
2013-06-28 00:32:17 +05:30
Donal Lafferty 4361418e41 Removed Dead Code from Management Server Hyper-V 2012 Support
Update ImageFormat enum to include VHDX format introduced with Hyper-V
Server 2012.
Remove existing Hyper-V plugin, because it does not work and is dead
code.
Remove references to existing Hyper-V plugin from config files.
Remove Hypervisor.HypervisorType.Hyperv special cases from manager code
that are unused or unsupported.
Specifically, there is no CIFS secondary storage class
"CifsSecondaryStorageResource".  Also, the Hyper-V plugin's
ServerResource is contacted by the management server and not the other
way around.
Add Hyperv-V support to ListHypervisorsCmd API call

Signed-off-by: Edison Su <sudison@gmail.com>
2013-06-27 11:46:02 -07:00
Alena Prokharchyk 77fd76acb4 CLOUDSTACK-3242: fixed updateTemplate and updateTemplate permissions security checks for project based templates 2013-06-27 11:32:41 -07:00
Wei Zhou 181567ba74 CLOUDSTACK-1192: Disk I/O Statistics (vm stats) support KVM and XenServer only util 2013/06/25 2013-06-27 14:25:54 +02:00
Alena Prokharchyk 079f920494 CreateVPC: validate that the zone exists before checking its attributes 2013-06-26 15:26:20 -07:00
Murali Reddy 4bc6294746 CLOUDSTACK-3213: ResourceStateEvents for user VM are generated with
entity type as Network

changing entity type to be VirtualMachine from Network for the events
generated by user vm state transitions
2013-06-26 19:33:24 +05:30
Murali Reddy ff167134e4 CLOUDSTACK-3214: transferring portable IP across zones with enableStatic
NAT does not work

making an exception for portabe IP, so that if the current datacenter with
portable IP is associated is different from destiantion data center

also on transfer on to new zone, transfer the portable ip association to
new data center, physical network id's
2013-06-26 19:29:55 +05:30
Harikrishna Patnala 9385cf0453 CLOUDSTACK-2835: VR Deployement from admin registered template is failing because registered template type is user. Additional parameter "isrouter" in register/update template API for the root admin. True if registered template is of type ROUTING.
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2013-06-26 16:00:12 +05:30
Harikrishna Patnala ec2bf09284 CLOUDSTACK-2794: Global parameter "router.template.id" should be removed The parameter was not in use. We use zone/global coonfigutaion parameters router.template.xenserver/vmware/hyperv/kvm/lxc to deploy router
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2013-06-26 15:56:40 +05:30
Likitha Shetty 55f0e167ec CLOUDSTACK-3206. CreateVlanIpRange fails with IndexOutOfBoundsException. 2013-06-26 14:59:36 +05:30
Wei Zhou 3bb4ec9f65 CLOUDSTACK-1192: Disk I/O Statistics support KVM only util 20130625 2013-06-26 11:10:11 +02:00
Jayapal 82958f0d58 CLOUDSTACK-3199 apply acl item to private gateway when added to acl list 2013-06-26 14:31:56 +05:30
Mice Xia 94254e3c2b fix CLOUDSTACK-2989, do not list network offering with specifyvlan=true for non-root-admin user 2013-06-26 15:55:32 +08:00
Likitha Shetty 8a1fefc7aa CLOUDSTACK-3192. When a dedicated public ip range is released, don't generate usage event EVENT_NET_IP_RELEASE
for ips in the range that are in use becauase these ips are not disassociated from the account.
2013-06-26 10:51:39 +05:30
Alena Prokharchyk 1eacd7872e Update resource count for networks only when the network is non system and Isolated. Before we used to update the count only when offering had specifyVlan=false. And in 4.2 even isolated networks can have this attribute set to true, and we have to count them 2013-06-25 13:46:35 -07:00
Hiroaki KAWAI ed5697f3e1 filter out the network providers that does not handle IP address
The elements that deploy IP address are subclass of IpDeployingRequester
CloudRuntimeException will be raised for elements that is not implemeing
the interface at NetworkManagerImpl#applyIpAssociations.
2013-06-25 13:18:06 +09:00
Harikrishna Patnala f7b1d3d8d5 CLOUDSTACK-2916: admin is not able to login through UI after setting GP "cluster.cpu.allocated.capacity.notificationthreshold" to some string
CLOUDSTACK-2457:  No check for input values,special character,-ive values can be assigne to GLobal parameter "cluster.cpu.allocated.capacity.disablethreshold"

Added validation for float values and checking limit for weight based parameters by creating a set of parameters.
Signed off by : nitin mehta<nitin.mehta@citrix.com>
2013-06-24 20:00:09 +05:30
Kishan Kavala da0006618f CLOUDSTACK-3124: Deletion of ACL associated with a tier/ pvt gateway should not be allowed. Check for associated tiers/gateways before deletion 2013-06-24 17:58:29 +05:30
Sateesh Chodapuneedi e9df9c29bd CLOUDSTACK-3155 [VMware] Deletion of zone should not be allowed if VMware DC is still associated with that zone.
Check if there exists any VMware DC already associated with this zone. Deny zone deletion if true.

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-06-24 12:11:31 +05:30
Kishan Kavala bd5ad442d0 CLOUDSTACK-3084: Added check to disallow -ve number for ACL rule 2013-06-24 17:20:29 +05:30
Kishan Kavala 7c46cc9580 CLOUDSTACK-3149: Allow default ACLs when creating tier with ACL 2013-06-24 16:22:02 +05:30
Jayapal bb50c0d2d6 CLOUDSTACK-3148 failed to create private gw with default acl id 2013-06-24 13:37:01 +05:30
Jayapal c22e7d0052 CLOUDSTACK-1578 SRX: Egress default policy configurable using network offering on SRX firewall 2013-06-24 13:37:01 +05:30
Jayapal 6a7ae637dd CLOUDSTACK-1578 Egress default policy configurable using network offering in xenserver with VR as firewall provider 2013-06-24 13:37:00 +05:30
Harikrishna Patnala 1eb744fa16 CLOUDSTACK-2181: Scale down is allowed when one resource(say cpu) is being scale up and other resource (say ram) is
being scale down ;but not allowed when both resources are being scaledown
Signed off by : Nitin Mehta<nitin.mehta@citrix.com>
2013-06-24 12:09:55 +05:30
Sheng Yang fe32dc7665 Baremetal: Add BaremetalDhcp Server and BaremetalPxe server to avoid list of stats collector 2013-06-21 17:36:21 -07:00
Sheng Yang db97bb8e89 Fix NPE when using baremetal template
Template size is NULL for baremetal, which caused NPE when unboxing
2013-06-21 17:16:33 -07:00
Min Chen 64c5266ec5 CLOUDSTACK-3120: ListTemplates didn't return Baremetal templates after
storage refactor.
2013-06-21 16:10:39 -07:00
Alena Prokharchyk 22232f2baf CLOUDSTACK-2698: always generate new id when create VirtualRouter. Don't try to re-use the id of the VR that failed to deploy and was expunged as a result of this failure 2013-06-21 15:29:00 -07:00
Sheng Yang 041303cc67 Baremetal: Fix typo of BaremetaUserdataProvider
Should be "Baremetal" rather than "Baremeta"
2013-06-21 09:48:25 -07:00
Sheng Yang 2edfa9a7f2 Baremetal: DB upgrade
Conflicts:
	setup/db/db/schema-410to420.sql
2013-06-21 09:47:45 -07:00
Sheng Yang f37b089fce Revert "Removing baremetal related references"
This reverts commit 99ea4011b1.

Conflicts:
	server/src/com/cloud/network/NetworkServiceImpl.java
2013-06-21 09:46:56 -07:00
Min Chen 2f9ba709a5 Add listCacheStoresCmd api for UI to list cache stores. 2013-06-20 18:06:30 -07:00
Edison Su 6b9ea1761a CLOUDSTACK-2947: fix create template from snapshot, in case of mix zone-wide/cluster wide primary storage 2013-06-20 17:51:11 -07:00
Min Chen 2fe732b354 CLOUDSTACK-3080: listVirtualMachines tag search refinement no longer
working.
2013-06-20 15:44:01 -07:00
Alena Prokharchyk 2072026340 CLOUDSTACK-3088: fixed listRouters/listInternalLbVms by name 2013-06-20 10:37:59 -07:00
Alena Prokharchyk bf331064a2 CLOUDSTACK-3091: expect UUID instead of actual DB id, when read internallbvm.service.offering global config 2013-06-20 10:37:59 -07:00
Kishan Kavala b422d8ddd9 CLOUDSTACK-2819: Revoke existing ACL items if the new ACL is empty 2013-06-20 17:06:06 +05:30
Jayapal 2e0abccd3b CLOUDSTACK-2952 Fixed configuring private gateway with another vpc acl id 2013-06-20 16:11:20 +05:30
Kishan Kavala 03d1346dc3 CLOUDSTACK-2915: Create network ACL when adding ACL item to a tier without ACL for backward compatibility 2013-06-20 15:36:58 +05:30
Likitha Shetty 9df45065d0 CLOUDSTACK-3078 2013-06-20 14:34:33 +05:30
Edison Su 733ed3622d fix compile 2013-06-20 00:57:06 -07:00
Edison Su 97f8c524b8 merge object_store 2013-06-20 00:18:00 -07:00
Likitha Shetty 4a260672e0 CLOUDSTACK-3078. Since no default value is set for the isolation type during the physical network creation,
modify guest vlan range dedication to check if the isolation type is VLAN only when an isolation type has been set
2013-06-20 12:09:32 +05:30
Bharat Kumar f9e7094282 Cloudstack-2644 [Multiple_IP_Ranges] user data service on VR does not work in case of multiple subnets Cloudstack-2953 [Multiple_IP_Ranges] VM does not get the public key from VR incase of multiple subnets per vlan Also removed some unused code and fixed the an error in the dnsmasq config function
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2013-06-20 11:15:15 +05:30
Edison Su 5f28dcc6bb merge to master 2013-06-19 22:41:13 -07:00
Harikrishna Patnala 7b6b8d7a07 CLOUDSTACK-2987 Ensure XStools to be there in template inorder to enable dynamic scaling of vm
CLOUDSTACK-3042 - handle Scaling up of vm memory/CPU based on the presence of XS tools in the template
This also takes care of updation of VM after XS tools are installed in the vm and set memory values accordingly to support dynamic scaling after stop start of VM

Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2013-06-20 11:08:38 +05:30
Saksham Srivastava e420c3be8c CLOUDSTACK-2167: The Vlan ranges displayed are not in ascending order 2013-06-20 10:58:50 +05:30
Abhinandan Prateek febe7d9cff Cloudstack-2621 [Multiple_IP_Ranges] Failed to delete guest IP range from a subnet 2013-06-20 10:44:48 +05:30
Bharat Kumar 4d5c6c8381 Cloudstack-2621 [Multiple_IP_Ranges] Failed to delete guest IP range from a new subnet
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2013-06-20 10:40:23 +05:30
Edison Su 9aec9c605c merge to master 2013-06-19 18:16:47 -07:00
Sheng Yang b3fb4851ee Fix regression of return Userdata provider when caller asked for DHCP
It's introduced by:

commit 052c24c4d1
Author: Bharat Kumar <bharat.kumar@citrix.com>
Date:   Mon May 13 17:02:27 2013 +0530

    CLOUDSTACK-702: Multiple ip ranges in different subnets.

This commit get userdata provider when caller asked for dhcp provider, thus
result in trouble e.g.

ERROR [cloud.async.AsyncJobManagerImpl] (Job-Executor-11:job-10) Unexpected
exception while executing
org.apache.cloudstack.api.command.user.network.DeleteNetworkCmd
java.lang.ClassCastException:
com.cloud.baremetal.networkservice.BaremetalUserdataElement_EnhancerByCloudStack_5dee69d2
cannot be cast to com.cloud.network.element.DhcpServiceProvider
        at
com.cloud.network.NetworkManagerImpl.getDhcpServiceProvider(NetworkManagerImpl.java:3309)
...
2013-06-19 17:06:06 -07:00
Alena Prokharchyk 0a4e65126f CLOUDSTACK-3079: Use global var "ping.timeout" as a multiplier to ping.interval before announcing an agent has timed out. The multiplier used to be hardcoded to 3 2013-06-19 15:11:53 -07:00
Edison Su 11b9d5ff64 CLOUDSTACK-1405: add scope type in liststoragepoolcmd 2013-06-19 14:09:49 -07:00
Alena Prokharchyk 928d94265b Added more logging to the place where VR investigates whether the user vm is alive, by executing PingCommand 2013-06-19 10:53:56 -07:00
Jessica Wang d5d0142ed4 CLOUDSTACK-3016: listZones API - take in networktype instead of zonetype parameter to be consistent with networktype property in ZoneResponse. 2013-06-19 10:22:14 -07:00
Alena Prokharchyk d66e9c7b51 CLOUDSTACK-2843: Provideded an ability to turn off the synchronization being done on the CS agent side,
for number of commands participating in Vm deployment process, as parallel deployment is supported on the hypervisor side.
The behavior is controlled by global config varirables:

"execute.in.sequence.hypervisor.commands" (false by default) sets/resets the synchronization for commands:
=========================
StartCommand
StopCommand
CreateCommand
CopyVolumeCommand

"execute.in.sequence.network.element.commands" (false by default) sets/resets the synchronization for commands:
==========================
DhcpEntryCommand
SavePasswordCommand
UserDataCommand
VmDataCommand

As a part of the fix, increased the global lock timeout to 30 mins in several VR scripts:
===========================
edithosts.sh
savepassword.sh
userdata.sh

to support situations when multiple concurrent calls to the script are being made.
2013-06-19 10:12:13 -07:00
Likitha Shetty 1af928570c CLOUDSTACK-3062. Dedication of a guest vlan range that extends 2 ranges dedicated to different accounts removes an old dedication 2013-06-19 16:59:14 +05:30
Jessica Wang 2f2bb6b316 CLOUDSTACK-3016: remove zonetype property from API response (userVM) 2013-06-18 14:55:56 -07:00
Jessica Wang 759eeca651 CLOUDSTACK-3016: remove zonetype property from API response (snapshot, ISO, template, network, volume) 2013-06-18 14:42:38 -07:00
Jessica Wang 0a8343e750 CLOUDSTACK-3016: remove zonetype property from API response (cluster, domainRouter, host, pod, storagePool, systemVM) 2013-06-18 13:54:37 -07:00
Jessica Wang b5abc0862b CLOUDSTACK-3016: remove zonetype parameter from listRouters API, listInternalLbVms API. 2013-06-18 10:41:37 -07:00
Wei Zhou 0dd45513e3 CLOUDSTACK-2885: show cpuNumber and cpuSpeed on VM Statistics page 2013-06-18 17:00:44 +02:00
Wei Zhou 9d7c7c14c7 CLOUDSTACK-1866: create iptables rules for network usage in finalizeSshAndVersionAndNetworkUsageOnStart only for non-Vpc network 2013-06-18 12:56:19 +02:00
Wei Zhou 882220e802 CLOUDSTACK-1301: VM Disk I/O Throttling 2013-06-18 10:02:55 +02:00
Prachi Damle fb31a39efe CLOUDSTACK-2900: Ubuntu 13.04 - Migrate Virtual Router fail - Unable to find the VM by id=
Changes:
- Have to search the vm_instance table to find the instance
2013-06-17 16:59:32 -07:00
Jessica Wang 3e852cc29b CLOUDSTACK-3016: remove zonetype parameter from listNetworks API. 2013-06-17 16:26:09 -07:00
Alena Prokharchyk 5d0a1cee13 CLOUDSTACK-2883: create default network offering with internal lb support (if doesn't exist already) 2013-06-17 16:13:19 -07:00
Jessica Wang 880029844b CLOUDSTACK-3016: remove zonetype parameter from listTemplates, listIsos API. 2013-06-17 16:08:38 -07:00
Jessica Wang cb35ec6f4d CLOUDSTACK-3016: remove zonetype parameter from listSystemVMs API. 2013-06-17 15:58:33 -07:00
Min Chen 4c26dd6ae5 CLOUDSTACK-2956:createStoragePools API should ignore passed clusterId
and podId parameters in creating zone scoped primary storage
2013-06-17 15:57:52 -07:00
Jessica Wang 56d390d54e CLOUDSTACK-3016: remove zonetype parameter from listPods API. 2013-06-17 15:51:07 -07:00
Jessica Wang 9d0d02222b CLOUDSTACK-3016: remove zonetype parameter from listClusters API. 2013-06-17 15:28:39 -07:00
Jessica Wang 9e7356c686 CLOUDSTACK-3016: remove zonetype parameter from listSnapshots API. 2013-06-17 15:00:44 -07:00
Min Chen 1df4cf839e CLOUDSTACK-3028: Object_Store_Refactor - S3 reduced redundancy storage
should be an option.
2013-06-17 11:49:33 -07:00
Laszlo Hornyak 202cd15290 NPE fix
- fixes an NPE in case the pool.scope = null
- replaces null checks around toString with ObjectUtils.toString call

Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2013-06-17 19:19:43 +01:00
Laszlo Hornyak c88d8fb3a2 use commons-lang StringUtils
commons-lang is already a transitive dependency of the utils project, which allows removing some duplicated functionality.
This patch replaces StringUtils.join(String, Object...) with it's commons-lang counterpart.
It also replaces calls to String join(Iterable<? extends Object>, String) in cases where an array is already exist and it is only wrapped into a List.

Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2013-06-17 19:17:22 +01:00
Alena Prokharchyk 952fa2464d LOUDSTACK-2914: handle situation when serviceProvider map is empty 2013-06-17 10:55:33 -07:00
Alena Prokharchyk fc16e29f99 CLOUDSTACK-2914: default lb scheme to Public when the service LB is enabled, and scheme is not specified explicitly 2013-06-17 10:10:43 -07:00
Hugo Trippaers b0ea02e65a Allow DSA public keys.
DSA can't be used for encryption with the bouncycastle library, so make
sure this situation is properly handled.
2013-06-17 10:04:59 -07:00
Likitha Shetty 770cf02ccf Global config to disable an account from acquiring public ips and guest vlans from the system if the account
has dedicated resources and the dedicated resources have all been consumed - use.system.public.ips and use.system.guest.vlans
Both configs are configurable at the account level too.
2013-06-17 17:54:36 +05:30
Edison Su f41c800d88 merge to master 2013-06-14 19:06:33 -07:00
Edison Su c2da4eac89 fix NPE for cache ref cnt 2013-06-14 17:24:31 -07:00
Jessica Wang 8925d39b78 CLOUDSTACK-3016: remove zonetype parameter from listVirtualMachines API. 2013-06-14 16:51:20 -07:00
Jessica Wang b4a692d80f CLOUDSTACK-3016: remove zonetype parameter from listVolumes API. 2013-06-14 16:39:04 -07:00
Jessica Wang ea0de9eaf4 CLOUDSTACK-3016: remove zonetype parameter from listStoragePools API. 2013-06-14 16:33:27 -07:00
Jessica Wang cb37d4cb63 CLOUDSTACK-3016: remove zonetype parameter from listHosts API. 2013-06-14 16:14:45 -07:00
Edison Su a715eb8121 clean up storage related code, and add lru replacement algorithm for cache storage 2013-06-14 15:55:59 -07:00
Min Chen bb85a564da Remove state from vm_template table, we should use template_store_ref
state column to represent the state of a template in each zone.
2013-06-14 15:14:09 -07:00
Mice Xia 7663684981 fix CLOUDSTACK-2989 normal user are allowed to create isolated network offerings with vlan assignments
1) only root admin can list network offering with specifyVlan=true
2) only root admin can create network with specifyVlan=true
2013-06-14 14:58:24 +08:00
Mice Xia 5e56e43e31 fix CLOUDSTACK-2930, exception while applying ACL rule with protocol as ALL.
1) change UI, disable startport and endport when protocol=All
2) validate parameters for API createNetworkACL
2013-06-14 13:19:07 +08:00
Sheng Yang 5a8a2a259e CLOUDSTACK-2792: Send "saved_password" to BACKUP router when reset password for user VM
Otherwise when MASTER failed, the user VM would get password reset again after
reboot.

But this fix still have issues if MASTER is failure before VM boot up, but in
that case, password of user VM won't change and user would request password
change again, then it would be fine.
2013-06-13 16:05:15 -07:00
Sheng Yang fbe6b273e3 CLOUDSTACK-1170: Redundant Router: Ensure MACs are same on other than first public nic 2013-06-13 16:05:15 -07:00
Harikrishna Patnala b83b8eb838 CLOUDSTACK-2502: Scalevm and over provisioning should respect each other
During Scale up of VM, memory/cpu calculations should consider the memory/cpu overprovisioning factors which are set per cluster.

CLOUDSTACK-2939:  CPU limit is not getting set for vm after scaleup to a service offering which have cpu cap enabled

Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2013-06-13 16:30:56 +05:30
Jayapal b72c79b370 CLOUDSTACK-2934 Fixed not showing uuid in list firewall rules response
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2013-06-13 14:37:34 +05:30
Vijayendra Bhamidipati ff0a524bd6 CLOUDSTACK-2969: Exception when creating vlan ip range
Description:

	Putting in null pointer check when creating ip range.

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-06-13 11:07:12 +05:30
Min Chen 18aeef3ef1 Merge branch 'master' (up to commit
c30d9be3ce) into object_store.
2013-06-12 11:20:32 -07:00
Bharat Kumar 31f0e34539 CLOUDSTACK-2963 Build failure due to validateIpRange test failure
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2013-06-12 18:48:46 +05:30
Nitin Mehta 2aafc39f3d CLOUDSTACK-2957
deployVm API size attribute should be capped by the storage.max.volume.size as it is in createVolume.
2013-06-12 17:01:41 +05:30
Bharat Kumar ca13586331 Cloudstack-2511 Multiple_Ip_Ranges: Adding guest ip range in subset/superset to existing CIDR is allowed Cloudstack-2651 [Shared n/w]Add IP range should ask for gateway and netmask
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2013-06-12 16:27:56 +05:30
Wei Zhou 51a3a5a9b5 CLOUDSTACK-2945: ignore collect disk statistics if vm is not running on KVM or XenServer 2013-06-12 11:57:17 +02:00
Nitin Mehta 83fcba9ee6 CLOUDSTACK-2946
CS-15158: Correcting the allocated size for local storage in listStoragePools
2013-06-12 14:58:54 +05:30
Harikrishna Patnala 215b638e8e CLOUDSTACK-2347: Zone filter for listSnapshots API
Added new optional parameter zone id in listSnapshots API which allows to list snapshots with additional criteria.
   Signed off by :- Nitin Mehta <nitin.mehta@citrix.com>
2013-06-12 13:35:58 +05:30
Nitin Mehta e73aafc09a CLOUDSTACK-2940
Allowing Replacement of realhostip.com with a customized domain for SSVM. Though the config variable was there we were always hardcoding to realhostip.com
Reviewed-by: Abhi
2013-06-12 11:51:45 +05:30
Nitin Mehta d21e064724 CLOUDSTACK-2937
Scheduled snapshot events should be shown to users
2013-06-12 11:42:10 +05:30
Jayapal 358f3edc57 CLOUDSTACK-2609 Fixed accoundId, domainId for the secondary ip address for shared networks
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2013-06-12 10:32:04 +05:30
Min Chen ec55c2e909 CS-17842: java.lang.NullPointerException seen when using
"updateTemplatePermission" with projectids parameter.
2013-06-11 17:07:26 -07:00
Likitha Shetty 7b63894a0a CLOUDSTACK-2891. While adding a new vlan range if the new range extends an existing range then CS extends the existing range to include the new range.
This is done by checking if the last vlan in the new range is same as the start vlan of any existing range.
Since for a single vlan the start and the end vlan are the same the check goes to an infinite loop resulting in a java.lang.OutOfMemoryError: Java heap space error.
Remove the check for a single vlan because if an existing range starts with the single vlan then it implies that the range already exists
2013-06-11 12:08:05 +05:30
Min Chen cc0de88088 Remove old DeleteTemplateCommand, DeleteVolumeCommand,
DeleteSnapshotBackupCommand, replaced by DeleteCommand.
2013-06-10 17:55:30 -07:00
Kelven Yang 923deba89b Wire CreateSnapshotCmd with @Inject support in SnapshotSchedulerImpl 2013-06-10 17:52:14 -07:00
Wei Zhou 76ce304411 CLOUDSTACK-2707: use executeBatch instead of persist in Usage Server 2013-06-10 15:00:08 +02:00
Nitin Mehta d8a235ee31 CLOUDSTACK-2923: Delete Secondary storage of a Zone was giving NPE bcz we were still refering to the object. Instead log that the cpvm and ssvm cant be created bcz sec storage is not available 2013-06-10 16:48:50 +05:30
Jayapal c1ad3b7974 CLOUDSTACK-2604 Fixed deleting secondary ip when no PF rules set
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2013-06-10 12:13:08 +05:30
Likitha Shetty 22a8508280 CLOUDSTACK-2894. Removing all vlan ranges should update the vnet column to NULL. 2013-06-10 10:39:55 +05:30
Prachi Damle 8c9f681f9e CLOUDSTACK-2350: Anti-Affinity - As admin user, when tryinto update the affinity group for a Vm that is deployed by a regular user , he is presented with admin's affinity groups.
Changes:
- listAffinityGroups API takes in accountname and domainId parameter
- For admin, listall=true should return all affinity groups of all users
2013-06-07 15:28:28 -07:00
Saksham Srivastava 5dc7387d3b CLOUDSTACK-1647: IP Reservation should not happen if the guest-vm cidr and network cidr is not same but their start ip and end ip are same.
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-06-07 16:54:40 +05:30
Likitha Shetty e7d5ccaada Fix DB warnings - txn: Commit called when it is not a transaction: -NetworkServiceImpl.dedicateGuestVlanRange:3050 2013-06-07 12:12:18 +05:30
Sheng Yang 4a14ea8a4d CLOUDSTACK-1771: Fix ipv6 address for router
Now it won't change(as ipv4 address) after router is destroyed.
2013-06-06 18:04:35 -07:00
Min Chen 66e702222d Simplify various DeleteTemplateCommnad, DeleteVolumeCommand and
DeleteSnapshotBackupCommand to use one DeleteCommand, also provide
BaseImageStoreDriverImpl class for plugin to inherit to avoid code
duplication.
2013-06-06 18:00:38 -07:00
Alena Prokharchyk f4a1a2ff38 Allow account to have multiple networks with customer defined cidrs as we already let it happen when the cidr is taken from the physical network config 2013-06-06 11:52:15 -07:00
Kishan Kavala 62e125c081 check for null ACL before creating ACL commands 2013-06-06 19:02:44 +05:30
Kishan Kavala aa2fb31112 check for null protocol while validating ACL item 2013-06-06 19:02:44 +05:30
Wei Zhou d2e6bf5fa4 CLOUDSTACK-2865: fix error in prepareStop 2013-06-05 16:43:31 +02:00
Alena Prokharchyk 54481d0b7b listLoadBalancingRules: when list by networkId, no need to pass the dataCenterId to the call 2013-06-05 10:25:25 -07:00