alena
2184dd1af2
bug 7195: introduced search by forVirtualNetwork parameter in listVmsCmd. Added "forVirtualNetwork" param to responses for all VM's apis.
...
status 7195: resolved fixed
2010-11-17 14:11:16 -08:00
alena
dae39942f1
bug 7192: Added networktype parameter for the zone
...
status 7192: resolved fixed
1) Zone has networktype parameter now, 2 values are supported: Basic and Advanced. "networktype" field is created in data_center table. The parameter is being set at creation time; we don't allow to modify it with updateZone command.
2) Only vlan of Untagged Direct type can be created in Basic network zone; any other vlan except for Untagged Direct can be created in Advanced zone
3) Allow NULL guest vlan range for the zone. Only vlan of Direct type can be created in zone with NULL guest vlan.
4) "Default" zone is Basic by default.
5) Changed "vnet" parameter to "vlan" in updateZone command to be consistent with createZone
2010-11-16 16:54:44 -08:00
abhishek
10cfe07970
bug 6793: returning the right msg to the ui when we try to log in to a locked account
2010-11-16 14:15:08 -08:00
abhishek
e5e128545d
removing the tags support in the update commands for disk and service offerings
2010-11-16 13:25:25 -08:00
alena
c5d78a726e
Modified exception handing in API. Following exceptions are supported now (location - BaseCmd.java):
...
* MALFORMED_PARAMETER_ERROR - when type of the request parameter is invalid (String instead of Long for id for example)
* PARAM_ERROR - when invalid parameter value is specified in api request. For example, id of non existing vm for StartVmCmd
* ACCOUNT_RESOURCE_LIMIT_ERROR - when user tries to exceed his resource limits by executing the api command.
* INSUFFICIENT_CAPACITY_ERROR - when resource fails to create/start due to insufficient capacity.
* RESOURCE_UNAVAILABLE_ERROR - when user tries to create a vm when storage is not available.
* RESOURCE_IN_USE_ERROR - when user tries to delete/modify resource while it's in use. For example, when we try to delete a network group when it contains ingress rules.
* NETWORK_RULE_CONFLICT_ERROR - when LB/PF rule to add conflicts with existing rule
* ACCOUNT_ERROR - when user is not authorized to execute operation on the resource.
* INTERNAL_ERROR
2010-11-16 11:56:34 -08:00
abhishek
92e3dc91c4
found a bug in the code where we were not decoding the params sent in eg. "a b" was being stored in the db as 'a%20b'. Fixing the same to have the right val persisted to the db
2010-11-16 11:46:55 -08:00
Alex Huang
ed31497188
ComponentLocator changes
2010-11-16 04:28:15 -08:00
Alex Huang
17afeade00
better componentslocator
2010-11-16 04:28:14 -08:00
alena
d43a8e983c
Fixed authorizeNetworkGroupIngress api command (it stopped working after API refactor)
2010-11-15 17:44:51 -08:00
alena
1a8d9a92a7
Modified all api calls to throw ApiServerException if null object is returned by the manager.
2010-11-15 17:44:51 -08:00
abhishek
d5ab597fcf
bug 6474,6475: porting over the expunge fixes for port forwarding rules to 2.2
...
status 6474,6475: resolved fixed
2010-11-15 17:33:05 -08:00
abhishek
c115a2e401
bug 7189: returning vmdisplayname if available for all port fwding crud cmds
...
status 7189: resolved fixed
2010-11-15 14:55:03 -08:00
abhishek
d520f0af5b
adding a column in user_ip_address table called one_to_one_nat; which is a boolean to tell us if the ip is a nat ip. This is false by default, and is set to true when we nat the ip. Also, this value is returned in the list public ip addrsses api call.
...
finally, the value is set to false when we delete the ip forwarding rule.
2010-11-15 12:39:24 -08:00
abhishek
6d943abf55
bug 7119: code refactor away from the ms calls, to the share and prepare methods based on alex's recommendations
...
status 7119: resolved fixed
2010-11-15 11:17:36 -08:00
alena
a01aad84ed
bug 7162: added search by id to listZones command
...
status 7162: resolved fixed
2010-11-15 10:48:36 -08:00
alena
050eed742f
1) Removed account/domainId info from deleteSnapshot and deleteSnapshotPolicy commands as we get account info from the snapshot/policy object.
...
2) Introduced responseObject field in @Implementation for all apis. This field contains information about the response object class, so we can used it for generating API documentation.
2010-11-12 17:36:17 -08:00
abhishek
fc461abed1
bug 6755: adding checks for commands before they hit the ms; to ensure they are valid. Also returning the right error msg if the command is not valid
...
status 6755: resolved fixed
2010-11-12 13:55:06 -08:00
abhishek
c91c977fba
bug 6290: we will be returning the service offering details for a root disk in the list volumes cmd, as opposed to the disk offering which was misleading
...
status 6290: resolved fixed
2010-11-12 11:24:34 -08:00
abhishek
673ddb246a
bug 6832: returning the missing api value for destroyed volumes
...
status 6832: resolved fixed
2010-11-12 10:55:13 -08:00
nit
dd8f02589d
bug 6837 : UpdateIso and UpdateTemplate API should return ostypename. Removing incorrect domainId creeping in because it was of primitive type.
...
status 6837: resolved fixed
2010-11-12 18:08:43 +05:30
nit
5215f6f817
bug 7101 : DetachISO API and AttachISO API would start returning an embedded object of virtualmachine so that the UI could use that to update the vm.
...
status 7101: resolved fixed
2010-11-12 16:40:55 +05:30
alena
6e0b500a83
bug 4964: made listDomainChildren work with "isRecursive" flag
...
status 4964: resolved fixed
2010-11-11 14:32:36 -08:00
abhishek
1faaba8fb0
fixed a corner case; also changed the commands to be async and changed the method signatures to conform with the master refactor
2010-11-11 13:07:26 -08:00
abhishek
26b75fc05d
this is a good point to check the code in; have completed a part of the enhancement's code; with create and delete ip forwarding rule commands and the skeleton for port to rule map with associated table
2010-11-11 13:07:26 -08:00
abhishek
e5ca5dddf9
renaming the ip forwarding commands to port forwarding commands, and beginning to work on Keshav's request to modify the current 1-1 NAT to be compatible with the Amazon apis
2010-11-11 13:07:26 -08:00
Alex Huang
05ce97f918
Merged in alena's changes
2010-11-11 12:53:19 -08:00
Alex Huang
284720bf00
compilation errors fixed
2010-11-11 12:53:19 -08:00
Alex Huang
c6033baa78
system vm start and stop added
2010-11-11 12:53:19 -08:00
alena
86c8f86a56
bug 6192: use "ipaddress" instead of "publicip" in updatePortForwarding command
...
status 6192: resolved fixed
2010-11-11 12:12:29 -08:00
alena
86e83bc4bd
Created new response objects for userVm/domainRouter/systemVm that going to be used by API after network refactorig is in place.
2010-11-11 10:43:18 -08:00
alena
b1194e68f7
Fixed the build
2010-11-10 10:14:08 -08:00
nit
0597c0cf4b
bug 4177: RegisterIsoCmd and RegisterTemplateCmd API - Added account and domainId params so that one could register them on behalf of other accounts.
...
status 4177: resolved fixed
2010-11-10 17:47:59 +05:30
alena
3954c7550a
bug 6914: return password in deployVirtualMachine/resetVmPassword response.
...
status 6914: resolved fixed
2010-11-09 11:18:54 -08:00
alena
5fafef9970
More api refactor - build api response is execute() method instead of getResponse method.
2010-11-09 09:58:05 -08:00
abhishek
7262b854a5
bug 7121: made the disk offering id optional, and added a check to ensure we never have both disk offering and snapshot ids to be null
...
status 7121: resolved fixed
2010-11-08 17:59:26 -08:00
alena
47e365f5ea
bug 7089: return embedded object name in xml response
...
status 7089: resolved fixed
2010-11-08 13:59:14 -08:00
will
551e7e4b82
bug 6812: fixed default pagesize of all listXXX command to unlimited for now.
2010-11-08 13:15:02 -08:00
Alex Huang
c8a3ea3080
merge conflict with alena's changes
2010-11-08 12:40:38 -08:00
Alex Huang
734cd0b1b1
fixed some bugs
2010-11-08 12:29:37 -08:00
alena
1c24deda34
1) Refactored current Apis not to use reflection for method invocation. In new version following has to be done:
...
* Implement callCreate() and execute() methods in apis extending BaseAsyncCreateCmd (example - CreateVolumeCmd)
* Implement execute() method in apis extending BaseCmd and BaseAsyncCmd (example - deleteVolumeCmd and deleteUserCmd)
We no longer need createMethod(), method(), manager() fields in @Implementation annotation, cleanup has to be done.
2) Moved Account/User related methods to AccountManagerImpl. Methods are exposed via AccountService interface.
3) Enhanced exception handing for Api calls.
4) Created ConfigurationService interface, all Api config methods are exposed via it.
2010-11-08 11:27:36 -08:00
nit
02781422b5
bug 6055: createDiskOffering: remove domainId parameter.
...
status 6055: resolved fixed
2010-11-08 13:41:33 +05:30
nit
4dc8837dc8
bug 6952: listISO should return "ispublic" property.
...
status 6952: resolved fixed
2010-11-08 12:33:23 +05:30
will
89c717703f
Fixed API commands that extend BaseCreateAsyncCmd to return the correct API response of id, and jobid.
...
Added the default public constructor back in the SuccessResponse to make sure deserialization works from the asyncjob table.
Fixed a issues with the VPN tab. It should now make use of the corrected API format.
2010-11-06 16:30:08 -07:00
will
ca0ce93fde
Fixed all sync commands that can possibly return a <success> tag. If success, it will return true, otherwise an HTTP error will be returned.
2010-11-05 21:25:19 -07:00
will
563b45a220
bug 7059: Fixed the async output to use the object name
2010-11-05 20:58:00 -07:00
anthony
224da7e775
several snapshot fixes
2010-11-05 20:55:19 -07:00
will
bcb53ec363
bug 7059: Fixing adding primary and secondary storage to use new api output.
2010-11-05 20:30:55 -07:00
will
a3dbc34857
bug 7059: refactored the API to now add the single embedded object tag after a response
...
- Changed networkgroups to security groups
- a whole bunch of other API bugs. Unfortunately, I may have broken more.
2010-11-05 20:10:57 -07:00
will
05ab3bf673
bug 7063: AsyncJobResult should now return the correct success and error tags upon the completion of a async job. It should now follow either the format ... jobresult.success or jobresult.errorcode and jobresult.errortext
...
- Fixed a lot of other Async related packaging issues. It's not all done but will continue to refactor this later.
2010-11-05 17:30:03 -07:00
Alex Huang
4555fcd73f
changed everything back so everyone can test
2010-11-05 16:10:22 -07:00
Alex Huang
5f90a8adb0
Checking in to do git pull...stupid git
2010-11-05 16:10:22 -07:00
alena
e2aa4738ec
listVirtualMachine api: return "Not created" as a root volume type when volume's storage pool id is NULL
2010-11-05 16:03:37 -07:00
alena
c0e2986766
bug 6958: return state for Account api commands
...
status 6958: resolved fixed
2010-11-05 15:48:05 -07:00
alena
a9166929f0
Fixed NPE in listVolumes/listVirtualMachines commands - do searchIncludingRemoved when get diskOffering/serviceOffering info.
2010-11-05 14:46:08 -07:00
alena
b9ad299ac6
bug 6998: return embedded job result object in queryAsyncJobResult command
...
status 6998: resolved fixed
2010-11-05 12:03:01 -07:00
will
b9fc4137f7
Bug 6988: Fixed issue with queryAsyncJobResult returning jobResults in all String format. This is to mirror the same way that the async commands are being serialized.
...
- Changed client.war to now include all the thirdparty files
- Fixed addVpnUser command to return a vpnuser instead of the response
- Added vmware jar files to the development build.
2010-11-04 20:56:28 -07:00
will
70b4c4d181
Bug 6988: addVpnUser did not camel case the "username" which resulted in that particular value not being returned.
2010-11-04 20:56:23 -07:00
Chiradeep Vittal
5c445bd99e
bug 6991: add presharedkey to response
...
status 6991: resolved fixed
2010-11-04 15:40:24 -07:00
abhishek
03ea885dcd
making disk offering id mandatory for volume creation
2010-11-04 15:30:23 -07:00
abhishek
d96a1a841d
adding logic to prevent commands from being sent to the pool when it is NOT up; also adding better thread safety and db locking, along with a general refactor
2010-11-04 13:35:57 -07:00
nit
7dc7a4838a
bug 4286: Fixing the extract functionality for Upload after new API framework. Also added a check to avoid system created templates and ISO's from getting extracted as per Mike.
...
status 4286: resolved fixed
2010-11-04 19:09:38 +05:30
will
f907e370d1
- Added the rest of the VPN UI feature with the exception of displaying the preshared key.
...
- AddVpnUserCmd will now return the embedded object.
- Fixed RemoteAccssVpnResponse to return "iprange" instead of "ipRange"
2010-11-03 22:24:22 -07:00
abhishek
84ee08430a
making changes to the list zones flow, to add the domain name to the table, and return it
2010-11-03 22:08:32 -07:00
Alex Huang
9bb05d3ef8
harmony amongst joins
2010-11-03 21:18:31 -07:00
Alex Huang
e27bb550fe
Harmony among gurus
2010-11-03 21:18:31 -07:00
Jessica Wang
3deb7580bb
Create Disk Offering - make disksize optional
2010-11-03 19:48:35 -07:00
abhishek
2303afe55c
making changes for disk offerings with a new column called customized being added, for the UI to cosume whilst deploying vm with an arbitrary volume size. The UI will use this value to set the right size and the offering will ensure the right tags are taken.
2010-11-03 17:45:52 -07:00
alena
2939e90d66
Build response the same way for create/list/update IPForwardingRule.
2010-11-03 15:49:51 -07:00
abhishek
7674df6c7a
fixing the merge conflicts
2010-11-03 15:39:16 -07:00
abhishek
46497e3aad
making changes for the private/public zones enhancement, for the UI to consume. The list method has been changed to return visible zones based on the user's credentials, or if the domainId for private zone listing is specified. In the update zone cmd, we do not allow updating private zone once it has been associated with a domain. This might change in the coming releases.
2010-11-03 15:39:16 -07:00
alena
6bd87ca161
Return "status" field in StoragePoolResponse. Status can be Up, Maintenance, ErrorInMaintenance
2010-11-03 14:59:00 -07:00
alena
52a8370102
bug 6955: return embedded object for PreparePrimaryStorageForMaintenance
...
status 6955: resolved fixed
2010-11-03 14:30:35 -07:00
Chiradeep Vittal
e1cb94831f
VPN users feature complete
2010-11-03 14:02:13 -07:00
Chiradeep Vittal
0dd19c197b
VPN users API -- WIP
2010-11-03 14:02:13 -07:00
Chiradeep Vittal
14613415e1
VPN users API -- WIP
2010-11-03 14:02:13 -07:00
Chiradeep Vittal
b6d3b3c184
users for vpn -- data model
2010-11-03 14:02:12 -07:00
alena
4a645cdeb0
Return embedded Volume object for create/attach/detach Volume commands.
2010-11-03 13:07:06 -07:00
alena
8c0e2fa7ec
Fixed updatePod Api to return embedded object instead of "success" response
2010-11-03 11:18:51 -07:00
alena
886fd4e754
More api refactoring - move response building for LoadBalancer/IpAddress commands to ApiResponseHelper.
2010-11-03 10:11:59 -07:00
alena
ebdc1f069d
1) Return embedded Host object in PrepareForMaintenance command.
...
2) Build HostResonse object in ApiResponseHelper for add/reconnect/update/prepareForMaintenance/cancelMaintenance commands
2010-11-02 20:30:41 -07:00
alena
abb8f45667
1) Return embedded object for upgradeRouter command
...
2) Build response objects in ApiResponseHelper for stop/start/reboot/list router/systemVm commands
2010-11-02 19:47:14 -07:00
Alena Prokharchyk
694a8231ef
Build responses in ApiResponseHelper for the deploy/start/stop/reboot/recover/listVm create/list snapshot/snapshotPolicies
2010-11-02 18:16:45 -07:00
abhishek
c6809f89d4
bug 6890: preventing users from searching for system account details via the list api
...
status 6890: resolved fixed
2010-11-02 17:59:24 -07:00
alena
571ca42c44
1) Return embedded object for addCfg/updateCfg/listCfg.
...
2) Fixed NPE in updateCfg command (used to happen when no value was specified)
3) Fixed addCfg command to call correct getName method while setting config name (used to call the method returning the command name)
2010-11-02 15:26:33 -07:00
Alex Huang
5fe5450abc
even more refactoring
2010-11-02 15:25:07 -07:00
abhishek
d4b33f523d
bug 5190: changes from the ui perspective; we upload the entire cert as a string, instead of reading it from a file. Then, we process the cert via ip streams instead of fileinputstreams. Moved the cert validation to before cert persistance, and also added more logging and exception catch blocks to deal with IO exceptions that might arise out of the ip stream processing for the new change.
2010-11-02 14:48:05 -07:00
alena
0c044a10d1
Moved response building for ServiceOffering/ResourceLimit commands to ApiResponseHelper class.
2010-11-02 11:59:10 -07:00
abhishek
85f78d8cb3
bug 6886: fixing the npe which occurs when we try to delete a non existant user. We were trying to return user details for an async job desc assuming the user always existed. Changing that logic to ensure when we don't have such details, we log the apt message
...
status 6886: resolved fixed
2010-11-02 11:20:52 -07:00
alena
6c3256d1e4
1) Return embedded objects for enable/disable/lock/update Account/User and updateDomain
...
2) Added "haschild" return parameter to Domain response.
3) Fixed updateDomain command - used to set domainname to "updatedomainnameresponse" value if no name was specified in the request. Added more logging for updateDomain command.
2010-11-01 23:49:57 -07:00
alena
5d4e4be974
1) Created ApiResponseHelper class - all api response objects should be built there.
...
2) Removed isMirrored tag from the update/create/listDiskOffering commands
2010-11-01 23:49:57 -07:00
abhishek
45f4499c14
bug 6836: fixing the api responses for disk offerings. We were using the wrong objext name, and were only returning success responses. Now, we are constructing the apt object and returning the entire object back.
...
status 6836: resolved fixed
2010-11-01 13:24:28 -07:00
abhishek
f70b55daa2
bug 6380: removing the code which returns hostid and hostname, as on a stopped vm, we do not have any association of the vm to the host
2010-11-01 12:16:53 -07:00
root
bee976b5f5
bug 6779: returning the deviceId wherever possible, in the xxxVolume() calls
...
status 6779: resolved fixed
2010-11-01 11:12:03 -07:00
Chiradeep Vittal
1e0eb04442
Add VPN apis, some systemvm changes for vpn
2010-11-01 10:27:49 -07:00
abhishek
c74fd77730
putting in final comments, so that the code to be checked in is better readable for others trying to understand it
2010-11-01 09:06:32 -07:00
abhishek
362e67d724
adding failover protection case for when the mgmt svr crashes in the middle of executing something; along with custom response for cert
2010-11-01 09:04:51 -07:00
root
3752a4eb31
making the logic more robust, testing more corner cases, improving efficiency and changing the schema
2010-11-01 09:04:51 -07:00
kishan
3a0f30a049
bug 6408: remove security groups/port forwarding service in virtual network case
...
status 6408: resolved fixed
2010-11-01 14:28:03 +05:30
Kris McQueen
24551eea3a
Add constants for API command parameter names and for API response parameter names. Update the commands with the new constants rather than custom strings. Update several of the responses with the constants. Not all the responses have been updated, this is still work in progress...
2010-10-29 17:20:40 -07:00
Kris McQueen
a9349cb815
bug 6857: if the dispatcher recieves an IllegalArgumentException, bubble that up to the response so the caller gets a useful message
2010-10-29 14:07:23 -07:00
Kris McQueen
88dac13bb0
use the API response date format when serializing response objects
2010-10-29 13:23:29 -07:00
will
9cc5aaa978
Fixed listTemplates to use the template type.
2010-10-29 13:17:32 -07:00
Kris McQueen
ebac4539d0
it's possible createSnapshotDB will return null, handle that case. However, if createSnapshotDB returns null because there was no work to do (empty snapshot) we should probably throw an exception that reports that fact instead of returning null and throwing an internal error
2010-10-28 17:52:37 -07:00
Kris McQueen
642b8a56f4
If the create command returns null for whatever reason, throw an exception so it aborts scheduling the async job to act on the created object
2010-10-28 17:52:37 -07:00
Kris McQueen
2f9e91a9ae
bug 6738: honor groupid when listing vms (restrict the list to just that group)
...
status 6738: resolved fixed
2010-10-28 16:27:07 -07:00
Kris McQueen
7531525252
Add commented code out for the old style (2.1.x) JSON async job responses. The XML responses are still a TODO. In order to get this to fully revert back to 2.1.x style responses, some commands will need to be modified to set the responseName to be something like getResultObjectName(), and there's an example of this in StopVMCmd.
2010-10-28 14:32:13 -07:00
Kris McQueen
9eb851db60
bug 6809, 6712: standardize the domain router response to use guestmacaddress instead of macaddress
...
status 6809, 6712: resolved fixed
2010-10-28 14:32:13 -07:00
will
c5fef26f11
ListTemplates will no longer return any SystemVM templates. I am using a startsWith() string match for now since we used to make this comparision by ID with a single hypervisor.
2010-10-28 13:28:33 -07:00
will
f0a4449ec3
ListTemplates now return the hypervisor type.
2010-10-27 19:50:36 -07:00
Kris McQueen
50c175d6c1
bug 6799: forgot to add the exception response in my commit for this bug...
2010-10-27 18:23:23 -07:00
Kris McQueen
9056653e17
Change the API Implementation annotation to use the manager's class rather than an enum. This allows methods for new managers to be added trivially rather than having to modify the dispatcher to load a new manager class.
2010-10-27 12:23:31 -07:00
Kris McQueen
ae9b6d4fe1
bug 6776: for some reason, we checked for zoneId = -1 in registerTemplate and applied it to all zones, but this wasn't done for registerIso. Oh well, make the change for registerIso and things seem happy again
...
status 6776: resolved fixed
2010-10-26 17:55:00 -07:00
Kris McQueen
a788d2cb2e
bug 6736: rebootSystemVm should return the vm properties, not success true/false.
...
status 6736: resolved fixed
2010-10-26 17:19:55 -07:00
Kris McQueen
95da86ef1a
bug 6733: re-throw ServerApiExceptions when dispatching API commands rather than logging them and throwing a generic INTERNAL_ERROR exception
...
status 6733: resolved fixed
2010-10-26 16:54:42 -07:00
abhishek
c6588c0e25
adding some error return handling to api dispatcher, and cleaning up some of the code paths to return the right error messages
2010-10-26 14:27:26 -07:00
alena
afd79a9b1b
Code cleanup
2010-10-26 13:59:11 -07:00
Alex Huang
f58063911e
deploy vm completed
2010-10-26 09:35:24 -07:00
nit
497c60d63d
Extending extract functionlity for volumes to allow download. The
...
extraction can have two modes FTP_UPLOAD and HTTP_DOWNLOAD. In the former one
the user would provide the ftp url where the entity needs to be uploaded and in
the later the user would be provided a HTTP URL where from he/she can download
the entity. This url would be exposed for a specific time limit and would not
function after the time limit
2010-10-26 18:49:43 +05:30
Kris McQueen
b3c7821b44
bug 6752: fix updating resource limits for a domain by looking at the given accountName/domainId parameters rather than looking at the caller's account. If updating limits for an account, e.g. account 'foo' in domain 4, then execute updateResourceLimit&account=foo&domainid=4&..., but if updating the limit for a domain, don't specify the account parameter. When processing the command, if accountName is null, the limit for the domain will be properly updated.
...
status 6752: resolved fixed
2010-10-25 17:32:28 -07:00
Kris McQueen
ef131bbc18
bug 6724: set useVirtualNetwork in the createServiceResponse
...
status 6724: resolved fixed
2010-10-25 17:08:47 -07:00
Kris McQueen
f9c1f12778
bug 6725: use serviceOfferingName rather than the API command name when updating the service offering; set memory in the response for UpdateServiceOffering
...
status 6725: resolved fixed
2010-10-25 17:08:47 -07:00
Kris McQueen
27cafb2957
bug 6727: ostypename was being set from guest_os.name which seems to be null most of the time. Instead, use guest_os.display_name.
...
status 6727: resolved fixed
2010-10-25 17:08:47 -07:00
Kris McQueen
fcb0ff83ac
bug 6712: for router responses, change guestmacaddress -> macaddress to preserve behavior from 2.1.x and before.
...
status 6712: resolved fixed
2010-10-25 16:37:42 -07:00
Kris McQueen
869f3587c3
bug 6714: add displaytext to SuccessResponse so commands that return success true/false can also return a brief description of what took place.
...
status 6714: resolved fixed
2010-10-25 16:37:42 -07:00
Kris McQueen
3660d6a3d1
bug 6717: updateDiskOffering is supposed to return success true/false rather than the updated disk offering
...
status 6717: resolved fixed
2010-10-25 16:37:42 -07:00
Kris McQueen
c8e9531842
bug 6720: add 'created' to the ListHosts response
...
status 6720: resolved fixed
2010-10-25 16:37:42 -07:00
Kris McQueen
83e4922b94
bug 6703, 6704: use the correct method signatures for invoking updateTemplate/updateIso and updateTemplatePermissions/updateIsoPermissions APIs. It's possible that the reflection should just use 'isAssignableFrom' when getting methods since the manager methods were using a base class as the parameter rather than UpdateTemplateCmd/UpdateIsoCmd and UpdateTemplatePermissions/UpdateIsoPermissions, but for now the explicit methods are added for simplicity.
...
status 6703, 6704: resolved fixed
2010-10-25 15:01:50 -07:00
Kris McQueen
d229877cd8
bug 6710: rebootRouter was supposed to return the rebooted router, not success/failure
...
status 6710: resolved fixed
2010-10-25 15:01:50 -07:00
Kris McQueen
18f6d67121
bug 6705, 6708: use the UserVmResponse for changeServiceForVirtualMachine API (UpgradeVMCmd) since the response is a vm. There was no need for a specific UpgradeVmResponse which had scalars instead of objects and the serializer skips null, but will serialize scalars with their default values, in this case 0 for id and host id.
...
status 6750, 6708: resolved fixed
2010-10-25 15:01:49 -07:00
nit
511a095c26
bug 6487: AttachISO API would return an embedded object on success.
...
status 6487: resolved fixed
2010-10-25 18:26:39 +05:30
nit
5774fd163d
bug 6480: detachVolume API would start returning an embedded object, like attachVolume API does.
...
status 6480: resolved fixed
2010-10-25 17:19:22 +05:30
nit
554e360d21
Fixing a typo in the HostResponse of the word custer.
...
Fixing the names of the ISO and templates.
2010-10-25 14:54:49 +05:30
nit
035810d60a
bug 6481: embedded object returned by attachVolume API would have the "type" property indicating the volume type of the disk volume (ROOT or DATADISK)
...
status 6481: resolved fixed
2010-10-25 14:14:40 +05:30
kishan
3530daf3ff
bug 6697: make resourcetype optional
...
status 6697: resolved fixed
2010-10-25 12:22:06 +05:30
Jessica Wang
958aaaaf87
new UI - instance page - refactor submenu.
2010-10-22 20:23:05 -07:00
Kris McQueen
e6f7a480ae
bug 6674: Fix VM responses
...
- ostypeid -> guestosid
- findRootVolume is now in ApiDBUtils (from mgmt server) since it's for API responses only
- add rootdeviceid and rootdevicetype to various VM respones (listVirtualMachines, deployVirtualMachine, start/stopVirtualMachine)
status 6674: resolved fixed
2010-10-22 13:57:03 -07:00
Kris McQueen
4a96e1f633
bug 6662: handle a null ip forwarding rule in the API response as 'the rule already exists' since other errors will result in thrown exceptions. Also, fix up detection of network conflicts and duplicate rules by adding a list of used protocols to the port mappings
...
status 6662: resolved fixed
2010-10-22 11:47:52 -07:00
Alex Huang
f1a431714c
checkin to fix windows
2010-10-22 09:19:53 -07:00
anthony
18ffd7e7a8
fixed build
2010-10-21 19:25:52 -07:00
NIKITA
2f70032972
conflict
2010-10-21 17:57:56 -07:00
Alex Huang
25e4ed6997
more changes in the api
2010-10-21 16:53:42 -07:00
abhishek
a957a679ed
bug 5190: modifying a few minor details in the upload cert part, to conform with the new api refactor design
2010-10-21 15:51:46 -07:00
Kris McQueen
365ac7501f
bug 6672: Fix up volume commands. For createVolume, the command is supposed to create a database object, but not assign it to a storage pool until the user first attaches it to a vm instance. That allows the volume to start off hypervisor agnostic. For attachVolume, detachVolume, and listVolumes, the responses had minor issues (sourceType could be null, for example) in either the response generation, or the response handling by the UI.
...
status 6672: resolved fixed
2010-10-21 15:15:01 -07:00
Alex Huang
d5d8f27cad
Added more changes to the api
2010-10-21 15:11:49 -07:00
abhishek
9a9146c07b
whilst testing my enh, found that this call was using the wrong method name. Checking in the fix for the same.
2010-10-21 11:43:06 -07:00
abhishek
2b9ab00cc2
bug 3386: first part of the checkin, wherein we have an optional param domainId for create and modify zones. If this domain exists in the system, then the zone is tagged with this domain id, so that subsequent calls are checked for sanity against this domain.
2010-10-21 11:43:06 -07:00
kishan
bec09a4323
bug 6486: added VirtualMachine to stopVm response
...
status 6486: resolved fixed
2010-10-21 14:52:27 +05:30
nit
b7d430cf86
bug 6399: deployVirtualMachine API should return an embedded object (named "virtualmachine").
...
status 6399: resolved fixed
2010-10-21 13:48:29 +05:30
kishan
fa4a16cb68
bug 5592: Added configurable domain for hosts.
...
status 5592: resolved fixed
2010-10-21 11:51:09 +05:30
nit
6723549fc7
bug 6399: extending extract functionlity for templates and ISO's to allow download. The extraction can have two modes FTP_UPLOAD and HTTP_DOWNLOAD. In the former one the user would provide the ftp url where the entity needs to be uploaded and in the later the user would be provided a HTTP URL where from he/she can download the entity. This url would be exposed for a specific time limit and would not function after the time limit.
2010-10-20 11:40:03 +05:30
Kris McQueen
2bd5b6a29e
bug 6654: virtualmachinename should be serialized as vmname, fix handling of the createPortForwardingRule response
...
status 6654: resolved fixed
2010-10-19 15:59:37 -07:00
abhishek
7c11c04427
reverting the change for bug 6361; this was an accidental push instead of commit
2010-10-19 15:21:01 -07:00
abhishek
7cc8087fa6
bug 6361: more name changes from network group to security group
2010-10-19 15:21:01 -07:00
abhishek
523862f571
bug 6361: further name changes from network to security group
2010-10-19 14:35:17 -07:00
abhishek
6bd7caa9c2
bug 6361: first part of incremental checkin to rename network group to security grou[
2010-10-19 14:35:17 -07:00
Kris McQueen
0267a306c8
bug 6649: when listing domains, accept -1 as 'list all.' Fix listDomainChildren response to return haschild, handle haschild as a boolean rather than a string.
...
status 6649: resolved fixed
2010-10-19 13:49:00 -07:00
abhishek
04c8c0f91c
bug 6041: returning the complete embedded reponse for a destroyvm async call
...
status 6041: resolved fixed
2010-10-19 11:46:42 -07:00
Kris McQueen
f4f00cbe2d
bug 6655: when verifying request signature for API requests that use keys, pass the userId of the requester as a Long to avoid NPEs when converting it to a string. Also set up the UserContext for both normal users and admins.
...
status 6655: resolved fixed
2010-10-19 11:41:09 -07:00
abhishek
408822e358
bug 6037: last part of the checkin for this bug
...
status 6037: resolved fixed
2010-10-19 11:36:54 -07:00
abhishek
89e9a85902
bug 6037: adding response obj of type uservmmanager to recovervm response
2010-10-19 11:00:23 -07:00
Chiradeep Vittal
947c2ca16d
fix problems in api post-refactor
2010-10-19 09:53:51 -07:00
alena
bb5399c2bc
Fixed PodResponse: endip is all lowercase now.
2010-10-18 14:11:21 -07:00
Kris McQueen
603874605d
The serialized names for the old VIRTUAL_MACHINE_* constants weren't quite right. Fix these up. This is a good example for why there needs to be a pass through the API commands and responses and constants should be used in the annotations rather than the current strings that are in place.
2010-10-18 14:10:07 -07:00
Kris McQueen
3be625ca6e
The stopVirtualMachine API should return the vm instance rather than a boolean indicating success. The response for async jobs is now under the jobresult property of the JSON response, handle the start/stop virtual machine responses using data from the jobresult rather than expecting some embedded object.
2010-10-18 11:15:07 -07:00
edison
e41729cc43
fix rpm build
2010-10-16 01:03:31 -07:00
Kris McQueen
88814d95f0
A zoneId of -1 means all zones, so if zoneId is passed in as -1 just list all zones for registering the template
2010-10-14 19:11:21 -07:00
Kris McQueen
d928a6f3d9
If storage pool is null after adding a pool, throw an exception so the user sees a problem adding the pool. This is better than the NPE that was happening...
2010-10-13 16:08:49 -07:00
Kris McQueen
5960911511
Fix processing of session parameters in logout case
2010-10-12 19:42:53 -07:00
Kris McQueen
8e086d7a21
resolving merge conflicts between 2.1.refactor and master
2010-10-12 16:28:16 -07:00
Kris McQueen
0f4a245f0a
resolving merge conflicts before pushing to the remote repository
2010-10-12 15:37:50 -07:00
Kris McQueen
2740ba6c40
final merge of master->2.1.refactor preparing for merge back into master
2010-10-12 14:46:24 -07:00
alena
fb50fe624c
* Added descriptions for Api command's request and response parameters.
...
* Changed response type for DeleteDomain and DeletePreallocatedLun commands to SuccessResponse
* Implemented small tool (ApiXmlDocReader) for comparing api commands of different product versions.
2010-10-11 09:21:42 -07:00
anthony
2861895a84
bug 6450: list all snapshot for admin
...
status 6450: resolved fixed
2010-10-07 15:35:58 -07:00
Kris McQueen
7c4a06a764
fix the method name for listIsos command
2010-10-07 15:10:02 -07:00
Kris McQueen
e18895f15b
account and domainid are required parameters when disabling an account
2010-10-07 15:09:28 -07:00
Kris McQueen
bef7998bbf
resolving merge conflicts between the documentation changes and other API refactoring work
2010-10-07 15:07:49 -07:00
Kris McQueen
335613a8a9
Add the mirrored property to the disk offering response
2010-10-07 15:03:47 -07:00
alena
e7b478f43d
Added descriptions for Api commands and corresponding requrest parameters
2010-10-07 14:46:29 -07:00
Kris McQueen
fbb5a109cc
Fix return types for resetVmPassword and upgradeVirtualMachine commands. Fix response for resetVmPassword to be a vm rather than success/failure. Make sure the password is a transient variable for the resetVmPassword command so that the new password is returned to the user.
2010-10-06 18:29:27 -07:00
Kris McQueen
9c593352d0
Fixing events for async jobs so that there's a scheduled event recorded with appropriate type/description whenever the API framework schedules the async command to run. A few miscellaneous fixes as well uncovered during regression testing (router response was not parsed correctly by UI, etc.)
2010-10-05 20:26:18 -07:00
edison
1cd370fc36
hypervisor type for deployvmCmd is optional, only deploying blankvm
...
needs it.
2010-10-05 09:52:06 -07:00
nit
f7f2b5666a
bug 5871: removing the NDC since there is no nested context involved in the audit trail and since its leaking into the management server logs.
2010-10-05 19:51:12 +05:30
edison
8db5a1a1e2
add Copyright for new file
2010-10-04 17:05:41 -07:00
edison
aaaa5dc3ad
bug 6379: add ListHypervisors cmd to list all the supported hypervisors.
...
status 6379: resolved fixed
The supported hypervisors are controlled by hypervisor.list in configuration table
2010-10-04 16:55:25 -07:00
edison
1877200575
missing to add the new file
2010-10-04 14:57:14 -07:00
Kris McQueen
24bd6a39e6
Fix the type of the id attribute in BaseAsyncCmd (it should be Long), deleteNetworkRuleConfig is async command again (this was a regression), misc event and account verification fixes
2010-10-04 10:36:44 -07:00
alena
136060e5cf
1) Finished XmlApiDoc writer. The program gets api classes from commands.properties.in file, and build Command objects with "name"/"description"/"request"/"response" fields. Request and response are represented by the list of arguments, each argument contains "name"/"description"/"isrequired" fields. The commands are being serialized to commands.xml using imported xstream library, and can be desiarialized later - it will help to compare commands from differemt product versions.
...
2) Added description() methods to Implementation and Param annotations.
2010-10-04 09:50:14 -07:00
alena
46a433d750
Incremental checkin for ApiXmlDocBuilder
2010-10-04 09:50:14 -07:00
nit
38fd80e522
bug 5871: Introducing audit trail for all the interactions with the cloud stack - User 'X' initiated an action 'Y' on resource 'Z'. The audit will contain http api request along with the contextual parameters (userId, accountId, sessionId). For the response part only log success/failure for all sync api's with the exception of queryAsyncJob where reason code and reason will also be logged. For async api's I will also log the async job id.
2010-10-04 14:27:40 +05:30
edison
3aa34687f5
set hypervisor type to be manadatory for deployvm and registertmplt API
2010-10-01 15:15:01 -07:00
Kris McQueen
41a16a478a
Fixes required for regressions found running automated tests. (1) method signatures that weren't properly refactored to new API framework (2) API request parameter types should always be specified lest they default to String which may or may not be desired (3) better exception handling with regard to Queued commands and generic exceptions (4) fix eventing to pass the proper accountId where neccessary
2010-10-01 14:11:18 -07:00
Kris McQueen
5f2acc8cdd
Fixing API responses for user VMs (we need to return ipaddress rather than privateip) and domain routers (guestMacAddress != guestmacaddress for case sensitive string comparison)
2010-09-30 14:22:10 -07:00
edison
26807bc701
bug 6362: Need to call guestos.getDisplayName to the guest os name now.
...
status 6362: resolved fixed
2010-09-30 12:26:37 -07:00
Kris McQueen
bc2449a69a
If the session in invalidated due to a bad session key, just return to avoid the situation where the session is invalidated twice (which causes IllegalStateException)
2010-09-30 11:39:36 -07:00
edison
58c430f7d7
add xenserver specific configruation back
2010-09-29 18:48:26 -07:00
edison
ad1ef80459
Now we have multiple routing template and buitin templates now, refactor template download code, that can handle it.
...
Basically, change the meaning of type field in template table: SYSTEM means sytem vm template, BUILIIN means buildin templates.
2010-09-29 18:41:55 -07:00
edison
6fc7528809
create data volume is splitted into two stage:
...
1. create a volume entry in the database,
2. when user attaching the volume to a VM, then actually create the volume on storage pool.
2010-09-29 18:41:54 -07:00
edison
964f8f1fe3
fix boot from iso
2010-09-29 18:41:54 -07:00
edison
d98d6cbb9f
fix template download, listguestos type
2010-09-29 18:41:53 -07:00
edison
baeb1af265
fix register template hypervisor type
2010-09-29 18:41:53 -07:00
edison
b8c1d2ea17
set external ipallocator as true by default
2010-09-29 18:40:52 -07:00
edison
9e0f57bc0e
change code for new UI
2010-09-29 18:40:52 -07:00
edison
8943cc6745
create volume
...
Conflicts:
api/src/com/cloud/vm/VmCharacteristics.java
core/src/com/cloud/dc/ClusterVO.java
core/src/com/cloud/server/ManagementServer.java
server/src/com/cloud/network/NetworkManager.java
server/src/com/cloud/storage/allocator/AbstractStoragePoolAllocator.java
2010-09-29 18:40:51 -07:00
Kris McQueen
0105aec338
Always set the response type on the command object so that the correct output is generated. Add both Strings and Longs to the login response (domainId and userId will be the Longs). Use the correct method name for ListSystemVMsCmd.
2010-09-29 17:32:19 -07:00
anthony
be5fa82229
remove snapshotpolicyRef
2010-09-29 16:24:57 -07:00
Kris McQueen
da660f2575
Change session parameters to be their actual type (domainId and userId are saved to the session as Longs and not Strings)
2010-09-29 15:18:43 -07:00
Kris McQueen
9e2d1f5e70
Refactoring disableUser and disableAccount to new API framework (they are both async commands).
2010-09-29 13:57:26 -07:00
abhishek
cd42fcc1bf
some code refactoring
2010-09-29 11:17:42 -07:00
kishan
9e87534e42
bug 6216: Added Id to listAlerts response
2010-09-29 15:52:13 +05:30
Kris McQueen
95a7f20a0a
Adding in XML response serializing. Now the new API framework supports both XML and JSON responses the way the old framework did.
2010-09-28 17:36:27 -07:00
Kris McQueen
848ce60097
Merging master into 2.1.refactor, resolve the merge conflicts as best I can. New commands related to extracting template/iso/volume and related to instance groups were refactored to the new API framework.
2010-09-28 15:47:14 -07:00
nit
122b15071d
bug 6334: Correcting the syntax of json data when the response is empty.
...
status 6334: resolved fixed
2010-09-28 14:46:44 +05:30
alena
9b10074c2a
Added missing license info to the bunch of files
2010-09-27 19:08:03 -07:00
abhishek
ad4ea90207
bug 5190: enhancing some of the error messages returned to be more intuitive
2010-09-27 17:01:01 -07:00
abhishek
677d8894ea
bug 5190: modifying the api calls
2010-09-27 16:49:34 -07:00
abhishek
1356f5f33a
bug 5190: incremental checkin, code cleanup
2010-09-27 16:46:14 -07:00
abhishek
060dfc2cf9
bug 5190: incremental checkin
2010-09-27 16:39:32 -07:00
alena
49143dbe4a
Remove user vm from instance_group when empty string is passed as value for "group" parameter in updateVirtualMachine API.
2010-09-27 14:24:08 -07:00
nit
b857a9b4c8
bug 4177: registerTemplate/registerIso commands would start accepting account/domainId params.
...
status 4177: resolved fixed
2010-09-27 17:24:23 +05:30
nit
26fc22160c
bug 5871: Correcting the ostypeid and ostypename returned by the listIsos
2010-09-27 12:10:49 +05:30
Kris McQueen
62257d4021
Fix serializing async job responses by writing a custom adapter for ResponseObjects. Improve exception handling when calling async commands (the job still needs to complete, but with FAILED status).
2010-09-24 13:52:35 -07:00
Kris McQueen
2a4ddac41a
Change getResponse() to return a ResponseObject so that the caller can choose how to serialize. This in in preparation for serializing the async commands to the database with class information and deserializing them into the ResponseObject itself when queryAsyncJobResult is called. Once the ResponseObject is deserialized, the proper string can be returned to the caller.
...
The previous behavior had the JSON response from the command embedded into the queryAsyncJobResult response as a string rather than a JSON object which prevented the client from being able to read the response. With this new behavior an actual JSON object should be returned which can then be parsed on the client side.
2010-09-23 17:34:28 -07:00
abhishek
320df380c9
bug 6217: incremental fix for the vm api
...
bug 6217: resolved fixed
2010-09-23 14:56:25 -07:00
abhishek
e0dcb95511
bug 6217: incremental checkin
2010-09-23 14:55:13 -07:00
abhishek
703c182f8f
bug 6222: removing non needed attribs
...
status 6222: resolved fixed
2010-09-23 10:32:42 -07:00
abhishek
32884572b9
bug 6241: incremental checkin
2010-09-22 15:32:42 -07:00
nit
fd86e976b6
bug 6249, 6250: listDiskOfferings API - adding createed date tag and removing ismirrored tag.
...
status 6249, 6250: resolved fixed
2010-09-22 15:08:14 +05:30
Kris McQueen
c26426c7c7
Throw an exception when the dispatcher can't find the implementation for an API command.
2010-09-21 18:26:57 -07:00
Kris McQueen
e31f89e6a9
Set up accountId in the AsyncJob since it's needed for proper validation when querying the job status.
2010-09-21 18:26:34 -07:00
Kris McQueen
8161078803
QueryAsyncJobResult was missing an implementation and had 'id' as the parameter when it should have been 'jobid'.
2010-09-21 18:25:35 -07:00
Kris McQueen
c32d6e7524
Template id is not a required parameter when listing templates. The proper serialized name for the async job id is jobid, not id. Sadly, ctxAccoutId != ctxAccountId, ugh, no wonder the UserContext wasn't getting set up correctly. Clean up some miscellaneous unnecessary casts.
2010-09-21 17:00:50 -07:00
Kris McQueen
5a3f4af638
AddHost and AddSecondaryStorage have different required parameters, so avoid subclassing these commands and just call a common method in the agent manager. Fix the response name for listAccounts. CreateUser returns one user, so don't always get response.user[0] since that's pointless. A secondary storage host does not have a pod id (NfsSecondaryStorageResource) so make sure not to dereference variables that will be null.
2010-09-21 16:28:31 -07:00
abhishek
122b0d1aeb
bug 6243: adding a check to return an error in case we have a null domain id for a non null account
...
status 6243: resolved fixed
2010-09-21 15:50:49 -07:00
abhishek
d07cac932a
bug 6165: there is a possiblility of the root volume being null when we search for it, which may be causing a npe in this bug. enhancing the logic around this
...
status 6165: resolved fixed
2010-09-21 15:17:21 -07:00
abhishek
37870da95f
bug 3120: incremental fix
2010-09-21 14:47:51 -07:00
nit
87f1a96c29
bug 6214: UpdateIso API - Adding account and domain tags.
2010-09-21 16:17:48 +05:30
nit
0669c2c1d4
Merge branch 'master' of ssh://git.cloud.com/var/lib/git/cloudstack-oss
2010-09-21 13:37:47 +05:30
nit
7ff551bd5c
bug 4286: Extract functionality - code cleanup
2010-09-21 13:36:57 +05:30
Kris McQueen
ebd06ae6f3
List clusters was using the name of the command rather than the name of the cluster to search for clusters, which was resulting in no clusters returned. Fixed. CreateStoragePool was returning an array of one pool every time, simplified it to just return the pool and changed the UI to expect one pool rather than an array. Fixed the backend code for creating a storage pool to (a) generate a UUID based on host name, path, and a timestamp and (b) to list only active storage pools when checking for duplicates. This allows a storage pool to be create with the same path as a pool that had previously been deleted.
2010-09-20 19:08:52 -07:00
Kris McQueen
1a54c52d5e
Change the annontations for response objects to use the GSON annotations for the property name written to the response
2010-09-20 17:47:56 -07:00
Kris McQueen
12ef5106b6
Fixing serialization of JSON responses to handle both regular objects and list-style responses. Add missing managers to API dispatcher. Fix a typo in listAlerts command implementation method. Add signatures for various add host/storage APIs.
2010-09-20 15:20:32 -07:00
abhishek
a9c96b4da0
bug 3120: incremental checkin
2010-09-20 14:54:06 -07:00
abhishek
437f717633
bug 3120: incremental checkin
2010-09-20 14:54:06 -07:00
kishan
9393ad410e
Merge branch 'master' of ssh://kishan@git.cloud.com/var/lib/git/cloudstack-oss
2010-09-20 15:12:55 +05:30
kishan
b606d14396
Bug 5904: Included version in API header
2010-09-20 15:00:57 +05:30
nit
a39fad5da4
bug 3384: listVolumes: allowing regular user to make a search by "type".
...
status 3384: resolved fixed
2010-09-20 13:09:33 +05:30
nit
33e683e2c7
bug 4286: Making ExtractVolumeCommand async and some code cleanup
2010-09-19 18:34:12 +05:30
nit
1a30ffbdc0
bug 6055: createDiskOffering API - removed isMirrored and domainId parameters.
...
status 6055: resolved fixed
2010-09-19 16:13:13 +05:30
Kris McQueen
e2e0e76063
More work on serializing responses. Now responses have to have the name set on them, and the name will eventually be serialized to the JSON/XML response the way it used to work for commands themselves [the result of cmd.getName() was written to the response string]. For list respones, we wrap the individual objects in a ListResponse object that has the name of the response, and the individual objects have the object name so that accounts will be something like <listaccountsresponse><account><...></account><account><...></account></listaccountsresponse>.
2010-09-17 17:13:04 -07:00
abhishek
1a37b661c7
code cleanup
2010-09-17 17:06:19 -07:00