For VMs which have service offering that does not allow HA, haenable option will be not shown in the UpdateVM UI form.
Fixes#5743
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
* fix new UI missing 4 parameters when adding a BareMetal host
* remove test options
* add rule for hosttag with baremetal
* fixes password not provided
* Enable resetting config values to default value
Provide reset button to zone,cluster,domain,account,
primary and secondary storage so that config values
can be reset to default value
* fix ui issue
* Update test/integration/smoke/test_reset_configuration_settings.py
* Update test/integration/smoke/test_reset_configuration_settings.py
Co-authored-by: Rakesh Venkatesh <rakeshv@apache.org>
Co-authored-by: dahn <daan.hoogland@gmail.com>
Related to PR #5549 changed the notification from $notification to $showNotification. This PR aims to change it back to the way it was for easier use while keeping the delete all button.
* ui: fix add network offering for vpc
Fixes issues with form related to supported services provider and router service offering when offering to be created for VPC.
Fixes#5807
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
* fix issues getting with making select element update on options change (loop infinity) (#72)
* fixes
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Co-authored-by: Hoang Nguyen <hoangnm@unitech.vn>
* add clear all notification button
* change position set count notify
* get notification count
* set label transliteration
* add margin for notification
* change position of clear notification button
This PR fixes#5623.
Also, some more information that is not present in the issue in question:
Although the proxy console access button does not appear in the UI, users with access permission to the VM in question have access to the console as well. Simply generate the console access link using another user, copy that link, and, on the user without access to the console button, type that link.
Co-authored-by: SadiJr <sadi@scclouds.com.br>
* add footer text option for login screen
* using single key for policy
* set empty for default policy text
* rename footer text key
* rename the footer text property name
* change position avoid breaking with docHelp
* change position of properties
In the UI, when selecting a service offering that has a root disk enforced, stills show the root disk size of the template (or the custom size gave by the user). This PR fixes this issue, that thas been reported in #5777.
Fixes: #5777
* ui: prevent incorrect tags displa for primary storage
Tags in info card of the UI are related to tags functionality(create/delete/lsitTags API)
UI was incorrectly showing storage tags as these tags in the UI.
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
* remove logging
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
* ui: show tags only for supported resources
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
* conditional broadcastUri
* add filter to keep order and apply to details as well
* use global isAdmin method
Co-authored-by: Daan Hoogland <dahn@onecht.net>
Better forms in UI for migrating VMs and volumes.
- Show option to migrate with storage while live migrating a VM
- For VM storage migration (stopped VM), allow migrating volumes to specific primary storages
- Show primary storage details in migrate volume form
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
* ui-primary-storage: hide provider if Linstor protocol
If Linstor protocol is selected it makes no sense to show other
providers as Linstor only works with the Linstor provider.
This was removed with the fix for #5613, that probably resulted from a
bad merge resolving from my part.
* ui-wizard: set correct provider for Linstor protocol
* Updating pom.xml version numbers for release 4.17.0.0-SNAPSHOT
Signed-off-by: nicolas <nicovazquez90@gmail.com>
* Fix build and version numbers
* SSL Certificates 버튼이 작동하지않는 버그
SSL Certificates 버튼이 작동하지않는 버그
* Revert "Updating pom.xml version numbers for release 4.17.0.0-SNAPSHOT"
This reverts commit e4dba9fb95.
* Revert "Fix build and version numbers"
This reverts commit fd6161a9df.
Co-authored-by: nicolas <nicovazquez90@gmail.com>
Co-authored-by: Dajeong-Park <ekwjd7182@gmail.com>
* VPC: support LB in multiple vpc tiers if LB provider is VpcVirtualRouter
* server: fix unit test CreateNetworkOfferingTest failures
[ERROR] Tests run: 10, Failures: 0, Errors: 10, Skipped: 0, Time elapsed: 13.902 s <<< FAILURE! - in org.apache.cloudstack.networkoffering.CreateNetworkOfferingTest
[ERROR] createIsolatedNtwkOffWithVlan(org.apache.cloudstack.networkoffering.CreateNetworkOfferingTest) Time elapsed: 0.662 s <<< ERROR!
org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'loadBalancerDaoImpl': Invocation of init method failed; nested exception is java.lang.NullPointerException
at org.apache.cloudstack.networkoffering.CreateNetworkOfferingTest.setUp(CreateNetworkOfferingTest.java:110)
Caused by: java.lang.NullPointerException
at org.apache.cloudstack.networkoffering.CreateNetworkOfferingTest.setUp(CreateNetworkOfferingTest.java:110)
* update #5580: use java.util.Optional
* update #5580: create method listByNetworkIdOrVpcIdAndScheme
* vmware, network: add maclearning option
Adds option for specifying MAC Learning property for network offering (useful for VMware Distributed Virtual Portgroup). Added global config - network.mac.learning for the default value.
MAC Learning is supported for DV portgroups for VMware Distributed vSwitches v6.6.0+ and vSphere 6.7+
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
* fix warning msg
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Enhanced update network form in the UI.
On network offering change for an isolated network,
- VMware portgroup should be updated accordingly.
- VMs on the network should be placed on the correct VMware portgroup based on the network rate, https://docs.cloudstack.apache.org/en/latest/adminguide/service_offerings.html#network-throttling.
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
* Provide a cleanup flag so that the project will
be deleted only when there are no resources left
in the project. If users click on delete project
by mistake then everything is deleted.
* fix travis failures
Co-authored-by: Rakesh Venkatesh <rakeshv@apache.org>
* ui: recommend adv zone to new users and show basic zone as bottom option
This shows the adv zone option in the create zone wizard before the basic
zone option and recommends it for new users. This is because adv zone
can offer more flexible and network topology options including what
basic zone offers in form of shared network (with/without security
groups).
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
* let's see if this ticks advanced by default
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
* Display ACL id for the private gateway
Display link for acl id which is associated
with the private gateway
* Update ui/src/components/view/InfoCard.vue
Co-authored-by: davidjumani <dj.davidjumani1994@gmail.com>
* Update InfoCard.vue
* Update InfoCard.vue
Co-authored-by: Rakesh Venkatesh <rakeshv@apache.org>
Co-authored-by: Rohit Yadav <rohit@apache.org>
Co-authored-by: davidjumani <dj.davidjumani1994@gmail.com>
This adds a volume(primary) storage plugin for the Linstor SDS.
Currently it can create/delete/migrate volumes, snapshots should be possible,
but currently don't work for RAW volume types in cloudstack.
* plugin-storage-volume-linstor: notify libvirt guests about the resize
This PR updates the pod response, grouped the parameters: startip, endip, vlanid, forsystemvms as ip range response and added to ipranges parameter (a new parameter to hold the list of IP range details).
* Resource Icon support - backend
* Add API support for resourceicon
* update reponse params + ui support
* Add exclusive list api for icons and UI changes
* refactor upload view
* UI changes to support resource icon wherever necessary
* convert api to POST + refactor icon view
* Add response name to list API + cosmetic changes in UI
* Added support for the following:
resource icon support for vpcs, networks, domains, and projects
add icons to list view if reosurces support icons to be added
support for showing project icons in the project switching drop-down menu
* List resourceicon cmds to be allowed for user role too
Users to inherit account icon if present (in listUsers response)
Move common code to plugin.js
Add icon to project list view - while switching between projects - Dashboard page
Show icons against zones - Capacity Dashboard view
Show user / account icon at the login button if present
* cosmetic changes
* optimize ui code
* fix reload issue for domain view
* add access check for delete operation
* ui-related changes to show iso icons
* iso image in uservm response
* add icons to custom form's list resources
* some more custom forms aligned to show icon for resources
* conmitic changes + add listing of icons to listdomainchildren cmd
* Add backend/server-side validation for base64 string passed for image
* change preview border
* preselect zone if there's only one
* add default icon
* show icon for network list in deploy vm view
* add custom icons if any to the import-export VM view
* preselect zone persistence on clearing cache
* prevent root vol from inheriting template/iso icon
* show tempalte icon in the info card details
* fix icon not being show on hard-refresh / initial traversal
* fx success message
* api: Update DNS on changing VM name
* refactor backend code + UI - add warning messaging to prompt users to restart VM in case particular fields are updated
* address comments
Form tries to find newly created network which belongs to the same account, created in last 30s and was not present in the networks list before opening create network dialog.
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
listConfigurations is not available for all roles and therefore not fit to use in UI for a generic functionality.
This PR makes default ui pagesize a part for listCapabilities API response to make it available for UI across different role accounts.
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Add management IP range form shows same pod multiple times when the pods has multiple IP ranges.
This PR fixes the behaviour.
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
* Display colors Save settings only in dev mode
* Hide entirely the dic section if not on dev
* Hide the settings floating widget if not on development
* ui: show nicAdapter selection for non-readfromova template
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
* show keyboardcontroller and ostype elements in different rows
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
* Extend addAnnotation and listAnnotations APIs
* Allow users to add, list and remove comments
* Add adminsonly UI and allow admins or owners to remove comments
* New annotations tab
* In progress: new comments section
* Address review comments
* Fix
* Fix annotationfilter and comments section
* Add keyword and delete action
* Fix and rename annotations tab
* Update annotation visibility API and update comments table accordingly
* Allow users seeing all the comments for their owned resources
* Extend comments for volumes and snapshots
* Extend comments to multiple entities
* Add uuid to ssh keypairs
* SSH keypair UI refactor
* Extend comments to the infrastructure entities
* Add missing entities
* Fix upgrade version for ssh keypairs
* Fix typo on DB upgrade schema
* Fix annotations table columns when there is no data
* Extend the list view of items showing they if they have comments
* Remove extra test
* Add annotation permissions
* Address review comments
* Extend marvin tests for annotations
* updating ui stuff
* addition to toggle visibility
* Fix pagination on comments section
* Extend to kubernetes clusters
* Fixes after last review
* Change default value for adminsonly column
* Remove the required field for the annotationfilter parameter
* Small fixes on visibility and other fixes
* Cleanup to reduce files changed
* Rollback extra line
* Address review comments
* Fix cleanup error on smoke test
* Fix sending incorrect parameter to checkPermissions method
* Add check domain access for the calling account for domain networks
* Fix only display annotations icon if there are comments the user can see
* Simply change the Save button label to Submit
* Change order of the Tools menu to provent users getting 404 error on clicking the text instead of expanding
* Remove comments when removing entities
* Address review comments on marvin tests
* Allow users to list annotations for an entity ID
* Allow users to see all comments for allowed entities
* Fix search filters
* Remove username from search filter
* Add pagination to the annotations tab
* Display username for user comments
* Fix add permissions for domain and resource admins
* Fix for domain admins
* Trivial but important UI fix
* Replace pagination for annotations tab
* Add confirmation for delete comment
* Lint warnings
* Fix reduced list as domain admin
* Fix display remove comment button for non admins
* Improve display remove action button
* Remove unused parameter on groupShow
* Include a clock icon to the all comments filter except for root admin
* Move cleanup SQL to the correct file after rebasing main
Co-authored-by: davidjumani <dj.davidjumani1994@gmail.com>
* add button toggle dark mode
* switch components corresponding to dark mode
* restructure the style dark mode file
* fix collapse & login page
* fix test failed
* fix dark mode styles by refer antd pro
* fix disabled colors of button, input,... & refactor file dark mode styles
* add setting drawer and save it into local storage
* add an alert for save the setting
* add `cursor: pointer`
* hide drawer when init
* change id name of svg icon
* fix after merged 4.15
* edit active color menu item
* fix plaholder color, project chart color & reset setting
* fix event change color picker & error input focus color
* fix empty data color
* add multiple management server support
* display the server on the user menu
* remove primary color in server icon
* using `/client` from apiBase
* add a setting that allows users to customize whether to use multiple servers or not
* set default hidden the multiple server config
* fix error test unit on MigrateWizard
* fix error test unit on AutogenView, ActionButton
* fix error lint
* fix error pollJob originalPage.starWith undefined
* Update ui/src/utils/plugins.js
Co-authored-by: davidjumani <dj.davidjumani1994@gmail.com>
* Update ui/src/utils/plugins.js
Co-authored-by: davidjumani <dj.davidjumani1994@gmail.com>
* uses a substitution variable if the originalPage is null with queryAsyncJob have jobstatus = 1
* remove argument null
Co-authored-by: davidjumani <dj.davidjumani1994@gmail.com>
Adds UI for importing and unmanaging VMs.
A new navigation section - Tools has been added in the UI.
Doc PR: apache/cloudstack-documentation#221
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
* fixes: submit the form when press enter
* add Enter submit for component missing
* add ctrl+enter event key for submitting form
* add directive.js check keyup event
* fix build test failure
* using directive in main.js
* fix warning show in the test unit
* fix multiple submits
* fix travis run test failures
* fix filter button style
* fix the problem of ctrl+enter keyup on firefox browser
* removed computed function not using
* remove space errror
* add ref for ctrl+enter submit
* resolve conflit and fix build
* add missing directive
* add missing directive & ref button
* fixes errors
* fixes errors
* add preventDefault()
* fix ctrl keypress not support on firefox
* refactor async job polling codebase-wide
* fix multiple call fetchData() when async job completed
* remove unnecessary functions
* remove const not use
* move closeaction out of handleResponse
* call closeAction without waiting for all group actions to complete
* refactor polljob network provider
* removed variable not use
* remove await
* ui: support bulk action for various resources
* ui: support bulk action for various resources
* Bulk actions support - progress review
* Extract common code + suppress error notification with bulk actions
* cleanup + suppress notification
* add progress view
* Add routes to notification + add async jobs + refactor progress view
* minor tweaks
* fix group action for vpn users
* Refactor code
* Unique row key
* remove redundant cols
* address comments
* Added the following:
1. Make Cancel as default button for bulk actions
2. Add Filter Filter on the Operation status Column - Progress View
3. For Stop and delete bulk operations - add An alert message(in Red) to inform users that it is a destructive operation
* Add dynamism to column filtering
* ui: refactor get api params in forms
Refactor code getting api params for APIs in UI forms.
Added a new util plugin in plugins.js
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
* fix
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
* fix
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Added action in UI for syncStoragePool API for DatastoreCluster type primary storages.
Fixes#5086
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
This PR introduces new granularity levels to configure VM dynamic scalability. Previously VM is configured to be dynamically scalable based on the template and global setting. Now we bringing this option to configure at service offering and VM level also.
VM can dynamically scale only when all flags are ON at VM level, template, service offering and global setting. If any of the flags is set to false then VM cannot be scalable. This result will be persisted in DB for each VM and will be honoured for that VM till it is updated.
We are introducing 'dynamicscalingallowed' parameter with permitted values of true or false for deployVM API and createServiceOffering API.
Following are the API parameter changes:
createServiceOffering API:
dynamicscalingenabled: an optional parameter of type Boolean with default value “true”.
deployVirtualMachine API:
dynamicscalingenabled: an optional parameter of type Boolean with default value “true”.
Following are the UI changes:
Service offering creation has ON/OFF switch for dynamic scaling enabled with default value true
Inclusivity changes for CloudStack
- Change default git branch name from 'master' to 'main' (post renaming/changing default git branch to 'main' in git repo)
- Rename some offensive words/terms as appropriate for inclusiveness.
This PR updates the default git branch to 'main', as part of #4887.
Signed-off-by: Suresh Kumar Anaparti <suresh.anaparti@shapeblue.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
AddUser form wrongly shows the account dropdown when adding a user for an account. Account dropdown remains empty in the form.
When an account is not selected prior to opening the form, the account input should be required.
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Fixes: #4990
When a VM associated with a backup offering is destroyed/expunged, the backup offering isn't unassigned, and despite the VM having no backups present, backup usage is generated. This PR prevent usage record generation when there are no backups present for a VM with a backup offering associated to it. This is done by ensuring that usage event for backups is generated only when a the backup size > 0
Prevent same string docHelp suffix override.
List all existing docHelp suffixes in the config file during the build process.
Updated apache/cloudstack-documentation#199
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
IKE version allows selecting ike (autoselect), ikev1, or ikev2.
Split connections gives an option of separating the first right subnet from the rest, and kicking out individual statements for each right subnet for better cross-compatibility.
Backported from PR: #4137
update per PR suggestion
Fixes#3138
Co-authored-by: Greg Goodrich <ggoodrich@ippathways.com>
Co-authored-by: Daan Hoogland <dahn@onecht.net>
Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com>
Fixes: #4808, #4941
This PR adds a force flag to the attachIso / detachIso commands, especially for VMware where it is noticed that when trying to either detach an iso or attach an iso when there already exists another present it fails to do the necessary operation as from ACS end we either answer the question returned by Esxi for CDRom disconnect operation as No (for detach operation) or do not answer the question at all (for Attach operation).
Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com>
For an auto-generated form, with list mapping of action, mapped API parameter was not getting added to the request when first index from the list is selected. Change added to fix this.
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Co-authored-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This PR includes fixes to complete the Korean language support of the new CloudStack UI.
CloudStack explains that it supports Korean, but only some features are translated. Compared to the en-us.json file, it is not up to date on new features.
To support Korean language support for new features and more modern Korean language support, the contents of en-us.json were copied to the ko-kr.json file and retranslated into Korean.
Co-authored-by: Dajeong-Park <ekwjd7182@gmail.com>
* Fix bug in creating shared network
Sometimes creating shared network fails because the physical network
data is null and redereferencing it causes NPE.
Wait till the physical network data is available before accessing it
* Update CreateSharedNetworkForm.vue
Co-authored-by: Rohit Yadav <rohit@apache.org>
This PR aims at introducing persistence mode in L2 networks and enhancing the behavior in Isolated networks
Doc PR apache/cloudstack-documentation#183
Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com>
If a vm belongs to shared network then display the list
of ip addresses available which can be used to assign for
secondary IP addresses.
Also display "Public IP addresses" tab for shared networks
config.json can have a property named 'docHelpMappings' which can be used to override docHelp suffixes.
In config.json admin can add mappings as follows:
"docHelpMappings": {
"virtual_machine.html": "some.html",
"some_string": "override_string"
}
UI will use these mappings and will make appropriate replacements in the documentation links for different sections and forms.
Addresses #4731
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
This PR fixes the issue pertaining to volume resize on VMWare for deploy as-is templates. VMware deploy as-is templates are those that are deployed as per the specification in the imported OVF. Hence override root disk size will not be adhered to for such templates. Moreover, when we deploy VMs in stopped state and resize the volume, the root disk doesn't get resized but the volume size is merely updated in the DB.
This PR also includes the following (for deploy as-is templates):
- Disables overriding root disk size during VM deployment on the UI
- Disables selection of compute offerings with root disk size specified, at the time of deployment
- Provided users with the option to deploy VM is stopped state via UI (so as to give an option to users to resize the volumes before starting the VM)
Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com>
Abhishek Kumar
Suresh Kumar Anaparti
Hoang Nguyen
Daman Arora
Rakesh
SadiJr
Rohit Yadav
Wei Zhou
Nicolas Vazquez
Gabriel Beims Bräscher
Pearl Dsilva
sureshanaparti
dahn
Harikrishna
Apurv Gupta
Peinthor Rene
DH Park
davidjumani
SadiJr
DK101010
mib85
j-porsche
Wei Zhou
slavkap
Sina Kashipazha
Wei Zhou
Michael
Abhishek Kumar
fermosan
Spaceman1984
DH Park
Daan Hoogland
