Commit Graph

160 Commits

Author SHA1 Message Date
Vijayendra Bhamidipati 93a0989167 CS-15569: InterVlan - ApiDispatcher reports wrong Information as the reason for Failure. Public IP Addresses unrelated to the Guest VM are mentioned to be associated with the VM.
Description:

    Fixing misleading error message in exception.
2012-08-13 17:58:17 -07:00
Alena Prokharchyk a82ff7b0d1 VPC: CS-15968 - don't send ips in Releasing state to the router when the nic is already unplugged for this Vlan 2012-08-13 11:42:29 -07:00
Fang Wang 90d0871131 bugCS-15741
InterVlan - User VM's ID should not be revealed in the Error message displayed to the Regular User Account - Error during Static NAT Rule creation.
Description:
	Use the UUID to replace the vmId in the exception message.
2012-08-10 19:53:13 -07:00
Alena Prokharchyk e866122ff8 Fixed line endings in RulesManagerimpl file 2012-08-10 16:33:34 -07:00
Alena Prokharchyk 029a07fad4 VPC: CS-15950 - throw networkConflictException when try to create network rule for the ip address that is already in use for another service 2012-08-10 16:04:18 -07:00
Murali Reddy f837a0431d bug CS-15817 system VM's fail to create in basic zone with EIP/ELB network offering
removing the ActionEvent annotation on associate IP, acuquire IP methods
on internal methods, so that static NAT for system VM succeeds
2012-08-03 08:54:35 +05:30
Alena Prokharchyk 21f2d1b779 VPC: moved vpc related code from NetworkManager to VpcManager 2012-07-31 16:58:14 -07:00
Alena Prokharchyk d467ff8a49 CS-15743: disable static nat as a part of network resources cleanup 2012-07-30 10:53:01 -07:00
Vijayendra Bhamidipati 62c11df4e9 CS-15217: Security: Malicious user is able to get the size of the cloud by enumerating IDs
Description:

	1) With this commit in the series for this bug,
	removed all occurrances of db IDs being passed
	when raising InvalidParameterValueException.

	2) Renamed HyervisorTemplateAdapter.java to
	HypervisorTemplateAdapter.java.
2012-07-27 15:08:48 -07:00
Alena Prokharchyk ecd8450ab6 Added missing action events for enable/disable static nat 2012-07-26 15:26:53 -07:00
Deepak Garg a4a15aa737 Work around for CS-15556 2012-07-24 10:00:26 +05:30
Alena Prokharchyk 49199d0022 VPC: when VPC router gets destroyed and recreated, plug public nic for each Vlan where VPC public ips belong to 2012-07-20 16:28:43 -07:00
Alena Prokharchyk c0fb2fece9 VPC: CS-15638: Plug nic for the public ip address if the ip address from the diff vlan range than sourceNat ip 2012-07-20 13:25:09 -07:00
Vijayendra Bhamidipati b14cebbe68 CS-15556: [NS Autoscale] System VMs not coming up in Basic zone EIP ELB offering
Description:

	Removing a reference to user_vm table when populating a system VM
	id in an exception. Undoing change committed earlier as part of
	Bug CS-15217.
2012-07-13 13:44:10 -07:00
Alena Prokharchyk ab418176ef VPC: CS-15569/CS-15568 - release ip address from VPC when fail to enable static nat 2012-07-13 10:37:09 -07:00
Alena Prokharchyk 7e73ae8e74 VPC: CS-15553 and CS-15549 - more checks during automatic ip assoc to VPC network 2012-07-12 10:04:39 -07:00
Vijayendra Bhamidipati a0f6cb47f1 CS-15217: Security: Malicious user is able to get the size of the cloud by enumerating IDs
Description:

	Removing DB IDs from exception messages.
2012-07-11 19:52:56 -07:00
Alena Prokharchyk 1011dfd31c Resource tags: 1) Remove tag records when correspdonding cloudStack object gets removed
2) added "tags" request parameter to the banch of list* Api commands (listVirtualMachines, listSnapshots - all commands are listed in the resource tags functional spec)
2012-07-03 14:47:07 -07:00
Alena Prokharchyk 37f29ccb11 VPC: set networkId to be null for IP address when the last PF/LB rule is removed for it and the IP belongs to VPC 2012-06-29 13:46:20 -07:00
Alena Prokharchyk ceb4445166 VPC: createPF/createLBrule: 1) don't allow to pass openFirewall=true 2) when no openFirewall is passed in, defaulted to false if the public ip belongs to VPC 2012-06-28 14:19:14 -07:00
Alena Prokharchyk 84a4a7c1c8 VPC: update ip address object after the ip is associated with the network 2012-06-25 16:26:19 -07:00
Alena Prokharchyk 32c858ecd2 VPC: finilize start for the VR - send ip assoc commands only after plug nic is done for all public nics 2012-06-25 15:59:23 -07:00
Alena Prokharchyk bb30a6b6bb VPC: initial checkin for network ACLs 2012-06-20 12:48:00 -07:00
Vijayendra Bhamidipati e03ed60540 Bug 13127: API error text refer to database ids instead of uuids
Bug CS-14448: Wrong error message on using the createVlanIpRange cmd

Cherry-picking from master for bug 14448 into 3.0.x. Resolved
conflicts encountered during cherry-picking.

Description:

	Adding overloaded addProxyObject() function to CloudException
	and RuntimeCloudException classes and using this function
	to stuff exceptions with IDs, to reduce code footprint.

Conflicts:

	server/src/com/cloud/network/NetworkManagerImpl.java
	server/src/com/cloud/resource/ResourceManagerImpl.java
2012-06-18 12:55:44 -07:00
Vijayendra Bhamidipati 7860b78049 Bug 13127: API error text refer to database ids instead of uuids
Bug CS-14448: Wrong error message on using the createVlanIpRange cmd

Cherry-picking from master for bug 14448 into 3.0.x. Resolving
conflicts arising from the pick.

Description:

	Modifying the API functions' exception handling to call
	addProxyObject() wherever applicable, and removing some
	wrong calls to addProxyObject() that were put in in an
	earlier commit for this bug.

	With this commit, we cover many API functions to use the
	new exception handling code, but some pieces may still be
	left out. These will be covered as work in progress, when
	making changes to the CS API code.

Conflicts:

	server/src/com/cloud/network/NetworkManagerImpl.java
	server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java
	server/src/com/cloud/resource/ResourceManagerImpl.java
2012-06-18 12:44:18 -07:00
Alena Prokharchyk aaf0d24a83 Merge branch 'vpc-3.0.x' into 3.0.x
Conflicts:
	api/src/com/cloud/api/ApiConstants.java
	api/src/com/cloud/api/BaseCmd.java
	api/src/com/cloud/api/ResponseGenerator.java
	api/src/com/cloud/api/commands/AssociateIPAddrCmd.java
	api/src/com/cloud/api/commands/EnableStaticNatCmd.java
	api/src/com/cloud/event/EventTypes.java
	api/src/com/cloud/network/NetworkService.java
	api/src/com/cloud/network/rules/RulesService.java
	client/tomcatconf/commands.properties.in
	core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java
	scripts/vm/hypervisor/xenserver/xenserver56fp1/patch
	server/src/com/cloud/api/ApiDBUtils.java
	server/src/com/cloud/api/ApiResponseHelper.java
	server/src/com/cloud/configuration/DefaultComponentLibrary.java
	server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java
	server/src/com/cloud/network/NetworkManagerImpl.java
	server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
	server/src/com/cloud/network/rules/RulesManagerImpl.java
	server/src/com/cloud/server/ManagementServerImpl.java
	server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java
	server/src/com/cloud/upgrade/dao/Upgrade2214to30.java
	server/test/com/cloud/network/MockNetworkManagerImpl.java
	server/test/com/cloud/vm/MockVirtualMachineManagerImpl.java
	setup/db/create-schema.sql
	wscript
2012-06-14 19:04:59 -07:00
Alena Prokharchyk ddae550a55 AssociateIpAddress to VPC - the ip gets associated to the network only when the first rule for the ip gets created.
When the last rule is removed for vpc ip, networkId is set to null
2012-05-30 19:46:40 -07:00
Murali reddy 135431d727 bug CS-14862: EIP/ELB - SSVM and CPVM should be given an ip address from the public ip address range.
With this fix  both SSVM and CPVM will get public IP's in case of basic zone with EIP service.
A static NAT rule is implicitly configured on the EIP service provider to map public IP to a
guest IP address associated with SSVM/CPVM
2012-05-21 20:08:46 +05:30
frank 72d284de7d Switch to Apache license 2012-04-03 04:54:14 -07:00
Sheng Yang 2619df56a5 Fix debug messages in RulesManagerImpl
Reviewed-by: Edison
2012-02-23 10:57:57 -08:00
Alena Prokharchyk 9bdf7fe645 bug 13919: do includingRemoved Nic search when remove firewall rules during the vm expunge
status 13919: resolved fixed
Reviewed-by: Sheng Yang
2012-02-21 18:02:54 -08:00
Alena Prokharchyk 12aade4dc7 Changed isElastic to isSystem for the publicIpAddress assigned during the vm deployment in EIP enabled network
Reviewed-by: Chiradeep
2012-02-21 15:38:31 -08:00
Sheng Yang 99b7b73d7f bug 12747: release ip when no static nat rule existed
status 12747: resolved fixed
2012-02-08 15:54:03 -08:00
Alena Prokharchyk cad392cd68 bug 13335: fixed listProjectInvitations by projectId
status 13335: resolved fixed
2012-02-07 13:16:27 -08:00
Alena Prokharchyk 1490e45a1c Fixed format style in a bunch of files (replaced tabs with spaces as a part of it) 2012-02-03 13:49:11 -08:00
Alena Prokharchyk 7ea3c8933d bug 13305: don't allow to create ip forwarding rules when elasticIP is enabled for the network offering
status 13305: resolved fixed

Reviewed-by: Will Chan
2012-01-25 10:57:34 -08:00
Alena Prokharchyk 5307d21210 DisableStaticNat: if elasticIP service is enabled for the network offering, always allocate new elastic ip and create static nat rule for it when disableStaticNat is called 2012-01-24 14:06:01 -08:00
Alena Prokharchyk 03cce245cf Fail to create vm when corresponding elastic ip failed to apply on the backend 2012-01-19 14:13:49 -08:00
Alena Prokharchyk d4d345a587 Don't retry to re-create the vm when failed to allocate public ip 2012-01-19 14:00:07 -08:00
Alena Prokharchyk a9e4af0866 Can't release/disable static nat for IP when the IP is elastic 2012-01-19 13:58:36 -08:00
Alena Prokharchyk 4f46c3b160 Mark ip as not elastic when disable static nat is called on it 2012-01-19 13:58:36 -08:00
Alena Prokharchyk 212c22b256 Added isElastic flag to ip address 2012-01-19 13:58:35 -08:00
Alena Prokharchyk 1d0ffc4575 EnableStaticNat for newly allocated address - if eIp is enabled, and the target vm already assigned to the ip, reassign the vm to the new ip 2012-01-19 13:58:35 -08:00
Alena Prokharchyk 6325d21c50 Get new elasticIp when releaseIpAddress is called for elasticIP of the vm 2012-01-19 13:58:35 -08:00
Alena Prokharchyk 6deeb7ddc9 Firewall service is enabled in default elb/eip network offering
Also added more handling for error cases scenarios
2012-01-19 13:58:35 -08:00
Alena Prokharchyk 0e8104cca1 Disassociate ip address - always allocate a new IP and enable static nat for it when elactic IP is enabled 2012-01-19 13:58:35 -08:00
Alena Prokharchyk 83400cd15f bug 12776: if there are multiple objects involved in resource creation, verify that they belong to the same account
status 12776: resolved fixed
2012-01-17 13:40:37 -08:00
Alena Prokharchyk f0c4980dff bug 13110: use Ternary data structure when build search criteria
status 13110: resolved fixed
2012-01-16 14:15:28 -08:00
kishan 474543d623 Bug 10284: Throw exception instead of returnning false for firewall API commands
Status 10284: resolved fixed
Reviewed-By: Nitin
2012-01-12 19:03:34 +05:30
Alena Prokharchyk e6080436cf bug 12926: fixed regression in enableStaticNat code introduced by preserve ip fix 2012-01-10 12:17:13 -08:00