etan39
/
cloudstack
mirror of https://github.com/apache/cloudstack.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
29,278 Commits 331 Branches 326 Tags 947 MiB
Commit Graph

1707 Commits

Author SHA1 Message Date
Rohit Yadav 37820e15f2 CLOUDSTACK-7593: allow nic type to be fetched from vm's details 
(cherry picked from commit 43db75c319)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

Conflicts:
	engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
 2015-04-13 15:47:03 +05:30
Daan Hoogland 015eef2f4b findbugs: explicit default encoding 2015-04-12 19:39:25 +02:00
wilderrodrigues 240bcb8120 Refactoring the GetGPUStatsCommand wrapper in order to cope with new design 
- Unit tests added: 100% coverage
 2015-04-05 09:23:09 +02:00
wilderrodrigues 3d22a16c4f Bump priority stragety is no longer used for redundant virtual routers 
- With the changes added by the rVPC work, the bump priority became deprecated.
     This commit includes a refactor to get it removed from the following resources:
     * Java classes
     * domain_router table - removing the is_priority_bumpup column
     * Fixing unit tests

All changes were tested with:

XenServer 6.2 running under our VMWare zone
CloudStack Management Server running on MacBook Pro
MySql running on MackBook Pro
Storage Type: Local
 2015-04-02 21:50:49 +02:00
wilderrodrigues 11d0336803 Refactoring GetStorageStatsCommand and PrimaryStorageDownloadCommand to cope with the new design 
Fix the NPE in the constructor that was never used
  - Basic tests added for all changes
 2015-03-31 10:38:29 +02:00
wilderrodrigues c3ae8c793b Adding the refactor of CitrixCheckConsoleProxyLoadCommandWrapper.java and CitrixWatchConsoleProxyLoadCommandWrapper.java 
- plus basic tests
 2015-03-31 10:38:24 +02:00
wilderrodrigues a1e8778211 First piece of the refactor of the CitrisResourceBase 
- The same pattern will be used by the other subclasses of the ServerResource interface.
 2015-03-31 10:38:24 +02:00
Rajani Karuturi 018023c1ef volume upload: added validation for file formats 
merged TemplateUtils and ImageStoreUtil to a singe ImageStoreUtil
also added a unittest for ImageStoreUtil
 2015-03-20 16:25:13 +05:30
wilderrodrigues 159088cb90 Fix array index problems on the ACL command. 2015-03-16 11:39:55 +01:00
wilderrodrigues edd839ab10 Fix: allow multiple VIFs per Mac Address 
Fix: RTNETLINK errors
     - Management Server health check trying to create already existing interface
     - Changes on update_config.py, cs_guestnetwork.py, merger.py
Fix: replace RRouTER_LOG in the CsRedundant.py per log file location
Fix: Guest Net address association during Router restart
     - Changes on NicProfileHelper, NicProfileHelperImpl
Fix: aggregationExecution() method on VirtualNetworkApplianceManagerImpl
     - Do not send an AggregationControlCommand to a non-configured router

Some classes have been formatted.
 2015-03-16 11:39:48 +01:00
Ian Southam 7d0df32560 Lots of fixes from the testing 
firewallrules implemented sperately from networkacl (ugly but best that can be done ATM)
Some refactoring in CsDHCP as it made no sense to do it that way anymore
processmonitoring implemented
Domain not correctly sourced in VR
 2015-03-16 11:38:15 +01:00
Hugo Trippaers 39035f4782 Fix test cases now ConfigHelper is gone 2015-03-16 11:35:38 +01:00
Hugo Trippaers 0a95c44c51 ConfigHelper is replace by a facade pattern 2015-03-16 11:35:36 +01:00
wilderrodrigues 0a1677242a Adding tests for IpAssocVpc; DeleteIpAlias; DnsMasqConfig 
Adding IpAssocVpcCommand to the AbstractConfigItemFacade map
 2015-03-16 11:35:34 +01:00
wilderrodrigues 6d7f75e18b Adding LoadBalancer command to JSON style 
Adding a couple of tests (ConfigHelperTest) to validate the following:

* Command is generated;
* JSON String is generated based on the Java Object
* JSON Object is generated based on the String content

Also fixed the SetPortForwardingRulesVpcConfigItem: implementation was missing.
 2015-03-16 11:35:33 +01:00
wilderrodrigues 6898acd349 BumpUpPriotity doesn't need the generateConfigItems() method. 
Its approach is different, it uses a non-parameterized script.
 2015-03-16 11:35:33 +01:00
wilderrodrigues 8caafe2859 Adding all other (13) rules to the new code design 
Removed the code from ConfigHelper, which is now really clean
Added Flyweight to AbstractConfigItemFacada
Renamed 3 *ConfigItem classes that had typos in their names
 2015-03-16 11:35:33 +01:00
wilderrodrigues 7ccd174471 Add 8 Commands/ConfigItems to new style 
Make subclasses extend the abstract class; change accessor of few methods
 2015-03-16 11:35:32 +01:00
wrodrigues 36a95e7577 TK-2925 Add support for loadbalancer config in ConfigHelper 
Adding new ConfigItem classes, that will be used to decouple the configureation from the ConfigHelper class.

The idea is to use mix of Flyweight and Facade implementation in order to the correct classes without having so many ifs and private static methods.
 2015-03-16 11:35:31 +01:00
Ian Southam 8a92a0a460 Corrected a couple of small typos 2015-03-16 11:35:23 +01:00
Sander Botman 9b40f3d379 fixing the nullpointer on type which is null 2015-03-16 11:35:18 +01:00
Sander Botman 4c5113b9e5 Creating new model for the firewall rules 2015-03-16 11:35:18 +01:00
Hugo Trippaers d2e3b238ed New style dnsmasq configuration 2015-03-16 11:35:17 +01:00
Sander Botman daf6c33507 Creating new model for the MonitorService 2015-03-16 11:35:17 +01:00
Sander Botman b4acd77abf New model for RemoteAccessVpn and moving into the new structure 2015-03-16 11:35:16 +01:00
Hugo Trippaers caef7ee9a9 Staticroutes to new json style 2015-03-16 11:35:16 +01:00
Hugo Trippaers 58919dcf50 Change the location for the temporary json files to /var/cache/cloud 2015-03-16 11:35:16 +01:00
Sander Botman 92aca76c3b Adding new model for the Site2SiteVpn configuration. 2015-03-16 11:35:15 +01:00
Hugo Trippaers 2e968d85fe Migrate ip alias commands 2015-03-16 11:35:15 +01:00
Hugo Trippaers 660fdbe238 modified StaticNatRule to use the new style 2015-03-16 11:35:14 +01:00
Sander Botman f423f3ea4e New style manage VPN user command <Still need some testing with the VR image> 2015-03-16 11:35:13 +01:00
Hugo Trippaers 6ae56b7275 Add forwarding rules to the new config format and do a little rewrite on 
the models
 2015-03-16 11:35:13 +01:00
Hugo Trippaers 3ab83fdba7 New style save password command 2015-03-16 11:35:11 +01:00
Hugo Trippaers bda4c0d2c9 Move some static strings to constants and remove some duplicate code 2015-03-16 11:35:11 +01:00
Hugo Trippaers 9b2a73370b Put a netmask in the netmask field 2015-03-16 11:35:09 +01:00
Hugo Trippaers 25b8510c43 Change vmdata to the new config system 2015-03-16 11:35:06 +01:00
Hugo Trippaers 43fd212298 Add some debug logging to keep track of timing 2015-03-16 11:35:05 +01:00
Hugo Trippaers 7b8050c056 Rewrite networkacl model to have separate entries for each rule 2015-03-16 11:35:05 +01:00
Hugo Trippaers 0027db6cd1 Switch ip associations to new model and update the recipes 2015-03-16 11:35:04 +01:00
Hugo Trippaers 183b248c4e Include a type field in all json configuration objects 2015-03-16 11:35:04 +01:00
Hugo Trippaers 1f1a9ba8b0 Create a json file for SetNetworkACL 2015-03-16 11:35:03 +01:00
Hugo Trippaers 639b24a575 Replace CreateGuestNetwork config script with a json file. 2015-03-16 11:35:01 +01:00
Hugo Trippaers 9514f259f6 Removed useless array from SetStaticRoutesCmd. 2015-03-16 11:34:59 +01:00
Hugo Trippaers 0f5af91668 Switch ip associations to the new config file system 2015-03-16 11:34:58 +01:00
Likitha Shetty bdd28a45ed CLOUDSTACK-8319. For both 'MigrateVolume' and 'MigrateVMWithVolumes, ensure VM's vconfiguration files are migrated along with VM's root volume. 2015-03-12 11:57:02 +05:30
Laszlo Hornyak e6e3a20bd6 removed redundant autoboxing 
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
 2015-02-27 19:38:12 +01:00
Laszlo Hornyak 5626a340dd Logical expression simplification, == true is redundant 
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
 2015-02-27 19:38:12 +01:00
Likitha Shetty 15b348632d CLOUDSTACK-8129. Cold migration of VM across VMware DCs leaves the VM behind in the source host. 
If VM has been cold migrated across different VMware DCs, then unregister the VM from source host.
 2014-12-26 11:07:30 +05:30
Likitha Shetty 647532376f CLOUDSTACK-8111. NFS secondary storage repetitively mounted on CS server with ESXi hypervisors. 
Fix cleanup of NFS mounts on management server during server starup by correcting how mount points are listed for a management server.
 2014-12-23 13:23:43 +05:30
Rajani Karuturi d2ef7295f9 volume upload: sending the preshared key to ssvm 
sending the key to ssvm in the secondary storage setup command
saving it in a file on ssvm
 2014-11-28 16:40:20 +05:30
Laszlo Hornyak 3577423da9 removed executable flags from java classes 
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
 2014-11-23 19:49:01 +01:00
Hugo Trippaers 22ad646aca CID-1114601/CID-1114602 Fix ignored return values and remove duplicate code 2014-11-18 15:05:09 +01:00
Santhosh Edukulla 1aef5cba66 Fixed Coverity Issues 2014-11-03 16:45:30 +05:30
Mike Tutkowski 15c8d8caf6 Pass on new command 2014-10-21 16:01:15 -06:00
Mike Tutkowski 0cea0346ae Support for back-end snapshots on primary storage 2014-10-21 16:01:14 -06:00
Daan Hoogland 1de0cb7094 restore barematel work after merge 2014-10-17 10:24:01 +02:00
amoghvk 71c9804165 Fixing possible formatting issue with license header, causing builds to fail. Works well locally 2014-10-14 14:37:38 -07:00
Sanjay Tripathi 176e0d47bb CLOUDSTACK-6650: Reorder Cluster list in deployment planner to protect 
GPU enabled hosts from non-GPU VM deployment.
Cluster reordering is based on the number of unique host tags in a cluster,
cluster with most number of unique host tags will put at the end of list.
Hosts with GPU capability will get tagged with implicit tags defined by
global config param 'implicit.host.tags' at the time os host discovery.

Also added FirstFitPlannerTest unit test file.
 2014-10-14 17:55:37 +05:30
amoghvk da73d735b2 Revert "CLOUDSTACK-6650: Reorder Cluster list in deployment planner to protect" 
This reverts commit d910b4ff14 since it is causing encryption/decryption issues with RPM builds

(cherry picked from commit fbcab01ff0)
 2014-10-13 00:37:34 -04:00
Hugo Trippaers 5990ed4610 Move the PrepareKickstartPxeServerCommand to the core api so other 
modules can use it.
(cherry picked from commit b6401b04f22b0a5b686c7c477da4c6e0fd18df84)

Conflicts:
	plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetalKickStartServiceImpl.java
 2014-10-13 00:22:50 -04:00
Sanjay Tripathi 47d2a578ee CLOUDSTACK-6650: Reorder Cluster list in deployment planner to protect 
GPU enabled hosts from non-GPU VM deployment.
Cluster reordering is based on the number of unique host tags in a cluster,
cluster with most number of unique host tags will put at the end of list.
Hosts with GPU capability will get tagged with implicit tags defined by
global config param 'implicit.host.tags' at the time os host discovery.

Also added FirstFitPlannerTest unit test file.

(cherry picked from commit 39fe766c2b)
 2014-10-13 00:15:03 -04:00
Edison Su 9278a6378b fix checkstyle 
(cherry picked from commit 8db4f197ef)
 2014-10-13 00:12:54 -04:00
Edison Su ae0bf7db5f speed up template download: don't sync io for each write 
(cherry picked from commit 6de4dcb10a)
 2014-10-13 00:12:36 -04:00
Hugo Trippaers 4ad2734576 CID-1114601 to 1114604 Recommended practice is to test the result of 
skip and read for EOF
 2014-09-19 14:29:01 +02:00
Hugo Trippaers 90df7cf881 CID-1116300 Prevent potential NPE 2014-09-19 11:55:17 +02:00
Anthony Xu 071004e3e1 removed start/stop VR from queue 2014-09-17 19:04:34 -07:00
Jayapal 86bf33bfab CLOUDSTACK-7540: Fixed NPE in check s2svpn connection status 2014-09-15 14:54:13 +05:30
Devdeep Singh f099732be7 CLOUDSTACK-7359. Make sure timeout value is set for the MigrateVolumeCommand. This will 
make sure the agent waits for the resource to complete (success/failure) migration of
volume on the hypervisor.
 2014-08-18 11:38:29 +05:30
Hugo Trippaers d2aa1c4aa1 Fix concurrency issues CID-1230585 and CID-1230586 2014-08-13 08:39:40 +02:00
Min Chen e3564658be CLOUDSTACK-6940, CLOUDSTACK-7312, CLOUDSTACK-5512: Template/ISO/Volume 
upload rejects some valid URL formats. Also consolidate URL format check
into one util routine.
 2014-08-12 11:43:08 -07:00
Kishan Kavala c09888fcb5 CLOUDSTACK-7237 : Added TAR image processor for templates with tar extension 2014-08-06 18:03:02 +05:30
Jayapal 912dc15bc1 CLOUDSTACK-7246: corrected script name of createipalias 2014-08-05 14:20:32 +05:30
Santhosh Edukulla e4d6cd8e6a Fixed coverity reported concurrency issues 
Signed-off-by: Santhosh Edukulla <santhosh.edukulla@gmail.com>
 2014-08-05 12:16:08 +05:30
Anthony Xu 330c4ba578 completed the new vmsync TODOs in the code. 
removed old vmsync logic
 2014-07-28 12:51:37 -07:00
Hugo Trippaers 49f60ca744 Fix a coverity issue about unchecked returns and make the code flow a 
litle bit more easy to follow.
 2014-07-28 14:42:42 +02:00
Sheng Yang f4757a198a Revert "CLOUDSTACK-7124: Fix semicolon caused VPN programming issue" 
This reverts commit 809b47e4eb.

Because the fix cause CLOUDSTACK-7163. Would fix it in another way.

Conflicts:
	core/src/com/cloud/agent/resource/virtualnetwork/ConfigHelper.java
 2014-07-25 14:10:35 -07:00
Hugo Trippaers 70e68be4f3 Fix string encoding problem reported by coverity 2014-07-22 13:12:47 +02:00
Hugo Trippaers a963fd34b5 CLOUDSTACK-7111 Empty commandlist must return a succes 2014-07-18 09:28:42 +02:00
Hugo Trippaers 5651a13cfd Remove duplicated code 2014-07-18 09:28:42 +02:00
Sheng Yang 809b47e4eb CLOUDSTACK-7124: Fix semicolon caused VPN programming issue 
Semicolon can cause trouble in bash, need to be escaped.
 2014-07-17 18:40:14 -07:00
Hugo Trippaers dbc7d80329 Aggregate command cleanup is not required for the virtual router as we 
already cleanup in the finish.

And consequently dies if somebody tries to test with assertions enabled.
 2014-07-16 16:24:54 +02:00
amoghvk 6831ed4026 CLOUDSTACK-6358: Missing patches in master branch 2014-07-14 15:17:58 -07:00
Hugo Trippaers a49bb7e8e3 Cleanup licenses in core with com.mycila:license-maven-plugin:format 2014-07-14 16:28:29 +02:00
Hugo Trippaers 109d129096 Enforce licenses and license format in cloud-core 2014-07-14 16:28:29 +02:00
Hugo Trippaers 1ed554650c One day i'll remember to put the licenses in right away. 2014-07-14 16:04:29 +02:00
Hugo Trippaers c12767908d Refactor VirtualRoutingResource, put the ConfigItems in separate classes and create a separate ConfigHelper 2014-07-14 15:32:31 +02:00
Santhosh Edukulla 97d296bfbd Fixed Coverity reported performance issues like inefficient string concatenations, wrong boxing or unboxing types, inefficent map element retrievals 
Signed-off-by: Daan Hoogland <daan@onecht.net>
 2014-07-01 22:06:25 +02:00
Mike Tutkowski 42d00cae58 SolidFire (shared-access) Provider 2014-06-16 12:15:29 -06:00
Nitin Mehta 5393387bbd CLOUDSTACK-6599: 
1. Adding the missing Template/Volume URLs expiration functionality
2. Improvement - While deleting the volume during expiration use rm -rf as vmware now contains directoy
3. Improvement - Use standard Answer so that the error gets logged in case deletion of expiration link didnt work fine.
4. Improvement - In case of domain change, expire the old urls
 2014-05-30 10:48:42 -07:00
Marcus Sorensen 15ac47e47b CLOUDSTACK-6088: Check first bytes of template when downloading to verify format/type 2014-05-28 15:40:57 -06:00
Rajesh Battala cc92f3bbe3 Fixed testSetupGuestNetwork unit test as the SetupGuestnetwork prepare command got changed 2014-05-05 13:45:12 +05:30
Rajesh Battala f9cf2c241b CLOUDSTACK-6518 [Hyper-V] Efficient way of finding the empty nic in VR/VpcVR to configure VPC entities 2014-05-05 12:56:42 +05:30
Rajesh Battala 6cbb9a5b72 CLOUDSTACK-6528 SetupGuestNetwork command is not deleting the guest network configured on the eth device 2014-05-05 12:56:42 +05:30
Anthony Xu b3491bcbac removed unused command ClusterSyncCommand 2014-05-01 11:45:19 -07:00
Mike Tutkowski c0910cbdb9 CLOUDSTACK-6170 (VMware root-disk support for managed storage) 2014-04-19 10:41:42 -06:00
Sheng Yang 4620c27ebf CLOUDSTACK-6047: Make aggregation command timeout configurable 
In case some environments has different performance or we found some commands
would took too long to execute, one global configuration item is introduced to
specify "time out in seconds per one command in aggregation commands".

By default it's 3 seconds. If admin feel it's too long, it can be adjust to as
low as 1 seconds, which runs still well in my machine.

Conflicts:
	setup/db/db/schema-430to440.sql
 2014-04-18 23:36:19 -07:00
Koushik Das 5e90b75c98 CLOUDSTACK-6402: Fix StopCommand so that VMs are not removed accidentally as part of vmsync 
Added a new flag 'checkBeforeCleanup' to StopCommand based on which check is done to see if VM is running in HV host.
If VM is running then in this case it is not stopped and the operation bails out.
Also modified the MS code to call the StopCommand with appropriate value for the flag based on the context.
Currently it is only set to 'true' when called from the new vmsync logic based on powerstate of VM. For rest it
is set to 'false' meaning no change in behaviour.
 2014-04-14 16:52:37 +05:30
Sanjay Tripathi a195205d11 CLOUDSTACK-6366: add vgpuTypes details in vgpu_types table. 2014-04-09 18:23:50 +05:30
Harikrishna Patnala ecc71518a9 CLOUDSTACK-6253: Optimizing VR alerts getting algorithm In addition to this a new configuration parameter is added router.alerts.check.interval defaulted to 30minutes to check for alerts in Virtual Router 2014-04-09 18:12:20 +05:30
Sheng Yang b2ffd86570 CLOUDSTACK-6309: Fix timeout in KVM when execute VR commands 
Timeout is in seconds rather than milliseconds.
 2014-03-31 11:30:06 -07:00