Commit Graph

5040 Commits

Author SHA1 Message Date
Koushik Das c36880fe45 CS-16022: If host connection fails due to some DB error, host disconnect does not happen and mgmt_server_id is not removed.
Reviewed-by: prachi
2012-08-22 14:19:47 +05:30
Sheng Yang 061f7c8b82 CS-16043: Using network based router rather than account for RVR detection
Backported from 3.0.x

Reviewed-by: Alena Prokharchyk <alena.prokharchyk@citrix.com>
2012-08-20 17:04:33 -07:00
prachi cfd8ef8fce CS-12510: Deleting the host_details and inserting them back causes deadlocks.
Reviewed-By: Alex

Changes:
- Deleting and inserting the host_details in one transaction leads to this MySQL deadlock issue sometimes
- This fix is to use the ON DUPLICATE KEY UPDATE MySQL query that will insert the deatils if they are new or update the ones that are existing.
- This needs a UNIQUE constraint on host_details.
2012-08-01 17:23:26 -07:00
prachi 74b717ba6a CS-15606 Dogfood Setup: Virtual Router (DHCP Server) fails to create in Pods
Reviewed-By: Alena

Changes:
- Correct the virtual router entries from table' virtual_router_providers' that wrongly refer to SecurityGroupProvider instead of VirtualRouter provider in physical_network_service_providers table
- For such entries, we update them to point to the VirtualRouter provider in physical_network_service_providers table
2012-07-17 16:16:21 -07:00
prachi e2e76c70ec CS-15578 (spinned off from 15495) Upgrade from 2.2.14 -> 3.0.3-> 3.04 failed with exception"mysql.jdbc.exceptions.jdbc4.MySQLIntegrityConstraintViolationException
reviewed-by: kishan

- Add physical network to the removed data_center as well and mark it as removed, to avoid foreign constraint failures
- Since rest all stuff related to multiple physcial networks is done based on networks having non-null removed field, nothing will apply to this zone.
2012-07-16 16:05:13 -07:00
prachi 3f1283fdaf CS-15407 [2.2.14 to 3.0.4 upgrade] After upgrade VLAN allocation doesn't happen properly for multiple physical networks
Reviewed-By: Alena

Changes:
- Upgrade insturctions updated to secify 'isolated' networks
2012-07-13 11:29:52 -07:00
Murali Reddy ead38c43af bug CS-15495: upgrade from 2.2.14 to Bonita(3.0.3 GA/304) failed with CloudRuntimeException
Reviewed-By: Abhi
handling the F5 and SRX hosts which are deleted in a data center while upgrade
2012-07-12 23:05:17 -07:00
Koushik Das 04b0930659 Fix for CS-15279.
Issue happens when ROOT volume gets created and there is subsequent failure in starting the VM. During retry if allocator assigns a different storage pool the scenario was not handled. Now in case of local storage the volume get recreated on the newly assigned pool and old one gets cleaned up. In case of shared storage the existing volume is migrated to new storage pool.

Reviewed-by: Prachi, Edison, Nitin
2012-07-13 11:24:58 +05:30
prachi 1378223967 CS-15476: Multiple physical networks are created with same label (to same NIC) after upgrade
Reviewed-By: Alena

Changes:
- Error out upgrade when we find there will be multiple physical networks with same traffic label
2012-07-12 16:49:56 -07:00
prachi ff1dba0ec3 CS-15407 [2.2.14 to 3.0.4 upgrade] After upgrade VLAN allocation doesn't happen properly for multiple physical networks
Reviewed-By: Alena

- Update instructions for setups with multiple physical networks and guest vnets
- if there are such setups upgraded to 3.0.3 and face problems starting VMs, then they need to roll back to 2.2.14 and carry out the instructions and then upgrade to 3.0.4
2012-07-12 16:49:55 -07:00
prachi 65d43a37da CS-15516 com.cloud.utils.exception.CloudRuntimeException: Exception while adding PhysicalNetworks : Caused by: java.sql.SQLException: No value specified for parameter 1
Reviewed-By: Prachi

- Same bug in 303 to 304.
2012-07-10 10:39:15 -07:00
prachi ab6c234b62 CS 15516: com.cloud.utils.exception.CloudRuntimeException: Exception while adding PhysicalNetworks : Caused by: java.sql.SQLException: No value specified for parameter 1
Reviewed-by: Prachi

Changes:
Missed on setting the zoneId parameter.
2012-07-10 08:18:29 -07:00
prachi 9ea905b620 CS-15404 [2.2.14 to 3.0.4 upgrade] After upgrade cloud.physical_network.id starts from 200 which is not the case with fresh installation
Reviewed-By: Alena

Changes:
- We need to set the id while creating physical network entry.
2012-07-09 15:01:03 -07:00
prachi 31ba107338 CS-15406 [2.2.14 to 3.0.4 upgrade] Hosts going to Alert state after upgrade as it cann't find any name-label set to "cloud-private"
Reviewed-By: Alena

Changes:
- Looks like we cannot default to 'cloud-private' label.
- If it is not set, CS figures out the default management interface and usus its name.
- We will use the global config variable as the label. if it is null, the label on the physical network will be null.
2012-07-09 14:57:41 -07:00
Devdeep Singh 3f7911d569 CS-15429: Create instance should fail if it results in exceeding volume resource limits for a user/domain-admin.
Additional fix needed if an instance is being created from an ISO. If an instance is created from an iso disk
offering id not null and only one root volume disk is created. Making a fix to pass the right resource count
for an instance being created from an iso.

Reviewed-By: Rajesh
2012-07-09 17:43:04 +05:30
Deepti Dohare 9ad450e0f7 Merge branch '3.0.3' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 3.0.3
reviewed-by: deepti
2012-07-06 17:41:41 +05:30
Koushik Das 751304b263 Fix bug CS-15261.
In case IP address is passed to deployVirtualMachine API, the default property on NIC was not getting set and as a result there was a failure down the line and VM creation was failing.
Reviewed-by: Abhi
2012-07-06 15:46:21 +05:30
Deepti Dohare da2f5b83c5 CS-15430 Create snapshot should fail if creating snapshot results in exceeding snapshot resource limit for domain-admin or user accounts
Reviewed-by: devdeep.singh@citrix.com
Change:
1. Before creating the snapshot, we synchronized checkresourcelimit to allow the users to create the snapshot and increment the resource count.
2. Depending on the failure of snapshot creation/ backup, we are decrementing the resource count.
2012-07-06 15:20:02 +05:30
prachi 63491fb893 CS-15407 [2.2.14 to 3.0.4 upgrade] After upgrade VLAN allocation doesn't happen properly for multiple physical networks
Reviewed-by: Alena

Changes:
- If a 2.2.14 setup uses guest vnet and has multiple network tags, we cannot upgrade this to 3.0.x since on upgrade we dont know how to assign the vnets to physical networks
- So we error out and provide instructions
- If an already upgraded 3.0.3 setup has this some guest networks using vnet but the assignment of vnet to physical network is wrong, upgrade to 3.04 will detect it and error out with further steps
2012-07-06 00:03:34 -07:00
prachi 61830aef95 CS-15450: vmware:upgrade fails from 2.2.14GA to 3.04
CS-15414 [upgrde from 2.2.14 to 3.0.4] Need to decrypt xen.guest.network.device value before setting the traffic label after upgrade.

Reviewed-by: Alena

- This uncovered a generic case where only 1 network tag is used and other few untagged networks.
- Upgrdae 303 to 304, should create a physical network for the untagged networks.
- Earlier we were doing this only if the 303 db has multiple physical networks. But in this case the 303 db will  have just 1 physcial network (created due to the single tag used on 2.2.14).
- So  we need to create the extra physical network for the untagged networks irrespective of the number of physical networks present in 303 db.

- This commit also take care of the decryption of the xen.guest.network.device value
2012-07-05 15:43:25 -07:00
Deepti Dohare 09d9bacce4 CS-15429: Create Instance should fail if creating instance results in exceeding volume resource limit for domain-admin or user accounts
Reviewed-by: devdeep.singh@citrix.com
Change: Adding a check for diskOfferingId
2012-07-05 11:00:19 +05:30
prachi aeee0f6d33 CS-15396: [2.2.14 to 3.0.4 upgrade] data_center table doesn't contain "uuid" after upgrade
Reviewed-By: Sheng Yang

Changes:
- Add uuid to data_center while upgrading from 2.2.14 to 3.0x.
- For previous setups that have already been updated, correctly add the uuid in 304 upgrade
2012-07-02 13:47:47 -07:00
Deepti Dohare 4840918cfb CS-15300 Limits on domain admin accounts
Reviewed-by: devdeep.singh@citrix.com

change: fix for listResourceLimits
2012-07-02 20:05:24 +05:30
prachi 7c7aab9807 CS-15381: Upgrade from 3.0.3 to 3.0.4 is failing
CS-15382: Hosts going to Alert state if there were destroyed networks with non-existent tags prior to upgrade

Reviewed-By: Alena P.

Changes:
- If 2.2.14, create the SG provider by looking at is_security_group_enabled flag
- if 3.0.3, create the SG provider by looking at the ntwk_service_map.
2012-07-01 18:09:00 -07:00
Deepti Dohare 13d432fe87 Fix for CS-15300 Limits on domain admin accounts
Reviewed-by: devdeep.singh@citrix.com
2012-06-30 00:17:59 +05:30
prachi acfc1dbd79 Bug 14773 - VM's are unable to start after upgrade from 2.2.14 to 3.0.3
Reviewed-By: Alena P.

Changes:
- Added upgrade path to 304. This would check the missing portions of the previous upgrades and try to correct.
- This will check if the setup has multiple physical networks with Guest traffic type. If yes then:
- Check if the previous upgrade has left behind any guest networks that were untagged in 2.2.14. For such networks, add a new physical network
- Check if the multiple physical network has tags. If no add tag and clone the network offerings for the networks on this physical network and add this tag to them
- Also clone the network offering service map.
- Thus this creates copies of offerings for each physical network.
2012-06-26 15:39:45 -07:00
prachi a8108823f6 CS-15239 vmware:noticed nullpointer exception when we put host in maintenance mode in clustered management setup
Reviewed-By: Kelven

Changes:
- Use of class variable of type GenericSearchBuilder causes issues when multiple threads invoke this method to findCapacity
- Changing the scope of the variable to be local to these methods.
2012-06-06 15:03:40 -07:00
Nitin Mehta fc82d5fd64 bug CS-14156: While listing Pods Having Vms for an Account during userconcentratedpod_firstfit allocation look for starting and stopping states of vms as well.
Reviewed-by: Prachi
2012-06-06 22:06:45 +05:30
kishan f19d8d0084 bug CS-15221: Encrypt config value before changing category to Hidden. Regression due to af1fc1cf5d361cb6d43e0107a644c42f645a0ccc
status CS-15221: resolved fixed
reviewed-by: Nitin
2012-06-05 14:41:06 +05:30
Alena Prokharchyk 79cdb23301 CS-15220: fixed db upgrade for networks using external devices
Reviewed-by: Sheng Yang
2012-06-04 19:20:34 -07:00
frank 26fc280d7b CloudStack CS-15222
Rebalancing of hosts fails with "java.lang.ClassCastException:" since SSVM host gets picked up for rabalacing.

fixed
reviewed-by: edison
2012-06-04 18:22:46 -07:00
frank 2c0dd7dbaa CloudStack CS-15195
Multinode Management server - Not able to put the host in maintanace mode when the request is issed from the management server that is not the owner of the host

resolved fixed
reviewed-by: edison
2012-06-04 11:48:23 -07:00
Murali reddy e8531f5bf7 bug CS-15196: Upgrade Failed 2.2.14 -> Bonita CloudStack-tag-3.0.3-prerelease1-3.0.3-0.2549-rhel5 : Caused by: java.sql.SQLException:
status CS-15196: resolved fixed
Reviewed-by: Nitin
2012-06-04 22:38:17 +05:30
Kelven Yang 3d8a14fce6 bug CS-15191: remove a sanity check that prevent us from getting traffic lable under VMware
Reviewed-by: anthony
2012-06-01 10:34:17 -07:00
sateesh 3f9180d13e CS-14938 Trying to detect the traffic label for public network while adding Cluster with Nexus Vswitch in Basic Zone network
Status CS-14938: resolved fixed
Reviewed-by: Devdeep
2012-06-01 15:20:28 +05:30
Vijayendra Bhamidipati 7065c17910 CS-15173: Additional Cluster is allowed to add with the same VSM IPaddress as the previous cluster
reviewed-by: Sateesh
Description:

	Missed deletion of cluster record in case of failure in
	validation of vsm:cluster mapping restriction.
2012-05-31 23:46:35 -07:00
Vijayendra Bhamidipati 00dfebf26c CS-15173: Additional Cluster is allowed to add with the same VSM IPaddress as the previous cluster
reviewed-by: Vijay
Description:

	Fixing null pointer exception introduced by previous
	checkin.
2012-05-31 17:32:49 -07:00
Vijayendra Bhamidipati ea23f52003 CS-15173: Additional Cluster is allowed to add with the same VSM IPaddress as the previous cluster
reviewed-by: Vijay
Description:

	Restricting association of a Cisco Nexus VSM to a single
	cluster.
2012-05-31 13:49:48 -07:00
Kelven Yang 0b210f0602 CS-15080: VMware control network is CloudStack management network, correct the way to send down a correct traffic label to VMware resource
Reviewed-by: Anthony
2012-05-31 11:32:23 -07:00
Murali reddy 5ffaac9c4c bug CS-15144: Upgrade 3.0.1 -> Bonita 3.0.3 with F5 and SRX devices failed
status CS-15144: resolved fixed
reviewed-by: Murali
2012-05-31 20:11:11 +05:30
kishan 0a4f635d88 bug CS-15168: Use cagetory from DB instead of Config.java, set category to Hidden during upgrade if they are not already
status CS-15168: resolved fixed
reviewed-by: Nitin
2012-05-31 14:34:41 +05:30
prachi 5bb3257719 CS-14156: Handle UserConcentratedPod for DOMR creation
Reviewed-By: Alena

Changes:
- corrected the account being set in vmProfile as owner of the VM.
- It was set to the caller of the start Vm method. However in case of routers, the caller account is System account while the router owner is the network owner account.
2012-05-30 15:45:08 -07:00
prachi 13faf93287 CS-13944 : 2.2.x - 3.0 db upgrade for multiple physical networks
Reviewed-By: Alena

Changes:
- need to add physical network referrence to public vlan entries.
2012-05-29 17:03:38 -07:00
Sateesh Chodapuneedi 9ef5a2767d CS-14956 Support for rate limiting policies in Nexus dvSwith feature for CloudStack
Removed global parameters that are not required. Cleanup.
Reviewed-by: Devdeep
2012-05-26 05:28:17 +05:30
Kelven Yang f6d7c96e7d bug 15080: check traffic type in host discovery stage - cluster level checks
Reviewed-by: Anthony
2012-05-25 10:56:06 -07:00
Kelven Yang 95766bef1d bug : CS-15080 - check traffic label at host discovery stage also
Reviewed-by: anthony
2012-05-25 10:56:05 -07:00
Alena Prokharchyk 5d888a44ba CS-15082: changed search criteria for Running vms in Network. Ip4 Address for guest network can be null for nic in Basic zone when vm originally fails to start.
Reviewed-by: Frank
2012-05-25 10:19:32 -07:00
Vijayendra Bhamidipati d584018d32 CS-9919: Support for Nexus Swiches (Cisco Vswitches)
reviewed-by: vijay
Description:

	Incorporating Salvatore's review comments.
2012-05-25 09:44:43 -07:00
Nitin Mehta a268af4298 bug CS-14945: Throw an error message if the user is trying to attach the volume in local only storage zone.
Reviewed-by: Kishan
2012-05-25 18:49:53 +05:30
Vijayendra Bhamidipati f16bd16077 CS-9919: Support for Nexus Swiches (Cisco Vswitches)
reviewed-by: Vijay

Description:

	Deleting the row in cluster_vsm_map after
	a cluster is deleted, if the cluster type
	is vmware and the global vswitch nexus
	config flag is set to true.
2012-05-24 13:58:44 -07:00