Commit Graph

387 Commits

Author SHA1 Message Date
alena abb8f45667 1) Return embedded object for upgradeRouter command
2) Build response objects in ApiResponseHelper for stop/start/reboot/list router/systemVm commands
2010-11-02 19:47:14 -07:00
Alena Prokharchyk 694a8231ef Build responses in ApiResponseHelper for the deploy/start/stop/reboot/recover/listVm create/list snapshot/snapshotPolicies 2010-11-02 18:16:45 -07:00
abhishek c6809f89d4 bug 6890: preventing users from searching for system account details via the list api
status 6890: resolved fixed
2010-11-02 17:59:24 -07:00
alena 571ca42c44 1) Return embedded object for addCfg/updateCfg/listCfg.
2) Fixed NPE in updateCfg command (used to happen when no value was specified)
3) Fixed addCfg command to call correct getName method while setting config name (used to call the method returning the command name)
2010-11-02 15:26:33 -07:00
Alex Huang 5fe5450abc even more refactoring 2010-11-02 15:25:07 -07:00
abhishek d4b33f523d bug 5190: changes from the ui perspective; we upload the entire cert as a string, instead of reading it from a file. Then, we process the cert via ip streams instead of fileinputstreams. Moved the cert validation to before cert persistance, and also added more logging and exception catch blocks to deal with IO exceptions that might arise out of the ip stream processing for the new change. 2010-11-02 14:48:05 -07:00
alena 0c044a10d1 Moved response building for ServiceOffering/ResourceLimit commands to ApiResponseHelper class. 2010-11-02 11:59:10 -07:00
abhishek 85f78d8cb3 bug 6886: fixing the npe which occurs when we try to delete a non existant user. We were trying to return user details for an async job desc assuming the user always existed. Changing that logic to ensure when we don't have such details, we log the apt message
status 6886: resolved fixed
2010-11-02 11:20:52 -07:00
alena 6c3256d1e4 1) Return embedded objects for enable/disable/lock/update Account/User and updateDomain
2) Added "haschild" return parameter to Domain response.
3) Fixed updateDomain command - used to set domainname to "updatedomainnameresponse" value if no name was specified in the request. Added more logging for updateDomain command.
2010-11-01 23:49:57 -07:00
alena 5d4e4be974 1) Created ApiResponseHelper class - all api response objects should be built there.
2) Removed isMirrored tag from the update/create/listDiskOffering commands
2010-11-01 23:49:57 -07:00
abhishek 45f4499c14 bug 6836: fixing the api responses for disk offerings. We were using the wrong objext name, and were only returning success responses. Now, we are constructing the apt object and returning the entire object back.
status 6836: resolved fixed
2010-11-01 13:24:28 -07:00
abhishek f70b55daa2 bug 6380: removing the code which returns hostid and hostname, as on a stopped vm, we do not have any association of the vm to the host 2010-11-01 12:16:53 -07:00
root bee976b5f5 bug 6779: returning the deviceId wherever possible, in the xxxVolume() calls
status 6779: resolved fixed
2010-11-01 11:12:03 -07:00
Chiradeep Vittal 1e0eb04442 Add VPN apis, some systemvm changes for vpn 2010-11-01 10:27:49 -07:00
abhishek c74fd77730 putting in final comments, so that the code to be checked in is better readable for others trying to understand it 2010-11-01 09:06:32 -07:00
abhishek 362e67d724 adding failover protection case for when the mgmt svr crashes in the middle of executing something; along with custom response for cert 2010-11-01 09:04:51 -07:00
root 3752a4eb31 making the logic more robust, testing more corner cases, improving efficiency and changing the schema 2010-11-01 09:04:51 -07:00
kishan 3a0f30a049 bug 6408: remove security groups/port forwarding service in virtual network case
status 6408: resolved fixed
2010-11-01 14:28:03 +05:30
Kris McQueen 24551eea3a Add constants for API command parameter names and for API response parameter names. Update the commands with the new constants rather than custom strings. Update several of the responses with the constants. Not all the responses have been updated, this is still work in progress... 2010-10-29 17:20:40 -07:00
Kris McQueen a9349cb815 bug 6857: if the dispatcher recieves an IllegalArgumentException, bubble that up to the response so the caller gets a useful message 2010-10-29 14:07:23 -07:00
Kris McQueen 88dac13bb0 use the API response date format when serializing response objects 2010-10-29 13:23:29 -07:00
will 9cc5aaa978 Fixed listTemplates to use the template type. 2010-10-29 13:17:32 -07:00
Kris McQueen ebac4539d0 it's possible createSnapshotDB will return null, handle that case. However, if createSnapshotDB returns null because there was no work to do (empty snapshot) we should probably throw an exception that reports that fact instead of returning null and throwing an internal error 2010-10-28 17:52:37 -07:00
Kris McQueen 642b8a56f4 If the create command returns null for whatever reason, throw an exception so it aborts scheduling the async job to act on the created object 2010-10-28 17:52:37 -07:00
Kris McQueen 2f9e91a9ae bug 6738: honor groupid when listing vms (restrict the list to just that group)
status 6738: resolved fixed
2010-10-28 16:27:07 -07:00
Kris McQueen 7531525252 Add commented code out for the old style (2.1.x) JSON async job responses. The XML responses are still a TODO. In order to get this to fully revert back to 2.1.x style responses, some commands will need to be modified to set the responseName to be something like getResultObjectName(), and there's an example of this in StopVMCmd. 2010-10-28 14:32:13 -07:00
Kris McQueen 9eb851db60 bug 6809, 6712: standardize the domain router response to use guestmacaddress instead of macaddress
status 6809, 6712: resolved fixed
2010-10-28 14:32:13 -07:00
will c5fef26f11 ListTemplates will no longer return any SystemVM templates. I am using a startsWith() string match for now since we used to make this comparision by ID with a single hypervisor. 2010-10-28 13:28:33 -07:00
will f0a4449ec3 ListTemplates now return the hypervisor type. 2010-10-27 19:50:36 -07:00
Kris McQueen 50c175d6c1 bug 6799: forgot to add the exception response in my commit for this bug... 2010-10-27 18:23:23 -07:00
Kris McQueen 9056653e17 Change the API Implementation annotation to use the manager's class rather than an enum. This allows methods for new managers to be added trivially rather than having to modify the dispatcher to load a new manager class. 2010-10-27 12:23:31 -07:00
Kris McQueen ae9b6d4fe1 bug 6776: for some reason, we checked for zoneId = -1 in registerTemplate and applied it to all zones, but this wasn't done for registerIso. Oh well, make the change for registerIso and things seem happy again
status 6776: resolved fixed
2010-10-26 17:55:00 -07:00
Kris McQueen a788d2cb2e bug 6736: rebootSystemVm should return the vm properties, not success true/false.
status 6736: resolved fixed
2010-10-26 17:19:55 -07:00
Kris McQueen 95da86ef1a bug 6733: re-throw ServerApiExceptions when dispatching API commands rather than logging them and throwing a generic INTERNAL_ERROR exception
status 6733: resolved fixed
2010-10-26 16:54:42 -07:00
abhishek c6588c0e25 adding some error return handling to api dispatcher, and cleaning up some of the code paths to return the right error messages 2010-10-26 14:27:26 -07:00
alena afd79a9b1b Code cleanup 2010-10-26 13:59:11 -07:00
Alex Huang f58063911e deploy vm completed 2010-10-26 09:35:24 -07:00
nit 497c60d63d Extending extract functionlity for volumes to allow download. The
extraction can have two modes FTP_UPLOAD and HTTP_DOWNLOAD. In the former one
the user would provide the ftp url where the entity needs to be uploaded and in
the later the user would be provided a HTTP URL where from he/she can download
the entity. This url would be exposed for a specific time limit and would not
function after the time limit
2010-10-26 18:49:43 +05:30
Kris McQueen b3c7821b44 bug 6752: fix updating resource limits for a domain by looking at the given accountName/domainId parameters rather than looking at the caller's account. If updating limits for an account, e.g. account 'foo' in domain 4, then execute updateResourceLimit&account=foo&domainid=4&..., but if updating the limit for a domain, don't specify the account parameter. When processing the command, if accountName is null, the limit for the domain will be properly updated.
status 6752: resolved fixed
2010-10-25 17:32:28 -07:00
Kris McQueen ef131bbc18 bug 6724: set useVirtualNetwork in the createServiceResponse
status 6724: resolved fixed
2010-10-25 17:08:47 -07:00
Kris McQueen f9c1f12778 bug 6725: use serviceOfferingName rather than the API command name when updating the service offering; set memory in the response for UpdateServiceOffering
status 6725: resolved fixed
2010-10-25 17:08:47 -07:00
Kris McQueen 27cafb2957 bug 6727: ostypename was being set from guest_os.name which seems to be null most of the time. Instead, use guest_os.display_name.
status 6727: resolved fixed
2010-10-25 17:08:47 -07:00
Kris McQueen fcb0ff83ac bug 6712: for router responses, change guestmacaddress -> macaddress to preserve behavior from 2.1.x and before.
status 6712: resolved fixed
2010-10-25 16:37:42 -07:00
Kris McQueen 869f3587c3 bug 6714: add displaytext to SuccessResponse so commands that return success true/false can also return a brief description of what took place.
status 6714: resolved fixed
2010-10-25 16:37:42 -07:00
Kris McQueen 3660d6a3d1 bug 6717: updateDiskOffering is supposed to return success true/false rather than the updated disk offering
status 6717: resolved fixed
2010-10-25 16:37:42 -07:00
Kris McQueen c8e9531842 bug 6720: add 'created' to the ListHosts response
status 6720: resolved fixed
2010-10-25 16:37:42 -07:00
Kris McQueen 83e4922b94 bug 6703, 6704: use the correct method signatures for invoking updateTemplate/updateIso and updateTemplatePermissions/updateIsoPermissions APIs. It's possible that the reflection should just use 'isAssignableFrom' when getting methods since the manager methods were using a base class as the parameter rather than UpdateTemplateCmd/UpdateIsoCmd and UpdateTemplatePermissions/UpdateIsoPermissions, but for now the explicit methods are added for simplicity.
status 6703, 6704: resolved fixed
2010-10-25 15:01:50 -07:00
Kris McQueen d229877cd8 bug 6710: rebootRouter was supposed to return the rebooted router, not success/failure
status 6710: resolved fixed
2010-10-25 15:01:50 -07:00
Kris McQueen 18f6d67121 bug 6705, 6708: use the UserVmResponse for changeServiceForVirtualMachine API (UpgradeVMCmd) since the response is a vm. There was no need for a specific UpgradeVmResponse which had scalars instead of objects and the serializer skips null, but will serialize scalars with their default values, in this case 0 for id and host id.
status 6750, 6708: resolved fixed
2010-10-25 15:01:49 -07:00
nit 511a095c26 bug 6487: AttachISO API would return an embedded object on success.
status 6487: resolved fixed
2010-10-25 18:26:39 +05:30