Rajani Karuturi
8bc0294014
Revert "Merge pull request #714 from rafaelweingartner/master-lrg-cs-hackday-003"
...
This reverts commit cd7218e241 , reversing
changes made to f5a7395cc2 .
Reason for Revert:
noredist build failed with the below error:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.2:compile (default-compile) on project cloud-plugin-hypervisor-vmware: Compilation failure
[ERROR] /home/jenkins/acs/workspace/build-master-noredist/plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java:[484,12] error: non-static variable logger cannot be referenced from a static context
[ERROR] -> [Help 1]
even the normal build is broken as reported by @koushik-das on dev list
http://markmail.org/message/nngimssuzkj5gpbz
2015-08-31 11:27:57 +05:30
Rafael Weingartner
3818257a68
Solved jira ticket: CLOUDSTACK-8750
2015-08-28 22:35:08 -03:00
Mike Tutkowski
b1905c2040
CLOUDSTACK-8698: Retrieve a new device ID, if needed
2015-08-05 13:58:22 -06:00
Daan Hoogland
bb613baa2b
findbugs: repeated condition seems c&p error the tested states sugest that EXPUNGED should be the last one
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #491
2015-06-19 15:26:53 +03:00
Rajani Karuturi
bd71fcb650
Fixed two coverity reported issues
...
Dereference after null check
Dm: Dubious method used
This closes #219
2015-05-01 16:08:26 +05:30
Rajani Karuturi
0b8355920e
Merge branch 'volume-upload' into master
...
This closes #206
2015-04-29 11:12:53 +05:30
Rajani Karuturi
75ae90b073
volume-upload: added account level secondary storage resource limit checks
2015-04-24 15:48:44 +05:30
Rajani Karuturi
f172fbef8a
Bug-Id: CS-39350 Able to upload Volume greater than the Resource limit defined for Primary Storage.
...
Reviewed-By: Harikrishna Patnala <harikrishna.patnala@citrix.com>
2015-04-20 13:01:19 +05:30
Rajani Karuturi
4f35d3611a
volume upload: fixed the error message incase of wrong image format
2015-04-16 17:43:46 +05:30
Koushik Das
4338bea070
volume upload: cannot delete a volume in NotUploaded state
...
Volume deletion is not allowed in NotUploaded or UploadInProgress states, added validation in delete volume API for same
2015-04-14 16:08:54 +05:30
Rohit Yadav
a07497b373
server: fix NPE case in VolumeApiServiceImpl
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit df934c9541 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-04-13 15:47:51 +05:30
Sanjay Tripathi
5f59091418
CLOUDSTACK-8350: Volume attachment failed when user stops the VM during attaching DISK.
2015-03-27 15:26:32 +05:30
Rajani Karuturi
018023c1ef
volume upload: added validation for file formats
...
merged TemplateUtils and ImageStoreUtil to a singe ImageStoreUtil
also added a unittest for ImageStoreUtil
2015-03-20 16:25:13 +05:30
Rajani Karuturi
d5dffb5dc9
volume upload: added md5 checksum validation
...
also fixed the issue wherein the successful uploads where also moving to
error state as the channelinactive is called after the end of successful
upload as well.
added a fileuploaded boolean to check when the channel is inactive.
2015-03-18 12:20:51 +05:30
Rajani Karuturi
b16520bcec
volume upload: added max size check for temaplte/volume post upload
...
used the existing configuration variables max.template.iso.size and
storage.max.volume.upload.size for templates and volumes respectively.
2015-03-03 17:27:40 +05:30
Rajani Karuturi
dd1a8da977
volume upload: Volume entry created in DB even though GetUpload* API fails with "No ssvm present" error
...
Signed-off-by: Rajani Karuturi <rajanikaruturi@gmail.com>
2015-02-27 17:42:32 +05:30
Rajani Karuturi
b616894c21
volume upload: fixed issues during request validation
...
adding the encoded metadata to the signature
2015-02-17 11:50:58 +05:30
Rajani Karuturi
5c4fd12a9b
volume upload: using the timeout from configuration
...
removed the hardcoded 60 min
2015-02-17 11:33:29 +05:30
Rajani Karuturi
3814677977
volume upload: getUploadParamsForVolume url has IP address instead of hostname, SSL fails
2015-02-17 11:31:44 +05:30
Mike Tutkowski
8aa34d048a
Putting in an extra check to see if this volume is already attached to a VM
2015-01-26 17:25:17 -07:00
Mike Tutkowski
e5ffcab09d
Moving the call to getDeviceId(long, long) avoids a race condition when two volumes are being attached to a VM at the same time
2015-01-24 00:36:07 -07:00
Mike Tutkowski
0f84e042b9
Adding support for creating a volume from a snapshot when the snapshot is on managed storage
2015-01-20 15:24:33 -07:00
Rajani Karuturi
15ae33a5b6
volume upload: refactored post upload command and used it during template registration
2015-01-20 09:24:14 +05:30
Rajani Karuturi
ad6b7b30cb
Volume upload: sending the nfsstore url in the metadata
...
decoding the metadata and deserialising it on receiving it
2015-01-19 18:04:14 +05:30
Koushik Das
7900ae5d9f
volume-upload: initializing state for volume and also setting the post url in volume_store_ref
2015-01-19 11:03:42 +05:30
Rajani Karuturi
1ae34d98d4
volume upload: fixed circular reference error while generating json
2015-01-13 10:41:39 +05:30
Likitha Shetty
15b348632d
CLOUDSTACK-8129. Cold migration of VM across VMware DCs leaves the VM behind in the source host.
...
If VM has been cold migrated across different VMware DCs, then unregister the VM from source host.
2014-12-26 11:07:30 +05:30
Likitha Shetty
a5a65c7b55
CLOUDSTACK-8122. Handle NPE thrown during migration failures.
...
When migration fails instead of returning NULL, throw the exception.
2014-12-24 13:33:11 +05:30
Likitha Shetty
4d7ede535d
CLOUDSTACK-8119. Propagate error message to UI for attach/detach volume failure operations.
...
For AttachVolume/DetachVolume API command, improve user error message in case of RuntimeException by throwing the exception instead of 'Unexpected Exception'.
2014-12-24 11:29:03 +05:30
Rajani Karuturi
3e594c4e4f
volume upload: removed unused variables
2014-12-19 12:44:56 +05:30
Rajani Karuturi
9bb6cf8452
volume upload: persisting the volume metadata
...
on calling GetUploadParamsForVolume, persisting the metadata to db
validating the account limits and incrementing the appropriate limits
encoded the metadata on management server using preshared key
2014-12-18 17:50:51 +05:30
Edison Su
5a10a4725d
add event for volume migration
...
Reviewed-by: Frank
2014-12-17 14:33:06 -08:00
Prachi Damle
f5d4736c87
CLOUDSTACK-8079: If the cluster capacity threshold is reached, HA-enabled VM is not migrated on another host during HA
...
Changes:
- When there is HA we try to redeploy the affected vm using regular planners and if that fails we retry using the special planner for HA (which skips checking disable threshold)
Now because of job framework the InsufficientCapacittyException gets masked and the special planners are not called. Job framework needs to be fixed to rethrow the correct exception.
- Also the VM Work Job framework is not setting the DeploymentPlanner to the VmWorkJob. So the HA Planner being passed by HAMgr was not getting used.
- Now the job framework sets the planner passed in by any caller of the VM Start operation, to the job
2014-12-17 11:43:07 -08:00
Min Chen
528bc80b4c
CLOUDSTACK-8061: Extracting volume when it is in migrating state causes
...
both the operations to fail.
2014-12-11 09:53:33 -08:00
Wei Zhou
fc1a09ff49
Add snapshotName parameter in CreateSnapshotCmd
2014-12-04 15:29:39 +01:00
Damodar
7b8fe0c8cd
Attach volume events are not correctly shown in events.
...
Signed-off-by: Koushik Das <koushik@apache.org>
2014-12-04 19:31:03 +05:30
Min Chen
9ac93d3e43
CLOUDSTACK-7678:volumes are getting uploaded successfully with wrong url.
2014-11-21 14:36:36 -08:00
Edison Su
2ccecce515
CLOUDSTACK-7946:
...
fix compile
2014-11-19 16:09:30 -08:00
Devdeep Singh
cffae8eef0
CLOUDSTACK-6924. To attach a volume if a volume needs to be moved to another storage
...
pool, the source and destination pools cannot be local and cluster/zone and vice versa.
Cloudstack detects it and throws a exception. However, the end user only sees an
unexpected exception and not the reason for failure. Fixed it by making sure the
reason for the failure is correctly captured and shown to the end user.
2014-11-14 11:19:19 +05:30
Damodar
781648fb10
CLOUDSTACK-7792: Usage Events to be captured based on Volume State Machine
2014-11-10 15:19:02 +05:30
Min Chen
684889f0b5
CLOUDSTACK-7833: VM Async work jobs log "Was unable to find lock for the key vm_instance" errors as warning
2014-11-03 10:52:47 -08:00
Kishan Kavala
99010f463b
CLOUDSTACK-7265: For LXC volumes, show unsupported operation error for volume snapshot
2014-11-03 17:20:00 +05:30
Rohit Yadav
62f9bf0fff
PR #26 CLOUDSTACK-7688, CLOUDSTACK-7747
...
Restricted various operations for VM with VM Snapshots #26
This closes #26
2014-10-30 15:11:57 +05:30
Anshul Gangwar
d8b46b81b9
CLOUDSTACK-7767: fixed events are not generated for snapshot creation
2014-10-30 13:25:06 +05:30
Anshul Gangwar
a4d8215ebb
CLOUDSTACK-7688, CLOUDSTACK-7747: restricted various operations for VM with VM snapshots which breaks VM snapshots.
...
Now they are informed that they cannot perform the operation.
To perform operation they have to remove VM snapshots of VM.
2014-10-30 12:37:50 +05:30
Mike Tutkowski
57dacf99a2
Changed "boolean connectVolumeToHost(VolumeInfo, Host, DataStore)" to "boolean grantAccess(DataObject, Host, DataStore)"
...
Changed "void disconnectVolumeFromHost(VolumeInfo, Host, DataStore)" to "void revokeAccess(DataObject, Host, DataStore)"
2014-10-21 16:01:14 -06:00
Daan Hoogland
1de0cb7094
restore barematel work after merge
2014-10-17 10:24:01 +02:00
Nitin Mehta
a6d575b127
CLOUDSTACK-7699: Disable ROOT volume attach/detach ability.
2014-10-13 13:57:45 -07:00
Likitha Shetty
54110edda1
CLOUDSTACK-6969. Data Volume Shrink operation failing with "Unexpected Exception".
...
(cherry picked from commit bca71ec169 )
2014-10-13 00:14:09 -04:00
Devdeep Singh
549840dd0d
CLOUDSTACK-7495. Volume resize is only supported on kvm, vmware and xenserver. If
...
the operation is tried on other hypervisors it fails but logs a stack trace. We
should just log a message that the operation isn't supported.
(cherry picked from commit ec1123aca1 )
2014-10-13 00:01:55 -04:00