Commit Graph

12548 Commits

Author SHA1 Message Date
Jtolelo ae455ee193 VPC restart cleanup for Public networks with multi-CIDR data (#12622)
* Fix VPC restart with multi-CIDR networks: handle comma-separated CIDR in NetworkVO.equals()

When a network has multiple CIDRs (e.g. '192.168.2.0/24,160.0.0.0/24'),
NetworkVO.equals() passes the raw comma-separated string to
NetUtils.isNetworkAWithinNetworkB() which expects a single CIDR,
causing 'cidr is not formatted correctly' error during VPC restart
with cleanup=true.

Extract only the first CIDR value before passing to NetUtils.

* Fix root cause: skip CIDR/gateway updates for Public traffic type networks

addCidrAndGatewayForIpv4/Ipv6 (introduced by PR #11249) was called for all
network types without checking if the network is Public. This caused
comma-separated CIDRs to be stored on Public networks, which then triggered
'cidr is not formatted correctly' errors during VPC restart.

Add TrafficType.Public guard in both the VLAN creation (addCidr) and
VLAN deletion (removeCidr) paths in ConfigurationManagerImpl.

* Sanitize legacy network-level addressing fields for Public networks

---------

Co-authored-by: dahn <daan@onecht.net>
2026-04-13 15:40:26 +02:00
Suresh Kumar Anaparti 47c5bb8ee7 Support list/query async jobs by resource (#12983)
* Add resource filtering to async job query commands

* Fix logical condition in AsyncJobDaoImpl and ResourceIdSupport

* resource type case-insensitive validation

* fix resource type and id search

---------

Co-authored-by: mprokopchuk <mprokopchuk@gmail.com>
Co-authored-by: mprokopchuk <mprokopchuk@apple.com>
2026-04-13 15:39:49 +02:00
Manoj Kumar b196e97cc3
Prevent deletion of account and domain if either of them has deleted protected instance (#12901) 2026-04-10 15:51:22 +02:00
Abhisar Sinha df7ff97271
Create volume on a specified storage pool (#12966) 2026-04-10 14:27:39 +02:00
Bernardo De Marco Gonçalves 27e4d979f1
Clean up backup references to their schedules when the schedules are deleted (#12401)
* clean up backup schedule references after their deletion

* drop unused column

* address reviews
2026-04-10 14:51:52 +05:30
Nicolas Vazquez b5858029bb
Fix listing service offerings with different host tags (#12919) 2026-04-09 10:55:47 +02:00
Daman Arora 7ba5240b31
Block backup deletion while create-VM-from-backup or restore jobs are in progress (#12792)
* Block backup deletion while create-VM-from-backup or restore jobs are in progress

* Add tests

* Fix exception message

* Update test

Co-authored-by: Abhisar Sinha <63767682+abh1sar@users.noreply.github.com>
2026-04-09 11:09:01 +05:30
Wei Zhou 470812100e
server: set template type to ROUTING or USER if template type is not specified when upload a template (#12768) 2026-04-02 09:34:28 +05:30
Suresh Kumar Anaparti e10c066cc1
Fix NPE during VM setup for pvlan (#12781)
* Fix NPE during VM setup for pvlan

* review comments
2026-04-01 16:29:44 +02:00
Suresh Kumar Anaparti 68030df10b
VM start error handling improvements and config to expose error to users (#12894)
* VM start error handling improvements, and config to expose error to user

* refactor
2026-03-27 15:35:08 -03:00
Nicolas Vazquez c1af36f8fc
[4.22] Prevent unmanaging or reinstalling a VM if it is part of a CKS cluster (#12800) 2026-03-26 18:17:49 +05:30
Suresh Kumar Anaparti 84676afd5c
Check for null host before proceeding with VM volume operations in managed storage while restoring VM (#12879) 2026-03-26 07:58:52 -03:00
Suresh Kumar Anaparti 7c3637a2f5
Fix duplicate dummy templates, and update guest os for dummy template (#12780)
* Fix duplicate dummy template 'kvm-default-vm-import-dummy-template' entries

* Update guest os id of dummy template to 99 (Other Linux (64-bit)) from existing id: 1 (CentOS 4.5 (32-bit))

* update migration path to remove duplicate dummy templates
2026-03-24 18:01:26 +05:30
Nicolas Vazquez 7107d28db8
[VMware to KVM] Add guest OS for importing VM based on the source VM OS (#12802) 2026-03-24 15:06:38 +05:30
Suresh Kumar Anaparti bce55945ec
Mark VMs in error state when expunge fails during destroy operation (#12749)
* Mark VMs in error state when expunge fails during destroy operation

* fetch volume by external id (used by external plugins)

* review comments

* Update reorder hosts log to DEBUG, log line is too verbose to have on as INFO
2026-03-24 00:29:14 -03:00
Manoj Kumar e93ae1a4f4
New config key "allow.import.volume.with.backing.file" to skip volume backing (#12809)
* Added support for skipping volume backing when importing unmanaged volumes and VMs. This allows users to import volumes and VMs without creating a backing volume, which can be useful in certain scenarios where the backing volume is not needed or desired.

* cleanup conflicting key

* move configkey into VolumeImportUnmanageService

---------

Co-authored-by: rajujith <rajujith@gmail.com>
2026-03-17 11:34:34 -03:00
Nicolas Vazquez 09ee0927e9
[4.22] Prevent Load Balancer rule creation when adding a VM from a different network (#12785) 2026-03-16 09:36:52 +01:00
Abhishek Kumar c3d6a8cff7
server: fix templatetype during iso upload (#12151) 2026-03-09 14:20:28 +05:30
Suresh Kumar Anaparti 65e54091ff
Merge branch '4.20' into 4.22 2026-03-04 21:12:15 +05:30
Suresh Kumar Anaparti 56dc11980f
test_accounts.py failure fix - keep the camelCase parameter "domainId" (#12689) 2026-02-27 11:36:18 +01:00
Suresh Kumar Anaparti b74f21b967
Merge branch '4.20' into 4.22 2026-02-26 11:11:41 +05:30
Erik Böck c748b69e70
Fix NPE during public IP listing when a removed network or VPC ID is informed for associatenetworkid parameter (#12372) 2026-02-23 13:03:36 +01:00
Erik Böck d0543449a6
Changes to the error message displayed during the removal of public templates that are used (#12373) 2026-02-23 11:21:04 +01:00
dahn da7ac80dc4
prevent user.uuid from being regenerated on each operation by reading it from the DB (#12632) 2026-02-23 11:12:13 +01:00
Suresh Kumar Anaparti 5caf6cd043
Merge branch '4.20' into 4.22 2026-02-19 13:19:14 +05:30
Suresh Kumar Anaparti 9dd93cef76
Support for custom SSH port for KVM hosts from the host url on add host and the configuration (#12571) 2026-02-18 20:05:51 +01:00
Suresh Kumar Anaparti 8c12a13216
Fix NPE during reset password (#12585) 2026-02-18 20:03:36 +01:00
Daan Hoogland 11df71e55c Merge branch '4.20' into '4.22' 2026-02-17 11:53:08 +01:00
Pearl Dsilva ae5308bdd2
Fix issue when restoring backup after migration of volume (#12549) 2026-02-13 15:14:58 +01:00
Fabricio Duarte 34f6f413a1
Fix injection of preset variables into the JS interpreter (#12515) 2026-02-11 16:12:09 +01:00
Nicolas Vazquez b7c970f45f
Fix issue with multiple KVM Host entries in host table (#12589) 2026-02-11 13:47:21 +01:00
Daan Hoogland 7324ef45d4 Merge branch '4.20' into 4.22 2026-02-09 13:05:08 +01:00
Pearl Dsilva a0f35a186d
Fixes issue with loading Capacity dashboard when mulitple backup providers configured (#12550) 2026-02-09 12:12:28 +01:00
Daan Hoogland cd6a8f61ca Merge branch '4.20' into 4.22 2026-02-05 15:32:36 +01:00
Abhisar Sinha 9ae696d1c8
Preserve VM settings on Instance Snapshot revert for Custom Service Offering (#12555) 2026-02-03 14:15:09 +01:00
Suresh Kumar Anaparti ce42ce54c2
Fix template details deletion while updating template from UI (#12559)
* Fix template details deletion while updating template from UI

* update the latest template details before submit
2026-02-03 14:21:43 +05:30
Wei Zhou b869913529
noVNC: support Spanish Latin American keyboard on VMware (#12484)
* noVNC: support Spanish Latin American keyboard

* Update server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
2026-02-02 15:16:54 +05:30
Suresh Kumar Anaparti 30d306622a
Merge branch '4.20' into 4.22 2026-01-30 21:15:21 +05:30
Suresh Kumar Anaparti 6bed3d4e64
Update storage usage / size in backup usage response (#12539) 2026-01-30 13:45:59 +01:00
Suresh Kumar Anaparti f5778eaa32
Merge branch '4.20' into 4.22 2026-01-29 19:41:29 +05:30
Fabricio Duarte 7d52cd0e43
Fix calculation of the next time that Usage will execute in `removeRawUsageRecords` (#12518)
* Fix calculation of the next time that Usage will execute in `removeRawUsageRecords`

* Address copilot reviews
2026-01-29 15:38:12 +02:00
Wei Zhou aef3df7577
server: pass network label of physical network when plug nic for private gateway on hypervisor (#11846) 2026-01-29 14:47:08 +02:00
Abhishek Kumar 3626c515e8
server: fix listing resource limits (#12188) 2026-01-29 12:36:16 +01:00
Suresh Kumar Anaparti d700e2db64
Merge branch '4.20' into 4.22 2026-01-29 15:51:58 +05:30
Suresh Kumar Anaparti 26b57655ec
Deployment plan fixes for VM with last host, and last host in maintenance (#12062)
* Deployment plan fixes for VM with last host
- Consider last host when it is not in maintenance
- Fail deployment when user requests for last host consideration and last host doesn't exists or in maintenance

* changes

* msg update with vm/host name

* address comments

* Exclude last hosts with error or degraded state as well, for vm deploy

* review changes
2026-01-29 10:29:41 +02:00
Nicolas Vazquez 664f76c7e4
Fix KvmSshToAgentEnabled setting description and make it dynamic (#12533) 2026-01-29 09:24:58 +01:00
Manoj Kumar a8f1e4a5ba
import network acl rules using csv (#12013) 2026-01-29 09:10:28 +01:00
Suresh Kumar Anaparti 65e9bebc69
Show parent snapshot (along with the chain size) for incremental snapshots (#12468)
* Show parent snapshot (along with the chain size) for incremental snapshots

* review

* review changes
2026-01-29 08:16:10 +02:00
Fabricio Duarte b7fc7179fc
Add batch deletion support to `removeRawUsageRecords` (#12522)
* Add batch deletion support to `removeRawUsageRecords`

* Remove ORDER BY from batch expunge
2026-01-29 08:14:05 +02:00
Jeevan 1300fc5e91
Fix keyword parameter filtering in listBackupOfferings API (#12540)
Signed-off-by: Jeevan Yewale <jeevanyewale4@gmial.com>
Co-authored-by: Jeevan Yewale <jeevanyewale4@gmial.com>
2026-01-28 16:26:37 +01:00