Commit Graph

11696 Commits

Author SHA1 Message Date
Abhishek Kumar 4e41394088 refactor
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2024-10-11 18:21:43 +05:30
Abhishek Kumar 8038b28b1c server: indirectagentlb hypervisor type fix
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2024-10-11 17:56:18 +05:30
Abhishek Kumar 47333a7077 Merge remote-tracking branch 'apple/apple-base418' into scalability-improvements 2024-10-11 13:37:12 +05:30
Fabricio Duarte bc42264b34 Restore listNetworks behavior & clean up the code (#9461)
Co-authored-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2024-10-11 12:29:43 +05:30
Abhishek Kumar 0b8ebb08d6 increase expiry
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2024-10-09 17:18:44 +05:30
Wei Zhou 85076cb0f8
Resize volume: add pool capacity disablethreshold for resize and allow volume auto migration (#492)
* server: add global settings for volume resize

* resizeVolume: support automigrate

* server: fix build errors as it is backported from 4.20/main

* Address Suresh's comments

* Update api/src/main/java/org/apache/cloudstack/api/command/user/volume/ResizeVolumeCmd.java

Co-authored-by: Suresh Kumar Anaparti <suresh.anaparti@shapeblue.com>

* Apple issue-299: address Suresh's comments

* Update api/src/main/java/org/apache/cloudstack/api/command/user/volume/ResizeVolumeCmd.java

* UI: add autoMigrate to resizeVolume

---------

Co-authored-by: Suresh Kumar Anaparti <suresh.anaparti@shapeblue.com>
2024-10-09 16:36:33 +05:30
Abhishek Kumar 5f86dad4cb improve cluster overcommit value cache
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2024-10-09 16:28:24 +05:30
Abhishek Kumar f85ac6adf9 add a todo
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2024-10-08 14:30:45 +05:30
Abhishek Kumar a3ea8603a9 during resource calculation directly return ids for service offering,
templates

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2024-10-08 14:28:26 +05:30
Abhishek Kumar 3f6b7b930a during resourcecalculation select specific fields for uservmjoinvo
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2024-10-08 14:27:26 +05:30
Abhishek Kumar a9661f4587 changes in statscollection
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2024-10-07 16:23:15 +05:30
Abhishek Kumar a5d02665b4 changes for host reqrieval from db
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2024-10-07 16:21:06 +05:30
Suresh Kumar Anaparti 7068a6ebeb
Fix root disk resize validation - don't lookup with disk offering id of the root disk in service offering view (#9428) (#489)
Issue: During root disk resize, the root disk size details are checked in a different service offering (looks up with disk offering id of the root disk in service offering view which is getting wrong service offering).
2024-09-24 21:45:03 +05:30
Abhishek Kumar 0151f125aa improvement
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2024-09-23 20:04:34 +05:30
Abhishek Kumar 0ca8722c38 Merge remote-tracking branch 'apple/scalability-improvements' into scalability-improvements-fixes 2024-09-23 14:47:25 +05:30
Abhishek Kumar 1d0b90f984 Merge remote-tracking branch 'apple/apple-base418' into scalability-improvements 2024-09-23 14:45:21 +05:30
Cheng Cheng 9f3380c4be
Add Functionality Enum to HypervisorType (#481)
* Commit for PR https://github.com/shapeblue/cloudstack-apple/pull/471

This PR adds a flag (customType) to HypervisorType to differentiate if a hypervisor plugin is built-in or customized.
With the customType flag, we can isolate conditional checks for allow the customized hypervisor plugin to proceed.

* Add customType field to HypervisorType to differentiate if the plugin is a customized type

* Address @shwstppr's comments

* Define a enum in HypervisorType to indicate specific functionalities of a hypervisor plugin type

* Refactoring to define if the hypervisor supports the operation during
initialization of the HypervisorType.

* Remove ROOT_DISK_SIZE_OVERRIDE_SUPPORTING_HYPERVISORS

---------

Co-authored-by: Annie Li <ji_li@apple.com>
2024-09-18 16:46:06 +05:30
Abhishek Kumar 8941fa550c build fix
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2024-09-17 15:50:14 +05:30
Abhishek Kumar 35ed30bd51 continuation of 1d47e4d4ae
list host IDs instead of complete row where possible

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2024-09-16 18:03:06 +05:30
Abhishek Kumar 99115b9f09 server: cache cluster host type retrievals during connections
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2024-09-13 18:05:54 +05:30
Abhishek Kumar 1d47e4d4ae engine-schema,server,plugins: list host IDs instead whole row where
applicable

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2024-09-13 16:19:43 +05:30
Abhishek Kumar fe4ef05053 server,engine-schema: use single query to to list host capacities while
host capacity update

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2024-09-13 16:17:47 +05:30
Abhishek Kumar e1a5bd9ef2 improve agentlb sort when host list not needed
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2024-09-13 10:25:31 +05:30
Abhishek Kumar ad275e7a36 remove dead code
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2024-09-12 17:21:00 +05:30
Abhishek Kumar eb74974685 more test fix
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2024-09-12 17:00:57 +05:30
Abhishek Kumar 9e5c99ef9e fix tests from a78a2508e9
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2024-09-12 16:58:18 +05:30
Suresh Kumar Anaparti 51fea012ef
NPE fix, for test_hostha_kvm_host_fencing (#479) 2024-09-12 16:45:19 +05:30
Abhishek Kumar a78a2508e9 server: refactor MS list retrieval for agent connect
During agent join and while changing configs - host and indirect.agent.lb.algorithm, optimize calling DB for zone's host list

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2024-09-12 16:00:17 +05:30
Abhishek Kumar 1d11605787 remove todo as configkey caching is implemented
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2024-09-11 13:27:17 +05:30
Abhishek Kumar df137fc387 refactor
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2024-09-10 10:22:59 +05:30
mprokopchuk 31229e770b
Merge pull request #476 from shapeblue/update_host_capacity_vm_update_time_fix
Host capacity calculation: use VM creation time if update time is null
2024-09-09 16:41:59 -07:00
mprokopchuk 2755e338d8
Merge pull request #477 from shapeblue/list_events_sql_error
List Events returns intermittent SQL exception.
2024-09-09 16:41:20 -07:00
mprokopchuk fc79a87050 Fixed code review comments 2024-09-09 15:56:15 -07:00
mprokopchuk 97b07dbaae Fixed code review comments 2024-09-09 15:54:44 -07:00
Abhishek Kumar 61764aba1f cache and executors refactoring
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2024-09-09 19:39:50 +05:30
mprokopchuk 8cabccdbae Fixed listEvents intermittent exception:
com.mysql.cj.jdbc.ClientPreparedStatement: SELECT event_view.id, event_view.uuid, event_view.type, event_view.state, event_view.description, event_view.created, event_view.user_id, event_view.user_name, event_view.level, event_view.start_id, event_view.start_uuid, event_view.parameters, event_view.account_id, event_view.account_uuid, event_view.account_name, event_view.account_type, event_view.domain_id, event_view.domain_uuid, event_view.domain_name, event_view.domain_path, event_view.resource_id, event_view.resource_type, event_view.project_id, event_view.project_uuid, event_view.project_name, event_view.archived, event_view.display FROM event_view WHERE event_view.id IN )
2024-09-04 22:44:04 -07:00
mprokopchuk b9946c28e7 CapacityManagementImpl.updateCapacityForHost(..) use VM update time in capacity calculation.
VM update time is nullable in DB and can cause NullPointerException if record in vm_instance has defined last_host_id and undefined update_time.
2024-09-04 21:21:43 -07:00
Abhishek Kumar 060a8ca623 fix
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2024-09-03 17:56:03 +05:30
Abhishek Kumar 4f1eeae9f7 server: DownloadListener - add caching for processConnect StartupCommand
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2024-09-03 16:25:28 +05:30
Abhishek Kumar 4400e02a1b
framework/config,server: configkey caching (#472)
Added caching for ConfigKey value retrievals based on the Caffeine
in-memory caching library.
https://github.com/ben-manes/caffeine
Currently, expire time for a cache is 1 minute and each update of the
config key invalidates the cache.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2024-09-03 15:53:08 +05:30
mprokopchuk e0d6066935 Bumped pom version to 4.18.1.2 (to add migration SQL script) 2024-08-15 17:55:00 -07:00
Rohit Yadav a794462da1
server, api: account and api entity access improvements (#470)
Backports CVE fix from upstream 4.18.2.3

https://cloudstack.apache.org/blog/security-release-advisory-4.19.1.1-4.18.2.3

(cherry picked from commit e7dce2bcce)

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Co-authored-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Co-authored-by: Fabricio Duarte <fabricio.duarte.jr@gmail.com>
Co-authored-by: nvazquez <nicovazquez90@gmail.com>
2024-08-07 21:18:24 +05:30
Abhishek Kumar e676b80052 revert fc2e4ffd12
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2024-07-29 13:08:28 +05:30
Abhishek Kumar fc2e4ffd12 server: refactor listNetworks api database retrievals (#9184)
* server: refactor listNetworks api database retrievals

* fixes

* remove unused methods

* imports

* fix empty searchcriteria issue

* refactor

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2024-07-22 16:14:00 +05:30
Abhishek Kumar 5e98405b38 Merge remote-tracking branch 'apple/apple-base418' into scalability-improvements 2024-07-22 16:12:19 +05:30
Suresh Kumar Anaparti d1faa59677
Back port fixes from upstream 4.19 (#466)
* Fixed src datastore on copy check for PowerFlex/ScaleIO storage driver (#9310)

* Ignore non-managed pools for storage pool access preparation (#9376)
2024-07-19 09:38:11 +05:30
Suresh Kumar Anaparti 5c682677fc
Support resource name / displaytext with unicode / emoji chars, and SQL exception msg improvements (#460)
* Don't send sql exception/query from dao to upper layer, log it and send only the error message

* Updated charset to utf8mb4, for display_name column/user_vm table and job_result column/async_job table to support unicode chars & emojis

* Added API arg validator for RFC compliance domain name, to validate VM's host name

* Updated user resources name / display name column's charset to utf8mb4

* Check and update char set for affinity group name to utf8mb4, from the data migration in upgrade path

* Updated backup offering name column charset to utf8mb4

* Added unit tests for vm host/domain name validation

* Added smoke test to check resource name for vm, volume, service & disk offering, template, iso, account(first/lastname)

* Updated resource annotation charset to utf8mb4

* Updated some resources description charset to utf8mb4
2024-07-19 09:35:18 +05:30
Rohit Yadav b46e4d4bbf
framework/cluster: improve cluster service and integration API service (#465)
- mTLS implementation for cluster service communication
- Listen only on the specified cluster node IP address instead of all interfaces
- Validate incoming cluster service requests are from peer management servers based on the server's certificate dns name which can be through global config - ca.framework.cert.management.custom.san
- Hardening of KVM command wrapper script execution
- Improve API server integration port check
- cloudstack-management.default: don't have JMX configuration if not needed. JMX is used for instrumentation; users who need to use it should enable it explicitly

Co-authored-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Co-authored-by: Wei Zhou <weizhou@apache.org>
Co-authored-by: Rohit Yadav <rohit.yadav@shapeblue.com>

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
(cherry picked from commit 4f5561937c)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2024-07-09 09:03:40 +05:30
Vishesh c6d35b31ca
Log stdout to a file (#399)
* Log stdout to a file

* Add logrotation

* Fixup permissions in log file

* Remove info logs in stdout

* Change output file names

Co-authored-by: Suresh Kumar Anaparti <suresh.anaparti@shapeblue.com>

* Fix logrotate config

* Disable logging to stdout

---------

Co-authored-by: Suresh Kumar Anaparti <suresh.anaparti@shapeblue.com>
2024-07-03 20:51:20 +05:30
Abhishek Kumar 08246e05ed
server,test: fix resourceid for VOLUME.DETROY in restore VM (#9032) (#454)
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2024-06-28 12:01:55 +05:30