etan39
/
cloudstack
mirror of https://github.com/apache/cloudstack.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
2,822 Commits 323 Branches 325 Tags 839 MiB
Commit Graph

525 Commits

Author SHA1 Message Date
abhishek 020afa6e33 adding a list command for ip forwarding rules for 1:1 nat, to be consumed by the ui 2010-11-18 11:15:13 -08:00
abhishek c4f1b35aef returning the public ip address in the creation of firewall rule, for the UI to consume 2010-11-18 09:42:47 -08:00
alena 91a87f9d8f bug 7155: fixed NPE in AuditTrial which used to happen when logout command was executed when session was already invalidated. 
status 7155: resolved fixed
 2010-11-17 21:42:51 -08:00
alena a95b853a17 bug 6898: updateResourceLimit command requires domainId or account/domainId now if executed via 8096 port 
status 6898: resolved fixed
 2010-11-17 19:43:06 -08:00
alena 97a8349110 bug 6894: removed "account" request parameter in listAccounts command. Should use "name" if need to make search by account name 
status 6894: resolved fixed
 2010-11-17 19:21:02 -08:00
Alex Huang a73e3dc9ac new networking can be set by use.new.networking 2010-11-17 17:51:17 -08:00
Chiradeep Vittal 9640f12cce bug 6971: revert some changes 2010-11-17 15:33:10 -08:00
Chiradeep Vittal 31e17b907d bug 6971: ensure no conflicts with portforwarding rules for vpn udp ports 
also, do not open up port 1701 -- only used on ppp interface not public interface
also clean up password generator, make it easier to use and more secure
moved some constants to NetUtils
heuristic to determine if an ip is one-to-one nat'ted
 2010-11-17 15:32:50 -08:00
alena 2184dd1af2 bug 7195: introduced search by forVirtualNetwork parameter in listVmsCmd. Added "forVirtualNetwork" param to responses for all VM's apis. 
status 7195: resolved fixed
 2010-11-17 14:11:16 -08:00
alena dae39942f1 bug 7192: Added networktype parameter for the zone 
status 7192: resolved fixed

1) Zone has networktype parameter now, 2 values are supported: Basic and Advanced. "networktype" field is created in data_center table. The parameter is being set at creation time; we don't allow to modify it with updateZone command.
2) Only vlan of Untagged Direct type can be created in Basic network zone; any other vlan except for Untagged Direct can be created in Advanced zone
3) Allow NULL guest vlan range for the zone. Only vlan of Direct type can be created in zone with NULL guest vlan.
4) "Default" zone is Basic by default.
5) Changed "vnet" parameter to "vlan" in updateZone command to be consistent with createZone
 2010-11-16 16:54:44 -08:00
abhishek 10cfe07970 bug 6793: returning the right msg to the ui when we try to log in to a locked account 2010-11-16 14:15:08 -08:00
abhishek e5e128545d removing the tags support in the update commands for disk and service offerings 2010-11-16 13:25:25 -08:00
alena c5d78a726e Modified exception handing in API. Following exceptions are supported now (location - BaseCmd.java): 
* MALFORMED_PARAMETER_ERROR - when type of the request parameter is invalid (String instead of Long for id for example)
* PARAM_ERROR - when invalid parameter value is specified in api request. For example, id of non existing vm for StartVmCmd
* ACCOUNT_RESOURCE_LIMIT_ERROR - when user tries to exceed his resource limits by executing the api command.
* INSUFFICIENT_CAPACITY_ERROR - when resource fails to create/start due to insufficient capacity.
* RESOURCE_UNAVAILABLE_ERROR - when user tries to create a vm when storage is not available.
* RESOURCE_IN_USE_ERROR - when user tries to delete/modify resource while it's in use. For example, when we try to delete a network group when it contains ingress rules.
* NETWORK_RULE_CONFLICT_ERROR - when LB/PF rule to add conflicts with existing rule
* ACCOUNT_ERROR - when user is not authorized to execute operation on the resource.
* INTERNAL_ERROR
 2010-11-16 11:56:34 -08:00
abhishek 92e3dc91c4 found a bug in the code where we were not decoding the params sent in eg. "a b" was being stored in the db as 'a%20b'. Fixing the same to have the right val persisted to the db 2010-11-16 11:46:55 -08:00
Alex Huang ed31497188 ComponentLocator changes 2010-11-16 04:28:15 -08:00
Alex Huang 17afeade00 better componentslocator 2010-11-16 04:28:14 -08:00
alena d43a8e983c Fixed authorizeNetworkGroupIngress api command (it stopped working after API refactor) 2010-11-15 17:44:51 -08:00
alena 1a8d9a92a7 Modified all api calls to throw ApiServerException if null object is returned by the manager. 2010-11-15 17:44:51 -08:00
abhishek d5ab597fcf bug 6474,6475: porting over the expunge fixes for port forwarding rules to 2.2 
status 6474,6475: resolved fixed
 2010-11-15 17:33:05 -08:00
abhishek c115a2e401 bug 7189: returning vmdisplayname if available for all port fwding crud cmds 
status 7189: resolved fixed
 2010-11-15 14:55:03 -08:00
abhishek d520f0af5b adding a column in user_ip_address table called one_to_one_nat; which is a boolean to tell us if the ip is a nat ip. This is false by default, and is set to true when we nat the ip. Also, this value is returned in the list public ip addrsses api call. 
finally, the value is set to false when we delete the ip forwarding rule.
 2010-11-15 12:39:24 -08:00
abhishek 6d943abf55 bug 7119: code refactor away from the ms calls, to the share and prepare methods based on alex's recommendations 
status 7119: resolved fixed
 2010-11-15 11:17:36 -08:00
alena a01aad84ed bug 7162: added search by id to listZones command 
status 7162: resolved fixed
 2010-11-15 10:48:36 -08:00
alena 050eed742f 1) Removed account/domainId info from deleteSnapshot and deleteSnapshotPolicy commands as we get account info from the snapshot/policy object. 
2) Introduced responseObject field in @Implementation for all apis. This field contains information about the response object class, so we can used it for generating API documentation.
 2010-11-12 17:36:17 -08:00
abhishek fc461abed1 bug 6755: adding checks for commands before they hit the ms; to ensure they are valid. Also returning the right error msg if the command is not valid 
status 6755: resolved fixed
 2010-11-12 13:55:06 -08:00
abhishek c91c977fba bug 6290: we will be returning the service offering details for a root disk in the list volumes cmd, as opposed to the disk offering which was misleading 
status 6290: resolved fixed
 2010-11-12 11:24:34 -08:00
abhishek 673ddb246a bug 6832: returning the missing api value for destroyed volumes 
status 6832: resolved fixed
 2010-11-12 10:55:13 -08:00
nit dd8f02589d bug 6837 : UpdateIso and UpdateTemplate API should return ostypename. Removing incorrect domainId creeping in because it was of primitive type. 
status 6837: resolved fixed
 2010-11-12 18:08:43 +05:30
nit 5215f6f817 bug 7101 : DetachISO API and AttachISO API would start returning an embedded object of virtualmachine so that the UI could use that to update the vm. 
status 7101: resolved fixed
 2010-11-12 16:40:55 +05:30
alena 6e0b500a83 bug 4964: made listDomainChildren work with "isRecursive" flag 
status 4964: resolved fixed
 2010-11-11 14:32:36 -08:00
abhishek 1faaba8fb0 fixed a corner case; also changed the commands to be async and changed the method signatures to conform with the master refactor 2010-11-11 13:07:26 -08:00
abhishek 26b75fc05d this is a good point to check the code in; have completed a part of the enhancement's code; with create and delete ip forwarding rule commands and the skeleton for port to rule map with associated table 2010-11-11 13:07:26 -08:00
abhishek e5ca5dddf9 renaming the ip forwarding commands to port forwarding commands, and beginning to work on Keshav's request to modify the current 1-1 NAT to be compatible with the Amazon apis 2010-11-11 13:07:26 -08:00
Alex Huang 05ce97f918 Merged in alena's changes 2010-11-11 12:53:19 -08:00
Alex Huang 284720bf00 compilation errors fixed 2010-11-11 12:53:19 -08:00
Alex Huang c6033baa78 system vm start and stop added 2010-11-11 12:53:19 -08:00
alena 86c8f86a56 bug 6192: use "ipaddress" instead of "publicip" in updatePortForwarding command 
status 6192: resolved fixed
 2010-11-11 12:12:29 -08:00
alena 86e83bc4bd Created new response objects for userVm/domainRouter/systemVm that going to be used by API after network refactorig is in place. 2010-11-11 10:43:18 -08:00
alena b1194e68f7 Fixed the build 2010-11-10 10:14:08 -08:00
nit 0597c0cf4b bug 4177: RegisterIsoCmd and RegisterTemplateCmd API - Added account and domainId params so that one could register them on behalf of other accounts. 
status 4177: resolved fixed
 2010-11-10 17:47:59 +05:30
alena 3954c7550a bug 6914: return password in deployVirtualMachine/resetVmPassword response. 
status 6914: resolved fixed
 2010-11-09 11:18:54 -08:00
alena 5fafef9970 More api refactor - build api response is execute() method instead of getResponse method. 2010-11-09 09:58:05 -08:00
abhishek 7262b854a5 bug 7121: made the disk offering id optional, and added a check to ensure we never have both disk offering and snapshot ids to be null 
status 7121: resolved fixed
 2010-11-08 17:59:26 -08:00
alena 47e365f5ea bug 7089: return embedded object name in xml response 
status 7089: resolved fixed
 2010-11-08 13:59:14 -08:00
will 551e7e4b82 bug 6812: fixed default pagesize of all listXXX command to unlimited for now. 2010-11-08 13:15:02 -08:00
Alex Huang c8a3ea3080 merge conflict with alena's changes 2010-11-08 12:40:38 -08:00
Alex Huang 734cd0b1b1 fixed some bugs 2010-11-08 12:29:37 -08:00
alena 1c24deda34 1) Refactored current Apis not to use reflection for method invocation. In new version following has to be done: 
* Implement callCreate() and execute() methods in apis extending BaseAsyncCreateCmd (example - CreateVolumeCmd)
* Implement execute() method in apis extending BaseCmd and BaseAsyncCmd (example - deleteVolumeCmd and deleteUserCmd)

We no longer need createMethod(), method(), manager() fields in @Implementation annotation, cleanup has to be done.

2) Moved Account/User related methods to AccountManagerImpl. Methods are exposed via AccountService interface.
3) Enhanced exception handing for Api calls.
4) Created ConfigurationService interface, all Api config methods are exposed via it.
 2010-11-08 11:27:36 -08:00
nit 02781422b5 bug 6055: createDiskOffering: remove domainId parameter. 
status 6055: resolved fixed
 2010-11-08 13:41:33 +05:30
nit 4dc8837dc8 bug 6952: listISO should return "ispublic" property. 
status 6952: resolved fixed
 2010-11-08 12:33:23 +05:30
will 89c717703f Fixed API commands that extend BaseCreateAsyncCmd to return the correct API response of id, and jobid. 
Added the default public constructor back in the SuccessResponse to make sure deserialization works from the asyncjob table.
Fixed a issues with the VPN tab.  It should now make use of the corrected API format.
 2010-11-06 16:30:08 -07:00
will ca0ce93fde Fixed all sync commands that can possibly return a <success> tag. If success, it will return true, otherwise an HTTP error will be returned. 2010-11-05 21:25:19 -07:00
will 563b45a220 bug 7059: Fixed the async output to use the object name 2010-11-05 20:58:00 -07:00
anthony 224da7e775 several snapshot fixes 2010-11-05 20:55:19 -07:00
will bcb53ec363 bug 7059: Fixing adding primary and secondary storage to use new api output. 2010-11-05 20:30:55 -07:00
will a3dbc34857 bug 7059: refactored the API to now add the single embedded object tag after a response 
- Changed networkgroups to security groups
- a whole bunch of other API bugs.  Unfortunately, I may have broken more.
 2010-11-05 20:10:57 -07:00
will 05ab3bf673 bug 7063: AsyncJobResult should now return the correct success and error tags upon the completion of a async job. It should now follow either the format ... jobresult.success or jobresult.errorcode and jobresult.errortext 
- Fixed a lot of other Async related packaging issues.  It's not all done but will continue to refactor this later.
 2010-11-05 17:30:03 -07:00
Alex Huang 4555fcd73f changed everything back so everyone can test 2010-11-05 16:10:22 -07:00
Alex Huang 5f90a8adb0 Checking in to do git pull...stupid git 2010-11-05 16:10:22 -07:00
alena e2aa4738ec listVirtualMachine api: return "Not created" as a root volume type when volume's storage pool id is NULL 2010-11-05 16:03:37 -07:00
alena c0e2986766 bug 6958: return state for Account api commands 
status 6958: resolved fixed
 2010-11-05 15:48:05 -07:00
alena a9166929f0 Fixed NPE in listVolumes/listVirtualMachines commands - do searchIncludingRemoved when get diskOffering/serviceOffering info. 2010-11-05 14:46:08 -07:00
alena b9ad299ac6 bug 6998: return embedded job result object in queryAsyncJobResult command 
status 6998: resolved fixed
 2010-11-05 12:03:01 -07:00
will b9fc4137f7 Bug 6988: Fixed issue with queryAsyncJobResult returning jobResults in all String format. This is to mirror the same way that the async commands are being serialized. 
- Changed client.war to now include all the thirdparty files
- Fixed addVpnUser command to return a vpnuser instead of the response
- Added vmware jar files to the development build.
 2010-11-04 20:56:28 -07:00
will 70b4c4d181 Bug 6988: addVpnUser did not camel case the "username" which resulted in that particular value not being returned. 2010-11-04 20:56:23 -07:00
Chiradeep Vittal 5c445bd99e bug 6991: add presharedkey to response 
status 6991: resolved fixed
 2010-11-04 15:40:24 -07:00
abhishek 03ea885dcd making disk offering id mandatory for volume creation 2010-11-04 15:30:23 -07:00
abhishek d96a1a841d adding logic to prevent commands from being sent to the pool when it is NOT up; also adding better thread safety and db locking, along with a general refactor 2010-11-04 13:35:57 -07:00
nit 7dc7a4838a bug 4286: Fixing the extract functionality for Upload after new API framework. Also added a check to avoid system created templates and ISO's from getting extracted as per Mike. 
status 4286: resolved fixed
 2010-11-04 19:09:38 +05:30
will f907e370d1 - Added the rest of the VPN UI feature with the exception of displaying the preshared key. 
- AddVpnUserCmd will now return the embedded object.
- Fixed RemoteAccssVpnResponse to return "iprange" instead of "ipRange"
 2010-11-03 22:24:22 -07:00
abhishek 84ee08430a making changes to the list zones flow, to add the domain name to the table, and return it 2010-11-03 22:08:32 -07:00
Alex Huang 9bb05d3ef8 harmony amongst joins 2010-11-03 21:18:31 -07:00
Alex Huang e27bb550fe Harmony among gurus 2010-11-03 21:18:31 -07:00
Jessica Wang 3deb7580bb Create Disk Offering - make disksize optional 2010-11-03 19:48:35 -07:00
abhishek 2303afe55c making changes for disk offerings with a new column called customized being added, for the UI to cosume whilst deploying vm with an arbitrary volume size. The UI will use this value to set the right size and the offering will ensure the right tags are taken. 2010-11-03 17:45:52 -07:00
alena 2939e90d66 Build response the same way for create/list/update IPForwardingRule. 2010-11-03 15:49:51 -07:00
abhishek 7674df6c7a fixing the merge conflicts 2010-11-03 15:39:16 -07:00
abhishek 46497e3aad making changes for the private/public zones enhancement, for the UI to consume. The list method has been changed to return visible zones based on the user's credentials, or if the domainId for private zone listing is specified. In the update zone cmd, we do not allow updating private zone once it has been associated with a domain. This might change in the coming releases. 2010-11-03 15:39:16 -07:00
alena 6bd87ca161 Return "status" field in StoragePoolResponse. Status can be Up, Maintenance, ErrorInMaintenance 2010-11-03 14:59:00 -07:00
alena 52a8370102 bug 6955: return embedded object for PreparePrimaryStorageForMaintenance 
status 6955: resolved fixed
 2010-11-03 14:30:35 -07:00
Chiradeep Vittal e1cb94831f VPN users feature complete 2010-11-03 14:02:13 -07:00
Chiradeep Vittal 0dd19c197b VPN users API -- WIP 2010-11-03 14:02:13 -07:00
Chiradeep Vittal 14613415e1 VPN users API -- WIP 2010-11-03 14:02:13 -07:00
Chiradeep Vittal b6d3b3c184 users for vpn -- data model 2010-11-03 14:02:12 -07:00
alena 4a645cdeb0 Return embedded Volume object for create/attach/detach Volume commands. 2010-11-03 13:07:06 -07:00
alena 8c0e2fa7ec Fixed updatePod Api to return embedded object instead of "success" response 2010-11-03 11:18:51 -07:00
alena 886fd4e754 More api refactoring - move response building for LoadBalancer/IpAddress commands to ApiResponseHelper. 2010-11-03 10:11:59 -07:00
alena ebdc1f069d 1) Return embedded Host object in PrepareForMaintenance command. 
2) Build HostResonse object in ApiResponseHelper for add/reconnect/update/prepareForMaintenance/cancelMaintenance commands
 2010-11-02 20:30:41 -07:00
alena abb8f45667 1) Return embedded object for upgradeRouter command 
2) Build response objects in ApiResponseHelper for stop/start/reboot/list router/systemVm commands
 2010-11-02 19:47:14 -07:00
Alena Prokharchyk 694a8231ef Build responses in ApiResponseHelper for the deploy/start/stop/reboot/recover/listVm create/list snapshot/snapshotPolicies 2010-11-02 18:16:45 -07:00
abhishek c6809f89d4 bug 6890: preventing users from searching for system account details via the list api 
status 6890: resolved fixed
 2010-11-02 17:59:24 -07:00
alena 571ca42c44 1) Return embedded object for addCfg/updateCfg/listCfg. 
2) Fixed NPE in updateCfg command (used to happen when no value was specified)
3) Fixed addCfg command to call correct getName method while setting config name (used to call the method returning the command name)
 2010-11-02 15:26:33 -07:00
Alex Huang 5fe5450abc even more refactoring 2010-11-02 15:25:07 -07:00
abhishek d4b33f523d bug 5190: changes from the ui perspective; we upload the entire cert as a string, instead of reading it from a file. Then, we process the cert via ip streams instead of fileinputstreams. Moved the cert validation to before cert persistance, and also added more logging and exception catch blocks to deal with IO exceptions that might arise out of the ip stream processing for the new change. 2010-11-02 14:48:05 -07:00
alena 0c044a10d1 Moved response building for ServiceOffering/ResourceLimit commands to ApiResponseHelper class. 2010-11-02 11:59:10 -07:00
abhishek 85f78d8cb3 bug 6886: fixing the npe which occurs when we try to delete a non existant user. We were trying to return user details for an async job desc assuming the user always existed. Changing that logic to ensure when we don't have such details, we log the apt message 
status 6886: resolved fixed
 2010-11-02 11:20:52 -07:00
alena 6c3256d1e4 1) Return embedded objects for enable/disable/lock/update Account/User and updateDomain 
2) Added "haschild" return parameter to Domain response.
3) Fixed updateDomain command - used to set domainname to "updatedomainnameresponse" value if no name was specified in the request. Added more logging for updateDomain command.
 2010-11-01 23:49:57 -07:00
alena 5d4e4be974 1) Created ApiResponseHelper class - all api response objects should be built there. 
2) Removed isMirrored tag from the update/create/listDiskOffering commands
 2010-11-01 23:49:57 -07:00
abhishek 45f4499c14 bug 6836: fixing the api responses for disk offerings. We were using the wrong objext name, and were only returning success responses. Now, we are constructing the apt object and returning the entire object back. 
status 6836: resolved fixed
 2010-11-01 13:24:28 -07:00
abhishek f70b55daa2 bug 6380: removing the code which returns hostid and hostname, as on a stopped vm, we do not have any association of the vm to the host 2010-11-01 12:16:53 -07:00