Commit Graph

525 Commits

Author SHA1 Message Date
edison 26807bc701 bug 6362: Need to call guestos.getDisplayName to the guest os name now.
status 6362: resolved fixed
2010-09-30 12:26:37 -07:00
Kris McQueen bc2449a69a If the session in invalidated due to a bad session key, just return to avoid the situation where the session is invalidated twice (which causes IllegalStateException) 2010-09-30 11:39:36 -07:00
edison 58c430f7d7 add xenserver specific configruation back 2010-09-29 18:48:26 -07:00
edison ad1ef80459 Now we have multiple routing template and buitin templates now, refactor template download code, that can handle it.
Basically, change the meaning of type field in template table: SYSTEM means sytem vm template, BUILIIN means buildin templates.
2010-09-29 18:41:55 -07:00
edison 6fc7528809 create data volume is splitted into two stage:
1. create a volume entry in the database,
2. when user attaching the volume to a VM, then actually create the volume on storage pool.
2010-09-29 18:41:54 -07:00
edison 964f8f1fe3 fix boot from iso 2010-09-29 18:41:54 -07:00
edison d98d6cbb9f fix template download, listguestos type 2010-09-29 18:41:53 -07:00
edison baeb1af265 fix register template hypervisor type 2010-09-29 18:41:53 -07:00
edison b8c1d2ea17 set external ipallocator as true by default 2010-09-29 18:40:52 -07:00
edison 9e0f57bc0e change code for new UI 2010-09-29 18:40:52 -07:00
edison 8943cc6745 create volume
Conflicts:

	api/src/com/cloud/vm/VmCharacteristics.java
	core/src/com/cloud/dc/ClusterVO.java
	core/src/com/cloud/server/ManagementServer.java
	server/src/com/cloud/network/NetworkManager.java
	server/src/com/cloud/storage/allocator/AbstractStoragePoolAllocator.java
2010-09-29 18:40:51 -07:00
Kris McQueen 0105aec338 Always set the response type on the command object so that the correct output is generated. Add both Strings and Longs to the login response (domainId and userId will be the Longs). Use the correct method name for ListSystemVMsCmd. 2010-09-29 17:32:19 -07:00
anthony be5fa82229 remove snapshotpolicyRef 2010-09-29 16:24:57 -07:00
Kris McQueen da660f2575 Change session parameters to be their actual type (domainId and userId are saved to the session as Longs and not Strings) 2010-09-29 15:18:43 -07:00
Kris McQueen 9e2d1f5e70 Refactoring disableUser and disableAccount to new API framework (they are both async commands). 2010-09-29 13:57:26 -07:00
abhishek cd42fcc1bf some code refactoring 2010-09-29 11:17:42 -07:00
kishan 9e87534e42 bug 6216: Added Id to listAlerts response 2010-09-29 15:52:13 +05:30
Kris McQueen 95a7f20a0a Adding in XML response serializing. Now the new API framework supports both XML and JSON responses the way the old framework did. 2010-09-28 17:36:27 -07:00
Kris McQueen 848ce60097 Merging master into 2.1.refactor, resolve the merge conflicts as best I can. New commands related to extracting template/iso/volume and related to instance groups were refactored to the new API framework. 2010-09-28 15:47:14 -07:00
nit 122b15071d bug 6334: Correcting the syntax of json data when the response is empty.
status 6334: resolved fixed
2010-09-28 14:46:44 +05:30
alena 9b10074c2a Added missing license info to the bunch of files 2010-09-27 19:08:03 -07:00
abhishek ad4ea90207 bug 5190: enhancing some of the error messages returned to be more intuitive 2010-09-27 17:01:01 -07:00
abhishek 677d8894ea bug 5190: modifying the api calls 2010-09-27 16:49:34 -07:00
abhishek 1356f5f33a bug 5190: incremental checkin, code cleanup 2010-09-27 16:46:14 -07:00
abhishek 060dfc2cf9 bug 5190: incremental checkin 2010-09-27 16:39:32 -07:00
alena 49143dbe4a Remove user vm from instance_group when empty string is passed as value for "group" parameter in updateVirtualMachine API. 2010-09-27 14:24:08 -07:00
nit b857a9b4c8 bug 4177: registerTemplate/registerIso commands would start accepting account/domainId params.
status 4177: resolved fixed
2010-09-27 17:24:23 +05:30
nit 26fc22160c bug 5871: Correcting the ostypeid and ostypename returned by the listIsos 2010-09-27 12:10:49 +05:30
Kris McQueen 62257d4021 Fix serializing async job responses by writing a custom adapter for ResponseObjects. Improve exception handling when calling async commands (the job still needs to complete, but with FAILED status). 2010-09-24 13:52:35 -07:00
Kris McQueen 2a4ddac41a Change getResponse() to return a ResponseObject so that the caller can choose how to serialize. This in in preparation for serializing the async commands to the database with class information and deserializing them into the ResponseObject itself when queryAsyncJobResult is called. Once the ResponseObject is deserialized, the proper string can be returned to the caller.
The previous behavior had the JSON response from the command embedded into the queryAsyncJobResult response as a string rather than a JSON object which prevented the client from being able to read the response.  With this new behavior an actual JSON object should be returned which can then be parsed on the client side.
2010-09-23 17:34:28 -07:00
abhishek 320df380c9 bug 6217: incremental fix for the vm api
bug 6217: resolved fixed
2010-09-23 14:56:25 -07:00
abhishek e0dcb95511 bug 6217: incremental checkin 2010-09-23 14:55:13 -07:00
abhishek 703c182f8f bug 6222: removing non needed attribs
status 6222: resolved fixed
2010-09-23 10:32:42 -07:00
abhishek 32884572b9 bug 6241: incremental checkin 2010-09-22 15:32:42 -07:00
nit fd86e976b6 bug 6249, 6250: listDiskOfferings API - adding createed date tag and removing ismirrored tag.
status 6249, 6250: resolved fixed
2010-09-22 15:08:14 +05:30
Kris McQueen c26426c7c7 Throw an exception when the dispatcher can't find the implementation for an API command. 2010-09-21 18:26:57 -07:00
Kris McQueen e31f89e6a9 Set up accountId in the AsyncJob since it's needed for proper validation when querying the job status. 2010-09-21 18:26:34 -07:00
Kris McQueen 8161078803 QueryAsyncJobResult was missing an implementation and had 'id' as the parameter when it should have been 'jobid'. 2010-09-21 18:25:35 -07:00
Kris McQueen c32d6e7524 Template id is not a required parameter when listing templates. The proper serialized name for the async job id is jobid, not id. Sadly, ctxAccoutId != ctxAccountId, ugh, no wonder the UserContext wasn't getting set up correctly. Clean up some miscellaneous unnecessary casts. 2010-09-21 17:00:50 -07:00
Kris McQueen 5a3f4af638 AddHost and AddSecondaryStorage have different required parameters, so avoid subclassing these commands and just call a common method in the agent manager. Fix the response name for listAccounts. CreateUser returns one user, so don't always get response.user[0] since that's pointless. A secondary storage host does not have a pod id (NfsSecondaryStorageResource) so make sure not to dereference variables that will be null. 2010-09-21 16:28:31 -07:00
abhishek 122b0d1aeb bug 6243: adding a check to return an error in case we have a null domain id for a non null account
status 6243: resolved fixed
2010-09-21 15:50:49 -07:00
abhishek d07cac932a bug 6165: there is a possiblility of the root volume being null when we search for it, which may be causing a npe in this bug. enhancing the logic around this
status 6165: resolved fixed
2010-09-21 15:17:21 -07:00
abhishek 37870da95f bug 3120: incremental fix 2010-09-21 14:47:51 -07:00
nit 87f1a96c29 bug 6214: UpdateIso API - Adding account and domain tags. 2010-09-21 16:17:48 +05:30
nit 0669c2c1d4 Merge branch 'master' of ssh://git.cloud.com/var/lib/git/cloudstack-oss 2010-09-21 13:37:47 +05:30
nit 7ff551bd5c bug 4286: Extract functionality - code cleanup 2010-09-21 13:36:57 +05:30
Kris McQueen ebd06ae6f3 List clusters was using the name of the command rather than the name of the cluster to search for clusters, which was resulting in no clusters returned. Fixed. CreateStoragePool was returning an array of one pool every time, simplified it to just return the pool and changed the UI to expect one pool rather than an array. Fixed the backend code for creating a storage pool to (a) generate a UUID based on host name, path, and a timestamp and (b) to list only active storage pools when checking for duplicates. This allows a storage pool to be create with the same path as a pool that had previously been deleted. 2010-09-20 19:08:52 -07:00
Kris McQueen 1a54c52d5e Change the annontations for response objects to use the GSON annotations for the property name written to the response 2010-09-20 17:47:56 -07:00
Kris McQueen 12ef5106b6 Fixing serialization of JSON responses to handle both regular objects and list-style responses. Add missing managers to API dispatcher. Fix a typo in listAlerts command implementation method. Add signatures for various add host/storage APIs. 2010-09-20 15:20:32 -07:00
abhishek a9c96b4da0 bug 3120: incremental checkin 2010-09-20 14:54:06 -07:00
abhishek 437f717633 bug 3120: incremental checkin 2010-09-20 14:54:06 -07:00
kishan 9393ad410e Merge branch 'master' of ssh://kishan@git.cloud.com/var/lib/git/cloudstack-oss 2010-09-20 15:12:55 +05:30
kishan b606d14396 Bug 5904: Included version in API header 2010-09-20 15:00:57 +05:30
nit a39fad5da4 bug 3384: listVolumes: allowing regular user to make a search by "type".
status 3384: resolved fixed
2010-09-20 13:09:33 +05:30
nit 33e683e2c7 bug 4286: Making ExtractVolumeCommand async and some code cleanup 2010-09-19 18:34:12 +05:30
nit 1a30ffbdc0 bug 6055: createDiskOffering API - removed isMirrored and domainId parameters.
status 6055: resolved fixed
2010-09-19 16:13:13 +05:30
Kris McQueen e2e0e76063 More work on serializing responses. Now responses have to have the name set on them, and the name will eventually be serialized to the JSON/XML response the way it used to work for commands themselves [the result of cmd.getName() was written to the response string]. For list respones, we wrap the individual objects in a ListResponse object that has the name of the response, and the individual objects have the object name so that accounts will be something like <listaccountsresponse><account><...></account><account><...></account></listaccountsresponse>. 2010-09-17 17:13:04 -07:00
abhishek 1a37b661c7 code cleanup 2010-09-17 17:06:19 -07:00
abhishek 573885c615 bug 6203: changed the functionality for custom volume and disk offering creation
status 6203: resolved fixed
2010-09-17 16:59:40 -07:00
abhishek a016aa27cd bug 6203: incremental fix 2010-09-17 16:59:40 -07:00
Kris McQueen a5f50d236f Rearranging how response objects work since we need the response name when doing serialization. Now there's a base class that implements the getResponseName method, all responses extend this base class 2010-09-17 15:18:37 -07:00
Kris McQueen 4a73639d67 Fix up setting the response object correctly after dispatching the api method call. Begin working on the serialization of the responses which don't include the command name just yet, that's coming. 2010-09-17 14:56:55 -07:00
Kris McQueen 1f4b2cfb06 Async commands need to have a start event id for event tracking. 2010-09-17 12:07:16 -07:00
nit 48cd102ab9 Merge branch 'master' of ssh://git.cloud.com/var/lib/git/cloudstack-oss 2010-09-17 17:04:35 +05:30
nit 636dc041c7 bug 4286: Making extractIsoCmd and extractTemplateCmd async 2010-09-17 17:04:07 +05:30
Kris McQueen 3f6a438d92 Refactoring the AsyncJobManager to queue jobs appropriately if there is a need to synchronize execution on an object, e.g. a router. API developers can now call command.synchronizeCommand(String, Long) to force the command to be synchronized on a particular object type [the string arg] with a particular id [the long arg]. When synchronizeCommand() is invoked, an exception maybe thrown by the framework (AsyncCommandQueued exception) to force the business logic to abort. The command will then be queued and invoked at the appropriate time. The synchronizeCommand() is re-entrant and will be a no-op if the command has already been queued and is now ready for execution. 2010-09-16 19:05:06 -07:00
alena 091b28a6b3 Modified addSecondaryStorage/addHost/updateHost/associateIpAddress/attachIso/copyIso/copyTemplate/deletePortForwardingService/startRouter/stopRouter/rebootRouter commands to new API framework. 2010-09-16 18:54:15 -07:00
abhishek f1cab0525c bug 6021: blocking the deletion of private disk offering from the back end api 2010-09-16 16:47:35 -07:00
abhishek 3abe056736 bug 6141: fixed the error of not providing the right error for an incorrect diskoffering
status 6141: resolved fixed
2010-09-16 15:01:13 -07:00
abhishek 6731dc66f1 bug 3120: incremental checkin 2010-09-16 12:02:54 -07:00
alena 6fef440732 Updated DeleteHost/DeleteIso/deletePool/UpdateDiskOffering/updateIso/updateTemplate/updateDomain to new api framework 2010-09-15 20:07:01 -07:00
alena ec47f83a4a Merge branch '2.1.refactor' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 2.1.refactor 2010-09-15 16:45:59 -07:00
alena b49f63c28e Refactoring addConfig/deleteDiskOffering/deletePod/getCloudIdentifier/enableAccount/enableUser/enableAccount/updateUser/updateDiskOffering/updateConfig commands to new API framework 2010-09-15 16:41:38 -07:00
Kris McQueen e18898ae4d Cleaning up some TODOs related to generating API command responses. Now that the ApiDBUtils class is available, setting things like domainNames is possible, so make use of that. 2010-09-15 16:22:55 -07:00
Kris McQueen be6a4612a4 Cleaning up some TODOs related to generating API command responses. Now that the ApiDBUtils class is available, setting things like domainNames is possible, so make use of that. 2010-09-15 15:48:52 -07:00
abhishek b2efa6872b a few more code cleanup tasks 2010-09-15 15:38:24 -07:00
Kris McQueen 8607fbe923 Cleaning up some TODOs related to generating API command responses. Now that the ApiDBUtils class is available, setting things like domainNames is possible, so make use of that. 2010-09-15 14:56:20 -07:00
Kris McQueen 496bcb9e85 Adding more db operations to the API utils class and removing them from ManagementServer. These methods delegate directly to the DAO and are cluttering ManagementServer with cover methods specifically for the API. Now that these methods are being moved to the API Utils class, ManagementServer has a smaller, cleaner API than before. 2010-09-15 14:25:21 -07:00
Kris McQueen 8bdb8f3581 Adding more db operations to the API utils class and removing them from ManagementServer. These methods delegate directly to the DAO and are cluttering ManagementServer with cover methods specifically for the API. Now that these methods are being moved to the API Utils class, ManagementServer has a smaller, cleaner API than before. 2010-09-15 12:16:00 -07:00
abhishek 652620363d bug 3120: reverting changes as still soliciting feedback on design 2010-09-15 11:52:31 -07:00
abhishek a05dc480a7 bug 3120: incremental checkin 2010-09-15 11:18:04 -07:00
abhishek ef8781b7b5 bug 3120: introducing this optional parameter in the command 2010-09-15 10:28:41 -07:00
abhishek cacb4dba1d bug 3120: incremental checkin for this bug, with the introduction of an optional ONE_TO_ONE_NAT parameter 2010-09-15 10:28:41 -07:00
nit f5ac46255c bug 4286: Schema changes to include the upload table, Introducing extractIso command and extractVolume command 2010-09-15 17:51:42 +05:30
alena b26ac321de bug 6177: Make VM group a first class object
1) Added new apis: createInstanceGroup, updateInstanceGroup, deleteInstanceGroup, listInstanceGroups
2) Group can be created using:
* createInsanceGroup api
* deployVirtualMachine/updateVirtualMachine commands (we create a group with name equal to "group" parameter value if the group doesn't exist already)
3) Group can be removed by:
* deleteInstanceGroup api
* when corresponding account is removed
4) Vm can be assigned to one group only. To move vm from one group to another, use updateVirtualMachine command with "group" parameter
5) Changed listVirtualMachines command to use "groupId" parameter instead of "group".

status 6177: resolved fixed
2010-09-14 19:08:01 -07:00
Kris McQueen dc6e07ad75 Refactoring deletePreallocatedLun and registerPreallocatedLun to new API framework. 2010-09-14 17:53:12 -07:00
Kris McQueen 1b8965c202 fixing package name for pre-allocated lun api commands 2010-09-14 17:04:35 -07:00
Kris McQueen cf6829a038 Moving pre-allocated lun API commands to OSS since it's not a premium feature 2010-09-14 17:02:16 -07:00
Kris McQueen 1d912fb608 adding licensing info 2010-09-14 16:09:05 -07:00
Kris McQueen a53cb4aab0 Refactoring deleteDomain to new API framework. Cleaning up some compilation errors that resulted from previous refactoring, namely there was a requirement to keep the old manager method around for createDiskOffering and createZone in order for the ConfigurationServer to work. 2010-09-14 15:36:12 -07:00
Kris McQueen dbb2897626 Unexposed parameters can now be assigned to commands. This are for internal use of the command, and will be serialized/deserialized during execution/response phases, but will not be accepted as part of the API request. Also create a DB utility file for the API to use which delegates requests to the DAOs. Mostly this utility class will look up objects by ID, and it allows the removal of similar methods from ManagementServer, thereby reducing some of the clutter in ManagementServer. 2010-09-14 14:54:04 -07:00
Kris McQueen f4caf145c3 Refactoring dispatching API commands from the scheduled async job. Instead of calling an executor, the dispatcher invokes the method on the manager directly. After the command is executed the response is serialized to the async job table so it can be queried later. Also serialize a response for async create commands that includes the id of the object being created. 2010-09-13 18:28:19 -07:00
Kris McQueen a8112f65de When using session based authentication, we now store the parameters in the session as part of the login processing, instead of returning those parameters so that the caller has to update the session. Authentication now throws an exception on failure and the caught exception is where the session is invalidated. 2010-09-13 17:04:11 -07:00
Kris McQueen de5e978b7b Removing listSecurityGroups and listNetworkGroups from the SecurityGroupDao and NetworkGroupDao since they weren't being called by anyone. 2010-09-13 15:59:52 -07:00
Kris McQueen df10af0688 cleaning up imports, fixing up some compilation problems related to API refactoring 2010-09-13 15:25:46 -07:00
Kris McQueen 449d1f3acf working through some compilation errors that have arisen due to all the API refactoring... 2010-09-13 14:46:23 -07:00
Kris McQueen 460ef94299 Refactoring listStoragePoolsAndHosts command to new API framework. 2010-09-13 14:03:07 -07:00
Kris McQueen 1e46e2e588 refactoring createVolume to new API framework 2010-09-10 23:25:22 -07:00
abhishek ec01e0b423 bug 5147: this checkin ensures that we cover some more corner cases, in particular, to not allow an execution when we have pools in inconsistent states (maintenance, prepareformaintenance or errorinmaintenance) 2010-09-10 14:52:05 -07:00
abhishek 4682b25cb5 bug 5147: implemented the logic to ensure that the volume creation is blocked when all sp's are in maintenance (or any of the status != UP) 2010-09-10 14:41:04 -07:00
abhishek 93261c4eb8 bug 5147: Improvements after testing the storage maintenance across multiple sp's, with sys vms scattered across multiple sps 2010-09-10 13:44:39 -07:00
Kris McQueen b73cd10fbe Refactoring listAccounts to new API framework. 2010-09-09 18:58:37 -07:00
Kris McQueen 037f1ff327 Refactoring createSnapshot to new API framework. 2010-09-09 18:58:37 -07:00
Kris McQueen 39038721a8 Refactoring deployVirtualMachine to new API framework. Since this is a rather complicated command with many steps, for now the way the logic is broken up between ManagementServer and UserVmManager and NetworkManager is preserved. Later there is a possibility of consolidating some of the logic. 2010-09-09 18:58:37 -07:00
abhishek 0a4532a003 bug 5147: some more improvements 2010-09-09 18:05:43 -07:00
alena 3659b7b207 Code cleanup - deleted code that was commented out and unused imports. 2010-09-09 16:07:29 -07:00
Alex Huang 7249f168d5 more file changes 2010-09-09 13:27:20 -07:00
Alex Huang 6134f7dfd2 more file changes 2010-09-09 11:52:12 -07:00
alena 75483e4e05 Modified AuthorizeNetworkGroupIngress/DeleteNetworkGroupIngress to new api framework 2010-09-09 11:41:33 -07:00
alena ea415e65bb Merge branch '2.1.refactor' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 2.1.refactor
Conflicts:
	server/src/com/cloud/server/ManagementServerImpl.java
2010-09-08 20:08:14 -07:00
alena 44f86d3726 Refactored AssignPortForwardingServiceCmd and DeletePortForwardingServiceCmd 2010-09-08 20:06:15 -07:00
Kris McQueen 3949afa9ae Refactor queryAsyncJobResult to new API framework. 2010-09-08 19:24:35 -07:00
alena fd680189f6 Merge branch '2.1.refactor' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 2.1.refactor 2010-09-08 19:04:13 -07:00
alena b0aa28032c Refactored DeleteIPForwardingRule/UpdateIPForwardingRule commands to new api framework. 2010-09-08 19:03:42 -07:00
Kris McQueen 8c2756b681 Refactor listZones to new API framework. 2010-09-08 18:56:28 -07:00
Kris McQueen 741bb77b7e Refactor listVolumes to new API framework. 2010-09-08 18:56:28 -07:00
Kris McQueen b144be4613 Refactor listVMs to new API framework. 2010-09-08 18:56:28 -07:00
Kris McQueen 88f5b73682 Refactor listVlanIpRanges to new API framework. 2010-09-08 18:56:28 -07:00
Kris McQueen bdebd4bfa3 Refactor listUsers to new API framework. 2010-09-08 18:56:28 -07:00
Kris McQueen b40f496f80 Refactoring listTemplatePermissions and listIsoPermissions to new API framework. 2010-09-08 18:56:27 -07:00
Kris McQueen 5204349fef Refactor listSystemVms to new API framework. Add missing licensing info to several API response files. Combine ConsoleProxy and SecondaryStorageVm interfaces into SystemVm interface to have common functions callable from one interface rather than having to cast overly much just to get the same data from the objects. This also includes a partial refactoring of ListStoragePoolsAndHosts command. 2010-09-08 18:56:27 -07:00
alena 5170c215f8 Refactored DeleteLoadBalancerRule/UpdateLoadBalancerRule api commands. 2010-09-08 15:04:26 -07:00
alena c0185e713a Refactored AttachVolume/PrepareForMaintenance/CancelMaintenance/PreparePrimaryStorageForMaintenance/CancelPrimaryStorageMaintenance commands. 2010-09-08 12:18:46 -07:00
alena 7e5f0de448 Merge branch '2.1.refactor' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 2.1.refactor 2010-09-07 18:54:59 -07:00
alena 41000e61d3 Refactored copyIso/copyTemplate/attachIso/startRouter/stopRouter/rebootRouter commands 2010-09-07 18:53:04 -07:00
Kris McQueen 614c3fa502 Refactor listSnapshots to new API framework. Also some minor code cleanup. 2010-09-07 18:41:52 -07:00
Kris McQueen 3b703c76cf Refactor listSnapshotPolicies to new API framework. 2010-09-07 17:46:55 -07:00
Kris McQueen e6ebe3ac77 Refactoring listServiceOfferings to new API framework. 2010-09-07 17:29:13 -07:00
Kris McQueen a905442b2e Refactor listRouters to new API framework. 2010-09-07 16:25:26 -07:00
Kris McQueen 4e5aa9cd98 Finish refactoring listResourceLimits to new API framework. 2010-09-07 14:56:51 -07:00
Kris McQueen cee6b37757 Partial refactoring of listResourceLimits to new API framework. 2010-09-07 14:56:51 -07:00
Kris McQueen f653e54ce6 Refactoring listRecurringSnapshotSchedule to new API framework. 2010-09-07 14:56:50 -07:00
alena 70279f35fa Merge branch '2.1.refactor' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 2.1.refactor 2010-09-07 11:31:46 -07:00
alena d3b4a56520 Merge branch '2.1.refactor' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 2.1.refactor 2010-09-02 18:54:14 -07:00
alena f2a680ae66 1) Refactored DeleteIsoCmd api.
2) Removed DeleteTemplateExecutor and DeleteTemplateParam files because deleteTemplate/deleteIso are not async commands
3) Cleaned up unused imports.
2010-09-02 18:52:43 -07:00
Kris McQueen 22b0a95b2f Refactor listPublicIpAddresses to new API framework. 2010-09-02 16:23:29 -07:00
Kris McQueen 1d1e10d2d3 Refactoring listPreallocatedLuns to new API framework. 2010-09-02 15:23:15 -07:00
Kris McQueen 2cd9a44267 Refactoring listPortForwardingServices to new API framework. Also forgot to return a response from listPortForwardingServicesByVM... 2010-09-02 15:03:06 -07:00
Kris McQueen f6ae5e9b52 Refactoring listPortForwardingServicesByVM to new API framework. 2010-09-02 11:57:31 -07:00
Kris McQueen 476151453e Refactor listPortForwardingServiceRules to new API framework. 2010-09-01 16:19:11 -07:00
Kris McQueen 931706ad87 Refactor listPortForwardingRules to new API framework. Clean up imports. 2010-09-01 15:00:22 -07:00
Kris McQueen 44eaf247b5 Refactoring listPods to new API framework. 2010-09-01 14:17:00 -07:00
Kris McQueen fbcb02cd9e Refactoring listNetworkGroups to new API framework. The search is done entirely within NetworkGroupManager, and this is one instances of a response with nested data (the ingress rules are nested within the groups). Some work will need to be done to serialize this response properly. 2010-09-01 14:05:39 -07:00
Kris McQueen ec9ad29c9a Refactoring listLoadBalancerRules to new API framework. 2010-09-01 10:10:48 -07:00
Kris McQueen 583f29242d Refactoring listLoadBalancerRuleInstances to new API framework. 2010-08-31 18:59:20 -07:00
Kris McQueen 4be6af476d Refactoring listTemplates and listIsos to new API framework. 2010-08-31 14:50:30 -07:00
Kris McQueen 7e7baba8e7 Refactor listHosts API to new framework. 2010-08-30 18:02:54 -07:00
abhishek 854611e40a bug 5897: returning the os_type_id
status 5897: resolved fixed
2010-08-30 16:25:58 -07:00
Kris McQueen b797313ac0 Refactor listOSTypes API to new framework. 2010-08-30 16:18:40 -07:00
Kris McQueen 9abc658da0 Refactor listGuestOSCategories API to new framework. 2010-08-30 16:18:40 -07:00
Kris McQueen 5636503e39 Refactor listDomainChildren API to new framework. 2010-08-30 16:18:40 -07:00
Kris McQueen 4bb71d2a0c Refactor listEvents API to new framework. 2010-08-30 16:18:40 -07:00
Kris McQueen 9eeabb701a Refactoring listDomains to the new API framework. The search criteria are now retrieved from the command itself rather than creating an intermediate Criteria object first. 2010-08-30 16:18:40 -07:00
Kris McQueen e55e6c283f Refactoring work on listCapacities, listConfigurations, listClusters, and listDiskOfferings commands. The work represents consolidating the Criteria object into just pulling the search criteria directly from the command. Also changed BaseListCmd to server the startIndex and pageSizeVal [includes default page size of 50] rather than have each search command compute these things. 2010-08-30 16:18:39 -07:00
Kris McQueen 68275debc0 Refactor listAsyncJobs to new API framework, consolidating parameter and criteria packing/unpacking into just command unpacking to simplify building the search criteria. 2010-08-30 16:18:39 -07:00
alena 53892037c4 Refactored associateIPAddress and updateHost commands. 2010-08-30 15:22:42 -07:00
abhishek dc750e2691 Moving the disassoc logic to network manager 2010-08-30 10:50:27 -07:00
abhishek 7a0ad69b89 Incremental checkin 2010-08-30 10:40:45 -07:00
abhishek 742869b750 Refactoring the delete snapshot command. This has a lot of spaghetti calls, trying my best to make it works. Hopefully it all does, on the 1st pass 2010-08-27 11:26:14 -07:00
abhishek 284c630eeb Further refactoring the cmd 2010-08-27 10:27:00 -07:00
abhishek 0ea56e1504 refactored the delete port forwarding service rule cmd 2010-08-27 10:22:11 -07:00
kishan 0e326e853c bug 5900: Added events for disk offering 2010-08-27 18:02:23 +05:30
abhishek 126da4baf7 Refactored the delete user cmd 2010-08-26 17:58:53 -07:00
abhishek 3d8a3ef358 Refactoring the snapshot policies cmd 2010-08-26 17:17:30 -07:00
abhishek 8b8e0929f1 Refactored the delete template command 2010-08-26 16:15:42 -07:00
abhishek 4bdbc64bf7 Some more refactoring 2010-08-26 15:33:12 -07:00
abhishek 7f7a342cbe Refactoring the delete volume command 2010-08-26 14:31:25 -07:00
abhishek 604e7016a3 Incremental checkin 2010-08-26 14:18:36 -07:00
abhishek 2bdaaa48a6 Refactored the destroy vm command 2010-08-26 13:37:57 -07:00
abhishek 6070948e16 Merge branch '2.1.refactor' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 2.1.refactor 2010-08-26 11:11:10 -07:00
abhishek f73d14e267 Refactored the destroy console proxy command 2010-08-26 11:10:29 -07:00
Kris McQueen f30e0dc383 Adding the response object for alerts, initially created as part of the listAlerts refactoring. 2010-08-26 10:46:04 -07:00
Kris McQueen 187d89fce5 Refactoring listAlerts to the new API framework. This is now a BaseListCmd so it inherits keywork, page, and pagesize parameters. This also simplifies creating a Criteria object from the parameters, and then creating a search criteria from the criteria object. It's now one step...search criteria from the command itself. 2010-08-26 10:46:04 -07:00
abhishek d1b4034633 Mvoing console proxy manager to server 2010-08-26 10:30:52 -07:00
abhishek 88d41090ca Merge branch '2.1.refactor' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 2.1.refactor 2010-08-26 10:17:36 -07:00
abhishek 3a2930e383 Adding another manager 2010-08-26 10:16:51 -07:00
kishan acb23b6158 bug 5904,5474: added listCapabilities API 2010-08-26 14:53:03 +05:30
Kris McQueen 479ff26051 Refactoring createZone to new API framework. The logic was entirely delegated to configuration manager, so pushed the logic there and removed the proxy method from Management server. 2010-08-25 18:26:38 -07:00
Kris McQueen 34a3c3ece2 Refactored createVlanIpRange to new API framework. Moved logic to configuration manager, including the association of the ip addresses on a vlan with the account for which the vlan is being created. On deployVirtualMachine, this association might happen as well, and now mgmt server calls config manager. 2010-08-25 18:26:38 -07:00
Kris McQueen c085283c2e Refactor createUser to new API framework. Consolidate the old createUser (GWT UI used this API) and createUserAPI into one createUser method since it's only called through integration API now. Return a UserAccount instead of a User in order to generate a response with all the information required. Also clean up some of the unused private template code from ManagementServer that was mistakenly left in from a previous refactor. 2010-08-25 18:26:38 -07:00
Kris McQueen defae59126 Finish refactoring createTemplate to new API framework. The executor and result object from old framework still need to be deleted, but this commit moves all the business logic to the manager with validation in the createPrivateTemplateRecord and creating a snapshot if necessary in createPrivateTemplate. Additionally, added a find method on the template dao to check if the template name is in use for the account (this is part of the validation). 2010-08-25 18:26:38 -07:00
Kris McQueen 97f3068687 Work in progress refactoring createTemplate command to new API. The logic had been partially moved to the manager, still need to finish up moving the logic, then delete the unnecessary code. 2010-08-25 18:26:38 -07:00
will f8c93cd5fa Bug #:5975
Merge from 2.1.x

- Fixed issue where listAccounts only return one less than the actual number of accounts in the system.  That is because the SQL query asks for X accounts, but the API filters out the SYSTEM account.  The fix is to add the filter of the system account in the actual query itself rather than have the code do it.

Conflicts:

	server/src/com/cloud/api/commands/ListAccountsCmd.java
2010-08-25 18:21:32 -07:00
abhishek cf68dfb430 Refactored detach iso command 2010-08-25 15:33:06 -07:00
abhishek 37f6e794d9 Used the wrong base cmd 2010-08-25 14:54:38 -07:00
abhishek d8219225ea Import cleanup 2010-08-25 13:54:31 -07:00
abhishek 82fbae2553 Refactoring the detach volume command 2010-08-25 13:53:43 -07:00
abhishek 702658556b Refactoring the delete zone cmd 2010-08-25 11:16:07 -07:00
abhishek c2f517fa81 Refactoring the delete vlan ip range cmd 2010-08-25 10:59:14 -07:00
nit 6ae72df46a bug 5905: Adding deviceId tag to the ListVolumes command when the volume is attached. status 5905: closed fixed 2010-08-25 11:44:54 +05:30
Alex Huang fb389e8cd6 Merge branch 'master' of ssh://git.cloud.com/var/lib/git/cloudstack-oss 2010-08-24 00:01:09 -07:00
abhishek 5a8313cc51 Detach volume command refactor incremental checkin 2010-08-23 17:41:22 -07:00
abhishek 7f771cbe24 bug 5883: Final checkin for volume lineage
status 5853: RESOLVED FIXED
2010-08-23 16:17:18 -07:00
Alex Huang e0165dd2ef my changes 2010-08-23 13:59:23 -07:00
Jessica Wang 65b9f29941 Issue #: 5975
(1) API-side: make listDomains, ListDomainChildren return all items

(2) UI-side: make domains page show all domains by specifying pageSize=-1
2010-08-20 17:39:40 -07:00
abhishek ec9fdd5b16 Refactored disassociateipaddress cmd 2010-08-20 16:01:37 -07:00
abhishek 5503013e1f Refactoring the lockAccount cmd 2010-08-20 14:48:35 -07:00
abhishek 58598bb0cb Refactoring the lockUser cmd 2010-08-20 14:20:27 -07:00
abhishek 934173db2e Refactoring some more system vm commands 2010-08-20 12:19:37 -07:00
abhishek dc45e9b08b Refactoring the rebootvm cmd 2010-08-20 11:48:24 -07:00
abhishek be75946b1f Refactored the reconnectHost command 2010-08-20 11:14:48 -07:00
abhishek 49482e947b Refactoring another bunch of commands for vms 2010-08-20 10:38:44 -07:00
abhishek f625900b8b Refactoring the register command 2010-08-20 09:59:06 -07:00
abhishek d5b041a790 Refactoring register commands for template and iso 2010-08-19 17:59:56 -07:00
abhishek d468a0bd7f Incremental checkin 2010-08-19 16:40:41 -07:00
abhishek 21f7c0dec8 Refactored RegisterTemplateCmd 2010-08-19 16:33:26 -07:00
abhishek fcdeb5a97d Incremental checkin 2010-08-19 14:40:08 -07:00
abhishek 9da6d89837 Refactoring deleteServiceOffering cmd 2010-08-19 12:15:26 -07:00
abhishek c200375b0f Refactoring RemoveFromLoadBalancerRuleCmd 2010-08-19 11:59:56 -07:00
abhishek ef2b80f9c6 Refactoring the removePortForwardingService cmd 2010-08-19 10:55:58 -07:00
abhishek 25d5126f68 Refactoring the resetVmPassword command 2010-08-19 10:12:38 -07:00
alena 78846ec4eb 1) Fixed AddHost, AddSecondaryStorage, UpdateIso, UpdateTemplate to return correct command name.
2) Added missing accessors getFormat and isPasswordEnabled to UpdateTemplateOrIso abstract class.
2010-08-18 21:03:31 -07:00
Kris McQueen 78445d8348 Refactoring createStoragePool to new API framework. The logic was always in StoragePoolManager, mostly removed the management server proxy method which called into StoragePoolManager. There is still an outstanding TODO for this API in terms of the response. Once the storage pool has been added, there is a query for the allocated bytes on the pool in order to return proper storage stats. Hooking into this query to get the right data needs to be done. 2010-08-18 19:11:01 -07:00
Kris McQueen b0668df1b9 refactoring createSnapshotPolicy to new API framework...since this is a basic database create just move parameter validation to SnapshotManager and save the snapshot policy in the database 2010-08-18 19:08:23 -07:00
Kris McQueen da03aee028 Add snapshot manager to the list of managers that can be invoked through the API. This prepares the way for refactoring createSnapshot, but since the method is an async create that also needs to create a policy first and generally does not follow any other patters, I'll do this one last. 2010-08-18 19:08:23 -07:00
Kris McQueen 96f999a375 Refactoring createServiceOffering to the new API framework, just a simple database create that has been moved from a management server proxy method that calls configuration manager directly into the configuration manager. 2010-08-18 19:06:12 -07:00
Kris McQueen 88395cfcd8 CreatePortForwardingService has been refactored to the new API framework. CreatePortForwardingServiceRule has also been refactored to the new API framework. This is the first async create command, so there are some changes for the framework with async creates. First, the annotation has a 'createMethod' element, the framework will invoke the createMethod synchronously, update the id of the created object, return the jobId and objectId, then queue the method. Once the method is invoked the actual business logic will kick in, for example 'createVolume' will create a database record for the volume, return the appropriate id, and then asynchronously create the volume in the correct storage pool. The requirement is now that both a create method and an implementation method will be required in the given manager for async create commands. 2010-08-18 19:06:12 -07:00
abhishek 3198abd8c1 Refactoring network ingress group command 2010-08-18 17:52:55 -07:00
abhishek d6f1f641b4 bug 5934: Checking if scmbug works : TEST
status 5934: resolved fixed
2010-08-18 17:42:12 -07:00
Anthony Xu 41f7c745bd bug 5934: if it is standalone, give cluser name as Standalone-ip/name
status 5934: resolved fixed

Conflicts:

	server/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java
2010-08-18 17:33:25 -07:00
abhishek 2c670609b1 Merge branch '2.1.refactor' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 2.1.refactor 2010-08-18 16:15:09 -07:00
abhishek 66f51effd9 Refactoring startsystemvm cmd 2010-08-18 16:14:31 -07:00
alena 89179dd12e Api refactor 2010-08-18 16:00:31 -07:00
alena 46c331b54b Merge branch '2.1.refactor' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 2.1.refactor
Conflicts:
	server/src/com/cloud/storage/StorageManagerImpl.java
2010-08-18 15:52:23 -07:00
alena f1b95641cb Refactor api deletePool, addHost, addSecondaryStorage 2010-08-18 15:41:16 -07:00
abhishek 6ca1ceb769 Refactoring the startvm cmd 2010-08-18 15:38:02 -07:00
abhishek c58749b917 Refactoring StopSystemVmCmd 2010-08-18 14:55:19 -07:00
abhishek 716271fca1 Merge branch '2.1.refactor' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 2.1.refactor 2010-08-18 14:05:45 -07:00
abhishek aa6e9ab2bb Refactoring the startvm command 2010-08-18 14:01:15 -07:00
Alex Huang b250b985ec changes 2010-08-18 12:19:22 -07:00
alena e2950eb5a1 Merge branch '2.1.refactor' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 2.1.refactor
Conflicts:
	server/src/com/cloud/api/BaseCmd.java
	server/src/com/cloud/network/security/NetworkGroupManagerImpl.java
2010-08-18 11:36:05 -07:00
alena 3d85fdf687 API refactor 2010-08-18 11:24:29 -07:00
abhishek 8f54cac031 Resolve conflicts
Merge branch '2.1.refactor' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 2.1.refactor

Conflicts:
	server/src/com/cloud/api/BaseCmd.java
2010-08-18 10:41:34 -07:00
abhishek e553bcde96 Refactoring the updateResourceLimits code, moving all logic to agent manager, updating the enum with a new manager type for reflection 2010-08-18 10:32:21 -07:00
nitin 5331e13bac 5844 - adding more tags to updateTemplate API 2010-08-18 12:44:27 +05:30
Kris McQueen 261c96f99c refactor createPod command to new API framework 2010-08-17 19:08:06 -07:00
Kris McQueen 21ab91dc2c refactoring CreateNetworkGroup API command to new API framework 2010-08-17 19:07:00 -07:00
Kris McQueen 82d6edcdf3 Refactoring CreateIPForwardingRule and CreateLoadBalancerRule to new API framework 2010-08-17 19:07:00 -07:00
Kris McQueen a6c34d422c Work in progress for modifying createPortForwardingRule command.
- some of the logic has been moved to manager
  - some annotations have been added for the command itself
2010-08-17 19:07:00 -07:00
abhishek 154c6985a4 Refactoring updatePod command 2010-08-17 17:55:38 -07:00
abhishek 1252a2b8a7 Refactoring update service offering cmd 2010-08-17 17:21:04 -07:00
abhishek 57edd7d2f8 Refactoring the StorageManager interface into server code 2010-08-17 16:43:01 -07:00
abhishek 8b8f126a2c Called the wrong method, fixing the same 2010-08-17 16:11:44 -07:00
abhishek 7e502768ed Incremental checkin 2010-08-17 16:07:48 -07:00
abhishek 492fa760ff Removing unused imports 2010-08-17 15:19:09 -07:00
abhishek fffd1f2099 Refactoring permissions commands 2010-08-17 15:18:00 -07:00
abhishek 67b8a9e608 Incremental checkin 2010-08-17 14:52:29 -07:00
abhishek 4114c1b74a Adding the updatetemplateoriso command refactoring, 2010-08-17 14:14:16 -07:00
abhishek c092b78c47 Changing the manager 2010-08-17 12:22:26 -07:00
abhishek 001fc0f7ae Refactoring update user command 2010-08-17 12:12:07 -07:00
abhishek 6f680375f3 Refactoring some more vm commands, as well as refactoring the account and user validation into a method. Please use the same for future validation calls 2010-08-17 11:28:23 -07:00
abhishek a4ab5fa38d Creating a new response obj file 2010-08-17 10:56:06 -07:00
abhishek 7a937685b0 Adding the response object for UpgradeVmResponse 2010-08-17 10:54:01 -07:00
Kris McQueen 5ed3ec9192 Add response object interface.
Add response objects for CreateDiskOffering and CreateDomain.
Move validation of parameters for CreateDiskOffering and CreateDomain to business logic, add getResponse logic for these commands.
2010-08-16 18:12:31 -07:00
Alex Huang c5f822ca7a Merge branch 'master' of ssh://git.cloud.com/var/lib/git/cloudstack-oss 2010-08-16 11:30:22 -07:00
Alex Huang 867b43dcf9 more changes for the rewrite. 2010-08-16 11:28:11 -07:00
root 183eb4e4a3 Api refactoring for following commands: updateAccount, updateTemplate/Iso, UpdateDomain, EnableUser/Account, DeletePod 2010-08-15 21:01:24 -07:00
alena b4adabe4a9 Refactored EnableAccount api command 2010-08-13 17:51:00 -07:00
abhishek 5326d0ec89 bug 5922: Checking if bug db updates works
status 5922: resolved fixed
2010-08-13 14:07:55 -07:00
abhishek 7d14dd7576 Issue :# 5922
Status 5922: Resolved Fixed
Fix for 5922
2010-08-13 13:55:33 -07:00
alena 3268303d51 Merge branch '2.1.refactor' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 2.1.refactor 2010-08-12 16:34:51 -07:00
alena 167433e562 Api refactor:
* Moved ManagementServer interface from "core" to "server" package
* Changed AddConfig, UpdateCfg, UpdateAccount commands
2010-08-12 16:32:23 -07:00
abhishek d8cc85c42f Fixing the listAlerts api call to return the correct format for the sent on field 2010-08-12 15:52:34 -07:00
abhishek 5a0735edd6 Refactoring upgradeVmCmd (note that the response obj still needs to be constructed) 2010-08-12 14:22:30 -07:00
alena 8825147f0d Merge branch '2.1.refactor' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 2.1.refactor
Conflicts:
	server/src/com/cloud/configuration/ConfigurationManager.java
	server/src/com/cloud/configuration/ConfigurationManagerImpl.java
2010-08-12 11:41:02 -07:00
alena a9d48a1b8a Refactored updateDiskOffering and deleteDiskOffering commands 2010-08-12 11:27:37 -07:00
abhishek 23444d5f07 Refactoring the updateZone command 2010-08-12 10:59:59 -07:00
Kris McQueen 96f76062f9 Moving createDiskOffering to configurationManager, make AssignToLoadBalancer async 2010-08-11 19:32:09 -07:00
Kris McQueen 286d57f436 Remove old execute method from AssignToLoadBalancer. 2010-08-11 17:53:22 -07:00
Kris McQueen 0c644a5ccb Add EventUtils to consolidate the creation of events and make it usable from all managers (there were some private methods in ManagementServerImpl). Add some validation logic to AssignToLoadBalancer implementation in NetworkManagerImpl. 2010-08-11 16:53:03 -07:00
Manuel Amador (Rudd-O) 14ae76781e Committing Kris' big merge 2010-08-11 16:02:57 -07:00
Kris McQueen c49cdb21d8 Remove comment from testing Git and Eclipse 2010-08-11 13:55:05 -07:00
Kris McQueen 2a2d618da9 Add a comment for testing Git and Eclipse 2010-08-11 13:54:07 -07:00
Manuel Amador (Rudd-O) ac730ec496 Branch 2.1.refactor committed 2010-08-11 09:13:42 -07:00
Manuel Amador (Rudd-O) 05c020e1f6 Source code committed 2010-08-11 09:13:29 -07:00