Commit Graph

6918 Commits

Author SHA1 Message Date
Alena Prokharchyk 833c83d7f7 CLOUDSTACK-3387: deleteTemplate - log the exception message when delete command fails 2013-07-08 15:44:03 -07:00
Alena Prokharchyk f68a74eada CLOUDSTACK-3356: list shared networks available for projects when call is executed by the admin who is not a part of the project 2013-07-08 11:28:15 -07:00
Koushik Das 33ed076969 CLOUDSTACK-3393: Local disk recreated for stopped VM when started
Recreating local disk will result in cleanup of the old disk and this will lead to data loss. So preventing this and bailing out with error. Once migration of local disk is supported then another option is to migrate the existing disk to the new local storage pool.
2013-07-08 17:02:35 +05:30
toshiaki.hatano 814630c542 CLOUDSTACK-3384: CloudStack allow VLAN range between 0-4096. Should be 0-'4095'. 2013-07-08 15:19:12 +05:30
Murali Reddy ea8b85af2a CLOUDSTACK-234: create/delete firewa/lb/pf rule: send ip assoc command
only on first rule is created on the IP and last rule is revoked on the
IP

Current suboptima logic of IP Assoc

 - On associate IP to GuestNetwork there is an IPAssoc command sent to
   corresponding network service providers of the network
 - On every rule apply on IP associated with the network send IP assoc
   to the network service providers
 - On every rule deletion on IP associated with a network sernd IP assoc
   command to the network service providers

With this fix logic of IP assoc is changed as below which eliminates
executio of unnessary and expensive IpAssocCommand resource command

 - On associate IP to GuestNetwork, associate IP only to the network,
   Untill any service is associated with the IP dont send IP Assoc
 - On creation of first rule on the IP send IPAssoc to corresponding
   network service provider. Since IP is used for a service, IPAssoc
   need to be sent to correpondign service provider
 - On deletion of last rule on the IP send IPAssoc to corresponding
   network service provider. When last rule is deleted, IP has no
   service associated with it, so send IP assoc to service provider to
   remove the IP association
2013-07-08 14:52:12 +05:30
Ryan Dietrich 70f33efa72 CLOUDSTACK-3190: Async jobs actions now trigger event bus messages to be
published

-AsyncJobManagerImpl to publish async job events when async jobs are
created, updated and completed
2013-07-05 17:48:25 +05:30
Likitha Shetty 06c8e5bfd8 Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/cloudstack 2013-07-05 16:28:24 +05:30
Likitha Shetty 9c5da1c6e3 CLOUDSTACK-3361. [Projects] Allow a normal user to edit public templates created by him. 2013-07-05 16:21:47 +05:30
Wei Zhou f93c51e2bd CLOUDSTACK-3345: createLBStickinessPolicy replaces old stickiness policy if exists 2013-07-05 10:02:29 +02:00
Wei Zhou ac438a6d1d CLOUDSTACK-3372: CapacityManager does not count destroyed volumes when deploy VMs 2013-07-05 09:49:56 +02:00
Hugo Trippaers 41fa79f65c The millisecond to second calculation was done with a bit shift of 10.
This is in effect a division by 1024, while time in ms should be divided
by 1000. The difference of 24 adds up to about a 381 day difference
today. This confuses anybody checking the timestamps in the logs.
2013-07-04 18:39:03 +02:00
Murali Reddy a8a23c4364 CLOUDSTACK-2045:[Multiple IPs Per Nic] This feature is not working well
in case of networks with external devices after GC

adding missing 'retrun false' for isNetworkReadyForGc for the networks
that use external network devices and has secondary IP's associated with
nics.
2013-07-04 21:30:31 +05:30
Kishan Kavala 7a8d7eaa60 CLOUDSTACK-3172: Allow creation of private gateway with same Vlan in different VPCs 2013-07-04 16:11:12 +05:30
Harikrishna Patnala 968c252ca5 CLOUDSTACK-3351: Fix add cluster API to set right hypervisor type
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2013-07-04 14:23:08 +05:30
Alex Huang 43ab9506ab Moved HostAllocator and PodAllocator from server to api package, where they are supposed to be. In the process, I had to change the VO objects used by these two itnerfaces to interface equivalent. This makes sense because there's really no reasons why allocators require write access to the database. One of the files have been reformatted because it contained a bunch of tabs instead of spaces for indentation. 2013-07-03 17:48:53 -07:00
Alena Prokharchyk d8560281a4 CLOUDSTACK-3347: fixed project deletion for project's owned template
Conflicts:
	server/src/com/cloud/template/TemplateAdapterBase.java
2013-07-03 13:48:06 -07:00
Alex Huang bec53fb59a VMSync: Separating jobs from api 2013-07-03 11:22:40 -07:00
Sanjay Tripathi 31df729008 CLOUDSTACK-3184: updateVirtualMachine api gives java NPE.
Signed-off-by: Prasanna Santhanam <tsp@apache.org>
2013-07-03 19:39:02 +05:30
Daan Hoogland 141fbc7ef7 cidr compare fixme addressed 2013-07-03 09:28:49 -04:00
Nitin Mehta 90a15bfff6 CLOUDSTACK-2107
If the scaling up fails on the host the vm is running on try to migrate it to other hosts in the cluster and try scaling.
CLOUDSTACK-3349
For deciding the host in the cluster try the new deployment manager now
Signed off by : nitin mehta<nitin.mehta@citrix.com>
2013-07-03 18:40:22 +05:30
Hugo Trippaers 4e823e3a3e Workaround for NPE 2013-07-03 14:59:03 +02:00
Min Chen d425fa76f7 CLOUDSTACK-3335:[Object_Store_Refactor][Automation]CopyTemplate failed
with Unexpected exception.
2013-07-02 18:01:47 -07:00
Prachi Damle 8780fef05a CLOUDSTACK-3047 java.lang.NullPointerException encountered when executing capacityChecker thread.
Changes:
- Added null check around clusterId, since its possible to have null clusterId for storagepool and host records
2013-07-02 16:36:58 -07:00
Min Chen 9a3067fb87 CLOUDSTACK-3314: templates downloaded to S3 should show up in
listTemplates when zoneId is provided.
2013-07-02 15:47:49 -07:00
Alena Prokharchyk 8a0470ee0f CLOUDSTACK-3207: added resourceLimit/resourceCount to the Project API response
Conflicts:
	setup/db/db/schema-410to420.sql
2013-07-02 15:34:08 -07:00
Min Chen 05f4680735 CLOUDSTACK-3314: ListTemplates only show one entry for cross-zone
templates.
2013-07-02 13:54:40 -07:00
Rajesh Battala d660bc7e8d CLOUDSTACK-3089 [ZWPS] NPE while cancelling the Storage Maintenance
Signed-off-by: Edison Su <sudison@gmail.com>
2013-07-02 11:51:16 -07:00
Rajesh Battala 2bc4cbf9fb CLOUDSTACK-2571 Zone Wide Primary Storage blocker issues while Enabling in Maintenance State
Signed-off-by: Edison Su <sudison@gmail.com>
2013-07-02 11:49:16 -07:00
Murali Reddy 2f3764ef94 CLOUDSTACK-1959: GSLB: add capability to provide weights to the sites
involved in the GSLB

add weights to each site participating in the GSLB. Traffic will be load
balanced across the sites based on the weigths associated with each
site. If not specified weight of site is defaulted to 1.
2013-07-02 17:55:58 +05:30
Alena Prokharchyk 54c2133590 CLOUDSTACK-2984: createNetwork call - when vlan is specified, check that its not coming from the physical network vnet range as this range is used for dynamic vlan allocation during the network implementation stage 2013-07-01 16:17:43 -07:00
Alena Prokharchyk 37f12a31a3 CLOUDSTACK-236: log uuid instead of actual db id, in the updateNetworkOffering method 2013-07-01 15:13:19 -07:00
Jessica Wang 1762be05a9 CLOUDSTACK-2084: API - when account type is ACCOUNT_TYPE_PROJECT, make listVlanIpRanges API to return accountName. 2013-07-01 14:22:06 -07:00
Murali Reddy 1c67e34c82 CLOUDSTACK-3287: [GSLB] API "updateGlobalLoadBalancerRule" is not
recognised by CloudStack

added api to managementServerImpl and ensure glsb config is applied to
gslb service providers
2013-07-02 00:07:58 +05:30
Sanjay Tripathi 301c91c099 CLOUDSTACK-3189: Primary storage usage is not getting decremented after deleting the DATA volumes.
When a volume is created the resource usage for it gets incremented. If it is deleted without being
attached to a volume, the decrement doesn't take place. Fixed the delete volume code to decrement
resource usage for a volume in allocated state too.
2013-07-01 23:41:10 +05:30
Daan Hoogland 639592f3b7 readibilty of log- and exception messages
Signed-off-by: Prasanna Santhanam <tsp@apache.org>
2013-07-01 20:17:11 +05:30
Sanjay Tripathi ffd5f1a777 CLOUDSTACK-2288: NPE while creating volume from snapshot when the primary storage is in maintenance state.
Signed-off-by: Prasanna Santhanam <tsp@apache.org>
2013-07-01 20:17:11 +05:30
Murali Reddy e07a8b3f51 CLOUDSTACK-3282:[GSLB] Unable to add multiple LB rules to same GSLB rule
-fixing regression due to adding GSLB monitor for GSLB service

-code to add/delete GSLB monitor and GSLB service-monitor binding is
made idempotenet so as to succeed if the resource exists.
2013-07-01 19:07:00 +05:30
Nitin Mehta 4c0425f918 CLOUDSTACK-2813 - Some deployment failures do not release the resources.
Applying the short term fix of force cleaning up if the answer recieved from startcommand is not valid
Signed off by : nitin mehta<nitin.mehta@citrix.com>
2013-06-30 14:53:32 +05:30
Edison Su 49ded7e4a3 the plugin better not touch database 2013-06-29 15:09:43 +05:30
Prasanna Santhanam de38cd815f Fix typo in class name
AsyncRpcConext -> AsyncRpcContext

Signed-off-by: Prasanna Santhanam <tsp@apache.org>
2013-06-29 13:50:25 +05:30
Min Chen 87c401aaaf CLOUDSTACK-3144: [Automation] Deletion of templates failing. Fails to
find image store housing template.
2013-06-28 17:57:42 -07:00
Min Chen 2c31f38c05 CLOUDSTACK-3145:StorageManager-Scavenger NPEs when cleaning up
templates.
2013-06-28 17:54:48 -07:00
Mike Tutkowski 99227f7b3e SolidFire plug-in and related changes
SolidFire plug-in

SolidFire plug-in related
2013-06-28 16:59:21 -06:00
Prachi Damle 02ab2eb384 Revert "Cloudstack-2150 DB table entries of phisical network is not proper.Shows Duplicate entries Cloudstack-2980 Adding a VLAN range that overlaps with two existing ranges results in inconsistent DB entries"
This reverts commit 7f2f25d640.
2013-06-28 14:58:32 -07:00
Vijayendra Bhamidipati 78922589bb CLOUDSTACK-2385: template download fails with Unexpected failure in Vmware.
Description:

    Putting in fix to allow download of guest VM templates that are available
    across zones.
2013-06-28 23:08:36 +05:30
Bharat Kumar 974245991c Cloudstack-2732 [Multiple_IP_Ranges] Deleting guest IP range is not throwing any error message to user while the ip addresses are being used
Signed-off-by: Jayapal <jayapal@apache.org>
2013-06-28 19:05:55 +05:30
Bharat Kumar 6b0df2566d Cloudstack-3106 Delete all ips except ipAlias. Cloudstack-3119 Shared network removal doesn't cleanup corresponding IP ranges
Signed-off-by: Jayapal <jayapal@apache.org>
2013-06-28 19:05:55 +05:30
Bharat Kumar 7f2f25d640 Cloudstack-2150 DB table entries of phisical network is not proper.Shows Duplicate entries Cloudstack-2980 Adding a VLAN range that overlaps with two existing ranges results in inconsistent DB entries
Signed-off-by: Jayapal <jayapal@apache.org>
2013-06-28 19:05:54 +05:30
Jayapal 3096261c05 Updated to show same value in log msg SetFirewallRulesCommand and accessdetails for egress default policy 2013-06-28 19:05:54 +05:30
Murali Reddy 0f40cfbea8 CLOUDSTACK-2045: [Multiple IPs Per Nic] This feature is not working well
in case of networks with external devices after GC

add an exception for networks that use external networking devices and has
secondary guest IP's allocated. On network GC, when network goes through
implement phase a new vlan is allocated, based on the acquired VLAN id cidr
of the network is decided in case of external networking case. While NIC
uses reservation strategy 'Start' which ensures that new primary ip is
allocated for the NiC from the new CIDR. Secondary IP's have hardcoded
IP's in  network rules. So prevent network GC.
2013-06-28 12:26:20 +05:30
Kishan Kavala 6da29c4cde CLOUDSTACK-650: Rename ExternalLBUsageMgr to more generic ExternalDeviceUsageManager since it contains firewall usage also. Most of the functionality is already fixed in CLOUDSTACK-1289 2013-06-28 12:08:33 +05:30
Kishan Kavala 7713c5cdbc CLOUDSTACK-3239: Delete Traffic Monitor directly without going through maintenance state 2013-06-28 11:12:55 +05:30
Devdeep Singh 4bbc65b34c CLOUDSTACK-3246: Unable to use portable ips if the portable ip range is deleted and readded atleast once. Fixed the query used to look for available portable ips. 2013-06-28 03:32:31 +05:30
Min Chen 3160a0c2da Add template zone related information into TemplateZoneResponse. 2013-06-27 14:34:00 -07:00
Harikrishna Patnala c8692f2e4a CLOUDSTACK-3245: non admin user not able to register template
Reviewed-by: Alena Prokharchyk
2013-06-27 14:09:52 -07:00
Saksham Srivastava 0d78868180 CLOUDSTACK-3064: Able to create an instance from different account of the same domain without
using affinity group even if the zone is dedicated to an account. The check to make sure that
explicit resources are not picked up for non-explicit deployment was present only at the domain
level for zones. Added a check at account level too.
2013-06-28 00:32:17 +05:30
Donal Lafferty 4361418e41 Removed Dead Code from Management Server Hyper-V 2012 Support
Update ImageFormat enum to include VHDX format introduced with Hyper-V
Server 2012.
Remove existing Hyper-V plugin, because it does not work and is dead
code.
Remove references to existing Hyper-V plugin from config files.
Remove Hypervisor.HypervisorType.Hyperv special cases from manager code
that are unused or unsupported.
Specifically, there is no CIFS secondary storage class
"CifsSecondaryStorageResource".  Also, the Hyper-V plugin's
ServerResource is contacted by the management server and not the other
way around.
Add Hyperv-V support to ListHypervisorsCmd API call

Signed-off-by: Edison Su <sudison@gmail.com>
2013-06-27 11:46:02 -07:00
Alena Prokharchyk 77fd76acb4 CLOUDSTACK-3242: fixed updateTemplate and updateTemplate permissions security checks for project based templates 2013-06-27 11:32:41 -07:00
Wei Zhou 181567ba74 CLOUDSTACK-1192: Disk I/O Statistics (vm stats) support KVM and XenServer only util 2013/06/25 2013-06-27 14:25:54 +02:00
Alena Prokharchyk 079f920494 CreateVPC: validate that the zone exists before checking its attributes 2013-06-26 15:26:20 -07:00
Murali Reddy 4bc6294746 CLOUDSTACK-3213: ResourceStateEvents for user VM are generated with
entity type as Network

changing entity type to be VirtualMachine from Network for the events
generated by user vm state transitions
2013-06-26 19:33:24 +05:30
Murali Reddy ff167134e4 CLOUDSTACK-3214: transferring portable IP across zones with enableStatic
NAT does not work

making an exception for portabe IP, so that if the current datacenter with
portable IP is associated is different from destiantion data center

also on transfer on to new zone, transfer the portable ip association to
new data center, physical network id's
2013-06-26 19:29:55 +05:30
Harikrishna Patnala 9385cf0453 CLOUDSTACK-2835: VR Deployement from admin registered template is failing because registered template type is user. Additional parameter "isrouter" in register/update template API for the root admin. True if registered template is of type ROUTING.
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2013-06-26 16:00:12 +05:30
Harikrishna Patnala ec2bf09284 CLOUDSTACK-2794: Global parameter "router.template.id" should be removed The parameter was not in use. We use zone/global coonfigutaion parameters router.template.xenserver/vmware/hyperv/kvm/lxc to deploy router
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2013-06-26 15:56:40 +05:30
Likitha Shetty 55f0e167ec CLOUDSTACK-3206. CreateVlanIpRange fails with IndexOutOfBoundsException. 2013-06-26 14:59:36 +05:30
Wei Zhou 3bb4ec9f65 CLOUDSTACK-1192: Disk I/O Statistics support KVM only util 20130625 2013-06-26 11:10:11 +02:00
Jayapal 82958f0d58 CLOUDSTACK-3199 apply acl item to private gateway when added to acl list 2013-06-26 14:31:56 +05:30
Mice Xia 94254e3c2b fix CLOUDSTACK-2989, do not list network offering with specifyvlan=true for non-root-admin user 2013-06-26 15:55:32 +08:00
Likitha Shetty 8a1fefc7aa CLOUDSTACK-3192. When a dedicated public ip range is released, don't generate usage event EVENT_NET_IP_RELEASE
for ips in the range that are in use becauase these ips are not disassociated from the account.
2013-06-26 10:51:39 +05:30
Alena Prokharchyk 1eacd7872e Update resource count for networks only when the network is non system and Isolated. Before we used to update the count only when offering had specifyVlan=false. And in 4.2 even isolated networks can have this attribute set to true, and we have to count them 2013-06-25 13:46:35 -07:00
Hiroaki KAWAI ed5697f3e1 filter out the network providers that does not handle IP address
The elements that deploy IP address are subclass of IpDeployingRequester
CloudRuntimeException will be raised for elements that is not implemeing
the interface at NetworkManagerImpl#applyIpAssociations.
2013-06-25 13:18:06 +09:00
Harikrishna Patnala f7b1d3d8d5 CLOUDSTACK-2916: admin is not able to login through UI after setting GP "cluster.cpu.allocated.capacity.notificationthreshold" to some string
CLOUDSTACK-2457:  No check for input values,special character,-ive values can be assigne to GLobal parameter "cluster.cpu.allocated.capacity.disablethreshold"

Added validation for float values and checking limit for weight based parameters by creating a set of parameters.
Signed off by : nitin mehta<nitin.mehta@citrix.com>
2013-06-24 20:00:09 +05:30
Kishan Kavala da0006618f CLOUDSTACK-3124: Deletion of ACL associated with a tier/ pvt gateway should not be allowed. Check for associated tiers/gateways before deletion 2013-06-24 17:58:29 +05:30
Sateesh Chodapuneedi e9df9c29bd CLOUDSTACK-3155 [VMware] Deletion of zone should not be allowed if VMware DC is still associated with that zone.
Check if there exists any VMware DC already associated with this zone. Deny zone deletion if true.

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-06-24 12:11:31 +05:30
Kishan Kavala bd5ad442d0 CLOUDSTACK-3084: Added check to disallow -ve number for ACL rule 2013-06-24 17:20:29 +05:30
Kishan Kavala 7c46cc9580 CLOUDSTACK-3149: Allow default ACLs when creating tier with ACL 2013-06-24 16:22:02 +05:30
Jayapal bb50c0d2d6 CLOUDSTACK-3148 failed to create private gw with default acl id 2013-06-24 13:37:01 +05:30
Jayapal c22e7d0052 CLOUDSTACK-1578 SRX: Egress default policy configurable using network offering on SRX firewall 2013-06-24 13:37:01 +05:30
Jayapal 6a7ae637dd CLOUDSTACK-1578 Egress default policy configurable using network offering in xenserver with VR as firewall provider 2013-06-24 13:37:00 +05:30
Harikrishna Patnala 1eb744fa16 CLOUDSTACK-2181: Scale down is allowed when one resource(say cpu) is being scale up and other resource (say ram) is
being scale down ;but not allowed when both resources are being scaledown
Signed off by : Nitin Mehta<nitin.mehta@citrix.com>
2013-06-24 12:09:55 +05:30
Sheng Yang fe32dc7665 Baremetal: Add BaremetalDhcp Server and BaremetalPxe server to avoid list of stats collector 2013-06-21 17:36:21 -07:00
Sheng Yang db97bb8e89 Fix NPE when using baremetal template
Template size is NULL for baremetal, which caused NPE when unboxing
2013-06-21 17:16:33 -07:00
Min Chen 64c5266ec5 CLOUDSTACK-3120: ListTemplates didn't return Baremetal templates after
storage refactor.
2013-06-21 16:10:39 -07:00
Alena Prokharchyk 22232f2baf CLOUDSTACK-2698: always generate new id when create VirtualRouter. Don't try to re-use the id of the VR that failed to deploy and was expunged as a result of this failure 2013-06-21 15:29:00 -07:00
Sheng Yang 041303cc67 Baremetal: Fix typo of BaremetaUserdataProvider
Should be "Baremetal" rather than "Baremeta"
2013-06-21 09:48:25 -07:00
Sheng Yang 2edfa9a7f2 Baremetal: DB upgrade
Conflicts:
	setup/db/db/schema-410to420.sql
2013-06-21 09:47:45 -07:00
Sheng Yang f37b089fce Revert "Removing baremetal related references"
This reverts commit 99ea4011b1.

Conflicts:
	server/src/com/cloud/network/NetworkServiceImpl.java
2013-06-21 09:46:56 -07:00
Min Chen 2f9ba709a5 Add listCacheStoresCmd api for UI to list cache stores. 2013-06-20 18:06:30 -07:00
Edison Su 6b9ea1761a CLOUDSTACK-2947: fix create template from snapshot, in case of mix zone-wide/cluster wide primary storage 2013-06-20 17:51:11 -07:00
Min Chen 2fe732b354 CLOUDSTACK-3080: listVirtualMachines tag search refinement no longer
working.
2013-06-20 15:44:01 -07:00
Alena Prokharchyk 2072026340 CLOUDSTACK-3088: fixed listRouters/listInternalLbVms by name 2013-06-20 10:37:59 -07:00
Alena Prokharchyk bf331064a2 CLOUDSTACK-3091: expect UUID instead of actual DB id, when read internallbvm.service.offering global config 2013-06-20 10:37:59 -07:00
Kishan Kavala b422d8ddd9 CLOUDSTACK-2819: Revoke existing ACL items if the new ACL is empty 2013-06-20 17:06:06 +05:30
Jayapal 2e0abccd3b CLOUDSTACK-2952 Fixed configuring private gateway with another vpc acl id 2013-06-20 16:11:20 +05:30
Kishan Kavala 03d1346dc3 CLOUDSTACK-2915: Create network ACL when adding ACL item to a tier without ACL for backward compatibility 2013-06-20 15:36:58 +05:30
Likitha Shetty 9df45065d0 CLOUDSTACK-3078 2013-06-20 14:34:33 +05:30
Edison Su 733ed3622d fix compile 2013-06-20 00:57:06 -07:00
Edison Su 97f8c524b8 merge object_store 2013-06-20 00:18:00 -07:00
Likitha Shetty 4a260672e0 CLOUDSTACK-3078. Since no default value is set for the isolation type during the physical network creation,
modify guest vlan range dedication to check if the isolation type is VLAN only when an isolation type has been set
2013-06-20 12:09:32 +05:30
Bharat Kumar f9e7094282 Cloudstack-2644 [Multiple_IP_Ranges] user data service on VR does not work in case of multiple subnets Cloudstack-2953 [Multiple_IP_Ranges] VM does not get the public key from VR incase of multiple subnets per vlan Also removed some unused code and fixed the an error in the dnsmasq config function
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2013-06-20 11:15:15 +05:30