Commit Graph

35426 Commits

Author SHA1 Message Date
Nicolas Vazquez 1ed0830bc4
[Vmware][Deploy-as-is] Refactor the OVF parsing (#5825)
* Add the list of supported namespaces per document and refactor the disks extraction by using the namespaces

* Refactor matching the default OVF schema

* Move parser methods to a new class and refactor

* Fix import, unit tests

* Reduce indentation

* Address review comments
2022-01-26 11:24:40 +05:30
Abhishek Kumar d18ef1c0fd
ui: add custom form for update template (#5434)
* ui: add custom form for update template

* label fix

* changes and fix

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-01-25 10:47:41 +05:30
sureshanaparti 06b5e84182
Removed redundant parsing of VMSnapshot usage record. (#5872) 2022-01-24 18:06:02 +01:00
Abhishek Kumar 68a5e5aa77
ui: show password with success notification (#5889)
Fixes #5888

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-01-24 17:05:07 +05:30
Suresh Kumar Anaparti 97d6cd50a0
Merge branch '4.16' into main 2022-01-21 19:59:35 +05:30
DK101010 f639f56834
fill volume attached field (#5865)
Co-authored-by: DK101010 <dirk.klahre@itelligence.de>
2022-01-20 19:24:26 +05:30
sureshanaparti 4996b800b5
Now correct values are shown when configuring limits for a domain. (#5874) (#5880)
Now correct values are shown when configuring limits for a domain. (#5874) (#5880)

Co-authored-by: JoaoJandre <48719461+JoaoJandre@users.noreply.github.com>
Co-authored-by: Joao <JoaoJandre@gitlab.com>
2022-01-20 14:37:51 +05:30
Wei Zhou f3289fb596
server: fix regular user can create isolated network without sourcenat (#5844)
* server: fix regular user can create isolated network without sourcenat
2022-01-20 14:10:23 +05:30
JoaoJandre 7f000f5016
Now correct values are shown when configuring limits for a domain. (#5874)
Co-authored-by: Joao <JoaoJandre@gitlab.com>
2022-01-20 10:28:56 +05:30
dahn fb35f46a96
Delete ldap config from UI (#5871)
* add params to delete command

* pass known params

Co-authored-by: Daan Hoogland <dahn@onecht.net>
2022-01-18 10:21:51 +01:00
Hoang Nguyen 0e2c09baca
UI - Fixes Pod, Cluster selected is incorrect on addHost dialog (#5869)
* fix pod selected is incorrect

* fixes fetch cluster with podid empty

* clear clusterid field
2022-01-18 14:35:28 +05:30
Suresh Kumar Anaparti 0efdc535a5
Merge branch '4.16' into main 2022-01-18 12:44:55 +05:30
Nicolas Vazquez e18ff602f8
Prevent upgrade failures if there are existing annotations permissions (#5846)
* Do not fail if there are existing role permissions for annotations
* Refactor
* Improve refactor
* Do not update if there are existing role permissions for annotations
* Fix exception on upgrade
* Remove extra space from suggestion
* Apply suggestions from code review

Co-authored-by: sureshanaparti <12028987+sureshanaparti@users.noreply.github.com>
2022-01-18 11:20:00 +05:30
Abhishek Kumar f5b0d2f056
ui: fix create user domain, account selection (#5487)
* ui: fix create user domain, account selection

* fetch accounts only after domains

* refresh on saml configure

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-01-17 16:30:29 +05:30
Hoang Nguyen a42ed1fb89
add a setting to config.json that allows users to set theme (#5584) 2022-01-17 11:30:56 +05:30
Abhishek Kumar 59a615cf21
ui: fix deploy vm in basic zone (#5856)
* ui: fix deploy vm in basic zone

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-01-14 16:29:35 +05:30
Hoang Nguyen 619c754903
Clear cache APIs when the switch domain with SAML user (#5855) 2022-01-14 16:20:56 +05:30
Suresh Kumar Anaparti a6271b8306
Merge branch '4.16' into main 2022-01-13 22:49:11 +05:30
Abhishek Kumar c86b98e682
ui: show account configure limits tab for domain-admin (#5858)
Fixes #5676

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-01-13 14:08:02 +01:00
Hoang Nguyen 4746509c82
[UI] Cancel all requests api, async jobs in UI when user logs out (#5663)
* cancel requests in UI when user logs out

* clear notification, message from UI after logout
2022-01-13 17:44:49 +05:30
Hoang Nguyen 001f4213c8
UI - Deploy VM with params from the template, iso, network pages (#5653)
* deploy VM with params from the template, iso, network pages

* remove default-checked not necessary
2022-01-13 16:59:41 +05:30
Suresh Kumar Anaparti 42a941cc70
Merge branch '4.16' into main 2022-01-13 12:47:08 +05:30
Abhishek Kumar d78a815442
server: fix update vm with unconstrained offering (#5828)
Fixes #5694

Signed-off-by: Abhishek Kumar <abhishek.kumar@shapeblue.com>
2022-01-13 12:30:12 +05:30
Abhishek Kumar c17ae740f4
ui: fix getDiagnosticsData files field (#5853)
Fixes #5707

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-01-12 13:52:01 +05:30
Wei Zhou 216bea1978
ipv6: disable IPv6-only shared network with VR (#5810)
* ipv6: disable IPv6-only shared network with VR

* Update #5810: import org.apache.commons.lang3.StringUtils
* Update #5810: do not import org.apache.commons.lang3.StringUtils
* Update server/src/main/java/com/cloud/network/NetworkServiceImpl.java
* Update engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java

Co-authored-by: Daniel Augusto Veronezi Salvador <38945620+GutoVeronezi@users.noreply.github.com>
2022-01-12 13:33:35 +05:30
Abhishek Kumar 223bc11d2a
ui: fix paging in enable static NAT form (#5849)
Fixes #5715

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-01-11 22:31:02 +05:30
Gabriel Beims Bräscher 2e2d328cde
Add toggle button on the UI for list including elements in projects. (#5790)
* Allow to use projectid=-1 and list all resources (e.g. VMs) regardless of their project.
2022-01-11 21:30:30 +05:30
Abhishek Kumar c08592cad8
ui: update vm haenable only for supported vms (#5847)
For VMs which have service offering that does not allow HA, haenable option will be not shown in the UpdateVM UI form.

Fixes #5743

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-01-11 14:55:11 +05:30
Suresh Kumar Anaparti e1b56be67c
Merge branch '4.16' into main 2022-01-11 12:46:33 +05:30
Wei Zhou 9293f5bd27
server: fix enable/disable static nat if userdata is not supported (#5839)
* server: fix enable/disable static nat if userdata is not supported

* Update #5839: rename applyUserData to applyUserDataIfNeeded

* Update server/src/main/java/com/cloud/network/rules/RulesManagerImpl.java

Co-authored-by: Daniel Augusto Veronezi Salvador <38945620+GutoVeronezi@users.noreply.github.com>
2022-01-11 12:22:59 +05:30
dahn 7ea2cbd889
Storage pool absent (#5841)
* simple null check

Co-authored-by: Daan Hoogland <dahn@onecht.net>
Co-authored-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Co-authored-by: Daniel Augusto Veronezi Salvador <38945620+GutoVeronezi@users.noreply.github.com>
2022-01-11 12:18:55 +05:30
Wei Zhou fadd74aaca
network: fix vm can be deployed on L2 network of other accounts (#5784)
* Update #5769: fix domain admin can deploy vm on L2 network of other users

* test: fix test_storage_policy.py

* Update #5784: revert part of changes in #2420
2022-01-11 12:16:00 +05:30
dahn 028d338aaa
remove VmWorkJob after adding a nic to a vm (#5658)
Co-authored-by: Daan Hoogland <dahn@onecht.net>
Co-authored-by: Suresh Kumar Anaparti <suresh.anaparti@shapeblue.com>
Co-authored-by: Wei Zhou <weizhou@apache.org>
2022-01-10 16:31:50 +01:00
Hoang Nguyen 4916f3c90d
UI - Fix Locked "Override Root Disk Size" switch (#5843)
* Fix Locked "Override Root Disk Size" switch

* fixes ut
2022-01-10 19:04:46 +05:30
Hoang Nguyen 0f926b5d68
UI: Add s3 provider option to create secondary storage (#5726)
* add s3 provider option to create secondary storage

* fixes label name

* add storagepolicy for swift provider
2022-01-10 19:01:53 +05:30
SadiJr 5d7ea30f87
vmware: Remove restriction, in VMWare, to resize only SCSI disks (#5650)
Remove restriction, in VMWare, to resize only SCSI disks, because VMWare supports resize of subtypes of SCSI, like LSILOGIC, LSILOGIC SAS, etc

In VMWare, there are different types of SCSI controllers, such as BusLogic Parallel, LSI Logic Parallel, LSI Logic SAS, etc. All of these sub-types support the disk resize operation, the only exception is the IDE controller. However, in ACS, there is a logical restriction to allow only resizing of volumes of the specific SCSI type; thus, not allowing resizing of the SCSI sub-types. This PR corrects this behavior blocking the resize of volumes which uses IDE controller only.
More information can be found at:

https://www.starwindsoftware.com/blog/storage-controllers-in-vmware-vsphere
https://www.nakivo.com/blog/scsi-controller-and-other-vmware-controller-types/
https://docs.vmware.com/en/VMware-vSphere/7.0/com.vmware.vsphere.vm_admin.doc/GUID-5872D173-A076-42FE-8D0B-9DB0EB0E7362.html
https://communities.vmware.com/t5/ESXi-Discussions/Unable-to-increase-disk-Space/td-p/397823

Co-authored-by: SadiJr <sadi@scclouds.com.br>
2022-01-08 09:02:00 +05:30
Nicolas Vazquez 946f9156e5
vmware: Persist empty values instead of null (#5748)
This PR allows deploying VMware appliances missing default values on some properties
Fixes: #5747
2022-01-08 08:58:46 +05:30
slavkap 48006de3e3
kvm: Set RAW format to RBD DATADISK (#5801)
While deploying a VM with data disk on Ceph the volume format was in
QCOW2.

Fixes #5531
2022-01-08 08:54:21 +05:30
Abhishek Kumar feb4343abe
ui: fix create network/vpc offering form (#5840)
* ui: fix create network/vpc offering form

Fixes #5838

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* fix inlinemode

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-01-08 08:41:58 +05:30
Wei Zhou 84b9b61b9b
api: fix typo in Volume Destroy state - volume can be recovered (#5833)
* api: fix type Destroy volume can be recovered

* Update api/src/main/java/com/cloud/storage/Volume.java

Co-authored-by: dahn <daan.hoogland@gmail.com>
2022-01-07 13:19:26 +05:30
Wei Zhou 6d35b520d3
server: fix vm can be recovered by other accounts (#5822) 2022-01-07 13:13:48 +05:30
SadiJr e993a20e5a
[Veeam] Force ACS to use the template repository to clone job (#5774)
* [Veeam] Force ACS to use the repository of the template to clone job

* Address reviews

* Fix checkstyle

Co-authored-by: SadiJr <sadi@scclouds.com.br>
2022-01-07 11:12:57 +05:30
Suresh Kumar Anaparti 5c02f6d507
Merge branch '4.16' into main 2022-01-06 17:47:37 +05:30
Hoang Nguyen 3cbde8cd6c
UI - Hide shrink disk option on XCP-NG/Xenserver (#5829)
* hide shrink disk option on XCP-NG/Xenserver
2022-01-06 17:41:54 +05:30
dahn 2774bc156f
use physical size instead of virtual size for migration. (#5750)
* Use Physical size to evaluate if migration is possible

* Improve logging and consider files skipped as failure in complete migration

* skipped can't be negative

* remove useless method

* group multidisk templates for secstor migration

* use enum

* Update engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/DataMigrationUtility.java

Co-authored-by: sureshanaparti <12028987+sureshanaparti@users.noreply.github.com>
Co-authored-by: Pearl Dsilva <pearl1594@gmail.com>
Co-authored-by: Daan Hoogland <dahn@onecht.net>
Co-authored-by: Pearl d'Silva <pearl.dsilva@shapeblue.com>
2022-01-06 17:18:50 +05:30
Abhishek Kumar 51f69f7134
server: do not return inaccessible entity details to normal users (#5827)
Fixes #5534

As pre 3.x APIs allow using internal DB IDs, even normal users can use internal IDs.
This fix removes additional information in error message when the caller doesn't have access to the resource.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-01-06 16:42:57 +05:30
Suresh Kumar Anaparti 30ae9eedad
Merge branch '4.16' into main 2022-01-05 10:14:47 +05:30
Hoang Nguyen f071873d84
UI: Fix new UI missing 4 parameters when adding a BareMetal host (#5812)
* fix new UI missing 4 parameters when adding a BareMetal host

* remove test options

* add rule for hosttag with baremetal

* fixes password not provided
2022-01-04 15:13:31 +05:30
Daman Arora 610b2d0dd0
simplify code using optional chaining in compute views (#5635) 2022-01-04 12:23:28 +05:30
Rakesh 2bd1dc1e14
Enable resetting config values to default value (#4230)
* Enable resetting config values to default value

Provide reset button to zone,cluster,domain,account,
primary and secondary storage so that config values
can be reset to default value

* fix ui issue

* Update test/integration/smoke/test_reset_configuration_settings.py

* Update test/integration/smoke/test_reset_configuration_settings.py

Co-authored-by: Rakesh Venkatesh <rakeshv@apache.org>
Co-authored-by: dahn <daan.hoogland@gmail.com>
2022-01-03 21:55:30 +01:00