Commit Graph

5267 Commits

Author SHA1 Message Date
anthony 970bdb3972 CS-15551 : if 'xen.check.hvm' is false, don't check template hvm in allocator 2012-07-12 11:17:13 -07:00
Alena Prokharchyk 7e73ae8e74 VPC: CS-15553 and CS-15549 - more checks during automatic ip assoc to VPC network 2012-07-12 10:04:39 -07:00
Alena Prokharchyk 988831327a VPC: added forVpc parameter to listNetworks api call. If true, list networks not belonging to any vpc 2012-07-12 09:09:09 -07:00
Vijayendra Bhamidipati 05c910ca5c CS-15217: Security: Malicious user is able to get the size of the cloud by enumerating IDs
Description:

	Removing DB IDs from exception messages.
2012-07-11 20:57:09 -07:00
Vijayendra Bhamidipati a0f6cb47f1 CS-15217: Security: Malicious user is able to get the size of the cloud by enumerating IDs
Description:

	Removing DB IDs from exception messages.
2012-07-11 19:52:56 -07:00
Alena Prokharchyk fcd9c0c368 VPC: CS-15550 - fixed listVPCs by cidr 2012-07-11 19:10:48 -07:00
Vijayendra Bhamidipati c5be9daa95 CS-15217: Security: Malicious user is able to get the size of the cloud by enumerating IDs
Description:

	Removing more DB IDs from exception messages,
2012-07-11 18:34:00 -07:00
Edison Su 79bb22c942 CS-15544,fixed 2012-07-11 16:01:07 -07:00
Vijayendra Bhamidipati 1e407f62ad Merge branch '3.0.x' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 3.0.x 2012-07-11 15:52:55 -07:00
Alena Prokharchyk 9fe68fc4a9 VPC: mark gateway with Deleting state when all static routes are gone 2012-07-11 15:48:29 -07:00
Vijayendra Bhamidipati f2c8a59983 CS-15217: Security: Malicious user is able to get the size of the cloud by enumerating IDs
Description:

	More changes to remove DB IDs from exception messages,
2012-07-11 15:46:17 -07:00
Alena Prokharchyk be4185338f VPC: CS-15548 - don't plug the nic for guest network to router when network not in Implemented state 2012-07-11 15:04:34 -07:00
Alena Prokharchyk a0a0113b51 VPC: fixed listStaticRoutes when search by gatewayId 2012-07-11 14:51:19 -07:00
Alena Prokharchyk 1a3a899d59 VPC: fixed logging 2012-07-11 14:51:19 -07:00
Alena Prokharchyk c44af15cd6 VPC: added State to vpc_gateways 2012-07-11 11:53:30 -07:00
Alena Prokharchyk b8b7d06f15 VPC: don't send staticRoutes in Revoke state to the VPC VR 2012-07-11 10:51:20 -07:00
Koushik Das d4d1b1c5a9 Revert "Fix for CS-15345". This issue was caused due some bug in VPC related cleanup code. The bug got fixed as part of 3caffc7855, so this is no longer needed.
This reverts commit a8c1568b37.
2012-07-11 14:19:29 +05:30
Sheng Yang 6582882666 S2S VPN: Add domain and account for VPN
Admin can add VPN connection for others
2012-07-10 18:55:08 -07:00
Alena Prokharchyk a3424cf8a0 VPC: add vm to network - no need to prepare nic when add vm in Stopped state to the network; the nic will be prepared once the vm starts up 2012-07-10 18:02:44 -07:00
Alena Prokharchyk 954b937a42 VPC: unplugNic - release the nic in the DB only after the command is executed succesfully on the backend 2012-07-10 18:02:44 -07:00
Alena Prokharchyk 4e5355b192 VPC: CS-15519 - fixed ipAssoc when only zoneId parameter is passed in to the API call 2012-07-10 15:15:30 -07:00
Sheng Yang 37a0ef7375 CS-15512: Fix delete vpn connection 2012-07-10 14:47:27 -07:00
Alena Prokharchyk 3caffc7855 VPC: CS-15345 - fixed regression in ipRelease happening as a part of cleanupNetworkResources method 2012-07-10 14:33:24 -07:00
Sheng Yang 8212de6f94 CS-15513: Fix group 5 of s2s vpn 2012-07-10 10:31:25 -07:00
Alena Prokharchyk 08b9b3bc5b VPC: CS-15505 - allocate guest nics when new VR starts in VPC 2012-07-09 18:08:44 -07:00
Sheng Yang a87a0619c2 S2S VPN: Add state for vpn connection response 2012-07-09 16:54:40 -07:00
Alena Prokharchyk e8658c9525 VPC: CS-15481: don't allow creating networkACLs for overlapping cidrs/ports 2012-07-09 16:24:44 -07:00
Alena Prokharchyk 9c9b7ee299 CS-15503: don't send Ips in Releasing state as a part of VPC VR start 2012-07-09 15:30:50 -07:00
Alena Prokharchyk fe958786b5 CS-15459: fixed listTags by resourceType 2012-07-09 14:58:11 -07:00
Alena Prokharchyk 1657486f41 VPC: added vpc_id to private_ip_address table to indicate which vpc the ip belongs to 2012-07-09 13:00:03 -07:00
Alena Prokharchyk 03138dee07 listPublicIpAddresses api: don't set associatedWithNetworkId if corresponding field is null in the DB 2012-07-09 10:11:29 -07:00
Alena Prokharchyk 98f8e70ca9 VPC: CS-15486 - prepare public nic as a part of VR deployment 2012-07-09 10:11:29 -07:00
Devdeep Singh 993852c5df CS-15429: Create instance should fail if it results in exceeding volume resource limits for a user/domain-admin.
Additional fix needed if an instance is being created from an ISO. If an instance is created from an iso disk
offering id is not null and only one root volume disk is created. Making a fix to pass the right resource count
for an instance being created from an iso.

Reviewed-By: Rajesh
2012-07-09 17:52:32 +05:30
Alena Prokharchyk 6a9d5a7a0d ResourceTags: respect tag parameter in listTemplates/listIsos commands 2012-07-06 16:37:40 -07:00
Alena Prokharchyk 29aaf4c841 VPC: fixed listNetworkACLs by networkId 2012-07-06 16:33:31 -07:00
Vijayendra Bhamidipati b5cb3ef70e Merge branch '3.0.x' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 3.0.x 2012-07-06 15:58:55 -07:00
Vijayendra Bhamidipati 06a9ef7923 CS-15217: Security: Malicious user is able to get the size of the cloud by enumerating IDs
Description:
	More changes to remove DB IDs from exception messages.
2012-07-06 15:58:12 -07:00
Alena Prokharchyk a9e1c8fa86 VPC: allow adding private gateway to the VPC when the VR is in Stopped state 2012-07-06 15:26:33 -07:00
Sheng Yang 987cf9bc93 CS-15447: Don't enable s2s vpn when provider is disabled 2012-07-06 15:08:26 -07:00
Alena Prokharchyk c49cc27b1c VPC: CS-15485 - dont' create a record for VPC VR private gateway nic in router_network_ref; do it for regular guest networks only 2012-07-06 14:54:25 -07:00
Alena Prokharchyk ed63a14d5e Resource tags: CS-15473 - fixed delete/list by resourceId when UUID is specified as a value 2012-07-06 10:32:24 -07:00
Deepti Dohare 009f2543ed Merge branch '3.0.x' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 3.0.x 2012-07-06 15:13:51 +05:30
Deepti Dohare f659958c24 CS-15430 Create snapshot should fail if creating snapshot results in exceeding snapshot resource limit for domain-admin or user accounts
Reviewed-by: devdeep.singh@citrix.com
Change:
1. Before creating the snapshot, we synchronized checkresourcelimit to allow the users to create the snapshot and increment the resource count.
2. Depending on the failure of snapshot creation/ backup, we are decrementing the resource count.
2012-07-06 15:08:46 +05:30
Alena Prokharchyk f2546dd2bd CS-15459: fixed listTags for userVms 2012-07-05 18:33:23 -07:00
Alena Prokharchyk 447f018b13 VPC: fixed CS-15465 - lb creation for ip not associated with any networks 2012-07-05 18:06:52 -07:00
Alena Prokharchyk f9d512f163 ResourceTags: resourcetags support for Project/Vpc/NetworkACL/StaticRoute 2012-07-05 17:33:20 -07:00
Alena Prokharchyk 7c647223f2 VPC: don't fail when create/remove static route when VPC VR is in Stopped state 2012-07-05 17:26:25 -07:00
Vijayendra Bhamidipati 3a557c2998 Merge branch '3.0.x' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 3.0.x
Conflicts:
	server/src/com/cloud/network/NetworkManagerImpl.java
2012-07-05 17:06:02 -07:00
Vijayendra Bhamidipati f1ec4fddd3 CS-15217: Security: Malicious user is able to get the size of the cloud by enumerating IDs
Description:

	As part of the fix for Bug CS-13127, a new overloaded function,
	addProxyObject() was added to facilitate transparent db id to
	uuid conversions when db IDs were added to exceptions that were
	thrown in the Cloudstack mgmt server code. However, it turns out
	that there are quite many db IDs still in the code that are
	being directly embedded in the String message that is passed
	during exception creation.

	In this commit, we modify the default constructor of
	InvalidParameterValueException so that it takes a second
	argument of type List<IdentityProxy>. This will help developers
	see that there is a second parameter required, and make them
	look into what that parameter is about. Hopefully, this will
	stop db IDs from being embedded into the exception message.

	The parameter can be set to null though, since there are many
	places in the code that don't embed any DB IDs in the exception.

	This is still a WIP, so the older default constructor for
	InvalidParameterValueException has not been removed yet. When
	all instances of throw new InvalidParameterValueException()
	have been moved over to the new default constructor, the old
	one will be removed, else compilation will break. The reason
	for having to do this in batches is that there are way too
	many places in the code that throw exceptions, and they all
	cannot be covered in a single commit without it taking much
	time.

	In following commits, all other exceptions will be changed
	in the same way as InvalidParameterValueException.
2012-07-05 16:48:36 -07:00
Sheng Yang a0a5e25e32 CS-15456: Prohibit creating more than one VPN gateway of VPC 2012-07-05 15:45:21 -07:00