Commit Graph

23828 Commits

Author SHA1 Message Date
Daan Hoogland beaa65f777 try-with-resource to prevent resource leaks
(cherry picked from commit 39f775c381)
2014-06-06 19:28:21 +02:00
sedukull 6c0b43431f CLOUDSTACK-6793: Fixed an invalid Domain Id Issue
Signed-off-by: sedukull <santhosh.edukulla@gmail.com>
(cherry picked from commit 91d054cb00)
2014-06-06 15:54:45 +02:00
Alena Prokharchyk 0b08d5319c Fixed unittest
(cherry picked from commit 96bfa8a73f)
2014-06-06 13:43:56 +02:00
Alena Prokharchyk e6c37ffd41 CLOUDSTACK-6853: Search for non-removed nics only when check if the running vm belongs to a certain network
(cherry picked from commit 03623fe57e)
2014-06-06 13:42:12 +02:00
Alena Prokharchyk 11d8c953e3 CLOUDSTACK-6676: cleanup ip address details on ip disassoc
(cherry picked from commit 66df43572e)
2014-06-06 13:41:23 +02:00
Koushik Das 5fe7eb3357 CLOUDSTACK-6843: [Automation] List listServiceOfferings api fails with NPE
Incorrect parameter name used in query building resulted in a bad sql query.

(cherry picked from commit 025c143ac7)
2014-06-05 15:51:39 +02:00
Rajesh Battala 073928fef5 CLOUDSTACK-6831 [Hyper-V] Improve the logging for VM snapshot failures as it is not supported. Right now it is throwing NPEs
(cherry picked from commit d59cc1ff8f)
2014-06-05 14:36:17 +02:00
Rajesh Battala 1f7d2ee091 CLOUDSTACK-6833 [Hyper-V] Volume snapshot creation returns success even though snapshots are not supported for Hyper-V
(cherry picked from commit 945e879bf2)
2014-06-05 12:21:14 +02:00
Edison Su 91391e6779 CLOUDSTACK-6464: if guest network type is vlan://untagged, and traffic label is used, kvm agent needs to honor traffic label
(cherry picked from commit dfb59cd6cc)
2014-06-04 16:49:43 +02:00
Daan Hoogland c6e00c6825 release branch fix 2014-06-04 15:03:36 +02:00
Edison Su 3f0dcc76ae CLOUDSTACK-5505: if vpc public network with snat enabled, then will triger this issue
(cherry picked from commit 5e80e5d33d)
2014-06-04 09:26:25 +02:00
Nitin Mehta 16afdc0314 CLOUDSTACK-6824: In case there is a failure to delete the soft link of a download url, dont bail out since there can be cases such as destroy ssvm where the soft links do not exist any more. 2014-06-04 09:24:13 +02:00
Rajani Karuturi 004e0cbf61 Fixed ResouceLeak on pstmtCidr in the function Upgrade430to440.moveCidrsToTheirOwnTable as reported by coverity
Fixed another leak which might occur due to outer while loop.

Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-06-03 15:38:16 +02:00
Nitin Mehta 9fd0655adb CLOUDSTACK-6599: Add the column in Java upgrade path since 4.2 already has the extract template/volume columns
Conflicts:
	engine/schema/src/com/cloud/upgrade/dao/Upgrade430to440.java
2014-06-03 10:04:52 +02:00
Nitin Mehta 9286417f05 CLOUDSTACK-6599:
1. Adding the missing Template/Volume URLs expiration functionality
2. Improvement - While deleting the volume during expiration use rm -rf as vmware now contains directoy
3. Improvement - Use standard Answer so that the error gets logged in case deletion of expiration link didnt work fine.
4. Improvement - In case of domain change, expire the old urls

(cherry picked from commit 48ea9e0b5e)
2014-06-03 10:02:06 +02:00
Rajani Karuturi b941b1882c Fixed ResouceLeak on pstmtCidr in the function Upgrade430to440.moveCidrsToTheirOwnTable as reported by coverity
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-06-03 09:21:50 +02:00
Daan Hoogland e249038ee5 update vlan uris 2014-06-02 15:53:18 +02:00
ynojima 426c8741b2 CLOUDSTACK-6816 bugfix: cloudstack-setup-management make /root directory's permission 0777 improperly 2014-05-31 22:32:26 +02:00
Rajani Karuturi c476312a10 FIXED CLOUDSTACK-6669 Support volume resize in usage server 2014-05-30 19:07:25 +02:00
Rajani Karuturi fab339e4cf FIXED CLOUDSTACK-6808 Need to add Database Information to Alter table statements in a commit to schema-430to440.sql 2014-05-30 19:05:28 +02:00
Devdeep Singh 3b642c7578 CLOUDSTACK-6810: Fix storage migration of a vm with volume on local was failing. When a plan
with hostid included was passed to the local storage pool allocator, it returned all the local
storage pools in the cluster, instead of just the local pool on the given host in the plan.
This was happening the search at a host level was happening only for data disk. Fixed this.
Additionally, the query to list the storage pools on a host was failing if the pool did have
tags. Fixed the query too.

CLOUDSTACK-6802: Fix for not being able to attach data disk on local. This issue gets fixed
with the above issue too. The query to list pools on a host was failing if there were no
tags on the storage pool.
2014-05-30 19:03:21 +02:00
rayeesn b4021284b8 CLOUDSTACK-6392: system template always create with name master instead of specific branch
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2014-05-30 09:45:38 +02:00
Hiroki Ohashi 58d4a2400a Allow usaage reporting on removed service offering 2014-05-29 19:13:39 +02:00
Rajani Karuturi 032be54fc6 FIXED CLOUDSTACK-6781 [Automation] integration.smoke.test_portable_publicip.TestPortablePublicIPRange.test_createPortablePublicIPRange failing on 4.4
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2014-05-28 10:11:47 +02:00
Wido den Hollander 93cc3e80d9 CLOUDSTACK-6783: Return a proper LibvirtStoragePool object after creating the pool
In situations where libvirt lost the storage pool the KVM Agent will re-create the
storage pool in libvirt.

This could be then libvirt is restarted for example.

The object returned internally was missing essential information like the sourceDir
aka the Ceph pool, the monitor IPs, cephx information and such.

In this case the first operation on this newly created pool would fail. All operations
afterwards would succeed.
2014-05-27 16:39:49 +02:00
Jayapal c83e90b008 CLOUDSTACK-6328: added license header and removed white space 2014-05-27 11:26:56 +02:00
Anshul Gangwar 92bc68d1f1 CLOUDSTACK-6663: Fixed Hyper-V agent fails to start on some setups. During startup agent tries
to get nic info of 0.0.0.0. To get it, it iterates through all nics and return the last NIC in
the list if it doesn't match with any IP address. In case last NIC doesn't have unicastAddress,
Hyper-V agent will fail to start. We don't need IP address during initialization. It get
initialized with startupcommand later.
2014-05-27 10:44:34 +02:00
Saurav Lahiri d298546ccc CLOUDSTACK-6328: run.sh check if an existing java process is running, before spawining new ones
Signed-off-by: Jayapal <jayapal@apache.org>
2014-05-27 10:42:23 +02:00
Jayapal 9bb35ce11d CLOUDSTACK-6761: Fixed removing proxy arp rule on deleting static nat or PF rule on ip
The proxy-arp add/del is done on firewall rule add/del.
    The proxy-arp rule is deleted only when there is no static nat or dest nat rule is not using the ip.

    When there is static nat or PF and firewall rule
     a. Delete firewall rule. It skips delete proxy-arp because the rule is used by static nat rule.
     b. After deleting fw rule if we disable static nat there is no way to delete proxy-arp rule.

     On VM expunge we are deleting firewall rules first then static nat rules. This caused the stale proxy-arp
     rules.

    With this fix adding/deleting proxy arp rule on static nat/PF rule add/del.
2014-05-27 10:39:13 +02:00
Rajani Karuturi df42ce903d Fixed CLOUDSTACK-6756: usage id is not being returned for an ip in deleted ip range 2014-05-27 10:37:55 +02:00
Rajesh Battala 1fea5d9ea7 Fixed windows line ending issues
Conflicts:
	plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResourceController.cs
	plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs
2014-05-26 14:40:43 +02:00
Daan Hoogland 6f2ee6daac CLOUDSTACK-6485 prevent ipaddress asignment of gateway to gateway-interface on vpc router 2014-05-24 19:45:18 +02:00
Min Chen 3fc781d660 Convert windows line ending to unix forIAMService.java. 2014-05-24 09:40:53 +02:00
Ian Duffy ec28b2bc27 Resolve issue with build script for systemvm hanging due to libssl waiting on a input prompt caused by apt-get update 2014-05-23 10:16:13 +02:00
Min Chen f002e4d161 CLOUDSTACK-6752: IAM command class separation caused ApiDoc warning of
duplicated cmd class for the same api name.
2014-05-23 10:10:12 +02:00
Min Chen f1a586e9be CLOUDSTACK-6745:DomainAdmin is not able to deploy Vm for users in his
domain/subdomain.
2014-05-23 10:07:18 +02:00
Amogh Vasekar b0b71e59e9 CLOUDSTACK-6671: Fixing NPE when a mapping is missing
Adding missing KVM mappings

Testing Done:
Local testing with removing CentOS mapping and launch a VM.

Signed-off-by: Nitin Mehta <nitin.mehta@citrix.com>
2014-05-22 20:38:57 +02:00
ynojima b44266a3f4 bugfix: systemvm template build failed
since newer vboxmanage generates $appliance-$branch-vmware-disk3.vmdk
2014-05-22 10:18:45 +02:00
Min Chen c169ed1f3e CLOUDSTACK-6742: listVolumes - As regularuser , able to list Vms and
volumes of other users.
2014-05-22 10:17:15 +02:00
Kelven Yang 943cbbb7aa CLOUDSTACK-5485: Use edge-triggering in MessageDetector to handle bogus wakeup gracefully. Level triggering plus bogus wakeup can cause a tight loop to spin 2014-05-22 09:54:46 +02:00
Min Chen 6ba541afb7 Disable IAM feature from 4.4 release.
Conflicts:
	test/integration/smoke/test_vm_iam.py
2014-05-21 13:49:11 +02:00
Murali Reddy 850e068a56 CLOUDSTACK-6720: Async job events are not published on event bus
fix ensures publishOnEventBus() is called on submit, update, complete
phase of job procesing
2014-05-20 14:27:03 +02:00
Murali Reddy 019ac691f0 CLOUDSTACK-6721: VolumeApiServiceImpl is sending wrong type for
updateAsyncJobAttachment

fix sends 'Volume' instead of 'volume'
2014-05-20 14:26:13 +02:00
Joris van Lieshout 8326428bb8 A slightly more reliable way of extracting the device name. Thanks John.
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-05-20 12:33:48 +02:00
Joris van Lieshout 1c88ea51e5 releasing dhcp leases on vpcs failes because the network tier of the tennant aren't behinbd eth0. Here we make interface selection dynamic.
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-05-20 12:33:44 +02:00
Jayapal c4ae789e8b CLOUDSTACK-6714: monitor script echo service command is added with quotes 2014-05-20 10:24:18 +02:00
Murali Reddy 5b525aadf3 CLOUDSTACK-6712: NPE in findJobInstanceUuid() in ApiDBUtils 2014-05-20 10:20:20 +02:00
Murali Reddy 840938504b CLOUDSTACK-6672: [Automation] NPE observed while listing system vms
fixing NPE
2014-05-19 11:04:57 +02:00
Prachi Damle 0b99822262 CLOUDSTACK-6476: Basic Zone with Multiple Pods Setup: DHCP server doesnt get deployed in the pod where the VM gets deployed
Changes:
PodId in which the router should get started was not being saved to the DB due to the VO's setter method not following the setXXX format. So when planner loaded the router from DB, it always got podId as null and that would allow planner to deploy the router in any pod. If the router happens to start in a different pod than the user VM, the Vm fails to start since the Dhcp service check fails.

Fixed the VO's setPodId method, that was causing the DB save operation fail.
2014-05-17 11:25:02 +02:00
Murali Reddy 99dc7e009c CLOUDSTACK-6686:NetworkACLItemCidrsDaoImpl uses firewallRuleId instead
of networkAclItemId

fix uses networkAclItemId instead of firewallRuleId
2014-05-16 22:54:20 +02:00