Commit Graph

8004 Commits

Author SHA1 Message Date
Min Chen e8e0449ed4 CLOUDSTACK-6613:IAM: authorizeSecurityGroupIngress fails when SG Name is
passed.
2014-05-08 23:09:12 -07:00
Min Chen b9bdaf9d31 CLOUDSTACK-6598:IAM - listAccount() retrurns "Caller cannot be passed as
NULL to IAM!" when domain deletion is in progress.
2014-05-08 15:19:23 -07:00
Murali Reddy 52257bc418 CLOUDSTACK-6608:OVS distributed firewall: default ACL rule is not
getting applied when a tier in VPC is created.

fix ensures, VpcRoutingPolicyUpdate is send when network rules are
programmed when network tier in VPC is created
2014-05-08 15:50:21 +05:30
Daan Hoogland 0ca013e647 Revert "CLOUDSTACK-6485: private gateway network should not be associated with vpc"
This reverts commit 69add34ad0.
2014-05-08 11:33:37 +02:00
Alena Prokharchyk cadefb1aeb CLOUDSTACK-6601: added "forDisplay" parameter to listLoadBalancerRules API 2014-05-07 17:12:58 -07:00
Alena Prokharchyk 515fa261ba CLOUDSTACK-6596: UUID and display flag update support for LBStickinessPolicy and LBHealthCheckPolicy 2014-05-07 15:38:17 -07:00
Amogh Vasekar 5949e33578 CLOUDSTACK-6358: As a part of supporting dynamic guest OS defined by user, removing the hard-coded dependencies.
This patch is for KVM

1. Local testing on KVM
2. Successfully got up system VMs
3. Successfully created a CentOS VM
4. Snapshots are not supported for KVM

 Signed off by :- Nitin Mehta<nitin.mehta@citrix.com>
2014-05-07 15:17:47 -07:00
Alena Prokharchyk b9284db857 CLOUDSTACK-6595: call expunge method marked with @ActionEvent from expunge thread context. So the action even EXPUNGE.VM is generated when vm is expunged by the thread. 2014-05-07 13:44:26 -07:00
Murali Reddy df65b2e7c4 CLOUDSTACK-6593: Connectivity service capabilites should be matched with
the provider only if at least one capability is specified

Fix avoids the check, and only if the createNetworkOffering
'StrechedL2'Subnet' capability is specified then it should match against
'Connectivity' service provider
2014-05-07 20:03:28 +05:30
Jayapal 99f75db1eb Fixed vpc private gateway backend issues 2014-05-07 16:17:22 +05:30
Devdeep Singh 681e628543 CLOUDSTACK-6510: Fix gson serialization exception in storage migration. Gson couldn't serialize
a map with volume and storagepool objects for logging. Fixed by using volume and storage pool
ids instead of objects in the map.
2014-05-07 14:07:36 +05:30
Prachi Damle eb28f77d1a CLOUDSTACK-6581: IAM - Shared Network -Root Admin user is allowed to deploy VM in a shared network that is scoped for a specific domain/account.
Changes:
- Strict access check in NetworkModel is needed as CS 4.3
- We cannot go through accountMgr since accountMgr is relaxed for rootAdmin
2014-05-06 17:21:05 -07:00
Alena Prokharchyk 8ffb2c1148 CLOUDSTACK-6585: added missing metadata support for LBStickiness/LBHealthcheck policies 2014-05-06 17:04:03 -07:00
Kelven Yang be2b5918e6 CLOUDSTACK-6586: Move EventBus hookup on job framework to ApiServer to decouple job framework away from business logic related hookups. The decoupling is done through internal messaging facility provided inside management server. 2014-05-06 16:48:35 -07:00
Jayapal a708d5c498 CLOUDSTACK-6577: Disable service monitoring in RVR 2014-05-06 19:35:34 +05:30
Jayapal 758f7f2f16 CLOUDSTACK-6578: Fixed issue in delete remote access vpn command 2014-05-06 19:35:34 +05:30
Rajani Karuturi 645516ee78 CLOUDSTACK-6531: stopping the router in case of command failures. Also added alerts for failures.
Signed-off-by: Jayapal <jayapal@apache.org>
2014-05-06 19:35:34 +05:30
wrodrigues 31b3f0a5ce CLOUDSTACK-6139 router vm on local storage 2014-05-06 13:37:24 +02:00
Tanner Danzey 2c4ae0883b CLOUDSTACK-5907, CLOUDSTACK-6396: KVM/RBD & KVM/CLVM volumes mistakenly shown as OVM, disables snapshotting
modified:   server/src/com/cloud/api/ApiDBUtils.java

Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-05-05 15:27:38 +02:00
Mike Tutkowski 0cdcab26f5 CLOUDSTACK-6170 Corrected an issue related to the "Reinstall VM" command and managed storage with VMware 2014-05-02 18:31:14 -06:00
Min Chen ffec3d0284 CLOUDSTACK-6568:API:createVolume: Volume gets created with wrong domain
ID.
2014-05-02 16:29:34 -07:00
Min Chen 03f6188c1c CLOUDSTACK-6569: IAM - Regular user is able to listNetworks of another
user in the same domain , by passing account and domainId.
2014-05-02 14:53:44 -07:00
Alena Prokharchyk 4e7498bc08 LOUDSTACK-6475: cleanupVPC task - removed the transaction wrapping up multiple VPC destroy as the destroy operation has external calls, to prevent long-locked transaction.
Reviewed-by: Prachi Damle
2014-05-02 14:20:27 -07:00
Sam Schmit fe84b674c1 CLOUDSTACK-6472 listUsageRecords: Pull information from removed items as well, fixing NPEs/Null UUIDs with usage API calls. 2014-05-02 16:36:37 -04:00
Sebastien Goasguen f328f6157b Review from pyr https://reviews.apache.org/r/20557/ 2014-05-02 16:35:46 -04:00
Prachi Damle 2e5b529157 CLOUDSTACK-6560: IAM - Admin user is denied permission to create Egress rule for a user's network
Changes:
- CS 4.3 handled Network entity in two ways:
a) Specified "UseNetwork" access and did a strict check w.r.t who can use this network. Regular users and Domain Admin went through the strict check. Root admin got access always.
b) Specified "null" access and that meant admins can access this network for the calling API that passes null access.

- Fixing CS 4.4 IAM to handle this behavior:
a) "UseNetwork" is mapped to "UseEntry" and IAM check will be done only for domain admin and regular users when this access is specified. Root Admin is grated access.
b) If "null" access is specified, root and domain admin both are granted access. Regular users still go through IAM.
2014-05-01 16:07:52 -07:00
Prachi Damle e89c628843 CLOUDSTACK-6558 IAM - Admin user is able to deploy VM in a regular user's Security Group.
Changes:
- Even for SecurityGroup, go through IAM to do permission checks for all type of accounts
2014-05-01 16:07:50 -07:00
Min Chen 6435b261de CLOUDSTACK-6556: Deploy VM failing with error "does
not have permission to access resource Ntwk".
2014-05-01 15:07:36 -07:00
Min Chen f0edfc7ac5 CLOUDSTACK-6535: IAM:MS:API createVMSnapshot doesn't preserve access
rights.
2014-05-01 12:13:59 -07:00
Min Chen 4415aee1e9 CLOUDSTACK-6556: [Automation] Deploy VM failing with error "does not
have permission to access resource Ntwk".
2014-05-01 11:33:41 -07:00
Prachi Damle e14c2ec724 CLOUDSTACK-6517: IAM - Admin is allowed to create PortFowarding rule for a regular user, when admin does not have " UseEntry" permission for IpAddress.
Changes:
- IAM was applying ordering on accessTypes. Thus if an account had Operate, he got USe access as well. So even if IAM schema did not have 'UseEntry" permission for IpAddress, some other 'OperateEntry' permission on IpAddress was letting this operation go through.
- Fixed IAM to NOT do ordering of access types anymore. IAm will perform strict accessType check only.
- This fix is needed so that admin does not get permission to USE resources from other account just becase he has OPERATE access on those resources due to some other APIs.

- However due to this fix, we break backwards compatibilty with CS 4.3.
- CS 4.3 allowed root admin to do the createPF operation for a user by passing in networkId of the user.
- Same was the case for domain admins within their domains
- Why this worked was due to CS 4.3 simply returning true for root admin/domain admin

- So to maintain backwards compatibilty, we are adding the logic to return "true" for root admin and domain admin just like CS 4.3.
- Exception is: For Network, AffinityGroup and Templates, we still call IAM even for root admin/domain admin, since thats what CS 4.3 did. Just for these 3 resource_types, it used to perform access checks even for root admin/domain admin.
2014-04-30 11:58:21 -07:00
Min Chen 412793f9b4 CLOUDSTACK-6513: remove commented code. 2014-04-30 10:03:06 -07:00
Min Chen 3af2f6d141 CLOUDSTACK-6513: templateFilter=shared should not show self-owned
template.
2014-04-29 19:02:57 -07:00
Min Chen 7309146f9f CLOUDSTACK-6513: Optimize code by removing deprecated utility to
QueryManagerImpl as private method just used for listTemplates and
listAffinityGroups to avoid misuse by new list APIs.
2014-04-29 18:33:10 -07:00
Min Chen 0767060b1f CLOUDSTACK-6532:Affinity Groups - As admin user, not able to list all
affinity groups available for regular users by passing account and
domainId paramater. This is to revert IAM way of implementing
listAffinityGroupsCmd, will bring it back when we have implemented real
impersonation.
2014-04-29 18:08:00 -07:00
Rajani Karuturi 08ec6ebdda Fixed CLOUDSTACK-6509 Cannot import multiple LDAP/AD users into a cloudstack account
Conflicts:
	api/src/com/cloud/user/AccountService.java
	plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapCreateAccountCmd.java
	plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java

Signed-off-by: Koushik Das <koushik@apache.org>
2014-04-29 14:38:32 +05:30
Nitin Mehta 3e7ea4e8d9 CLOUDSTACK-6530: Populate the first class entities in the context to be available for publishing more information for the event bus, checking the displayable property etc. 2014-04-28 18:16:13 -07:00
Daan Hoogland 69add34ad0 CLOUDSTACK-6485: private gateway network should not be associated with vpc
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-04-28 14:55:06 +02:00
Sanjay Tripathi 6f7f9996f2 CLOUDSTACK-6480: Creating Service Offering with Implict Dedication planner
fails with message:  "Please specify the pciDevice and vgpuType correctly".
2014-04-28 11:24:41 +05:30
Min Chen a4cb8d1146 CLOUDSTACK-6513: IAM - Templates - When templates are listed with
templatefilter="shared" is used , we see public templates also being
included in the list. This commit reverts listTemplates behavior to 4.3
old logic without using consistent interpretation of list parameters
adopted in new IAM model.
2014-04-25 17:25:16 -07:00
Amogh Vasekar 7694bee83f In 4.3, SSL was turned off by default.
However, for SSVM, the value from configuration server overrides the default in Config.java. Work around is to change in global properties.

Local testing, checking a fresh install has the above property false by default.

Signed-off-by: Nitin Mehta<nitin.mehta@citrix.com>
(cherry picked from commit 05802004e2)
2014-04-25 14:50:37 -07:00
Min Chen 092b4be8d9 CLOUDSTACK-6512:IAM - Not able to list shared networks in the Vm
deployment flow. This commit is to revert
ec5ee761d9 to still use old logic for
listNetworks to keep old behavior instead of new IAM model.
2014-04-25 14:35:38 -07:00
Mike Tutkowski 6dfa742eb8 CLOUDSTACK-6170 Updated logic to more accurately calculate how much space is currently allocated for a managed storage pool 2014-04-25 12:30:38 -06:00
Min Chen 5728ed33e9 CLOUDSTACK-6501:IAM - DomainAdmin - When listVirtualMachines is used
with listall=true and account and domainId , Vms owned by the account
account is not listed.
2014-04-24 18:14:25 -07:00
Nitin Mehta b8a1cbe81a CLOUDSTACK-6499:
Made changes so that uploading custom certificate works for ssvm.
    1. Reboot ssvm only when private key is passed meaning the server cert is passed. This is because while uploading the server cert is the last to be uploaded. And we want to propagate the entire chain once uploading is done.
    2. Change the SecStorageSetupCommand sent to ssvm so that it also carries the root cert apart from having the chain and the server cert and key.
    3. Change ssvm agent code to be able to configure root cert to the java key store.
    4. Change ssvm configure ssl script to insert the chain certs correctly.
    5. Fix order of chain certificates for apache webserver in SSVM
    6. Remove double encoding and decoding for uploadCustomCertificate API from UI and server code respectively, so that API call without UI works fine
    7. Java 1.7 - disable using SNI since copyTemplate doesnt work for SSL.
2014-04-24 17:20:41 -07:00
Alena Prokharchyk 98d9b8fc3f CLOUDSTACK-6436: listResourceDetails - don't return entries set with display=false, by default 2014-04-24 14:32:10 -07:00
Prachi Damle bc3a8378d0 CLOUDSTACK-6458: IAM - When a domain is deleted , the group created for this domian is not removed.
Changes:
- When domain is deleted or is removed during account cleanup, send message to IAM to remove the domain group
2014-04-24 11:39:26 -07:00
Min Chen b6617843d2 CLOUDSTACK-6468:IAM - Templates - Admin user is not allowed to edit
template and set isExtractable() paramater.
2014-04-21 17:53:04 -07:00
Sheng Yang 3578c7137f CLOUDSTACK-6047: Make aggregation command timeout configurable
In case some environments has different performance or we found some commands
would took too long to execute, one global configuration item is introduced to
specify "time out in seconds per one command in aggregation commands".

By default it's 3 seconds. If admin feel it's too long, it can be adjust to as
low as 1 seconds, which runs still well in my machine.
2014-04-18 23:27:12 -07:00
Min Chen 7821da66cc Fix findBugs bug. 2014-04-18 17:35:01 -07:00