Commit Graph

34822 Commits

Author SHA1 Message Date
sureshanaparti 06b5e84182
Removed redundant parsing of VMSnapshot usage record. (#5872) 2022-01-24 18:06:02 +01:00
Abhishek Kumar 68a5e5aa77
ui: show password with success notification (#5889)
Fixes #5888

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-01-24 17:05:07 +05:30
DK101010 f639f56834
fill volume attached field (#5865)
Co-authored-by: DK101010 <dirk.klahre@itelligence.de>
2022-01-20 19:24:26 +05:30
sureshanaparti 4996b800b5
Now correct values are shown when configuring limits for a domain. (#5874) (#5880)
Now correct values are shown when configuring limits for a domain. (#5874) (#5880)

Co-authored-by: JoaoJandre <48719461+JoaoJandre@users.noreply.github.com>
Co-authored-by: Joao <JoaoJandre@gitlab.com>
2022-01-20 14:37:51 +05:30
Wei Zhou f3289fb596
server: fix regular user can create isolated network without sourcenat (#5844)
* server: fix regular user can create isolated network without sourcenat
2022-01-20 14:10:23 +05:30
dahn fb35f46a96
Delete ldap config from UI (#5871)
* add params to delete command

* pass known params

Co-authored-by: Daan Hoogland <dahn@onecht.net>
2022-01-18 10:21:51 +01:00
Hoang Nguyen 0e2c09baca
UI - Fixes Pod, Cluster selected is incorrect on addHost dialog (#5869)
* fix pod selected is incorrect

* fixes fetch cluster with podid empty

* clear clusterid field
2022-01-18 14:35:28 +05:30
Nicolas Vazquez e18ff602f8
Prevent upgrade failures if there are existing annotations permissions (#5846)
* Do not fail if there are existing role permissions for annotations
* Refactor
* Improve refactor
* Do not update if there are existing role permissions for annotations
* Fix exception on upgrade
* Remove extra space from suggestion
* Apply suggestions from code review

Co-authored-by: sureshanaparti <12028987+sureshanaparti@users.noreply.github.com>
2022-01-18 11:20:00 +05:30
Abhishek Kumar f5b0d2f056
ui: fix create user domain, account selection (#5487)
* ui: fix create user domain, account selection

* fetch accounts only after domains

* refresh on saml configure

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-01-17 16:30:29 +05:30
Hoang Nguyen a42ed1fb89
add a setting to config.json that allows users to set theme (#5584) 2022-01-17 11:30:56 +05:30
Abhishek Kumar 59a615cf21
ui: fix deploy vm in basic zone (#5856)
* ui: fix deploy vm in basic zone

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-01-14 16:29:35 +05:30
Hoang Nguyen 619c754903
Clear cache APIs when the switch domain with SAML user (#5855) 2022-01-14 16:20:56 +05:30
Abhishek Kumar c86b98e682
ui: show account configure limits tab for domain-admin (#5858)
Fixes #5676

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-01-13 14:08:02 +01:00
Hoang Nguyen 4746509c82
[UI] Cancel all requests api, async jobs in UI when user logs out (#5663)
* cancel requests in UI when user logs out

* clear notification, message from UI after logout
2022-01-13 17:44:49 +05:30
Hoang Nguyen 001f4213c8
UI - Deploy VM with params from the template, iso, network pages (#5653)
* deploy VM with params from the template, iso, network pages

* remove default-checked not necessary
2022-01-13 16:59:41 +05:30
Abhishek Kumar d78a815442
server: fix update vm with unconstrained offering (#5828)
Fixes #5694

Signed-off-by: Abhishek Kumar <abhishek.kumar@shapeblue.com>
2022-01-13 12:30:12 +05:30
Abhishek Kumar c17ae740f4
ui: fix getDiagnosticsData files field (#5853)
Fixes #5707

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-01-12 13:52:01 +05:30
Wei Zhou 216bea1978
ipv6: disable IPv6-only shared network with VR (#5810)
* ipv6: disable IPv6-only shared network with VR

* Update #5810: import org.apache.commons.lang3.StringUtils
* Update #5810: do not import org.apache.commons.lang3.StringUtils
* Update server/src/main/java/com/cloud/network/NetworkServiceImpl.java
* Update engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java

Co-authored-by: Daniel Augusto Veronezi Salvador <38945620+GutoVeronezi@users.noreply.github.com>
2022-01-12 13:33:35 +05:30
Abhishek Kumar 223bc11d2a
ui: fix paging in enable static NAT form (#5849)
Fixes #5715

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-01-11 22:31:02 +05:30
Gabriel Beims Bräscher 2e2d328cde
Add toggle button on the UI for list including elements in projects. (#5790)
* Allow to use projectid=-1 and list all resources (e.g. VMs) regardless of their project.
2022-01-11 21:30:30 +05:30
Abhishek Kumar c08592cad8
ui: update vm haenable only for supported vms (#5847)
For VMs which have service offering that does not allow HA, haenable option will be not shown in the UpdateVM UI form.

Fixes #5743

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-01-11 14:55:11 +05:30
Wei Zhou 9293f5bd27
server: fix enable/disable static nat if userdata is not supported (#5839)
* server: fix enable/disable static nat if userdata is not supported

* Update #5839: rename applyUserData to applyUserDataIfNeeded

* Update server/src/main/java/com/cloud/network/rules/RulesManagerImpl.java

Co-authored-by: Daniel Augusto Veronezi Salvador <38945620+GutoVeronezi@users.noreply.github.com>
2022-01-11 12:22:59 +05:30
dahn 7ea2cbd889
Storage pool absent (#5841)
* simple null check

Co-authored-by: Daan Hoogland <dahn@onecht.net>
Co-authored-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Co-authored-by: Daniel Augusto Veronezi Salvador <38945620+GutoVeronezi@users.noreply.github.com>
2022-01-11 12:18:55 +05:30
Wei Zhou fadd74aaca
network: fix vm can be deployed on L2 network of other accounts (#5784)
* Update #5769: fix domain admin can deploy vm on L2 network of other users

* test: fix test_storage_policy.py

* Update #5784: revert part of changes in #2420
2022-01-11 12:16:00 +05:30
dahn 028d338aaa
remove VmWorkJob after adding a nic to a vm (#5658)
Co-authored-by: Daan Hoogland <dahn@onecht.net>
Co-authored-by: Suresh Kumar Anaparti <suresh.anaparti@shapeblue.com>
Co-authored-by: Wei Zhou <weizhou@apache.org>
2022-01-10 16:31:50 +01:00
Hoang Nguyen 4916f3c90d
UI - Fix Locked "Override Root Disk Size" switch (#5843)
* Fix Locked "Override Root Disk Size" switch

* fixes ut
2022-01-10 19:04:46 +05:30
Hoang Nguyen 0f926b5d68
UI: Add s3 provider option to create secondary storage (#5726)
* add s3 provider option to create secondary storage

* fixes label name

* add storagepolicy for swift provider
2022-01-10 19:01:53 +05:30
Nicolas Vazquez 946f9156e5
vmware: Persist empty values instead of null (#5748)
This PR allows deploying VMware appliances missing default values on some properties
Fixes: #5747
2022-01-08 08:58:46 +05:30
slavkap 48006de3e3
kvm: Set RAW format to RBD DATADISK (#5801)
While deploying a VM with data disk on Ceph the volume format was in
QCOW2.

Fixes #5531
2022-01-08 08:54:21 +05:30
Abhishek Kumar feb4343abe
ui: fix create network/vpc offering form (#5840)
* ui: fix create network/vpc offering form

Fixes #5838

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* fix inlinemode

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-01-08 08:41:58 +05:30
Wei Zhou 84b9b61b9b
api: fix typo in Volume Destroy state - volume can be recovered (#5833)
* api: fix type Destroy volume can be recovered

* Update api/src/main/java/com/cloud/storage/Volume.java

Co-authored-by: dahn <daan.hoogland@gmail.com>
2022-01-07 13:19:26 +05:30
Wei Zhou 6d35b520d3
server: fix vm can be recovered by other accounts (#5822) 2022-01-07 13:13:48 +05:30
Hoang Nguyen 3cbde8cd6c
UI - Hide shrink disk option on XCP-NG/Xenserver (#5829)
* hide shrink disk option on XCP-NG/Xenserver
2022-01-06 17:41:54 +05:30
dahn 2774bc156f
use physical size instead of virtual size for migration. (#5750)
* Use Physical size to evaluate if migration is possible

* Improve logging and consider files skipped as failure in complete migration

* skipped can't be negative

* remove useless method

* group multidisk templates for secstor migration

* use enum

* Update engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/DataMigrationUtility.java

Co-authored-by: sureshanaparti <12028987+sureshanaparti@users.noreply.github.com>
Co-authored-by: Pearl Dsilva <pearl1594@gmail.com>
Co-authored-by: Daan Hoogland <dahn@onecht.net>
Co-authored-by: Pearl d'Silva <pearl.dsilva@shapeblue.com>
2022-01-06 17:18:50 +05:30
Abhishek Kumar 51f69f7134
server: do not return inaccessible entity details to normal users (#5827)
Fixes #5534

As pre 3.x APIs allow using internal DB IDs, even normal users can use internal IDs.
This fix removes additional information in error message when the caller doesn't have access to the resource.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-01-06 16:42:57 +05:30
Hoang Nguyen f071873d84
UI: Fix new UI missing 4 parameters when adding a BareMetal host (#5812)
* fix new UI missing 4 parameters when adding a BareMetal host

* remove test options

* add rule for hosttag with baremetal

* fixes password not provided
2022-01-04 15:13:31 +05:30
Rakesh 2bd1dc1e14
Enable resetting config values to default value (#4230)
* Enable resetting config values to default value

Provide reset button to zone,cluster,domain,account,
primary and secondary storage so that config values
can be reset to default value

* fix ui issue

* Update test/integration/smoke/test_reset_configuration_settings.py

* Update test/integration/smoke/test_reset_configuration_settings.py

Co-authored-by: Rakesh Venkatesh <rakeshv@apache.org>
Co-authored-by: dahn <daan.hoogland@gmail.com>
2022-01-03 21:55:30 +01:00
dahn e06a66ba14
ldap: truststore per domain (#5816)
Co-authored-by: Daan Hoogland <dahn@onecht.net>
2022-01-03 21:01:51 +05:30
Hoang Nguyen 4392cc4d48
ui: refactoring $notification according to the old version (#5819)
Related to PR #5549 changed the notification from $notification to $showNotification. This PR aims to change it back to the way it was for easier use while keeping the delete all button.
2022-01-03 20:59:49 +05:30
dahn 5f93bc8948
assume a property is one when it isn't a number (#5647)
Co-authored-by: Daan Hoogland <dahn@onecht.net>
2022-01-03 12:53:18 +05:30
Wei Zhou 4ba2ad5397
test: fix component test test_configdrive.py (#5528)
* test: fix test_configdrive.py and move it to smoke test

(sleep 30s as vm crashes after migration in ubuntu 20.04)

* Update test/integration/smoke/test_configdrive.py

Co-authored-by: dahn <daan.hoogland@gmail.com>

* test: fix test_configdrive.py

* Update #5528: move back to component test

Co-authored-by: dahn <daan.hoogland@gmail.com>
2021-12-30 16:31:31 +05:30
Hoang Nguyen 10bda8549b
ui: auto-prefill edit tariff label (#5714) 2021-12-30 16:27:56 +05:30
Abhishek Kumar d7a9873053
ui: fix add network offering for vpc (#5809)
* ui: fix add network offering for vpc

Fixes issues with form related to supported services provider and router service offering when offering to be created for VPC.

Fixes #5807

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* fix issues getting with making select element update on options change (loop infinity) (#72)

* fixes

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

Co-authored-by: Hoang Nguyen <hoangnm@unitech.vn>
2021-12-30 16:26:54 +05:30
Hoang Nguyen eb04a46541
ui: Add clear all notification button (#5549)
* add clear all notification button

* change position set count notify

* get notification count

* set label transliteration

* add margin for notification

* change position of clear notification button
2021-12-30 16:24:17 +05:30
Hoang Nguyen 5eccbc9521
ui: Add footer text option for login screen (#5628)
* add footer text option for login screen

* using single key for policy

* set empty for default policy text

* rename footer text key

* rename the footer text property name

* change position avoid breaking with docHelp

* change position of properties
2021-12-30 16:21:40 +05:30
Wei Zhou 8952cd5955
kvm: add hosts using cloudstack ssh private key (ccc21 hackathon) (#5684)
This PR provides the option to add kvm hosts with empty or wrong password.
To support this, the cloudstack ssh public key needs to be added in the ~/.ssh/authorized_keys on host.

Feature work:

1. get cloudstack public key from management server (/var/lib/cloudstack/management/.ssh/id_rsa.pub)

![image](https://user-images.githubusercontent.com/57355700/141449653-85f644b5-c32e-44ca-9c6b-77570262c046.png)


2. add the key to ~/.ssh/authorized_keys on kvm hosts

![image](https://user-images.githubusercontent.com/57355700/141449722-e906eea5-74fd-4f81-a4d3-41563beeb79c.png)

3. add kvm host with empty password

<img src="https://user-images.githubusercontent.com/57355700/141449865-6ffee1f0-b0d7-4ea4-b11a-32df42e2fe91.png" height="50%" width="50%">

Tested as:
1. add host, with correct password,  works as expected.
2. put host to maitenance, stop cloudstack-agent, cancel maintenance, remove the host. all work.
3. add host, with empty password (ssh public key is added to  ~/.ssh/authorized_keys),   works as expected.
4. put host to maitenance, stop cloudstack-agent, cancel maintenance. all work as expected.
2021-12-30 16:20:04 +05:30
Wei Zhou 9798fa08b5
kvm: support qemu-system-x86>=5.2 (#5755) 2021-12-30 16:16:08 +05:30
Nicolas Vazquez c0ddda361a
[VMware] Fix service offerings listing on appliances deployment options (#5752)
* Fix list service offerings for VMware deployment options

* UI fix to allow selecting offerings
2021-12-30 16:13:41 +05:30
Marcus Sorensen dcdcd09058
Randomize managed volume copy host (#5789)
* Randomize managed volume copy host

* Managed volume copy was always returning first host that could see storage pools

* Fix null value in logging for ScaleIOPrimaryDataStoreDriver due to if/else logic error

Signed-off-by: Marcus Sorensen <mls@apple.com>

* Use String.format for ScaleIO debug message

Signed-off-by: Marcus Sorensen <mls@apple.com>

* Update debug message for ScaleIO copy methods

Signed-off-by: Marcus Sorensen <mls@apple.com>

Co-authored-by: Marcus Sorensen <mls@apple.com>
2021-12-30 16:11:00 +05:30
Gabriel Beims Bräscher 62089767f6
Fix UI issue 5777 Root disk size is not shown as 'Disk Size' on VM deployment. (#5796)
In the UI, when selecting a service offering that has a root disk enforced, stills show the root disk size of the template (or the custom size gave by the user). This PR fixes this issue, that thas been reported in #5777.
Fixes: #5777
2021-12-30 15:21:11 +05:30