Sheng Yang
260422de07
CS-15704: Fix wrong domain id setting of non-root domain
2012-07-27 15:31:52 -07:00
Vijayendra Bhamidipati
b6e70f2281
CS-15217: Security: Malicious user is able to get the size of the cloud by enumerating IDs
...
Description:
New 3.0.x merge included a new instance of InvalidParameterValue exception
being raised. Fixing it.
2012-07-27 15:15:32 -07:00
Vijayendra Bhamidipati
b8211728e1
Merge branch '3.0.x' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 3.0.x
2012-07-27 15:11:14 -07:00
Vijayendra Bhamidipati
62c11df4e9
CS-15217: Security: Malicious user is able to get the size of the cloud by enumerating IDs
...
Description:
1) With this commit in the series for this bug,
removed all occurrances of db IDs being passed
when raising InvalidParameterValueException.
2) Renamed HyervisorTemplateAdapter.java to
HypervisorTemplateAdapter.java.
2012-07-27 15:08:48 -07:00
Alena Prokharchyk
c0b58130d3
VPC: CS-15725 - don't allow regular offering upgrade to the offering that can be used inside vpc only
2012-07-27 13:32:00 -07:00
Alena Prokharchyk
78a00c03e1
VPC: replaced vmTo object with vmName parameter in plug/unplugNic commands
2012-07-27 13:32:00 -07:00
Vijay
57b1783764
CS-15729. AutoScale. Default counter names are corrected to valid values without special characters
2012-07-27 21:00:03 +05:30
Sheng Yang
c971d3c2a6
CS-15697: Fix wrong class for finalizeStop()
2012-07-26 16:04:10 -07:00
Vijayendra Bhamidipati
1e9c5c54df
Merge branch '3.0.x' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 3.0.x
2012-07-26 18:27:55 -04:00
Alena Prokharchyk
ecd8450ab6
Added missing action events for enable/disable static nat
2012-07-26 15:26:53 -07:00
Vijayendra Bhamidipati
06e974ef92
Merge branch '3.0.x' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 3.0.x
2012-07-26 18:06:06 -04:00
Vijayendra Bhamidipati
2e18ffec20
CS-15217: Security: Malicious user is able to get the size of the cloud by enumerating IDs
...
Description:
Removing more DB IDs from exception messages.
2012-07-26 18:05:43 -04:00
Alena Prokharchyk
5eb87e99ff
VPC: added global configuration for limiting number of networks per vpc (vpc.max.networks)
2012-07-26 14:05:56 -07:00
prachi
5f433ff7bc
Merge branch '3.0.x' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 3.0.x
2012-07-26 11:37:36 -07:00
prachi
6fe394231b
CS-15299: Typo in use.external.dns setting description
...
Changes:
- fixed the typo in the setting description
2012-07-26 11:37:04 -07:00
Alena Prokharchyk
20b6b36302
VPC:
...
1) CS-15692 - ipAddress is always null for NetworkACL rule
2) CS-15699 - redundant router = true when provider is VirtualRouter
3) CS-15701 - fixed error message
2012-07-26 10:15:35 -07:00
Sheng Yang
cc35ea2be3
S2S VPN: CS-15650: Add connection status update to s2s vpn
2012-07-25 22:00:40 -07:00
Sheng Yang
517c9af7c9
S2S VPN: Add list function for normal users
2012-07-25 18:59:49 -07:00
Vijayendra Bhamidipati
3b13c47e38
Merge branch '3.0.x' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 3.0.x
2012-07-25 18:43:21 -04:00
Vijayendra Bhamidipati
a0fa53ecd8
CS-15217: Security: Malicious user is able to get the size of the cloud by enumerating IDs
...
Description:
Removing more DB IDs from exception messages.
2012-07-25 18:39:48 -04:00
Alena Prokharchyk
8cfc3c4775
Bug 14875: fixed listNetworks by domainId/aclType=Domain
2012-07-25 14:48:08 -07:00
Alena Prokharchyk
f6041de179
VPC: added vif info to ipassoc command
2012-07-25 13:03:40 -07:00
Vijay
d4e43846f8
AutoScale. Adding default counters
2012-07-25 18:17:32 +05:30
Koushik Das
266b8e5ee8
Support for local data disk (part 1)
...
Following changes are made:
- Create disk offering API now takes an extra parameter to denote storage type (local or shared). This is similar to storage type in service offering.
- Create/delete of data volume on local storage
- Attach/detach for local data volumes. Re-attach is allowed as long as vm host and data volume storage pool host is same.
- Migration of VM instance is not supported if it uses local root or data volumes.
- Migrate is not supported for local volumes.
Reviewed-by: Abhi
2012-07-25 15:16:42 +05:30
Sheng Yang
c4dff1e204
CS-15670: Allow normal users to configure S2S VPN
2012-07-24 19:44:27 -07:00
Alena Prokharchyk
2c24b7446e
VPC: CS-15681 - execute VPC related methods only when router is a vpc router
2012-07-24 16:06:47 -07:00
Sheng Yang
793715d8f2
Fix DB upgrade test
...
Now you can run:
ant test -Dtest=Upgrade304to305Test
For 3.0.4 to 3.0.5 DB upgrade sanity test.
2012-07-24 14:12:10 -07:00
Sheng Yang
d88f8abed4
S2S VPN: Fix build
2012-07-24 13:24:22 -07:00
Sheng Yang
eeaee286a1
S2S VPN: Fix incorrect conn returned by resetVpnConnection cmd
2012-07-24 13:02:29 -07:00
Sheng Yang
f1dbdedfa9
S2S VPN: Add name field for customer gateway
...
Easier for user to identify the correct gateway
2012-07-24 13:02:24 -07:00
Alena Prokharchyk
f68a1a7d44
listPublicIpAddresses: when do join with nics table, count only non-removed nics
2012-07-24 12:39:26 -07:00
Sheng Yang
9da29e7f77
CS-15676: Fix NPE when stop non-VPC router
2012-07-24 11:42:36 -07:00
Alena Prokharchyk
87e1359826
Fixed unittest
2012-07-24 10:23:46 -07:00
Vijay
04b51bb6ba
AutoScale.
...
NetScaler changes for deleteAutoScaleVmGroup and min/max member
policies - Tested
Introducing apikey/sharedsecret/csurl empty checks as well
Introducing the autoscale change sheet that got deleted during the merge
2012-07-24 19:25:22 +05:30
Vijay
62082b0de6
Resetting unwanted files similar to 3.0.x
2012-07-24 10:45:25 +05:30
Vijay
629053d2f1
AutoScale. Catching an odd case to get rid of null pointer exception
2012-07-24 10:02:45 +05:30
Deepak Garg
edcd8e7394
Checking success in deleteCounter
2012-07-24 10:02:39 +05:30
Vijay
30cb0e74d2
AutoScale. ALenas Final Review Comments. 2nd Cut. Remove csurl from profile,
2012-07-24 10:02:29 +05:30
Vijay
f9bcf3186c
AutoScale. Enabling AutoScale to go to the Resource.
...
Tested the reachability for Basic Network.
Fixing compile error introduced due to a89919ce2ffd9a0a99f1810aeaa0488b0805f665
2012-07-24 10:01:22 +05:30
Deepak Garg
a96df19b68
Improved logging in AutoScale APIs
2012-07-24 10:01:19 +05:30
Deepak Garg
349ab92ffc
Added more logging to AutoScale Vm Group
2012-07-24 10:01:13 +05:30
Deepak Garg
05e46cfd31
Added more params to UpdateAutoScaleVmProfileCmd
2012-07-24 10:00:42 +05:30
Vijay
09adc78196
AutoScale. Removed checks for no parameters in update command.
2012-07-24 10:00:40 +05:30
Vijay
deb70ad200
AutoScale. Enabled Update commands with UnitTesting. Introduced and tested capability for NetScaler
2012-07-24 10:00:37 +05:30
Deepak Garg
a4a15aa737
Work around for CS-15556
2012-07-24 10:00:26 +05:30
Vijay
df84f88296
CS-15593: Conditions are checked in database before used
2012-07-24 10:00:03 +05:30
Vijay
c755172a3a
CS-15590 : Conditions are corrected to be similar to other search wrapper usecases
2012-07-24 10:00:00 +05:30
Vijay
c826fa295b
AutoScale. AutoScaleVmGroup Response corrected. Responses tested for list commands of autoscale entities
2012-07-24 09:59:57 +05:30
Deepak Garg
3bee3fd4fd
Added CSurl in the vm profile response
2012-07-24 09:59:44 +05:30
Vijay
19a2f4ab66
AutoScale. Introducing caller in getEntityInDatabase
2012-07-24 09:59:12 +05:30
Deepak Garg
8bbc8ee0ec
Added csurl as param in CreateAutoScaleVmProfileCmd
2012-07-24 09:58:56 +05:30
Vijay
fa9282add1
AutoScale. Alena's final review comments. 1st Cut.
2012-07-24 09:58:17 +05:30
Deepak Garg
1c960c0b34
Fixed event type in deleteCondition
2012-07-24 09:57:30 +05:30
Deepak Garg
10a58fdef2
CS-15592 Fixed the quiettime parameter check
2012-07-24 09:57:28 +05:30
Deepak Garg
4ee6ed6afb
CS-15589 Fixed the invalid counter exception
2012-07-24 09:57:26 +05:30
Vijay
998f9aa051
AutoScale. Unit Test Add/Delete/List of all AutoScale entities.
2012-07-24 09:57:24 +05:30
Vijay
a6a206d3fc
AutoScale. Bringing in update commands and enable/disable. Not Tested.
2012-07-24 09:57:21 +05:30
Vijay
21e13657b4
AutoScale.
...
All API commands with separate service layer for AutoScale.
Not tested.
2012-07-24 09:57:10 +05:30
Sheng Yang
4dddd76e95
CS-15534: Mark VPN connection as Disconnected when rebootRouter
2012-07-23 21:07:49 -07:00
Sheng Yang
6e571d28df
S2S VPN: Add check for router status before apply vpn
2012-07-23 19:53:06 -07:00
Alena Prokharchyk
22826032b4
VPC: CS-15668 - IpAssoc: unplug the nics before pluggning new ones
2012-07-23 16:18:49 -07:00
Alena Prokharchyk
a867e7e5a8
CS-15077: fixed listPublicIpAddresses in basic zone
2012-07-23 11:16:28 -07:00
Alena Prokharchyk
9899df816c
Resource tags: CS-15661 - don't accept NULL or empty key value when create resource tag
2012-07-23 10:50:21 -07:00
Alena Prokharchyk
cec0ea54ec
Resource tags: CS-15647 - delete resource tags when SG is expunged
2012-07-23 10:32:56 -07:00
Alena Prokharchyk
49199d0022
VPC: when VPC router gets destroyed and recreated, plug public nic for each Vlan where VPC public ips belong to
2012-07-20 16:28:43 -07:00
prachi
2a97fdae64
Merge branch '3.0.x' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 3.0.x
2012-07-20 15:39:43 -07:00
prachi
c581d8b820
CS-15586: Public Vlan for an account fails in case of multiple Physical networks
...
Changes:
- Since Now a zone can have multiple physical networks, we need to find the physical network Id from the networkOffering's tag and zoneId and trafficType when we create a guest network
2012-07-20 15:39:26 -07:00
Alena Prokharchyk
04ed3884d0
CS-15622: always get router info from the DB
2012-07-20 14:35:39 -07:00
Alena Prokharchyk
aa6ee7c506
VPC: one more fix for multiple public nic case for the VPC VR
2012-07-20 14:08:00 -07:00
Alena Prokharchyk
c0fb2fece9
VPC: CS-15638: Plug nic for the public ip address if the ip address from the diff vlan range than sourceNat ip
2012-07-20 13:25:09 -07:00
Prasanna Santhanam
135a999db8
CS-15560 : Improve HVM logging of hosts
...
When a host is not considered for deployment because it is disabled HVM,
then call that out in the logs for debugging.
2012-07-20 17:28:36 +05:30
saksham
4f83043403
CS-15331.Removing obsolete JUnit test file : SearchCriteria2Test
2012-07-20 12:05:04 +05:30
saksham
84a20faada
Disabling the calls made to cleanup.sql from Junit upgrade tests
2012-07-20 12:05:04 +05:30
Alena Prokharchyk
f243765758
304-305 DB upgrade: upgrade for VPC and resourceTags feature
2012-07-19 16:54:00 -07:00
Alena Prokharchyk
ba0c448174
Added upgrade path from 3.0.4 to 3.0.5 (Burbank) release
2012-07-19 16:54:00 -07:00
Alena Prokharchyk
6224423ecc
More logging to the VirtualRouter manager
2012-07-19 14:02:04 -07:00
prachi
317e0df566
CS-15606 Dogfood Setup: Virtual Router (DHCP Server) fails to create in Pods
...
Reviewed-By: Alena
Changes:
- Correct the virtual router entries from table' virtual_router_providers' that wrongly refer to SecurityGroupProvider instead of VirtualRouter provider in physical_network_service_providers table
- For such entries, we update them to point to the VirtualRouter provider in physical_network_service_providers table
2012-07-18 16:54:47 -07:00
prachi
302485e8ef
CS-15578 (spinned off from 15495) Upgrade from 2.2.14 -> 3.0.3-> 3.04 failed with exception"mysql.jdbc.exceptions.jdbc4.MySQLIntegrityConstraintViolationException
...
reviewed-by: kishan
- Add physical network to the removed data_center as well and mark it as removed, to avoid foreign constraint failures
- Since rest all stuff related to multiple physcial networks is done based on networks having non-null removed field, nothing will apply to this zone.
2012-07-18 16:54:22 -07:00
prachi
f06d73a6f3
CS-15407 [2.2.14 to 3.0.4 upgrade] After upgrade VLAN allocation doesn't happen properly for multiple physical networks
...
Reviewed-By: Alena
Changes:
- Upgrade insturctions updated to secify 'isolated' networks
2012-07-18 16:53:42 -07:00
prachi
58dab4b62e
CS-15476: Multiple physical networks are created with same label (to same NIC) after upgrade
...
Reviewed-By: Alena
Changes:
- Error out upgrade when we find there will be multiple physical networks with same traffic label
2012-07-18 16:53:20 -07:00
prachi
30737b8cdd
CS-15407 [2.2.14 to 3.0.4 upgrade] After upgrade VLAN allocation doesn't happen properly for multiple physical networks
...
Reviewed-By: Alena
- Update instructions for setups with multiple physical networks and guest vnets
- if there are such setups upgraded to 3.0.3 and face problems starting VMs, then they need to roll back to 2.2.14 and carry out the instructions and then upgrade to 3.0.4
2012-07-18 16:52:39 -07:00
prachi
2e7ec3798d
CS-15516 com.cloud.utils.exception.CloudRuntimeException: Exception while adding PhysicalNetworks : Caused by: java.sql.SQLException: No value specified for parameter 1
...
Reviewed-By: Prachi
- Same bug in 303 to 304.
2012-07-18 16:49:57 -07:00
prachi
a7ae4b9988
CS 15516: com.cloud.utils.exception.CloudRuntimeException: Exception while adding PhysicalNetworks : Caused by: java.sql.SQLException: No value specified for parameter 1
...
Reviewed-by: Prachi
Changes:
Missed on setting the zoneId parameter.
2012-07-18 16:49:28 -07:00
prachi
ff8acfa50a
CS-15404 [2.2.14 to 3.0.4 upgrade] After upgrade cloud.physical_network.id starts from 200 which is not the case with fresh installation
...
Reviewed-By: Alena
Changes:
- We need to set the id while creating physical network entry.
2012-07-18 16:49:05 -07:00
prachi
5e03887430
CS-15406 [2.2.14 to 3.0.4 upgrade] Hosts going to Alert state after upgrade as it cann't find any name-label set to "cloud-private"
...
Reviewed-By: Alena
Changes:
- Looks like we cannot default to 'cloud-private' label.
- If it is not set, CS figures out the default management interface and usus its name.
- We will use the global config variable as the label. if it is null, the label on the physical network will be null.
2012-07-18 16:48:19 -07:00
prachi
bef9670476
CS-15407 [2.2.14 to 3.0.4 upgrade] After upgrade VLAN allocation doesn't happen properly for multiple physical networks
...
Reviewed-by: Alena
Changes:
- If a 2.2.14 setup uses guest vnet and has multiple network tags, we cannot upgrade this to 3.0.x since on upgrade we dont know how to assign the vnets to physical networks
- So we error out and provide instructions
- If an already upgraded 3.0.3 setup has this some guest networks using vnet but the assignment of vnet to physical network is wrong, upgrade to 3.04 will detect it and error out with further steps
2012-07-18 16:45:30 -07:00
prachi
b818e6f68f
CS-15450: vmware:upgrade fails from 2.2.14GA to 3.04
...
CS-15414 [upgrde from 2.2.14 to 3.0.4] Need to decrypt xen.guest.network.device value before setting the traffic label after upgrade.
Reviewed-by: Alena
- This uncovered a generic case where only 1 network tag is used and other few untagged networks.
- Upgrdae 303 to 304, should create a physical network for the untagged networks.
- Earlier we were doing this only if the 303 db has multiple physical networks. But in this case the 303 db will have just 1 physcial network (created due to the single tag used on 2.2.14).
- So we need to create the extra physical network for the untagged networks irrespective of the number of physical networks present in 303 db.
- This commit also take care of the decryption of the xen.guest.network.device value
2012-07-18 16:43:21 -07:00
prachi
64ce2eac32
CS-15396: [2.2.14 to 3.0.4 upgrade] data_center table doesn't contain "uuid" after upgrade
...
Reviewed-By: Sheng Yang
Changes:
- Add uuid to data_center while upgrading from 2.2.14 to 3.0x.
- For previous setups that have already been updated, correctly add the uuid in 304 upgrade
2012-07-18 16:39:13 -07:00
prachi
709f1b9c78
CS-15381: Upgrade from 3.0.3 to 3.0.4 is failing
...
CS-15382: Hosts going to Alert state if there were destroyed networks with non-existent tags prior to upgrade
Reviewed-By: Alena P.
Changes:
- If 2.2.14, create the SG provider by looking at is_security_group_enabled flag
- if 3.0.3, create the SG provider by looking at the ntwk_service_map.
2012-07-18 16:34:13 -07:00
prachi
a8fd70fe0a
Bug 14773 - VM's are unable to start after upgrade from 2.2.14 to 3.0.3
...
Reviewed-By: Alena P.
Changes:
- Added upgrade path to 304. This would check the missing portions of the previous upgrades and try to correct.
- This will check if the setup has multiple physical networks with Guest traffic type. If yes then:
- Check if the previous upgrade has left behind any guest networks that were untagged in 2.2.14. For such networks, add a new physical network
- Check if the multiple physical network has tags. If no add tag and clone the network offerings for the networks on this physical network and add this tag to them
- Also clone the network offering service map.
- Thus this creates copies of offerings for each physical network.
2012-07-18 16:32:23 -07:00
Alena Prokharchyk
f778f0f174
Fixed update endpointe.url global config var
2012-07-18 15:45:42 -07:00
Alena Prokharchyk
9bebe245ca
More logging on nic release
2012-07-18 10:59:07 -07:00
Sheng Yang
3dca5a8689
CS-15615: Fix Site2SiteVpnService injection
2012-07-18 09:58:14 -07:00
Sheng Yang
d2643c0fdf
CS-15574: Delete VPN gateway and connection when deleting VPC
2012-07-17 18:06:15 -07:00
Alena Prokharchyk
14c3ef17ad
VPC: added one more default network offering for VPC - the one not having LB service
2012-07-17 17:47:02 -07:00
Sheng Yang
c36de737db
S2S VPN: Use source NAT ip address for VPN gateway
2012-07-17 17:22:00 -07:00
Alena Prokharchyk
3994d8427c
VPC: fixed listPublicIpAddresses for the addresses with NULL network_id
2012-07-17 17:10:08 -07:00
Alena Prokharchyk
97a142c0fc
Fixed unittest
2012-07-17 15:46:44 -07:00
Alena Prokharchyk
0fdf1a1d8a
Resource tags: CS-15591 - delete tags for template/iso when corresponding vo object is removed
2012-07-16 14:36:47 -07:00
Alena Prokharchyk
d7214db5ae
VPC: CS-15583 - hostName for the vm should be unique inside the network domain
2012-07-16 13:40:28 -07:00
Alena Prokharchyk
0575b83ec0
VPC: CS-15598 - update ipVO object after getting system ip as a part of elastic LB
2012-07-16 11:26:16 -07:00
anthony
2557315a5a
VPC: CS-15580 - don't allow gateway for VPC guest network to be equal to the cidr broadcast ip
2012-07-13 18:20:30 -07:00
Alena Prokharchyk
b145029718
VPC: CS-15580 - don't allow gateway for VPC guest network to be equal to the cidr subnet
2012-07-13 17:06:10 -07:00
Alena Prokharchyk
c17bca4088
CS-15579 - perform check when account/domainId is passed to list call by the regular user
2012-07-13 15:57:33 -07:00
Vijayendra Bhamidipati
695db226af
Merge branch '3.0.x' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 3.0.x
2012-07-13 13:44:33 -07:00
Vijayendra Bhamidipati
b14cebbe68
CS-15556: [NS Autoscale] System VMs not coming up in Basic zone EIP ELB offering
...
Description:
Removing a reference to user_vm table when populating a system VM
id in an exception. Undoing change committed earlier as part of
Bug CS-15217.
2012-07-13 13:44:10 -07:00
Alena Prokharchyk
f9552f4707
VPC: CS-15562 - get info about VR's guest networks from nics table
2012-07-13 13:06:36 -07:00
Alena Prokharchyk
34066935c0
VPC: CS-15564 - when send the rules to the backend, form the list of rules after the rules were marked with Revoke state
2012-07-13 12:48:51 -07:00
Alena Prokharchyk
ab418176ef
VPC: CS-15569/CS-15568 - release ip address from VPC when fail to enable static nat
2012-07-13 10:37:09 -07:00
Koushik Das
1bcb9afa89
Fix for CS-15279.
...
Issue happens when ROOT volume gets created and there is subsequent failure in starting the VM. During retry if allocator assigns a different storage pool the scenario was not handled. Now in case of local storage the volume get recreated on the newly assigned pool and old one gets cleaned up. In case of shared storage the existing volume is migrated to new storage pool.
Reviewed-by: Prachi, Edison, Nitin
2012-07-13 11:13:00 +05:30
Vijayendra Bhamidipati
7ef5f314ee
CS-15526: Failed to create a guest network for basic zone.
...
Description:
vlanId isn't a db ID, so removing its inclusion
in an IdentityProxy object when throwing an
exception. It's a string, so it was causing
problems since it was being converted to a Long.
2012-07-12 17:36:12 -07:00
anthony
970bdb3972
CS-15551 : if 'xen.check.hvm' is false, don't check template hvm in allocator
2012-07-12 11:17:13 -07:00
Alena Prokharchyk
7e73ae8e74
VPC: CS-15553 and CS-15549 - more checks during automatic ip assoc to VPC network
2012-07-12 10:04:39 -07:00
Alena Prokharchyk
988831327a
VPC: added forVpc parameter to listNetworks api call. If true, list networks not belonging to any vpc
2012-07-12 09:09:09 -07:00
Vijayendra Bhamidipati
05c910ca5c
CS-15217: Security: Malicious user is able to get the size of the cloud by enumerating IDs
...
Description:
Removing DB IDs from exception messages.
2012-07-11 20:57:09 -07:00
Vijayendra Bhamidipati
a0f6cb47f1
CS-15217: Security: Malicious user is able to get the size of the cloud by enumerating IDs
...
Description:
Removing DB IDs from exception messages.
2012-07-11 19:52:56 -07:00
Alena Prokharchyk
fcd9c0c368
VPC: CS-15550 - fixed listVPCs by cidr
2012-07-11 19:10:48 -07:00
Vijayendra Bhamidipati
c5be9daa95
CS-15217: Security: Malicious user is able to get the size of the cloud by enumerating IDs
...
Description:
Removing more DB IDs from exception messages,
2012-07-11 18:34:00 -07:00
Edison Su
79bb22c942
CS-15544,fixed
2012-07-11 16:01:07 -07:00
Vijayendra Bhamidipati
1e407f62ad
Merge branch '3.0.x' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 3.0.x
2012-07-11 15:52:55 -07:00
Alena Prokharchyk
9fe68fc4a9
VPC: mark gateway with Deleting state when all static routes are gone
2012-07-11 15:48:29 -07:00
Vijayendra Bhamidipati
f2c8a59983
CS-15217: Security: Malicious user is able to get the size of the cloud by enumerating IDs
...
Description:
More changes to remove DB IDs from exception messages,
2012-07-11 15:46:17 -07:00
Alena Prokharchyk
be4185338f
VPC: CS-15548 - don't plug the nic for guest network to router when network not in Implemented state
2012-07-11 15:04:34 -07:00
Alena Prokharchyk
a0a0113b51
VPC: fixed listStaticRoutes when search by gatewayId
2012-07-11 14:51:19 -07:00
Alena Prokharchyk
1a3a899d59
VPC: fixed logging
2012-07-11 14:51:19 -07:00
Alena Prokharchyk
c44af15cd6
VPC: added State to vpc_gateways
2012-07-11 11:53:30 -07:00
Alena Prokharchyk
b8b7d06f15
VPC: don't send staticRoutes in Revoke state to the VPC VR
2012-07-11 10:51:20 -07:00
Koushik Das
d4d1b1c5a9
Revert "Fix for CS-15345". This issue was caused due some bug in VPC related cleanup code. The bug got fixed as part of 3caffc7855, so this is no longer needed.
...
This reverts commit a8c1568b37 .
2012-07-11 14:19:29 +05:30
Sheng Yang
6582882666
S2S VPN: Add domain and account for VPN
...
Admin can add VPN connection for others
2012-07-10 18:55:08 -07:00
Alena Prokharchyk
a3424cf8a0
VPC: add vm to network - no need to prepare nic when add vm in Stopped state to the network; the nic will be prepared once the vm starts up
2012-07-10 18:02:44 -07:00
Alena Prokharchyk
954b937a42
VPC: unplugNic - release the nic in the DB only after the command is executed succesfully on the backend
2012-07-10 18:02:44 -07:00
Alena Prokharchyk
4e5355b192
VPC: CS-15519 - fixed ipAssoc when only zoneId parameter is passed in to the API call
2012-07-10 15:15:30 -07:00
Sheng Yang
37a0ef7375
CS-15512: Fix delete vpn connection
2012-07-10 14:47:27 -07:00
Alena Prokharchyk
3caffc7855
VPC: CS-15345 - fixed regression in ipRelease happening as a part of cleanupNetworkResources method
2012-07-10 14:33:24 -07:00
Sheng Yang
8212de6f94
CS-15513: Fix group 5 of s2s vpn
2012-07-10 10:31:25 -07:00
Alena Prokharchyk
08b9b3bc5b
VPC: CS-15505 - allocate guest nics when new VR starts in VPC
2012-07-09 18:08:44 -07:00
Sheng Yang
a87a0619c2
S2S VPN: Add state for vpn connection response
2012-07-09 16:54:40 -07:00
Alena Prokharchyk
e8658c9525
VPC: CS-15481: don't allow creating networkACLs for overlapping cidrs/ports
2012-07-09 16:24:44 -07:00
Alena Prokharchyk
9c9b7ee299
CS-15503: don't send Ips in Releasing state as a part of VPC VR start
2012-07-09 15:30:50 -07:00
Alena Prokharchyk
fe958786b5
CS-15459: fixed listTags by resourceType
2012-07-09 14:58:11 -07:00
Alena Prokharchyk
1657486f41
VPC: added vpc_id to private_ip_address table to indicate which vpc the ip belongs to
2012-07-09 13:00:03 -07:00
Alena Prokharchyk
03138dee07
listPublicIpAddresses api: don't set associatedWithNetworkId if corresponding field is null in the DB
2012-07-09 10:11:29 -07:00
Alena Prokharchyk
98f8e70ca9
VPC: CS-15486 - prepare public nic as a part of VR deployment
2012-07-09 10:11:29 -07:00
Devdeep Singh
993852c5df
CS-15429: Create instance should fail if it results in exceeding volume resource limits for a user/domain-admin.
...
Additional fix needed if an instance is being created from an ISO. If an instance is created from an iso disk
offering id is not null and only one root volume disk is created. Making a fix to pass the right resource count
for an instance being created from an iso.
Reviewed-By: Rajesh
2012-07-09 17:52:32 +05:30
Alena Prokharchyk
6a9d5a7a0d
ResourceTags: respect tag parameter in listTemplates/listIsos commands
2012-07-06 16:37:40 -07:00
Alena Prokharchyk
29aaf4c841
VPC: fixed listNetworkACLs by networkId
2012-07-06 16:33:31 -07:00
Vijayendra Bhamidipati
b5cb3ef70e
Merge branch '3.0.x' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 3.0.x
2012-07-06 15:58:55 -07:00
Vijayendra Bhamidipati
06a9ef7923
CS-15217: Security: Malicious user is able to get the size of the cloud by enumerating IDs
...
Description:
More changes to remove DB IDs from exception messages.
2012-07-06 15:58:12 -07:00
Alena Prokharchyk
a9e1c8fa86
VPC: allow adding private gateway to the VPC when the VR is in Stopped state
2012-07-06 15:26:33 -07:00
Sheng Yang
987cf9bc93
CS-15447: Don't enable s2s vpn when provider is disabled
2012-07-06 15:08:26 -07:00
Alena Prokharchyk
c49cc27b1c
VPC: CS-15485 - dont' create a record for VPC VR private gateway nic in router_network_ref; do it for regular guest networks only
2012-07-06 14:54:25 -07:00
Alena Prokharchyk
ed63a14d5e
Resource tags: CS-15473 - fixed delete/list by resourceId when UUID is specified as a value
2012-07-06 10:32:24 -07:00
Deepti Dohare
009f2543ed
Merge branch '3.0.x' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 3.0.x
2012-07-06 15:13:51 +05:30
Deepti Dohare
f659958c24
CS-15430 Create snapshot should fail if creating snapshot results in exceeding snapshot resource limit for domain-admin or user accounts
...
Reviewed-by: devdeep.singh@citrix.com
Change:
1. Before creating the snapshot, we synchronized checkresourcelimit to allow the users to create the snapshot and increment the resource count.
2. Depending on the failure of snapshot creation/ backup, we are decrementing the resource count.
2012-07-06 15:08:46 +05:30
Alena Prokharchyk
f2546dd2bd
CS-15459: fixed listTags for userVms
2012-07-05 18:33:23 -07:00
Alena Prokharchyk
447f018b13
VPC: fixed CS-15465 - lb creation for ip not associated with any networks
2012-07-05 18:06:52 -07:00
Alena Prokharchyk
f9d512f163
ResourceTags: resourcetags support for Project/Vpc/NetworkACL/StaticRoute
2012-07-05 17:33:20 -07:00
Alena Prokharchyk
7c647223f2
VPC: don't fail when create/remove static route when VPC VR is in Stopped state
2012-07-05 17:26:25 -07:00
Vijayendra Bhamidipati
3a557c2998
Merge branch '3.0.x' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 3.0.x
...
Conflicts:
server/src/com/cloud/network/NetworkManagerImpl.java
2012-07-05 17:06:02 -07:00
Vijayendra Bhamidipati
f1ec4fddd3
CS-15217: Security: Malicious user is able to get the size of the cloud by enumerating IDs
...
Description:
As part of the fix for Bug CS-13127, a new overloaded function,
addProxyObject() was added to facilitate transparent db id to
uuid conversions when db IDs were added to exceptions that were
thrown in the Cloudstack mgmt server code. However, it turns out
that there are quite many db IDs still in the code that are
being directly embedded in the String message that is passed
during exception creation.
In this commit, we modify the default constructor of
InvalidParameterValueException so that it takes a second
argument of type List<IdentityProxy>. This will help developers
see that there is a second parameter required, and make them
look into what that parameter is about. Hopefully, this will
stop db IDs from being embedded into the exception message.
The parameter can be set to null though, since there are many
places in the code that don't embed any DB IDs in the exception.
This is still a WIP, so the older default constructor for
InvalidParameterValueException has not been removed yet. When
all instances of throw new InvalidParameterValueException()
have been moved over to the new default constructor, the old
one will be removed, else compilation will break. The reason
for having to do this in batches is that there are way too
many places in the code that throw exceptions, and they all
cannot be covered in a single commit without it taking much
time.
In following commits, all other exceptions will be changed
in the same way as InvalidParameterValueException.
2012-07-05 16:48:36 -07:00
Sheng Yang
a0a5e25e32
CS-15456: Prohibit creating more than one VPN gateway of VPC
2012-07-05 15:45:21 -07:00
Alena Prokharchyk
21cdd08948
VPC: don't allow vm to be a part of more than one VPC
2012-07-05 15:28:30 -07:00
Alena Prokharchyk
24023fd14d
VPC: don't allow vpcs for the same account with overlapping cidrs
2012-07-05 15:20:44 -07:00
Alena Prokharchyk
a44843af69
VPC: added "forVpc" (boolean) parameter to listRouters call - filter by the fact if router belongs to VPC or not
2012-07-05 14:04:34 -07:00
Alena Prokharchyk
d8cdb89721
VPC: added field networkacl_service_provided to physical_network_service_providers table
2012-07-05 13:56:55 -07:00
Alena Prokharchyk
2699e2c508
VPC: CS-15447 - fail vpc creation when vpc provider is not enabled at least in one physical network in the target zone
2012-07-05 13:34:34 -07:00
anthony
f1ac568a91
VPC : check if dns1 is null
2012-07-05 11:53:04 -07:00
Alena Prokharchyk
e6d73fb114
VPC: added dns1/dns2 + networkDomain to the list of bootload args passed on VPC VR start
2012-07-05 10:32:51 -07:00
Alena Prokharchyk
931c3eb78e
VPC: removed NetworkACL interface; added getTrafficType() to Firewall
2012-07-05 10:22:49 -07:00
Deepti Dohare
892ee23ca5
Merge branch '3.0.x' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 3.0.x
2012-07-05 11:32:24 +05:30
Pranav Saxena
922d254b72
CS-13376- Vm is stuck in Stopping state when MS is rebooted after the stop command was issued, but answer wasn't recieved from the backend yet
2012-07-05 11:29:01 +05:30
Deepti Dohare
7d6db010ac
CS-15429: Create Instance should fail if creating instance results in exceeding volume resource limit for domain-admin or user accounts
...
Reviewed-by: devdeep.singh@citrix.com
Change: Adding a check for diskOfferingId
2012-07-05 11:27:48 +05:30
Pranav Saxena
c6448d0e8e
CS-13376- Vm is stuck in Stopping state when MS is rebooted after the stop command was issued, but answer wasn't recieved from the backend yet
2012-07-05 11:24:24 +05:30
Pranav Saxena
a4740b314f
CS-13376: Vm is stuck in Stopping state when MS is rebooted after the stop command was issued, but answer wasn't recieved from the backend yet..removing trailing whitespaces in the code
2012-07-04 22:04:20 +05:30
Pranav Saxena
75026053bc
CS-13376: Vm is stuck in Stopping state when MS is rebooted after the stop command was issued, but answer wasn't recieved from the backend yet
2012-07-04 21:51:32 +05:30
Alena Prokharchyk
1ac1bcb2f6
VPC: createLB rule - removed duplicated check for ip services when createLB rule
2012-07-03 17:34:49 -07:00
Alena Prokharchyk
3383c79452
VPC: added zoneName to the VPC api response
2012-07-03 17:14:07 -07:00
Alena Prokharchyk
3a56e3c55c
VPC: CS-15426 - In Basic zone always pass control nic when prepare nics for the VR
2012-07-03 17:10:12 -07:00
Alena Prokharchyk
5a175e871c
VPC: CS-15355 - fixed router when deployVm in Basic zone
2012-07-03 17:10:12 -07:00
Alena Prokharchyk
a899391b6e
VPC: fixed response tag for VpcRespnse
2012-07-03 16:12:37 -07:00
Vijayendra Bhamidipati
ca5a53ce4d
Merge branch '3.0.x' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 3.0.x
2012-07-03 15:43:35 -07:00
Vijayendra Bhamidipati
e71732babc
CS-14952: Nexus vSwitch: vCenter IP Address and DataCenter information is not present in the "virtual_supervisor_module" table. VSwitch Crendentials are not encrypted.
...
Description:
Qualifying the VSM password stored in virtual_supervisor_module
as encryptable. The encryption/decryption is transparently done
by the cloudstack DAO layer.
2012-07-03 15:41:42 -07:00
Alena Prokharchyk
9f6d03b87b
VPC: added "forVpc" parameter to listNetworkOfferings command. If true, the offeirng can be used for vpc networks only
2012-07-03 15:37:07 -07:00
Alena Prokharchyk
1011dfd31c
Resource tags: 1) Remove tag records when correspdonding cloudStack object gets removed
...
2) added "tags" request parameter to the banch of list* Api commands (listVirtualMachines, listSnapshots - all commands are listed in the resource tags functional spec)
2012-07-03 14:47:07 -07:00
Vijayendra Bhamidipati
f5f356c150
Merge branch '3.0.x' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 3.0.x
2012-07-03 14:01:07 -07:00
Vijayendra Bhamidipati
9e3330374f
CS-15151: Cluster_details table stores Vcenter Cluster credentials in clear text
...
Description:
Encrypting password values before they're written out to
the cluster_details db, and decrypting them when reading
in the values from the db.
2012-07-03 13:47:29 -07:00
anthony
2742c50484
CS-15385 : fix vm start in basic zone
2012-07-03 11:30:59 -07:00
Alena Prokharchyk
1e67de0ac5
VPC: added missing FirewallService to the VR provider
2012-07-03 09:34:45 -07:00
Koushik Das
a8c1568b37
Fix for CS-15345
...
During account cleanup, associated network is accessed without checking whether it is present or not. Added a check to use it only when present.
2012-07-03 18:52:36 +05:30
Alena Prokharchyk
6af13737fa
VPC: corrected the name for PublicIp interface (mistakenly renamed it as a part of previous checkin)
2012-07-02 17:31:47 -07:00
Alena Prokharchyk
e3ca32af2a
VPC: remove network ACLs from VPC VR when shutdown guest network
2012-07-02 16:44:43 -07:00
Sheng Yang
c5cdd6947f
CS-6840: Fix 0 id returned by createVpnConnection
2012-07-02 16:15:43 -07:00
Jason Bausewein
b071260878
CS-15274: Fix NPE on CreateVlanIpRangeCmd()
...
Signed-off-by: Sheng Yang <sheng.yang@citrix.com>
2012-07-02 15:08:09 -07:00
Alena Prokharchyk
481f59df3b
VPC: multiple fixes:
...
* Separate service for NetworkACL - "NetworkACL" service
* allow having just one network supporting LB in the VPC
* perform check against VPC when upgrade network to the new network offering (the same set of checks when you add new network to the VPC)
2012-07-02 14:14:34 -07:00
Jessica Wang
1791c7533b
cloudstack 3.0 API - listVpnConnections API - add gatewayIp, guestCidrList,ipsecPsk, ikePolicy, espPolicy, lifetime property (get it from customerGateway object).
2012-07-02 13:39:34 -07:00
Alena Prokharchyk
4415c67604
VPC: createPrivateGateway - consists of plug nic + ipassoc (no setsource nat is needed)
2012-07-02 12:58:30 -07:00
Jessica Wang
60da16fe8b
cloudstack 3.0 API - listVpnConnections API - add publicip property (get it from vpnGateway object).
2012-07-02 10:24:10 -07:00
Deepti Dohare
b09e43f977
CS-15300 Limits on domain admin accounts
...
Reviewed-by: devdeep.singh@citrix.com
change: fix for listResourceLimits
2012-07-02 20:13:06 +05:30
Sheng Yang
618d2541c8
CS-6840: Add status checking for site 2 site VPN
2012-06-29 18:58:52 -07:00
anthony
0f06bc6643
VPC : network usage works in VPC
2012-06-29 17:33:17 -07:00