Commit Graph

362 Commits

Author SHA1 Message Date
Min Chen c6928f2f53 CLOUDSTACK-4480: Handle DestroyCommand in VmwareResource to evict
unused template from primary storage pool.
2013-08-23 14:36:11 -07:00
Animesh Chaturvedi 06f28722b6 Updating pom.xml version numbers for release 4.2.0
Signed-off-by: Animesh Chaturvedi <animesh@Animesh-LinuxDev.citrite.net>
2013-08-22 17:15:42 -07:00
Min Chen 71bd669cb0 CLOUDSTACK-4433:[VMware]Registration of template using the downloaded
template URL is failing.
(cherry picked from commit 885a161b62)

Signed-off-by: animesh <animesh@apache.org>
2013-08-22 00:15:57 -07:00
Min Chen 885a161b62 CLOUDSTACK-4433:[VMware]Registration of template using the downloaded
template URL is failing.
2013-08-21 17:34:03 -07:00
Sateesh Chodapuneedi 9d49fe8c0f CLOUDSTACK-4414
Fixing detection of failure in cluster discovery before cleanup vsm device.
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-08-21 07:58:13 +05:30
Nitin Mehta 836ee4b139 CLOUDSTACK-4386
KVM - Create template from volume
Vmware - Create template from volume / Create template from snapshot
send the physical size in the copycommand which accordingly will populate template store ref and the usage_event tables with the right physical size
Signed off by : nitin mehta<nitin.mehta@citrix.com>
2013-08-19 17:16:38 +05:30
Mice Xia 8b6eeedaae fix CLOUDSTACK-3234 modify the logics of retrieving Vmsnapshot volume path 2013-08-19 15:29:09 +08:00
Kelven Yang b73c449914 CLOUDSTACK-4390, CLOUDSTACK-4358: Enable full-clone deployment by default for VMware. Apply keep-alive kick for all outstanding vCenter sessions 2013-08-18 23:13:00 -07:00
Sateesh Chodapuneedi dd5ea8f2aa CLOUDSTACK-4385 : [ZWPS]Across the cluster live migration of VM on zone wide primary storage pool fails
If all the VM's volumes are on zone wide primary storage pool then live migration of the VM would not involve storage migration. Hence MigrateVM API would be called against MigrateVMWithVolume. So far PrepareForMigrationCommand handled scenarios of VM moving across hosts within a cluster, but with zone wide primary storage in picture this command need to handle scenarios of VM moving across clusters. Try to find the VM in datacenter if not found within cluster.

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-08-19 05:52:13 +05:30
Likitha Shetty 2e0ad8e573 CLOUDSTACK-4352. In VMWare, to resize an offline volume we create a worker vm. When a volume is being shrinked or when it is resized to the same size delete the vm before returning. 2013-08-16 14:36:32 +05:30
Kelven Yang 950672ef8c CLOUDSTACK-4288: Fix the way that VmwareClient is using vSphere 5.1 SDK which caused huge memory footprint 2013-08-14 15:00:07 -07:00
Edison Su 6abc3da828 CLOUDSTACK-4318: clean up snapshot stored in staging area, after backup snapshot to object store 2013-08-14 14:58:01 -07:00
Sateesh Chodapuneedi 507f742213 CLOUDSTACK-4326 Adding VMware DC to legacy zone should not be allowed by API
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-08-14 12:51:01 +05:30
Vijayendra Bhamidipati c850f0a0e3 CLOUDSTACK-4139: [VMWARE][ZWPS] Failed to resize the volumes which are created from snapshot
Description:

    Support offline volume resize on ESX by creating a worker VM
    to attach the unattached volume to and then resize it.
2013-08-13 12:46:35 -07:00
Mike Tutkowski b04a2b561b CLOUDSTACK-4264 2013-08-12 21:57:55 -06:00
Kelven Yang edaa1c8927 CLOUDSTACK-3568: Refactore CloudStack/vCenter API session management facility to avoid the situation that multiple API requests are sharing with the same vCenter API session 2013-08-12 16:24:57 -07:00
Sateesh Chodapuneedi 2c9f073249 CLOUDSTACK-3905 [VMWARE]Can not add Standard/DVSwitch when Nexus global config is set to true
Make VSM specific input paramters optional while adding VMware cluster where no traffic chosen to use Nexus 1000v dvSwitch when cloud level vSwitch is Nexus 1000v.

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-08-12 22:41:38 +05:30
Edison Su 73c57bf0b2 CLOUDSTACK-4253: add more logs for vmware storage related operations 2013-08-12 11:29:29 -07:00
Edison Su 8e5406f5ba CLOUDSTACK-4253: change the log message if copy template from secondary storage to primary storage failed 2013-08-12 11:01:56 -07:00
Sateesh Chodapuneedi 32fd0c94a2 CLOUDSTACK-4246 VM deployment fails with global configuration parameter "vmware.nested.virtualization" enabled.
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-08-12 09:51:41 +05:30
Sateesh Chodapuneedi e4f9c2ac44 CLOUDSTACK-4155 [VMWARE] Failed to deploy VM with NPE when vmware.nested.virtualization is enabled to true
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-08-12 07:45:15 +05:30
Kelven Yang 17715d7e77 CLOUDSTACK-3237: pass disk file name instead of full datastore path when setting up storage relocation specin order to safely locate the disk device 2013-08-09 17:28:35 -07:00
Kelven Yang 4e7b1de45a CLOUDSTACK-3778: serialize configuration of port group at per-host level to prevent run-time race condition 2013-08-08 17:41:45 -07:00
Min Chen 605376dc4d CLOUDSTACK-4190:[Object_store_refactor] volume should be deleted from
staging storage after successfule volume migration .
2013-08-08 16:08:50 -07:00
Edison Su 784a9d45d0 CLOUDSTACK-4106: fix volume related operations on vmware&s3 2013-08-08 12:34:54 -07:00
Sateesh Chodapuneedi caa9d27822 CLOUDSTACK-2558 Nexus configuration cleanup is not done when there is a failure while adding the Nexus enabled VMWARE cluster which is causing for NPE while readding the cluster with same configuration details
If cluster addition fails then cleaning up the Nexus VSM related to the cluster.

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-08-08 13:46:59 +05:30
Edison Su f6b66b94f0 CLOUDSTACK-4108: fix create template from snapshot for vmware& s3 2013-08-07 19:11:28 -07:00
Edison Su 26a5b76ee6 CLOUDSTACK-4109: fix upload volume to s3 for vmware 2013-08-07 18:25:59 -07:00
Kelven Yang ec5f2c1512 CLOUDSTACK-3869: fix merge conflicts 2013-08-07 17:44:40 -07:00
Kelven Yang 1d939930de CLOUDSTACK-3869: make new folder structure to work with Create/Delete/Attach/Detach commands 2013-08-07 17:44:40 -07:00
Min Chen ecfedf00bf CLOUDSTACK-4135: [Object_store_refactor] ISO attached to the guest vm
has wrong mount path.
2013-08-07 17:26:42 -07:00
Min Chen e87b1679cd CLOUDSTACK-3568: [Automation]Parallel deployment - Vmware - When
deploying 30 parallel Vms , we see ~15 Vms fail in
org.apache.cloudstack.storage.command.CopyCommand.
2013-08-07 11:13:56 -07:00
Kelven Yang 059e4b2ae0 CLOUDSTACK-3886: check in for review request https://reviews.apache.org/r/13008/ 2013-08-07 10:29:18 -07:00
Sateesh Chodapuneedi aa3558d103 CLOUDSTACK-3616 [VMware] Failed to create template from volume (volume is created from snapshot of data volume)
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-08-07 14:49:32 +05:30
Sateesh Chodapuneedi 30e12c289e CLOUDSTACK-3782 Data disk size is modified to KB from GB after it is attached to the instance
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-08-07 08:07:32 +05:30
Sateesh Chodapuneedi ffdde5cc2e CLOUDSTACK-4041 [ZWPSFailed to migrate a ROOT volume created on zone wide primary storage
While finding endpoint to send the migrate volume command, in case of zone wide storage pool, storage engine is picking a host among all connected hosts randomly. Hence a host may be from different cluster t

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-08-07 05:27:17 +05:30
Edison Su 333b272120 CLOUDSTACK-4073: fix s3 on vmware 2013-08-05 20:20:31 -07:00
Edison Su ab9ce67e19 CLOUDSTACK-4074: if hypervisor doesn't return size of volume/template, don't update it into db 2013-08-05 16:21:36 -07:00
Kelven Yang 68974a0d0e CLOUDSTACK-3869: Move VMware datastore folder structure policy management to central place 2013-08-05 13:40:57 -07:00
Bharat Kumar 087b1dcfc3 Cloudstack-3299 incorrect arguments sent to the script createIpalias in case of vmware, Cloudstack-3240 corrected a mistake in the script name.
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2013-08-01 17:00:40 +05:30
Kelven Yang 065ae7a497 Correct DAO usage in VmwareDatacenterVO, relax assertion conditions to work with stack calling frame that is not wrapped with @DB injection 2013-07-30 18:05:38 -07:00
Edison Su b3576cac27 add note on vmwarweguru->getCommandHostDelegation 2013-07-30 11:37:14 -07:00
Edison Su d9ba83f0a4 CLOUDSTACK-3944: fix regression for vmware 2013-07-30 11:34:40 -07:00
Koushik Das 73ec4ede66 CLOUDSTACK-3937: Attaching uploaded volume is failing
The method getCommandHostDelegation(long hostId, Command cmid) got overidden in VmwareGuru.java as part of
commit bfe30cd2e3. Earlier there was no HV specific implementation and copy
volume from secondary to primary worked fine. With the Vmware specific change the code was getting hit even
in case of XS and other hypervisors and failed with NPE.
Now there is a check in the Vmware implementation to check if the HV is of type Vmware.
2013-07-30 16:34:28 +05:30
Edison Su 6533e6559b CLOUDSTACK-3107: fix attach upload volume 2013-07-29 18:59:10 -07:00
Edison Su 734aa1d510 CLOUDSTACK-3908: fix extract path 2013-07-29 16:57:44 -07:00
Kishan Kavala 6154c52242 CLOUDSTACK-3849: Set volume size in CopyAnswer for Vmware when cloning volume from bas template 2013-07-29 16:34:15 +05:30
Mice Xia acd2396660 fix CLOUDSTACK-3591 add usage recording for VM snapshots 2013-07-29 17:57:20 +08:00
Sateesh Chodapuneedi 7ba5d9910b CLOUDSTACK-3468 Failed to Deploy Instances with multiple VMWARE clusters when DVS is enabled at the Zone level
Fixing cluster level override of zone level specified vSwitch settings.

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-07-29 03:09:09 +05:30
Sateesh Chodapuneedi 9b7bee0e85 CLOUDSTACK-3879 [VMware] NPE while attempting to create template from volume
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-07-27 16:59:26 +05:30
Sateesh Chodapuneedi 2aa2f47519 COUDSTACK-3053 Template creation from snapshot is failing on VMware setup
Fixed snapshot vmdk file path while copying snapshot files to template path.

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-07-27 16:54:49 +05:30
Edison Su ed46a64add CLOUDSTACK-3852: fix upload volume 2013-07-26 18:05:10 -07:00
Min Chen 1305697eaa CLOUDSTACK-3818: NFS Cache Improperly Named. 2013-07-26 14:36:00 -07:00
Min Chen 6b9ea47711 CLOUDSTACK-3667:[Object_Store_Refactor][VMWare] System VMs StartCommand
failed due to Exception: java.lang.Exception Message: secondary storage
for dc 3 is not ready yet?
2013-07-25 10:56:01 -07:00
Jayapal 34f75b0a5d CLOUDSTACK-2933 Added vpc load balancing changes for vmware 2013-07-25 17:40:21 +05:30
Edison Su ca474d0e09 CLOUDSTACK-2304: fix migrate volume for vmware 2013-07-24 18:59:46 -07:00
Edison Su bfe30cd2e3 CLOUDSTACK-3681: fix bunch of bugs related to vmware, regarding to snapshot 2013-07-24 15:54:36 -07:00
Bharat Kumar 42346cdf47 Cloudstack-3694 Dnsmasq rewrite in bash
(Sheng: Fix typo, fix log and error message, remove 'set -x' in script)

Signed-off-by: Sheng Yang <sheng.yang@citrix.com>
2013-07-24 13:59:58 -07:00
Harikrishna Patnala 820a5e09dc Fix file name in DnsMasqConfigCommand
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2013-07-24 13:59:58 -07:00
Harikrishna Patnala d09a088093 CLOUDSTACK-3302: [Multiple_IP_Ranges][VmWare] VM deployement failed due to dnsmasq configuration issue in case of multiple subnets in a vlan
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2013-07-24 13:59:58 -07:00
Bharat Kumar 3673db26b0 Cloudstack-3302 VM deployement failed in VMWare due to dnsmasq configuration issue in case of multiple subnets in a vlan
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2013-07-24 13:59:57 -07:00
Mike Tutkowski 25b33ec808 Changes related to Review Board comments 2013-07-20 17:25:22 -06:00
Mike Tutkowski 8f1799b71f Changes related to Review Board comments 2013-07-18 19:46:42 -06:00
Sateesh Chodapuneedi 7186473e33 CLOUDSTACK-3595 Backup snapshot successful but CopyCmdAnswer received is failure.
Send success answer of type CopyCmdAnswer with full snapshot backup path in secondary store (image store role)

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-07-18 10:31:52 -07:00
Vijayendra Bhamidipati dc1ac3c45d CLOUDSTACK-3554: NPE while attaching VMWARE Tools ISO to the instance
Description:

    Account for null imagestore for vmware-tools iso.
2013-07-17 16:58:26 -07:00
Sateesh Chodapuneedi 19548ec51c CLOUDSTACK-3530 Runtime exception while creating Snapshot from volume (ROOT/DATA)
Worker name is not being configured for CopyCommand.

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-07-18 00:41:27 +05:30
Jayapal 50b5ba6452 CLOUDSTACK-2433 Enable rps and rfs in virtual router 2013-07-17 18:07:46 +05:30
Hugo Trippaers 93621bb5f9 CLOUDSTACK-728 Remove the nvp portgroup when the virtual machine is
expunged.
2013-07-16 15:44:40 +02:00
Vijayendra Bhamidipati 6e85ae219b CLOUDSTACK-3425 Ignore network interfaces without a uuid when passing them on as extra configs to ESX for nicira NVP controller.
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2013-07-15 10:26:43 +02:00
Edison Su 28a85fe000 fix compile issue 2013-07-12 16:08:10 -07:00
Mike Tutkowski 13ec10caa6 Changes related to Review Board comments
Changes related to Review Board comments
2013-07-12 14:26:11 -06:00
Hugo Trippaers 55c0616d90 CLOUDSTACK-728 Get the framework in place the support the removal of the portgroup that is created for a nic connected to an lswitch.
Add a command to tell a hypervisor guru to take some action when
expunging a nic
2013-07-12 14:23:13 +02:00
Hugo Trippaers a0fe6ecc43 Formatting changes using the settings from Alex 2013-07-12 14:22:59 +02:00
Hugo Trippaers 5bdbd72d6d CLOUDSTACK-728 Rewrite support for lswitch connected nics on both standard and distributed switches.
Fix the name of the interface id in extra config, so the nic is found up using the nic uuid instead of the vm id.

getVlanInfo should return null when the nic is plugged on a Lswitch network.

On a distributed portgroup all vms should be connected to a single
portgroup and set a specific vlan on the port. On a standard switch each nic should have its own portgroup with a dedicated vlan (not related to CS vlans)
2013-07-12 14:22:44 +02:00
Sateesh Chodapuneedi e9dfb79e0d CLOUDSTACK-3469 [VMware] Support to make username/password optional while adding VMware cluster
For legacy zones insist on the old model of asking for credentials for each cluster being added.
For non-legacy zones check if username & password are provided. If either or both not provided, try to retrieve & use the credentials from database, which are provided earlier while adding VMware DC to zone.
This lets user to not specify credentials while adding VMware cluster to zone, if the credentials are same as that of provided while adding VMware DC to zone.

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-07-11 20:44:06 +05:30
Sateesh Chodapuneedi b1f7056565 Updated logger initalization in classes ListVmwareDcsCmd, RemoveVmwareDcCmd & minor cleanup of comments. 2013-07-11 16:02:34 +05:30
Sateesh Chodapuneedi 50b8d64299 CLOUDSTACK-3450 To implement toggle action of add/remove VMware DC, listVmwareDcs API call is required.
listVmwareDcs API is added. Takes 1 parameter (mandatory) which is zoneId.
Returns list of VMware DCs associated with specified zone.

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-07-10 23:07:47 +05:30
Sateesh Chodapuneedi c02e38d670 CLOUDSTACK-3303 Vmware - Put a mechanism to disable hot add vcpu if the number of cores per socket is not 1 and virtual machine hardware version=7
Following Hotadd memory checks are included now.
1) Check if guest operating system supports memory hotadd
2) Check if virtual machine is using hardware version 7 or later before enabling memory hotadd

Following Hotadd CPU checks are included now.
1) Check if guest operating system supports cpu hotadd
2) Check if virtual machine is using hardware version 8 or later.
3) Check if virtual machine has only 1 core per socket. If hardware version is 7, then only 1 core per socket is supported. Hot adding multi-core vcpus is not allowed if hardware version is 7.

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-07-10 18:14:06 +05:30
Mike Tutkowski be6bc2b681 Changes related to Review Board comments 2013-07-09 23:19:44 -06:00
Sateesh Chodapuneedi 8cab35aa41 CLOUDSTACK-3304 [Vmware][Dynamic Scaling] - Enforce checks for maximum hotadd memory limit & memory increment size in CS
Retrieve maximum hotadd memory limit & hotadd memory increment size from running VM's configuration to validate dynamic scale memory limit while scaling up a VM.

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-07-08 21:19:46 +05:30
Sateesh Chodapuneedi 574f782ab2 CLOUDSTACK-2592 [Automation]: Scale up VM on VMWARE without license doesn't throw appropriate error
Now ESXi server license would be fetched to see if HOTPLUG feature is license or not.
Throw Exception if the feature is not licensed.

Also added FeatureKeyConstants enum type to maintain list of various features to be checked whether licensed or not.

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-07-08 12:53:38 +05:30
Sateesh Chodapuneedi a52bf1b641 CLOUDSTACK-3152 addVmwareDc API call fails if called more than once to add same VMware DC to same cloudstack zone.
Check if the associated VMware DC matches the one specified in API params. This check would yield success as the association exists between same entities (zone and VMware DC)
This scenario would result in if the API addVmwareDc is called more than once with same parameters. For such scenario, return success response with VmwareDatacenter object read from database. Also returns success even if the zone has resources (clusters) already.

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-07-02 18:25:41 +05:30
Sateesh Chodapuneedi 265c00dcfc CLOUDSTACK-3279 Need mechanism to detect if hotadd for cpu/memory is supported per a specific guest OS supported by VMware.
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-07-01 22:22:09 +05:30
Prasanna Santhanam 085e8838e4 Fix typo in backupSnapshotCommand
Signed-off-by: Prasanna Santhanam <tsp@apache.org>
2013-06-29 13:50:25 +05:30
Prasanna Santhanam de38cd815f Fix typo in class name
AsyncRpcConext -> AsyncRpcContext

Signed-off-by: Prasanna Santhanam <tsp@apache.org>
2013-06-29 13:50:25 +05:30
Mike Tutkowski 99227f7b3e SolidFire plug-in and related changes
SolidFire plug-in

SolidFire plug-in related
2013-06-28 16:59:21 -06:00
Fang Wang 24499deb43 CLOUDSTACK-2384: Template created from snapshot error.
In DB, the backedUpSnapshotUuid format got changed.
This messed up the vmdk file path in template creation from snapshot
2013-06-27 17:34:32 -07:00
Hugo Trippaers 53d1ce75a1 CLOUDSTACK-728 Set vmspec extra config for the Nicira NVP vApp 2013-06-26 15:41:52 -07:00
Hugo Trippaers 98dc68d8c9 CLOUDSTACK-728 For Nicira NVP a specified port-group must be used,
instead of a dynamically configured one.

Refactor bits of the HypervisorHostHelper to better
support multiple BroadcastDomainTypes

Cleanup some parts of the code that was using tab indents and removed some dead code.
2013-06-26 15:41:52 -07:00
Sateesh Chodapuneedi c36a952f15 CLOUDSTACK-1767 VMWare DVS - cannot use untagged portgroups
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-06-25 19:43:20 +05:30
Sateesh Chodapuneedi b3927ffe96 CLOUDSTACK-1766 VmWare DVS vmware.ports.per.dvportgroup setting not used
Read the global configuration setting while configuring VmwareManager.
Also enabling autoExpand feature for supported distributed virtual switch versions.

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-06-25 19:15:24 +05:30
Jayapal 1ab87ef4be CLOUDSTACK-3003 Fixed static route issue in vpc vmware 2013-06-25 18:43:00 +05:30
Jayapal 9121191f70 CLOUDSTACK-1578 vmware:Egress default policy configurable using network offering on vmware 2013-06-24 13:37:01 +05:30
Edison Su f41c800d88 merge to master 2013-06-14 19:06:33 -07:00
Edison Su e8b0cff1c6 CLOUDSTACK-2658: timeout can't be null 2013-06-14 18:26:20 -07:00
Harikrishna Patnala b83b8eb838 CLOUDSTACK-2502: Scalevm and over provisioning should respect each other
During Scale up of VM, memory/cpu calculations should consider the memory/cpu overprovisioning factors which are set per cluster.

CLOUDSTACK-2939:  CPU limit is not getting set for vm after scaleup to a service offering which have cpu cap enabled

Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2013-06-13 16:30:56 +05:30
Jayapal aeb024723a CLOUDSTACK-2942 Fixed issue in private gateway network acl
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2013-06-13 14:30:19 +05:30
Sateesh Chodapuneedi a1d7016b9d CLOUDSTACK-2962 [SM][VMWare]: migrate a virtualMachine with volumes is failing
Checking if source and target hosts belongs to same vcenter datacenter.

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-06-13 12:49:07 +05:30
Min Chen 1b905463c8 Fix vmware plugin unit testcase failure. 2013-06-12 13:54:56 -07:00
Min Chen 18aeef3ef1 Merge branch 'master' (up to commit
c30d9be3ce) into object_store.
2013-06-12 11:20:32 -07:00