684889f0b5
CLOUDSTACK-7833: VM Async work jobs log "Was unable to find lock for the key vm_instance" errors as warning
2014-11-03 10:52:47 -08:00
1aef5cba66
Fixed Coverity Issues
2014-11-03 16:45:30 +05:30
4ebaf0a583
Bump master version to 4.6.0-SNAPSHOT after branching 4.5.0-SNAPSHOT
2014-10-29 14:54:23 +01:00
94969b0654
CLOUDSTACK-7778: Start VM checkWorkItem loop should also check VM DB state before going into idle waiting to exit faster.
2014-10-23 14:28:23 -07:00
8218ce0fe2
unexplained happy flow for restart network modified
2014-10-23 20:57:33 +02:00
4a13f81485
when host is pingtimeout and CCP can not determine the host status, put the host to Alert status , no VM HA.
2014-10-22 15:14:46 -07:00
97aa02ceb0
Commits related to taking snapshots that live on primary storage
2014-10-22 12:44:33 -06:00
70112bd145
CLOUDSTACK-7761:
...
Revert "when system VM ping times out, stop system VM"
This reverts commit ee23be1942
2014-10-21 17:19:57 -07:00
57dacf99a2
Changed "boolean connectVolumeToHost(VolumeInfo, Host, DataStore)" to "boolean grantAccess(DataObject, Host, DataStore)"
...
Changed "void disconnectVolumeFromHost(VolumeInfo, Host, DataStore)" to "void revokeAccess(DataObject, Host, DataStore)"
2014-10-21 16:01:14 -06:00
4b8bfe2627
CLOUDSTACK-7563: Fix potential NPE from FingBugs.
2014-10-14 11:19:39 -07:00
0a9742f914
Fixed few coverity issues
...
Signed-off-by: Santhosh Edukulla <santhosh.edukulla@gmail.com>
2014-10-14 17:16:50 +05:30
d233f39c82
disable parallel for xenserver. Also for vmware, if full.clone is enabled and migratecommand will have the behavor of start/stop command
2014-10-09 17:14:57 -07:00
31a42d2b7a
Fixed few coverity patches
...
Signed-off-by: Santhosh Edukulla <santhosh.edukulla@gmail.com>
2014-10-09 11:45:26 +05:30
847e1e47ae
when system VM ping times out, stop system VM
2014-09-30 12:35:44 -07:00
1c94017ff6
CID-1241966 Fix potential null deref
2014-09-30 11:27:51 +02:00
55b4ead495
CLOUDSTACK-7598: When a vm deployed by cloudstack is stopped on the hypervisor
...
(outside cloudstack), the state of the vm is not updated in cloudstack db. The
ping task was not checking for resource (host) status by default. The power
state of the vms is returned as part of the resource status. Fixed the issue by
making sure ping task atleast tries once to get the resource status.
2014-09-25 13:13:56 +05:30
8c8c54f9f5
CLOUDSTACK-7622: Fixed deleting network when provider is disable
2014-09-25 10:31:51 +05:30
c55bc0b2d1
CLOUDSTACK-7534: ResetVM for VM with attached datadisk fails when enable.ha.storage.migration is false
...
Separate global config to enable/disable Storage Migration during normal deployment
Introduced a configuration parameter named enable.storage.migration
2014-09-24 16:35:23 +05:30
8a13f44b44
Remove duplicate field in constructor
2014-09-18 16:02:26 +02:00
7f440854f7
CLOUDSTACK-7184 retry-wait loop config to deal with network glitches
...
(cherry picked from commit a29f954a26
2014-09-18 12:55:05 +02:00
2cd99e3e72
CID-1116245: Lock for getting answers from SynchronousListener
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-09-18 11:56:29 +02:00
3640c61207
CID-1116248: Synchornize method in SynchronousListener
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-09-18 11:54:31 +02:00
e5a91e40dd
in tagCommand, AsyncJobExecutionContext doesn't need to be created if it doesn't exist
2014-09-17 18:15:41 -07:00
1b15efb5f0
CLOUDSTACK-7563: ClassCastException in VirtualMachineManagerImpl in
...
handling various Agent command answer.
2014-09-16 12:12:17 -07:00
d5a8f1d875
CLOUDSTACK-7553: Clean up cached agentMap and pingMap in case of agents
...
connecting back to a different MS.
2014-09-15 17:37:51 -07:00
0a4ab3251a
CLOUDSTACK-7513: listServiceOfferings API when called with VM's id also returns offerings to which it cant be upgraded. Adding the logic that when vmid is passed it looks for compatible offerngs using the storage type (local/shares), storage tags and also compute (cpu,speed, memory) in case the vm is running.
...
Also changed the scaleVm API to upgrade only when the destination offering has storage tags as a subset of current offering tags.
2014-09-15 11:02:34 -07:00
2b7b837b28
CLOUDSTACK-6099 live migration is failing for vm deployed using dynaic compute offerings with NPE
2014-09-10 13:26:24 +02:00
6f7c4863a2
CLOUDSTACK-7473: Vm migration is not supported for LXC. When host is put in maintenance mode, stop the Vms instead of migrating
2014-09-04 20:59:19 +05:30
dc3f0cbc63
Improve the handling of the findbug exclude files
2014-09-03 10:41:22 +02:00
8ce6eba549
CLOUDSTACK-7415. Host remains in Alert after vCenter restart.
...
Management server PingTask should update PingMap entry for an agent only if it is already present in the Management Server's PingMap.
2014-08-25 13:24:28 +05:30
19ffc93e2e
Fixed few coverity reported issues:Aug22 2014
2014-08-21 17:09:27 +05:30
7dbff9b42c
CLOUDSTACK-7371. [VMware] Enabling primary storage maintenance fails when storages are across cluster.
...
1. While destroying a ROOT volume do the lookup of the associated VM under the DC and not just cluster.
2. In case of VMware, during VM start if a volume is being recreated no need to detach the old volume because
we now expunge it immediately and don't wait for the storage cleanup task to run.
2014-08-20 10:51:18 +05:30
de424061b2
CLOUDSTACK-7006: Restore template ID in ROOT volume usages
...
Signed-off-by: Sebastien Goasguen <runseb@gmail.com>
2014-08-18 10:14:26 -04:00
8bc7ae695d
CLOUDSTACK-7182: NPE while trying to deploy VMs in parallel in isolated network
...
- Check to see if network is implemented changed from 'state == Implementing||Implemented' to 'state == Implemented'.
The earlier check was a hack to prevent the issue described below.
- At the time of implementing network (using implementNetwork() method), if the VR needs to be deployed then it follows
the same path of regular VM deployment. This leads to a nested call to implementNetwork() while preparing VR nics. This
flow creates issues in dealing with network state transitions. The original call puts network in "Implementing" state
and then the nested call again tries to put it into same state resulting in issues. In order to avoid it, implementNetwork()
call for VR is replaced with below code.
2014-08-18 10:43:04 +05:30
fee2bfce49
CLOUDSTACK-7344:VOLUME.DELETE usage event missing for VM's in ERROR
...
state.
2014-08-13 22:15:47 -07:00
e4d6cd8e6a
Fixed coverity reported concurrency issues
...
Signed-off-by: Santhosh Edukulla <santhosh.edukulla@gmail.com>
2014-08-05 12:16:08 +05:30
b7d3f1bd30
Fixed few coverity issues for resource synchronization
2014-08-04 16:09:26 +05:30
ffeca8bbd2
CLOUDSTACK-7209: handle the case when network fails to implement NoTransitionException, and null is returned to the caller stack. All caller methods should verify if the return value is null before processing it further.
2014-08-01 09:47:28 -07:00
3d6c64d262
CLOUDSTACK-7206: Update vm_network_map table correctly
2014-08-01 13:58:06 +05:30
bd3d8286d3
Fixed a simple coverity issue
2014-07-31 16:00:42 +05:30
f47cfc6eb1
CLOUDSTACK-7186: Revert "CLOUDSTACK-7182: NPE while trying to deploy VMs in parallel in isolated network"
...
This reverts commit 47d6a64b31
2014-07-28 16:02:21 -07:00
330c4ba578
completed the new vmsync TODOs in the code.
...
removed old vmsync logic
2014-07-28 12:51:37 -07:00
67876b215e
CLOUDSTACK-7191:On restartNetwork destroy the VR immediatley, instead of
...
cleanup the rules then destroy
fix adds a provision to specify if cleanup is needed on network on
shutdown. VR is marked as to not to require network rules clean up on
network shutdown as the VR is destroyed and recreated.
ran the simulator tests that test network life cycle
2014-07-28 17:09:42 +05:30
47d6a64b31
CLOUDSTACK-7182: NPE while trying to deploy VMs in parallel in isolated network
...
The following changes are made:
- Check to see if network is implemented changed from 'state == Implementing||Implemented' to 'state == Implemented'.
The earlier check was a hack to prevent the issue described below.
- At the time of implementing network (using implementNetwork() method), if the VR needs to be deployed then
it follows the same path of regular VM deployment. This leads to a nested call to implementNetwork() while
preparing VR nics. This flow creates issues in dealing with network state transitions. The original call
puts network in "Implementing" state and then the nested call again tries to put it into same state resulting
in issues. In order to avoid it, implementNetwork() call for VR is replaced with below code.
2014-07-25 15:17:35 +05:30
676b2d1569
Fix overflow before widening issues reported by Coverity
2014-07-24 13:22:14 +02:00
e78bb1d225
Switch the catch to Throwable. Uncaught exceptions in a scheduled
...
threadpool executor will not report or log uncaught exceptions but will
kill the thread causing unexplained timeouts in CS.
2014-07-16 16:24:55 +02:00
aacf8ef77b
Findbugs fixes in cloud-utils project and a few other places
2014-07-15 14:23:17 +05:30
97d296bfbd
Fixed Coverity reported performance issues like inefficient string concatenations, wrong boxing or unboxing types, inefficent map element retrievals
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-07-01 22:06:25 +02:00
ab0dca0385
Catch possible exceptions in finally so they won't shadow the original exception.
2014-06-25 15:51:29 +02:00
cd0ef09344
Fix typo and add the right exception to the error map.
2014-06-25 15:51:28 +02:00
f756d4aa33
Make job info universally available across management server and resource agents
2014-06-24 16:28:22 -07:00
3d9eaf0753
Fixed some spacing issues from 4d6c682f18
2014-06-24 15:27:06 -06:00
4d6c682f18
supporting nfs protocol and resize feature for managed storage for xenserver
...
resize feature refactored
Signed-off-by: Mike Tutkowski <mike.tutkowski@solidfire.com>
2014-06-24 15:16:45 -06:00
450d890942
CLOUDSTACK-6830: Fixed during VM migration, volumes on zone wide primary store
...
requires storage migration resulting in failure of VM migration. This also improves
the hostsformigration api. Firstly we were trying to list all hosts and then
finding suitable storage pools for all volumes and then we were checking whether
vm migration requires storage migration to that host. Now the process is updated.
We are checking for only those volumes which are not in zone wide primary store.
We are verifying by comparing volumes->poolid->clusterid to host clusterid. If it
uses local or clusterids are different then verifying whether host has suitable
storage pools for the volume of the vm to be migrated too.
2014-06-20 16:32:19 +05:30
3312394154
CLOUDSTACK-6934: don't try to detach volume from host when volume was never allocated to a primary storage
2014-06-18 12:39:36 -07:00
f529823566
Add ReflectionUse annotation for marking up *un-used* methods
2014-06-17 17:31:29 -07:00
aa21cdcd49
CLOUDSTACK-6897: when we try to attach the uploaded/allocated volume to a VM on zwps, then we were passing the podId of VM instead of storage pool to storage allocator. This resulting in use of Clusterscope storage allocator, allocating a storage pool for VM on zwps beacuse of pod id not null. This was resulting in scope conflict later
2014-06-13 14:47:00 +05:30
66d1eb92f0
CLOUDSTACK-6865 , CLOUDSTACK-6868: [hyperv] while attaching the volume we were changing the volume's Image format to hypervisor's default Image format, hence it was failing to find the volume with vhdx format. Now changed the behavior to set Image Format for volume only when it is not set
2014-06-13 13:26:02 +05:30
b666a1f3a5
Fixed issues reported by coverity NPEs, unwritten field access and self assignment
...
Signed-off-by: Koushik Das <koushik@apache.org>
2014-06-10 14:34:47 +05:30
3b3f4577b0
CLOUDSTACK-6476: Basic Zone with Multiple Pods Setup: DHCP server doesnt get deployed in the pod where the VM gets deployed
...
Changes:
PodId in which the router should get started was not being saved to the DB due to the VO's setter method not following the setXXX format. So when planner loaded the router from DB, it always got podId as null and that would allow planner to deploy the router in any pod. If the router happens to start in a different pod than the user VM, the Vm fails to start since the Dhcp service check fails.
Fixed the VO's setPodId method, that was causing the DB save operation fail.
2014-06-06 16:15:31 -07:00
7ce3034299
CLOUDSTACK-6790: Disable PXE ROM for system vm nics
2014-05-27 16:52:26 -06:00
d5754d9101
CLOUDSTACK-6740: Direct agent command throttling improvements
...
List of changes:
1. Created a separate thread pool for handling cron and ping tasks. The size of the pool is based on direct.agent.pool.size. The existing direct agent pool will run all commands other than cron and ping.
2. For normal tasks (generated as part of user/admin API calls), if throttle limit is reached then tasks get queued up for subsequent execution once threads are available.
3. For cron and ping tasks (internally generated by MS like ping, VM sync etc.), if throttle limit is reached then these gets rejected. Since these are internally generated these can be rejected without any issues.
2014-05-22 14:15:42 +05:30
245b7f4c39
CLOUDSTACK-6510: Fix gson serialization exception in storage migration. Gson couldn't serialize
...
a map with volume and storagepool objects for logging. Fixed by using volume and storage pool
ids instead of objects in the map.
2014-05-08 12:23:46 +05:30
4b89a45e57
CLOUDSTACK-3272 Latest changes to add global configuration parameters to control the publishing of events on the message bus
2014-05-07 10:09:03 +05:30
b3491bcbac
removed unused command ClusterSyncCommand
2014-05-01 11:45:19 -07:00
ab39739bd8
CLOUDSTACK-6211: Xenserver - HA - SSVM fails to start due to running out of management Ip ranges when testing host down scenarios
...
Signed-off-by: Koushik Das <koushik@apache.org>
2014-04-18 17:52:49 +05:30
6397f1c82e
CLOUDSTACK-6329 [Automation] Changing service offering of VM from medium to small failing with NPE
...
- The hostAllocators were not getting set
2014-04-17 17:55:17 -07:00
c031eb7d38
CLOUDSTACK-6242: exception handling improvements
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-04-15 08:07:15 +02:00
5e90b75c98
CLOUDSTACK-6402: Fix StopCommand so that VMs are not removed accidentally as part of vmsync
...
Added a new flag 'checkBeforeCleanup' to StopCommand based on which check is done to see if VM is running in HV host.
If VM is running then in this case it is not stopped and the operation bails out.
Also modified the MS code to call the StopCommand with appropriate value for the flag based on the context.
Currently it is only set to 'true' when called from the new vmsync logic based on powerstate of VM. For rest it
is set to 'false' meaning no change in behaviour.
2014-04-14 16:52:37 +05:30
11f5bdd78d
CLOUDSTACK-6191 Add support for specifying volume provisioning
...
type (thin, sparse, fat) in disk/compute offerings.
Submitted-by: Yoshikazu Nojima <mail@ynojima.net>
Reviewed-by: Marcus Sorensen, Mike Tutowski
2014-04-10 09:23:04 -06:00
54e9a98e8b
CLOUDSTACK-6362: Parallel VM deployment - direct.agent.thread.cap needs to default to 1.0 (currently 0.1) to allow for parallel Vm deployments.
2014-04-09 12:28:01 +05:30
3a889aa217
CLOUDSTACK-3886: Volume attach/detach implementation for ROOT disk
...
Implemented for Xen hypervisor only by now
Unittests are included
2014-04-03 11:39:56 -07:00
cd8801f6f7
Do app-level iteration to avoid mysql deadlocks
2014-04-02 15:46:50 -07:00
24820d20d3
CLOUDSTACK-6288: Changing default ImageFormat to vhdx for hyper-v and allowing registration of vhdx format templates.
...
Signed-off-by: Devdeep Singh <devdeep@gmail.com>
2014-04-01 14:00:24 +05:30
504a6cdee2
CLOUDSTACK-5432:sync vm and storage commands on mgt server for kvm
...
Conflicts:
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
server/src/com/cloud/hypervisor/KVMGuru.java
2014-03-28 16:24:07 -07:00
8b62b2cb92
findbugs: exclude known spiffy hacks a.k.a. false positives
2014-03-28 14:28:10 +01:00
6d103e62fe
use correct interval for cleanTask and transitionTask
2014-03-26 14:22:27 -07:00
4ebb92c492
Fixed some warnings about using a deprecated constructor
2014-03-25 16:48:27 -07:00
f445274ed3
Added a config to enable checking whether a db transaction is wrapped around communications with the agent. If it is, an exception is thrown. This assert has actually been there because it is part of CloudStack's design principle to not use db transactions as a way to enforce atomicity in executing things on hardware resources. However, the assert has been ignored since the move to maven which is not good with enabling asserts. Since then, there's been a lot of commands added that actually runs within db transaction. This is a big no no as the problem is that the remote operation may take a long time and the db can actually close the connection, causing a rollback of the transaction. We should not depend on transactions to enforce the atomicity anyways.
2014-03-25 16:35:49 -07:00
e3fc5a4d46
vm meta sync sync xstoolsversion as well
2014-03-24 15:48:21 -07:00
2c4ac5e4d3
removed some redundant Boolean isntantiations
...
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-03-22 18:34:45 +01:00
7629d6f129
CLOUDSTACK-6170
2014-03-20 23:54:53 -06:00
a1831bc864
Revert "CLOUDSTACK-6170" due to unit test failure.
...
This reverts commit 50b5e2e247
2014-03-20 16:40:45 -07:00
50b5e2e247
CLOUDSTACK-6170
2014-03-20 16:52:52 -06:00
2b51207510
persist fact that network can span multiple zones, if network offering
...
has strechedL2Subnet capability and return the zones in which
network spans in the networkreponse object
2014-03-20 17:01:33 +05:30
ce1e53f451
Fix style-check issue after cherry-picks
2014-03-18 17:00:08 -07:00
d9506d2a05
Let VMSync be aware of HA take-over on VM state management.
2014-03-18 16:45:45 -07:00
5d19a936a2
CLOUDSTACK-6247: Usage Events - hide them when display flag is off in the context of "Ability to have better control over first class objects in CS" feature
...
Work done for network offering.
2014-03-18 14:00:55 -07:00
7442b56fa8
CLOUDSTACK-6247: Usage Events - hide them when display flag is off in the context of "Ability to have better control over first class objects in CS" feature
...
And when the flag is updated on the resource accordingly generate usage events again.
Also when display flag is false in deployvm cmd it should be false for the volumes associated with the vm as well
2014-03-18 14:00:25 -07:00
e7e4753979
checkstyle: trailing spaces
2014-03-18 12:35:10 +01:00
ed9ed446c2
CLOUDSTACK-5432: potential bugs in case of stop mgt server while
...
template is downloading, template_store_ref has leftover not in ready
state, when create vm from that template, the code doesn't check either
zone id, nor template_store_ref state.
Conflicts:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
2014-03-18 12:20:14 +01:00
d638d04cbf
CLOUDSTACK-6181: Merge of resize root feature (resize-root branch)
2014-03-14 07:17:33 -06:00
ae1d6a771b
Remove IAMEntityType to use existing VO interface class to annotate
...
entityType.
2014-03-17 17:19:55 -07:00
d55c4dd804
CLOUDSTACK-6170
2014-03-14 23:47:20 -06:00
5e4a4e8b34
Fix a regression that caused API job to return prematurely.
2014-03-14 17:31:16 -07:00
ec01791936
Fix the missing java imports from automatic merge
2014-03-14 14:22:23 -07:00
12f7cbcb76
Deal with concurrent state update for VM and Host objects.
2014-03-14 14:07:39 -07:00
4402685e11
Update master to 4.5.0-SNAPSHOT
2014-03-14 14:55:26 +01:00
4399e245f4
A typo that leads to opposite decision on determine whether or not to notify out-of-band VM state changes.
2014-03-13 17:17:15 -07:00
5a75a3e1f9
Give graceful state transition period to live with race-condition on VM startup time
2014-03-13 16:59:56 -07:00
Min Chen
Santhosh Edukulla
Hugo Trippaers
Daan Hoogland
Anthony Xu
Mike Tutkowski
Edison Su
Devdeep Singh
Jayapal
Harikrishna Patnala
Rohit Yadav
Nitin Mehta
Bharat Kumar
Kishan Kavala
Likitha Shetty
Olivier Lemasle
Koushik Das
Alena Prokharchyk
Saksham Srivastava
Sheng Yang
Murali Reddy
Kelven Yang
punith-cloudbyte
Anshul Gangwar
Rajani Karuturi
Prachi Damle
Marcus Sorensen
root
Ding Yuan
Alex Huang
Laszlo Hornyak