Nitin Mehta
a72580def0
CLOUDSTACK-7754: Templates source_template_id is null when it is created from Snapshot with its corresponding volume removed. Fix it by searching for volumes including removed.
...
(cherry picked from commit 287ff83552 )
2014-10-20 16:50:22 -07:00
Hugo Trippaers
9ead2046d4
CID-1240106 Remove unused variable
2014-09-23 11:02:40 +02:00
Nitin Mehta
082aed3d33
CLOUDSTACK-7588: [Vmware] Creating templates (with same names) from volumes get deleted from CS. Fix it by changing the unique name generation to the standard one used by registertemplate. Also cleaned up vmtemplatevo which had too many constructors.
2014-09-19 13:40:17 -07:00
Min Chen
1436ce62b6
CLOUDSTACK-7394:Caller should be owner after creating template from
...
snapshot/volume.
2014-08-21 17:16:13 -07:00
Bharat Kumar
cab2b12d7d
CLOUDSTACK-7155 Re-copying templates to other zones doesn't work
2014-08-21 09:50:54 +05:30
Min Chen
cc8fc746df
CLOUDSTACK-6468:IAM - Templates - Admin user is not allowed to edit
...
template and set isExtractable() paramater.
(cherry picked from commit b6617843d2 )
Signed-off-by: Nitin Mehta <nitin.mehta@citrix.com>
2014-07-08 14:20:45 -07:00
Santhosh Edukulla
97d296bfbd
Fixed Coverity reported performance issues like inefficient string concatenations, wrong boxing or unboxing types, inefficent map element retrievals
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-07-01 22:06:25 +02:00
Harikrishna Patnala
522208dec2
CLOUDSTACK-6869: SSH Public key content is overridden by template's meta data when you create a instance
2014-06-11 17:00:32 +05:30
Nitin Mehta
5393387bbd
CLOUDSTACK-6599:
...
1. Adding the missing Template/Volume URLs expiration functionality
2. Improvement - While deleting the volume during expiration use rm -rf as vmware now contains directoy
3. Improvement - Use standard Answer so that the error gets logged in case deletion of expiration link didnt work fine.
4. Improvement - In case of domain change, expire the old urls
2014-05-30 10:48:42 -07:00
Min Chen
ba848087f8
Disable IAM feature from 4.4 release.
2014-05-22 18:27:08 -07:00
Prachi Damle
9514c9e045
CLOUDSTACK-6349: IAM - No error message presented to the user , when
...
invalid password is provided.
- AccountManager now works using accountId instead of accountType in
following methods too:
- isResourceDomainAdmin()
- isAdmin()
2014-04-28 11:10:50 -07:00
Min Chen
94ebc90877
Remove usage of sameOwner checkAccess invocation, and convert to
...
OperateEntry IAM check.
2014-04-04 16:38:29 -07:00
Min Chen
ae1d6a771b
Remove IAMEntityType to use existing VO interface class to annotate
...
entityType.
2014-03-17 17:19:55 -07:00
Min Chen
48e08fe676
Merge branch 'master' into rbac.
2014-03-06 14:02:20 -08:00
Prachi Damle
187f9cd0a2
iam/plugin: Rename Acl to IAM everywhere
2014-02-25 16:43:23 -08:00
Prachi Damle
f41604fc6c
Renaming AclEntityType --> IAMEntityType
2014-02-25 16:43:17 -08:00
Min Chen
586ee74000
Clean up SecurityChecker.AccessType and modify code to use them
...
consistently.
2014-02-14 11:23:05 -08:00
Daan Hoogland
15fa2ef8df
findbugs: check for system template id == -> equals()
2014-02-14 18:37:47 +01:00
Min Chen
8072e50845
Fixed a bug for listTemplates with TemplateFilter=shared.
2014-02-13 16:47:41 -08:00
Marcus Sorensen
df77c4310a
CLOUDSTACK-6103: Pass VM iso information along with
...
PrepareForMigrationCommand, so that destination hypervisor can
mount pool. This further exposed an issue for KVM where iso
was not getting cleaned up upon successful migration, fixed as well.
2014-02-14 00:34:48 -07:00
Min Chen
3b58a45e04
Merge branch 'master' into rbac.
2014-02-07 13:43:36 -08:00
Min Chen
7c0170e3e9
Hook up IAM update for updateTemplatePermission api.
2014-02-05 16:04:13 -08:00
Alex Huang
7f34282dfa
Removed references to secondarystoragevmmanager from code that doesn't use it.
2014-02-05 01:39:15 +00:00
Prachi Damle
f84375442e
Merge branch 'master' into rbac
...
Conflicts:
api/src/org/apache/cloudstack/api/command/user/autoscale/ListAutoScaleVmProfilesCmd.java
api/src/org/apache/cloudstack/api/command/user/volume/ResizeVolumeCmd.java
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java
server/src/com/cloud/api/ApiServer.java
server/src/com/cloud/api/query/QueryManagerImpl.java
server/src/com/cloud/template/TemplateAdapterBase.java
setup/db/db/schema-430to440.sql
tools/apidoc/gen_toc.py
2014-02-04 12:07:32 -08:00
Alena Prokharchyk
fc56f0cf42
Revert "Findbugs: different issues solved(cherry picked from commit" as it breaks UserVm API Response
...
This reverts commit fae0556021 .
Conflicts:
server/src/com/cloud/dc/DedicatedResourceVO.java
2014-02-03 17:20:28 -08:00
Nitin Mehta
0e2e6995b7
CLOUDSTACK-5997:
...
Template state changes side affects
2014-01-30 17:59:55 -08:00
Daan Hoogland
fae0556021
Findbugs: different issues solved(cherry picked from commit
...
0b13f8e59d )
2014-01-28 16:30:04 +01:00
Min Chen
929fbabaa2
Merge branch 'master' into rbac.
2014-01-17 14:37:08 -08:00
Min Chen
6f800506fd
CLOUDSTACK-5653:S3 object store as Secondary Storage, the template
...
created from different zone is not available for the other zones.
2013-12-26 14:48:21 -08:00
Min Chen
5d262d7b59
CLOUDSTACK-5648:CopyTemplate and CopyISO across zones fails after NFS
...
migration to S3.
2013-12-26 12:39:39 -08:00
Alex Huang
be5e5cc641
All Checkstyle problems corrected
2013-12-12 12:26:07 -08:00
Min Chen
010b007ee4
CLOUDSTACK-5414: With NFS Image Store migrated to S3 an error is thrown
...
in creation of Virtual Router.
2013-12-11 14:17:43 -08:00
Anthony Xu
70c9781e9c
XS VMmetadata platform contains virtual platform related info, CS should save platform info in DB to migrate the VM to other Cluster
...
fixed typo
2013-12-06 01:20:30 -08:00
Anthony Xu
04b48ae04e
XS VMmetadata platform contains virtual platform related info, CS should save platform info in DB to migrate the VM to other Cluster
2013-12-05 01:41:14 -08:00
Nitin Mehta
03c78247cc
CLOUDSTACK-3364:
...
change updateIsoPermissions API to accept isextractable paramter from normal user
2013-12-03 14:55:39 -08:00
Alex Huang
d620df2bdd
Reformatted all of the code.
2013-11-21 06:15:26 -08:00
Alex Huang
8d62744681
Reformat all source code. Added checkstyle to check the source code
2013-11-20 07:26:53 -08:00
Min Chen
ce3638bb03
Merge branch 'master' into rbac.
2013-11-04 15:49:29 -08:00
Min Chen
6eecb0b3b5
CLOUDSTACK-5017: If SSVM is unavailable DownloadCommands will be routed
...
to mgmt server.
2013-11-01 18:07:00 -07:00
Min Chen
2ef4d5200c
Merge branch 'master' into rbac.
2013-10-31 17:16:33 -07:00
Alena Prokharchyk
591dcd1d1c
ResourceDetails: added "display" field to a bunch of VOs - determines whether the detail should be returned to the regular user
2013-10-29 09:18:11 -07:00
Min Chen
6be228a438
CLOUDSTACK-4024:Provide a way to upgrade from existing NFS secondary
...
storage to S3.
2013-10-28 21:01:31 -07:00
Alena Prokharchyk
0fb4d9d5a2
Made all resource details DAOs (nic_details, user_vm_details, template_details, volume_details, service_offering_details) extend from the same base class as although details are being stored in diff tables, those tables have the same structure and same accessors.
2013-10-25 10:56:19 -07:00
Darren Shepherd
f62e28c1ec
New Transaction API
...
Introduction of a new Transaction API that is more consistent with the style
of Spring's transaction managment. The existing Transaction class was renamed
to TransactionLegacy. All of the non-DAO code in the management server has been
updated to use the new Transaction API.
2013-10-16 09:21:00 -07:00
Darren Shepherd
aed5e9dc2a
Add Manage Context framework
...
The managed context framework provides a simple way to add logic
to ACS at the various entry points of the system. As threads are
launched and ran listeners can be registered for onEntry or onLeave
of the managed context. This framework will be used specifically
to handle DB transaction checking and setting up the CallContext.
This framework is need to transition away from ACS custom AOP to
Spring AOP.
2013-10-02 13:09:52 -07:00
Darren Shepherd
efbfae723e
Switch to setter injection for extensibility
...
Various classes are using member injection to inject extensible objects.
Really those object should come from an AdapterList that is injected in.
This patch switches the code to use setter injection that will later allow
spring to inject an AdapterList or something similar to allow
extensibility.
2013-09-30 09:45:07 -07:00
Edison Su
a9aad4f388
add sourcetemplateid for template created from volume/snapshot
...
Conflicts:
server/src/com/cloud/template/TemplateManagerImpl.java
2013-09-25 16:35:31 -07:00
Edison Su
49d8e44491
CLOUDSTACK-4459: one more try, bypass libvirt to find volume if libvirt call failed
...
Conflicts:
server/src/com/cloud/template/TemplateManagerImpl.java
2013-09-25 16:16:10 -07:00
Prachi Damle
aba54356d5
Account_Type Refactoring for Root Admin Role
...
- change the AccountService::isRootAdmin(short) to isRootAdmin(long accountId);
- Change all callers
- Change all places that check the account.getType() directly to call the AccountManagerImpl.
2013-09-24 15:31:09 -07:00
Alex Huang
8f556e6d88
Made changes to configuration. Eliminated ConfigValue and only use ConfigKey
2013-09-06 15:40:38 -07:00
Alex Huang
435e74e914
Commit to try something on removing getZone
2013-09-06 15:40:33 -07:00
Alex Huang
2e5bb63f77
Moved NetworkManagerImpl to NetworkOrchestrator
2013-09-06 15:40:32 -07:00
Min Chen
b67a832f77
CLOUDSTACK-4530:Create Template from a Snapshot fails with unable to
...
find any snapshot ova/ovf when we have multiple secondary storage for a
zone.
2013-08-27 17:15:11 -07:00
Alex Huang
8113ebb08f
Moved the csvtotags into StringUtils. It was there to begin with. No idea who copied it to ConfigurationManager
2013-08-26 20:27:27 -07:00
Alex Huang
abbae2aa87
Fixed the problem with offerings and templates. These two items due to a previous patch all the way back in 2.1.x versions uses the removed column incorrectly. No one fixed since then. Hence, there's a bunch of findbyidincludingremoved calls in the cloudstack code around these two items.
2013-08-26 17:31:10 -07:00
Min Chen
3bd2bbf59d
CLOUDSTACK-3950:Set cross-zone flag in registerTemplate/registerIso in
...
case of region-wide secondary is enabled.
2013-08-20 14:13:49 -07:00
Alex Huang
de2bd96d98
Moved volume related code into cloud-engine-orchestration
2013-08-12 19:06:51 -07:00
Alex Huang
5495f10bce
Revert "Reverting the range of commits that broke the build"
...
This reverts commit b59e3aaefc .
2013-08-08 15:02:40 -07:00
Prasanna Santhanam
b59e3aaefc
Reverting the range of commits that broke the build
...
This reverts commits 30c33415..f6a2c817bc
Signed-off-by: Prasanna Santhanam <tsp@apache.org>
2013-08-08 14:46:56 +05:30
Alex Huang
942f282a6e
Moved config into it's own package
2013-08-07 16:41:02 -07:00
Alena Prokharchyk
a5c2d24ee2
CLOUDSTACK-4087: updateTemplatePermissions - derive domainId from the template owner, not from the operation caller
...
Conflicts:
server/src/com/cloud/template/TemplateManagerImpl.java
2013-08-05 10:39:48 -07:00
Nitin Mehta
f28a28dc77
CLOUDSTACK-3913
...
Private templates would now get copied to only one of image storage chosen randamly as was the case earlier. Dont throw an exception for uploading volumes when there are multiple image stores, instead choose one of them randomly
Signed off by : nitin mehta<nitin.mehta@citrix.com>
2013-08-05 17:43:57 +05:30
Min Chen
151a7ee497
CLOUDSTACK-3861 and CLOUDSTACK-3862: Deprecate old S3/Swift classes.
2013-08-02 18:16:46 -07:00
Alex Huang
8930cfa983
Switched over to use the new jobs framework
2013-08-02 11:07:55 -07:00
Bharat Kumar
65370f31bc
upgrade to ASF 4.2 "cloud" Database Schema Inconsistencies on the Upgraded Setup - Table "volumes"
...
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2013-08-02 17:07:22 +05:30
Edison Su
ae534388c0
CLOUDSTACK-3852: fix upload volume
...
Conflicts:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java
server/src/com/cloud/template/TemplateManagerImpl.java
2013-07-29 11:50:16 -07:00
Min Chen
588efa0150
Fix an incomplete logging message.
2013-07-25 15:47:39 -07:00
Saksham Srivastava
135a2e66c5
CLOUDSTACK-2508: Template usage should report both physical and virtual sizes
2013-07-24 18:17:09 +05:30
Min Chen
67b15ed956
CLOUDSTACK-3639:Unable to create template from snapshot when there are
...
multiple secondary storages in the zone.
2013-07-23 16:56:46 -07:00
Harikrishna Patnala
03fac83180
CLOUDSTACK-3358: create template from a volume/snapshot should also take input from User/Admin whether xstools / vmware tools installed in the VM
...
Signed off by : Nitin Mehta<nitin.mehta@citrix.com>
2013-07-19 11:55:32 +05:30
Min Chen
cb2a84241b
CLOUDSTACK-3513: [Automation] Failed to copy iso and template between
...
zones.
2013-07-17 17:31:50 -07:00
ahuang
11e1e585b1
UserContext switched to CallContext. Added generic storage mechanism for other code to carry information throughout a call. Made the calling User and Account a must have. Added an interface to carry entities in error. Fixed up the code. Part of the vmsync branch
2013-07-16 11:24:21 -07:00
Edison Su
8f4575e877
CLOUDSTACK-3400: add swift support
2013-07-13 02:07:15 -07:00
Harikrishna Patnala
5dd1a1dd8e
CLOUDSTACK-2987: Fixing dynamicallyScalable flag in register and update template API Previuos commit: 7b6b8d7a07 This fix is due to some changes made by the merges after this commit.
...
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2013-07-12 15:19:25 +05:30
Min Chen
d425fa76f7
CLOUDSTACK-3335:[Object_Store_Refactor][Automation]CopyTemplate failed
...
with Unexpected exception.
2013-07-02 18:01:47 -07:00
Mike Tutkowski
99227f7b3e
SolidFire plug-in and related changes
...
SolidFire plug-in
SolidFire plug-in related
2013-06-28 16:59:21 -06:00
Harikrishna Patnala
9385cf0453
CLOUDSTACK-2835: VR Deployement from admin registered template is failing because registered template type is user. Additional parameter "isrouter" in register/update template API for the root admin. True if registered template is of type ROUTING.
...
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2013-06-26 16:00:12 +05:30
Harikrishna Patnala
ec2bf09284
CLOUDSTACK-2794: Global parameter "router.template.id" should be removed The parameter was not in use. We use zone/global coonfigutaion parameters router.template.xenserver/vmware/hyperv/kvm/lxc to deploy router
...
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2013-06-26 15:56:40 +05:30
Min Chen
18aeef3ef1
Merge branch 'master' (up to commit
...
c30d9be3ce ) into object_store.
2013-06-12 11:20:32 -07:00
Min Chen
ec55c2e909
CS-17842: java.lang.NullPointerException seen when using
...
"updateTemplatePermission" with projectids parameter.
2013-06-11 17:07:26 -07:00
Min Chen
ef03d5a122
Move data store specific extract template/iso logic from
...
TemplateManager to data store driver.
2013-06-04 11:50:43 -07:00
Min Chen
e51adc3b7d
CLOUDSTACK-2673: Failed to deploy guest vm using ISO with S3 being the
...
storage provider.
2013-05-29 15:47:39 -07:00
Edison Su
0ed441c690
CLOUDSTACK-2637: fix upload volume
2013-05-24 19:00:52 -07:00
Min Chen
c609bc0541
Not reuse already destroyed entries in template_store_ref to make code
...
cleaner.
2013-05-24 14:34:56 -07:00
Min Chen
9e1a9bfd4b
Fix a bug in attachIsoToVM for S3.
2013-05-24 14:24:23 -07:00
Min Chen
863b534066
Copy iso from S3 to Cache in attach iso to VM.
2013-05-24 13:56:08 -07:00
Min Chen
c614c6a424
CLOUDSTACK-2674: Secondary Storage garbage collector failed with NPE in
...
case of S3 storage provider.
2013-05-24 11:10:45 -07:00
Min Chen
98af424053
Merge branch 'master' into object_store.
2013-05-23 18:00:15 -07:00
Min Chen
d1704a389a
Exclude removed template from template sync.
2013-05-23 17:23:25 -07:00
Prachi Damle
780b45e245
CLOUDSTACK-2657: listTemplatePermissions API should also include the owner of the template to the list of users having permission to launch
...
Changes:
- Add template owner to the list of users
2013-05-23 16:33:07 -07:00
Min Chen
039098469a
CLOUDSTACK-2584: set Format value in CopyCommand.
2013-05-22 14:33:40 -07:00
Min Chen
2af36aa87b
Clean up template_zone_ref entries in case of create template failure.
2013-05-21 12:00:59 -07:00
Min Chen
565bdfb27b
Fix CLOUDSTACK-2525: clean up db entries in vm_template and
...
template_store_ref in case of template creation failure.
2013-05-20 16:21:45 -07:00
Min Chen
255d08ae7c
Fix CLOUDSTACK-2586: ExtractTemplate for S3 template should give URL
...
directly from S3.
2013-05-20 12:06:36 -07:00
Edison Su
f7c1b711ad
merge to master
2013-05-16 23:56:20 -07:00
Mice Xia
6d57393629
instead of using '==', use equals() to test Long value equality
2013-05-16 16:00:02 +08:00
Edison Su
879a954b98
delete snapshot at the backend
2013-05-14 21:58:07 -07:00
Nitin Mehta
c11dbad9c9
merge master
2013-05-11 15:28:43 +05:30
Alex Huang
342624e0eb
Merged with head
2013-05-10 16:33:57 -07:00
Alex Huang
3047929367
Merged
2013-05-10 16:21:43 -07:00