Min Chen
afcf967d24
Revert "CLOUDSTACK-4941:"
...
This reverts commit 231e7c01f2 .
2013-12-18 16:01:37 -08:00
Nitin Mehta
231e7c01f2
CLOUDSTACK-4941:
...
During HA and maintenance call different planners (if the original planners are not able to find capacity) which skip some heurestics
2013-12-18 14:58:37 -08:00
Alex Huang
be5e5cc641
All Checkstyle problems corrected
2013-12-12 12:26:07 -08:00
tuna
f355359b23
fix issues
2013-12-10 10:37:28 +07:00
Nitin Mehta
e79350d256
CLOUDSTACK-3664:
...
scaling up vms was not considering parameter cluster.(memory/cpu).allocated.capacity.disablethreshold. Fixed it
Also added overprovisioning factor retrieval at the cluster level for host capacity check
2013-12-09 15:40:17 -08:00
Kelven Yang
aa72b76aec
CLOUDSTACK-669: put system vm work under new vmsync model
2013-12-06 16:53:11 -08:00
Nitin Mehta
98ee087d31
CLOUDSTACK-4880:
...
check for host cpu capability while dynamic scaling a vm on the same host
2013-12-05 14:31:27 -08:00
Alena Prokharchyk
bd6f706b72
CLOUDSTACK-5261: added support for Alert publishing via ROOT Admin API
...
Conflicts:
engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
engine/storage/image/src/org/apache/cloudstack/storage/image/TemplateServiceImpl.java
engine/storage/volume/src/org/apache/cloudstack/storage/datastore/provider/DefaultHostListener.java
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/discoverer/HypervServerDiscoverer.java
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java
server/src/com/cloud/alert/AlertManagerImpl.java
server/src/com/cloud/alert/ConsoleProxyAlertAdapter.java
server/src/com/cloud/alert/SecondaryStorageVmAlertAdapter.java
server/src/com/cloud/configuration/ConfigurationManagerImpl.java
server/src/com/cloud/ha/HighAvailabilityManagerExtImpl.java
server/src/com/cloud/ha/HighAvailabilityManagerImpl.java
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
server/src/com/cloud/resourcelimit/ResourceLimitManagerImpl.java
server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java
server/src/com/cloud/vm/UserVmManagerImpl.java
usage/src/com/cloud/usage/UsageAlertManagerImpl.java
usage/src/com/cloud/usage/UsageManagerImpl.java
listAlerts: introduced new parameter "name" to the alertResponse
Conflicts:
api/src/org/apache/cloudstack/api/command/admin/resource/ListAlertsCmd.java
server/src/com/cloud/alert/AlertManagerImpl.java
usage/src/com/cloud/usage/UsageAlertManagerImpl.java
Added new Admin API - generateAlert. Available to ROOT admin only
Conflicts:
api/src/org/apache/cloudstack/alert/AlertService.java
api/src/org/apache/cloudstack/api/BaseCmd.java
usage/src/com/cloud/usage/UsageAlertManagerImpl.java
listAlerts: implemented search by alert name
Conflicts:
api/src/org/apache/cloudstack/alert/AlertService.java
api/src/org/apache/cloudstack/api/command/admin/resource/ListAlertsCmd.java
engine/schema/src/com/cloud/alert/AlertVO.java
2013-12-04 10:05:46 -08:00
Bharat Kumar
e5cfe94818
CLOUDSTACK-5160 add a map to specify the custom compute parameters in the deployvm api.
...
Signed-off-by: Jayapal <jayapal@apache.org>
2013-12-04 11:28:45 +05:30
Devdeep Singh
5a96307fbf
Changes for allowing migration of a vm on hyperv. Migration was blocked in cloudstack for hyperv.
...
Enabled it. Also updated the agent code to allow hyperv migration.
2013-12-04 10:29:36 +05:30
Nitin Mehta
d5e497859f
CLOUDSTACK-4881:
...
changeServiceForVirtualMachine API should be used to scale up a stopped vm only
2013-12-02 17:27:13 -08:00
Bharat Kumar
68406ba29d
CLOUDSTACK-5161 enable scaling of a vm using custom offering
...
Signed-off-by: Koushik Das <koushik@apache.org>
2013-11-29 17:53:33 +05:30
Wei Zhou
f17f35eeb8
CLOUDSTACK-5293: fix issue when collect vm disk statistics from iso
2013-11-27 14:38:25 +01:00
Nitin Mehta
6bea532efa
CLOUDSTACK-5206: Ability to control the external id of first
...
class objects. Putting in the generic methods and trying it
for objects like vm, volume. This is the first cut
2013-11-26 09:52:17 -08:00
Bharat Kumar
ef40e156ed
CLOUDSTACK-5162 Usage details are not getting populated when using dynamic offerings.
...
Signed-off-by: Koushik Das <koushik@apache.org>
2013-11-26 14:32:30 +05:30
Alex Huang
d620df2bdd
Reformatted all of the code.
2013-11-21 06:15:26 -08:00
Alex Huang
224f479974
Removed trailing spaces
2013-11-21 04:08:01 -08:00
Prachi Damle
e0d2423f06
Refactoring account_type for Domain_Admin and Normal_User types
2013-11-20 16:53:59 -08:00
Alex Huang
8d62744681
Reformat all source code. Added checkstyle to check the source code
2013-11-20 07:26:53 -08:00
Hugo Trippaers
f00bfea61e
Fix CID 1127030, 1127029 Questionable Boxing of primitive value
...
Fix CID 1127028 Fix Inefficient Map Iterator
Fix bug.
2013-11-07 14:59:03 +01:00
Hugo Trippaers
9631df8d0e
Fix CID 1127021 Operands don't affect results
...
int can never be bigger than maxint.
Auto unboxing of Integer, not need for intValue()
2013-11-07 13:34:48 +01:00
Hugo Trippaers
f611c24dd5
Fix CID 1127027 Dereference before null check
...
template can't be null at this point as it has already been dereferenced
2013-11-07 13:34:48 +01:00
Bharat Kumar
7095ea2b5e
CLOUDSTACK-4738 Dynamic compute offering.
...
Signed-off-by: Koushik Das <koushik@apache.org>
2013-11-07 12:41:20 +05:30
Alena Prokharchyk
6d7674982a
CLOUDSTACK-4979: fix hostName for VmWare vms to follow the same logic
2013-11-06 16:16:25 -08:00
Alena Prokharchyk
fac22936f6
CLOUDSTACK-4979: if no hostName is passed to deployVm call, automatically generated hostName follows the pattern <instance.id global config>-<randomly generated uuid>.
...
Example: VM-a6c6457e-e4d0-486f-a392-9239be9b36f5
2013-11-06 15:46:57 -08:00
Min Chen
ce3638bb03
Merge branch 'master' into rbac.
2013-11-04 15:49:29 -08:00
Min Chen
2ef4d5200c
Merge branch 'master' into rbac.
2013-10-31 17:16:33 -07:00
Edison Su
c5bec6b336
add quiescevm in createvmsnapshotcmd
2013-10-31 16:45:05 -07:00
Wei Zhou
382391f270
CLOUDSTACK-4987: only shared network and isolated network with same account can be assigned to a VM
...
(cherry picked from commit 743eed8771 )
2013-10-31 11:37:31 +01:00
Alena Prokharchyk
591dcd1d1c
ResourceDetails: added "display" field to a bunch of VOs - determines whether the detail should be returned to the regular user
2013-10-29 09:18:11 -07:00
Likitha Shetty
cc4b612bf6
CLOUDSTACK-4985. NPE while deleting old root volumes of a restored VM during storage garbage collection.
...
In case of VMware, once the state of the old root volume has been updated to destroyed force expunge it from primary storage to avoid the garbage collector from trying to delete the new root volume
2013-10-29 11:31:45 +05:30
Edison Su
70b2c0150d
rebase to spring changes
2013-10-25 18:15:36 -07:00
Edison Su
51a8086cf6
Merge branch 'pluggable_vm_snapshot'
...
Conflicts:
client/tomcatconf/applicationContext.xml.in
engine/storage/integration-test/test/org/apache/cloudstack/storage/test/SnapshotTest.java
engine/storage/integration-test/test/resources/storageContext.xml
server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java
server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java
2013-10-25 16:47:17 -07:00
Edison Su
a6ce66e55a
move a lot of code into vmsnapshot strategy
...
fix compile
fix compile
add vm_snapshot_details table in db
add vmsnapshot test cases
2013-10-25 15:09:04 -07:00
Wei Zhou
059e3beb28
CLOUDSTACK-4505: add ExpungeVM command to expunge a destroyed VM on demand
2013-10-24 11:52:00 +02:00
Darren Shepherd
205a77a5bb
Merge remote-tracking branch 'origin/txn-refactor'
...
Conflicts:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
server/src/com/cloud/configuration/ConfigurationManagerImpl.java
server/src/com/cloud/metadata/ResourceMetaDataManagerImpl.java
server/src/com/cloud/vm/UserVmManagerImpl.java
2013-10-23 10:40:44 -07:00
Darren Shepherd
edeaf98117
Cleaner and more type safe Transaction API for checked exceptions
2013-10-23 10:02:43 -07:00
Anthony Xu
e33ae74067
CLOUDSTACK-4649:
...
xs 6.1/6.2 introduce the new virtual platform, so there are two virtual platforms, windows PV driver version must match virtual platforms,
this patch tracks PV driver versions in vm details and template details.
Anthony
2013-10-22 17:54:51 -07:00
Alena Prokharchyk
25d6e6ec66
CLOUDSTACK-4894: DestroyVirtualMachine API - added "expunge" admin-only parameter. When passed as true, the vm gets expunged immediately (false by default to preserve the initial command behavior)
...
Conflicts:
api/src/org/apache/cloudstack/api/ApiConstants.java
api/src/org/apache/cloudstack/api/command/user/vm/DestroyVMCmd.java
2013-10-21 11:11:42 -07:00
Darren Shepherd
f62e28c1ec
New Transaction API
...
Introduction of a new Transaction API that is more consistent with the style
of Spring's transaction managment. The existing Transaction class was renamed
to TransactionLegacy. All of the non-DAO code in the management server has been
updated to use the new Transaction API.
2013-10-16 09:21:00 -07:00
Min Chen
f59e47b263
Clean up ListVMsCmd implementation to not using Criteria class.
2013-10-08 15:11:56 -07:00
Darren Shepherd
aed5e9dc2a
Add Manage Context framework
...
The managed context framework provides a simple way to add logic
to ACS at the various entry points of the system. As threads are
launched and ran listeners can be registered for onEntry or onLeave
of the managed context. This framework will be used specifically
to handle DB transaction checking and setting up the CallContext.
This framework is need to transition away from ACS custom AOP to
Spring AOP.
2013-10-02 13:09:52 -07:00
Alena Prokharchyk
b253d95de9
UpdateVirtualMachine: code cleanup - got rid of warnings and unused code from the method; extracted part of the code to its separate method.
2013-09-30 15:34:56 -07:00
Prachi Damle
aba54356d5
Account_Type Refactoring for Root Admin Role
...
- change the AccountService::isRootAdmin(short) to isRootAdmin(long accountId);
- Change all callers
- Change all places that check the account.getType() directly to call the AccountManagerImpl.
2013-09-24 15:31:09 -07:00
Laszlo Hornyak
88954053c3
do not instantiate Long just for toString
...
replaced Long object instantiation with static call to Long.toString in case it was only to generate a string
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2013-09-19 16:58:59 +02:00
Kelven Yang
832db1b398
Apply https://reviews.apache.org/r/14084/
2013-09-17 16:29:48 -07:00
Alex Huang
1f5699b29f
Fixed unit tests
2013-09-06 15:40:39 -07:00
Alex Huang
8f556e6d88
Made changes to configuration. Eliminated ConfigValue and only use ConfigKey
2013-09-06 15:40:38 -07:00
Alex Huang
b8e79c30a8
Compile complete
2013-09-06 15:40:37 -07:00
Alex Huang
435e74e914
Commit to try something on removing getZone
2013-09-06 15:40:33 -07:00
Alex Huang
2e5bb63f77
Moved NetworkManagerImpl to NetworkOrchestrator
2013-09-06 15:40:32 -07:00
Alex Huang
8e5249df62
Moved NetworkManager to NetworkOrchestrationService
2013-09-06 15:40:31 -07:00
Kelven Yang
9a2148ffc3
CLOUDSTACK-3886: check in for review request https://reviews.apache.org/r/13008/
2013-09-04 14:49:45 -07:00
Prachi Damle
ef22b42b38
CLOUDSTACK-4221: Dedicated Resources: changes to associate the dedicated resource with the 'ExplicitDedication' affinity group
...
Changes:
- Implict creation of the 'ExplicitDedication' Affinity group during resource dedication
- Only one group per account or per domain will be present
- ListDedicatedResources by affinityGroup
- Deployment should consider dedicated resources associated to the group only
- Deleting affinity group should release the dedicated resouces
- Releasing the dedicated resources should remove the group associated if there are no more resources.
Conflicts:
plugins/dedicated-resources/src/org/apache/cloudstack/dedicated/DedicatedResourceManagerImpl.java
plugins/dedicated-resources/test/org/apache/cloudstack/dedicated/manager/DedicatedApiUnitTest.java
server/src/com/cloud/configuration/ConfigurationManagerImpl.java
2013-09-03 20:02:38 -07:00
Prachi Damle
a06bd9fa2b
CLOUDSTACK-4168 Root Admin should be able to create 'ExplicitDedication' affinity group at domain level and make it available for all accounts in the domain
...
Changes:
- 'ExcplicitDedication' type of group can be created/deleted by Root admin only
- Users can no longer create this type of affinity group
- RootAdmin can create this type of affinitygroup at domain level. Such a domain level group is available for all accounts in that domain for listing and for use during deployVM.
- The domain level affinitygroup should be visible to the users in that domain, domain admins and Root admin.
Conflicts:
server/src/com/cloud/api/query/QueryManagerImpl.java
server/src/org/apache/cloudstack/affinity/AffinityGroupServiceImpl.java
server/test/org/apache/cloudstack/affinity/AffinityApiUnitTest.java
2013-09-03 20:02:34 -07:00
Chip Childers
bf967eb622
Updating datetime format of events to include the timezone
2013-09-03 12:45:01 -04:00
Chip Childers
14ee684ce3
Adding eventDateTime to all event generation locations
2013-09-03 11:34:56 -04:00
Wei Zhou
65c1c986da
CLOUDSTACK-1192: fix collectVmDiskStatistics issue when stopping a vm
2013-09-03 11:45:34 +02:00
Wei Zhou
a16fd4781c
CLOUDSTACK-4566: fix incorrect values in resource_count table for resource limitation
...
There are three issues in resource_count table
(1) expunge a vm, the public_ip decreases and becomes -1 in basic zone.
(2) recover a vm, the volume increase.
(3) restore a vm, the volume decrease.
2013-09-02 16:56:34 +02:00
Prachi Damle
af175d8c65
CLOUDSTACK-4528 [Vmware] new mapping vmware datacenter cloudstack zone - Virtual Router host migration across cluster FAIL
...
Change:
- Also add a check in migrateSystemVM API to check that source and destination host are in the same cluster
2013-08-28 17:03:24 -07:00
Alex Huang
abbae2aa87
Fixed the problem with offerings and templates. These two items due to a previous patch all the way back in 2.1.x versions uses the removed column incorrectly. No one fixed since then. Hence, there's a bunch of findbyidincludingremoved calls in the cloudstack code around these two items.
2013-08-26 17:31:10 -07:00
Alex Huang
494ea5052f
Made IpAddressManager a manager
2013-08-19 14:13:31 -07:00
Alex Huang
564502abd7
Moved the virtualmachine implementation into engine/orchestration
2013-08-19 14:13:28 -07:00
Alex Huang
4ba359c3fe
Moved VirtualMachineManager into engine
2013-08-19 14:13:28 -07:00
Bharat Kumar
15c93ba9b7
=CLOUDSTACK-4068 scaling up user vm and system vm is failing with NPE if current service offering is deleted
...
Nitin Mehta <nitin.mehta@citrix.com>
2013-08-16 17:27:00 +05:30
Nitin Mehta
088ce975c6
CLOUDSTACK-4313
...
Wrong error message is throwing on failure of dynamic scale up operation. Fix it.
Signed off by : nitin mehta<nitin.mehta@citrix.com>
2013-08-16 13:03:42 +05:30
Alena Prokharchyk
b727001f48
CLOUDSTACK-4315: VPC - when fail to add nic to the VR, a) remove the nic b) remove the reference to nic from router_network_ref table. Before the fix b) was missing, and it caused NPEs when tried to apply the rules on the routers not having nic in the network
...
Conflicts:
server/src/com/cloud/network/element/VirtualRouterElement.java
server/src/com/cloud/vm/VirtualMachineManagerImpl.java
2013-08-14 11:44:34 -07:00
Edison Su
c58f15d867
CLOUDSTACK-4222: use new volume object in case of migrate volume
2013-08-13 15:16:45 -07:00
Wido den Hollander
227509be46
Remove .java.orig file
...
Left over from somebodies editor?
2013-08-13 16:25:09 +02:00
Alex Huang
de2bd96d98
Moved volume related code into cloud-engine-orchestration
2013-08-12 19:06:51 -07:00
Alex Huang
5495f10bce
Revert "Reverting the range of commits that broke the build"
...
This reverts commit b59e3aaefc .
2013-08-08 15:02:40 -07:00
Bharat Kumar
5f2f5181e9
CLOUDSTACK-4083 if a failure occurs while adding VM to another network (this should be the first vm in the subnet). The ip alias created as a part of this process is not removed.
...
Signed-off-by: Sheng Yang <sheng.yang@citrix.com>
2013-08-08 10:31:15 -07:00
Prasanna Santhanam
b59e3aaefc
Reverting the range of commits that broke the build
...
This reverts commits 30c33415..f6a2c817bc
Signed-off-by: Prasanna Santhanam <tsp@apache.org>
2013-08-08 14:46:56 +05:30
Alex Huang
5161ded69c
Removed the configuration parameters from Config.java
2013-08-07 16:41:05 -07:00
Alex Huang
942f282a6e
Moved config into it's own package
2013-08-07 16:41:02 -07:00
Chiradeep Vittal
d8a5f03c7f
Revert "Starting the work of moving orchestration pieces to engine"
...
This reverts commit 7a2aaf96fd .
2013-08-02 15:09:29 -07:00
Alex Huang
7a2aaf96fd
Starting the work of moving orchestration pieces to engine
2013-08-02 13:51:48 -07:00
Alex Huang
8930cfa983
Switched over to use the new jobs framework
2013-08-02 11:07:55 -07:00
Bharat Kumar
80e2934bb7
fix to add the the overcommit details of the vms in uservm details table when decreasing the overcommit to one.
...
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2013-08-02 19:09:26 +05:30
Bharat Kumar
65370f31bc
upgrade to ASF 4.2 "cloud" Database Schema Inconsistencies on the Upgraded Setup - Table "volumes"
...
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2013-08-02 17:07:22 +05:30
Alena Prokharchyk
a3b86573b9
CLOUDSTACK-4020: lock nic entry in releaseNic method. Otherwise multiple threads can try to release the same nic at the same time, and it will lead to NPEs and backend failures
...
Conflicts:
server/src/com/cloud/network/NetworkManagerImpl.java
server/src/com/cloud/vm/VirtualMachineManagerImpl.java
2013-08-01 16:19:10 -07:00
Mice Xia
51e4f597e0
fix CLOUDSTACK-3591 add usage recording for VM snapshots
...
Conflicts:
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java
setup/db/db/schema-410to420.sql
2013-08-01 10:47:36 +08:00
Bharat Kumar
980b227817
recalculate the capacity after overcomit change.
...
Conflicts:
server/src/com/cloud/capacity/CapacityManager.java
server/src/com/cloud/capacity/CapacityManagerImpl.java
server/src/com/cloud/resource/ResourceManagerImpl.java
server/src/com/cloud/vm/VirtualMachineManagerImpl.java
2013-07-31 18:39:14 +05:30
Harikrishna Patnala
2c53ede1de
CLOUDSTACK-3848: Usage events for dynamic scaling of cpu/ram operation on VM
2013-07-31 15:07:17 +05:30
Alex Huang
1e1ee902a2
Moved over the new jobs framework from vmsync. This has not been integrated into the server package yet. Will do that next
2013-07-30 15:00:58 -07:00
Prasanna Santhanam
34e751fb8d
simulator supports migration
...
Add simultor to the seemingly strict filter which should happen within
the hypervisor resource and not the virtualmachine :/
Signed-off-by: Prasanna Santhanam <tsp@apache.org>
(cherry picked from commit 3d4d350dbe )
2013-07-30 11:25:14 +05:30
Alena Prokharchyk
4c0053fb2d
CLOUDSTACK-3909: deployVM API - validate hypervisorType parameter when the vm is being deployed from ISO
2013-07-29 11:16:39 -07:00
Harikrishna Patnala
2f369973e2
CLOUDSTACK-3779: Support System vm scaling on VMWare
...
Marked the system template new system template as dynamicallyScalable
- handled upgrade case
- moved "dynamicallyScalable" flag to vm_instance table from user_vm_details to support dynamic scaling of system vm
Signed off by : Nitin Mehta<nitin.mehta@citrix.com>
2013-07-29 15:25:07 +05:30
Harikrishna Patnala
8ef097ef6e
CLOUDSTACK-3669: Bringing down the dynamic scalable check (for VM whether it has xstools or vmware tools in it) to the management layer.
...
Signed off by : Nitin Mehta <nitin.mehta@citrix.com>
2013-07-29 15:16:21 +05:30
Harikrishna Patnala
a8ad908666
CLOUDSTACK-3703: change service offering of stopped vm on
...
Conflicts:
server/test/com/cloud/vm/UserVmManagerTest.java
2013-07-27 19:52:30 +05:30
Alex Huang
395cbcc023
Move the rest of the generics out of virtualmachinemanager
2013-07-25 19:00:25 -07:00
Nitin Mehta
1f64354ec8
CLOUDSTACK-3712
...
Use Vminstance instead of user vm for scaling stopped vms.
Signed off by : nitin mehta<nitin.mehta@citrix.com>
2013-07-25 14:58:42 +05:30
Bharat Kumar
e14f5d0aeb
Cloudstack-3694 Dnsmasq rewrite in bash
...
(Sheng: Fix typo, fix log and error message, remove 'set -x' in script)
Signed-off-by: Sheng Yang <sheng.yang@citrix.com>
2013-07-24 14:00:31 -07:00
Alex Huang
e99a1ef1d9
Moved the rest of VirtualMachineManager to be vm agnostic
2013-07-23 18:24:59 -07:00
Alex Huang
9bc5870f01
Removed the remove method. Not sure why we added to VirtualMachineManager
2013-07-23 18:24:58 -07:00
Alex Huang
3ae0acc26f
Forgot to save something in VirtualMachineManager
2013-07-23 18:24:58 -07:00
Alex Huang
861be3063c
Simplify the components that VirtualMachineManager uses
2013-07-23 18:24:57 -07:00
Wei Zhou
9985a895a4
CLOUDSTACK-3734: remove wrong break in 'for' block in VirtualMachineManagerImpl.java
2013-07-23 17:37:39 +02:00
Saksham Srivastava
89b94bb754
CLOUDSTACK-3382. Alert should be raised if a vm is migrated from dedicated to non-dedicated resource and vice versa.
...
Alerts are generated for VM migration between:
1) Source host is dedicated and destination host is not.
2) Source host is not dedicated and destination host is dedicated.
3) Both hosts are dedicated to different accounts/domains
2013-07-23 13:38:14 +05:30
Alex Huang
51377c40f2
Forgot to populate a method to called advanceStop
2013-07-22 20:06:05 -07:00