Commit Graph

67 Commits

Author SHA1 Message Date
Likitha Shetty ff72492c01 CS-15031. ec2-describe-instances, provide support for group-id filter. 2012-05-22 11:10:27 +05:30
prachi 1c1c663e34 CS-14661: Error handling should be imporved
Changes:
- Read the HttpURLConnection responseMessage.
- If not found check if there is "X-Description" header that gives out a message
- if not use a default error string with status code.
2012-05-21 18:28:44 -07:00
Likitha Shetty 52351b14a0 CS-14970. "java.lang.NumberFormatException" seen when ec2-describe-groups used to list ingress rules
and if any of the icmp rules has a type or code of value '-1'.
Update EC2GroupFilterSet to match the filter values with a regular expression and not an integer.
2012-05-18 15:31:18 +05:30
Likitha Shetty 691b9a471c CS-14966. When a group has no ingress rules ec2-describe-group does not list this group. 2012-05-18 15:31:18 +05:30
prachi 6d4c6a4f6b CS 14640: Output of ec2-describe-instances should provide security group,private ipaddress, ipaddress and hypervisor information.
Changes:
- Fixed setting multiple group
-removed EBS
2012-05-17 17:26:36 -07:00
Likitha Shetty dc37a8acfe CS-14747: ec2-describe-group. Update EC2GroupFilterSet to reduce the iteratons made
ipPermissionFilterMatched() to match the filter.
2012-05-17 11:32:42 +05:30
Likitha Shetty c45a0b4560 CS-14638. ec2-run-instances, not setting the attach-time for volume in the reponse. 2012-05-15 16:54:14 +05:30
Likitha Shetty 91bde4f926 CS-14732. ec2-revoke: Revoking an ingress rule relatng one cidr results in revoking
an ingress rule pointing to a different cidr, when the protocol and port are the same.
Resolved. In the request set the cidr correctly.
2012-05-15 16:37:50 +05:30
Likitha Shetty 52df9da27c CS-14747: ec2-describe-group. When multiple filters are used, if the group contains filter values across
different ingress rules the group gets returned.
Resolved. Filter matching updated to return a group only if any one rule matches all ip-permission* filters.
2012-05-15 16:37:50 +05:30
Chiradeep Vittal 1edd57f276 Revert "Temporarily ignoring auth"
This reverts commit 7058988839c66ad273aa2bee01a68bbf2deba105.
2012-05-14 16:09:43 -07:00
Chiradeep Vittal 8f4ee3c2a1 Dont proceed if the object is not found 2012-05-14 16:09:43 -07:00
Chiradeep Vittal 362150b968 Rollback in case of exception 2012-05-14 16:09:43 -07:00
Chiradeep Vittal 99cae6e025 Handle listing of non-existing buckets 2012-05-14 16:09:42 -07:00
Chiradeep Vittal 86faa539e4 Format ListAllBuckets properly (or the buggy way AWS does it) 2012-05-14 16:09:42 -07:00
Chiradeep Vittal 5188c52294 409 conflict whenever bucket already exists to match AWS S3 2012-05-14 16:09:42 -07:00
Chiradeep Vittal 1424ec34b5 ignore signature 2012-05-14 16:09:42 -07:00
Chiradeep Vittal 37f6f77796 compile fixes 2012-05-14 16:09:42 -07:00
Chiradeep Vittal e8ac504a3e Temporarily return 404 instead of 400 for HEAD 2012-05-14 16:09:42 -07:00
Chiradeep Vittal fb35aa39c5 fake bucket location 2012-05-14 16:09:42 -07:00
Chiradeep Vittal f5d55d4520 load bucket location constraint class 2012-05-14 16:09:41 -07:00
Chiradeep Vittal af712d1482 Fake HEAD with GET temporarily 2012-05-14 16:09:41 -07:00
Chiradeep Vittal 66849fe02e Temporarily ignoring auth 2012-05-14 16:09:40 -07:00
prachi e3cf8a6140 CS-14856: upgrade script:schema-2214to30.sql fails while upgrading CS 2.2.14 to Bonita
http://bugs.cloudstack.org/browse/CS-14856

- Problem is with the awsapi webapp being loaded first in tomcat before cloudstack webapp. There is no way this order can be controlled.

- We are not supporting upgrades for awsapi feature

- The solution is awsapi will check if the db exists during initialization. If not, the webapp will fail to load. Error loading the webapp can be seen in the catalina.out output.

- But this should not affect CloudStack db upgrade.
2012-05-14 15:39:15 -07:00
Likitha Shetty 14902a0bf7 CS-14731. Not able to revoke ingress rule, when there are multiple rules pointing to the same port and CIDR.
Resolved.
2012-05-14 17:37:14 +05:30
Likitha Shetty c4f258fa82 CS-14728. ec2-revoke: Not able to revoke the icmp rules. Presented with "Server.InternalError:Cannot find matching ruleid"
Resolved. ICMP type and code was not correctly set in the request.
2012-05-14 17:37:14 +05:30
Rajesh Battala 9f7d218698 removed TODO comment 2012-05-13 22:32:14 +05:30
Rajesh Battala f51cdd61f2 Implemented Multi Object Delete feature for S3 2012-05-13 22:26:43 +05:30
prachi 1b806e3713 CS 14640 - Output of ec2-describe-instances should provide security group,private ipaddress, ipaddress and hypervisor information.
Changes:
- fixed response.
2012-05-11 18:59:57 -07:00
prachi f5363e4c51 CS- 14640 Output of ec2-describe-instances should provide security group,private ipaddress, ipaddress and hypervisor information.
Changes:
- Fixed response of describe Instances
2012-05-11 18:59:55 -07:00
prachi 1a81acd232 CS-14827: ec2-start-instances and ec2-stop-instances - When we try to start an instance that is already in "Running" state / try to stop an instance that is in "Stopped" state , API returns nothing.
Changes:

Adding the instance previous and current state to resposne; both states will be same.
2012-05-11 16:44:05 -07:00
prachi 1f5e68d96f CS-14828: ec2-terminate-instance - When trying to terminate/start/top/reboot an instance that is already terminated , we get an error - "Server.InternalError: Instance:cffab230-b3c1-478b-b44a-6a603c5673ed not found"
Changes:

Changed error message.
2012-05-11 16:25:24 -07:00
Likitha Shetty 48d1191fef CS-14742. When icmp rules are listed type and code is always shown as 0.
Not able to use filters "ip-permission.from-port" and "ip-permission.to-port" for listing icmp ingress rules.
Resolved.
2012-05-11 17:35:33 +05:30
Likitha Shetty 41aba7872d CS-14638, Output of ec2-run-instances should provide security group, private address and ipaddress information. 2012-05-11 14:27:06 +05:30
Likitha Shetty 51963ef03d CS-14727 ec2-describe-group. When a group has an account based ingress rule, we see and additional CIDR entry with no CIDR being returned.
Resolved. Update the response of DescribeSecurityGroup.
reviewed by: prachi
2012-05-11 10:25:18 +05:30
prachi ba4f35add6 CS-14684 - ec2-describe-instances - Not able to use ip-address filter to list an instance with the provided ip-address.
Changes:
- awsapi was using a wrong name for the public ip field in response, so the ip address was not getting parsed out of the json response.
2012-05-10 16:50:32 -07:00
prachi da520dfe21 awsapi - EIP related changes 2012-05-10 15:58:30 -07:00
Likitha Shetty 26f9cc6475 CS-14632 Not able to deploy VM in security groups using -g option for ec2-run-instances
Resolved. Updated the request and response for ec2-run-instances to
deploy VM in multiple security groups and output the corresponding security groups.
reviewed by: Prachi
2012-05-10 11:54:45 +05:30
prachi 96dffa2155 CS-14837 [ec2-describe-snapshots] Unable to find responseObjName:[snapshot]. Returning null! Exception: java.lang.NumberFormatException: For input string: <job-id>
- Changing JobId to String since CS 3.0.x uses String Ids now.
2012-05-09 23:20:51 -07:00
Rajesh Battala 44f3846168 Modified S3RestServlet to turn down request if enable.s3.api is false. Changed upgrade script for S3 API Feature 2012-05-09 15:25:39 +05:30
prachi 82af66cc5d CS-14704 ec2-describe-keypairs - Not able to list the keypairs.
Changes:
- Response name that awsapi looks for was wrong.
- Filter matching improved.
2012-05-08 17:46:49 -07:00
prachi 48573deb1f Change in awsapi to get Default Zone for the account during runInstances, CreateVolume etc.
- If zoneName is specified we use that
- If not, we choos the default zone marked for the account
- If no such default zone is found, fall back to choosing the first available zone.
2012-05-08 15:50:58 -07:00
JohnZ 2242ec0ca3 Correction to cloud-bridge-register and S3RestServlet to use parameter Action in POST 2012-05-08 17:54:53 +01:00
Likitha Shetty 9228a70913 Changes in CloudBridge to lookup defaultZoneId(marked for an account) from CloudStack DB.
reviewed by: Prachi
2012-05-08 13:10:29 +05:30
prachi 0ca7bbe89f CS-14682 - When invalid filter name is provided in ec2-describe-instances command , java.lang.reflect.InvocationTargetException is thrown.
Changes:
- AxisFault was not being constructed in some cases
2012-05-07 17:21:15 -07:00
prachi 4c163bfab0 CS-14687: When a valid instance id that does not belong to the current user is passed to ec2-stop-instances,ec2-start-instances,ec2-terminate-instances, api does not return anythin
Changes:
Throw error if LookUpInstances fails to list the Vm by id.
2012-05-07 16:07:06 -07:00
prachi da884e18ef CS-14775: When trying to vms when there is enough capacity for only Vms between the min and max range , we donot respect the min count.
Changes:

Deploy minimum instances if the max allowed is less than the specified max. number in the request.
2012-05-07 14:31:50 -07:00
prachi dcbd098ab0 CS-14777- Not able to retrieve password of a VM using ec2-get-password command.
Resolved. The response parsing in awsapi was broken.
2012-05-07 12:43:11 -07:00
prachi 31bf4eb426 EC2 API fidelity: Implement support for image attribute - launchPermission
Now SOAP EC2 API supports launchPermission attribute for following commands:
- ec2-describe-image-attribute
- ec2-modify-image-attribute
- ec2-reset-image-attribute

Note:
- REST API is not changed.
- ec2 tools have some validation for userId to be AWS account id (8 digits). SO its is not possible to test adding or removing individual userIds in  ec2-modify-image-attribute command.
2012-05-07 11:40:09 -07:00
prachi 43f0d0df35 Logging related Changes overwritten by S3 Merger
Also did changes to not log the hibernate SQL
2012-05-07 11:40:01 -07:00
prachi 01fdcd5d00 Changes overwritten by S3 Merge 2012-05-03 16:45:19 -07:00