Commit Graph

56 Commits

Author SHA1 Message Date
Prachi Damle ee90ebfc00 CLOUDSTACK-1128: [EC2 Query API] DescribeAvailabilityZones, support for message filter
Add message in the response element of EC2DesrcibeAvailibilityZones. Add support for filter 'message'.
The value of 'message' should be set to the allocation_state of the zone
Code cleanup
2013-02-12 13:45:29 -08:00
Likitha Shetty 961c8ee365 CLOUDSTACK-1127: [EC2 Query API] DescribeSecurityGroups, support for additional filters
Add support for filters ip-permission.group-name and ip-permission.user-id
2013-02-12 13:45:26 -08:00
Likitha Shetty 2a565d4dc8 CLOUDSTACK-1126: [EC2 Query API] RunInstances ignores the UserData input parameter
When EC2RunInstances is called with UserData parameter, the parameter is not propogated to CS
2013-02-12 13:45:24 -08:00
Likitha Shetty 203fb466de CLOUDSTACK-1136: [EC2 Query API] AssociateAdress, DisassociateAddress and ReleaseAddress fail with NPE
When invalid parameter is provided as input for any of these API's we get an NPE
2013-02-11 12:08:03 -08:00
Likitha Shetty d592ea10bd CLOUDSTACK-1124 [EC2 Query API] Improve the logging. Having empty response objects is harmless to functionality
This is observed in the awsapi.log for all Describe* EC2 commands when the response object returned by CS has no elements. But with EC2DescribeImages command it is always observed. This is because every time DescribeImage is fired, we call CS listTemplates command multiple times, each time setting a different value for the templateFilter parameter (e.g. featured, executable, community etc.). And for some of these CS calls made we obtain am empty response and hence the message in the logs.
2013-02-11 11:59:40 -08:00
Likitha Shetty 1fbda5d177 CLOUDSTACK-1112 [EC2 Query API] DescribeSnapshots fails, when an invalid 'snapshotId' parameter is provided 2013-02-11 11:40:07 -08:00
Likitha Shetty b1d0d8d5f9 CLOUDSTACK-1121: [EC2 Query API] RunInstances, instance is always deployed in the default security group
During EC2RunInstances, even if the security group the instance is to be deployed in specified the instance gets deployed in the default security group
2013-02-11 11:24:06 -08:00
Likitha Shetty e63fc4c0cb CLOUDSTACK-1120 [EC2 Query API] Parameter 'keynames' is not honoured by DescribeKeyPairs
When EC2DesribeKeyPairs is called with filter 'keynames' it ignored the key-name provided and lists all the key-pairs
2013-02-11 11:23:53 -08:00
Likitha Shetty 1884f518a3 CLOUDSTACK-1119 [EC2 Query API] Add filter support for DecsribeAddresses
EC2DescribeAddresses doesn't have filter support.
Support will be available for filters -> instance-id and public-ip
2013-02-07 18:33:59 -08:00
Likitha Shetty 40d1fe1049 [EC2 Query API] DescribeAvailabilityZones doesn't have any filter support.
CLOUDSTACK-1118

Support will be available for filters - zone-name and message
2013-02-07 18:25:21 -08:00
Likitha Shetty b97f468b03 CLOUDSTACK-1117 [EC2 Query API] DescribeImageAttribute fails
EC2DescribeImageAttribute fails with 'Unsupported - only description supported' error. And this is observed for both the supported attributes 'Description' and 'LaunchPermission'
2013-02-07 18:25:11 -08:00
Prachi Damle c92f1f9839 CLOUDSTACK-1116 [EC2 Query API] Support for ModifyImageAttribute and ResetImageAttribute
https://reviews.apache.org/r/9213

Add support for EC2 ApiI's ModifyImageAttribute and ResetImageAttribute.
Attributes supported are Description and LaunchPermission.
2013-02-07 17:42:27 -08:00
Kelven Yang 7bd8bec68a Sync javelin with master up to 894cb8f7d9 2013-01-31 17:20:19 -08:00
Likitha Shetty 64b00d0b34 [EC2 Query API] Remove the registration step since query API does not require the certificate
https://reviews.apache.org/r/8742/

While checking if the user keys exists and also while retrieving the secret-key for signature generation (Query API only), make a change to directly check in the 'cloud' DB instead of the 'cloudbridge' DB.
With this change user will not require to register the keys before making EC2 Query API calls against CS. The registration process to make EC2 SOAP API calls will remain the same.
2013-01-31 12:00:39 -08:00
Likitha Shetty f18828d7d8 [EC2 Query API] AttachVolume fails with 'Permission Denied: Invalid Signature' error.
https://reviews.apache.org/r/8480/

In AWSAPI while forming the signature to validate an API, url-encode every parameter name with UTF-8 encoding scheme.
2013-01-31 12:00:37 -08:00
Likitha Shetty 61f24d8a16 [EC2 Query API] RunInstance and DescribeInstances throw NumberFormatException error when called using AWS Java SDK
https://reviews.apache.org/r/8483/

AWS Java SDK doesn't expect a string value in the AmiLaunchIndex response element for RunInstances and DescribeInstances response.
2013-01-31 12:00:35 -08:00
Likitha Shetty d738c81a46 [EC2 Query API] DescribeAddresses fails with Null Pointer Exception.
https://reviews.apache.org/r/8492/

As a part of EC2 Query API support, resolve the NPE obtained when DescribeAddresses is called
In EC2Engine modify DescribeAddresses implementation to be consistent with the other Describe* API implementation
2013-01-31 12:00:32 -08:00
Likitha Shetty de517d95b0 [EC2 Query API] AuthorizeSecurityGroupIngress and RevokeSecurityGroupIngress return false even when the request is successful.
https://reviews.apache.org/r/8513

If the response is not null and if all the ruleid's(permissions) are present return true.
2013-01-31 12:00:30 -08:00
Likitha Shetty b514735c7b [EC2 Query API] AuthorizeSecurityGroupIngress fails with 'Server.InternalError 431 Invalid protocol' error.
https://reviews.apache.org/r/8468

Before making the AuthorizeSecurityGroupIngress CloudStack API call, parse the string arguments 'FromPort' and 'ToPort' as an integer.
2013-01-31 12:00:28 -08:00
Likitha Shetty bea669d091 [EC2 Query API] RevokeSecurityGroupIngress fails with 'EC2ResponseError'.
https://reviews.apache.org/r/8466/

[EC2 Query API] Provide DescribeKeyPairs Query API support in CS AWSAPI.
https://reviews.apache.org/r/8465/
2013-01-31 12:00:25 -08:00
Prachi Damle 3c75d53f2f more change to fix awsapi deployment with maven and jetty and Spring 2013-01-30 18:16:45 -08:00
Kelven Yang 526bb01b04 Fix awsapi issues in Spring wiring 2013-01-30 16:43:40 -08:00
Prachi Damle 4dc63f50a7 Spring hack for Ec2RestServlet 2013-01-30 15:56:56 -08:00
Kelven Yang 176523254e Improve component lifecycle management with system run-level concept 2013-01-30 15:21:02 -08:00
Kelven Yang da2e6461a6 Remove temporary hacking and use Official way to wire-up servlet with injection under Spring 2013-01-30 15:21:01 -08:00
Kelven Yang b5deb52fba Put a tempoary fix to awsapi to workaround an issue with jetty/Spring integration limitation 2013-01-28 17:45:16 -08:00
Prachi Damle 2bfdce02f1 Spring changes in awsapi 2013-01-28 16:01:50 -08:00
Alex Huang f40e7b7511 removed componentlocator and inject 2013-01-10 11:05:20 -08:00
Alex Huang 30f2565d98 Merge branch 'api_refactoring' into javelin 2013-01-08 12:36:04 -08:00
Hiroaki Kawai a28f4cac3c HttpClient needs releaseConnection method call
reviewboard: https://reviews.apache.org/r/8186/

Signed-off-by: Hugo Trippaers <trippie@gmail.com>
2012-11-29 20:23:30 +01:00
Hiroaki Kawai c8832cd4b6 Commit https://reviews.apache.org/r/8075/
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2012-11-19 12:02:26 +01:00
Kelven Yang cea8f3bf37 Switch inject annotation to javax and let ComponentLocator to recognize both the new and original inject annotation 2012-11-07 15:03:22 -08:00
Kelven Yang aab02e2743 Add Spring annotation to major components 2012-11-07 14:53:39 -08:00
Chip Childers 7090c10311 CLOUDSTACK-327: Correcting license header
Signed-off-by: Chip Childers <chip.childers@gmail.com>
2012-10-12 11:59:33 -04:00
Hugo Trippaers 3343362328 Better to print an error message than to die with a npe. 2012-10-02 07:35:10 -07:00
Hugo Trippaers 28bfaea0d1 Fix some dependencies for awsapi. Axis2 and rampart versions should be
equal otherwise there will be conflicts with dependencies.

Small change to EC2MainServlet, pass along the rootcause for easier
debugging
2012-10-01 21:36:27 -07:00
Chip Childers 8746e902e4 CLOUDSTACK-56 : fixing license headers 2012-09-07 17:03:53 -04:00
Jamshid Afshar 5d208a5c95 Add initial support for Caringo CAStor object store as backing store for S3 API
Signed-off-by: Chiradeep Vittal <chiradeep@apache.org>
2012-09-05 23:35:09 -07:00
Rajesh Battala 39aa7d86af Moved Awsapi (EC2/S3) from Hibernate framework to CloudStack Generic Dao Framework
Created/Modified new VO's and Dao Impl classes to use Generic Dao Framework
2012-08-31 11:44:58 -07:00
Likitha Shetty 8c3450b503 CS-14770. ec2-run-instances and ec2-describe-instances don't return keypair information. Component: AWSAPI. 2012-08-28 13:52:42 -07:00
Likitha Shetty fef8f6d4af CS-15703: EC2 tag support, improve error handling. Component: AWSAPI.
Handle exceptions thrown when invalid syntax is used to create or delete tags.
2012-08-27 15:56:13 -07:00
Mice Xia 1894fb56cf Remove @author tag from non third-party source files in awsapi folder 2012-08-13 14:59:31 +08:00
Chip Childers 3cbc0e324f awsapi license header changes 2012-08-01 09:34:12 -04:00
Likitha Shetty 11f5bd25f8 CS-15145: Summary: ec2-register: need better error handling for negative cases.
The negative cases for which the error handling is improved,
1. run ec2-register with incorrect field separator for architecture parameter.
2. run ec2-register without providing required parameters.
2012-07-23 15:46:03 -07:00
Likitha Shetty 59462cd825 Modifying filter support in 3 EC2 Describe* API's(DescribeInstances, DescribeVolumes and DescribeSnapshots) to include tags. Component: AWSAPI.
Tags support has been added to 3 EC2Describe* API's(DescribeInstances, DescribeVolumes and DescribeSnapshots). Hence for the same 3 EC2Describe* API's filter support has been modified to included 3 tag related filters: tag-key,
tag-value and tag:key.
2012-07-23 15:24:41 -07:00
Likitha Shetty aef09e1b20 Adding tags support to the 4 EC2 Describe* API's (DescribeImages, DescribeInstances, DescribeVolumes, DescribeSnapshots) in AWSAPI
- List* APIs in CloudStack have tags support. Adding the corresponding support to EC2Decsribe* APIs in the AWSAPI component.
2012-07-23 15:22:38 -07:00
Likitha Shetty c60e4b4a9e Adding support in AWSAPI for CloudStack API's that implement the tags feature.
Verified the output of,
1. ec2-create-tags for all 4 supported ec2 resources(image, instance, volume and snapshot) with and without tag-value.
2. ec2-delete-tags for all types of created tags.
3. ec2-describe-tags with and without all supported filter.
2012-07-23 11:31:17 -07:00
Likitha Shetty 8d38f4e051 CS-15167: AWS API calls do not honor the "admin" accounts ability to view/act on the resources owned by regular users. 2012-07-06 16:00:27 -07:00
Hugo Trippaers 6cc8896f96 package statement was removed during a license update 2012-07-06 10:03:51 -04:00
David Nalley 5c3a8cd490 more license header cleanups 2012-07-04 21:41:50 -04:00